ext2: Fix fs corruption in ext2_get_xip_mem()
authorJan Kara <jack@suse.cz>
Tue, 5 Nov 2013 00:15:38 +0000 (01:15 +0100)
committerJan Kara <jack@suse.cz>
Tue, 5 Nov 2013 10:26:47 +0000 (11:26 +0100)
commit7ba3ec5749ddb61f79f7be17b5fd7720eebc52de
tree01b2ff745122e12632c17142ce72748336886b03
parent18da65e7d30a76ab3ca0ccd2b7ca0690f80f28e4
ext2: Fix fs corruption in ext2_get_xip_mem()

Commit 8e3dffc651cb "Ext2: mark inode dirty after the function
dquot_free_block_nodirty is called" unveiled a bug in __ext2_get_block()
called from ext2_get_xip_mem(). That function called ext2_get_block()
mistakenly asking it to map 0 blocks while 1 was intended. Before the
above mentioned commit things worked out fine by luck but after that commit
we started returning that we allocated 0 blocks while we in fact
allocated 1 block and thus allocation was looping until all blocks in
the filesystem were exhausted.

Fix the problem by properly asking for one block and also add assertion
in ext2_get_blocks() to catch similar problems.

Reported-and-tested-by: Andiry Xu <andiry.xu@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext2/inode.c
fs/ext2/xip.c