sched: fix __sched_setscheduler() vs load balancing race
authorMike Galbraith <umgwanakikbuti@gmail.com>
Wed, 17 Feb 2016 03:02:59 +0000 (04:02 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 27 Feb 2016 14:28:49 +0000 (14:28 +0000)
commit34bce1998711e65b8a7ef37eb92641cdc368587a
tree239a217a5e90727d57dbcf6a428ea12a3d3a330f
parentfeae3ca2e5e1a8f44aa6290255d3d9709985d0b2
sched: fix __sched_setscheduler() vs load balancing race

__sched_setscheduler() may release rq->lock in pull_rt_task() as a task is
being changed rt -> fair class.  load balancing may sneak in, move the task
behind __sched_setscheduler()'s back, which explodes in switched_to_fair()
when the passed but no longer valid rq is used.  Tell can_migrate_task() to
say no if ->pi_lock is held.

@stable: Kernels that predate SCHED_DEADLINE can use this simple (and tested)
check in lieu of backport of the full 18 patch mainline treatment.

Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
[bwh: Backported to 3.2:
 - Adjust numbering in the comment
 - Adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Willy Tarreau <w@1wt.eu>
kernel/sched_fair.c