ALSA: timer: Fix double unlink of active_list
authorTakashi Iwai <tiwai@suse.de>
Wed, 13 Jan 2016 20:35:06 +0000 (21:35 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 13 Feb 2016 10:34:09 +0000 (10:34 +0000)
commit0e8f916d7dc9170ab2ef4b9a9ed19b640720029b
tree5bcd6dda0ca0f8c8f4d4d0ed8cba975231a49450
parente68624cb8e984efcfa95dd016e92fb67f325fd66
ALSA: timer: Fix double unlink of active_list

commit ee8413b01045c74340aa13ad5bdf905de32be736 upstream.

ALSA timer instance object has a couple of linked lists and they are
unlinked unconditionally at snd_timer_stop().  Meanwhile
snd_timer_interrupt() unlinks it, but it calls list_del() which leaves
the element list itself unchanged.  This ends up with unlinking twice,
and it was caught by syzkaller fuzzer.

The fix is to use list_del_init() variant properly there, too.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Tested-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/core/timer.c