xfrm_user: validate XFRM_MSG_NEWAE incoming ESN size harder

[pandora-kernel.git] / net / xfrm / xfrm_user.c

diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index a0daa32..bd26a97 100644 (file)
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -390,7 +390,11 @@ static inline int xfrm_replay_verify_len(struct xfrm_replay_state_esn *replay_es
        up = nla_data(rp);
        ulen = xfrm_replay_state_esn_len(up);
 
        up = nla_data(rp);
        ulen = xfrm_replay_state_esn_len(up);
 

-       if (nla_len(rp) < ulen || xfrm_replay_state_esn_len(replay_esn) != ulen)
+       /* Check the overall length and the internal bitmap length to avoid
+        * potential overflow. */
+       if (nla_len(rp) < ulen ||
+           xfrm_replay_state_esn_len(replay_esn) != ulen ||
+           replay_esn->bmp_len != up->bmp_len)

                return -EINVAL;
 
        if (up->replay_window > up->bmp_len * sizeof(__u32) * 8)
                return -EINVAL;
 
        if (up->replay_window > up->bmp_len * sizeof(__u32) * 8)