cfg80211: rename regdom_changed to regdom_changes() and use it
[pandora-kernel.git] / net / wireless / reg.c
index 85c9034..3bd2ea2 100644 (file)
 #include "core.h"
 #include "reg.h"
 
-/**
- * struct regulatory_request - receipt of last regulatory request
- *
- * @wiphy: this is set if this request's initiator is
- *     %REGDOM_SET_BY_COUNTRY_IE or %REGDOM_SET_BY_DRIVER. This
- *     can be used by the wireless core to deal with conflicts
- *     and potentially inform users of which devices specifically
- *     cased the conflicts.
- * @initiator: indicates who sent this request, could be any of
- *     of those set in reg_set_by, %REGDOM_SET_BY_*
- * @alpha2: the ISO / IEC 3166 alpha2 country code of the requested
- *     regulatory domain. We have a few special codes:
- *     00 - World regulatory domain
- *     99 - built by driver but a specific alpha2 cannot be determined
- *     98 - result of an intersection between two regulatory domains
- * @intersect: indicates whether the wireless core should intersect
- *     the requested regulatory domain with the presently set regulatory
- *     domain.
- * @country_ie_checksum: checksum of the last processed and accepted
- *     country IE
- * @country_ie_env: lets us know if the AP is telling us we are outdoor,
- *     indoor, or if it doesn't matter
- */
-struct regulatory_request {
-       struct wiphy *wiphy;
-       enum reg_set_by initiator;
-       char alpha2[2];
-       bool intersect;
-       u32 country_ie_checksum;
-       enum environment_cap country_ie_env;
-};
-
 /* Receipt of information from last regulatory request */
 static struct regulatory_request *last_request;
 
@@ -86,16 +54,23 @@ static u32 supported_bandwidths[] = {
        MHZ_TO_KHZ(20),
 };
 
-/* Central wireless core regulatory domains, we only need two,
+/*
+ * Central wireless core regulatory domains, we only need two,
  * the current one and a world regulatory domain in case we have no
- * information to give us an alpha2 */
-static const struct ieee80211_regdomain *cfg80211_regdomain;
+ * information to give us an alpha2
+ */
+const struct ieee80211_regdomain *cfg80211_regdomain;
 
-/* We use this as a place for the rd structure built from the
+/*
+ * We use this as a place for the rd structure built from the
  * last parsed country IE to rest until CRDA gets back to us with
- * what it thinks should apply for the same country */
+ * what it thinks should apply for the same country
+ */
 static const struct ieee80211_regdomain *country_ie_regdomain;
 
+static LIST_HEAD(reg_requests_list);
+static spinlock_t reg_requests_lock;
+
 /* We keep a static world regulatory domain in case of the absence of CRDA */
 static const struct ieee80211_regdomain world_regdom = {
        .n_reg_rules = 1,
@@ -115,9 +90,11 @@ static char *ieee80211_regdom = "US";
 module_param(ieee80211_regdom, charp, 0444);
 MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain code");
 
-/* We assume 40 MHz bandwidth for the old regulatory work.
+/*
+ * We assume 40 MHz bandwidth for the old regulatory work.
  * We make emphasis we are using the exact same frequencies
- * as before */
+ * as before
+ */
 
 static const struct ieee80211_regdomain us_regdom = {
        .n_reg_rules = 6,
@@ -156,8 +133,10 @@ static const struct ieee80211_regdomain jp_regdom = {
 
 static const struct ieee80211_regdomain eu_regdom = {
        .n_reg_rules = 6,
-       /* This alpha2 is bogus, we leave it here just for stupid
-        * backward compatibility */
+       /*
+        * This alpha2 is bogus, we leave it here just for stupid
+        * backward compatibility
+        */
        .alpha2 =  "EU",
        .reg_rules = {
                /* IEEE 802.11b/g, channels 1..13 */
@@ -226,8 +205,10 @@ static void reset_regdomains(void)
        cfg80211_regdomain = NULL;
 }
 
-/* Dynamic world regulatory domain requested by the wireless
- * core upon initialization */
+/*
+ * Dynamic world regulatory domain requested by the wireless
+ * core upon initialization
+ */
 static void update_world_regdomain(const struct ieee80211_regdomain *rd)
 {
        BUG_ON(!last_request);
@@ -268,8 +249,10 @@ static bool is_unknown_alpha2(const char *alpha2)
 {
        if (!alpha2)
                return false;
-       /* Special case where regulatory domain was built by driver
-        * but a specific alpha2 cannot be determined */
+       /*
+        * Special case where regulatory domain was built by driver
+        * but a specific alpha2 cannot be determined
+        */
        if (alpha2[0] == '9' && alpha2[1] == '9')
                return true;
        return false;
@@ -279,9 +262,11 @@ static bool is_intersected_alpha2(const char *alpha2)
 {
        if (!alpha2)
                return false;
-       /* Special case where regulatory domain is the
+       /*
+        * Special case where regulatory domain is the
         * result of an intersection between two regulatory domain
-        * structures */
+        * structures
+        */
        if (alpha2[0] == '9' && alpha2[1] == '8')
                return true;
        return false;
@@ -306,8 +291,10 @@ static bool alpha2_equal(const char *alpha2_x, const char *alpha2_y)
        return false;
 }
 
-static bool regdom_changed(const char *alpha2)
+static bool regdom_changes(const char *alpha2)
 {
+       assert_cfg80211_lock();
+
        if (!cfg80211_regdomain)
                return true;
        if (alpha2_equal(cfg80211_regdomain->alpha2, alpha2))
@@ -334,8 +321,10 @@ static bool country_ie_integrity_changes(u32 checksum)
        return false;
 }
 
-/* This lets us keep regulatory code which is updated on a regulatory
- * basis in userspace. */
+/*
+ * This lets us keep regulatory code which is updated on a regulatory
+ * basis in userspace.
+ */
 static int call_crda(const char *alpha2)
 {
        char country_env[9 + 2] = "COUNTRY=";
@@ -446,10 +435,12 @@ static bool freq_in_rule_band(const struct ieee80211_freq_range *freq_range,
 #undef ONE_GHZ_IN_KHZ
 }
 
-/* Converts a country IE to a regulatory domain. A regulatory domain
+/*
+ * Converts a country IE to a regulatory domain. A regulatory domain
  * structure has a lot of information which the IE doesn't yet have,
  * so for the other values we use upper max values as we will intersect
- * with our userspace regulatory agent to get lower bounds. */
+ * with our userspace regulatory agent to get lower bounds.
+ */
 static struct ieee80211_regdomain *country_ie_2_rd(
                                u8 *country_ie,
                                u8 country_ie_len,
@@ -494,9 +485,11 @@ static struct ieee80211_regdomain *country_ie_2_rd(
 
        *checksum ^= ((flags ^ alpha2[0] ^ alpha2[1]) << 8);
 
-       /* We need to build a reg rule for each triplet, but first we must
+       /*
+        * We need to build a reg rule for each triplet, but first we must
         * calculate the number of reg rules we will need. We will need one
-        * for each channel subband */
+        * for each channel subband
+        */
        while (country_ie_len >= 3) {
                int end_channel = 0;
                struct ieee80211_country_ie_triplet *triplet =
@@ -534,9 +527,11 @@ static struct ieee80211_regdomain *country_ie_2_rd(
                if (cur_sub_max_channel < cur_channel)
                        return NULL;
 
-               /* Do not allow overlapping channels. Also channels
+               /*
+                * Do not allow overlapping channels. Also channels
                 * passed in each subband must be monotonically
-                * increasing */
+                * increasing
+                */
                if (last_sub_max_channel) {
                        if (cur_channel <= last_sub_max_channel)
                                return NULL;
@@ -544,10 +539,12 @@ static struct ieee80211_regdomain *country_ie_2_rd(
                                return NULL;
                }
 
-               /* When dot11RegulatoryClassesRequired is supported
+               /*
+                * When dot11RegulatoryClassesRequired is supported
                 * we can throw ext triplets as part of this soup,
                 * for now we don't care when those change as we
-                * don't support them */
+                * don't support them
+                */
                *checksum ^= ((cur_channel ^ cur_sub_max_channel) << 8) |
                  ((cur_sub_max_channel ^ cur_sub_max_channel) << 16) |
                  ((triplet->chans.max_power ^ cur_sub_max_channel) << 24);
@@ -558,8 +555,10 @@ static struct ieee80211_regdomain *country_ie_2_rd(
                country_ie_len -= 3;
                num_rules++;
 
-               /* Note: this is not a IEEE requirement but
-                * simply a memory requirement */
+               /*
+                * Note: this is not a IEEE requirement but
+                * simply a memory requirement
+                */
                if (num_rules > NL80211_MAX_SUPP_REG_RULES)
                        return NULL;
        }
@@ -587,8 +586,10 @@ static struct ieee80211_regdomain *country_ie_2_rd(
                struct ieee80211_freq_range *freq_range = NULL;
                struct ieee80211_power_rule *power_rule = NULL;
 
-               /* Must parse if dot11RegulatoryClassesRequired is true,
-                * we don't support this yet */
+               /*
+                * Must parse if dot11RegulatoryClassesRequired is true,
+                * we don't support this yet
+                */
                if (triplet->ext.reg_extension_id >=
                                IEEE80211_COUNTRY_EXTENSION_ID) {
                        country_ie += 3;
@@ -610,10 +611,12 @@ static struct ieee80211_regdomain *country_ie_2_rd(
                        end_channel =  triplet->chans.first_channel +
                                (4 * (triplet->chans.num_channels - 1));
 
-               /* The +10 is since the regulatory domain expects
+               /*
+                * The +10 is since the regulatory domain expects
                 * the actual band edge, not the center of freq for
                 * its start and end freqs, assuming 20 MHz bandwidth on
-                * the channels passed */
+                * the channels passed
+                */
                freq_range->start_freq_khz =
                        MHZ_TO_KHZ(ieee80211_channel_to_frequency(
                                triplet->chans.first_channel) - 10);
@@ -621,9 +624,11 @@ static struct ieee80211_regdomain *country_ie_2_rd(
                        MHZ_TO_KHZ(ieee80211_channel_to_frequency(
                                end_channel) + 10);
 
-               /* Large arbitrary values, we intersect later */
-               /* Increment this if we ever support >= 40 MHz channels
-                * in IEEE 802.11 */
+               /*
+                * These are large arbitrary values we use to intersect later.
+                * Increment this if we ever support >= 40 MHz channels
+                * in IEEE 802.11
+                */
                freq_range->max_bandwidth_khz = MHZ_TO_KHZ(40);
                power_rule->max_antenna_gain = DBI_TO_MBI(100);
                power_rule->max_eirp = DBM_TO_MBM(100);
@@ -639,8 +644,10 @@ static struct ieee80211_regdomain *country_ie_2_rd(
 }
 
 
-/* Helper for regdom_intersect(), this does the real
- * mathematical intersection fun */
+/*
+ * Helper for regdom_intersect(), this does the real
+ * mathematical intersection fun
+ */
 static int reg_rules_intersect(
        const struct ieee80211_reg_rule *rule1,
        const struct ieee80211_reg_rule *rule2,
@@ -718,11 +725,13 @@ static struct ieee80211_regdomain *regdom_intersect(
        if (!rd1 || !rd2)
                return NULL;
 
-       /* First we get a count of the rules we'll need, then we actually
+       /*
+        * First we get a count of the rules we'll need, then we actually
         * build them. This is to so we can malloc() and free() a
         * regdomain once. The reason we use reg_rules_intersect() here
         * is it will return -EINVAL if the rule computed makes no sense.
-        * All rules that do check out OK are valid. */
+        * All rules that do check out OK are valid.
+        */
 
        for (x = 0; x < rd1->n_reg_rules; x++) {
                rule1 = &rd1->reg_rules[x];
@@ -750,14 +759,18 @@ static struct ieee80211_regdomain *regdom_intersect(
                rule1 = &rd1->reg_rules[x];
                for (y = 0; y < rd2->n_reg_rules; y++) {
                        rule2 = &rd2->reg_rules[y];
-                       /* This time around instead of using the stack lets
+                       /*
+                        * This time around instead of using the stack lets
                         * write to the target rule directly saving ourselves
-                        * a memcpy() */
+                        * a memcpy()
+                        */
                        intersected_rule = &rd->reg_rules[rule_idx];
                        r = reg_rules_intersect(rule1, rule2,
                                intersected_rule);
-                       /* No need to memset here the intersected rule here as
-                        * we're not using the stack anymore */
+                       /*
+                        * No need to memset here the intersected rule here as
+                        * we're not using the stack anymore
+                        */
                        if (r)
                                continue;
                        rule_idx++;
@@ -776,8 +789,10 @@ static struct ieee80211_regdomain *regdom_intersect(
        return rd;
 }
 
-/* XXX: add support for the rest of enum nl80211_reg_rule_flags, we may
- * want to just have the channel structure use these */
+/*
+ * XXX: add support for the rest of enum nl80211_reg_rule_flags, we may
+ * want to just have the channel structure use these
+ */
 static u32 map_regdom_flags(u32 rd_flags)
 {
        u32 channel_flags = 0;
@@ -790,48 +805,45 @@ static u32 map_regdom_flags(u32 rd_flags)
        return channel_flags;
 }
 
-/**
- * freq_reg_info - get regulatory information for the given frequency
- * @center_freq: Frequency in KHz for which we want regulatory information for
- * @bandwidth: the bandwidth requirement you have in KHz, if you do not have one
- *     you can set this to 0. If this frequency is allowed we then set
- *     this value to the maximum allowed bandwidth.
- * @reg_rule: the regulatory rule which we have for this frequency
- *
- * Use this function to get the regulatory rule for a specific frequency on
- * a given wireless device. If the device has a specific regulatory domain
- * it wants to follow we respect that unless a country IE has been received
- * and processed already.
- *
- * Returns 0 if it was able to find a valid regulatory rule which does
- * apply to the given center_freq otherwise it returns non-zero. It will
- * also return -ERANGE if we determine the given center_freq does not even have
- * a regulatory rule for a frequency range in the center_freq's band. See
- * freq_in_rule_band() for our current definition of a band -- this is purely
- * subjective and right now its 802.11 specific.
- */
-static int freq_reg_info(u32 center_freq, u32 *bandwidth,
-                        const struct ieee80211_reg_rule **reg_rule)
+static int freq_reg_info_regd(struct wiphy *wiphy,
+                             u32 center_freq,
+                             u32 *bandwidth,
+                             const struct ieee80211_reg_rule **reg_rule,
+                             const struct ieee80211_regdomain *custom_regd)
 {
        int i;
        bool band_rule_found = false;
+       const struct ieee80211_regdomain *regd;
        u32 max_bandwidth = 0;
 
-       if (!cfg80211_regdomain)
+       regd = custom_regd ? custom_regd : cfg80211_regdomain;
+
+       /*
+        * Follow the driver's regulatory domain, if present, unless a country
+        * IE has been processed or a user wants to help complaince further
+        */
+       if (last_request->initiator != REGDOM_SET_BY_COUNTRY_IE &&
+           last_request->initiator != REGDOM_SET_BY_USER &&
+           wiphy->regd)
+               regd = wiphy->regd;
+
+       if (!regd)
                return -EINVAL;
 
-       for (i = 0; i < cfg80211_regdomain->n_reg_rules; i++) {
+       for (i = 0; i < regd->n_reg_rules; i++) {
                const struct ieee80211_reg_rule *rr;
                const struct ieee80211_freq_range *fr = NULL;
                const struct ieee80211_power_rule *pr = NULL;
 
-               rr = &cfg80211_regdomain->reg_rules[i];
+               rr = &regd->reg_rules[i];
                fr = &rr->freq_range;
                pr = &rr->power_rule;
 
-               /* We only need to know if one frequency rule was
+               /*
+                * We only need to know if one frequency rule was
                 * was in center_freq's band, that's enough, so lets
-                * not overwrite it once found */
+                * not overwrite it once found
+                */
                if (!band_rule_found)
                        band_rule_found = freq_in_rule_band(fr, center_freq);
 
@@ -849,6 +861,14 @@ static int freq_reg_info(u32 center_freq, u32 *bandwidth,
 
        return !max_bandwidth;
 }
+EXPORT_SYMBOL(freq_reg_info);
+
+int freq_reg_info(struct wiphy *wiphy, u32 center_freq, u32 *bandwidth,
+                        const struct ieee80211_reg_rule **reg_rule)
+{
+       return freq_reg_info_regd(wiphy, center_freq,
+               bandwidth, reg_rule, NULL);
+}
 
 static void handle_channel(struct wiphy *wiphy, enum ieee80211_band band,
                           unsigned int chan_idx)
@@ -860,6 +880,11 @@ static void handle_channel(struct wiphy *wiphy, enum ieee80211_band band,
        const struct ieee80211_power_rule *power_rule = NULL;
        struct ieee80211_supported_band *sband;
        struct ieee80211_channel *chan;
+       struct wiphy *request_wiphy = NULL;
+
+       assert_cfg80211_lock();
+
+       request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);
 
        sband = wiphy->bands[band];
        BUG_ON(chan_idx >= sband->n_channels);
@@ -867,11 +892,12 @@ static void handle_channel(struct wiphy *wiphy, enum ieee80211_band band,
 
        flags = chan->orig_flags;
 
-       r = freq_reg_info(MHZ_TO_KHZ(chan->center_freq),
+       r = freq_reg_info(wiphy, MHZ_TO_KHZ(chan->center_freq),
                &max_bandwidth, &reg_rule);
 
        if (r) {
-               /* This means no regulatory rule was found in the country IE
+               /*
+                * This means no regulatory rule was found in the country IE
                 * with a frequency range on the center_freq's band, since
                 * IEEE-802.11 allows for a country IE to have a subset of the
                 * regulatory information provided in a country we ignore
@@ -890,8 +916,10 @@ static void handle_channel(struct wiphy *wiphy, enum ieee80211_band band,
                                chan->center_freq, wiphy_name(wiphy));
 #endif
                } else {
-               /* In this case we know the country IE has at least one reg rule
-                * for the band so we respect its band definitions */
+               /*
+                * In this case we know the country IE has at least one reg rule
+                * for the band so we respect its band definitions
+                */
 #ifdef CONFIG_CFG80211_REG_DEBUG
                        if (last_request->initiator == REGDOM_SET_BY_COUNTRY_IE)
                                printk(KERN_DEBUG "cfg80211: Disabling "
@@ -907,6 +935,24 @@ static void handle_channel(struct wiphy *wiphy, enum ieee80211_band band,
 
        power_rule = &reg_rule->power_rule;
 
+       if (last_request->initiator == REGDOM_SET_BY_DRIVER &&
+           request_wiphy && request_wiphy == wiphy &&
+           request_wiphy->strict_regulatory) {
+               /*
+                * This gaurantees the driver's requested regulatory domain
+                * will always be used as a base for further regulatory
+                * settings
+                */
+               chan->flags = chan->orig_flags =
+                       map_regdom_flags(reg_rule->flags);
+               chan->max_antenna_gain = chan->orig_mag =
+                       (int) MBI_TO_DBI(power_rule->max_antenna_gain);
+               chan->max_bandwidth = KHZ_TO_MHZ(max_bandwidth);
+               chan->max_power = chan->orig_mpwr =
+                       (int) MBM_TO_DBM(power_rule->max_eirp);
+               return;
+       }
+
        chan->flags = flags | map_regdom_flags(reg_rule->flags);
        chan->max_antenna_gain = min(chan->orig_mag,
                (int) MBI_TO_DBI(power_rule->max_antenna_gain));
@@ -935,7 +981,14 @@ static bool ignore_reg_update(struct wiphy *wiphy, enum reg_set_by setby)
        if (!last_request)
                return true;
        if (setby == REGDOM_SET_BY_CORE &&
-                 wiphy->fw_handles_regulatory)
+                 wiphy->custom_regulatory)
+               return true;
+       /*
+        * wiphy->regd will be set once the device has its own
+        * desired regulatory domain set
+        */
+       if (wiphy->strict_regulatory && !wiphy->regd &&
+           !is_world_regdom(last_request->alpha2))
                return true;
        return false;
 }
@@ -945,23 +998,108 @@ static void update_all_wiphy_regulatory(enum reg_set_by setby)
        struct cfg80211_registered_device *drv;
 
        list_for_each_entry(drv, &cfg80211_drv_list, list)
-               if (!ignore_reg_update(&drv->wiphy, setby))
-                       wiphy_update_regulatory(&drv->wiphy, setby);
+               wiphy_update_regulatory(&drv->wiphy, setby);
 }
 
 void wiphy_update_regulatory(struct wiphy *wiphy, enum reg_set_by setby)
 {
        enum ieee80211_band band;
+
+       if (ignore_reg_update(wiphy, setby))
+               return;
        for (band = 0; band < IEEE80211_NUM_BANDS; band++) {
                if (wiphy->bands[band])
                        handle_band(wiphy, band);
-               if (wiphy->reg_notifier)
-                       wiphy->reg_notifier(wiphy, setby);
        }
+       if (wiphy->reg_notifier)
+               wiphy->reg_notifier(wiphy, last_request);
+}
+
+static void handle_channel_custom(struct wiphy *wiphy,
+                                 enum ieee80211_band band,
+                                 unsigned int chan_idx,
+                                 const struct ieee80211_regdomain *regd)
+{
+       int r;
+       u32 max_bandwidth = 0;
+       const struct ieee80211_reg_rule *reg_rule = NULL;
+       const struct ieee80211_power_rule *power_rule = NULL;
+       struct ieee80211_supported_band *sband;
+       struct ieee80211_channel *chan;
+
+       sband = wiphy->bands[band];
+       BUG_ON(chan_idx >= sband->n_channels);
+       chan = &sband->channels[chan_idx];
+
+       r = freq_reg_info_regd(wiphy, MHZ_TO_KHZ(chan->center_freq),
+               &max_bandwidth, &reg_rule, regd);
+
+       if (r) {
+               chan->flags = IEEE80211_CHAN_DISABLED;
+               return;
+       }
+
+       power_rule = &reg_rule->power_rule;
+
+       chan->flags |= map_regdom_flags(reg_rule->flags);
+       chan->max_antenna_gain = (int) MBI_TO_DBI(power_rule->max_antenna_gain);
+       chan->max_bandwidth = KHZ_TO_MHZ(max_bandwidth);
+       chan->max_power = (int) MBM_TO_DBM(power_rule->max_eirp);
+}
+
+static void handle_band_custom(struct wiphy *wiphy, enum ieee80211_band band,
+                              const struct ieee80211_regdomain *regd)
+{
+       unsigned int i;
+       struct ieee80211_supported_band *sband;
+
+       BUG_ON(!wiphy->bands[band]);
+       sband = wiphy->bands[band];
+
+       for (i = 0; i < sband->n_channels; i++)
+               handle_channel_custom(wiphy, band, i, regd);
+}
+
+/* Used by drivers prior to wiphy registration */
+void wiphy_apply_custom_regulatory(struct wiphy *wiphy,
+                                  const struct ieee80211_regdomain *regd)
+{
+       enum ieee80211_band band;
+       for (band = 0; band < IEEE80211_NUM_BANDS; band++) {
+               if (wiphy->bands[band])
+                       handle_band_custom(wiphy, band, regd);
+       }
+}
+EXPORT_SYMBOL(wiphy_apply_custom_regulatory);
+
+static int reg_copy_regd(const struct ieee80211_regdomain **dst_regd,
+                        const struct ieee80211_regdomain *src_regd)
+{
+       struct ieee80211_regdomain *regd;
+       int size_of_regd = 0;
+       unsigned int i;
+
+       size_of_regd = sizeof(struct ieee80211_regdomain) +
+         ((src_regd->n_reg_rules + 1) * sizeof(struct ieee80211_reg_rule));
+
+       regd = kzalloc(size_of_regd, GFP_KERNEL);
+       if (!regd)
+               return -ENOMEM;
+
+       memcpy(regd, src_regd, sizeof(struct ieee80211_regdomain));
+
+       for (i = 0; i < src_regd->n_reg_rules; i++)
+               memcpy(&regd->reg_rules[i], &src_regd->reg_rules[i],
+                       sizeof(struct ieee80211_reg_rule));
+
+       *dst_regd = regd;
+       return 0;
 }
 
-/* Return value which can be used by ignore_request() to indicate
- * it has been determined we should intersect two regulatory domains */
+/*
+ * Return value which can be used by ignore_request() to indicate
+ * it has been determined we should intersect two regulatory domains
+ */
 #define REG_INTERSECT  1
 
 /* This has the logic which determines when a new request
@@ -969,6 +1107,10 @@ void wiphy_update_regulatory(struct wiphy *wiphy, enum reg_set_by setby)
 static int ignore_request(struct wiphy *wiphy, enum reg_set_by set_by,
                          const char *alpha2)
 {
+       struct wiphy *last_wiphy = NULL;
+
+       assert_cfg80211_lock();
+
        /* All initial requests are respected */
        if (!last_request)
                return 0;
@@ -977,54 +1119,85 @@ static int ignore_request(struct wiphy *wiphy, enum reg_set_by set_by,
        case REGDOM_SET_BY_INIT:
                return -EINVAL;
        case REGDOM_SET_BY_CORE:
-               /*
-                * Always respect new wireless core hints, should only happen
-                * when updating the world regulatory domain at init.
-                */
-               return 0;
+               return -EINVAL;
        case REGDOM_SET_BY_COUNTRY_IE:
+
+               last_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);
+
                if (unlikely(!is_an_alpha2(alpha2)))
                        return -EINVAL;
                if (last_request->initiator == REGDOM_SET_BY_COUNTRY_IE) {
-                       if (last_request->wiphy != wiphy) {
+                       if (last_wiphy != wiphy) {
                                /*
                                 * Two cards with two APs claiming different
                                 * different Country IE alpha2s. We could
                                 * intersect them, but that seems unlikely
                                 * to be correct. Reject second one for now.
                                 */
-                               if (!alpha2_equal(alpha2,
-                                                 cfg80211_regdomain->alpha2))
+                               if (regdom_changes(alpha2))
                                        return -EOPNOTSUPP;
                                return -EALREADY;
                        }
-                       /* Two consecutive Country IE hints on the same wiphy.
-                        * This should be picked up early by the driver/stack */
-                       if (WARN_ON(!alpha2_equal(cfg80211_regdomain->alpha2,
-                                 alpha2)))
+                       /*
+                        * Two consecutive Country IE hints on the same wiphy.
+                        * This should be picked up early by the driver/stack
+                        */
+                       if (WARN_ON(regdom_changes(alpha2)))
                                return 0;
                        return -EALREADY;
                }
                return REG_INTERSECT;
        case REGDOM_SET_BY_DRIVER:
-               if (last_request->initiator == REGDOM_SET_BY_DRIVER)
+               if (last_request->initiator == REGDOM_SET_BY_CORE) {
+                       if (is_old_static_regdom(cfg80211_regdomain))
+                               return 0;
+                       if (regdom_changes(alpha2))
+                               return 0;
                        return -EALREADY;
-               return 0;
+               }
+
+               /*
+                * This would happen if you unplug and plug your card
+                * back in or if you add a new device for which the previously
+                * loaded card also agrees on the regulatory domain.
+                */
+               if (last_request->initiator == REGDOM_SET_BY_DRIVER &&
+                   !regdom_changes(alpha2))
+                       return -EALREADY;
+
+               return REG_INTERSECT;
        case REGDOM_SET_BY_USER:
                if (last_request->initiator == REGDOM_SET_BY_COUNTRY_IE)
                        return REG_INTERSECT;
-               /* If the user knows better the user should set the regdom
-                * to their country before the IE is picked up */
+               /*
+                * If the user knows better the user should set the regdom
+                * to their country before the IE is picked up
+                */
                if (last_request->initiator == REGDOM_SET_BY_USER &&
                          last_request->intersect)
                        return -EOPNOTSUPP;
+               /*
+                * Process user requests only after previous user/driver/core
+                * requests have been processed
+                */
+               if (last_request->initiator == REGDOM_SET_BY_CORE ||
+                   last_request->initiator == REGDOM_SET_BY_DRIVER ||
+                   last_request->initiator == REGDOM_SET_BY_USER) {
+                       if (regdom_changes(last_request->alpha2))
+                               return -EAGAIN;
+               }
+
+               if (!is_old_static_regdom(cfg80211_regdomain) &&
+                   !regdom_changes(alpha2))
+                       return -EALREADY;
+
                return 0;
        }
 
        return -EINVAL;
 }
 
-/* Caller must hold &cfg80211_drv_mutex */
+/* Caller must hold &cfg80211_mutex */
 int __regulatory_hint(struct wiphy *wiphy, enum reg_set_by set_by,
                        const char *alpha2,
                        u32 country_ie_checksum,
@@ -1034,13 +1207,34 @@ int __regulatory_hint(struct wiphy *wiphy, enum reg_set_by set_by,
        bool intersect = false;
        int r = 0;
 
+       assert_cfg80211_lock();
+
        r = ignore_request(wiphy, set_by, alpha2);
 
-       if (r == REG_INTERSECT)
+       if (r == REG_INTERSECT) {
+               if (set_by == REGDOM_SET_BY_DRIVER) {
+                       r = reg_copy_regd(&wiphy->regd, cfg80211_regdomain);
+                       if (r)
+                               return r;
+               }
                intersect = true;
-       else if (r)
+       } else if (r) {
+               /*
+                * If the regulatory domain being requested by the
+                * driver has already been set just copy it to the
+                * wiphy
+                */
+               if (r == -EALREADY && set_by == REGDOM_SET_BY_DRIVER) {
+                       r = reg_copy_regd(&wiphy->regd, cfg80211_regdomain);
+                       if (r)
+                               return r;
+                       r = -EALREADY;
+                       goto new_request;
+               }
                return r;
+       }
 
+new_request:
        request = kzalloc(sizeof(struct regulatory_request),
                          GFP_KERNEL);
        if (!request)
@@ -1049,13 +1243,18 @@ int __regulatory_hint(struct wiphy *wiphy, enum reg_set_by set_by,
        request->alpha2[0] = alpha2[0];
        request->alpha2[1] = alpha2[1];
        request->initiator = set_by;
-       request->wiphy = wiphy;
+       request->wiphy_idx = get_wiphy_idx(wiphy);
        request->intersect = intersect;
        request->country_ie_checksum = country_ie_checksum;
        request->country_ie_env = env;
 
        kfree(last_request);
        last_request = request;
+
+       /* When r == REG_INTERSECT we do need to call CRDA */
+       if (r < 0)
+               return r;
+
        /*
         * Note: When CONFIG_WIRELESS_OLD_REGULATORY is enabled
         * AND if CRDA is NOT present nothing will happen, if someone
@@ -1069,26 +1268,176 @@ int __regulatory_hint(struct wiphy *wiphy, enum reg_set_by set_by,
        return call_crda(alpha2);
 }
 
-void regulatory_hint(struct wiphy *wiphy, const char *alpha2)
+/* This currently only processes user and driver regulatory hints */
+static int reg_process_hint(struct regulatory_request *reg_request)
+{
+       int r = 0;
+       struct wiphy *wiphy = NULL;
+
+       BUG_ON(!reg_request->alpha2);
+
+       mutex_lock(&cfg80211_mutex);
+
+       if (wiphy_idx_valid(reg_request->wiphy_idx))
+               wiphy = wiphy_idx_to_wiphy(reg_request->wiphy_idx);
+
+       if (reg_request->initiator == REGDOM_SET_BY_DRIVER &&
+           !wiphy) {
+               r = -ENODEV;
+               goto out;
+       }
+
+       r = __regulatory_hint(wiphy,
+                             reg_request->initiator,
+                             reg_request->alpha2,
+                             reg_request->country_ie_checksum,
+                             reg_request->country_ie_env);
+       /* This is required so that the orig_* parameters are saved */
+       if (r == -EALREADY && wiphy && wiphy->strict_regulatory)
+               wiphy_update_regulatory(wiphy, reg_request->initiator);
+out:
+       mutex_unlock(&cfg80211_mutex);
+
+       if (r == -EALREADY)
+               r = 0;
+
+       return r;
+}
+
+static void reg_process_pending_hints(void)
+       {
+       struct regulatory_request *reg_request;
+       int r;
+
+       spin_lock(&reg_requests_lock);
+       while (!list_empty(&reg_requests_list)) {
+               reg_request = list_first_entry(&reg_requests_list,
+                                              struct regulatory_request,
+                                              list);
+               list_del_init(&reg_request->list);
+               spin_unlock(&reg_requests_lock);
+
+               r = reg_process_hint(reg_request);
+#ifdef CONFIG_CFG80211_REG_DEBUG
+               if (r && (reg_request->initiator == REGDOM_SET_BY_DRIVER ||
+                   reg_request->initiator == REGDOM_SET_BY_COUNTRY_IE))
+                       printk(KERN_ERR "cfg80211: wiphy_idx %d sent a "
+                               "regulatory hint for %c%c but now has "
+                               "gone fishing, ignoring request\n",
+                               reg_request->wiphy_idx,
+                               reg_request->alpha2[0],
+                               reg_request->alpha2[1]);
+#endif
+               kfree(reg_request);
+               spin_lock(&reg_requests_lock);
+       }
+       spin_unlock(&reg_requests_lock);
+}
+
+static void reg_todo(struct work_struct *work)
+{
+       reg_process_pending_hints();
+}
+
+static DECLARE_WORK(reg_work, reg_todo);
+
+static void queue_regulatory_request(struct regulatory_request *request)
+{
+       spin_lock(&reg_requests_lock);
+       list_add_tail(&request->list, &reg_requests_list);
+       spin_unlock(&reg_requests_lock);
+
+       schedule_work(&reg_work);
+}
+
+/* Core regulatory hint -- happens once during cfg80211_init() */
+static int regulatory_hint_core(const char *alpha2)
+{
+       struct regulatory_request *request;
+
+       BUG_ON(last_request);
+
+       request = kzalloc(sizeof(struct regulatory_request),
+                         GFP_KERNEL);
+       if (!request)
+               return -ENOMEM;
+
+       request->alpha2[0] = alpha2[0];
+       request->alpha2[1] = alpha2[1];
+       request->initiator = REGDOM_SET_BY_CORE;
+
+       queue_regulatory_request(request);
+
+       return 0;
+}
+
+/* User hints */
+int regulatory_hint_user(const char *alpha2)
+{
+       struct regulatory_request *request;
+
+       BUG_ON(!alpha2);
+
+       request = kzalloc(sizeof(struct regulatory_request), GFP_KERNEL);
+       if (!request)
+               return -ENOMEM;
+
+       request->wiphy_idx = WIPHY_IDX_STALE;
+       request->alpha2[0] = alpha2[0];
+       request->alpha2[1] = alpha2[1];
+       request->initiator = REGDOM_SET_BY_USER,
+
+       queue_regulatory_request(request);
+
+       return 0;
+}
+
+/* Driver hints */
+int regulatory_hint(struct wiphy *wiphy, const char *alpha2)
 {
+       struct regulatory_request *request;
+
        BUG_ON(!alpha2);
+       BUG_ON(!wiphy);
 
-       mutex_lock(&cfg80211_drv_mutex);
-       __regulatory_hint(wiphy, REGDOM_SET_BY_DRIVER, alpha2, 0, ENVIRON_ANY);
-       mutex_unlock(&cfg80211_drv_mutex);
+       request = kzalloc(sizeof(struct regulatory_request), GFP_KERNEL);
+       if (!request)
+               return -ENOMEM;
+
+       request->wiphy_idx = get_wiphy_idx(wiphy);
+
+       /* Must have registered wiphy first */
+       BUG_ON(!wiphy_idx_valid(request->wiphy_idx));
+
+       request->alpha2[0] = alpha2[0];
+       request->alpha2[1] = alpha2[1];
+       request->initiator = REGDOM_SET_BY_DRIVER;
+
+       queue_regulatory_request(request);
+
+       return 0;
 }
 EXPORT_SYMBOL(regulatory_hint);
 
 static bool reg_same_country_ie_hint(struct wiphy *wiphy,
                        u32 country_ie_checksum)
 {
-       if (!last_request->wiphy)
+       struct wiphy *request_wiphy;
+
+       assert_cfg80211_lock();
+
+       request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);
+
+       if (!request_wiphy)
                return false;
-       if (likely(last_request->wiphy != wiphy))
+
+       if (likely(request_wiphy != wiphy))
                return !country_ie_integrity_changes(country_ie_checksum);
-       /* We should not have let these through at this point, they
+       /*
+        * We should not have let these through at this point, they
         * should have been picked up earlier by the first alpha2 check
-        * on the device */
+        * on the device
+        */
        if (WARN_ON(!country_ie_integrity_changes(country_ie_checksum)))
                return true;
        return false;
@@ -1102,11 +1451,14 @@ void regulatory_hint_11d(struct wiphy *wiphy,
        char alpha2[2];
        u32 checksum = 0;
        enum environment_cap env = ENVIRON_ANY;
+       struct regulatory_request *request;
 
-       if (!last_request)
-               return;
+       mutex_lock(&cfg80211_mutex);
 
-       mutex_lock(&cfg80211_drv_mutex);
+       if (unlikely(!last_request)) {
+               mutex_unlock(&cfg80211_mutex);
+               return;
+       }
 
        /* IE len must be evenly divisible by 2 */
        if (country_ie_len & 0x01)
@@ -1115,9 +1467,11 @@ void regulatory_hint_11d(struct wiphy *wiphy,
        if (country_ie_len < IEEE80211_COUNTRY_IE_MIN_LEN)
                goto out;
 
-       /* Pending country IE processing, this can happen after we
+       /*
+        * Pending country IE processing, this can happen after we
         * call CRDA and wait for a response if a beacon was received before
-        * we were able to process the last regulatory_hint_11d() call */
+        * we were able to process the last regulatory_hint_11d() call
+        */
        if (country_ie_regdomain)
                goto out;
 
@@ -1129,33 +1483,44 @@ void regulatory_hint_11d(struct wiphy *wiphy,
        else if (country_ie[2] == 'O')
                env = ENVIRON_OUTDOOR;
 
-       /* We will run this for *every* beacon processed for the BSSID, so
+       /*
+        * We will run this for *every* beacon processed for the BSSID, so
         * we optimize an early check to exit out early if we don't have to
-        * do anything */
-       if (likely(last_request->wiphy)) {
+        * do anything
+        */
+       if (likely(wiphy_idx_valid(last_request->wiphy_idx))) {
                struct cfg80211_registered_device *drv_last_ie;
 
-               drv_last_ie = wiphy_to_dev(last_request->wiphy);
+               drv_last_ie =
+                       cfg80211_drv_by_wiphy_idx(last_request->wiphy_idx);
 
-               /* Lets keep this simple -- we trust the first AP
-                * after we intersect with CRDA */
-               if (likely(last_request->wiphy == wiphy)) {
-                       /* Ignore IEs coming in on this wiphy with
-                        * the same alpha2 and environment cap */
+               /*
+                * Lets keep this simple -- we trust the first AP
+                * after we intersect with CRDA
+                */
+               if (likely(&drv_last_ie->wiphy == wiphy)) {
+                       /*
+                        * Ignore IEs coming in on this wiphy with
+                        * the same alpha2 and environment cap
+                        */
                        if (likely(alpha2_equal(drv_last_ie->country_ie_alpha2,
                                  alpha2) &&
                                  env == drv_last_ie->env)) {
                                goto out;
                        }
-                       /* the wiphy moved on to another BSSID or the AP
+                       /*
+                        * the wiphy moved on to another BSSID or the AP
                         * was reconfigured. XXX: We need to deal with the
                         * case where the user suspends and goes to goes
                         * to another country, and then gets IEs from an
-                        * AP with different settings */
+                        * AP with different settings
+                        */
                        goto out;
                } else {
-                       /* Ignore IEs coming in on two separate wiphys with
-                        * the same alpha2 and environment cap */
+                       /*
+                        * Ignore IEs coming in on two separate wiphys with
+                        * the same alpha2 and environment cap
+                        */
                        if (likely(alpha2_equal(drv_last_ie->country_ie_alpha2,
                                  alpha2) &&
                                  env == drv_last_ie->env)) {
@@ -1170,25 +1535,45 @@ void regulatory_hint_11d(struct wiphy *wiphy,
        if (!rd)
                goto out;
 
-       /* This will not happen right now but we leave it here for the
+       /*
+        * This will not happen right now but we leave it here for the
         * the future when we want to add suspend/resume support and having
         * the user move to another country after doing so, or having the user
-        * move to another AP. Right now we just trust the first AP. This is why
-        * this is marked as likley(). If we hit this before we add this support
-        * we want to be informed of it as it would indicate a mistake in the
-        * current design  */
-       if (likely(WARN_ON(reg_same_country_ie_hint(wiphy, checksum))))
-               goto out;
+        * move to another AP. Right now we just trust the first AP.
+        *
+        * If we hit this before we add this support we want to be informed of
+        * it as it would indicate a mistake in the current design
+        */
+       if (WARN_ON(reg_same_country_ie_hint(wiphy, checksum)))
+               goto free_rd_out;
+
+       request = kzalloc(sizeof(struct regulatory_request), GFP_KERNEL);
+       if (!request)
+               goto free_rd_out;
 
-       /* We keep this around for when CRDA comes back with a response so
-        * we can intersect with that */
+       /*
+        * We keep this around for when CRDA comes back with a response so
+        * we can intersect with that
+        */
        country_ie_regdomain = rd;
 
-       __regulatory_hint(wiphy, REGDOM_SET_BY_COUNTRY_IE,
-               country_ie_regdomain->alpha2, checksum, env);
+       request->wiphy_idx = get_wiphy_idx(wiphy);
+       request->alpha2[0] = rd->alpha2[0];
+       request->alpha2[1] = rd->alpha2[1];
+       request->initiator = REGDOM_SET_BY_COUNTRY_IE;
+       request->country_ie_checksum = checksum;
+       request->country_ie_env = env;
+
+       mutex_unlock(&cfg80211_mutex);
+
+       queue_regulatory_request(request);
 
+       return;
+
+free_rd_out:
+       kfree(rd);
 out:
-       mutex_unlock(&cfg80211_drv_mutex);
+       mutex_unlock(&cfg80211_mutex);
 }
 EXPORT_SYMBOL(regulatory_hint_11d);
 
@@ -1207,8 +1592,10 @@ static void print_rd_rules(const struct ieee80211_regdomain *rd)
                freq_range = &reg_rule->freq_range;
                power_rule = &reg_rule->power_rule;
 
-               /* There may not be documentation for max antenna gain
-                * in certain regions */
+               /*
+                * There may not be documentation for max antenna gain
+                * in certain regions
+                */
                if (power_rule->max_antenna_gain)
                        printk(KERN_INFO "\t(%d KHz - %d KHz @ %d KHz), "
                                "(%d mBi, %d mBm)\n",
@@ -1231,13 +1618,12 @@ static void print_regdomain(const struct ieee80211_regdomain *rd)
 {
 
        if (is_intersected_alpha2(rd->alpha2)) {
-               struct wiphy *wiphy = NULL;
-               struct cfg80211_registered_device *drv;
 
                if (last_request->initiator == REGDOM_SET_BY_COUNTRY_IE) {
-                       if (last_request->wiphy) {
-                               wiphy = last_request->wiphy;
-                               drv = wiphy_to_dev(wiphy);
+                       struct cfg80211_registered_device *drv;
+                       drv = cfg80211_drv_by_wiphy_idx(
+                               last_request->wiphy_idx);
+                       if (drv) {
                                printk(KERN_INFO "cfg80211: Current regulatory "
                                        "domain updated by AP to: %c%c\n",
                                        drv->country_ie_alpha2[0],
@@ -1247,7 +1633,7 @@ static void print_regdomain(const struct ieee80211_regdomain *rd)
                                        "domain intersected: \n");
                } else
                                printk(KERN_INFO "cfg80211: Current regulatory "
-                                       "intersected: \n");
+                                       "domain intersected: \n");
        } else if (is_world_regdom(rd->alpha2))
                printk(KERN_INFO "cfg80211: World regulatory "
                        "domain updated:\n");
@@ -1303,7 +1689,7 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
 {
        const struct ieee80211_regdomain *intersected_rd = NULL;
        struct cfg80211_registered_device *drv = NULL;
-       struct wiphy *wiphy = NULL;
+       struct wiphy *request_wiphy;
        /* Some basic sanity checks first */
 
        if (is_world_regdom(rd->alpha2)) {
@@ -1320,23 +1706,27 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
        if (!last_request)
                return -EINVAL;
 
-       /* Lets only bother proceeding on the same alpha2 if the current
+       /*
+        * Lets only bother proceeding on the same alpha2 if the current
         * rd is non static (it means CRDA was present and was used last)
-        * and the pending request came in from a country IE */
+        * and the pending request came in from a country IE
+        */
        if (last_request->initiator != REGDOM_SET_BY_COUNTRY_IE) {
-               /* If someone else asked us to change the rd lets only bother
-                * checking if the alpha2 changes if CRDA was already called */
+               /*
+                * If someone else asked us to change the rd lets only bother
+                * checking if the alpha2 changes if CRDA was already called
+                */
                if (!is_old_static_regdom(cfg80211_regdomain) &&
-                   !regdom_changed(rd->alpha2))
+                   !regdom_changes(rd->alpha2))
                        return -EINVAL;
        }
 
-       wiphy = last_request->wiphy;
-
-       /* Now lets set the regulatory domain, update all driver channels
+       /*
+        * Now lets set the regulatory domain, update all driver channels
         * and finally inform them of what we have done, in case they want
         * to review or adjust their own settings based on their own
-        * internal EEPROM data */
+        * internal EEPROM data
+        */
 
        if (WARN_ON(!reg_is_valid_request(rd->alpha2)))
                return -EINVAL;
@@ -1348,7 +1738,28 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
                return -EINVAL;
        }
 
+       request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);
+
        if (!last_request->intersect) {
+               int r;
+
+               if (last_request->initiator != REGDOM_SET_BY_DRIVER) {
+                       reset_regdomains();
+                       cfg80211_regdomain = rd;
+                       return 0;
+               }
+
+               /*
+                * For a driver hint, lets copy the regulatory domain the
+                * driver wanted to the wiphy to deal with conflicts
+                */
+
+               BUG_ON(request_wiphy->regd);
+
+               r = reg_copy_regd(&request_wiphy->regd, rd);
+               if (r)
+                       return r;
+
                reset_regdomains();
                cfg80211_regdomain = rd;
                return 0;
@@ -1362,8 +1773,16 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
                if (!intersected_rd)
                        return -EINVAL;
 
-               /* We can trash what CRDA provided now */
-               kfree(rd);
+               /*
+                * We can trash what CRDA provided now.
+                * However if a driver requested this specific regulatory
+                * domain we keep it for its private use
+                */
+               if (last_request->initiator == REGDOM_SET_BY_DRIVER)
+                       request_wiphy->regd = rd;
+               else
+                       kfree(rd);
+
                rd = NULL;
 
                reset_regdomains();
@@ -1380,8 +1799,10 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
        BUG_ON(!country_ie_regdomain);
 
        if (rd != country_ie_regdomain) {
-               /* Intersect what CRDA returned and our what we
-                * had built from the Country IE received */
+               /*
+                * Intersect what CRDA returned and our what we
+                * had built from the Country IE received
+                */
 
                intersected_rd = regdom_intersect(rd, country_ie_regdomain);
 
@@ -1391,16 +1812,18 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
                kfree(country_ie_regdomain);
                country_ie_regdomain = NULL;
        } else {
-               /* This would happen when CRDA was not present and
+               /*
+                * This would happen when CRDA was not present and
                 * OLD_REGULATORY was enabled. We intersect our Country
-                * IE rd and what was set on cfg80211 originally */
+                * IE rd and what was set on cfg80211 originally
+                */
                intersected_rd = regdom_intersect(rd, cfg80211_regdomain);
        }
 
        if (!intersected_rd)
                return -EINVAL;
 
-       drv = wiphy_to_dev(wiphy);
+       drv = wiphy_to_dev(request_wiphy);
 
        drv->country_ie_alpha2[0] = rd->alpha2[0];
        drv->country_ie_alpha2[1] = rd->alpha2[1];
@@ -1418,13 +1841,17 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
 }
 
 
-/* Use this call to set the current regulatory domain. Conflicts with
+/*
+ * Use this call to set the current regulatory domain. Conflicts with
  * multiple drivers can be ironed out later. Caller must've already
- * kmalloc'd the rd structure. Caller must hold cfg80211_drv_mutex */
+ * kmalloc'd the rd structure. Caller must hold cfg80211_mutex
+ */
 int set_regdom(const struct ieee80211_regdomain *rd)
 {
        int r;
 
+       assert_cfg80211_lock();
+
        /* Note that this doesn't update the wiphys, this is done below */
        r = __set_regdom(rd);
        if (r) {
@@ -1444,53 +1871,80 @@ int set_regdom(const struct ieee80211_regdomain *rd)
        return r;
 }
 
-/* Caller must hold cfg80211_drv_mutex */
+/* Caller must hold cfg80211_mutex */
 void reg_device_remove(struct wiphy *wiphy)
 {
-       if (!last_request || !last_request->wiphy)
+       struct wiphy *request_wiphy;
+
+       assert_cfg80211_lock();
+
+       request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);
+
+       kfree(wiphy->regd);
+       if (!last_request || !request_wiphy)
                return;
-       if (last_request->wiphy != wiphy)
+       if (request_wiphy != wiphy)
                return;
-       last_request->wiphy = NULL;
+       last_request->wiphy_idx = WIPHY_IDX_STALE;
        last_request->country_ie_env = ENVIRON_ANY;
 }
 
 int regulatory_init(void)
 {
-       int err;
+       int err = 0;
 
        reg_pdev = platform_device_register_simple("regulatory", 0, NULL, 0);
        if (IS_ERR(reg_pdev))
                return PTR_ERR(reg_pdev);
 
+       spin_lock_init(&reg_requests_lock);
+
 #ifdef CONFIG_WIRELESS_OLD_REGULATORY
        cfg80211_regdomain = static_regdom(ieee80211_regdom);
 
        printk(KERN_INFO "cfg80211: Using static regulatory domain info\n");
        print_regdomain_info(cfg80211_regdomain);
-       /* The old code still requests for a new regdomain and if
+       /*
+        * The old code still requests for a new regdomain and if
         * you have CRDA you get it updated, otherwise you get
         * stuck with the static values. We ignore "EU" code as
-        * that is not a valid ISO / IEC 3166 alpha2 */
+        * that is not a valid ISO / IEC 3166 alpha2
+        */
        if (ieee80211_regdom[0] != 'E' || ieee80211_regdom[1] != 'U')
-               err = __regulatory_hint(NULL, REGDOM_SET_BY_CORE,
-                                       ieee80211_regdom, 0, ENVIRON_ANY);
+               err = regulatory_hint_core(ieee80211_regdom);
 #else
        cfg80211_regdomain = cfg80211_world_regdom;
 
-       err = __regulatory_hint(NULL, REGDOM_SET_BY_CORE, "00", 0, ENVIRON_ANY);
-       if (err)
-               printk(KERN_ERR "cfg80211: calling CRDA failed - "
-                      "unable to update world regulatory domain, "
-                      "using static definition\n");
+       err = regulatory_hint_core("00");
 #endif
+       if (err) {
+               if (err == -ENOMEM)
+                       return err;
+               /*
+                * N.B. kobject_uevent_env() can fail mainly for when we're out
+                * memory which is handled and propagated appropriately above
+                * but it can also fail during a netlink_broadcast() or during
+                * early boot for call_usermodehelper(). For now treat these
+                * errors as non-fatal.
+                */
+               printk(KERN_ERR "cfg80211: kobject_uevent_env() was unable "
+                       "to call CRDA during init");
+#ifdef CONFIG_CFG80211_REG_DEBUG
+               /* We want to find out exactly why when debugging */
+               WARN_ON(err);
+#endif
+       }
 
        return 0;
 }
 
 void regulatory_exit(void)
 {
-       mutex_lock(&cfg80211_drv_mutex);
+       struct regulatory_request *reg_request, *tmp;
+
+       cancel_work_sync(&reg_work);
+
+       mutex_lock(&cfg80211_mutex);
 
        reset_regdomains();
 
@@ -1501,5 +1955,15 @@ void regulatory_exit(void)
 
        platform_device_unregister(reg_pdev);
 
-       mutex_unlock(&cfg80211_drv_mutex);
+       spin_lock(&reg_requests_lock);
+       if (!list_empty(&reg_requests_list)) {
+               list_for_each_entry_safe(reg_request, tmp,
+                                        &reg_requests_list, list) {
+                       list_del(&reg_request->list);
+                       kfree(reg_request);
+               }
+       }
+       spin_unlock(&reg_requests_lock);
+
+       mutex_unlock(&cfg80211_mutex);
 }