git.openpandora.org
/
pandora-kernel.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
rfkill: fix rfkill_fop_read wait_event usage
[pandora-kernel.git]
/
net
/
rfkill
/
core.c
diff --git
a/net/rfkill/core.c
b/net/rfkill/core.c
index
5be1957
..
ae7b50a
100644
(file)
--- a/
net/rfkill/core.c
+++ b/
net/rfkill/core.c
@@
-50,7
+50,6
@@
struct rfkill {
spinlock_t lock;
struct rfkill {
spinlock_t lock;
- const char *name;
enum rfkill_type type;
unsigned long state;
enum rfkill_type type;
unsigned long state;
@@
-74,6
+73,7
@@
struct rfkill {
struct delayed_work poll_work;
struct work_struct uevent_work;
struct work_struct sync_work;
struct delayed_work poll_work;
struct work_struct uevent_work;
struct work_struct sync_work;
+ char name[];
};
#define to_rfkill(d) container_of(d, struct rfkill, dev)
};
#define to_rfkill(d) container_of(d, struct rfkill, dev)
@@
-848,14
+848,14
@@
struct rfkill * __must_check rfkill_alloc(const char *name,
if (WARN_ON(type == RFKILL_TYPE_ALL || type >= NUM_RFKILL_TYPES))
return NULL;
if (WARN_ON(type == RFKILL_TYPE_ALL || type >= NUM_RFKILL_TYPES))
return NULL;
- rfkill = kzalloc(sizeof(*rfkill), GFP_KERNEL);
+ rfkill = kzalloc(sizeof(*rfkill)
+ strlen(name) + 1
, GFP_KERNEL);
if (!rfkill)
return NULL;
spin_lock_init(&rfkill->lock);
INIT_LIST_HEAD(&rfkill->node);
rfkill->type = type;
if (!rfkill)
return NULL;
spin_lock_init(&rfkill->lock);
INIT_LIST_HEAD(&rfkill->node);
rfkill->type = type;
-
rfkill->name = name
;
+
strcpy(rfkill->name, name)
;
rfkill->ops = ops;
rfkill->data = ops_data;
rfkill->ops = ops;
rfkill->data = ops_data;
@@
-1065,17
+1065,6
@@
static unsigned int rfkill_fop_poll(struct file *file, poll_table *wait)
return res;
}
return res;
}
-static bool rfkill_readable(struct rfkill_data *data)
-{
- bool r;
-
- mutex_lock(&data->mtx);
- r = !list_empty(&data->events);
- mutex_unlock(&data->mtx);
-
- return r;
-}
-
static ssize_t rfkill_fop_read(struct file *file, char __user *buf,
size_t count, loff_t *pos)
{
static ssize_t rfkill_fop_read(struct file *file, char __user *buf,
size_t count, loff_t *pos)
{
@@
-1092,8
+1081,11
@@
static ssize_t rfkill_fop_read(struct file *file, char __user *buf,
goto out;
}
mutex_unlock(&data->mtx);
goto out;
}
mutex_unlock(&data->mtx);
+ /* since we re-check and it just compares pointers,
+ * using !list_empty() without locking isn't a problem
+ */
ret = wait_event_interruptible(data->read_wait,
ret = wait_event_interruptible(data->read_wait,
-
rfkill_readable(data
));
+
!list_empty(&data->events
));
mutex_lock(&data->mtx);
if (ret)
mutex_lock(&data->mtx);
if (ret)