Merge branch 'pandora-27-omap1' into rev2

[pandora-kernel.git] / net / netfilter / xt_statistic.c

diff --git a/net/netfilter/xt_statistic.c b/net/netfilter/xt_statistic.c
index 091a9f8..4313308 100644 (file)
--- a/net/netfilter/xt_statistic.c
+++ b/net/netfilter/xt_statistic.c
@@ -18,32 +18,32 @@
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Patrick McHardy <kaber@trash.net>");
-MODULE_DESCRIPTION("xtables statistical match module");
+MODULE_DESCRIPTION("Xtables: statistics-based matching (\"Nth\", random)");
 MODULE_ALIAS("ipt_statistic");
 MODULE_ALIAS("ip6t_statistic");
 
 static DEFINE_SPINLOCK(nth_lock);
 
-static int
-match(const struct sk_buff *skb,
-      const struct net_device *in, const struct net_device *out,
-      const struct xt_match *match, const void *matchinfo,
-      int offset, unsigned int protoff, int *hotdrop)
+static bool
+statistic_mt(const struct sk_buff *skb, const struct net_device *in,
+             const struct net_device *out, const struct xt_match *match,
+             const void *matchinfo, int offset, unsigned int protoff,
+             bool *hotdrop)
 {
        struct xt_statistic_info *info = (struct xt_statistic_info *)matchinfo;
-       int ret = info->flags & XT_STATISTIC_INVERT ? 1 : 0;
+       bool ret = info->flags & XT_STATISTIC_INVERT;
 
        switch (info->mode) {
        case XT_STATISTIC_MODE_RANDOM:
                if ((net_random() & 0x7FFFFFFF) < info->u.random.probability)
-                       ret ^= 1;
+                       ret = !ret;
                break;
        case XT_STATISTIC_MODE_NTH:
                info = info->master;
                spin_lock_bh(&nth_lock);
                if (info->u.nth.count++ == info->u.nth.every) {
                        info->u.nth.count = 0;
-                       ret ^= 1;
+                       ret = !ret;
                }
                spin_unlock_bh(&nth_lock);
                break;
@@ -52,50 +52,50 @@ match(const struct sk_buff *skb,
        return ret;
 }
 
-static int
-checkentry(const char *tablename, const void *entry,
-          const struct xt_match *match, void *matchinfo,
-          unsigned int hook_mask)
+static bool
+statistic_mt_check(const char *tablename, const void *entry,
+                   const struct xt_match *match, void *matchinfo,
+                   unsigned int hook_mask)
 {
-       struct xt_statistic_info *info = (struct xt_statistic_info *)matchinfo;
+       struct xt_statistic_info *info = matchinfo;
 
        if (info->mode > XT_STATISTIC_MODE_MAX ||
            info->flags & ~XT_STATISTIC_MASK)
-               return 0;
+               return false;
        info->master = info;
-       return 1;
+       return true;
 }
 
-static struct xt_match xt_statistic_match[] = {
+static struct xt_match statistic_mt_reg[] __read_mostly = {
        {
                .name           = "statistic",
                .family         = AF_INET,
-               .checkentry     = checkentry,
-               .match          = match,
+               .checkentry     = statistic_mt_check,
+               .match          = statistic_mt,
                .matchsize      = sizeof(struct xt_statistic_info),
                .me             = THIS_MODULE,
        },
        {
                .name           = "statistic",
                .family         = AF_INET6,
-               .checkentry     = checkentry,
-               .match          = match,
+               .checkentry     = statistic_mt_check,
+               .match          = statistic_mt,
                .matchsize      = sizeof(struct xt_statistic_info),
                .me             = THIS_MODULE,
        },
 };
 
-static int __init xt_statistic_init(void)
+static int __init statistic_mt_init(void)
 {
-       return xt_register_matches(xt_statistic_match,
-                                  ARRAY_SIZE(xt_statistic_match));
+       return xt_register_matches(statistic_mt_reg,
+              ARRAY_SIZE(statistic_mt_reg));
 }
 
-static void __exit xt_statistic_fini(void)
+static void __exit statistic_mt_exit(void)
 {
-       xt_unregister_matches(xt_statistic_match,
-                             ARRAY_SIZE(xt_statistic_match));
+       xt_unregister_matches(statistic_mt_reg,
+                             ARRAY_SIZE(statistic_mt_reg));
 }
 
-module_init(xt_statistic_init);
-module_exit(xt_statistic_fini);
+module_init(statistic_mt_init);
+module_exit(statistic_mt_exit);