Merge branch 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6
[pandora-kernel.git] / fs / ext3 / balloc.c
index 77927d6..063d994 100644 (file)
@@ -11,7 +11,6 @@
  *        David S. Miller (davem@caip.rutgers.edu), 1995
  */
 
-#include <linux/config.h>
 #include <linux/time.h>
 #include <linux/capability.h>
 #include <linux/fs.h>
@@ -163,20 +162,19 @@ restart:
 #endif
 
 static int
-goal_in_my_reservation(struct ext3_reserve_window *rsv, int goal,
+goal_in_my_reservation(struct ext3_reserve_window *rsv, ext3_grpblk_t grp_goal,
                        unsigned int group, struct super_block * sb)
 {
-       unsigned long group_first_block, group_last_block;
+       ext3_fsblk_t group_first_block, group_last_block;
 
-       group_first_block = le32_to_cpu(EXT3_SB(sb)->s_es->s_first_data_block) +
-                               group * EXT3_BLOCKS_PER_GROUP(sb);
+       group_first_block = ext3_group_first_block_no(sb, group);
        group_last_block = group_first_block + EXT3_BLOCKS_PER_GROUP(sb) - 1;
 
        if ((rsv->_rsv_start > group_last_block) ||
            (rsv->_rsv_end < group_first_block))
                return 0;
-       if ((goal >= 0) && ((goal + group_first_block < rsv->_rsv_start)
-               || (goal + group_first_block > rsv->_rsv_end)))
+       if ((grp_goal >= 0) && ((grp_goal + group_first_block < rsv->_rsv_start)
+               || (grp_goal + group_first_block > rsv->_rsv_end)))
                return 0;
        return 1;
 }
@@ -187,7 +185,7 @@ goal_in_my_reservation(struct ext3_reserve_window *rsv, int goal,
  * Returns NULL if there are no windows or if all windows start after the goal.
  */
 static struct ext3_reserve_window_node *
-search_reserve_window(struct rb_root *root, unsigned long goal)
+search_reserve_window(struct rb_root *root, ext3_fsblk_t goal)
 {
        struct rb_node *n = root->rb_node;
        struct ext3_reserve_window_node *rsv;
@@ -223,7 +221,7 @@ void ext3_rsv_window_add(struct super_block *sb,
 {
        struct rb_root *root = &EXT3_SB(sb)->s_rsv_window_root;
        struct rb_node *node = &rsv->rsv_node;
-       unsigned int start = rsv->rsv_start;
+       ext3_fsblk_t start = rsv->rsv_start;
 
        struct rb_node ** p = &root->rb_node;
        struct rb_node * parent = NULL;
@@ -310,20 +308,20 @@ void ext3_discard_reservation(struct inode *inode)
 
 /* Free given blocks, update quota and i_blocks field */
 void ext3_free_blocks_sb(handle_t *handle, struct super_block *sb,
-                        unsigned long block, unsigned long count,
-                        int *pdquot_freed_blocks)
+                        ext3_fsblk_t block, unsigned long count,
+                        unsigned long *pdquot_freed_blocks)
 {
        struct buffer_head *bitmap_bh = NULL;
        struct buffer_head *gd_bh;
        unsigned long block_group;
-       unsigned long bit;
+       ext3_grpblk_t bit;
        unsigned long i;
        unsigned long overflow;
        struct ext3_group_desc * desc;
        struct ext3_super_block * es;
        struct ext3_sb_info *sbi;
        int err = 0, ret;
-       unsigned group_freed;
+       ext3_grpblk_t group_freed;
 
        *pdquot_freed_blocks = 0;
        sbi = EXT3_SB(sb);
@@ -333,7 +331,7 @@ void ext3_free_blocks_sb(handle_t *handle, struct super_block *sb,
            block + count > le32_to_cpu(es->s_blocks_count)) {
                ext3_error (sb, "ext3_free_blocks",
                            "Freeing blocks not in datazone - "
-                           "block = %lu, count = %lu", block, count);
+                           "block = "E3FSBLK", count = %lu", block, count);
                goto error_return;
        }
 
@@ -369,7 +367,7 @@ do_more:
                      sbi->s_itb_per_group))
                ext3_error (sb, "ext3_free_blocks",
                            "Freeing blocks in system zones - "
-                           "Block = %lu, count = %lu",
+                           "Block = "E3FSBLK", count = %lu",
                            block, count);
 
        /*
@@ -453,7 +451,8 @@ do_more:
                                                bit + i, bitmap_bh->b_data)) {
                        jbd_unlock_bh_state(bitmap_bh);
                        ext3_error(sb, __FUNCTION__,
-                               "bit already cleared for block %lu", block + i);
+                               "bit already cleared for block "E3FSBLK,
+                                block + i);
                        jbd_lock_bh_state(bitmap_bh);
                        BUFFER_TRACE(bitmap_bh, "bit already cleared");
                } else {
@@ -493,10 +492,10 @@ error_return:
 
 /* Free given blocks, update quota and i_blocks field */
 void ext3_free_blocks(handle_t *handle, struct inode *inode,
-                       unsigned long block, unsigned long count)
+                       ext3_fsblk_t block, unsigned long count)
 {
        struct super_block * sb;
-       int dquot_freed_blocks;
+       unsigned long dquot_freed_blocks;
 
        sb = inode->i_sb;
        if (!sb) {
@@ -525,7 +524,7 @@ void ext3_free_blocks(handle_t *handle, struct inode *inode,
  * data-writes at some point, and disable it for metadata allocations or
  * sync-data inodes.
  */
-static int ext3_test_allocatable(int nr, struct buffer_head *bh)
+static int ext3_test_allocatable(ext3_grpblk_t nr, struct buffer_head *bh)
 {
        int ret;
        struct journal_head *jh = bh2jh(bh);
@@ -542,11 +541,11 @@ static int ext3_test_allocatable(int nr, struct buffer_head *bh)
        return ret;
 }
 
-static int
-bitmap_search_next_usable_block(int start, struct buffer_head *bh,
-                                       int maxblocks)
+static ext3_grpblk_t
+bitmap_search_next_usable_block(ext3_grpblk_t start, struct buffer_head *bh,
+                                       ext3_grpblk_t maxblocks)
 {
-       int next;
+       ext3_grpblk_t next;
        struct journal_head *jh = bh2jh(bh);
 
        /*
@@ -576,10 +575,11 @@ bitmap_search_next_usable_block(int start, struct buffer_head *bh,
  * the initial goal; then for a free byte somewhere in the bitmap; then
  * for any free bit in the bitmap.
  */
-static int
-find_next_usable_block(int start, struct buffer_head *bh, int maxblocks)
+static ext3_grpblk_t
+find_next_usable_block(ext3_grpblk_t start, struct buffer_head *bh,
+                       ext3_grpblk_t maxblocks)
 {
-       int here, next;
+       ext3_grpblk_t here, next;
        char *p, *r;
 
        if (start > 0) {
@@ -591,7 +591,7 @@ find_next_usable_block(int start, struct buffer_head *bh, int maxblocks)
                 * less than EXT3_BLOCKS_PER_GROUP. Aligning up to the
                 * next 64-bit boundary is simple..
                 */
-               int end_goal = (start + 63) & ~63;
+               ext3_grpblk_t end_goal = (start + 63) & ~63;
                if (end_goal > maxblocks)
                        end_goal = maxblocks;
                here = ext3_find_next_zero_bit(bh->b_data, end_goal, start);
@@ -628,7 +628,7 @@ find_next_usable_block(int start, struct buffer_head *bh, int maxblocks)
  * zero (failure).
  */
 static inline int
-claim_block(spinlock_t *lock, int block, struct buffer_head *bh)
+claim_block(spinlock_t *lock, ext3_grpblk_t block, struct buffer_head *bh)
 {
        struct journal_head *jh = bh2jh(bh);
        int ret;
@@ -651,19 +651,18 @@ claim_block(spinlock_t *lock, int block, struct buffer_head *bh)
  * new bitmap.  In that case we must release write access to the old one via
  * ext3_journal_release_buffer(), else we'll run out of credits.
  */
-static int
+static ext3_grpblk_t
 ext3_try_to_allocate(struct super_block *sb, handle_t *handle, int group,
-                       struct buffer_head *bitmap_bh, int goal,
+                       struct buffer_head *bitmap_bh, ext3_grpblk_t grp_goal,
                        unsigned long *count, struct ext3_reserve_window *my_rsv)
 {
-       int group_first_block, start, end;
+       ext3_fsblk_t group_first_block;
+       ext3_grpblk_t start, end;
        unsigned long num = 0;
 
        /* we do allocation within the reservation window if we have a window */
        if (my_rsv) {
-               group_first_block =
-                       le32_to_cpu(EXT3_SB(sb)->s_es->s_first_data_block) +
-                       group * EXT3_BLOCKS_PER_GROUP(sb);
+               group_first_block = ext3_group_first_block_no(sb, group);
                if (my_rsv->_rsv_start >= group_first_block)
                        start = my_rsv->_rsv_start - group_first_block;
                else
@@ -673,13 +672,13 @@ ext3_try_to_allocate(struct super_block *sb, handle_t *handle, int group,
                if (end > EXT3_BLOCKS_PER_GROUP(sb))
                        /* reservation window crosses group boundary */
                        end = EXT3_BLOCKS_PER_GROUP(sb);
-               if ((start <= goal) && (goal < end))
-                       start = goal;
+               if ((start <= grp_goal) && (grp_goal < end))
+                       start = grp_goal;
                else
-                       goal = -1;
+                       grp_goal = -1;
        } else {
-               if (goal > 0)
-                       start = goal;
+               if (grp_goal > 0)
+                       start = grp_goal;
                else
                        start = 0;
                end = EXT3_BLOCKS_PER_GROUP(sb);
@@ -688,43 +687,43 @@ ext3_try_to_allocate(struct super_block *sb, handle_t *handle, int group,
        BUG_ON(start > EXT3_BLOCKS_PER_GROUP(sb));
 
 repeat:
-       if (goal < 0 || !ext3_test_allocatable(goal, bitmap_bh)) {
-               goal = find_next_usable_block(start, bitmap_bh, end);
-               if (goal < 0)
+       if (grp_goal < 0 || !ext3_test_allocatable(grp_goal, bitmap_bh)) {
+               grp_goal = find_next_usable_block(start, bitmap_bh, end);
+               if (grp_goal < 0)
                        goto fail_access;
                if (!my_rsv) {
                        int i;
 
-                       for (i = 0; i < 7 && goal > start &&
-                                       ext3_test_allocatable(goal - 1,
+                       for (i = 0; i < 7 && grp_goal > start &&
+                                       ext3_test_allocatable(grp_goal - 1,
                                                                bitmap_bh);
-                                       i++, goal--)
+                                       i++, grp_goal--)
                                ;
                }
        }
-       start = goal;
+       start = grp_goal;
 
-       if (!claim_block(sb_bgl_lock(EXT3_SB(sb), group), goal, bitmap_bh)) {
+       if (!claim_block(sb_bgl_lock(EXT3_SB(sb), group), grp_goal, bitmap_bh)) {
                /*
                 * The block was allocated by another thread, or it was
                 * allocated and then freed by another thread
                 */
                start++;
-               goal++;
+               grp_goal++;
                if (start >= end)
                        goto fail_access;
                goto repeat;
        }
        num++;
-       goal++;
-       while (num < *count && goal < end
-               && ext3_test_allocatable(goal, bitmap_bh)
-               && claim_block(sb_bgl_lock(EXT3_SB(sb), group), goal, bitmap_bh)) {
+       grp_goal++;
+       while (num < *count && grp_goal < end
+               && ext3_test_allocatable(grp_goal, bitmap_bh)
+               && claim_block(sb_bgl_lock(EXT3_SB(sb), group), grp_goal, bitmap_bh)) {
                num++;
-               goal++;
+               grp_goal++;
        }
        *count = num;
-       return goal - num;
+       return grp_goal - num;
 fail_access:
        *count = num;
        return -1;
@@ -766,12 +765,13 @@ fail_access:
 static int find_next_reservable_window(
                                struct ext3_reserve_window_node *search_head,
                                struct ext3_reserve_window_node *my_rsv,
-                               struct super_block * sb, int start_block,
-                               int last_block)
+                               struct super_block * sb,
+                               ext3_fsblk_t start_block,
+                               ext3_fsblk_t last_block)
 {
        struct rb_node *next;
        struct ext3_reserve_window_node *rsv, *prev;
-       int cur;
+       ext3_fsblk_t cur;
        int size = my_rsv->rsv_goal_size;
 
        /* TODO: make the start of the reservation window byte-aligned */
@@ -873,10 +873,10 @@ static int find_next_reservable_window(
  *
  *     @rsv: the reservation
  *
- *     @goal: The goal (group-relative).  It is where the search for a
+ *     @grp_goal: The goal (group-relative).  It is where the search for a
  *             free reservable space should start from.
- *             if we have a goal(goal >0 ), then start from there,
- *             no goal(goal = -1), we start from the first block
+ *             if we have a grp_goal(grp_goal >0 ), then start from there,
+ *             no grp_goal(grp_goal = -1), we start from the first block
  *             of the group.
  *
  *     @sb: the super block
@@ -885,25 +885,24 @@ static int find_next_reservable_window(
  *
  */
 static int alloc_new_reservation(struct ext3_reserve_window_node *my_rsv,
-               int goal, struct super_block *sb,
+               ext3_grpblk_t grp_goal, struct super_block *sb,
                unsigned int group, struct buffer_head *bitmap_bh)
 {
        struct ext3_reserve_window_node *search_head;
-       int group_first_block, group_end_block, start_block;
-       int first_free_block;
+       ext3_fsblk_t group_first_block, group_end_block, start_block;
+       ext3_grpblk_t first_free_block;
        struct rb_root *fs_rsv_root = &EXT3_SB(sb)->s_rsv_window_root;
        unsigned long size;
        int ret;
        spinlock_t *rsv_lock = &EXT3_SB(sb)->s_rsv_window_lock;
 
-       group_first_block = le32_to_cpu(EXT3_SB(sb)->s_es->s_first_data_block) +
-                               group * EXT3_BLOCKS_PER_GROUP(sb);
+       group_first_block = ext3_group_first_block_no(sb, group);
        group_end_block = group_first_block + EXT3_BLOCKS_PER_GROUP(sb) - 1;
 
-       if (goal < 0)
+       if (grp_goal < 0)
                start_block = group_first_block;
        else
-               start_block = goal + group_first_block;
+               start_block = grp_goal + group_first_block;
 
        size = my_rsv->rsv_goal_size;
 
@@ -1057,14 +1056,15 @@ static void try_to_extend_reservation(struct ext3_reserve_window_node *my_rsv,
  * sorted double linked list should be fast.
  *
  */
-static int
+static ext3_grpblk_t
 ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle,
                        unsigned int group, struct buffer_head *bitmap_bh,
-                       int goal, struct ext3_reserve_window_node * my_rsv,
+                       ext3_grpblk_t grp_goal,
+                       struct ext3_reserve_window_node * my_rsv,
                        unsigned long *count, int *errp)
 {
-       unsigned long group_first_block;
-       int ret = 0;
+       ext3_fsblk_t group_first_block;
+       ext3_grpblk_t ret = 0;
        int fatal;
        unsigned long num = *count;
 
@@ -1090,17 +1090,16 @@ ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle,
         */
        if (my_rsv == NULL ) {
                ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh,
-                                               goal, count, NULL);
+                                               grp_goal, count, NULL);
                goto out;
        }
        /*
-        * goal is a group relative block number (if there is a goal)
-        * 0 < goal < EXT3_BLOCKS_PER_GROUP(sb)
+        * grp_goal is a group relative block number (if there is a goal)
+        * 0 < grp_goal < EXT3_BLOCKS_PER_GROUP(sb)
         * first block is a filesystem wide block number
         * first block is the block number of the first block in this group
         */
-       group_first_block = le32_to_cpu(EXT3_SB(sb)->s_es->s_first_data_block) +
-                       group * EXT3_BLOCKS_PER_GROUP(sb);
+       group_first_block = ext3_group_first_block_no(sb, group);
 
        /*
         * Basically we will allocate a new block from inode's reservation
@@ -1119,24 +1118,24 @@ ext3_try_to_allocate_with_rsv(struct super_block *sb, handle_t *handle,
         */
        while (1) {
                if (rsv_is_empty(&my_rsv->rsv_window) || (ret < 0) ||
-                       !goal_in_my_reservation(&my_rsv->rsv_window, goal, group, sb)) {
+                       !goal_in_my_reservation(&my_rsv->rsv_window, grp_goal, group, sb)) {
                        if (my_rsv->rsv_goal_size < *count)
                                my_rsv->rsv_goal_size = *count;
-                       ret = alloc_new_reservation(my_rsv, goal, sb,
+                       ret = alloc_new_reservation(my_rsv, grp_goal, sb,
                                                        group, bitmap_bh);
                        if (ret < 0)
                                break;                  /* failed */
 
-                       if (!goal_in_my_reservation(&my_rsv->rsv_window, goal, group, sb))
-                               goal = -1;
-               } else if (goal > 0 && (my_rsv->rsv_end-goal+1) < *count)
+                       if (!goal_in_my_reservation(&my_rsv->rsv_window, grp_goal, group, sb))
+                               grp_goal = -1;
+               } else if (grp_goal > 0 && (my_rsv->rsv_end-grp_goal+1) < *count)
                        try_to_extend_reservation(my_rsv, sb,
-                                       *count-my_rsv->rsv_end + goal - 1);
+                                       *count-my_rsv->rsv_end + grp_goal - 1);
 
                if ((my_rsv->rsv_start >= group_first_block + EXT3_BLOCKS_PER_GROUP(sb))
                    || (my_rsv->rsv_end < group_first_block))
                        BUG();
-               ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh, goal,
+               ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh, grp_goal,
                                           &num, &my_rsv->rsv_window);
                if (ret >= 0) {
                        my_rsv->rsv_alloc_hit += num;
@@ -1164,7 +1163,7 @@ out:
 
 static int ext3_has_free_blocks(struct ext3_sb_info *sbi)
 {
-       int free_blocks, root_blocks;
+       ext3_fsblk_t free_blocks, root_blocks;
 
        free_blocks = percpu_counter_read_positive(&sbi->s_freeblocks_counter);
        root_blocks = le32_to_cpu(sbi->s_es->s_r_blocks_count);
@@ -1200,19 +1199,20 @@ int ext3_should_retry_alloc(struct super_block *sb, int *retries)
  * bitmap, and then for any free bit if that fails.
  * This function also updates quota and i_blocks field.
  */
-int ext3_new_blocks(handle_t *handle, struct inode *inode,
-                       unsigned long goal, unsigned long *count, int *errp)
+ext3_fsblk_t ext3_new_blocks(handle_t *handle, struct inode *inode,
+                       ext3_fsblk_t goal, unsigned long *count, int *errp)
 {
        struct buffer_head *bitmap_bh = NULL;
        struct buffer_head *gdp_bh;
        int group_no;
        int goal_group;
-       int ret_block;
+       ext3_grpblk_t grp_target_blk;   /* blockgroup relative goal block */
+       ext3_grpblk_t grp_alloc_blk;    /* blockgroup-relative allocated block*/
+       ext3_fsblk_t ret_block;         /* filesyetem-wide allocated block */
        int bgi;                        /* blockgroup iteration index */
-       int target_block;
        int fatal = 0, err;
        int performed_allocation = 0;
-       int free_blocks;
+       ext3_grpblk_t free_blocks;      /* number of free blocks in a group */
        struct super_block *sb;
        struct ext3_group_desc *gdp;
        struct ext3_super_block *es;
@@ -1269,12 +1269,12 @@ int ext3_new_blocks(handle_t *handle, struct inode *inode,
                goal = le32_to_cpu(es->s_first_data_block);
        group_no = (goal - le32_to_cpu(es->s_first_data_block)) /
                        EXT3_BLOCKS_PER_GROUP(sb);
+       goal_group = group_no;
+retry_alloc:
        gdp = ext3_get_group_desc(sb, group_no, &gdp_bh);
        if (!gdp)
                goto io_error;
 
-       goal_group = group_no;
-retry:
        free_blocks = le16_to_cpu(gdp->bg_free_blocks_count);
        /*
         * if there is not enough free blocks to make a new resevation
@@ -1285,16 +1285,17 @@ retry:
                my_rsv = NULL;
 
        if (free_blocks > 0) {
-               ret_block = ((goal - le32_to_cpu(es->s_first_data_block)) %
+               grp_target_blk = ((goal - le32_to_cpu(es->s_first_data_block)) %
                                EXT3_BLOCKS_PER_GROUP(sb));
                bitmap_bh = read_block_bitmap(sb, group_no);
                if (!bitmap_bh)
                        goto io_error;
-               ret_block = ext3_try_to_allocate_with_rsv(sb, handle, group_no,
-                                       bitmap_bh, ret_block, my_rsv, &num, &fatal);
+               grp_alloc_blk = ext3_try_to_allocate_with_rsv(sb, handle,
+                                       group_no, bitmap_bh, grp_target_blk,
+                                       my_rsv, &num, &fatal);
                if (fatal)
                        goto out;
-               if (ret_block >= 0)
+               if (grp_alloc_blk >= 0)
                        goto allocated;
        }
 
@@ -1327,11 +1328,15 @@ retry:
                bitmap_bh = read_block_bitmap(sb, group_no);
                if (!bitmap_bh)
                        goto io_error;
-               ret_block = ext3_try_to_allocate_with_rsv(sb, handle, group_no,
-                                       bitmap_bh, -1, my_rsv, &num, &fatal);
+               /*
+                * try to allocate block(s) from this group, without a goal(-1).
+                */
+               grp_alloc_blk = ext3_try_to_allocate_with_rsv(sb, handle,
+                                       group_no, bitmap_bh, -1, my_rsv,
+                                       &num, &fatal);
                if (fatal)
                        goto out;
-               if (ret_block >= 0) 
+               if (grp_alloc_blk >= 0)
                        goto allocated;
        }
        /*
@@ -1344,7 +1349,7 @@ retry:
        if (my_rsv) {
                my_rsv = NULL;
                group_no = goal_group;
-               goto retry;
+               goto retry_alloc;
        }
        /* No space left on the device */
        *errp = -ENOSPC;
@@ -1360,18 +1365,18 @@ allocated:
        if (fatal)
                goto out;
 
-       target_block = ret_block + group_no * EXT3_BLOCKS_PER_GROUP(sb)
-                               + le32_to_cpu(es->s_first_data_block);
+       ret_block = grp_alloc_blk + ext3_group_first_block_no(sb, group_no);
 
-       if (in_range(le32_to_cpu(gdp->bg_block_bitmap), target_block, num) ||
-           in_range(le32_to_cpu(gdp->bg_inode_bitmap), target_block, num) ||
-           in_range(target_block, le32_to_cpu(gdp->bg_inode_table),
+       if (in_range(le32_to_cpu(gdp->bg_block_bitmap), ret_block, num) ||
+           in_range(le32_to_cpu(gdp->bg_inode_bitmap), ret_block, num) ||
+           in_range(ret_block, le32_to_cpu(gdp->bg_inode_table),
                      EXT3_SB(sb)->s_itb_per_group) ||
-           in_range(target_block + num - 1, le32_to_cpu(gdp->bg_inode_table),
+           in_range(ret_block + num - 1, le32_to_cpu(gdp->bg_inode_table),
                      EXT3_SB(sb)->s_itb_per_group))
                ext3_error(sb, "ext3_new_block",
                            "Allocating block in system zone - "
-                           "blocks from %u, length %lu", target_block, num);
+                           "blocks from "E3FSBLK", length %lu",
+                            ret_block, num);
 
        performed_allocation = 1;
 
@@ -1380,7 +1385,7 @@ allocated:
                struct buffer_head *debug_bh;
 
                /* Record bitmap buffer state in the newly allocated block */
-               debug_bh = sb_find_get_block(sb, target_block);
+               debug_bh = sb_find_get_block(sb, ret_block);
                if (debug_bh) {
                        BUFFER_TRACE(debug_bh, "state when allocated");
                        BUFFER_TRACE2(debug_bh, bitmap_bh, "bitmap state");
@@ -1393,24 +1398,21 @@ allocated:
                int i;
 
                for (i = 0; i < num; i++) {
-                       if (ext3_test_bit(ret_block,
+                       if (ext3_test_bit(grp_alloc_blk+i,
                                        bh2jh(bitmap_bh)->b_committed_data)) {
                                printk("%s: block was unexpectedly set in "
                                        "b_committed_data\n", __FUNCTION__);
                        }
                }
        }
-       ext3_debug("found bit %d\n", ret_block);
+       ext3_debug("found bit %d\n", grp_alloc_blk);
        spin_unlock(sb_bgl_lock(sbi, group_no));
        jbd_unlock_bh_state(bitmap_bh);
 #endif
 
-       /* ret_block was blockgroup-relative.  Now it becomes fs-relative */
-       ret_block = target_block;
-
        if (ret_block + num - 1 >= le32_to_cpu(es->s_blocks_count)) {
                ext3_error(sb, "ext3_new_block",
-                           "block(%d) >= blocks count(%d) - "
+                           "block("E3FSBLK") >= blocks count(%d) - "
                            "block_group = %d, es == %p ", ret_block,
                        le32_to_cpu(es->s_blocks_count), group_no, es);
                goto out;
@@ -1421,7 +1423,7 @@ allocated:
         * list of some description.  We don't know in advance whether
         * the caller wants to use it as metadata or data.
         */
-       ext3_debug("allocating block %d. Goal hits %d of %d.\n",
+       ext3_debug("allocating block %lu. Goal hits %d of %d.\n",
                        ret_block, goal_hits, goal_attempts);
 
        spin_lock(sb_bgl_lock(sbi, group_no));
@@ -1461,23 +1463,24 @@ out:
        return 0;
 }
 
-int ext3_new_block(handle_t *handle, struct inode *inode,
-                       unsigned long goal, int *errp)
+ext3_fsblk_t ext3_new_block(handle_t *handle, struct inode *inode,
+                       ext3_fsblk_t goal, int *errp)
 {
        unsigned long count = 1;
 
        return ext3_new_blocks(handle, inode, goal, &count, errp);
 }
 
-unsigned long ext3_count_free_blocks(struct super_block *sb)
+ext3_fsblk_t ext3_count_free_blocks(struct super_block *sb)
 {
-       unsigned long desc_count;
+       ext3_fsblk_t desc_count;
        struct ext3_group_desc *gdp;
        int i;
        unsigned long ngroups = EXT3_SB(sb)->s_groups_count;
 #ifdef EXT3FS_DEBUG
        struct ext3_super_block *es;
-       unsigned long bitmap_count, x;
+       ext3_fsblk_t bitmap_count;
+       unsigned long x;
        struct buffer_head *bitmap_bh = NULL;
 
        es = EXT3_SB(sb)->s_es;
@@ -1502,8 +1505,10 @@ unsigned long ext3_count_free_blocks(struct super_block *sb)
                bitmap_count += x;
        }
        brelse(bitmap_bh);
-       printk("ext3_count_free_blocks: stored = %u, computed = %lu, %lu\n",
-              le32_to_cpu(es->s_free_blocks_count), desc_count, bitmap_count);
+       printk("ext3_count_free_blocks: stored = "E3FSBLK
+               ", computed = "E3FSBLK", "E3FSBLK"\n",
+              le32_to_cpu(es->s_free_blocks_count),
+               desc_count, bitmap_count);
        return bitmap_count;
 #else
        desc_count = 0;
@@ -1520,7 +1525,7 @@ unsigned long ext3_count_free_blocks(struct super_block *sb)
 }
 
 static inline int
-block_in_use(unsigned long block, struct super_block *sb, unsigned char *map)
+block_in_use(ext3_fsblk_t block, struct super_block *sb, unsigned char *map)
 {
        return ext3_test_bit ((block -
                le32_to_cpu(EXT3_SB(sb)->s_es->s_first_data_block)) %