9p: do no return 0 from ->check_acl without actually checking

[pandora-kernel.git] / fs / 9p / acl.c

diff --git a/fs/9p/acl.c b/fs/9p/acl.c
index 535ab6e..df4d7a1 100644 (file)
--- a/fs/9p/acl.c
+++ b/fs/9p/acl.c
@@ -96,14 +96,11 @@ static struct posix_acl *v9fs_get_cached_acl(struct inode *inode, int type)
        return acl;
 }
 
-int v9fs_check_acl(struct inode *inode, int mask, unsigned int flags)
+int v9fs_check_acl(struct inode *inode, int mask)
 {
        struct posix_acl *acl;
        struct v9fs_session_info *v9ses;
 
-       if (flags & IPERM_FLAG_RCU)
-               return -ECHILD;
-
        v9ses = v9fs_inode2v9ses(inode);
        if (((v9ses->flags & V9FS_ACCESS_MASK) != V9FS_ACCESS_CLIENT) ||
                        ((v9ses->flags & V9FS_ACL_MASK) != V9FS_POSIX_ACL)) {
@@ -111,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask, unsigned int flags)
                 * On access = client  and acl = on mode get the acl
                 * values from the server
                 */
-               return 0;
+               return -EAGAIN;
        }
        acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);
 
@@ -185,12 +182,15 @@ int v9fs_acl_chmod(struct dentry *dentry)
 }
 
 int v9fs_set_create_acl(struct dentry *dentry,
-                       struct posix_acl *dpacl, struct posix_acl *pacl)
+                       struct posix_acl **dpacl, struct posix_acl **pacl)
 {
-       v9fs_set_acl(dentry, ACL_TYPE_DEFAULT, dpacl);
-       v9fs_set_acl(dentry, ACL_TYPE_ACCESS, pacl);
-       posix_acl_release(dpacl);
-       posix_acl_release(pacl);
+       if (dentry) {
+               v9fs_set_acl(dentry, ACL_TYPE_DEFAULT, *dpacl);
+               v9fs_set_acl(dentry, ACL_TYPE_ACCESS, *pacl);
+       }
+       posix_acl_release(*dpacl);
+       posix_acl_release(*pacl);
+       *dpacl = *pacl = NULL;
        return 0;
 }
 
@@ -212,11 +212,11 @@ int v9fs_acl_mode(struct inode *dir, mode_t *modep,
                struct posix_acl *clone;
 
                if (S_ISDIR(mode))
-                       *dpacl = acl;
+                       *dpacl = posix_acl_dup(acl);
                clone = posix_acl_clone(acl, GFP_NOFS);
-               retval = -ENOMEM;
+               posix_acl_release(acl);
                if (!clone)
-                       goto cleanup;
+                       return -ENOMEM;
 
                retval = posix_acl_create_masq(clone, &mode);
                if (retval < 0) {
@@ -225,11 +225,12 @@ int v9fs_acl_mode(struct inode *dir, mode_t *modep,
                }
                if (retval > 0)
                        *pacl = clone;
+               else
+                       posix_acl_release(clone);
        }
        *modep  = mode;
        return 0;
 cleanup:
-       posix_acl_release(acl);
        return retval;
 
 }