[SCSI] zfcp: Message cleanup
[pandora-kernel.git] / drivers / s390 / scsi / zfcp_dbf.c
index 0ab985c..7c72f50 100644 (file)
@@ -1,22 +1,9 @@
 /*
- * This file is part of the zfcp device driver for
- * FCP adapters for IBM System z9 and zSeries.
+ * zfcp device driver
  *
- * (C) Copyright IBM Corp. 2002, 2006
+ * Debug traces for zfcp.
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * Copyright IBM Corporation 2002, 2008
  */
 
 #include <linux/ctype.h>
@@ -29,8 +16,6 @@ module_param(dbfsize, uint, 0400);
 MODULE_PARM_DESC(dbfsize,
                 "number of pages for each debug feature area (default 4)");
 
-#define ZFCP_LOG_AREA                  ZFCP_LOG_AREA_OTHER
-
 static void zfcp_dbf_hexdump(debug_info_t *dbf, void *to, int to_len,
                             int level, char *from, int from_len)
 {
@@ -110,9 +95,8 @@ static void zfcp_dbf_outd(char **p, const char *label, char *buffer,
                *p += sprintf(*p, "\n");
 }
 
-static int
-zfcp_dbf_view_header(debug_info_t * id, struct debug_view *view, int area,
-                    debug_entry_t * entry, char *out_buf)
+static int zfcp_dbf_view_header(debug_info_t *id, struct debug_view *view,
+                               int area, debug_entry_t *entry, char *out_buf)
 {
        struct zfcp_dbf_dump *dump = (struct zfcp_dbf_dump *)DEBUG_DATA(entry);
        struct timespec t;
@@ -132,24 +116,28 @@ zfcp_dbf_view_header(debug_info_t * id, struct debug_view *view, int area,
        return p - out_buf;
 }
 
+/**
+ * zfcp_hba_dbf_event_fsf_response - trace event for request completion
+ * @fsf_req: request that has been completed
+ */
 void zfcp_hba_dbf_event_fsf_response(struct zfcp_fsf_req *fsf_req)
 {
        struct zfcp_adapter *adapter = fsf_req->adapter;
        struct fsf_qtcb *qtcb = fsf_req->qtcb;
        union fsf_prot_status_qual *prot_status_qual =
-           &qtcb->prefix.prot_status_qual;
+                                       &qtcb->prefix.prot_status_qual;
        union fsf_status_qual *fsf_status_qual = &qtcb->header.fsf_status_qual;
        struct scsi_cmnd *scsi_cmnd;
        struct zfcp_port *port;
        struct zfcp_unit *unit;
        struct zfcp_send_els *send_els;
        struct zfcp_hba_dbf_record *rec = &adapter->hba_dbf_buf;
-       struct zfcp_hba_dbf_record_response *response = &rec->type.response;
+       struct zfcp_hba_dbf_record_response *response = &rec->u.response;
        int level;
        unsigned long flags;
 
        spin_lock_irqsave(&adapter->hba_dbf_lock, flags);
-       memset(rec, 0, sizeof(struct zfcp_hba_dbf_record));
+       memset(rec, 0, sizeof(*rec));
        strncpy(rec->tag, "resp", ZFCP_DBF_TAG_SIZE);
 
        if ((qtcb->prefix.prot_status != FSF_PROT_GOOD) &&
@@ -183,8 +171,8 @@ void zfcp_hba_dbf_event_fsf_response(struct zfcp_fsf_req *fsf_req)
               fsf_status_qual, FSF_STATUS_QUALIFIER_SIZE);
        response->fsf_req_status = fsf_req->status;
        response->sbal_first = fsf_req->sbal_first;
-       response->sbal_curr = fsf_req->sbal_curr;
        response->sbal_last = fsf_req->sbal_last;
+       response->sbal_response = fsf_req->sbal_response;
        response->pool = fsf_req->pool != NULL;
        response->erp_action = (unsigned long)fsf_req->erp_action;
 
@@ -193,11 +181,9 @@ void zfcp_hba_dbf_event_fsf_response(struct zfcp_fsf_req *fsf_req)
                if (fsf_req->status & ZFCP_STATUS_FSFREQ_TASK_MANAGEMENT)
                        break;
                scsi_cmnd = (struct scsi_cmnd *)fsf_req->data;
-               if (scsi_cmnd != NULL) {
-                       response->data.send_fcp.scsi_cmnd
-                           = (unsigned long)scsi_cmnd;
-                       response->data.send_fcp.scsi_serial
-                           = scsi_cmnd->serial_number;
+               if (scsi_cmnd) {
+                       response->u.fcp.cmnd = (unsigned long)scsi_cmnd;
+                       response->u.fcp.serial = scsi_cmnd->serial_number;
                }
                break;
 
@@ -205,25 +191,25 @@ void zfcp_hba_dbf_event_fsf_response(struct zfcp_fsf_req *fsf_req)
        case FSF_QTCB_CLOSE_PORT:
        case FSF_QTCB_CLOSE_PHYSICAL_PORT:
                port = (struct zfcp_port *)fsf_req->data;
-               response->data.port.wwpn = port->wwpn;
-               response->data.port.d_id = port->d_id;
-               response->data.port.port_handle = qtcb->header.port_handle;
+               response->u.port.wwpn = port->wwpn;
+               response->u.port.d_id = port->d_id;
+               response->u.port.port_handle = qtcb->header.port_handle;
                break;
 
        case FSF_QTCB_OPEN_LUN:
        case FSF_QTCB_CLOSE_LUN:
                unit = (struct zfcp_unit *)fsf_req->data;
                port = unit->port;
-               response->data.unit.wwpn = port->wwpn;
-               response->data.unit.fcp_lun = unit->fcp_lun;
-               response->data.unit.port_handle = qtcb->header.port_handle;
-               response->data.unit.lun_handle = qtcb->header.lun_handle;
+               response->u.unit.wwpn = port->wwpn;
+               response->u.unit.fcp_lun = unit->fcp_lun;
+               response->u.unit.port_handle = qtcb->header.port_handle;
+               response->u.unit.lun_handle = qtcb->header.lun_handle;
                break;
 
        case FSF_QTCB_SEND_ELS:
                send_els = (struct zfcp_send_els *)fsf_req->data;
-               response->data.send_els.d_id = qtcb->bottom.support.d_id;
-               response->data.send_els.ls_code = send_els->ls_code >> 24;
+               response->u.els.d_id = qtcb->bottom.support.d_id;
+               response->u.els.ls_code = send_els->ls_code >> 24;
                break;
 
        case FSF_QTCB_ABORT_FCP_CMND:
@@ -235,8 +221,7 @@ void zfcp_hba_dbf_event_fsf_response(struct zfcp_fsf_req *fsf_req)
                break;
        }
 
-       debug_event(adapter->hba_dbf, level,
-                   rec, sizeof(struct zfcp_hba_dbf_record));
+       debug_event(adapter->hba_dbf, level, rec, sizeof(*rec));
 
        /* have fcp channel microcode fixed to use as little as possible */
        if (fsf_req->fsf_command != FSF_QTCB_FCP_CMND) {
@@ -251,34 +236,39 @@ void zfcp_hba_dbf_event_fsf_response(struct zfcp_fsf_req *fsf_req)
        spin_unlock_irqrestore(&adapter->hba_dbf_lock, flags);
 }
 
-void
-zfcp_hba_dbf_event_fsf_unsol(const char *tag, struct zfcp_adapter *adapter,
-                            struct fsf_status_read_buffer *status_buffer)
+/**
+ * zfcp_hba_dbf_event_fsf_unsol - trace event for an unsolicited status buffer
+ * @tag: tag indicating which kind of unsolicited status has been received
+ * @adapter: adapter that has issued the unsolicited status buffer
+ * @status_buffer: buffer containing payload of unsolicited status
+ */
+void zfcp_hba_dbf_event_fsf_unsol(const char *tag, struct zfcp_adapter *adapter,
+                                 struct fsf_status_read_buffer *status_buffer)
 {
        struct zfcp_hba_dbf_record *rec = &adapter->hba_dbf_buf;
        unsigned long flags;
 
        spin_lock_irqsave(&adapter->hba_dbf_lock, flags);
-       memset(rec, 0, sizeof(struct zfcp_hba_dbf_record));
+       memset(rec, 0, sizeof(*rec));
        strncpy(rec->tag, "stat", ZFCP_DBF_TAG_SIZE);
        strncpy(rec->tag2, tag, ZFCP_DBF_TAG_SIZE);
 
-       rec->type.status.failed = adapter->status_read_failed;
+       rec->u.status.failed = atomic_read(&adapter->stat_miss);
        if (status_buffer != NULL) {
-               rec->type.status.status_type = status_buffer->status_type;
-               rec->type.status.status_subtype = status_buffer->status_subtype;
-               memcpy(&rec->type.status.queue_designator,
+               rec->u.status.status_type = status_buffer->status_type;
+               rec->u.status.status_subtype = status_buffer->status_subtype;
+               memcpy(&rec->u.status.queue_designator,
                       &status_buffer->queue_designator,
                       sizeof(struct fsf_queue_designator));
 
                switch (status_buffer->status_type) {
                case FSF_STATUS_READ_SENSE_DATA_AVAIL:
-                       rec->type.status.payload_size =
+                       rec->u.status.payload_size =
                            ZFCP_DBF_UNSOL_PAYLOAD_SENSE_DATA_AVAIL;
                        break;
 
                case FSF_STATUS_READ_BIT_ERROR_THRESHOLD:
-                       rec->type.status.payload_size =
+                       rec->u.status.payload_size =
                            ZFCP_DBF_UNSOL_PAYLOAD_BIT_ERROR_THRESHOLD;
                        break;
 
@@ -286,43 +276,49 @@ zfcp_hba_dbf_event_fsf_unsol(const char *tag, struct zfcp_adapter *adapter,
                        switch (status_buffer->status_subtype) {
                        case FSF_STATUS_READ_SUB_NO_PHYSICAL_LINK:
                        case FSF_STATUS_READ_SUB_FDISC_FAILED:
-                               rec->type.status.payload_size =
+                               rec->u.status.payload_size =
                                        sizeof(struct fsf_link_down_info);
                        }
                        break;
 
                case FSF_STATUS_READ_FEATURE_UPDATE_ALERT:
-                       rec->type.status.payload_size =
+                       rec->u.status.payload_size =
                            ZFCP_DBF_UNSOL_PAYLOAD_FEATURE_UPDATE_ALERT;
                        break;
                }
-               memcpy(&rec->type.status.payload,
-                      &status_buffer->payload, rec->type.status.payload_size);
+               memcpy(&rec->u.status.payload,
+                      &status_buffer->payload, rec->u.status.payload_size);
        }
 
-       debug_event(adapter->hba_dbf, 2,
-                   rec, sizeof(struct zfcp_hba_dbf_record));
+       debug_event(adapter->hba_dbf, 2, rec, sizeof(*rec));
        spin_unlock_irqrestore(&adapter->hba_dbf_lock, flags);
 }
 
-void
-zfcp_hba_dbf_event_qdio(struct zfcp_adapter *adapter, unsigned int status,
-                       unsigned int qdio_error, unsigned int siga_error,
-                       int sbal_index, int sbal_count)
+/**
+ * zfcp_hba_dbf_event_qdio - trace event for QDIO related failure
+ * @adapter: adapter affected by this QDIO related event
+ * @status: as passed by qdio module
+ * @qdio_error: as passed by qdio module
+ * @siga_error: as passed by qdio module
+ * @sbal_index: first buffer with error condition, as passed by qdio module
+ * @sbal_count: number of buffers affected, as passed by qdio module
+ */
+void zfcp_hba_dbf_event_qdio(struct zfcp_adapter *adapter, unsigned int status,
+                            unsigned int qdio_error, unsigned int siga_error,
+                            int sbal_index, int sbal_count)
 {
-       struct zfcp_hba_dbf_record *rec = &adapter->hba_dbf_buf;
+       struct zfcp_hba_dbf_record *r = &adapter->hba_dbf_buf;
        unsigned long flags;
 
        spin_lock_irqsave(&adapter->hba_dbf_lock, flags);
-       memset(rec, 0, sizeof(struct zfcp_hba_dbf_record));
-       strncpy(rec->tag, "qdio", ZFCP_DBF_TAG_SIZE);
-       rec->type.qdio.status = status;
-       rec->type.qdio.qdio_error = qdio_error;
-       rec->type.qdio.siga_error = siga_error;
-       rec->type.qdio.sbal_index = sbal_index;
-       rec->type.qdio.sbal_count = sbal_count;
-       debug_event(adapter->hba_dbf, 0,
-                   rec, sizeof(struct zfcp_hba_dbf_record));
+       memset(r, 0, sizeof(*r));
+       strncpy(r->tag, "qdio", ZFCP_DBF_TAG_SIZE);
+       r->u.qdio.status = status;
+       r->u.qdio.qdio_error = qdio_error;
+       r->u.qdio.siga_error = siga_error;
+       r->u.qdio.sbal_index = sbal_index;
+       r->u.qdio.sbal_count = sbal_count;
+       debug_event(adapter->hba_dbf, 0, r, sizeof(*r));
        spin_unlock_irqrestore(&adapter->hba_dbf_lock, flags);
 }
 
@@ -344,42 +340,37 @@ static void zfcp_hba_dbf_view_response(char **p,
                      FSF_STATUS_QUALIFIER_SIZE, 0, FSF_STATUS_QUALIFIER_SIZE);
        zfcp_dbf_out(p, "fsf_req_status", "0x%08x", r->fsf_req_status);
        zfcp_dbf_out(p, "sbal_first", "0x%02x", r->sbal_first);
-       zfcp_dbf_out(p, "sbal_curr", "0x%02x", r->sbal_curr);
        zfcp_dbf_out(p, "sbal_last", "0x%02x", r->sbal_last);
+       zfcp_dbf_out(p, "sbal_response", "0x%02x", r->sbal_response);
        zfcp_dbf_out(p, "pool", "0x%02x", r->pool);
 
        switch (r->fsf_command) {
        case FSF_QTCB_FCP_CMND:
                if (r->fsf_req_status & ZFCP_STATUS_FSFREQ_TASK_MANAGEMENT)
                        break;
-               zfcp_dbf_out(p, "scsi_cmnd", "0x%0Lx",
-                            r->data.send_fcp.scsi_cmnd);
-               zfcp_dbf_out(p, "scsi_serial", "0x%016Lx",
-                            r->data.send_fcp.scsi_serial);
+               zfcp_dbf_out(p, "scsi_cmnd", "0x%0Lx", r->u.fcp.cmnd);
+               zfcp_dbf_out(p, "scsi_serial", "0x%016Lx", r->u.fcp.serial);
                break;
 
        case FSF_QTCB_OPEN_PORT_WITH_DID:
        case FSF_QTCB_CLOSE_PORT:
        case FSF_QTCB_CLOSE_PHYSICAL_PORT:
-               zfcp_dbf_out(p, "wwpn", "0x%016Lx", r->data.port.wwpn);
-               zfcp_dbf_out(p, "d_id", "0x%06x", r->data.port.d_id);
-               zfcp_dbf_out(p, "port_handle", "0x%08x",
-                            r->data.port.port_handle);
+               zfcp_dbf_out(p, "wwpn", "0x%016Lx", r->u.port.wwpn);
+               zfcp_dbf_out(p, "d_id", "0x%06x", r->u.port.d_id);
+               zfcp_dbf_out(p, "port_handle", "0x%08x", r->u.port.port_handle);
                break;
 
        case FSF_QTCB_OPEN_LUN:
        case FSF_QTCB_CLOSE_LUN:
-               zfcp_dbf_out(p, "wwpn", "0x%016Lx", r->data.unit.wwpn);
-               zfcp_dbf_out(p, "fcp_lun", "0x%016Lx", r->data.unit.fcp_lun);
-               zfcp_dbf_out(p, "port_handle", "0x%08x",
-                            r->data.unit.port_handle);
-               zfcp_dbf_out(p, "lun_handle", "0x%08x",
-                            r->data.unit.lun_handle);
+               zfcp_dbf_out(p, "wwpn", "0x%016Lx", r->u.unit.wwpn);
+               zfcp_dbf_out(p, "fcp_lun", "0x%016Lx", r->u.unit.fcp_lun);
+               zfcp_dbf_out(p, "port_handle", "0x%08x", r->u.unit.port_handle);
+               zfcp_dbf_out(p, "lun_handle", "0x%08x", r->u.unit.lun_handle);
                break;
 
        case FSF_QTCB_SEND_ELS:
-               zfcp_dbf_out(p, "d_id", "0x%06x", r->data.send_els.d_id);
-               zfcp_dbf_out(p, "ls_code", "0x%02x", r->data.send_els.ls_code);
+               zfcp_dbf_out(p, "d_id", "0x%06x", r->u.els.d_id);
+               zfcp_dbf_out(p, "ls_code", "0x%02x", r->u.els.ls_code);
                break;
 
        case FSF_QTCB_ABORT_FCP_CMND:
@@ -428,11 +419,11 @@ static int zfcp_hba_dbf_view_format(debug_info_t *id, struct debug_view *view,
                zfcp_dbf_tag(&p, "tag2", r->tag2);
 
        if (strncmp(r->tag, "resp", ZFCP_DBF_TAG_SIZE) == 0)
-               zfcp_hba_dbf_view_response(&p, &r->type.response);
+               zfcp_hba_dbf_view_response(&p, &r->u.response);
        else if (strncmp(r->tag, "stat", ZFCP_DBF_TAG_SIZE) == 0)
-               zfcp_hba_dbf_view_status(&p, &r->type.status);
+               zfcp_hba_dbf_view_status(&p, &r->u.status);
        else if (strncmp(r->tag, "qdio", ZFCP_DBF_TAG_SIZE) == 0)
-               zfcp_hba_dbf_view_qdio(&p, &r->type.qdio);
+               zfcp_hba_dbf_view_qdio(&p, &r->u.qdio);
 
        p += sprintf(p, "\n");
        return p - out_buf;
@@ -509,13 +500,13 @@ static const char *zfcp_rec_dbf_ids[] = {
        [52]    = "port boxed close unit",
        [53]    = "port boxed fcp",
        [54]    = "unit boxed fcp",
-       [55]    = "port access denied ct",
-       [56]    = "port access denied els",
-       [57]    = "port access denied open port",
-       [58]    = "port access denied close physical",
-       [59]    = "unit access denied open unit",
+       [55]    = "port access denied",
+       [56]    = "",
+       [57]    = "",
+       [58]    = "",
+       [59]    = "unit access denied",
        [60]    = "shared unit access denied open unit",
-       [61]    = "unit access denied fcp",
+       [61]    = "",
        [62]    = "request timeout",
        [63]    = "adisc link test reject or timeout",
        [64]    = "adisc link test d_id changed",
@@ -540,8 +531,8 @@ static const char *zfcp_rec_dbf_ids[] = {
        [80]    = "exclusive read-only unit access unsupported",
        [81]    = "shared read-write unit access unsupported",
        [82]    = "incoming rscn",
-       [83]    = "incoming plogi",
-       [84]    = "incoming logo",
+       [83]    = "incoming wwpn",
+       [84]    = "",
        [85]    = "online",
        [86]    = "offline",
        [87]    = "ccw device gone",
@@ -580,8 +571,8 @@ static const char *zfcp_rec_dbf_ids[] = {
        [120]   = "unknown fsf command",
        [121]   = "no recommendation for status qualifier",
        [122]   = "status read physical port closed in error",
-       [123]   = "fc service class not supported ct",
-       [124]   = "fc service class not supported els",
+       [123]   = "fc service class not supported",
+       [124]   = "",
        [125]   = "need newer zfcp",
        [126]   = "need newer microcode",
        [127]   = "arbitrated loop not supported",
@@ -589,7 +580,7 @@ static const char *zfcp_rec_dbf_ids[] = {
        [129]   = "qtcb size mismatch",
        [130]   = "unknown fsf status ecd",
        [131]   = "fcp request too big",
-       [132]   = "fc service class not supported fcp",
+       [132]   = "",
        [133]   = "data direction not valid fcp",
        [134]   = "command length not valid fcp",
        [135]   = "status read act update",
@@ -597,13 +588,14 @@ static const char *zfcp_rec_dbf_ids[] = {
        [137]   = "hbaapi port open",
        [138]   = "hbaapi unit open",
        [139]   = "hbaapi unit shutdown",
-       [140]   = "qdio error",
+       [140]   = "qdio error outbound",
        [141]   = "scsi host reset",
        [142]   = "dismissing fsf request for recovery action",
        [143]   = "recovery action timed out",
        [144]   = "recovery action gone",
        [145]   = "recovery action being processed",
        [146]   = "recovery action ready for next step",
+       [147]   = "qdio error inbound",
 };
 
 static int zfcp_rec_dbf_view_format(debug_info_t *id, struct debug_view *view,
@@ -617,7 +609,6 @@ static int zfcp_rec_dbf_view_format(debug_info_t *id, struct debug_view *view,
        zfcp_dbf_out(&p, "id", "%d", r->id2);
        switch (r->id) {
        case ZFCP_REC_DBF_ID_THREAD:
-               zfcp_dbf_out(&p, "sema", "%d", r->u.thread.sema);
                zfcp_dbf_out(&p, "total", "%d", r->u.thread.total);
                zfcp_dbf_out(&p, "ready", "%d", r->u.thread.ready);
                zfcp_dbf_out(&p, "running", "%d", r->u.thread.running);
@@ -665,38 +656,48 @@ static struct debug_view zfcp_rec_dbf_view = {
  * zfcp_rec_dbf_event_thread - trace event related to recovery thread operation
  * @id2: identifier for event
  * @adapter: adapter
- * @lock: non-zero value indicates that erp_lock has not yet been acquired
+ * This function assumes that the caller is holding erp_lock.
  */
-void zfcp_rec_dbf_event_thread(u8 id2, struct zfcp_adapter *adapter, int lock)
+void zfcp_rec_dbf_event_thread(u8 id2, struct zfcp_adapter *adapter)
 {
        struct zfcp_rec_dbf_record *r = &adapter->rec_dbf_buf;
        unsigned long flags = 0;
        struct list_head *entry;
        unsigned ready = 0, running = 0, total;
 
-       if (lock)
-               read_lock_irqsave(&adapter->erp_lock, flags);
        list_for_each(entry, &adapter->erp_ready_head)
                ready++;
        list_for_each(entry, &adapter->erp_running_head)
                running++;
        total = adapter->erp_total_count;
-       if (lock)
-               read_unlock_irqrestore(&adapter->erp_lock, flags);
 
        spin_lock_irqsave(&adapter->rec_dbf_lock, flags);
        memset(r, 0, sizeof(*r));
        r->id = ZFCP_REC_DBF_ID_THREAD;
        r->id2 = id2;
-       r->u.thread.sema = atomic_read(&adapter->erp_ready_sem.count);
        r->u.thread.total = total;
        r->u.thread.ready = ready;
        r->u.thread.running = running;
-       debug_event(adapter->rec_dbf, 5, r, sizeof(*r));
+       debug_event(adapter->rec_dbf, 6, r, sizeof(*r));
        spin_unlock_irqrestore(&adapter->rec_dbf_lock, flags);
 }
 
-static void zfcp_rec_dbf_event_target(u8 id2, u64 ref,
+/**
+ * zfcp_rec_dbf_event_thread - trace event related to recovery thread operation
+ * @id2: identifier for event
+ * @adapter: adapter
+ * This function assumes that the caller does not hold erp_lock.
+ */
+void zfcp_rec_dbf_event_thread_lock(u8 id2, struct zfcp_adapter *adapter)
+{
+       unsigned long flags;
+
+       read_lock_irqsave(&adapter->erp_lock, flags);
+       zfcp_rec_dbf_event_thread(id2, adapter);
+       read_unlock_irqrestore(&adapter->erp_lock, flags);
+}
+
+static void zfcp_rec_dbf_event_target(u8 id2, void *ref,
                                      struct zfcp_adapter *adapter,
                                      atomic_t *status, atomic_t *erp_count,
                                      u64 wwpn, u32 d_id, u64 fcp_lun)
@@ -708,7 +709,7 @@ static void zfcp_rec_dbf_event_target(u8 id2, u64 ref,
        memset(r, 0, sizeof(*r));
        r->id = ZFCP_REC_DBF_ID_TARGET;
        r->id2 = id2;
-       r->u.target.ref = ref;
+       r->u.target.ref = (unsigned long)ref;
        r->u.target.status = atomic_read(status);
        r->u.target.wwpn = wwpn;
        r->u.target.d_id = d_id;
@@ -724,7 +725,7 @@ static void zfcp_rec_dbf_event_target(u8 id2, u64 ref,
  * @ref: additional reference (e.g. request)
  * @adapter: adapter
  */
-void zfcp_rec_dbf_event_adapter(u8 id, u64 ref, struct zfcp_adapter *adapter)
+void zfcp_rec_dbf_event_adapter(u8 id, void *ref, struct zfcp_adapter *adapter)
 {
        zfcp_rec_dbf_event_target(id, ref, adapter, &adapter->status,
                                  &adapter->erp_counter, 0, 0, 0);
@@ -736,7 +737,7 @@ void zfcp_rec_dbf_event_adapter(u8 id, u64 ref, struct zfcp_adapter *adapter)
  * @ref: additional reference (e.g. request)
  * @port: port
  */
-void zfcp_rec_dbf_event_port(u8 id, u64 ref, struct zfcp_port *port)
+void zfcp_rec_dbf_event_port(u8 id, void *ref, struct zfcp_port *port)
 {
        struct zfcp_adapter *adapter = port->adapter;
 
@@ -751,7 +752,7 @@ void zfcp_rec_dbf_event_port(u8 id, u64 ref, struct zfcp_port *port)
  * @ref: additional reference (e.g. request)
  * @unit: unit
  */
-void zfcp_rec_dbf_event_unit(u8 id, u64 ref, struct zfcp_unit *unit)
+void zfcp_rec_dbf_event_unit(u8 id, void *ref, struct zfcp_unit *unit)
 {
        struct zfcp_port *port = unit->port;
        struct zfcp_adapter *adapter = port->adapter;
@@ -772,8 +773,8 @@ void zfcp_rec_dbf_event_unit(u8 id, u64 ref, struct zfcp_unit *unit)
  * @port: port
  * @unit: unit
  */
-void zfcp_rec_dbf_event_trigger(u8 id2, u64 ref, u8 want, u8 need, u64 action,
-                               struct zfcp_adapter *adapter,
+void zfcp_rec_dbf_event_trigger(u8 id2, void *ref, u8 want, u8 need,
+                               void *action, struct zfcp_adapter *adapter,
                                struct zfcp_port *port, struct zfcp_unit *unit)
 {
        struct zfcp_rec_dbf_record *r = &adapter->rec_dbf_buf;
@@ -783,10 +784,10 @@ void zfcp_rec_dbf_event_trigger(u8 id2, u64 ref, u8 want, u8 need, u64 action,
        memset(r, 0, sizeof(*r));
        r->id = ZFCP_REC_DBF_ID_TRIGGER;
        r->id2 = id2;
-       r->u.trigger.ref = ref;
+       r->u.trigger.ref = (unsigned long)ref;
        r->u.trigger.want = want;
        r->u.trigger.need = need;
-       r->u.trigger.action = action;
+       r->u.trigger.action = (unsigned long)action;
        r->u.trigger.as = atomic_read(&adapter->status);
        if (port) {
                r->u.trigger.ps = atomic_read(&port->status);
@@ -815,142 +816,153 @@ void zfcp_rec_dbf_event_action(u8 id2, struct zfcp_erp_action *erp_action)
        memset(r, 0, sizeof(*r));
        r->id = ZFCP_REC_DBF_ID_ACTION;
        r->id2 = id2;
-       r->u.action.action = (u64)erp_action;
+       r->u.action.action = (unsigned long)erp_action;
        r->u.action.status = erp_action->status;
        r->u.action.step = erp_action->step;
-       r->u.action.fsf_req = (u64)erp_action->fsf_req;
-       debug_event(adapter->rec_dbf, 4, r, sizeof(*r));
+       r->u.action.fsf_req = (unsigned long)erp_action->fsf_req;
+       debug_event(adapter->rec_dbf, 5, r, sizeof(*r));
        spin_unlock_irqrestore(&adapter->rec_dbf_lock, flags);
 }
 
-static void
-_zfcp_san_dbf_event_common_ct(const char *tag, struct zfcp_fsf_req *fsf_req,
-                             u32 s_id, u32 d_id, void *buffer, int buflen)
-{
-       struct zfcp_send_ct *send_ct = (struct zfcp_send_ct *)fsf_req->data;
-       struct zfcp_port *port = send_ct->port;
-       struct zfcp_adapter *adapter = port->adapter;
-       struct ct_hdr *header = (struct ct_hdr *)buffer;
-       struct zfcp_san_dbf_record *rec = &adapter->san_dbf_buf;
-       struct zfcp_san_dbf_record_ct *ct = &rec->type.ct;
-       unsigned long flags;
-
-       spin_lock_irqsave(&adapter->san_dbf_lock, flags);
-       memset(rec, 0, sizeof(struct zfcp_san_dbf_record));
-       strncpy(rec->tag, tag, ZFCP_DBF_TAG_SIZE);
-       rec->fsf_reqid = (unsigned long)fsf_req;
-       rec->fsf_seqno = fsf_req->seq_no;
-       rec->s_id = s_id;
-       rec->d_id = d_id;
-       if (strncmp(tag, "octc", ZFCP_DBF_TAG_SIZE) == 0) {
-               ct->type.request.cmd_req_code = header->cmd_rsp_code;
-               ct->type.request.revision = header->revision;
-               ct->type.request.gs_type = header->gs_type;
-               ct->type.request.gs_subtype = header->gs_subtype;
-               ct->type.request.options = header->options;
-               ct->type.request.max_res_size = header->max_res_size;
-       } else if (strncmp(tag, "rctc", ZFCP_DBF_TAG_SIZE) == 0) {
-               ct->type.response.cmd_rsp_code = header->cmd_rsp_code;
-               ct->type.response.revision = header->revision;
-               ct->type.response.reason_code = header->reason_code;
-               ct->type.response.reason_code_expl = header->reason_code_expl;
-               ct->type.response.vendor_unique = header->vendor_unique;
-       }
-       ct->payload_size =
-           min(buflen - (int)sizeof(struct ct_hdr), ZFCP_DBF_CT_PAYLOAD);
-       memcpy(ct->payload, buffer + sizeof(struct ct_hdr), ct->payload_size);
-       debug_event(adapter->san_dbf, 3,
-                   rec, sizeof(struct zfcp_san_dbf_record));
-       spin_unlock_irqrestore(&adapter->san_dbf_lock, flags);
-}
-
+/**
+ * zfcp_san_dbf_event_ct_request - trace event for issued CT request
+ * @fsf_req: request containing issued CT data
+ */
 void zfcp_san_dbf_event_ct_request(struct zfcp_fsf_req *fsf_req)
 {
        struct zfcp_send_ct *ct = (struct zfcp_send_ct *)fsf_req->data;
        struct zfcp_port *port = ct->port;
        struct zfcp_adapter *adapter = port->adapter;
+       struct ct_hdr *hdr = zfcp_sg_to_address(ct->req);
+       struct zfcp_san_dbf_record *r = &adapter->san_dbf_buf;
+       struct zfcp_san_dbf_record_ct_request *oct = &r->u.ct_req;
+       unsigned long flags;
 
-       _zfcp_san_dbf_event_common_ct("octc", fsf_req,
-                                     fc_host_port_id(adapter->scsi_host),
-                                     port->d_id, zfcp_sg_to_address(ct->req),
-                                     ct->req->length);
+       spin_lock_irqsave(&adapter->san_dbf_lock, flags);
+       memset(r, 0, sizeof(*r));
+       strncpy(r->tag, "octc", ZFCP_DBF_TAG_SIZE);
+       r->fsf_reqid = (unsigned long)fsf_req;
+       r->fsf_seqno = fsf_req->seq_no;
+       r->s_id = fc_host_port_id(adapter->scsi_host);
+       r->d_id = port->d_id;
+       oct->cmd_req_code = hdr->cmd_rsp_code;
+       oct->revision = hdr->revision;
+       oct->gs_type = hdr->gs_type;
+       oct->gs_subtype = hdr->gs_subtype;
+       oct->options = hdr->options;
+       oct->max_res_size = hdr->max_res_size;
+       oct->len = min((int)ct->req->length - (int)sizeof(struct ct_hdr),
+                      ZFCP_DBF_CT_PAYLOAD);
+       memcpy(oct->payload, (void *)hdr + sizeof(struct ct_hdr), oct->len);
+       debug_event(adapter->san_dbf, 3, r, sizeof(*r));
+       spin_unlock_irqrestore(&adapter->san_dbf_lock, flags);
 }
 
+/**
+ * zfcp_san_dbf_event_ct_response - trace event for completion of CT request
+ * @fsf_req: request containing CT response
+ */
 void zfcp_san_dbf_event_ct_response(struct zfcp_fsf_req *fsf_req)
 {
        struct zfcp_send_ct *ct = (struct zfcp_send_ct *)fsf_req->data;
        struct zfcp_port *port = ct->port;
        struct zfcp_adapter *adapter = port->adapter;
+       struct ct_hdr *hdr = zfcp_sg_to_address(ct->resp);
+       struct zfcp_san_dbf_record *r = &adapter->san_dbf_buf;
+       struct zfcp_san_dbf_record_ct_response *rct = &r->u.ct_resp;
+       unsigned long flags;
 
-       _zfcp_san_dbf_event_common_ct("rctc", fsf_req, port->d_id,
-                                     fc_host_port_id(adapter->scsi_host),
-                                     zfcp_sg_to_address(ct->resp),
-                                     ct->resp->length);
+       spin_lock_irqsave(&adapter->san_dbf_lock, flags);
+       memset(r, 0, sizeof(*r));
+       strncpy(r->tag, "rctc", ZFCP_DBF_TAG_SIZE);
+       r->fsf_reqid = (unsigned long)fsf_req;
+       r->fsf_seqno = fsf_req->seq_no;
+       r->s_id = port->d_id;
+       r->d_id = fc_host_port_id(adapter->scsi_host);
+       rct->cmd_rsp_code = hdr->cmd_rsp_code;
+       rct->revision = hdr->revision;
+       rct->reason_code = hdr->reason_code;
+       rct->expl = hdr->reason_code_expl;
+       rct->vendor_unique = hdr->vendor_unique;
+       rct->len = min((int)ct->resp->length - (int)sizeof(struct ct_hdr),
+                      ZFCP_DBF_CT_PAYLOAD);
+       memcpy(rct->payload, (void *)hdr + sizeof(struct ct_hdr), rct->len);
+       debug_event(adapter->san_dbf, 3, r, sizeof(*r));
+       spin_unlock_irqrestore(&adapter->san_dbf_lock, flags);
 }
 
-static void
-_zfcp_san_dbf_event_common_els(const char *tag, int level,
-                              struct zfcp_fsf_req *fsf_req, u32 s_id,
-                              u32 d_id, u8 ls_code, void *buffer, int buflen)
+static void zfcp_san_dbf_event_els(const char *tag, int level,
+                                  struct zfcp_fsf_req *fsf_req, u32 s_id,
+                                  u32 d_id, u8 ls_code, void *buffer,
+                                  int buflen)
 {
        struct zfcp_adapter *adapter = fsf_req->adapter;
        struct zfcp_san_dbf_record *rec = &adapter->san_dbf_buf;
        unsigned long flags;
 
        spin_lock_irqsave(&adapter->san_dbf_lock, flags);
-       memset(rec, 0, sizeof(struct zfcp_san_dbf_record));
+       memset(rec, 0, sizeof(*rec));
        strncpy(rec->tag, tag, ZFCP_DBF_TAG_SIZE);
        rec->fsf_reqid = (unsigned long)fsf_req;
        rec->fsf_seqno = fsf_req->seq_no;
        rec->s_id = s_id;
        rec->d_id = d_id;
-       rec->type.els.ls_code = ls_code;
+       rec->u.els.ls_code = ls_code;
        debug_event(adapter->san_dbf, level, rec, sizeof(*rec));
        zfcp_dbf_hexdump(adapter->san_dbf, rec, sizeof(*rec), level,
                         buffer, min(buflen, ZFCP_DBF_ELS_MAX_PAYLOAD));
        spin_unlock_irqrestore(&adapter->san_dbf_lock, flags);
 }
 
+/**
+ * zfcp_san_dbf_event_els_request - trace event for issued ELS
+ * @fsf_req: request containing issued ELS
+ */
 void zfcp_san_dbf_event_els_request(struct zfcp_fsf_req *fsf_req)
 {
        struct zfcp_send_els *els = (struct zfcp_send_els *)fsf_req->data;
 
-       _zfcp_san_dbf_event_common_els("oels", 2, fsf_req,
-                                      fc_host_port_id(els->adapter->scsi_host),
-                                      els->d_id,
-                                      *(u8 *) zfcp_sg_to_address(els->req),
-                                      zfcp_sg_to_address(els->req),
-                                      els->req->length);
+       zfcp_san_dbf_event_els("oels", 2, fsf_req,
+                              fc_host_port_id(els->adapter->scsi_host),
+                              els->d_id, *(u8 *) zfcp_sg_to_address(els->req),
+                              zfcp_sg_to_address(els->req), els->req->length);
 }
 
+/**
+ * zfcp_san_dbf_event_els_response - trace event for completed ELS
+ * @fsf_req: request containing ELS response
+ */
 void zfcp_san_dbf_event_els_response(struct zfcp_fsf_req *fsf_req)
 {
        struct zfcp_send_els *els = (struct zfcp_send_els *)fsf_req->data;
 
-       _zfcp_san_dbf_event_common_els("rels", 2, fsf_req, els->d_id,
-                                      fc_host_port_id(els->adapter->scsi_host),
-                                      *(u8 *) zfcp_sg_to_address(els->req),
-                                      zfcp_sg_to_address(els->resp),
-                                      els->resp->length);
+       zfcp_san_dbf_event_els("rels", 2, fsf_req, els->d_id,
+                              fc_host_port_id(els->adapter->scsi_host),
+                              *(u8 *)zfcp_sg_to_address(els->req),
+                              zfcp_sg_to_address(els->resp),
+                              els->resp->length);
 }
 
+/**
+ * zfcp_san_dbf_event_incoming_els - trace event for incomig ELS
+ * @fsf_req: request containing unsolicited status buffer with incoming ELS
+ */
 void zfcp_san_dbf_event_incoming_els(struct zfcp_fsf_req *fsf_req)
 {
        struct zfcp_adapter *adapter = fsf_req->adapter;
-       struct fsf_status_read_buffer *status_buffer =
-           (struct fsf_status_read_buffer *)fsf_req->data;
-       int length = (int)status_buffer->length -
-           (int)((void *)&status_buffer->payload - (void *)status_buffer);
-
-       _zfcp_san_dbf_event_common_els("iels", 1, fsf_req, status_buffer->d_id,
-                                      fc_host_port_id(adapter->scsi_host),
-                                      *(u8 *) status_buffer->payload,
-                                      (void *)status_buffer->payload, length);
+       struct fsf_status_read_buffer *buf =
+                       (struct fsf_status_read_buffer *)fsf_req->data;
+       int length = (int)buf->length -
+                    (int)((void *)&buf->payload - (void *)buf);
+
+       zfcp_san_dbf_event_els("iels", 1, fsf_req, buf->d_id,
+                              fc_host_port_id(adapter->scsi_host),
+                              *(u8 *)buf->payload, (void *)buf->payload,
+                              length);
 }
 
-static int
-zfcp_san_dbf_view_format(debug_info_t * id, struct debug_view *view,
-                        char *out_buf, const char *in_buf)
+static int zfcp_san_dbf_view_format(debug_info_t *id, struct debug_view *view,
+                                   char *out_buf, const char *in_buf)
 {
        struct zfcp_san_dbf_record *r = (struct zfcp_san_dbf_record *)in_buf;
        char *buffer = NULL;
@@ -967,42 +979,33 @@ zfcp_san_dbf_view_format(debug_info_t * id, struct debug_view *view,
        zfcp_dbf_out(&p, "d_id", "0x%06x", r->d_id);
 
        if (strncmp(r->tag, "octc", ZFCP_DBF_TAG_SIZE) == 0) {
-               /* FIXME: struct zfcp_dbf_ct_req *ct = ...; */
-               zfcp_dbf_out(&p, "cmd_req_code", "0x%04x",
-                            r->type.ct.type.request.cmd_req_code);
-               zfcp_dbf_out(&p, "revision", "0x%02x",
-                            r->type.ct.type.request.revision);
-               zfcp_dbf_out(&p, "gs_type", "0x%02x",
-                            r->type.ct.type.request.gs_type);
-               zfcp_dbf_out(&p, "gs_subtype", "0x%02x",
-                            r->type.ct.type.request.gs_subtype);
-               zfcp_dbf_out(&p, "options", "0x%02x",
-                            r->type.ct.type.request.options);
-               zfcp_dbf_out(&p, "max_res_size", "0x%04x",
-                            r->type.ct.type.request.max_res_size);
-               total = r->type.ct.payload_size;
-               buffer = r->type.ct.payload;
+               struct zfcp_san_dbf_record_ct_request *ct = &r->u.ct_req;
+               zfcp_dbf_out(&p, "cmd_req_code", "0x%04x", ct->cmd_req_code);
+               zfcp_dbf_out(&p, "revision", "0x%02x", ct->revision);
+               zfcp_dbf_out(&p, "gs_type", "0x%02x", ct->gs_type);
+               zfcp_dbf_out(&p, "gs_subtype", "0x%02x", ct->gs_subtype);
+               zfcp_dbf_out(&p, "options", "0x%02x", ct->options);
+               zfcp_dbf_out(&p, "max_res_size", "0x%04x", ct->max_res_size);
+               total = ct->len;
+               buffer = ct->payload;
                buflen = min(total, ZFCP_DBF_CT_PAYLOAD);
        } else if (strncmp(r->tag, "rctc", ZFCP_DBF_TAG_SIZE) == 0) {
-               zfcp_dbf_out(&p, "cmd_rsp_code", "0x%04x",
-                            r->type.ct.type.response.cmd_rsp_code);
-               zfcp_dbf_out(&p, "revision", "0x%02x",
-                            r->type.ct.type.response.revision);
-               zfcp_dbf_out(&p, "reason_code", "0x%02x",
-                            r->type.ct.type.response.reason_code);
-               zfcp_dbf_out(&p, "reason_code_expl", "0x%02x",
-                            r->type.ct.type.response.reason_code_expl);
-               zfcp_dbf_out(&p, "vendor_unique", "0x%02x",
-                            r->type.ct.type.response.vendor_unique);
-               total = r->type.ct.payload_size;
-               buffer = r->type.ct.payload;
+               struct zfcp_san_dbf_record_ct_response *ct = &r->u.ct_resp;
+               zfcp_dbf_out(&p, "cmd_rsp_code", "0x%04x", ct->cmd_rsp_code);
+               zfcp_dbf_out(&p, "revision", "0x%02x", ct->revision);
+               zfcp_dbf_out(&p, "reason_code", "0x%02x", ct->reason_code);
+               zfcp_dbf_out(&p, "reason_code_expl", "0x%02x", ct->expl);
+               zfcp_dbf_out(&p, "vendor_unique", "0x%02x", ct->vendor_unique);
+               total = ct->len;
+               buffer = ct->payload;
                buflen = min(total, ZFCP_DBF_CT_PAYLOAD);
        } else if (strncmp(r->tag, "oels", ZFCP_DBF_TAG_SIZE) == 0 ||
                   strncmp(r->tag, "rels", ZFCP_DBF_TAG_SIZE) == 0 ||
                   strncmp(r->tag, "iels", ZFCP_DBF_TAG_SIZE) == 0) {
-               zfcp_dbf_out(&p, "ls_code", "0x%02x", r->type.els.ls_code);
-               total = r->type.els.payload_size;
-               buffer = r->type.els.payload;
+               struct zfcp_san_dbf_record_els *els = &r->u.els;
+               zfcp_dbf_out(&p, "ls_code", "0x%02x", els->ls_code);
+               total = els->len;
+               buffer = els->payload;
                buflen = min(total, ZFCP_DBF_ELS_PAYLOAD);
        }
 
@@ -1022,12 +1025,11 @@ static struct debug_view zfcp_san_dbf_view = {
        NULL
 };
 
-static void
-_zfcp_scsi_dbf_event_common(const char *tag, const char *tag2, int level,
-                           struct zfcp_adapter *adapter,
-                           struct scsi_cmnd *scsi_cmnd,
-                           struct zfcp_fsf_req *fsf_req,
-                           unsigned long old_req_id)
+static void zfcp_scsi_dbf_event(const char *tag, const char *tag2, int level,
+                               struct zfcp_adapter *adapter,
+                               struct scsi_cmnd *scsi_cmnd,
+                               struct zfcp_fsf_req *fsf_req,
+                               unsigned long old_req_id)
 {
        struct zfcp_scsi_dbf_record *rec = &adapter->scsi_dbf_buf;
        struct zfcp_dbf_dump *dump = (struct zfcp_dbf_dump *)rec;
@@ -1038,7 +1040,7 @@ _zfcp_scsi_dbf_event_common(const char *tag, const char *tag2, int level,
 
        spin_lock_irqsave(&adapter->scsi_dbf_lock, flags);
        do {
-               memset(rec, 0, sizeof(struct zfcp_scsi_dbf_record));
+               memset(rec, 0, sizeof(*rec));
                if (offset == 0) {
                        strncpy(rec->tag, tag, ZFCP_DBF_TAG_SIZE);
                        strncpy(rec->tag2, tag2, ZFCP_DBF_TAG_SIZE);
@@ -1050,7 +1052,7 @@ _zfcp_scsi_dbf_event_common(const char *tag, const char *tag2, int level,
                                rec->scsi_result = scsi_cmnd->result;
                                rec->scsi_cmnd = (unsigned long)scsi_cmnd;
                                rec->scsi_serial = scsi_cmnd->serial_number;
-                               memcpy(rec->scsi_opcode, &scsi_cmnd->cmnd,
+                               memcpy(rec->scsi_opcode, scsi_cmnd->cmnd,
                                        min((int)scsi_cmnd->cmd_len,
                                                ZFCP_DBF_SCSI_OPCODE));
                                rec->scsi_retries = scsi_cmnd->retries;
@@ -1064,20 +1066,16 @@ _zfcp_scsi_dbf_event_common(const char *tag, const char *tag2, int level,
                                fcp_sns_info =
                                    zfcp_get_fcp_sns_info_ptr(fcp_rsp);
 
-                               rec->type.fcp.rsp_validity =
-                                   fcp_rsp->validity.value;
-                               rec->type.fcp.rsp_scsi_status =
-                                   fcp_rsp->scsi_status;
-                               rec->type.fcp.rsp_resid = fcp_rsp->fcp_resid;
+                               rec->rsp_validity = fcp_rsp->validity.value;
+                               rec->rsp_scsi_status = fcp_rsp->scsi_status;
+                               rec->rsp_resid = fcp_rsp->fcp_resid;
                                if (fcp_rsp->validity.bits.fcp_rsp_len_valid)
-                                       rec->type.fcp.rsp_code =
-                                           *(fcp_rsp_info + 3);
+                                       rec->rsp_code = *(fcp_rsp_info + 3);
                                if (fcp_rsp->validity.bits.fcp_sns_len_valid) {
                                        buflen = min((int)fcp_rsp->fcp_sns_len,
                                                     ZFCP_DBF_SCSI_MAX_FCP_SNS_INFO);
-                                       rec->type.fcp.sns_info_len = buflen;
-                                       memcpy(rec->type.fcp.sns_info,
-                                              fcp_sns_info,
+                                       rec->sns_info_len = buflen;
+                                       memcpy(rec->sns_info, fcp_sns_info,
                                               min(buflen,
                                                   ZFCP_DBF_SCSI_FCP_SNS_INFO));
                                        offset += min(buflen,
@@ -1088,7 +1086,7 @@ _zfcp_scsi_dbf_event_common(const char *tag, const char *tag2, int level,
                                rec->fsf_seqno = fsf_req->seq_no;
                                rec->fsf_issued = fsf_req->issued;
                        }
-                       rec->type.old_fsf_reqid = old_req_id;
+                       rec->old_fsf_reqid = old_req_id;
                } else {
                        strncpy(dump->tag, "dump", ZFCP_DBF_TAG_SIZE);
                        dump->total_size = buflen;
@@ -1100,45 +1098,61 @@ _zfcp_scsi_dbf_event_common(const char *tag, const char *tag2, int level,
                        memcpy(dump->data, fcp_sns_info + offset, dump->size);
                        offset += dump->size;
                }
-               debug_event(adapter->scsi_dbf, level,
-                           rec, sizeof(struct zfcp_scsi_dbf_record));
+               debug_event(adapter->scsi_dbf, level, rec, sizeof(*rec));
        } while (offset < buflen);
        spin_unlock_irqrestore(&adapter->scsi_dbf_lock, flags);
 }
 
-void
-zfcp_scsi_dbf_event_result(const char *tag, int level,
-                          struct zfcp_adapter *adapter,
-                          struct scsi_cmnd *scsi_cmnd,
-                          struct zfcp_fsf_req *fsf_req)
+/**
+ * zfcp_scsi_dbf_event_result - trace event for SCSI command completion
+ * @tag: tag indicating success or failure of SCSI command
+ * @level: trace level applicable for this event
+ * @adapter: adapter that has been used to issue the SCSI command
+ * @scsi_cmnd: SCSI command pointer
+ * @fsf_req: request used to issue SCSI command (might be NULL)
+ */
+void zfcp_scsi_dbf_event_result(const char *tag, int level,
+                               struct zfcp_adapter *adapter,
+                               struct scsi_cmnd *scsi_cmnd,
+                               struct zfcp_fsf_req *fsf_req)
 {
-       _zfcp_scsi_dbf_event_common("rslt", tag, level,
-                       adapter, scsi_cmnd, fsf_req, 0);
+       zfcp_scsi_dbf_event("rslt", tag, level, adapter, scsi_cmnd, fsf_req, 0);
 }
 
-void
-zfcp_scsi_dbf_event_abort(const char *tag, struct zfcp_adapter *adapter,
-                         struct scsi_cmnd *scsi_cmnd,
-                         struct zfcp_fsf_req *new_fsf_req,
-                         unsigned long old_req_id)
+/**
+ * zfcp_scsi_dbf_event_abort - trace event for SCSI command abort
+ * @tag: tag indicating success or failure of abort operation
+ * @adapter: adapter thas has been used to issue SCSI command to be aborted
+ * @scsi_cmnd: SCSI command to be aborted
+ * @new_fsf_req: request containing abort (might be NULL)
+ * @old_req_id: identifier of request containg SCSI command to be aborted
+ */
+void zfcp_scsi_dbf_event_abort(const char *tag, struct zfcp_adapter *adapter,
+                              struct scsi_cmnd *scsi_cmnd,
+                              struct zfcp_fsf_req *new_fsf_req,
+                              unsigned long old_req_id)
 {
-       _zfcp_scsi_dbf_event_common("abrt", tag, 1,
-                       adapter, scsi_cmnd, new_fsf_req, old_req_id);
+       zfcp_scsi_dbf_event("abrt", tag, 1, adapter, scsi_cmnd, new_fsf_req,
+                           old_req_id);
 }
 
-void
-zfcp_scsi_dbf_event_devreset(const char *tag, u8 flag, struct zfcp_unit *unit,
-                            struct scsi_cmnd *scsi_cmnd)
+/**
+ * zfcp_scsi_dbf_event_devreset - trace event for Logical Unit or Target Reset
+ * @tag: tag indicating success or failure of reset operation
+ * @flag: indicates type of reset (Target Reset, Logical Unit Reset)
+ * @unit: unit that needs reset
+ * @scsi_cmnd: SCSI command which caused this error recovery
+ */
+void zfcp_scsi_dbf_event_devreset(const char *tag, u8 flag,
+                                 struct zfcp_unit *unit,
+                                 struct scsi_cmnd *scsi_cmnd)
 {
-       struct zfcp_adapter *adapter = unit->port->adapter;
-
-       _zfcp_scsi_dbf_event_common(flag == FCP_TARGET_RESET ? "trst" : "lrst",
-                       tag, 1, adapter, scsi_cmnd, NULL, 0);
+       zfcp_scsi_dbf_event(flag == FCP_TARGET_RESET ? "trst" : "lrst", tag, 1,
+                           unit->port->adapter, scsi_cmnd, NULL, 0);
 }
 
-static int
-zfcp_scsi_dbf_view_format(debug_info_t * id, struct debug_view *view,
-                         char *out_buf, const char *in_buf)
+static int zfcp_scsi_dbf_view_format(debug_info_t *id, struct debug_view *view,
+                                    char *out_buf, const char *in_buf)
 {
        struct zfcp_scsi_dbf_record *r = (struct zfcp_scsi_dbf_record *)in_buf;
        struct timespec t;
@@ -1159,28 +1173,23 @@ zfcp_scsi_dbf_view_format(debug_info_t * id, struct debug_view *view,
        zfcp_dbf_out(&p, "scsi_retries", "0x%02x", r->scsi_retries);
        zfcp_dbf_out(&p, "scsi_allowed", "0x%02x", r->scsi_allowed);
        if (strncmp(r->tag, "abrt", ZFCP_DBF_TAG_SIZE) == 0)
-               zfcp_dbf_out(&p, "old_fsf_reqid", "0x%0Lx",
-                            r->type.old_fsf_reqid);
+               zfcp_dbf_out(&p, "old_fsf_reqid", "0x%0Lx", r->old_fsf_reqid);
        zfcp_dbf_out(&p, "fsf_reqid", "0x%0Lx", r->fsf_reqid);
        zfcp_dbf_out(&p, "fsf_seqno", "0x%08x", r->fsf_seqno);
        zfcp_dbf_timestamp(r->fsf_issued, &t);
        zfcp_dbf_out(&p, "fsf_issued", "%011lu:%06lu", t.tv_sec, t.tv_nsec);
 
        if (strncmp(r->tag, "rslt", ZFCP_DBF_TAG_SIZE) == 0) {
-               zfcp_dbf_out(&p, "fcp_rsp_validity", "0x%02x",
-                            r->type.fcp.rsp_validity);
-               zfcp_dbf_out(&p, "fcp_rsp_scsi_status",
-                            "0x%02x", r->type.fcp.rsp_scsi_status);
-               zfcp_dbf_out(&p, "fcp_rsp_resid", "0x%08x",
-                            r->type.fcp.rsp_resid);
-               zfcp_dbf_out(&p, "fcp_rsp_code", "0x%08x",
-                            r->type.fcp.rsp_code);
-               zfcp_dbf_out(&p, "fcp_sns_info_len", "0x%08x",
-                            r->type.fcp.sns_info_len);
-               zfcp_dbf_outd(&p, "fcp_sns_info", r->type.fcp.sns_info,
-                             min((int)r->type.fcp.sns_info_len,
+               zfcp_dbf_out(&p, "fcp_rsp_validity", "0x%02x", r->rsp_validity);
+               zfcp_dbf_out(&p, "fcp_rsp_scsi_status", "0x%02x",
+                            r->rsp_scsi_status);
+               zfcp_dbf_out(&p, "fcp_rsp_resid", "0x%08x", r->rsp_resid);
+               zfcp_dbf_out(&p, "fcp_rsp_code", "0x%08x", r->rsp_code);
+               zfcp_dbf_out(&p, "fcp_sns_info_len", "0x%08x", r->sns_info_len);
+               zfcp_dbf_outd(&p, "fcp_sns_info", r->sns_info,
+                             min((int)r->sns_info_len,
                              ZFCP_DBF_SCSI_FCP_SNS_INFO), 0,
-                             r->type.fcp.sns_info_len);
+                             r->sns_info_len);
        }
        p += sprintf(p, "\n");
        return p - out_buf;
@@ -1267,5 +1276,3 @@ void zfcp_adapter_debug_unregister(struct zfcp_adapter *adapter)
        adapter->hba_dbf = NULL;
        adapter->rec_dbf = NULL;
 }
-
-#undef ZFCP_LOG_AREA