bq27x00: Add bq27000 support
[pandora-kernel.git] / drivers / power / bq27x00_battery.c
index eff0273..44bc76b 100644 (file)
@@ -3,6 +3,7 @@
  *
  * Copyright (C) 2008 Rodolfo Giometti <giometti@linux.it>
  * Copyright (C) 2008 Eurotech S.p.A. <info@eurotech.it>
+ * Copyright (C) 2010-2011 Lars-Peter Clausen <lars@metafoo.de>
  *
  * Based on a previous work by Copyright (C) 2008 Texas Instruments, Inc.
  *
@@ -27,6 +28,8 @@
 #include <linux/slab.h>
 #include <asm/unaligned.h>
 
+#include <linux/power/bq27x00_battery.h>
+
 #define DRIVER_VERSION                 "1.1.0"
 
 #define BQ27x00_REG_TEMP               0x06
 #define BQ27500_FLAG_DSC               BIT(0)
 #define BQ27500_FLAG_FC                        BIT(9)
 
-/* If the system has several batteries we need a different name for each
- * of them...
- */
-static DEFINE_IDR(battery_id);
-static DEFINE_MUTEX(battery_mutex);
+#define BQ27000_RS                     20 /* Resistor sense */
 
 struct bq27x00_device_info;
 struct bq27x00_access_methods {
-       int (*read)(u8 reg, int *rt_value, int b_single,
-               struct bq27x00_device_info *di);
+       int (*read)(struct bq27x00_device_info *, u8 reg, int *rt_value,
+                       bool single);
 };
 
 enum bq27x00_chip { BQ27000, BQ27500 };
@@ -61,11 +60,11 @@ enum bq27x00_chip { BQ27000, BQ27500 };
 struct bq27x00_device_info {
        struct device           *dev;
        int                     id;
-       struct bq27x00_access_methods   *bus;
-       struct power_supply     bat;
        enum bq27x00_chip       chip;
 
-       struct i2c_client       *client;
+       struct power_supply     bat;
+
+       struct bq27x00_access_methods bus;
 };
 
 static enum power_supply_property bq27x00_battery_props[] = {
@@ -78,16 +77,17 @@ static enum power_supply_property bq27x00_battery_props[] = {
        POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW,
        POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG,
        POWER_SUPPLY_PROP_TIME_TO_FULL_NOW,
+       POWER_SUPPLY_PROP_TECHNOLOGY,
 };
 
 /*
  * Common code for BQ27x00 devices
  */
 
-static int bq27x00_read(u8 reg, int *rt_value, int b_single,
-                       struct bq27x00_device_info *di)
+static inline int bq27x00_read(struct bq27x00_device_info *di, u8 reg,
+               int *rt_value, bool single)
 {
-       return di->bus->read(reg, rt_value, b_single, di);
+       return di->bus.read(di, reg, rt_value, single);
 }
 
 /*
@@ -99,7 +99,7 @@ static int bq27x00_battery_temperature(struct bq27x00_device_info *di)
        int ret;
        int temp = 0;
 
-       ret = bq27x00_read(BQ27x00_REG_TEMP, &temp, 0, di);
+       ret = bq27x00_read(di, BQ27x00_REG_TEMP, &temp, false);
        if (ret) {
                dev_err(di->dev, "error reading temperature\n");
                return ret;
@@ -108,7 +108,7 @@ static int bq27x00_battery_temperature(struct bq27x00_device_info *di)
        if (di->chip == BQ27500)
                return temp - 2731;
        else
-               return ((temp >> 2) - 273) * 10;
+               return ((temp * 5) - 5463) / 2;
 }
 
 /*
@@ -120,7 +120,7 @@ static int bq27x00_battery_voltage(struct bq27x00_device_info *di)
        int ret;
        int volt = 0;
 
-       ret = bq27x00_read(BQ27x00_REG_VOLT, &volt, 0, di);
+       ret = bq27x00_read(di, BQ27x00_REG_VOLT, &volt, false);
        if (ret) {
                dev_err(di->dev, "error reading voltage\n");
                return ret;
@@ -140,7 +140,7 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di)
        int curr = 0;
        int flags = 0;
 
-       ret = bq27x00_read(BQ27x00_REG_AI, &curr, 0, di);
+       ret = bq27x00_read(di, BQ27x00_REG_AI, &curr, false);
        if (ret) {
                dev_err(di->dev, "error reading current\n");
                return 0;
@@ -148,9 +148,9 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di)
 
        if (di->chip == BQ27500) {
                /* bq27500 returns signed value */
-               curr = (int)(s16)curr;
+               curr = (int)((s16)curr) * 1000;
        } else {
-               ret = bq27x00_read(BQ27x00_REG_FLAGS, &flags, 0, di);
+               ret = bq27x00_read(di, BQ27x00_REG_FLAGS, &flags, false);
                if (ret < 0) {
                        dev_err(di->dev, "error reading flags\n");
                        return 0;
@@ -159,9 +159,10 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di)
                        dev_dbg(di->dev, "negative current!\n");
                        curr = -curr;
                }
+               curr = curr * 3570 / BQ27000_RS;
        }
 
-       return curr * 1000;
+       return curr;
 }
 
 /*
@@ -174,9 +175,9 @@ static int bq27x00_battery_rsoc(struct bq27x00_device_info *di)
        int rsoc = 0;
 
        if (di->chip == BQ27500)
-               ret = bq27x00_read(BQ27500_REG_SOC, &rsoc, 0, di);
+               ret = bq27x00_read(di, BQ27500_REG_SOC, &rsoc, false);
        else
-               ret = bq27x00_read(BQ27000_REG_RSOC, &rsoc, 1, di);
+               ret = bq27x00_read(di, BQ27000_REG_RSOC, &rsoc, true);
        if (ret) {
                dev_err(di->dev, "error reading relative State-of-Charge\n");
                return ret;
@@ -192,7 +193,7 @@ static int bq27x00_battery_status(struct bq27x00_device_info *di,
        int status;
        int ret;
 
-       ret = bq27x00_read(BQ27x00_REG_FLAGS, &flags, 0, di);
+       ret = bq27x00_read(di, BQ27x00_REG_FLAGS, &flags, false);
        if (ret < 0) {
                dev_err(di->dev, "error reading flags\n");
                return ret;
@@ -226,7 +227,7 @@ static int bq27x00_battery_time(struct bq27x00_device_info *di, int reg,
        int tval = 0;
        int ret;
 
-       ret = bq27x00_read(reg, &tval, 0, di);
+       ret = bq27x00_read(di, reg, &tval, false);
        if (ret) {
                dev_err(di->dev, "error reading register %02x\n", reg);
                return ret;
@@ -248,16 +249,21 @@ static int bq27x00_battery_get_property(struct power_supply *psy,
 {
        int ret = 0;
        struct bq27x00_device_info *di = to_bq27x00_device_info(psy);
+       int voltage = bq27x00_battery_voltage(di);
+
+       if (psp != POWER_SUPPLY_PROP_PRESENT && voltage <= 0)
+               return -ENODEV;
 
        switch (psp) {
        case POWER_SUPPLY_PROP_STATUS:
                ret = bq27x00_battery_status(di, val);
                break;
        case POWER_SUPPLY_PROP_VOLTAGE_NOW:
+               val->intval = voltage;
+               break;
        case POWER_SUPPLY_PROP_PRESENT:
-               val->intval = bq27x00_battery_voltage(di);
                if (psp == POWER_SUPPLY_PROP_PRESENT)
-                       val->intval = val->intval <= 0 ? 0 : 1;
+                       val->intval = voltage <= 0 ? 0 : 1;
                break;
        case POWER_SUPPLY_PROP_CURRENT_NOW:
                val->intval = bq27x00_battery_current(di);
@@ -277,6 +283,9 @@ static int bq27x00_battery_get_property(struct power_supply *psy,
        case POWER_SUPPLY_PROP_TIME_TO_FULL_NOW:
                ret = bq27x00_battery_time(di, BQ27x00_REG_TTF, val);
                break;
+       case POWER_SUPPLY_PROP_TECHNOLOGY:
+               val->intval = POWER_SUPPLY_TECHNOLOGY_LION;
+               break;
        default:
                return -EINVAL;
        }
@@ -284,23 +293,41 @@ static int bq27x00_battery_get_property(struct power_supply *psy,
        return ret;
 }
 
-static void bq27x00_powersupply_init(struct bq27x00_device_info *di)
+static int bq27x00_powersupply_init(struct bq27x00_device_info *di)
 {
+       int ret;
+
        di->bat.type = POWER_SUPPLY_TYPE_BATTERY;
        di->bat.properties = bq27x00_battery_props;
        di->bat.num_properties = ARRAY_SIZE(bq27x00_battery_props);
        di->bat.get_property = bq27x00_battery_get_property;
        di->bat.external_power_changed = NULL;
+
+       ret = power_supply_register(di->dev, &di->bat);
+       if (ret) {
+               dev_err(di->dev, "failed to register battery: %d\n", ret);
+               return ret;
+       }
+
+       dev_info(di->dev, "support ver. %s enabled\n", DRIVER_VERSION);
+
+       return 0;
 }
 
-/*
- * i2c specific code
+
+/* i2c specific code */
+#ifdef CONFIG_BATTERY_BQ27X00_I2C
+
+/* If the system has several batteries we need a different name for each
+ * of them...
  */
+static DEFINE_IDR(battery_id);
+static DEFINE_MUTEX(battery_mutex);
 
-static int bq27x00_read_i2c(u8 reg, int *rt_value, int b_single,
-                       struct bq27x00_device_info *di)
+static int bq27x00_read_i2c(struct bq27x00_device_info *di, u8 reg,
+                       int *rt_value, bool single)
 {
-       struct i2c_client *client = di->client;
+       struct i2c_client *client = to_i2c_client(di->dev);
        struct i2c_msg msg[1];
        unsigned char data[2];
        int err;
@@ -317,7 +344,7 @@ static int bq27x00_read_i2c(u8 reg, int *rt_value, int b_single,
        err = i2c_transfer(client->adapter, msg, 1);
 
        if (err >= 0) {
-               if (!b_single)
+               if (!single)
                        msg->len = 2;
                else
                        msg->len = 1;
@@ -325,7 +352,7 @@ static int bq27x00_read_i2c(u8 reg, int *rt_value, int b_single,
                msg->flags = I2C_M_RD;
                err = i2c_transfer(client->adapter, msg, 1);
                if (err >= 0) {
-                       if (!b_single)
+                       if (!single)
                                *rt_value = get_unaligned_le16(data);
                        else
                                *rt_value = data[0];
@@ -341,7 +368,6 @@ static int bq27x00_battery_probe(struct i2c_client *client,
 {
        char *name;
        struct bq27x00_device_info *di;
-       struct bq27x00_access_methods *bus;
        int num;
        int retval = 0;
 
@@ -368,38 +394,20 @@ static int bq27x00_battery_probe(struct i2c_client *client,
                retval = -ENOMEM;
                goto batt_failed_2;
        }
+
        di->id = num;
+       di->dev = &client->dev;
        di->chip = id->driver_data;
+       di->bat.name = name;
+       di->bus.read = &bq27x00_read_i2c;
 
-       bus = kzalloc(sizeof(*bus), GFP_KERNEL);
-       if (!bus) {
-               dev_err(&client->dev, "failed to allocate access method "
-                                       "data\n");
-               retval = -ENOMEM;
+       if (bq27x00_powersupply_init(di))
                goto batt_failed_3;
-       }
 
        i2c_set_clientdata(client, di);
-       di->dev = &client->dev;
-       di->bat.name = name;
-       bus->read = &bq27x00_read_i2c;
-       di->bus = bus;
-       di->client = client;
-
-       bq27x00_powersupply_init(di);
-
-       retval = power_supply_register(&client->dev, &di->bat);
-       if (retval) {
-               dev_err(&client->dev, "failed to register battery\n");
-               goto batt_failed_4;
-       }
-
-       dev_info(&client->dev, "support ver. %s enabled\n", DRIVER_VERSION);
 
        return 0;
 
-batt_failed_4:
-       kfree(bus);
 batt_failed_3:
        kfree(di);
 batt_failed_2:
@@ -418,7 +426,6 @@ static int bq27x00_battery_remove(struct i2c_client *client)
 
        power_supply_unregister(&di->bat);
 
-       kfree(di->bus);
        kfree(di->bat.name);
 
        mutex_lock(&battery_mutex);
@@ -430,10 +437,6 @@ static int bq27x00_battery_remove(struct i2c_client *client)
        return 0;
 }
 
-/*
- * Module stuff
- */
-
 static const struct i2c_device_id bq27x00_id[] = {
        { "bq27200", BQ27000 }, /* bq27200 is same as bq27000, but with i2c */
        { "bq27500", BQ27500 },
@@ -449,13 +452,167 @@ static struct i2c_driver bq27x00_battery_driver = {
        .id_table = bq27x00_id,
 };
 
+static inline int bq27x00_battery_i2c_init(void)
+{
+       int ret = i2c_add_driver(&bq27x00_battery_driver);
+       if (ret)
+               printk(KERN_ERR "Unable to register BQ27x00 i2c driver\n");
+
+       return ret;
+}
+
+static inline void bq27x00_battery_i2c_exit(void)
+{
+       i2c_del_driver(&bq27x00_battery_driver);
+}
+
+#else
+
+static inline int bq27x00_battery_i2c_init(void) { return 0; }
+static inline void bq27x00_battery_i2c_exit(void) {};
+
+#endif
+
+/* platform specific code */
+#ifdef CONFIG_BATTERY_BQ27X00_PLATFORM
+
+static int bq27000_read_platform(struct bq27x00_device_info *di, u8 reg,
+                       int *rt_value, bool single)
+{
+       struct device *dev = di->dev;
+       struct bq27000_platform_data *pdata = dev->platform_data;
+       unsigned int timeout = 3;
+       int upper, lower;
+       int temp;
+
+       if (!single) {
+               /* Make sure the value has not changed in between reading the
+                * lower and the upper part */
+               upper = pdata->read(dev, reg + 1);
+               do {
+                       temp = upper;
+                       if (upper < 0)
+                               return upper;
+
+                       lower = pdata->read(dev, reg);
+                       if (lower < 0)
+                               return lower;
+
+                       upper = pdata->read(dev, reg + 1);
+               } while (temp != upper && --timeout);
+
+               if (timeout == 0)
+                       return -EIO;
+
+               *rt_value = (upper << 8) | lower;
+       } else {
+               lower = pdata->read(dev, reg);
+               if (lower < 0)
+                       return lower;
+               *rt_value = lower;
+       }
+       return 0;
+}
+
+static int __devinit bq27000_battery_probe(struct platform_device *pdev)
+{
+       struct bq27x00_device_info *di;
+       struct bq27000_platform_data *pdata = pdev->dev.platform_data;
+       int ret;
+
+       if (!pdata) {
+               dev_err(&pdev->dev, "no platform_data supplied\n");
+               return -EINVAL;
+       }
+
+       if (!pdata->read) {
+               dev_err(&pdev->dev, "no hdq read callback supplied\n");
+               return -EINVAL;
+       }
+
+       di = kzalloc(sizeof(*di), GFP_KERNEL);
+       if (!di) {
+               dev_err(&pdev->dev, "failed to allocate device info data\n");
+               return -ENOMEM;
+       }
+
+       platform_set_drvdata(pdev, di);
+
+       di->dev = &pdev->dev;
+       di->chip = BQ27000;
+
+       di->bat.name = pdata->name ?: dev_name(&pdev->dev);
+       di->bus.read = &bq27000_read_platform;
+
+       ret = bq27x00_powersupply_init(di);
+       if (ret)
+               goto err_free;
+
+       return 0;
+
+err_free:
+       platform_set_drvdata(pdev, NULL);
+       kfree(di);
+
+       return ret;
+}
+
+static int __devexit bq27000_battery_remove(struct platform_device *pdev)
+{
+       struct bq27x00_device_info *di = platform_get_drvdata(pdev);
+
+       power_supply_unregister(&di->bat);
+       platform_set_drvdata(pdev, NULL);
+       kfree(di);
+
+       return 0;
+}
+
+static struct platform_driver bq27000_battery_driver = {
+       .probe  = bq27000_battery_probe,
+       .remove = __devexit_p(bq27000_battery_remove),
+       .driver = {
+               .name = "bq27000-battery",
+               .owner = THIS_MODULE,
+       },
+};
+
+static inline int bq27x00_battery_platform_init(void)
+{
+       int ret = platform_driver_register(&bq27000_battery_driver);
+       if (ret)
+               printk(KERN_ERR "Unable to register BQ27000 platform driver\n");
+
+       return ret;
+}
+
+static inline void bq27x00_battery_platform_exit(void)
+{
+       platform_driver_unregister(&bq27000_battery_driver);
+}
+
+#else
+
+static inline int bq27x00_battery_platform_init(void) { return 0; }
+static inline void bq27x00_battery_platform_exit(void) {};
+
+#endif
+
+/*
+ * Module stuff
+ */
+
 static int __init bq27x00_battery_init(void)
 {
        int ret;
 
-       ret = i2c_add_driver(&bq27x00_battery_driver);
+       ret = bq27x00_battery_i2c_init();
        if (ret)
-               printk(KERN_ERR "Unable to register BQ27x00 driver\n");
+               return ret;
+
+       ret = bq27x00_battery_platform_init();
+       if (ret)
+               bq27x00_battery_i2c_exit();
 
        return ret;
 }
@@ -463,7 +620,8 @@ module_init(bq27x00_battery_init);
 
 static void __exit bq27x00_battery_exit(void)
 {
-       i2c_del_driver(&bq27x00_battery_driver);
+       bq27x00_battery_platform_exit();
+       bq27x00_battery_i2c_exit();
 }
 module_exit(bq27x00_battery_exit);