Merge branch 'fix/misc' into for-linus
[pandora-kernel.git] / drivers / pci / hotplug / pciehp_ctrl.c
index acb7f9e..8aab8ed 100644 (file)
@@ -30,7 +30,6 @@
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/types.h>
-#include <linux/smp_lock.h>
 #include <linux/pci.h>
 #include <linux/workqueue.h>
 #include "../pci.h"
@@ -61,12 +60,12 @@ u8 pciehp_handle_attention_button(struct slot *p_slot)
        struct controller *ctrl = p_slot->ctrl;
 
        /* Attention Button Change */
-       ctrl_dbg(ctrl, "Attention button interrupt received.\n");
+       ctrl_dbg(ctrl, "Attention button interrupt received\n");
 
        /*
         *  Button pressed - See if need to TAKE ACTION!!!
         */
-       ctrl_info(ctrl, "Button pressed on Slot(%s)\n", p_slot->name);
+       ctrl_info(ctrl, "Button pressed on Slot(%s)\n", slot_name(p_slot));
        event_type = INT_BUTTON_PRESS;
 
        queue_interrupt_event(p_slot, event_type);
@@ -81,20 +80,20 @@ u8 pciehp_handle_switch_change(struct slot *p_slot)
        struct controller *ctrl = p_slot->ctrl;
 
        /* Switch Change */
-       ctrl_dbg(ctrl, "Switch interrupt received.\n");
+       ctrl_dbg(ctrl, "Switch interrupt received\n");
 
        p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
        if (getstatus) {
                /*
                 * Switch opened
                 */
-               ctrl_info(ctrl, "Latch open on Slot(%s)\n", p_slot->name);
+               ctrl_info(ctrl, "Latch open on Slot(%s)\n", slot_name(p_slot));
                event_type = INT_SWITCH_OPEN;
        } else {
                /*
                 *  Switch closed
                 */
-               ctrl_info(ctrl, "Latch close on Slot(%s)\n", p_slot->name);
+               ctrl_info(ctrl, "Latch close on Slot(%s)\n", slot_name(p_slot));
                event_type = INT_SWITCH_CLOSE;
        }
 
@@ -110,7 +109,7 @@ u8 pciehp_handle_presence_change(struct slot *p_slot)
        struct controller *ctrl = p_slot->ctrl;
 
        /* Presence Change */
-       ctrl_dbg(ctrl, "Presence/Notify input change.\n");
+       ctrl_dbg(ctrl, "Presence/Notify input change\n");
 
        /* Switch is open, assume a presence change
         * Save the presence state
@@ -120,13 +119,14 @@ u8 pciehp_handle_presence_change(struct slot *p_slot)
                /*
                 * Card Present
                 */
-               ctrl_info(ctrl, "Card present on Slot(%s)\n", p_slot->name);
+               ctrl_info(ctrl, "Card present on Slot(%s)\n", slot_name(p_slot));
                event_type = INT_PRESENCE_ON;
        } else {
                /*
                 * Not Present
                 */
-               ctrl_info(ctrl, "Card not present on Slot(%s)\n", p_slot->name);
+               ctrl_info(ctrl, "Card not present on Slot(%s)\n",
+                         slot_name(p_slot));
                event_type = INT_PRESENCE_OFF;
        }
 
@@ -141,22 +141,22 @@ u8 pciehp_handle_power_fault(struct slot *p_slot)
        struct controller *ctrl = p_slot->ctrl;
 
        /* power fault */
-       ctrl_dbg(ctrl, "Power fault interrupt received.\n");
+       ctrl_dbg(ctrl, "Power fault interrupt received\n");
 
        if ( !(p_slot->hpc_ops->query_power_fault(p_slot))) {
                /*
                 * power fault Cleared
                 */
                ctrl_info(ctrl, "Power fault cleared on Slot(%s)\n",
-                         p_slot->name);
+                         slot_name(p_slot));
                event_type = INT_POWER_FAULT_CLEAR;
        } else {
                /*
                 *   power fault
                 */
-               ctrl_info(ctrl, "Power fault on Slot(%s)\n", p_slot->name);
+               ctrl_info(ctrl, "Power fault on Slot(%s)\n", slot_name(p_slot));
                event_type = INT_POWER_FAULT;
-               ctrl_info(ctrl, "power fault bit %x set\n", 0);
+               ctrl_info(ctrl, "Power fault bit %x set\n", 0);
        }
 
        queue_interrupt_event(p_slot, event_type);
@@ -174,26 +174,24 @@ static void set_slot_off(struct controller *ctrl, struct slot * pslot)
        if (POWER_CTRL(ctrl)) {
                if (pslot->hpc_ops->power_off_slot(pslot)) {
                        ctrl_err(ctrl,
-                                "%s: Issue of Slot Power Off command failed\n",
-                                __func__);
+                                "Issue of Slot Power Off command failed\n");
                        return;
                }
+               /*
+                * After turning power off, we must wait for at least 1 second
+                * before taking any action that relies on power having been
+                * removed from the slot/adapter.
+                */
+               msleep(1000);
        }
 
-       /*
-        * After turning power off, we must wait for at least 1 second
-        * before taking any action that relies on power having been
-        * removed from the slot/adapter.
-        */
-       msleep(1000);
-
        if (PWR_LED(ctrl))
                pslot->hpc_ops->green_led_off(pslot);
 
        if (ATTN_LED(ctrl)) {
                if (pslot->hpc_ops->set_attention_status(pslot, 1)) {
-                       ctrl_err(ctrl, "%s: Issue of Set Attention "
-                                "Led command failed\n", __func__);
+                       ctrl_err(ctrl,
+                                "Issue of Set Attention Led command failed\n");
                        return;
                }
        }
@@ -210,8 +208,9 @@ static int board_added(struct slot *p_slot)
 {
        int retval = 0;
        struct controller *ctrl = p_slot->ctrl;
+       struct pci_bus *parent = ctrl->pci_dev->subordinate;
 
-       ctrl_dbg(ctrl, "%s: slot device, slot offset, hp slot = %d, %d ,%d\n",
+       ctrl_dbg(ctrl, "%s: slot device, slot offset, hp slot = %d, %d%d\n",
                 __func__, p_slot->device, ctrl->slot_device_offset,
                 p_slot->hp_slot);
 
@@ -225,28 +224,25 @@ static int board_added(struct slot *p_slot)
        if (PWR_LED(ctrl))
                p_slot->hpc_ops->green_led_blink(p_slot);
 
-       /* Wait for ~1 second */
-       msleep(1000);
-
        /* Check link training status */
        retval = p_slot->hpc_ops->check_lnk_status(ctrl);
        if (retval) {
-               ctrl_err(ctrl, "%s: Failed to check link status\n", __func__);
+               ctrl_err(ctrl, "Failed to check link status\n");
                set_slot_off(ctrl, p_slot);
                return retval;
        }
 
        /* Check for a power fault */
        if (p_slot->hpc_ops->query_power_fault(p_slot)) {
-               ctrl_dbg(ctrl, "%s: power fault detected\n", __func__);
+               ctrl_dbg(ctrl, "Power fault detected\n");
                retval = POWER_FAILURE;
                goto err_exit;
        }
 
        retval = pciehp_configure_device(p_slot);
        if (retval) {
-               ctrl_err(ctrl, "Cannot add device 0x%x:%x\n",
-                        p_slot->bus, p_slot->device);
+               ctrl_err(ctrl, "Cannot add device at %04x:%02x:%02x\n",
+                        pci_domain_nr(parent), p_slot->bus, p_slot->device);
                goto err_exit;
        }
 
@@ -278,25 +274,24 @@ static int remove_board(struct slot *p_slot)
        if (retval)
                return retval;
 
-       ctrl_dbg(ctrl, "In %s, hp_slot = %d\n", __func__, p_slot->hp_slot);
+       ctrl_dbg(ctrl, "%s: hp_slot = %d\n", __func__, p_slot->hp_slot);
 
        if (POWER_CTRL(ctrl)) {
                /* power off slot */
                retval = p_slot->hpc_ops->power_off_slot(p_slot);
                if (retval) {
-                       ctrl_err(ctrl, "%s: Issue of Slot Disable command "
-                                "failed\n", __func__);
+                       ctrl_err(ctrl,
+                                "Issue of Slot Disable command failed\n");
                        return retval;
                }
+               /*
+                * After turning power off, we must wait for at least 1 second
+                * before taking any action that relies on power having been
+                * removed from the slot/adapter.
+                */
+               msleep(1000);
        }
 
-       /*
-        * After turning power off, we must wait for at least 1 second
-        * before taking any action that relies on power having been
-        * removed from the slot/adapter.
-        */
-       msleep(1000);
-
        if (PWR_LED(ctrl))
                /* turn off Green LED */
                p_slot->hpc_ops->green_led_off(p_slot);
@@ -326,8 +321,10 @@ static void pciehp_power_thread(struct work_struct *work)
        switch (p_slot->state) {
        case POWEROFF_STATE:
                mutex_unlock(&p_slot->lock);
-               ctrl_dbg(p_slot->ctrl, "%s: disabling bus:device(%x:%x)\n",
-                        __func__, p_slot->bus, p_slot->device);
+               ctrl_dbg(p_slot->ctrl,
+                        "Disabling domain:bus:device=%04x:%02x:%02x\n",
+                        pci_domain_nr(p_slot->ctrl->pci_dev->subordinate),
+                        p_slot->bus, p_slot->device);
                pciehp_disable_slot(p_slot);
                mutex_lock(&p_slot->lock);
                p_slot->state = STATIC_STATE;
@@ -412,12 +409,12 @@ static void handle_button_press_event(struct slot *p_slot)
                        p_slot->state = BLINKINGOFF_STATE;
                        ctrl_info(ctrl,
                                  "PCI slot #%s - powering off due to button "
-                                 "press.\n", p_slot->name);
+                                 "press.\n", slot_name(p_slot));
                } else {
                        p_slot->state = BLINKINGON_STATE;
                        ctrl_info(ctrl,
                                  "PCI slot #%s - powering on due to button "
-                                 "press.\n", p_slot->name);
+                                 "press.\n", slot_name(p_slot));
                }
                /* blink green LED and turn off amber */
                if (PWR_LED(ctrl))
@@ -434,8 +431,7 @@ static void handle_button_press_event(struct slot *p_slot)
                 * press the attention again before the 5 sec. limit
                 * expires to cancel hot-add or hot-remove
                 */
-               ctrl_info(ctrl, "Button cancel on Slot(%s)\n", p_slot->name);
-               ctrl_dbg(ctrl, "%s: button cancel\n", __func__);
+               ctrl_info(ctrl, "Button cancel on Slot(%s)\n", slot_name(p_slot));
                cancel_delayed_work(&p_slot->work);
                if (p_slot->state == BLINKINGOFF_STATE) {
                        if (PWR_LED(ctrl))
@@ -447,7 +443,7 @@ static void handle_button_press_event(struct slot *p_slot)
                if (ATTN_LED(ctrl))
                        p_slot->hpc_ops->set_attention_status(p_slot, 0);
                ctrl_info(ctrl, "PCI slot #%s - action canceled "
-                         "due to button press\n", p_slot->name);
+                         "due to button press\n", slot_name(p_slot));
                p_slot->state = STATIC_STATE;
                break;
        case POWEROFF_STATE:
@@ -457,7 +453,7 @@ static void handle_button_press_event(struct slot *p_slot)
                 * this means that the previous attention button action
                 * to hot-add or hot-remove is undergoing
                 */
-               ctrl_info(ctrl, "Button ignore on Slot(%s)\n", p_slot->name);
+               ctrl_info(ctrl, "Button ignore on Slot(%s)\n", slot_name(p_slot));
                update_slot_info(p_slot);
                break;
        default:
@@ -539,16 +535,15 @@ int pciehp_enable_slot(struct slot *p_slot)
 
        rc = p_slot->hpc_ops->get_adapter_status(p_slot, &getstatus);
        if (rc || !getstatus) {
-               ctrl_info(ctrl, "%s: no adapter on slot(%s)\n",
-                         __func__, p_slot->name);
+               ctrl_info(ctrl, "No adapter on slot(%s)\n", slot_name(p_slot));
                mutex_unlock(&p_slot->ctrl->crit_sect);
                return -ENODEV;
        }
        if (MRL_SENS(p_slot->ctrl)) {
                rc = p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
                if (rc || getstatus) {
-                       ctrl_info(ctrl, "%s: latch open on slot(%s)\n",
-                                 __func__, p_slot->name);
+                       ctrl_info(ctrl, "Latch open on slot(%s)\n",
+                                 slot_name(p_slot));
                        mutex_unlock(&p_slot->ctrl->crit_sect);
                        return -ENODEV;
                }
@@ -557,8 +552,8 @@ int pciehp_enable_slot(struct slot *p_slot)
        if (POWER_CTRL(p_slot->ctrl)) {
                rc = p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
                if (rc || getstatus) {
-                       ctrl_info(ctrl, "%s: already enabled on slot(%s)\n",
-                                 __func__, p_slot->name);
+                       ctrl_info(ctrl, "Already enabled on slot(%s)\n",
+                                 slot_name(p_slot));
                        mutex_unlock(&p_slot->ctrl->crit_sect);
                        return -EINVAL;
                }
@@ -593,8 +588,8 @@ int pciehp_disable_slot(struct slot *p_slot)
        if (!HP_SUPR_RM(p_slot->ctrl)) {
                ret = p_slot->hpc_ops->get_adapter_status(p_slot, &getstatus);
                if (ret || !getstatus) {
-                       ctrl_info(ctrl, "%s: no adapter on slot(%s)\n",
-                                 __func__, p_slot->name);
+                       ctrl_info(ctrl, "No adapter on slot(%s)\n",
+                                 slot_name(p_slot));
                        mutex_unlock(&p_slot->ctrl->crit_sect);
                        return -ENODEV;
                }
@@ -603,8 +598,8 @@ int pciehp_disable_slot(struct slot *p_slot)
        if (MRL_SENS(p_slot->ctrl)) {
                ret = p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
                if (ret || getstatus) {
-                       ctrl_info(ctrl, "%s: latch open on slot(%s)\n",
-                                 __func__, p_slot->name);
+                       ctrl_info(ctrl, "Latch open on slot(%s)\n",
+                                 slot_name(p_slot));
                        mutex_unlock(&p_slot->ctrl->crit_sect);
                        return -ENODEV;
                }
@@ -613,8 +608,8 @@ int pciehp_disable_slot(struct slot *p_slot)
        if (POWER_CTRL(p_slot->ctrl)) {
                ret = p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
                if (ret || !getstatus) {
-                       ctrl_info(ctrl, "%s: already disabled slot(%s)\n",
-                                 __func__, p_slot->name);
+                       ctrl_info(ctrl, "Already disabled on slot(%s)\n",
+                                 slot_name(p_slot));
                        mutex_unlock(&p_slot->ctrl->crit_sect);
                        return -EINVAL;
                }
@@ -645,14 +640,16 @@ int pciehp_sysfs_enable_slot(struct slot *p_slot)
                break;
        case POWERON_STATE:
                ctrl_info(ctrl, "Slot %s is already in powering on state\n",
-                         p_slot->name);
+                         slot_name(p_slot));
                break;
        case BLINKINGOFF_STATE:
        case POWEROFF_STATE:
-               ctrl_info(ctrl, "Already enabled on slot %s\n", p_slot->name);
+               ctrl_info(ctrl, "Already enabled on slot %s\n",
+                         slot_name(p_slot));
                break;
        default:
-               ctrl_err(ctrl, "Not a valid state on slot %s\n", p_slot->name);
+               ctrl_err(ctrl, "Not a valid state on slot %s\n",
+                        slot_name(p_slot));
                break;
        }
        mutex_unlock(&p_slot->lock);
@@ -678,14 +675,16 @@ int pciehp_sysfs_disable_slot(struct slot *p_slot)
                break;
        case POWEROFF_STATE:
                ctrl_info(ctrl, "Slot %s is already in powering off state\n",
-                         p_slot->name);
+                         slot_name(p_slot));
                break;
        case BLINKINGON_STATE:
        case POWERON_STATE:
-               ctrl_info(ctrl, "Already disabled on slot %s\n", p_slot->name);
+               ctrl_info(ctrl, "Already disabled on slot %s\n",
+                         slot_name(p_slot));
                break;
        default:
-               ctrl_err(ctrl, "Not a valid state on slot %s\n", p_slot->name);
+               ctrl_err(ctrl, "Not a valid state on slot %s\n",
+                        slot_name(p_slot));
                break;
        }
        mutex_unlock(&p_slot->lock);