mac80211: unify config_interface and bss_info_changed
[pandora-kernel.git] / drivers / net / wireless / b43legacy / main.c
index fb996c2..07c7898 100644 (file)
@@ -955,23 +955,54 @@ static void b43legacy_write_template_common(struct b43legacy_wldev *dev,
                              size + sizeof(struct b43legacy_plcp_hdr6));
 }
 
+/* Convert a b43legacy antenna number value to the PHY TX control value. */
+static u16 b43legacy_antenna_to_phyctl(int antenna)
+{
+       switch (antenna) {
+       case B43legacy_ANTENNA0:
+               return B43legacy_TX4_PHY_ANT0;
+       case B43legacy_ANTENNA1:
+               return B43legacy_TX4_PHY_ANT1;
+       }
+       return B43legacy_TX4_PHY_ANTLAST;
+}
+
 static void b43legacy_write_beacon_template(struct b43legacy_wldev *dev,
                                            u16 ram_offset,
-                                           u16 shm_size_offset, u8 rate)
+                                           u16 shm_size_offset)
 {
 
        unsigned int i, len, variable_len;
        const struct ieee80211_mgmt *bcn;
        const u8 *ie;
        bool tim_found = 0;
+       unsigned int rate;
+       u16 ctl;
+       int antenna;
+       struct ieee80211_tx_info *info = IEEE80211_SKB_CB(dev->wl->current_beacon);
 
        bcn = (const struct ieee80211_mgmt *)(dev->wl->current_beacon->data);
        len = min((size_t)dev->wl->current_beacon->len,
                  0x200 - sizeof(struct b43legacy_plcp_hdr6));
+       rate = ieee80211_get_tx_rate(dev->wl->hw, info)->hw_value;
 
        b43legacy_write_template_common(dev, (const u8 *)bcn, len, ram_offset,
                                        shm_size_offset, rate);
 
+       /* Write the PHY TX control parameters. */
+       antenna = B43legacy_ANTENNA_DEFAULT;
+       antenna = b43legacy_antenna_to_phyctl(antenna);
+       ctl = b43legacy_shm_read16(dev, B43legacy_SHM_SHARED,
+                                  B43legacy_SHM_SH_BEACPHYCTL);
+       /* We can't send beacons with short preamble. Would get PHY errors. */
+       ctl &= ~B43legacy_TX4_PHY_SHORTPRMBL;
+       ctl &= ~B43legacy_TX4_PHY_ANT;
+       ctl &= ~B43legacy_TX4_PHY_ENC;
+       ctl |= antenna;
+       ctl |= B43legacy_TX4_PHY_ENC_CCK;
+       b43legacy_shm_write16(dev, B43legacy_SHM_SHARED,
+                             B43legacy_SHM_SH_BEACPHYCTL, ctl);
+
        /* Find the position of the TIM and the DTIM_period value
         * and write them to SHM. */
        ie = bcn->u.beacon.variable;
@@ -1013,7 +1044,8 @@ static void b43legacy_write_beacon_template(struct b43legacy_wldev *dev,
                b43legacywarn(dev->wl, "Did not find a valid TIM IE in the "
                              "beacon template packet. AP or IBSS operation "
                              "may be broken.\n");
-       }
+       } else
+               b43legacydbg(dev->wl, "Updated beacon template\n");
 }
 
 static void b43legacy_write_probe_resp_plcp(struct b43legacy_wldev *dev,
@@ -1025,7 +1057,7 @@ static void b43legacy_write_probe_resp_plcp(struct b43legacy_wldev *dev,
        __le16 dur;
 
        plcp.data = 0;
-       b43legacy_generate_plcp_hdr(&plcp, size + FCS_LEN, rate->bitrate);
+       b43legacy_generate_plcp_hdr(&plcp, size + FCS_LEN, rate->hw_value);
        dur = ieee80211_generic_frame_duration(dev->wl->hw,
                                               dev->wl->vif,
                                               size,
@@ -1129,10 +1161,104 @@ static void b43legacy_write_probe_resp_template(struct b43legacy_wldev *dev,
                   0x200 - sizeof(struct b43legacy_plcp_hdr6));
        b43legacy_write_template_common(dev, probe_resp_data,
                                        size, ram_offset,
-                                       shm_size_offset, rate->bitrate);
+                                       shm_size_offset, rate->hw_value);
        kfree(probe_resp_data);
 }
 
+static void b43legacy_upload_beacon0(struct b43legacy_wldev *dev)
+{
+       struct b43legacy_wl *wl = dev->wl;
+
+       if (wl->beacon0_uploaded)
+               return;
+       b43legacy_write_beacon_template(dev, 0x68, 0x18);
+       /* FIXME: Probe resp upload doesn't really belong here,
+        *        but we don't use that feature anyway. */
+       b43legacy_write_probe_resp_template(dev, 0x268, 0x4A,
+                                     &__b43legacy_ratetable[3]);
+       wl->beacon0_uploaded = 1;
+}
+
+static void b43legacy_upload_beacon1(struct b43legacy_wldev *dev)
+{
+       struct b43legacy_wl *wl = dev->wl;
+
+       if (wl->beacon1_uploaded)
+               return;
+       b43legacy_write_beacon_template(dev, 0x468, 0x1A);
+       wl->beacon1_uploaded = 1;
+}
+
+static void handle_irq_beacon(struct b43legacy_wldev *dev)
+{
+       struct b43legacy_wl *wl = dev->wl;
+       u32 cmd, beacon0_valid, beacon1_valid;
+
+       if (!b43legacy_is_mode(wl, NL80211_IFTYPE_AP))
+               return;
+
+       /* This is the bottom half of the asynchronous beacon update. */
+
+       /* Ignore interrupt in the future. */
+       dev->irq_savedstate &= ~B43legacy_IRQ_BEACON;
+
+       cmd = b43legacy_read32(dev, B43legacy_MMIO_MACCMD);
+       beacon0_valid = (cmd & B43legacy_MACCMD_BEACON0_VALID);
+       beacon1_valid = (cmd & B43legacy_MACCMD_BEACON1_VALID);
+
+       /* Schedule interrupt manually, if busy. */
+       if (beacon0_valid && beacon1_valid) {
+               b43legacy_write32(dev, B43legacy_MMIO_GEN_IRQ_REASON, B43legacy_IRQ_BEACON);
+               dev->irq_savedstate |= B43legacy_IRQ_BEACON;
+               return;
+       }
+
+       if (unlikely(wl->beacon_templates_virgin)) {
+               /* We never uploaded a beacon before.
+                * Upload both templates now, but only mark one valid. */
+               wl->beacon_templates_virgin = 0;
+               b43legacy_upload_beacon0(dev);
+               b43legacy_upload_beacon1(dev);
+               cmd = b43legacy_read32(dev, B43legacy_MMIO_MACCMD);
+               cmd |= B43legacy_MACCMD_BEACON0_VALID;
+               b43legacy_write32(dev, B43legacy_MMIO_MACCMD, cmd);
+       } else {
+               if (!beacon0_valid) {
+                       b43legacy_upload_beacon0(dev);
+                       cmd = b43legacy_read32(dev, B43legacy_MMIO_MACCMD);
+                       cmd |= B43legacy_MACCMD_BEACON0_VALID;
+                       b43legacy_write32(dev, B43legacy_MMIO_MACCMD, cmd);
+               } else if (!beacon1_valid) {
+                       b43legacy_upload_beacon1(dev);
+                       cmd = b43legacy_read32(dev, B43legacy_MMIO_MACCMD);
+                       cmd |= B43legacy_MACCMD_BEACON1_VALID;
+                       b43legacy_write32(dev, B43legacy_MMIO_MACCMD, cmd);
+               }
+       }
+}
+
+static void b43legacy_beacon_update_trigger_work(struct work_struct *work)
+{
+       struct b43legacy_wl *wl = container_of(work, struct b43legacy_wl,
+                                        beacon_update_trigger);
+       struct b43legacy_wldev *dev;
+
+       mutex_lock(&wl->mutex);
+       dev = wl->current_dev;
+       if (likely(dev && (b43legacy_status(dev) >= B43legacy_STAT_INITIALIZED))) {
+               spin_lock_irq(&wl->irq_lock);
+               /* update beacon right away or defer to irq */
+               dev->irq_savedstate = b43legacy_read32(dev, B43legacy_MMIO_GEN_IRQ_MASK);
+               handle_irq_beacon(dev);
+               /* The handler might have updated the IRQ mask. */
+               b43legacy_write32(dev, B43legacy_MMIO_GEN_IRQ_MASK,
+                           dev->irq_savedstate);
+               mmiowb();
+               spin_unlock_irq(&wl->irq_lock);
+       }
+       mutex_unlock(&wl->mutex);
+}
+
 /* Asynchronously update the packet templates in template RAM.
  * Locking: Requires wl->irq_lock to be locked. */
 static void b43legacy_update_templates(struct b43legacy_wl *wl)
@@ -1156,54 +1282,24 @@ static void b43legacy_update_templates(struct b43legacy_wl *wl)
        wl->current_beacon = beacon;
        wl->beacon0_uploaded = 0;
        wl->beacon1_uploaded = 0;
+       queue_work(wl->hw->workqueue, &wl->beacon_update_trigger);
 }
 
 static void b43legacy_set_beacon_int(struct b43legacy_wldev *dev,
                                     u16 beacon_int)
 {
        b43legacy_time_lock(dev);
-       if (dev->dev->id.revision >= 3)
-               b43legacy_write32(dev, 0x188, (beacon_int << 16));
-       else {
+       if (dev->dev->id.revision >= 3) {
+               b43legacy_write32(dev, B43legacy_MMIO_TSF_CFP_REP,
+                                (beacon_int << 16));
+               b43legacy_write32(dev, B43legacy_MMIO_TSF_CFP_START,
+                                (beacon_int << 10));
+       } else {
                b43legacy_write16(dev, 0x606, (beacon_int >> 6));
                b43legacy_write16(dev, 0x610, beacon_int);
        }
        b43legacy_time_unlock(dev);
-}
-
-static void handle_irq_beacon(struct b43legacy_wldev *dev)
-{
-       struct b43legacy_wl *wl = dev->wl;
-       u32 cmd;
-
-       if (!b43legacy_is_mode(wl, NL80211_IFTYPE_AP))
-               return;
-
-       /* This is the bottom half of the asynchronous beacon update. */
-
-       cmd = b43legacy_read32(dev, B43legacy_MMIO_MACCMD);
-       if (!(cmd & B43legacy_MACCMD_BEACON0_VALID)) {
-               if (!wl->beacon0_uploaded) {
-                       b43legacy_write_beacon_template(dev, 0x68,
-                                                       B43legacy_SHM_SH_BTL0,
-                                                       B43legacy_CCK_RATE_1MB);
-                       b43legacy_write_probe_resp_template(dev, 0x268,
-                                                           B43legacy_SHM_SH_PRTLEN,
-                                                           &__b43legacy_ratetable[3]);
-                       wl->beacon0_uploaded = 1;
-               }
-               cmd |= B43legacy_MACCMD_BEACON0_VALID;
-       }
-       if (!(cmd & B43legacy_MACCMD_BEACON1_VALID)) {
-               if (!wl->beacon1_uploaded) {
-                       b43legacy_write_beacon_template(dev, 0x468,
-                                                       B43legacy_SHM_SH_BTL1,
-                                                       B43legacy_CCK_RATE_1MB);
-                       wl->beacon1_uploaded = 1;
-               }
-               cmd |= B43legacy_MACCMD_BEACON1_VALID;
-       }
-       b43legacy_write32(dev, B43legacy_MMIO_MACCMD, cmd);
+       b43legacydbg(dev->wl, "Set beacon interval to %u\n", beacon_int);
 }
 
 static void handle_irq_ucode_debug(struct b43legacy_wldev *dev)
@@ -2297,6 +2393,7 @@ static void b43legacy_security_init(struct b43legacy_wldev *dev)
                                  dev->max_nr_keys - 8);
 }
 
+#ifdef CONFIG_B43LEGACY_HWRNG
 static int b43legacy_rng_read(struct hwrng *rng, u32 *data)
 {
        struct b43legacy_wl *wl = (struct b43legacy_wl *)rng->priv;
@@ -2312,17 +2409,21 @@ static int b43legacy_rng_read(struct hwrng *rng, u32 *data)
 
        return (sizeof(u16));
 }
+#endif
 
 static void b43legacy_rng_exit(struct b43legacy_wl *wl)
 {
+#ifdef CONFIG_B43LEGACY_HWRNG
        if (wl->rng_initialized)
                hwrng_unregister(&wl->rng);
+#endif
 }
 
 static int b43legacy_rng_init(struct b43legacy_wl *wl)
 {
-       int err;
+       int err = 0;
 
+#ifdef CONFIG_B43LEGACY_HWRNG
        snprintf(wl->rng_name, ARRAY_SIZE(wl->rng_name),
                 "%s_%s", KBUILD_MODNAME, wiphy_name(wl->hw->wiphy));
        wl->rng.name = wl->rng_name;
@@ -2336,6 +2437,7 @@ static int b43legacy_rng_init(struct b43legacy_wl *wl)
                       "number generator (%d)\n", err);
        }
 
+#endif
        return err;
 }
 
@@ -2619,11 +2721,6 @@ static int b43legacy_op_dev_config(struct ieee80211_hw *hw,
        /* Antennas for RX and management frame TX. */
        b43legacy_mgmtframe_txantenna(dev, antenna_tx);
 
-       /* Update templates for AP mode. */
-       if (b43legacy_is_mode(wl, NL80211_IFTYPE_AP))
-               b43legacy_set_beacon_int(dev, conf->beacon_int);
-
-
        if (!!conf->radio_enabled != phy->radio_on) {
                if (conf->radio_enabled) {
                        b43legacy_radio_turn_on(dev);
@@ -2650,7 +2747,7 @@ out_unlock_mutex:
        return err;
 }
 
-static void b43legacy_update_basic_rates(struct b43legacy_wldev *dev, u64 brates)
+static void b43legacy_update_basic_rates(struct b43legacy_wldev *dev, u32 brates)
 {
        struct ieee80211_supported_band *sband =
                dev->wl->hw->wiphy->bands[IEEE80211_BAND_2GHZ];
@@ -2707,6 +2804,7 @@ static void b43legacy_op_bss_info_changed(struct ieee80211_hw *hw,
        u32 savedirqs;
 
        mutex_lock(&wl->mutex);
+       B43legacy_WARN_ON(wl->vif != vif);
 
        dev = wl->current_dev;
        phy = &dev->phy;
@@ -2720,11 +2818,37 @@ static void b43legacy_op_bss_info_changed(struct ieee80211_hw *hw,
                goto out_unlock_mutex;
        }
        savedirqs = b43legacy_interrupt_disable(dev, B43legacy_IRQ_ALL);
-       spin_unlock_irqrestore(&wl->irq_lock, flags);
-       b43legacy_synchronize_irq(dev);
+
+       if (changed & BSS_CHANGED_BSSID) {
+               spin_unlock_irqrestore(&wl->irq_lock, flags);
+               b43legacy_synchronize_irq(dev);
+
+               if (conf->bssid)
+                       memcpy(wl->bssid, conf->bssid, ETH_ALEN);
+               else
+                       memset(wl->bssid, 0, ETH_ALEN);
+
+               if (b43legacy_status(dev) >= B43legacy_STAT_INITIALIZED) {
+                       if (b43legacy_is_mode(wl, NL80211_IFTYPE_AP)) {
+                               B43legacy_WARN_ON(vif->type != NL80211_IFTYPE_AP);
+                               if (changed & BSS_CHANGED_BEACON)
+                                       b43legacy_update_templates(wl);
+                       } else if (b43legacy_is_mode(wl, NL80211_IFTYPE_ADHOC)) {
+                               if (changed & BSS_CHANGED_BEACON)
+                                       b43legacy_update_templates(wl);
+                       }
+                       b43legacy_write_mac_bssid_templates(dev);
+               }
+               spin_unlock_irqrestore(&wl->irq_lock, flags);
+       }
 
        b43legacy_mac_suspend(dev);
 
+       if (changed & BSS_CHANGED_BEACON_INT &&
+           (b43legacy_is_mode(wl, NL80211_IFTYPE_AP) ||
+            b43legacy_is_mode(wl, NL80211_IFTYPE_ADHOC)))
+               b43legacy_set_beacon_int(dev, conf->beacon_int);
+
        if (changed & BSS_CHANGED_BASIC_RATES)
                b43legacy_update_basic_rates(dev, conf->basic_rates);
 
@@ -2744,8 +2868,6 @@ static void b43legacy_op_bss_info_changed(struct ieee80211_hw *hw,
        spin_unlock_irqrestore(&wl->irq_lock, flags);
  out_unlock_mutex:
        mutex_unlock(&wl->mutex);
-
-       return;
 }
 
 static void b43legacy_op_configure_filter(struct ieee80211_hw *hw,
@@ -2787,40 +2909,6 @@ static void b43legacy_op_configure_filter(struct ieee80211_hw *hw,
        spin_unlock_irqrestore(&wl->irq_lock, flags);
 }
 
-static int b43legacy_op_config_interface(struct ieee80211_hw *hw,
-                                        struct ieee80211_vif *vif,
-                                        struct ieee80211_if_conf *conf)
-{
-       struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw);
-       struct b43legacy_wldev *dev = wl->current_dev;
-       unsigned long flags;
-
-       if (!dev)
-               return -ENODEV;
-       mutex_lock(&wl->mutex);
-       spin_lock_irqsave(&wl->irq_lock, flags);
-       B43legacy_WARN_ON(wl->vif != vif);
-       if (conf->bssid)
-               memcpy(wl->bssid, conf->bssid, ETH_ALEN);
-       else
-               memset(wl->bssid, 0, ETH_ALEN);
-       if (b43legacy_status(dev) >= B43legacy_STAT_INITIALIZED) {
-               if (b43legacy_is_mode(wl, NL80211_IFTYPE_AP)) {
-                       B43legacy_WARN_ON(vif->type != NL80211_IFTYPE_AP);
-                       if (conf->changed & IEEE80211_IFCC_BEACON)
-                               b43legacy_update_templates(wl);
-               } else if (b43legacy_is_mode(wl, NL80211_IFTYPE_ADHOC)) {
-                       if (conf->changed & IEEE80211_IFCC_BEACON)
-                               b43legacy_update_templates(wl);
-               }
-               b43legacy_write_mac_bssid_templates(dev);
-       }
-       spin_unlock_irqrestore(&wl->irq_lock, flags);
-       mutex_unlock(&wl->mutex);
-
-       return 0;
-}
-
 /* Locking: wl->mutex */
 static void b43legacy_wireless_core_stop(struct b43legacy_wldev *dev)
 {
@@ -3392,6 +3480,9 @@ static int b43legacy_op_start(struct ieee80211_hw *hw)
        memset(wl->bssid, 0, ETH_ALEN);
        memset(wl->mac_addr, 0, ETH_ALEN);
        wl->filter_flags = 0;
+       wl->beacon0_uploaded = 0;
+       wl->beacon1_uploaded = 0;
+       wl->beacon_templates_virgin = 1;
 
        mutex_lock(&wl->mutex);
 
@@ -3429,6 +3520,7 @@ static void b43legacy_op_stop(struct ieee80211_hw *hw)
        struct b43legacy_wldev *dev = wl->current_dev;
 
        b43legacy_rfkill_exit(dev);
+       cancel_work_sync(&(wl->beacon_update_trigger));
 
        mutex_lock(&wl->mutex);
        if (b43legacy_status(dev) >= B43legacy_STAT_STARTED)
@@ -3457,7 +3549,6 @@ static const struct ieee80211_ops b43legacy_hw_ops = {
        .remove_interface       = b43legacy_op_remove_interface,
        .config                 = b43legacy_op_dev_config,
        .bss_info_changed       = b43legacy_op_bss_info_changed,
-       .config_interface       = b43legacy_op_config_interface,
        .configure_filter       = b43legacy_op_configure_filter,
        .get_stats              = b43legacy_op_get_stats,
        .get_tx_stats           = b43legacy_op_get_tx_stats,
@@ -3760,6 +3851,7 @@ static int b43legacy_wireless_init(struct ssb_device *dev)
        spin_lock_init(&wl->leds_lock);
        mutex_init(&wl->mutex);
        INIT_LIST_HEAD(&wl->devlist);
+       INIT_WORK(&wl->beacon_update_trigger, b43legacy_beacon_update_trigger_work);
 
        ssb_set_devtypedata(dev, wl);
        b43legacyinfo(wl, "Broadcom %04X WLAN found\n", dev->bus->chip_id);