[media] v1.88 DM04/QQBOX Move remote to use rc_core dvb-usb-remote
[pandora-kernel.git] / drivers / media / dvb / dvb-usb / lmedm04.c
index 46ccd01..37b1469 100644 (file)
@@ -2,7 +2,9 @@
  *
  * DM04/QQBOX DVB-S USB BOX    LME2510C + SHARP:BS2F7HZ7395
  *                             LME2510C + LG TDQY-P001F
+ *                             LME2510C + BS2F7HZ0194
  *                             LME2510 + LG TDQY-P001F
+ *                             LME2510 + BS2F7HZ0194
  *
  * MVB7395 (LME2510C+SHARP:BS2F7HZ7395)
  * SHARP:BS2F7HZ7395 = (STV0288+Sharp IX2505V)
  *
  * MVB0001F (LME2510C+LGTDQT-P001F)
  *
+ * MV0194 (LME2510+SHARP:BS2F7HZ0194)
+ * SHARP:BS2F7HZ0194 = (STV0299+IX2410)
+ *
+ * MVB0194 (LME2510C+SHARP0194)
+ *
  * For firmware see Documentation/dvb/lmedm04.txt
  *
  * I2C addresses:
  * 0xd0 - STV0288      - Demodulator
  * 0xc0 - Sharp IX2505V        - Tuner
- * --or--
+ * --
  * 0x1c - TDA10086   - Demodulator
  * 0xc0 - TDA8263    - Tuner
- *
- * ***Please Note***
- *             There are other variants of the DM04
- *             ***NOT SUPPORTED***
- *             MV0194 (LME2510+SHARP0194)
- *             MVB0194 (LME2510C+SHARP0194)
+ * --
+ * 0xd0 - STV0299      - Demodulator
+ * 0xc0 - IX2410       - Tuner
  *
  *
  * VID = 3344  PID LME2510=1122 LME2510C=1120
@@ -55,8 +59,9 @@
  *
  * QQbox suffers from noise on LNB voltage.
  *
- *     PID functions have been removed from this driver version due to
- * problems with different firmware and application versions.
+ *     LME2510: SHARP:BS2F7HZ0194(MV0194) cannot cold reset and share system
+ * with other tuners. After a cold reset streaming will not start.
+ *
  */
 #define DVB_USB_LOG_PREFIX "LME2510(C)"
 #include <linux/usb.h>
@@ -69,6 +74,9 @@
 #include "tda10086.h"
 #include "stv0288.h"
 #include "ix2505v.h"
+#include "stv0299.h"
+#include "dvb-pll.h"
+#include "z0194a.h"
 
 
 
@@ -94,10 +102,17 @@ static int dvb_usb_lme2510_firmware;
 module_param_named(firmware, dvb_usb_lme2510_firmware, int, 0644);
 MODULE_PARM_DESC(firmware, "set default firmware 0=Sharp7395 1=LG");
 
+static int pid_filter;
+module_param_named(pid, pid_filter, int, 0644);
+MODULE_PARM_DESC(pid, "set default 0=on 1=off");
+
 
 DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
+
+#define TUNER_DEFAULT  0x0
 #define TUNER_LG       0x1
 #define TUNER_S7395    0x2
+#define TUNER_S0194    0x3
 
 struct lme2510_state {
        u8 id;
@@ -112,6 +127,7 @@ struct lme2510_state {
        u8 i2c_tuner_gate_r;
        u8 i2c_tuner_addr;
        u8 stream_on;
+       u8 pid_size;
        void *buffer;
        struct urb *lme_urb;
        void *usb_buffer;
@@ -154,14 +170,14 @@ static int lme2510_usb_talk(struct dvb_usb_device *d,
        }
        buff = st->usb_buffer;
 
-       /* the read/write capped at 512 */
-       memcpy(buff, wbuf, (wlen > 512) ? 512 : wlen);
-
        ret = mutex_lock_interruptible(&d->usb_mutex);
 
        if (ret < 0)
                return -EAGAIN;
 
+       /* the read/write capped at 512 */
+       memcpy(buff, wbuf, (wlen > 512) ? 512 : wlen);
+
        ret |= usb_clear_halt(d->udev, usb_sndbulkpipe(d->udev, 0x01));
 
        ret |= lme2510_bulk_write(d->udev, buff, wlen , 0x01);
@@ -191,16 +207,36 @@ static int lme2510_stream_restart(struct dvb_usb_device *d)
                        rbuff, sizeof(rbuff));
        return ret;
 }
-static int lme2510_remote_keypress(struct dvb_usb_adapter *adap, u16 keypress)
+
+static int lme2510_enable_pid(struct dvb_usb_device *d, u8 index, u16 pid_out)
 {
-       struct dvb_usb_device *d = adap->dev;
+       struct lme2510_state *st = d->priv;
+       static u8 pid_buff[] = LME_ZERO_PID;
+       static u8 rbuf[1];
+       u8 pid_no = index * 2;
+       u8 pid_len = pid_no + 2;
+       int ret = 0;
+       deb_info(1, "PID Setting Pid %04x", pid_out);
 
-       deb_info(1, "INT Key Keypress =%04x", keypress);
+       if (st->pid_size == 0)
+               ret |= lme2510_stream_restart(d);
 
-       if (keypress > 0)
-               rc_keydown(d->rc_dev, keypress, 0);
+       pid_buff[2] = pid_no;
+       pid_buff[3] = (u8)pid_out & 0xff;
+       pid_buff[4] = pid_no + 1;
+       pid_buff[5] = (u8)(pid_out >> 8);
 
-       return 0;
+       if (pid_len > st->pid_size)
+               st->pid_size = pid_len;
+       pid_buff[7] = 0x80 + st->pid_size;
+
+       ret |= lme2510_usb_talk(d, pid_buff ,
+               sizeof(pid_buff) , rbuf, sizeof(rbuf));
+
+       if (st->stream_on)
+               ret |= lme2510_stream_restart(d);
+
+       return ret;
 }
 
 static void lme2510_int_response(struct urb *lme_urb)
@@ -209,6 +245,7 @@ static void lme2510_int_response(struct urb *lme_urb)
        struct lme2510_state *st = adap->dev->priv;
        static u8 *ibuf, *rbuf;
        int i = 0, offset;
+       u32 key;
 
        switch (lme_urb->status) {
        case 0:
@@ -235,9 +272,16 @@ static void lme2510_int_response(struct urb *lme_urb)
 
                switch (ibuf[0]) {
                case 0xaa:
-                       debug_data_snipet(1, "INT Remote data snipet in", ibuf);
-                       lme2510_remote_keypress(adap,
-                               (u16)(ibuf[4]<<8)+ibuf[5]);
+                       debug_data_snipet(1, "INT Remote data snipet", ibuf);
+                       if ((ibuf[4] + ibuf[5]) == 0xff) {
+                               key = ibuf[5];
+                               key += (ibuf[3] > 0)
+                                       ? (ibuf[3] ^ 0xff) << 8 : 0;
+                               key += (ibuf[2] ^ 0xff) << 16;
+                               deb_info(1, "INT Key =%08x", key);
+                               if (adap->dev->rc_dev != NULL)
+                                       rc_keydown(adap->dev->rc_dev, key, 0);
+                       }
                        break;
                case 0xbb:
                        switch (st->tuner_config) {
@@ -249,6 +293,7 @@ static void lme2510_int_response(struct urb *lme_urb)
                                st->time_key = ibuf[7];
                                break;
                        case TUNER_S7395:
+                       case TUNER_S0194:
                                /* Tweak for earlier firmware*/
                                if (ibuf[1] == 0x03) {
                                        if (ibuf[2] > 1)
@@ -306,21 +351,73 @@ static int lme2510_int_read(struct dvb_usb_adapter *adap)
        lme_int->lme_urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
 
        usb_submit_urb(lme_int->lme_urb, GFP_ATOMIC);
-       info("INT Interupt Service Started");
+       info("INT Interrupt Service Started");
 
        return 0;
 }
 
+static int lme2510_pid_filter_ctrl(struct dvb_usb_adapter *adap, int onoff)
+{
+       struct lme2510_state *st = adap->dev->priv;
+       static u8 clear_pid_reg[] = LME_CLEAR_PID;
+       static u8 rbuf[1];
+       int ret;
+
+       deb_info(1, "PID Clearing Filter");
+
+       ret = mutex_lock_interruptible(&adap->dev->i2c_mutex);
+       if (ret < 0)
+               return -EAGAIN;
+
+       if (!onoff)
+               ret |= lme2510_usb_talk(adap->dev, clear_pid_reg,
+                       sizeof(clear_pid_reg), rbuf, sizeof(rbuf));
+
+       st->pid_size = 0;
+
+       mutex_unlock(&adap->dev->i2c_mutex);
+
+       return 0;
+}
+
+static int lme2510_pid_filter(struct dvb_usb_adapter *adap, int index, u16 pid,
+       int onoff)
+{
+       int ret = 0;
+
+       deb_info(3, "%s PID=%04x Index=%04x onoff=%02x", __func__,
+               pid, index, onoff);
+
+       if (onoff)
+               if (!pid_filter) {
+                       ret = mutex_lock_interruptible(&adap->dev->i2c_mutex);
+                       if (ret < 0)
+                               return -EAGAIN;
+                       ret |= lme2510_enable_pid(adap->dev, index, pid);
+                       mutex_unlock(&adap->dev->i2c_mutex);
+       }
+
+
+       return ret;
+}
+
+
 static int lme2510_return_status(struct usb_device *dev)
 {
        int ret = 0;
-       u8 data[10] = {0};
+       u8 *data;
+
+       data = kzalloc(10, GFP_KERNEL);
+       if (!data)
+               return -ENOMEM;
 
        ret |= usb_control_msg(dev, usb_rcvctrlpipe(dev, 0),
                        0x06, 0x80, 0x0302, 0x00, data, 0x0006, 200);
        info("Firmware Status: %x (%x)", ret , data[2]);
 
-       return (ret < 0) ? -ENODEV : data[2];
+       ret = (ret < 0) ? -ENODEV : data[2];
+       kfree(data);
+       return ret;
 }
 
 static int lme2510_msg(struct dvb_usb_device *d,
@@ -364,6 +461,18 @@ static int lme2510_msg(struct dvb_usb_device *d,
                                        msleep(5);
                        }
                        break;
+               case TUNER_S0194:
+                       if (wbuf[2] == 0xd0) {
+                               if (wbuf[3] == 0x1b) {
+                                       st->signal_lock = rbuf[1];
+                                       if ((st->stream_on & 1) &&
+                                               (st->signal_lock & 0x8)) {
+                                               lme2510_stream_restart(d);
+                                               st->i2c_talk_onoff = 0;
+                                       }
+                               }
+                       }
+                       break;
                default:
                        break;
                }
@@ -423,11 +532,39 @@ static int lme2510_msg(struct dvb_usb_device *d,
                                break;
                        }
                        break;
+               case TUNER_S0194:
+                       switch (wbuf[3]) {
+                       case 0x18:
+                               rbuf[0] = 0x55;
+                               rbuf[1] = (st->signal_level & 0x80)
+                                               ? 0 : (st->signal_level * 2);
+                               break;
+                       case 0x24:
+                               rbuf[0] = 0x55;
+                               rbuf[1] = st->signal_sn;
+                               break;
+                       case 0x1b:
+                               rbuf[0] = 0x55;
+                               rbuf[1] = st->signal_lock;
+                               break;
+                       case 0x19:
+                       case 0x25:
+                       case 0x1e:
+                       case 0x1d:
+                               rbuf[0] = 0x55;
+                               rbuf[1] = 0x00;
+                               break;
+                       default:
+                               lme2510_usb_talk(d, wbuf, wlen, rbuf, rlen);
+                               st->i2c_talk_onoff = 1;
+                               break;
+                       }
+                       break;
                default:
                        break;
                }
 
-               deb_info(4, "I2C From Interupt Message out(%02x) in(%02x)",
+               deb_info(4, "I2C From Interrupt Message out(%02x) in(%02x)",
                                wbuf[3], rbuf[1]);
 
        }
@@ -517,17 +654,14 @@ static int lme2510_identify_state(struct usb_device *udev,
                struct dvb_usb_device_description **desc,
                int *cold)
 {
-       if (lme2510_return_status(udev) == 0x44)
-               *cold = 1;
-       else
-               *cold = 0;
+       *cold = 0;
        return 0;
 }
 
 static int lme2510_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff)
 {
        struct lme2510_state *st = adap->dev->priv;
-       static u8 clear_reg_3[] =  LME_CLEAR_PID;
+       static u8 clear_reg_3[] = LME_CLEAR_PID;
        static u8 rbuf[1];
        int ret = 0, rlen = sizeof(rbuf);
 
@@ -539,9 +673,10 @@ static int lme2510_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff)
        else {
                deb_info(1, "STM Steam Off");
                /* mutex is here only to avoid collision with I2C */
-               ret = mutex_lock_interruptible(&adap->dev->i2c_mutex);
+               if (mutex_lock_interruptible(&adap->dev->i2c_mutex) < 0)
+                       return -EAGAIN;
 
-               ret |= lme2510_usb_talk(adap->dev, clear_reg_3,
+               ret = lme2510_usb_talk(adap->dev, clear_reg_3,
                                sizeof(clear_reg_3), rbuf, rlen);
                st->stream_on = 0;
                st->i2c_talk_onoff = 1;
@@ -552,45 +687,6 @@ static int lme2510_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff)
        return (ret < 0) ? -ENODEV : 0;
 }
 
-static int lme2510_int_service(struct dvb_usb_adapter *adap)
-{
-       struct dvb_usb_device *d = adap->dev;
-       struct rc_dev *rc;
-       int ret;
-
-       info("STA Configuring Remote");
-
-       rc = rc_allocate_device();
-       if (!rc)
-               return -ENOMEM;
-
-       usb_make_path(d->udev, d->rc_phys, sizeof(d->rc_phys));
-       strlcat(d->rc_phys, "/ir0", sizeof(d->rc_phys));
-
-       rc->input_name = "LME2510 Remote Control";
-       rc->input_phys = d->rc_phys;
-       rc->map_name = RC_MAP_LME2510;
-       rc->driver_name = "LME 2510";
-       usb_to_input_id(d->udev, &rc->input_id);
-
-       ret = rc_register_device(rc);
-       if (ret) {
-               rc_free_device(rc);
-               return ret;
-       }
-       d->rc_dev = rc;
-
-       /* Start the Interupt */
-       ret = lme2510_int_read(adap);
-       if (ret < 0) {
-               rc_unregister_device(rc);
-               info("INT Unable to start Interupt Service");
-               return -ENODEV;
-       }
-
-       return 0;
-}
-
 static u8 check_sum(u8 *p, u8 len)
 {
        u8 sum = 0;
@@ -603,7 +699,7 @@ static int lme2510_download_firmware(struct usb_device *dev,
                                        const struct firmware *fw)
 {
        int ret = 0;
-       u8 data[512] = {0};
+       u8 *data;
        u16 j, wlen, len_in, start, end;
        u8 packet_size, dlen, i;
        u8 *fw_data;
@@ -611,6 +707,11 @@ static int lme2510_download_firmware(struct usb_device *dev,
        packet_size = 0x31;
        len_in = 1;
 
+       data = kzalloc(512, GFP_KERNEL);
+       if (!data) {
+               info("FRM Could not start Firmware Download (Buffer allocation failed)");
+               return -ENOMEM;
+       }
 
        info("FRM Starting Firmware Download");
 
@@ -626,15 +727,15 @@ static int lme2510_download_firmware(struct usb_device *dev,
                                data[0] = i | 0x80;
                                dlen = (u8)(end - j)-1;
                        }
-               data[1] = dlen;
-               memcpy(&data[2], fw_data, dlen+1);
-               wlen = (u8) dlen + 4;
-               data[wlen-1] = check_sum(fw_data, dlen+1);
-               deb_info(1, "Data S=%02x:E=%02x CS= %02x", data[3],
+                       data[1] = dlen;
+                       memcpy(&data[2], fw_data, dlen+1);
+                       wlen = (u8) dlen + 4;
+                       data[wlen-1] = check_sum(fw_data, dlen+1);
+                       deb_info(1, "Data S=%02x:E=%02x CS= %02x", data[3],
                                data[dlen+2], data[dlen+3]);
-               ret |= lme2510_bulk_write(dev, data,  wlen, 1);
-               ret |= lme2510_bulk_read(dev, data, len_in , 1);
-               ret |= (data[0] == 0x88) ? 0 : -1;
+                       ret |= lme2510_bulk_write(dev, data,  wlen, 1);
+                       ret |= lme2510_bulk_read(dev, data, len_in , 1);
+                       ret |= (data[0] == 0x88) ? 0 : -1;
                }
        }
 
@@ -654,13 +755,10 @@ static int lme2510_download_firmware(struct usb_device *dev,
        else
                info("FRM Firmware Download Completed - Resetting Device");
 
-
+       kfree(data);
        return (ret < 0) ? -ENODEV : 0;
 }
 
-/* Default firmware for LME2510C */
-char lme_firmware[50] = "dvb-usb-lme2510c-s7395.fw";
-
 static void lme_coldreset(struct usb_device *dev)
 {
        int ret = 0, len_in;
@@ -678,45 +776,81 @@ static void lme_coldreset(struct usb_device *dev)
 static int lme_firmware_switch(struct usb_device *udev, int cold)
 {
        const struct firmware *fw = NULL;
-       char lme2510c_s7395[] = "dvb-usb-lme2510c-s7395.fw";
-       char lme2510c_lg[] = "dvb-usb-lme2510c-lg.fw";
-       char *firm_msg[] = {"Loading", "Switching to"};
-       int ret;
+       const char fw_c_s7395[] = "dvb-usb-lme2510c-s7395.fw";
+       const char fw_c_lg[] = "dvb-usb-lme2510c-lg.fw";
+       const char fw_c_s0194[] = "dvb-usb-lme2510c-s0194.fw";
+       const char fw_lg[] = "dvb-usb-lme2510-lg.fw";
+       const char fw_s0194[] = "dvb-usb-lme2510-s0194.fw";
+       const char *fw_lme;
+       int ret, cold_fw;
 
        cold = (cold > 0) ? (cold & 1) : 0;
 
-       if (udev->descriptor.idProduct == 0x1122)
-               return 0;
+       cold_fw = !cold;
 
-       switch (dvb_usb_lme2510_firmware) {
-       case 0:
-       default:
-               memcpy(&lme_firmware, lme2510c_s7395, sizeof(lme2510c_s7395));
-               ret = request_firmware(&fw, lme_firmware, &udev->dev);
-               if (ret == 0) {
-                       info("FRM %s S7395 Firmware", firm_msg[cold]);
+       if (le16_to_cpu(udev->descriptor.idProduct) == 0x1122) {
+               switch (dvb_usb_lme2510_firmware) {
+               default:
+                       dvb_usb_lme2510_firmware = TUNER_S0194;
+               case TUNER_S0194:
+                       fw_lme = fw_s0194;
+                       ret = request_firmware(&fw, fw_lme, &udev->dev);
+                       if (ret == 0) {
+                               cold = 0;
+                               break;
+                       }
+                       dvb_usb_lme2510_firmware = TUNER_LG;
+               case TUNER_LG:
+                       fw_lme = fw_lg;
+                       ret = request_firmware(&fw, fw_lme, &udev->dev);
+                       if (ret == 0)
+                               break;
+                       info("FRM No Firmware Found - please install");
+                       dvb_usb_lme2510_firmware = TUNER_DEFAULT;
+                       cold = 0;
+                       cold_fw = 0;
                        break;
                }
-               if (cold == 0)
-                       dvb_usb_lme2510_firmware = 1;
-               else
+       } else {
+               switch (dvb_usb_lme2510_firmware) {
+               default:
+                       dvb_usb_lme2510_firmware = TUNER_S7395;
+               case TUNER_S7395:
+                       fw_lme = fw_c_s7395;
+                       ret = request_firmware(&fw, fw_lme, &udev->dev);
+                       if (ret == 0) {
+                               cold = 0;
+                               break;
+                       }
+                       dvb_usb_lme2510_firmware = TUNER_LG;
+               case TUNER_LG:
+                       fw_lme = fw_c_lg;
+                       ret = request_firmware(&fw, fw_lme, &udev->dev);
+                       if (ret == 0)
+                               break;
+                       dvb_usb_lme2510_firmware = TUNER_S0194;
+               case TUNER_S0194:
+                       fw_lme = fw_c_s0194;
+                       ret = request_firmware(&fw, fw_lme, &udev->dev);
+                       if (ret == 0)
+                               break;
+                       info("FRM No Firmware Found - please install");
+                       dvb_usb_lme2510_firmware = TUNER_DEFAULT;
                        cold = 0;
-       case 1:
-               memcpy(&lme_firmware, lme2510c_lg, sizeof(lme2510c_lg));
-               ret = request_firmware(&fw, lme_firmware, &udev->dev);
-               if (ret == 0) {
-                       info("FRM %s LG Firmware", firm_msg[cold]);
+                       cold_fw = 0;
                        break;
                }
-               info("FRM No Firmware Found - please install");
-               dvb_usb_lme2510_firmware = 0;
-               cold = 0;
-               break;
+       }
+
+       if (cold_fw) {
+               info("FRM Loading %s file", fw_lme);
+               ret = lme2510_download_firmware(udev, fw);
        }
 
        release_firmware(fw);
 
        if (cold) {
+               info("FRM Changing to %s firmware", fw_lme);
                lme_coldreset(udev);
                return -ENODEV;
        }
@@ -758,6 +892,18 @@ static struct ix2505v_config lme_tuner = {
        .tuner_chargepump = 0x3,
 };
 
+static struct stv0299_config sharp_z0194_config = {
+       .demod_address = 0xd0,
+       .inittab = sharp_z0194a_inittab,
+       .mclk = 88000000UL,
+       .invert = 0,
+       .skip_reinit = 0,
+       .lock_output = STV0299_LOCKOUTPUT_1,
+       .volt13_op0_op1 = STV0299_VOLT13_OP1,
+       .min_delay_ms = 100,
+       .set_symbol_rate = sharp_z0194a_set_symbol_rate,
+};
+
 static int dm04_lme2510_set_voltage(struct dvb_frontend *fe,
                                        fe_sec_voltage_t voltage)
 {
@@ -793,7 +939,8 @@ static int lme_name(struct dvb_usb_adapter *adap)
 {
        struct lme2510_state *st = adap->dev->priv;
        const char *desc = adap->dev->desc->name;
-       char *fe_name[] = {"", " LG TDQY-P001F", " SHARP:BS2F7HZ7395"};
+       char *fe_name[] = {"", " LG TDQY-P001F", " SHARP:BS2F7HZ7395",
+                               " SHARP:BS2F7HZ0194"};
        char *name = adap->fe->ops.info.name;
 
        strlcpy(name, desc, 128);
@@ -820,26 +967,40 @@ static int dm04_lme2510_frontend_attach(struct dvb_usb_adapter *adap)
                st->i2c_tuner_gate_r = 4;
                st->i2c_tuner_addr = 0xc0;
                st->tuner_config = TUNER_LG;
-               if (dvb_usb_lme2510_firmware != 1) {
-                       dvb_usb_lme2510_firmware = 1;
+               if (dvb_usb_lme2510_firmware != TUNER_LG) {
+                       dvb_usb_lme2510_firmware = TUNER_LG;
                        ret = lme_firmware_switch(adap->dev->udev, 1);
-               } else /*stops LG/Sharp multi tuner problems*/
-                       dvb_usb_lme2510_firmware = 0;
+               }
+               goto end;
+       }
+
+       st->i2c_gate = 4;
+       adap->fe = dvb_attach(stv0299_attach, &sharp_z0194_config,
+                       &adap->dev->i2c_adap);
+       if (adap->fe) {
+               info("FE Found Stv0299");
+               st->i2c_tuner_gate_w = 4;
+               st->i2c_tuner_gate_r = 5;
+               st->i2c_tuner_addr = 0xc0;
+               st->tuner_config = TUNER_S0194;
+               if (dvb_usb_lme2510_firmware != TUNER_S0194) {
+                       dvb_usb_lme2510_firmware = TUNER_S0194;
+                       ret = lme_firmware_switch(adap->dev->udev, 1);
+               }
                goto end;
        }
 
        st->i2c_gate = 5;
        adap->fe = dvb_attach(stv0288_attach, &lme_config,
                        &adap->dev->i2c_adap);
-
        if (adap->fe) {
                info("FE Found Stv0288");
                st->i2c_tuner_gate_w = 4;
                st->i2c_tuner_gate_r = 5;
                st->i2c_tuner_addr = 0xc0;
                st->tuner_config = TUNER_S7395;
-               if (dvb_usb_lme2510_firmware != 0) {
-                       dvb_usb_lme2510_firmware = 0;
+               if (dvb_usb_lme2510_firmware != TUNER_S7395) {
+                       dvb_usb_lme2510_firmware = TUNER_S7395;
                        ret = lme_firmware_switch(adap->dev->udev, 1);
                }
        } else {
@@ -847,22 +1008,25 @@ static int dm04_lme2510_frontend_attach(struct dvb_usb_adapter *adap)
                return -ENODEV;
        }
 
+
 end:   if (ret) {
-               kfree(adap->fe);
-               adap->fe = NULL;
+               if (adap->fe) {
+                       dvb_frontend_detach(adap->fe);
+                       adap->fe = NULL;
+               }
+               adap->dev->props.rc.core.rc_codes = NULL;
                return -ENODEV;
        }
 
        adap->fe->ops.set_voltage = dm04_lme2510_set_voltage;
        ret = lme_name(adap);
-
        return ret;
 }
 
 static int dm04_lme2510_tuner(struct dvb_usb_adapter *adap)
 {
        struct lme2510_state *st = adap->dev->priv;
-       char *tun_msg[] = {"", "TDA8263", "IX2505V"};
+       char *tun_msg[] = {"", "TDA8263", "IX2505V", "DVB_PLL_OPERA"};
        int ret = 0;
 
        switch (st->tuner_config) {
@@ -876,6 +1040,11 @@ static int dm04_lme2510_tuner(struct dvb_usb_adapter *adap)
                        &adap->dev->i2c_adap))
                        ret = st->tuner_config;
                break;
+       case TUNER_S0194:
+               if (dvb_attach(dvb_pll_attach , adap->fe, 0xc0,
+                       &adap->dev->i2c_adap, DVB_PLL_OPERA1))
+                       ret = st->tuner_config;
+               break;
        default:
                break;
        }
@@ -888,8 +1057,12 @@ static int dm04_lme2510_tuner(struct dvb_usb_adapter *adap)
                return -ENODEV;
        }
 
-       /* Start the Interupt & Remote*/
-       ret = lme2510_int_service(adap);
+       /* Start the Interrupt*/
+       ret = lme2510_int_read(adap);
+       if (ret < 0) {
+               info("INT Unable to start Interrupt Service");
+               return -ENODEV;
+       }
 
        return ret;
 }
@@ -902,12 +1075,13 @@ static int lme2510_powerup(struct dvb_usb_device *d, int onoff)
        static u8 rbuf[1];
        int ret, len = 3, rlen = 1;
 
-       ret = mutex_lock_interruptible(&d->i2c_mutex);
+       if (mutex_lock_interruptible(&d->i2c_mutex) < 0)
+               return -EAGAIN;
 
        if (onoff)
-               ret |= lme2510_usb_talk(d, lnb_on, len, rbuf, rlen);
+               ret = lme2510_usb_talk(d, lnb_on, len, rbuf, rlen);
        else
-               ret |= lme2510_usb_talk(d, lnb_off, len, rbuf, rlen);
+               ret = lme2510_usb_talk(d, lnb_off, len, rbuf, rlen);
 
        st->i2c_talk_onoff = 1;
 
@@ -936,7 +1110,10 @@ static int lme2510_probe(struct usb_interface *intf,
                return -ENODEV;
        }
 
-       lme_firmware_switch(udev, 0);
+       if (lme2510_return_status(udev) == 0x44) {
+               lme_firmware_switch(udev, 0);
+               return -ENODEV;
+       }
 
        if (0 == dvb_usb_device_init(intf, &lme2510_properties,
                                     THIS_MODULE, NULL, adapter_nr)) {
@@ -964,15 +1141,17 @@ MODULE_DEVICE_TABLE(usb, lme2510_table);
 
 static struct dvb_usb_device_properties lme2510_properties = {
        .caps = DVB_USB_IS_AN_I2C_ADAPTER,
-       .usb_ctrl = DEVICE_SPECIFIC,
-       .download_firmware = lme2510_download_firmware,
-       .firmware = "dvb-usb-lme2510-lg.fw",
-
        .size_of_priv = sizeof(struct lme2510_state),
        .num_adapters = 1,
        .adapter = {
                {
+                       .caps = DVB_USB_ADAP_HAS_PID_FILTER|
+                               DVB_USB_ADAP_NEED_PID_FILTERING|
+                               DVB_USB_ADAP_PID_FILTER_CAN_BE_TURNED_OFF,
                        .streaming_ctrl   = lme2510_streaming_ctrl,
+                       .pid_filter_count = 15,
+                       .pid_filter = lme2510_pid_filter,
+                       .pid_filter_ctrl  = lme2510_pid_filter_ctrl,
                        .frontend_attach  = dm04_lme2510_frontend_attach,
                        .tuner_attach = dm04_lme2510_tuner,
                        /* parameter for the MPEG2-data transfer */
@@ -989,6 +1168,12 @@ static struct dvb_usb_device_properties lme2510_properties = {
                        }
                }
        },
+       .rc.core = {
+               .protocol       = RC_TYPE_NEC,
+               .module_name    = "LME2510 Remote Control",
+               .allowed_protos = RC_TYPE_NEC,
+               .rc_codes       = RC_MAP_LME2510,
+       },
        .power_ctrl       = lme2510_powerup,
        .identify_state   = lme2510_identify_state,
        .i2c_algo         = &lme2510_i2c_algo,
@@ -1004,14 +1189,17 @@ static struct dvb_usb_device_properties lme2510_properties = {
 
 static struct dvb_usb_device_properties lme2510c_properties = {
        .caps = DVB_USB_IS_AN_I2C_ADAPTER,
-       .usb_ctrl = DEVICE_SPECIFIC,
-       .download_firmware = lme2510_download_firmware,
-       .firmware = (const char *)&lme_firmware,
        .size_of_priv = sizeof(struct lme2510_state),
        .num_adapters = 1,
        .adapter = {
                {
+                       .caps = DVB_USB_ADAP_HAS_PID_FILTER|
+                               DVB_USB_ADAP_NEED_PID_FILTERING|
+                               DVB_USB_ADAP_PID_FILTER_CAN_BE_TURNED_OFF,
                        .streaming_ctrl   = lme2510_streaming_ctrl,
+                       .pid_filter_count = 15,
+                       .pid_filter = lme2510_pid_filter,
+                       .pid_filter_ctrl  = lme2510_pid_filter_ctrl,
                        .frontend_attach  = dm04_lme2510_frontend_attach,
                        .tuner_attach = dm04_lme2510_tuner,
                        /* parameter for the MPEG2-data transfer */
@@ -1028,6 +1216,12 @@ static struct dvb_usb_device_properties lme2510c_properties = {
                        }
                }
        },
+       .rc.core = {
+               .protocol       = RC_TYPE_NEC,
+               .module_name    = "LME2510 Remote Control",
+               .allowed_protos = RC_TYPE_NEC,
+               .rc_codes       = RC_MAP_LME2510,
+       },
        .power_ctrl       = lme2510_powerup,
        .identify_state   = lme2510_identify_state,
        .i2c_algo         = &lme2510_i2c_algo,
@@ -1040,7 +1234,7 @@ static struct dvb_usb_device_properties lme2510c_properties = {
        }
 };
 
-void *lme2510_exit_int(struct dvb_usb_device *d)
+static void *lme2510_exit_int(struct dvb_usb_device *d)
 {
        struct lme2510_state *st = d->priv;
        struct dvb_usb_adapter *adap = &d->adapter[0];
@@ -1051,23 +1245,25 @@ void *lme2510_exit_int(struct dvb_usb_device *d)
                adap->feedcount = 0;
        }
 
-       if (st->lme_urb != NULL) {
+       if (st->usb_buffer != NULL) {
                st->i2c_talk_onoff = 1;
                st->signal_lock = 0;
                st->signal_level = 0;
                st->signal_sn = 0;
                buffer = st->usb_buffer;
+       }
+
+       if (st->lme_urb != NULL) {
                usb_kill_urb(st->lme_urb);
                usb_free_coherent(d->udev, 5000, st->buffer,
                                  st->lme_urb->transfer_dma);
-               info("Interupt Service Stopped");
-               rc_unregister_device(d->rc_dev);
-               info("Remote Stopped");
+               info("Interrupt Service Stopped");
        }
+
        return buffer;
 }
 
-void lme2510_exit(struct usb_interface *intf)
+static void lme2510_exit(struct usb_interface *intf)
 {
        struct dvb_usb_device *d = usb_get_intfdata(intf);
        void *usb_buffer;
@@ -1075,7 +1271,8 @@ void lme2510_exit(struct usb_interface *intf)
        if (d != NULL) {
                usb_buffer = lme2510_exit_int(d);
                dvb_usb_device_exit(intf);
-               kfree(usb_buffer);
+               if (usb_buffer != NULL)
+                       kfree(usb_buffer);
        }
 }
 
@@ -1109,5 +1306,5 @@ module_exit(lme2510_module_exit);
 
 MODULE_AUTHOR("Malcolm Priestley <tvboxspy@gmail.com>");
 MODULE_DESCRIPTION("LME2510(C) DVB-S USB2.0");
-MODULE_VERSION("1.75");
+MODULE_VERSION("1.88");
 MODULE_LICENSE("GPL");