Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
[pandora-kernel.git] / drivers / ide / ide.c
index f338fe9..300431d 100644 (file)
@@ -94,19 +94,8 @@ DEFINE_MUTEX(ide_cfg_mtx);
 
 int noautodma = 0;
 
-#ifdef CONFIG_BLK_DEV_IDEACPI
-int ide_noacpi = 0;
-int ide_noacpitfs = 1;
-int ide_noacpionboot = 1;
-#endif
-
-/*
- * This is declared extern in ide.h, for access by other IDE modules:
- */
 ide_hwif_t ide_hwifs[MAX_HWIFS];       /* master data repository */
 
-EXPORT_SYMBOL(ide_hwifs);
-
 static void ide_port_init_devices_data(ide_hwif_t *);
 
 /*
@@ -232,93 +221,6 @@ static int ide_system_bus_speed(void)
        return pci_dev_present(pci_default) ? 33 : 50;
 }
 
-static struct resource* hwif_request_region(ide_hwif_t *hwif,
-                                           unsigned long addr, int num)
-{
-       struct resource *res = request_region(addr, num, hwif->name);
-
-       if (!res)
-               printk(KERN_ERR "%s: I/O resource 0x%lX-0x%lX not free.\n",
-                               hwif->name, addr, addr+num-1);
-       return res;
-}
-
-/**
- *     ide_hwif_request_regions - request resources for IDE
- *     @hwif: interface to use
- *
- *     Requests all the needed resources for an interface.
- *     Right now core IDE code does this work which is deeply wrong.
- *     MMIO leaves it to the controller driver,
- *     PIO will migrate this way over time.
- */
-
-int ide_hwif_request_regions(ide_hwif_t *hwif)
-{
-       unsigned long addr;
-       unsigned int i;
-
-       if (hwif->mmio)
-               return 0;
-       addr = hwif->io_ports[IDE_CONTROL_OFFSET];
-       if (addr && !hwif_request_region(hwif, addr, 1))
-               goto control_region_busy;
-       hwif->straight8 = 0;
-       addr = hwif->io_ports[IDE_DATA_OFFSET];
-       if ((addr | 7) == hwif->io_ports[IDE_STATUS_OFFSET]) {
-               if (!hwif_request_region(hwif, addr, 8))
-                       goto data_region_busy;
-               hwif->straight8 = 1;
-               return 0;
-       }
-       for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; i++) {
-               addr = hwif->io_ports[i];
-               if (!hwif_request_region(hwif, addr, 1)) {
-                       while (--i)
-                               release_region(addr, 1);
-                       goto data_region_busy;
-               }
-       }
-       return 0;
-
-data_region_busy:
-       addr = hwif->io_ports[IDE_CONTROL_OFFSET];
-       if (addr)
-               release_region(addr, 1);
-control_region_busy:
-       /* If any errors are return, we drop the hwif interface. */
-       return -EBUSY;
-}
-
-/**
- *     ide_hwif_release_regions - free IDE resources
- *
- *     Note that we only release the standard ports,
- *     and do not even try to handle any extra ports
- *     allocated for weird IDE interface chipsets.
- *
- *     Note also that we don't yet handle mmio resources here. More
- *     importantly our caller should be doing this so we need to 
- *     restructure this as a helper function for drivers.
- */
-
-void ide_hwif_release_regions(ide_hwif_t *hwif)
-{
-       u32 i = 0;
-
-       if (hwif->mmio)
-               return;
-       if (hwif->io_ports[IDE_CONTROL_OFFSET])
-               release_region(hwif->io_ports[IDE_CONTROL_OFFSET], 1);
-       if (hwif->straight8) {
-               release_region(hwif->io_ports[IDE_DATA_OFFSET], 8);
-               return;
-       }
-       for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; i++)
-               if (hwif->io_ports[i])
-                       release_region(hwif->io_ports[i], 1);
-}
-
 void ide_remove_port_from_hwgroup(ide_hwif_t *hwif)
 {
        ide_hwgroup_t *hwgroup = hwif->hwgroup;
@@ -385,7 +287,7 @@ EXPORT_SYMBOL_GPL(ide_port_unregister_devices);
 
 /**
  *     ide_unregister          -       free an IDE interface
- *     @index: index of interface (will change soon to a pointer)
+ *     @hwif: IDE interface
  *
  *     Perform the final unregister of an IDE interface. At the moment
  *     we don't refcount interfaces so this will also get split up.
@@ -405,24 +307,22 @@ EXPORT_SYMBOL_GPL(ide_port_unregister_devices);
  *     This is raving bonkers.
  */
 
-void ide_unregister(unsigned int index)
+void ide_unregister(ide_hwif_t *hwif)
 {
-       ide_hwif_t *hwif, *g;
+       ide_hwif_t *g;
        ide_hwgroup_t *hwgroup;
        int irq_count = 0;
 
-       BUG_ON(index >= MAX_HWIFS);
-
        BUG_ON(in_interrupt());
        BUG_ON(irqs_disabled());
+
        mutex_lock(&ide_cfg_mtx);
-       spin_lock_irq(&ide_lock);
-       hwif = &ide_hwifs[index];
-       if (!hwif->present)
-               goto abort;
-       __ide_port_unregister_devices(hwif);
-       hwif->present = 0;
 
+       spin_lock_irq(&ide_lock);
+       if (hwif->present) {
+               __ide_port_unregister_devices(hwif);
+               hwif->present = 0;
+       }
        spin_unlock_irq(&ide_lock);
 
        ide_proc_unregister_port(hwif);
@@ -452,18 +352,15 @@ void ide_unregister(unsigned int index)
        blk_unregister_region(MKDEV(hwif->major, 0), MAX_DRIVES<<PARTN_BITS);
        kfree(hwif->sg_table);
        unregister_blkdev(hwif->major, hwif->name);
-       spin_lock_irq(&ide_lock);
 
        if (hwif->dma_base)
-               (void)ide_release_dma(hwif);
-
-       ide_hwif_release_regions(hwif);
+               ide_release_dma_engine(hwif);
 
+       spin_lock_irq(&ide_lock);
        /* restore hwif data to pristine status */
-       ide_init_port_data(hwif, index);
-
-abort:
+       ide_init_port_data(hwif, hwif->index);
        spin_unlock_irq(&ide_lock);
+
        mutex_unlock(&ide_cfg_mtx);
 }
 
@@ -471,9 +368,8 @@ EXPORT_SYMBOL(ide_unregister);
 
 void ide_init_port_hw(ide_hwif_t *hwif, hw_regs_t *hw)
 {
-       memcpy(hwif->io_ports, hw->io_ports, sizeof(hwif->io_ports));
+       memcpy(&hwif->io_ports, &hw->io_ports, sizeof(hwif->io_ports));
        hwif->irq = hw->irq;
-       hwif->noprobe = 0;
        hwif->chipset = hw->chipset;
        hwif->gendev.parent = hw->dev;
        hwif->ack_intr = hw->ack_intr;
@@ -564,7 +460,7 @@ int set_using_dma(ide_drive_t *drive, int arg)
        if (!drive->id || !(drive->id->capability & 1))
                goto out;
 
-       if (hwif->dma_host_set == NULL)
+       if (hwif->dma_ops == NULL)
                goto out;
 
        err = -EBUSY;
@@ -603,11 +499,14 @@ out:
 int set_pio_mode(ide_drive_t *drive, int arg)
 {
        struct request rq;
+       ide_hwif_t *hwif = drive->hwif;
+       const struct ide_port_ops *port_ops = hwif->port_ops;
 
        if (arg < 0 || arg > 255)
                return -EINVAL;
 
-       if (drive->hwif->set_pio_mode == NULL)
+       if (port_ops == NULL || port_ops->set_pio_mode == NULL ||
+           (hwif->host_flags & IDE_HFLAG_NO_SET_MODE))
                return -ENOSYS;
 
        if (drive->special.b.set_tune)
@@ -665,7 +564,7 @@ static int generic_ide_suspend(struct device *dev, pm_message_t mesg)
        if (!(drive->dn % 2))
                ide_acpi_get_timing(hwif);
 
-       memset(&rq, 0, sizeof(rq));
+       blk_rq_init(NULL, &rq);
        memset(&rqpm, 0, sizeof(rqpm));
        memset(&args, 0, sizeof(args));
        rq.cmd_type = REQ_TYPE_PM_SUSPEND;
@@ -703,7 +602,7 @@ static int generic_ide_resume(struct device *dev)
 
        ide_acpi_exec_tfs(drive);
 
-       memset(&rq, 0, sizeof(rq));
+       blk_rq_init(NULL, &rq);
        memset(&rqpm, 0, sizeof(rqpm));
        memset(&args, 0, sizeof(args));
        rq.cmd_type = REQ_TYPE_PM_RESUME;
@@ -929,16 +828,6 @@ static int __init match_parm (char *s, const char *keywords[], int vals[], int m
        return 0;       /* zero = nothing matched */
 }
 
-extern int probe_ali14xx;
-extern int probe_umc8672;
-extern int probe_dtc2278;
-extern int probe_ht6560b;
-extern int probe_qd65xx;
-extern int cmd640_vlb;
-extern int probe_4drives;
-
-static int __initdata is_chipset_set;
-
 /*
  * ide_setup() gets called VERY EARLY during initialization,
  * to handle kernel "command line" strings beginning with "hdx=" or "ide".
@@ -947,14 +836,12 @@ static int __initdata is_chipset_set;
  */
 static int __init ide_setup(char *s)
 {
-       int i, vals[3];
        ide_hwif_t *hwif;
        ide_drive_t *drive;
        unsigned int hw, unit;
+       int vals[3];
        const char max_drive = 'a' + ((MAX_HWIFS * MAX_DRIVES) - 1);
-       const char max_hwif  = '0' + (MAX_HWIFS - 1);
 
-       
        if (strncmp(s,"hd",2) == 0 && s[2] == '=')      /* hd= is for hd.c   */
                return 0;                               /* driver and not us */
 
@@ -970,7 +857,7 @@ static int __init ide_setup(char *s)
 
                printk(" : Enabled support for IDE doublers\n");
                ide_doubler = 1;
-               return 1;
+               goto obsolete_option;
        }
 #endif /* CONFIG_BLK_DEV_IDEDOUBLER */
 
@@ -984,17 +871,17 @@ static int __init ide_setup(char *s)
        if (!strcmp(s, "ide=noacpi")) {
                //printk(" : Disable IDE ACPI support.\n");
                ide_noacpi = 1;
-               return 1;
+               goto obsolete_option;
        }
        if (!strcmp(s, "ide=acpigtf")) {
                //printk(" : Enable IDE ACPI _GTF support.\n");
-               ide_noacpitfs = 0;
-               return 1;
+               ide_acpigtf = 1;
+               goto obsolete_option;
        }
        if (!strcmp(s, "ide=acpionboot")) {
                //printk(" : Call IDE ACPI methods on boot.\n");
-               ide_noacpionboot = 0;
-               return 1;
+               ide_acpionboot = 1;
+               goto obsolete_option;
        }
 #endif /* CONFIG_BLK_DEV_IDEACPI */
 
@@ -1004,7 +891,7 @@ static int __init ide_setup(char *s)
        if (s[0] == 'h' && s[1] == 'd' && s[2] >= 'a' && s[2] <= max_drive) {
                const char *hd_words[] = {
                        "none", "noprobe", "nowerr", "cdrom", "nodma",
-                       "autotune", "noautotune", "-8", "-9", "-10",
+                       "-6", "-7", "-8", "-9", "-10",
                        "noflush", "remap", "remap63", "scsi", NULL };
                unit = s[2] - 'a';
                hw   = unit / MAX_DRIVES;
@@ -1019,30 +906,22 @@ static int __init ide_setup(char *s)
                        case -1: /* "none" */
                        case -2: /* "noprobe" */
                                drive->noprobe = 1;
-                               goto done;
+                               goto obsolete_option;
                        case -3: /* "nowerr" */
                                drive->bad_wstat = BAD_R_STAT;
-                               hwif->noprobe = 0;
-                               goto done;
+                               goto obsolete_option;
                        case -4: /* "cdrom" */
                                drive->present = 1;
                                drive->media = ide_cdrom;
                                /* an ATAPI device ignores DRDY */
                                drive->ready_stat = 0;
-                               hwif->noprobe = 0;
-                               goto done;
+                               goto obsolete_option;
                        case -5: /* nodma */
                                drive->nodma = 1;
-                               goto done;
-                       case -6: /* "autotune" */
-                               drive->autotune = IDE_TUNE_AUTO;
-                               goto obsolete_option;
-                       case -7: /* "noautotune" */
-                               drive->autotune = IDE_TUNE_NOAUTO;
                                goto obsolete_option;
                        case -11: /* noflush */
                                drive->noflush = 1;
-                               goto done;
+                               goto obsolete_option;
                        case -12: /* "remap" */
                                drive->remap_0_to_1 = 1;
                                goto obsolete_option;
@@ -1060,8 +939,7 @@ static int __init ide_setup(char *s)
                                drive->sect     = drive->bios_sect = vals[2];
                                drive->present  = 1;
                                drive->forced_geom = 1;
-                               hwif->noprobe = 0;
-                               goto done;
+                               goto obsolete_option;
                        default:
                                goto bad_option;
                }
@@ -1079,126 +957,15 @@ static int __init ide_setup(char *s)
                        idebus_parameter = vals[0];
                } else
                        printk(" -- BAD BUS SPEED! Expected value from 20 to 66");
-               goto done;
+               goto obsolete_option;
        }
-       /*
-        * Look for interface options:  "idex="
-        */
-       if (s[3] >= '0' && s[3] <= max_hwif) {
-               /*
-                * Be VERY CAREFUL changing this: note hardcoded indexes below
-                * (-8, -9, -10) are reserved to ease the hardcoding.
-                */
-               static const char *ide_words[] = {
-                       "minus1", "serialize", "minus3", "minus4",
-                       "reset", "minus6", "ata66", "minus8", "minus9",
-                       "minus10", "four", "qd65xx", "ht6560b", "cmd640_vlb",
-                       "dtc2278", "umc8672", "ali14xx", NULL };
-
-               hw = s[3] - '0';
-               hwif = &ide_hwifs[hw];
-               i = match_parm(&s[4], ide_words, vals, 3);
-
-               /*
-                * Cryptic check to ensure chipset not already set for hwif.
-                * Note: we can't depend on hwif->chipset here.
-                */
-               if (i >= -18 && i <= -11) {
-                       /* chipset already specified */
-                       if (is_chipset_set)
-                               goto bad_option;
-                       /* these drivers are for "ide0=" only */
-                       if (hw != 0)
-                               goto bad_hwif;
-                       is_chipset_set = 1;
-                       printk("\n");
-               }
-
-               switch (i) {
-#ifdef CONFIG_BLK_DEV_ALI14XX
-                       case -17: /* "ali14xx" */
-                               probe_ali14xx = 1;
-                               goto obsolete_option;
-#endif
-#ifdef CONFIG_BLK_DEV_UMC8672
-                       case -16: /* "umc8672" */
-                               probe_umc8672 = 1;
-                               goto obsolete_option;
-#endif
-#ifdef CONFIG_BLK_DEV_DTC2278
-                       case -15: /* "dtc2278" */
-                               probe_dtc2278 = 1;
-                               goto obsolete_option;
-#endif
-#ifdef CONFIG_BLK_DEV_CMD640
-                       case -14: /* "cmd640_vlb" */
-                               cmd640_vlb = 1;
-                               goto obsolete_option;
-#endif
-#ifdef CONFIG_BLK_DEV_HT6560B
-                       case -13: /* "ht6560b" */
-                               probe_ht6560b = 1;
-                               goto obsolete_option;
-#endif
-#ifdef CONFIG_BLK_DEV_QD65XX
-                       case -12: /* "qd65xx" */
-                               probe_qd65xx = 1;
-                               goto obsolete_option;
-#endif
-#ifdef CONFIG_BLK_DEV_4DRIVES
-                       case -11: /* "four" drives on one set of ports */
-                               probe_4drives = 1;
-                               goto obsolete_option;
-#endif
-                       case -10: /* minus10 */
-                       case -9: /* minus9 */
-                       case -8: /* minus8 */
-                       case -6:
-                       case -4:
-                       case -3:
-                               goto bad_option;
-                       case -7: /* ata66 */
-#ifdef CONFIG_BLK_DEV_IDEPCI
-                               /*
-                                * Use ATA_CBL_PATA40_SHORT so drive side
-                                * cable detection is also overriden.
-                                */
-                               hwif->cbl = ATA_CBL_PATA40_SHORT;
-                               goto obsolete_option;
-#else
-                               goto bad_hwif;
-#endif
-                       case -5: /* "reset" */
-                               hwif->reset = 1;
-                               goto obsolete_option;
-                       case -2: /* "serialize" */
-                               hwif->mate = &ide_hwifs[hw^1];
-                               hwif->mate->mate = hwif;
-                               hwif->serialized = hwif->mate->serialized = 1;
-                               goto obsolete_option;
 
-                       case -1:
-                       case 0:
-                       case 1:
-                       case 2:
-                       case 3:
-                               goto bad_option;
-                       default:
-                               printk(" -- SUPPORT NOT CONFIGURED IN THIS KERNEL\n");
-                               return 1;
-               }
-       }
 bad_option:
        printk(" -- BAD OPTION\n");
        return 1;
 obsolete_option:
        printk(" -- OBSOLETE OPTION, WILL BE REMOVED SOON!\n");
        return 1;
-bad_hwif:
-       printk("-- NOT SUPPORTED ON ide%d", hw);
-done:
-       printk("\n");
-       return 1;
 }
 
 EXPORT_SYMBOL(ide_lock);
@@ -1327,11 +1094,183 @@ struct bus_type ide_bus_type = {
 
 EXPORT_SYMBOL_GPL(ide_bus_type);
 
-static void ide_port_class_release(struct device *portdev)
+int ide_vlb_clk;
+EXPORT_SYMBOL_GPL(ide_vlb_clk);
+
+module_param_named(vlb_clock, ide_vlb_clk, int, 0);
+MODULE_PARM_DESC(vlb_clock, "VLB clock frequency (in MHz)");
+
+int ide_pci_clk;
+EXPORT_SYMBOL_GPL(ide_pci_clk);
+
+module_param_named(pci_clock, ide_pci_clk, int, 0);
+MODULE_PARM_DESC(pci_clock, "PCI bus clock frequency (in MHz)");
+
+static int ide_set_dev_param_mask(const char *s, struct kernel_param *kp)
 {
-       ide_hwif_t *hwif = dev_get_drvdata(portdev);
+       int a, b, i, j = 1;
+       unsigned int *dev_param_mask = (unsigned int *)kp->arg;
+
+       if (sscanf(s, "%d.%d:%d", &a, &b, &j) != 3 &&
+           sscanf(s, "%d.%d", &a, &b) != 2)
+               return -EINVAL;
+
+       i = a * MAX_DRIVES + b;
 
-       put_device(&hwif->gendev);
+       if (i >= MAX_HWIFS * MAX_DRIVES || j < 0 || j > 1)
+               return -EINVAL;
+
+       if (j)
+               *dev_param_mask |= (1 << i);
+       else
+               *dev_param_mask &= (1 << i);
+
+       return 0;
+}
+
+static unsigned int ide_nodma;
+
+module_param_call(nodma, ide_set_dev_param_mask, NULL, &ide_nodma, 0);
+MODULE_PARM_DESC(nodma, "disallow DMA for a device");
+
+static unsigned int ide_noflush;
+
+module_param_call(noflush, ide_set_dev_param_mask, NULL, &ide_noflush, 0);
+MODULE_PARM_DESC(noflush, "disable flush requests for a device");
+
+static unsigned int ide_noprobe;
+
+module_param_call(noprobe, ide_set_dev_param_mask, NULL, &ide_noprobe, 0);
+MODULE_PARM_DESC(noprobe, "skip probing for a device");
+
+static unsigned int ide_nowerr;
+
+module_param_call(nowerr, ide_set_dev_param_mask, NULL, &ide_nowerr, 0);
+MODULE_PARM_DESC(nowerr, "ignore the WRERR_STAT bit for a device");
+
+static unsigned int ide_cdroms;
+
+module_param_call(cdrom, ide_set_dev_param_mask, NULL, &ide_cdroms, 0);
+MODULE_PARM_DESC(cdrom, "force device as a CD-ROM");
+
+struct chs_geom {
+       unsigned int    cyl;
+       u8              head;
+       u8              sect;
+};
+
+static unsigned int ide_disks;
+static struct chs_geom ide_disks_chs[MAX_HWIFS * MAX_DRIVES];
+
+static int ide_set_disk_chs(const char *str, struct kernel_param *kp)
+{
+       int a, b, c = 0, h = 0, s = 0, i, j = 1;
+
+       if (sscanf(str, "%d.%d:%d,%d,%d", &a, &b, &c, &h, &s) != 5 &&
+           sscanf(str, "%d.%d:%d", &a, &b, &j) != 3)
+               return -EINVAL;
+
+       i = a * MAX_DRIVES + b;
+
+       if (i >= MAX_HWIFS * MAX_DRIVES || j < 0 || j > 1)
+               return -EINVAL;
+
+       if (c > INT_MAX || h > 255 || s > 255)
+               return -EINVAL;
+
+       if (j)
+               ide_disks |= (1 << i);
+       else
+               ide_disks &= (1 << i);
+
+       ide_disks_chs[i].cyl  = c;
+       ide_disks_chs[i].head = h;
+       ide_disks_chs[i].sect = s;
+
+       return 0;
+}
+
+module_param_call(chs, ide_set_disk_chs, NULL, NULL, 0);
+MODULE_PARM_DESC(chs, "force device as a disk (using CHS)");
+
+static void ide_dev_apply_params(ide_drive_t *drive)
+{
+       int i = drive->hwif->index * MAX_DRIVES + drive->select.b.unit;
+
+       if (ide_nodma & (1 << i)) {
+               printk(KERN_INFO "ide: disallowing DMA for %s\n", drive->name);
+               drive->nodma = 1;
+       }
+       if (ide_noflush & (1 << i)) {
+               printk(KERN_INFO "ide: disabling flush requests for %s\n",
+                                drive->name);
+               drive->noflush = 1;
+       }
+       if (ide_noprobe & (1 << i)) {
+               printk(KERN_INFO "ide: skipping probe for %s\n", drive->name);
+               drive->noprobe = 1;
+       }
+       if (ide_nowerr & (1 << i)) {
+               printk(KERN_INFO "ide: ignoring the WRERR_STAT bit for %s\n",
+                                drive->name);
+               drive->bad_wstat = BAD_R_STAT;
+       }
+       if (ide_cdroms & (1 << i)) {
+               printk(KERN_INFO "ide: forcing %s as a CD-ROM\n", drive->name);
+               drive->present = 1;
+               drive->media = ide_cdrom;
+               /* an ATAPI device ignores DRDY */
+               drive->ready_stat = 0;
+       }
+       if (ide_disks & (1 << i)) {
+               drive->cyl  = drive->bios_cyl  = ide_disks_chs[i].cyl;
+               drive->head = drive->bios_head = ide_disks_chs[i].head;
+               drive->sect = drive->bios_sect = ide_disks_chs[i].sect;
+               drive->forced_geom = 1;
+               printk(KERN_INFO "ide: forcing %s as a disk (%d/%d/%d)\n",
+                                drive->name,
+                                drive->cyl, drive->head, drive->sect);
+               drive->present = 1;
+               drive->media = ide_disk;
+               drive->ready_stat = READY_STAT;
+       }
+}
+
+static unsigned int ide_ignore_cable;
+
+static int ide_set_ignore_cable(const char *s, struct kernel_param *kp)
+{
+       int i, j = 1;
+
+       if (sscanf(s, "%d:%d", &i, &j) != 2 && sscanf(s, "%d", &i) != 1)
+               return -EINVAL;
+
+       if (i >= MAX_HWIFS || j < 0 || j > 1)
+               return -EINVAL;
+
+       if (j)
+               ide_ignore_cable |= (1 << i);
+       else
+               ide_ignore_cable &= (1 << i);
+
+       return 0;
+}
+
+module_param_call(ignore_cable, ide_set_ignore_cable, NULL, NULL, 0);
+MODULE_PARM_DESC(ignore_cable, "ignore cable detection");
+
+void ide_port_apply_params(ide_hwif_t *hwif)
+{
+       int i;
+
+       if (ide_ignore_cable & (1 << hwif->index)) {
+               printk(KERN_INFO "ide: ignoring cable detection for %s\n",
+                                hwif->name);
+               hwif->cbl = ATA_CBL_PATA40_SHORT;
+       }
+
+       for (i = 0; i < MAX_DRIVES; i++)
+               ide_dev_apply_params(&hwif->drives[i]);
 }
 
 /*
@@ -1359,7 +1298,6 @@ static int __init ide_init(void)
                ret = PTR_ERR(ide_port_class);
                goto out_port_class;
        }
-       ide_port_class->dev_release = ide_port_class_release;
 
        init_ide_data();
 
@@ -1400,11 +1338,6 @@ int __init init_module (void)
 
 void __exit cleanup_module (void)
 {
-       int index;
-
-       for (index = 0; index < MAX_HWIFS; ++index)
-               ide_unregister(index);
-
        proc_ide_destroy();
 
        class_destroy(ide_port_class);