Merge branch 'for_paulus' of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc
[pandora-kernel.git] / drivers / hwmon / w83792d.c
index 1ba0726..958602e 100644 (file)
@@ -43,6 +43,7 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
 #include <linux/err.h>
+#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, 0x2f, I2C_CLIENT_END };
@@ -269,10 +270,9 @@ DIV_TO_REG(long val)
 struct w83792d_data {
        struct i2c_client client;
        struct class_device *class_dev;
-       struct semaphore lock;
        enum chips type;
 
-       struct semaphore update_lock;
+       struct mutex update_lock;
        char valid;             /* !=0 if following fields are valid */
        unsigned long last_updated;     /* In jiffies */
 
@@ -282,7 +282,7 @@ struct w83792d_data {
        u8 in[9];               /* Register value */
        u8 in_max[9];           /* Register value */
        u8 in_min[9];           /* Register value */
-       u8 low_bits[2];         /* Additional resolution to voltage in0-6 */
+       u16 low_bits;           /* Additional resolution to voltage in6-0 */
        u8 fan[7];              /* Register value */
        u8 fan_min[7];          /* Register value */
        u8 temp1[3];            /* current, over, thyst */
@@ -304,10 +304,6 @@ struct w83792d_data {
 static int w83792d_attach_adapter(struct i2c_adapter *adapter);
 static int w83792d_detect(struct i2c_adapter *adapter, int address, int kind);
 static int w83792d_detach_client(struct i2c_client *client);
-
-static int w83792d_read_value(struct i2c_client *client, u8 register);
-static int w83792d_write_value(struct i2c_client *client, u8 register,
-                               u8 value);
 static struct w83792d_data *w83792d_update_device(struct device *dev);
 
 #ifdef DEBUG
@@ -317,45 +313,31 @@ static void w83792d_print_debug(struct w83792d_data *data, struct device *dev);
 static void w83792d_init_client(struct i2c_client *client);
 
 static struct i2c_driver w83792d_driver = {
-       .owner = THIS_MODULE,
-       .name = "w83792d",
-       .flags = I2C_DF_NOTIFY,
+       .driver = {
+               .name = "w83792d",
+       },
        .attach_adapter = w83792d_attach_adapter,
        .detach_client = w83792d_detach_client,
 };
 
-static long in_count_from_reg(int nr, struct w83792d_data *data)
+static inline long in_count_from_reg(int nr, struct w83792d_data *data)
 {
-       u16 vol_count = data->in[nr];
-       u16 low_bits = 0;
-       vol_count = (vol_count << 2);
-       switch (nr)
-       {
-       case 0:  /* vin0 */
-               low_bits = (data->low_bits[0]) & 0x03;
-               break;
-       case 1:  /* vin1 */
-               low_bits = ((data->low_bits[0]) & 0x0c) >> 2;
-               break;
-       case 2:  /* vin2 */
-               low_bits = ((data->low_bits[0]) & 0x30) >> 4;
-               break;
-       case 3:  /* vin3 */
-               low_bits = ((data->low_bits[0]) & 0xc0) >> 6;
-               break;
-       case 4:  /* vin4 */
-               low_bits = (data->low_bits[1]) & 0x03;
-               break;
-       case 5:  /* vin5 */
-               low_bits = ((data->low_bits[1]) & 0x0c) >> 2;
-               break;
-       case 6:  /* vin6 */
-               low_bits = ((data->low_bits[1]) & 0x30) >> 4;
-       default:
-               break;
-       }
-       vol_count = vol_count | low_bits;
-       return vol_count;
+       /* in7 and in8 do not have low bits, but the formula still works */
+       return ((data->in[nr] << 2) | ((data->low_bits >> (2 * nr)) & 0x03));
+}
+
+/* The SMBus locks itself. The Winbond W83792D chip has a bank register,
+   but the driver only accesses registers in bank 0, so we don't have
+   to switch banks and lock access between switches. */
+static inline int w83792d_read_value(struct i2c_client *client, u8 reg)
+{
+       return i2c_smbus_read_byte_data(client, reg);
+}
+
+static inline int
+w83792d_write_value(struct i2c_client *client, u8 reg, u8 value)
+{
+       return i2c_smbus_write_byte_data(client, reg, value);
 }
 
 /* following are the sysfs callback functions */
@@ -401,30 +383,40 @@ static ssize_t store_in_##reg (struct device *dev, \
 store_in_reg(MIN, min);
 store_in_reg(MAX, max);
 
-#define sysfs_in_reg(offset) \
-static SENSOR_DEVICE_ATTR(in##offset##_input, S_IRUGO, show_in, \
-                               NULL, offset); \
-static SENSOR_DEVICE_ATTR(in##offset##_min, S_IRUGO | S_IWUSR, \
-                               show_in_min, store_in_min, offset); \
-static SENSOR_DEVICE_ATTR(in##offset##_max, S_IRUGO | S_IWUSR, \
-                               show_in_max, store_in_max, offset);
-
-sysfs_in_reg(0);
-sysfs_in_reg(1);
-sysfs_in_reg(2);
-sysfs_in_reg(3);
-sysfs_in_reg(4);
-sysfs_in_reg(5);
-sysfs_in_reg(6);
-sysfs_in_reg(7);
-sysfs_in_reg(8);
-
-#define device_create_file_in(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_in##offset##_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_in##offset##_max.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_in##offset##_min.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_in_input[] = {
+       SENSOR_ATTR(in0_input, S_IRUGO, show_in, NULL, 0),
+       SENSOR_ATTR(in1_input, S_IRUGO, show_in, NULL, 1),
+       SENSOR_ATTR(in2_input, S_IRUGO, show_in, NULL, 2),
+       SENSOR_ATTR(in3_input, S_IRUGO, show_in, NULL, 3),
+       SENSOR_ATTR(in4_input, S_IRUGO, show_in, NULL, 4),
+       SENSOR_ATTR(in5_input, S_IRUGO, show_in, NULL, 5),
+       SENSOR_ATTR(in6_input, S_IRUGO, show_in, NULL, 6),
+       SENSOR_ATTR(in7_input, S_IRUGO, show_in, NULL, 7),
+       SENSOR_ATTR(in8_input, S_IRUGO, show_in, NULL, 8),
+};
+static struct sensor_device_attribute sda_in_min[] = {
+       SENSOR_ATTR(in0_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 0),
+       SENSOR_ATTR(in1_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 1),
+       SENSOR_ATTR(in2_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 2),
+       SENSOR_ATTR(in3_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 3),
+       SENSOR_ATTR(in4_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 4),
+       SENSOR_ATTR(in5_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 5),
+       SENSOR_ATTR(in6_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 6),
+       SENSOR_ATTR(in7_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 7),
+       SENSOR_ATTR(in8_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 8),
+};
+static struct sensor_device_attribute sda_in_max[] = {
+       SENSOR_ATTR(in0_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 0),
+       SENSOR_ATTR(in1_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 1),
+       SENSOR_ATTR(in2_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 2),
+       SENSOR_ATTR(in3_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 3),
+       SENSOR_ATTR(in4_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 4),
+       SENSOR_ATTR(in5_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 5),
+       SENSOR_ATTR(in6_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 6),
+       SENSOR_ATTR(in7_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 7),
+       SENSOR_ATTR(in8_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 8),
+};
+
 
 #define show_fan_reg(reg) \
 static ssize_t show_##reg (struct device *dev, struct device_attribute *attr, \
@@ -505,28 +497,33 @@ store_fan_div(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_fan(offset) \
-static SENSOR_DEVICE_ATTR(fan##offset##_input, S_IRUGO, show_fan, NULL, \
-                               offset); \
-static SENSOR_DEVICE_ATTR(fan##offset##_div, S_IRUGO | S_IWUSR, \
-                               show_fan_div, store_fan_div, offset); \
-static SENSOR_DEVICE_ATTR(fan##offset##_min, S_IRUGO | S_IWUSR, \
-                               show_fan_min, store_fan_min, offset);
-
-sysfs_fan(1);
-sysfs_fan(2);
-sysfs_fan(3);
-sysfs_fan(4);
-sysfs_fan(5);
-sysfs_fan(6);
-sysfs_fan(7);
-
-#define device_create_file_fan(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_div.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_min.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_fan_input[] = {
+       SENSOR_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 1),
+       SENSOR_ATTR(fan2_input, S_IRUGO, show_fan, NULL, 2),
+       SENSOR_ATTR(fan3_input, S_IRUGO, show_fan, NULL, 3),
+       SENSOR_ATTR(fan4_input, S_IRUGO, show_fan, NULL, 4),
+       SENSOR_ATTR(fan5_input, S_IRUGO, show_fan, NULL, 5),
+       SENSOR_ATTR(fan6_input, S_IRUGO, show_fan, NULL, 6),
+       SENSOR_ATTR(fan7_input, S_IRUGO, show_fan, NULL, 7),
+};
+static struct sensor_device_attribute sda_fan_min[] = {
+       SENSOR_ATTR(fan1_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 1),
+       SENSOR_ATTR(fan2_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 2),
+       SENSOR_ATTR(fan3_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 3),
+       SENSOR_ATTR(fan4_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 4),
+       SENSOR_ATTR(fan5_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 5),
+       SENSOR_ATTR(fan6_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 6),
+       SENSOR_ATTR(fan7_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 7),
+};
+static struct sensor_device_attribute sda_fan_div[] = {
+       SENSOR_ATTR(fan1_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 1),
+       SENSOR_ATTR(fan2_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 2),
+       SENSOR_ATTR(fan3_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 3),
+       SENSOR_ATTR(fan4_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 4),
+       SENSOR_ATTR(fan5_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 5),
+       SENSOR_ATTR(fan6_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 6),
+       SENSOR_ATTR(fan7_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 7),
+};
 
 
 /* read/write the temperature1, includes measured value and limits */
@@ -558,21 +555,6 @@ static ssize_t store_temp1(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-
-static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp1, NULL, 0);
-static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO | S_IWUSR, show_temp1,
-                               store_temp1, 1);
-static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IRUGO | S_IWUSR, show_temp1,
-                               store_temp1, 2);
-
-#define device_create_file_temp1(client) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_temp1_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_temp1_max.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_temp1_max_hyst.dev_attr); \
-} while (0)
-
-
 /* read/write the temperature2-3, includes measured value and limits */
 
 static ssize_t show_temp23(struct device *dev, struct device_attribute *attr,
@@ -609,25 +591,23 @@ static ssize_t store_temp23(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_temp23(name,idx) \
-static SENSOR_DEVICE_ATTR_2(name##_input, S_IRUGO, show_temp23, NULL, \
-                               idx, 0); \
-static SENSOR_DEVICE_ATTR_2(name##_max, S_IRUGO | S_IWUSR, \
-                               show_temp23, store_temp23, idx, 2); \
-static SENSOR_DEVICE_ATTR_2(name##_max_hyst, S_IRUGO | S_IWUSR, \
-                               show_temp23, store_temp23, idx, 4);
-
-sysfs_temp23(temp2,0)
-sysfs_temp23(temp3,1)
+static struct sensor_device_attribute_2 sda_temp_input[] = {
+       SENSOR_ATTR_2(temp1_input, S_IRUGO, show_temp1, NULL, 0, 0),
+       SENSOR_ATTR_2(temp2_input, S_IRUGO, show_temp23, NULL, 0, 0),
+       SENSOR_ATTR_2(temp3_input, S_IRUGO, show_temp23, NULL, 1, 0),
+};
 
-#define device_create_file_temp_add(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_temp##offset##_input.dev_attr); \
-device_create_file(&client->dev, &sensor_dev_attr_temp##offset##_max.dev_attr); \
-device_create_file(&client->dev, \
-&sensor_dev_attr_temp##offset##_max_hyst.dev_attr); \
-} while (0)
+static struct sensor_device_attribute_2 sda_temp_max[] = {
+       SENSOR_ATTR_2(temp1_max, S_IRUGO | S_IWUSR, show_temp1, store_temp1, 0, 1),
+       SENSOR_ATTR_2(temp2_max, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 0, 2),
+       SENSOR_ATTR_2(temp3_max, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 1, 2),
+};
 
+static struct sensor_device_attribute_2 sda_temp_max_hyst[] = {
+       SENSOR_ATTR_2(temp1_max_hyst, S_IRUGO | S_IWUSR, show_temp1, store_temp1, 0, 2),
+       SENSOR_ATTR_2(temp2_max_hyst, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 0, 4),
+       SENSOR_ATTR_2(temp3_max_hyst, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 1, 4),
+};
 
 /* get reatime status of all sensors items: voltage, temp, fan */
 static ssize_t
@@ -639,10 +619,6 @@ show_alarms_reg(struct device *dev, struct device_attribute *attr, char *buf)
 
 static
 DEVICE_ATTR(alarms, S_IRUGO, show_alarms_reg, NULL);
-#define device_create_file_alarms(client) \
-device_create_file(&client->dev, &dev_attr_alarms);
-
-
 
 static ssize_t
 show_pwm(struct device *dev, struct device_attribute *attr,
@@ -730,26 +706,19 @@ store_pwmenable(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_pwm(offset) \
-static SENSOR_DEVICE_ATTR(pwm##offset, S_IRUGO | S_IWUSR, \
-                               show_pwm, store_pwm, offset); \
-static SENSOR_DEVICE_ATTR(pwm##offset##_enable, S_IRUGO | S_IWUSR, \
-                               show_pwmenable, store_pwmenable, offset); \
-
-sysfs_pwm(1);
-sysfs_pwm(2);
-sysfs_pwm(3);
-
-
-#define device_create_file_pwm(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_pwm##offset.dev_attr); \
-} while (0)
-
-#define device_create_file_pwmenable(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_pwm##offset##_enable.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_pwm[] = {
+       SENSOR_ATTR(pwm1, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 1),
+       SENSOR_ATTR(pwm2, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 2),
+       SENSOR_ATTR(pwm3, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 3),
+};
+static struct sensor_device_attribute sda_pwm_enable[] = {
+       SENSOR_ATTR(pwm1_enable, S_IWUSR | S_IRUGO,
+                   show_pwmenable, store_pwmenable, 1),
+       SENSOR_ATTR(pwm2_enable, S_IWUSR | S_IRUGO,
+                   show_pwmenable, store_pwmenable, 2),
+       SENSOR_ATTR(pwm3_enable, S_IWUSR | S_IRUGO,
+                   show_pwmenable, store_pwmenable, 3),
+};
 
 
 static ssize_t
@@ -783,18 +752,14 @@ store_pwm_mode(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_pwm_mode(offset) \
-static SENSOR_DEVICE_ATTR(pwm##offset##_mode, S_IRUGO | S_IWUSR, \
-                               show_pwm_mode, store_pwm_mode, offset);
-
-sysfs_pwm_mode(1);
-sysfs_pwm_mode(2);
-sysfs_pwm_mode(3);
-
-#define device_create_file_pwm_mode(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_pwm##offset##_mode.dev_attr); \
-} while (0)
+static struct sensor_device_attribute sda_pwm_mode[] = {
+       SENSOR_ATTR(pwm1_mode, S_IWUSR | S_IRUGO,
+                   show_pwm_mode, store_pwm_mode, 1),
+       SENSOR_ATTR(pwm2_mode, S_IWUSR | S_IRUGO,
+                   show_pwm_mode, store_pwm_mode, 2),
+       SENSOR_ATTR(pwm3_mode, S_IWUSR | S_IRUGO,
+                   show_pwm_mode, store_pwm_mode, 3),
+};
 
 
 static ssize_t
@@ -807,12 +772,6 @@ show_regs_chassis(struct device *dev, struct device_attribute *attr,
 
 static DEVICE_ATTR(chassis, S_IRUGO, show_regs_chassis, NULL);
 
-#define device_create_file_chassis(client) \
-do { \
-device_create_file(&client->dev, &dev_attr_chassis); \
-} while (0)
-
-
 static ssize_t
 show_chassis_clear(struct device *dev, struct device_attribute *attr, char *buf)
 {
@@ -843,13 +802,6 @@ store_chassis_clear(struct device *dev, struct device_attribute *attr,
 static DEVICE_ATTR(chassis_clear, S_IRUGO | S_IWUSR,
                show_chassis_clear, store_chassis_clear);
 
-#define device_create_file_chassis_clear(client) \
-do { \
-device_create_file(&client->dev, &dev_attr_chassis_clear); \
-} while (0)
-
-
-
 /* For Smart Fan I / Thermal Cruise */
 static ssize_t
 show_thermal_cruise(struct device *dev, struct device_attribute *attr,
@@ -883,20 +835,14 @@ store_thermal_cruise(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_thermal_cruise(offset) \
-static SENSOR_DEVICE_ATTR(thermal_cruise##offset, S_IRUGO | S_IWUSR, \
-                       show_thermal_cruise, store_thermal_cruise, offset);
-
-sysfs_thermal_cruise(1);
-sysfs_thermal_cruise(2);
-sysfs_thermal_cruise(3);
-
-#define device_create_file_thermal_cruise(client, offset) \
-do { \
-device_create_file(&client->dev, \
-&sensor_dev_attr_thermal_cruise##offset.dev_attr); \
-} while (0)
-
+static struct sensor_device_attribute sda_thermal_cruise[] = {
+       SENSOR_ATTR(thermal_cruise1, S_IWUSR | S_IRUGO,
+                   show_thermal_cruise, store_thermal_cruise, 1),
+       SENSOR_ATTR(thermal_cruise2, S_IWUSR | S_IRUGO,
+                   show_thermal_cruise, store_thermal_cruise, 2),
+       SENSOR_ATTR(thermal_cruise3, S_IWUSR | S_IRUGO,
+                   show_thermal_cruise, store_thermal_cruise, 3),
+};
 
 /* For Smart Fan I/Thermal Cruise and Smart Fan II */
 static ssize_t
@@ -935,19 +881,14 @@ store_tolerance(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_tolerance(offset) \
-static SENSOR_DEVICE_ATTR(tolerance##offset, S_IRUGO | S_IWUSR, \
-                               show_tolerance, store_tolerance, offset);
-
-sysfs_tolerance(1);
-sysfs_tolerance(2);
-sysfs_tolerance(3);
-
-#define device_create_file_tolerance(client, offset) \
-do { \
-device_create_file(&client->dev, &sensor_dev_attr_tolerance##offset.dev_attr); \
-} while (0)
-
+static struct sensor_device_attribute sda_tolerance[] = {
+       SENSOR_ATTR(tolerance1, S_IWUSR | S_IRUGO,
+                   show_tolerance, store_tolerance, 1),
+       SENSOR_ATTR(tolerance2, S_IWUSR | S_IRUGO,
+                   show_tolerance, store_tolerance, 2),
+       SENSOR_ATTR(tolerance3, S_IWUSR | S_IRUGO,
+                   show_tolerance, store_tolerance, 3),
+};
 
 /* For Smart Fan II */
 static ssize_t
@@ -983,28 +924,34 @@ store_sf2_point(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_sf2_point(offset, index) \
-static SENSOR_DEVICE_ATTR_2(sf2_point##offset##_fan##index, S_IRUGO | S_IWUSR, \
-                               show_sf2_point, store_sf2_point, offset, index);
-
-sysfs_sf2_point(1, 1); /* Fan1 */
-sysfs_sf2_point(2, 1); /* Fan1 */
-sysfs_sf2_point(3, 1); /* Fan1 */
-sysfs_sf2_point(4, 1); /* Fan1 */
-sysfs_sf2_point(1, 2); /* Fan2 */
-sysfs_sf2_point(2, 2); /* Fan2 */
-sysfs_sf2_point(3, 2); /* Fan2 */
-sysfs_sf2_point(4, 2); /* Fan2 */
-sysfs_sf2_point(1, 3); /* Fan3 */
-sysfs_sf2_point(2, 3); /* Fan3 */
-sysfs_sf2_point(3, 3); /* Fan3 */
-sysfs_sf2_point(4, 3); /* Fan3 */
-
-#define device_create_file_sf2_point(client, offset, index) \
-do { \
-device_create_file(&client->dev, \
-&sensor_dev_attr_sf2_point##offset##_fan##index.dev_attr); \
-} while (0)
+static struct sensor_device_attribute_2 sda_sf2_point[] = {
+       SENSOR_ATTR_2(sf2_point1_fan1, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 1, 1),
+       SENSOR_ATTR_2(sf2_point2_fan1, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 2, 1),
+       SENSOR_ATTR_2(sf2_point3_fan1, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 3, 1),
+       SENSOR_ATTR_2(sf2_point4_fan1, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 4, 1),
+
+       SENSOR_ATTR_2(sf2_point1_fan2, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 1, 2),
+       SENSOR_ATTR_2(sf2_point2_fan2, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 2, 2),
+       SENSOR_ATTR_2(sf2_point3_fan2, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 3, 2),
+       SENSOR_ATTR_2(sf2_point4_fan2, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 4, 2),
+
+       SENSOR_ATTR_2(sf2_point1_fan3, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 1, 3),
+       SENSOR_ATTR_2(sf2_point2_fan3, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 2, 3),
+       SENSOR_ATTR_2(sf2_point3_fan3, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 3, 3),
+       SENSOR_ATTR_2(sf2_point4_fan3, S_IRUGO | S_IWUSR,
+                     show_sf2_point, store_sf2_point, 4, 3),
+};
 
 
 static ssize_t
@@ -1045,26 +992,28 @@ store_sf2_level(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-#define sysfs_sf2_level(offset, index) \
-static SENSOR_DEVICE_ATTR_2(sf2_level##offset##_fan##index, S_IRUGO | S_IWUSR, \
-                               show_sf2_level, store_sf2_level, offset, index);
-
-sysfs_sf2_level(1, 1); /* Fan1 */
-sysfs_sf2_level(2, 1); /* Fan1 */
-sysfs_sf2_level(3, 1); /* Fan1 */
-sysfs_sf2_level(1, 2); /* Fan2 */
-sysfs_sf2_level(2, 2); /* Fan2 */
-sysfs_sf2_level(3, 2); /* Fan2 */
-sysfs_sf2_level(1, 3); /* Fan3 */
-sysfs_sf2_level(2, 3); /* Fan3 */
-sysfs_sf2_level(3, 3); /* Fan3 */
-
-#define device_create_file_sf2_level(client, offset, index) \
-do { \
-device_create_file(&client->dev, \
-&sensor_dev_attr_sf2_level##offset##_fan##index.dev_attr); \
-} while (0)
-
+static struct sensor_device_attribute_2 sda_sf2_level[] = {
+       SENSOR_ATTR_2(sf2_level1_fan1, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 1, 1),
+       SENSOR_ATTR_2(sf2_level2_fan1, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 2, 1),
+       SENSOR_ATTR_2(sf2_level3_fan1, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 3, 1),
+
+       SENSOR_ATTR_2(sf2_level1_fan2, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 1, 2),
+       SENSOR_ATTR_2(sf2_level2_fan2, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 2, 2),
+       SENSOR_ATTR_2(sf2_level3_fan2, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 3, 2),
+
+       SENSOR_ATTR_2(sf2_level1_fan3, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 1, 3),
+       SENSOR_ATTR_2(sf2_level2_fan3, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 2, 3),
+       SENSOR_ATTR_2(sf2_level3_fan3, S_IRUGO | S_IWUSR,
+                     show_sf2_level, store_sf2_level, 3, 3),
+};
 
 /* This function is called when:
      * w83792d_driver is inserted (when this module is loaded), for each
@@ -1166,12 +1115,19 @@ ERROR_SC_0:
        return err;
 }
 
+static void device_create_file_fan(struct device *dev, int i)
+{
+       device_create_file(dev, &sda_fan_input[i].dev_attr);
+       device_create_file(dev, &sda_fan_div[i].dev_attr);
+       device_create_file(dev, &sda_fan_min[i].dev_attr);
+}
 
 static int
 w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
 {
        int i = 0, val1 = 0, val2;
-       struct i2c_client *new_client;
+       struct i2c_client *client;
+       struct device *dev;
        struct w83792d_data *data;
        int err = 0;
        const char *client_name = "";
@@ -1189,13 +1145,13 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
                goto ERROR0;
        }
 
-       new_client = &data->client;
-       i2c_set_clientdata(new_client, data);
-       new_client->addr = address;
-       init_MUTEX(&data->lock);
-       new_client->adapter = adapter;
-       new_client->driver = &w83792d_driver;
-       new_client->flags = 0;
+       client = &data->client;
+       dev = &client->dev;
+       i2c_set_clientdata(client, data);
+       client->addr = address;
+       client->adapter = adapter;
+       client->driver = &w83792d_driver;
+       client->flags = 0;
 
        /* Now, we do the remaining detection. */
 
@@ -1204,50 +1160,49 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
           force_*=... parameter, and the Winbond will be reset to the right
           bank. */
        if (kind < 0) {
-               if (w83792d_read_value(new_client, W83792D_REG_CONFIG) & 0x80) {
-                       dev_warn(&new_client->dev, "Detection failed at step "
-                               "3\n");
+               if (w83792d_read_value(client, W83792D_REG_CONFIG) & 0x80) {
+                       dev_dbg(dev, "Detection failed at step 1\n");
                        goto ERROR1;
                }
-               val1 = w83792d_read_value(new_client, W83792D_REG_BANK);
-               val2 = w83792d_read_value(new_client, W83792D_REG_CHIPMAN);
+               val1 = w83792d_read_value(client, W83792D_REG_BANK);
+               val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
                /* Check for Winbond ID if in bank 0 */
                if (!(val1 & 0x07)) {  /* is Bank0 */
                        if (((!(val1 & 0x80)) && (val2 != 0xa3)) ||
                             ((val1 & 0x80) && (val2 != 0x5c))) {
+                               dev_dbg(dev, "Detection failed at step 2\n");
                                goto ERROR1;
                        }
                }
                /* If Winbond chip, address of chip and W83792D_REG_I2C_ADDR
                   should match */
-               if (w83792d_read_value(new_client,
+               if (w83792d_read_value(client,
                                        W83792D_REG_I2C_ADDR) != address) {
-                       dev_warn(&new_client->dev, "Detection failed "
-                               "at step 5\n");
+                       dev_dbg(dev, "Detection failed at step 3\n");
                        goto ERROR1;
                }
        }
 
        /* We have either had a force parameter, or we have already detected the
           Winbond. Put it now into bank 0 and Vendor ID High Byte */
-       w83792d_write_value(new_client,
+       w83792d_write_value(client,
                            W83792D_REG_BANK,
-                           (w83792d_read_value(new_client,
+                           (w83792d_read_value(client,
                                W83792D_REG_BANK) & 0x78) | 0x80);
 
        /* Determine the chip type. */
        if (kind <= 0) {
                /* get vendor ID */
-               val2 = w83792d_read_value(new_client, W83792D_REG_CHIPMAN);
+               val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
                if (val2 != 0x5c) {  /* the vendor is NOT Winbond */
                        goto ERROR1;
                }
-               val1 = w83792d_read_value(new_client, W83792D_REG_WCHIPID);
-               if (val1 == 0x7a && address >= 0x2c) {
+               val1 = w83792d_read_value(client, W83792D_REG_WCHIPID);
+               if (val1 == 0x7a) {
                        kind = w83792d;
                } else {
                        if (kind == 0)
-                                       dev_warn(&new_client->dev,
+                                       dev_warn(dev,
                                        "w83792d: Ignoring 'force' parameter for"
                                        " unknown chip at adapter %d, address"
                                        " 0x%02x\n", i2c_adapter_id(adapter),
@@ -1259,120 +1214,86 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
        if (kind == w83792d) {
                client_name = "w83792d";
        } else {
-               dev_err(&new_client->dev, "w83792d: Internal error: unknown"
+               dev_err(dev, "w83792d: Internal error: unknown"
                                          " kind (%d)?!?", kind);
                goto ERROR1;
        }
 
        /* Fill in the remaining client fields and put into the global list */
-       strlcpy(new_client->name, client_name, I2C_NAME_SIZE);
+       strlcpy(client->name, client_name, I2C_NAME_SIZE);
        data->type = kind;
 
        data->valid = 0;
-       init_MUTEX(&data->update_lock);
+       mutex_init(&data->update_lock);
 
        /* Tell the I2C layer a new client has arrived */
-       if ((err = i2c_attach_client(new_client)))
+       if ((err = i2c_attach_client(client)))
                goto ERROR1;
 
        if ((err = w83792d_detect_subclients(adapter, address,
-                       kind, new_client)))
+                       kind, client)))
                goto ERROR2;
 
        /* Initialize the chip */
-       w83792d_init_client(new_client);
+       w83792d_init_client(client);
 
        /* A few vars need to be filled upon startup */
        for (i = 0; i < 7; i++) {
-               data->fan_min[i] = w83792d_read_value(new_client,
+               data->fan_min[i] = w83792d_read_value(client,
                                        W83792D_REG_FAN_MIN[i]);
        }
 
        /* Register sysfs hooks */
-       data->class_dev = hwmon_device_register(&new_client->dev);
+       data->class_dev = hwmon_device_register(dev);
        if (IS_ERR(data->class_dev)) {
                err = PTR_ERR(data->class_dev);
                goto ERROR3;
        }
-       device_create_file_in(new_client, 0);
-       device_create_file_in(new_client, 1);
-       device_create_file_in(new_client, 2);
-       device_create_file_in(new_client, 3);
-       device_create_file_in(new_client, 4);
-       device_create_file_in(new_client, 5);
-       device_create_file_in(new_client, 6);
-       device_create_file_in(new_client, 7);
-       device_create_file_in(new_client, 8);
-
-       device_create_file_fan(new_client, 1);
-       device_create_file_fan(new_client, 2);
-       device_create_file_fan(new_client, 3);
+       for (i = 0; i < 9; i++) {
+               device_create_file(dev, &sda_in_input[i].dev_attr);
+               device_create_file(dev, &sda_in_max[i].dev_attr);
+               device_create_file(dev, &sda_in_min[i].dev_attr);
+       }
+       for (i = 0; i < 3; i++)
+               device_create_file_fan(dev, i);
 
        /* Read GPIO enable register to check if pins for fan 4,5 are used as
           GPIO */
-       val1 = w83792d_read_value(new_client, W83792D_REG_GPIO_EN);
+       val1 = w83792d_read_value(client, W83792D_REG_GPIO_EN);
        if (!(val1 & 0x40))
-               device_create_file_fan(new_client, 4);
+               device_create_file_fan(dev, 3);
        if (!(val1 & 0x20))
-               device_create_file_fan(new_client, 5);
+               device_create_file_fan(dev, 4);
 
-       val1 = w83792d_read_value(new_client, W83792D_REG_PIN);
+       val1 = w83792d_read_value(client, W83792D_REG_PIN);
        if (val1 & 0x40)
-               device_create_file_fan(new_client, 6);
+               device_create_file_fan(dev, 5);
        if (val1 & 0x04)
-               device_create_file_fan(new_client, 7);
-
-       device_create_file_temp1(new_client);           /* Temp1 */
-       device_create_file_temp_add(new_client, 2);     /* Temp2 */
-       device_create_file_temp_add(new_client, 3);     /* Temp3 */
-
-       device_create_file_alarms(new_client);
-
-       device_create_file_pwm(new_client, 1);
-       device_create_file_pwm(new_client, 2);
-       device_create_file_pwm(new_client, 3);
-
-       device_create_file_pwmenable(new_client, 1);
-       device_create_file_pwmenable(new_client, 2);
-       device_create_file_pwmenable(new_client, 3);
-
-       device_create_file_pwm_mode(new_client, 1);
-       device_create_file_pwm_mode(new_client, 2);
-       device_create_file_pwm_mode(new_client, 3);
-
-       device_create_file_chassis(new_client);
-       device_create_file_chassis_clear(new_client);
-
-       device_create_file_thermal_cruise(new_client, 1);
-       device_create_file_thermal_cruise(new_client, 2);
-       device_create_file_thermal_cruise(new_client, 3);
-
-       device_create_file_tolerance(new_client, 1);
-       device_create_file_tolerance(new_client, 2);
-       device_create_file_tolerance(new_client, 3);
-
-       device_create_file_sf2_point(new_client, 1, 1); /* Fan1 */
-       device_create_file_sf2_point(new_client, 2, 1); /* Fan1 */
-       device_create_file_sf2_point(new_client, 3, 1); /* Fan1 */
-       device_create_file_sf2_point(new_client, 4, 1); /* Fan1 */
-       device_create_file_sf2_point(new_client, 1, 2); /* Fan2 */
-       device_create_file_sf2_point(new_client, 2, 2); /* Fan2 */
-       device_create_file_sf2_point(new_client, 3, 2); /* Fan2 */
-       device_create_file_sf2_point(new_client, 4, 2); /* Fan2 */
-       device_create_file_sf2_point(new_client, 1, 3); /* Fan3 */
-       device_create_file_sf2_point(new_client, 2, 3); /* Fan3 */
-       device_create_file_sf2_point(new_client, 3, 3); /* Fan3 */
-       device_create_file_sf2_point(new_client, 4, 3); /* Fan3 */
-
-       device_create_file_sf2_level(new_client, 1, 1); /* Fan1 */
-       device_create_file_sf2_level(new_client, 2, 1); /* Fan1 */
-       device_create_file_sf2_level(new_client, 3, 1); /* Fan1 */
-       device_create_file_sf2_level(new_client, 1, 2); /* Fan2 */
-       device_create_file_sf2_level(new_client, 2, 2); /* Fan2 */
-       device_create_file_sf2_level(new_client, 3, 2); /* Fan2 */
-       device_create_file_sf2_level(new_client, 1, 3); /* Fan3 */
-       device_create_file_sf2_level(new_client, 2, 3); /* Fan3 */
-       device_create_file_sf2_level(new_client, 3, 3); /* Fan3 */
+               device_create_file_fan(dev, 6);
+
+       for (i = 0; i < 3; i++) {
+               device_create_file(dev, &sda_temp_input[i].dev_attr);
+               device_create_file(dev, &sda_temp_max[i].dev_attr);
+               device_create_file(dev, &sda_temp_max_hyst[i].dev_attr);
+               device_create_file(dev, &sda_thermal_cruise[i].dev_attr);
+               device_create_file(dev, &sda_tolerance[i].dev_attr);
+       }
+
+       for (i = 0; i < ARRAY_SIZE(sda_pwm); i++) {
+               device_create_file(dev, &sda_pwm[i].dev_attr);
+               device_create_file(dev, &sda_pwm_enable[i].dev_attr);
+               device_create_file(dev, &sda_pwm_mode[i].dev_attr);
+       }
+
+       device_create_file(dev, &dev_attr_alarms);
+       device_create_file(dev, &dev_attr_chassis);
+       device_create_file(dev, &dev_attr_chassis_clear);
+
+       for (i = 0; i < ARRAY_SIZE(sda_sf2_point); i++)
+               device_create_file(dev, &sda_sf2_point[i].dev_attr);
+
+       for (i = 0; i < ARRAY_SIZE(sda_sf2_level); i++)
+               device_create_file(dev, &sda_sf2_level[i].dev_attr);
 
        return 0;
 
@@ -1386,7 +1307,7 @@ ERROR3:
                kfree(data->lm75[1]);
        }
 ERROR2:
-       i2c_detach_client(new_client);
+       i2c_detach_client(client);
 ERROR1:
        kfree(data);
 ERROR0:
@@ -1416,28 +1337,6 @@ w83792d_detach_client(struct i2c_client *client)
        return 0;
 }
 
-/* The SMBus locks itself, usually, but nothing may access the Winbond between
-   bank switches. ISA access must always be locked explicitly!
-   We ignore the W83792D BUSY flag at this moment - it could lead to deadlocks,
-   would slow down the W83792D access and should not be necessary.
-   There are some ugly typecasts here, but the good news is - they should
-   nowhere else be necessary! */
-static int
-w83792d_read_value(struct i2c_client *client, u8 reg)
-{
-       int res=0;
-       res = i2c_smbus_read_byte_data(client, reg);
-
-       return res;
-}
-
-static int
-w83792d_write_value(struct i2c_client *client, u8 reg, u8 value)
-{
-       i2c_smbus_write_byte_data(client, reg,  value);
-       return 0;
-}
-
 static void
 w83792d_init_client(struct i2c_client *client)
 {
@@ -1476,7 +1375,7 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
        int i, j;
        u8 reg_array_tmp[4], pwm_array_tmp[7], reg_tmp;
 
-       down(&data->update_lock);
+       mutex_lock(&data->update_lock);
 
        if (time_after
            (jiffies - data->last_updated, (unsigned long) (HZ * 3))
@@ -1492,10 +1391,10 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
                        data->in_min[i] = w83792d_read_value(client,
                                                W83792D_REG_IN_MIN[i]);
                }
-               data->low_bits[0] = w83792d_read_value(client,
-                                               W83792D_REG_LOW_BITS1);
-               data->low_bits[1] = w83792d_read_value(client,
-                                               W83792D_REG_LOW_BITS2);
+               data->low_bits = w83792d_read_value(client,
+                                               W83792D_REG_LOW_BITS1) +
+                                (w83792d_read_value(client,
+                                               W83792D_REG_LOW_BITS2) << 8);
                for (i = 0; i < 7; i++) {
                        /* Update the Fan measured value and limits */
                        data->fan[i] = w83792d_read_value(client,
@@ -1506,7 +1405,7 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
                        pwm_array_tmp[i] = w83792d_read_value(client,
                                                W83792D_REG_PWM[i]);
                        data->pwm[i] = pwm_array_tmp[i] & 0x0f;
-                       data->pwm_mode[i] = (pwm_array_tmp[i] >> 7) & 0x01;
+                       data->pwm_mode[i] = pwm_array_tmp[i] >> 7;
                }
 
                reg_tmp = w83792d_read_value(client, W83792D_REG_FAN_CFG);
@@ -1587,7 +1486,7 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
                data->valid = 1;
        }
 
-       up(&data->update_lock);
+       mutex_unlock(&data->update_lock);
 
 #ifdef DEBUG
        w83792d_print_debug(data, dev);
@@ -1607,8 +1506,8 @@ static void w83792d_print_debug(struct w83792d_data *data, struct device *dev)
                dev_dbg(dev, "vin[%d] max is: 0x%x\n", i, data->in_max[i]);
                dev_dbg(dev, "vin[%d] min is: 0x%x\n", i, data->in_min[i]);
        }
-       dev_dbg(dev, "Low Bit1 is: 0x%x\n", data->low_bits[0]);
-       dev_dbg(dev, "Low Bit2 is: 0x%x\n", data->low_bits[1]);
+       dev_dbg(dev, "Low Bit1 is: 0x%x\n", data->low_bits & 0xff);
+       dev_dbg(dev, "Low Bit2 is: 0x%x\n", data->low_bits >> 8);
        dev_dbg(dev, "7 set of Fan Counts and Duty Cycles: =====>\n");
        for (i=0; i<7; i++) {
                dev_dbg(dev, "fan[%d] is: 0x%x\n", i, data->fan[i]);