Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux
[pandora-kernel.git] / drivers / gpu / drm / nouveau / nv50_display.c
index b244d99..f97b42c 100644 (file)
  *
  */
 
-#define NOUVEAU_DMA_DEBUG (nouveau_reg_debug & NOUVEAU_REG_DEBUG_EVO)
+#include "nouveau_drm.h"
+#include "nouveau_dma.h"
+
 #include "nv50_display.h"
 #include "nouveau_crtc.h"
 #include "nouveau_encoder.h"
 #include "nouveau_connector.h"
-#include "nouveau_fb.h"
 #include "nouveau_fbcon.h"
-#include "nouveau_ramht.h"
-#include "nouveau_software.h"
-#include "drm_crtc_helper.h"
+#include <drm/drm_crtc_helper.h>
+#include "nouveau_fence.h"
+
+#include <core/gpuobj.h>
+#include <subdev/timer.h>
 
-static void nv50_display_isr(struct drm_device *);
 static void nv50_display_bh(unsigned long);
 
 static inline int
 nv50_sor_nr(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
+       struct nouveau_device *device = nouveau_dev(dev);
 
-       if (dev_priv->chipset  < 0x90 ||
-           dev_priv->chipset == 0x92 ||
-           dev_priv->chipset == 0xa0)
+       if (device->chipset  < 0x90 ||
+           device->chipset == 0x92 ||
+           device->chipset == 0xa0)
                return 2;
 
        return 4;
@@ -54,73 +56,29 @@ nv50_sor_nr(struct drm_device *dev)
 u32
 nv50_display_active_crtcs(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
+       struct nouveau_device *device = nouveau_dev(dev);
        u32 mask = 0;
        int i;
 
-       if (dev_priv->chipset  < 0x90 ||
-           dev_priv->chipset == 0x92 ||
-           dev_priv->chipset == 0xa0) {
+       if (device->chipset  < 0x90 ||
+           device->chipset == 0x92 ||
+           device->chipset == 0xa0) {
                for (i = 0; i < 2; i++)
-                       mask |= nv_rd32(dev, NV50_PDISPLAY_SOR_MODE_CTRL_C(i));
+                       mask |= nv_rd32(device, NV50_PDISPLAY_SOR_MODE_CTRL_C(i));
        } else {
                for (i = 0; i < 4; i++)
-                       mask |= nv_rd32(dev, NV90_PDISPLAY_SOR_MODE_CTRL_C(i));
+                       mask |= nv_rd32(device, NV90_PDISPLAY_SOR_MODE_CTRL_C(i));
        }
 
        for (i = 0; i < 3; i++)
-               mask |= nv_rd32(dev, NV50_PDISPLAY_DAC_MODE_CTRL_C(i));
+               mask |= nv_rd32(device, NV50_PDISPLAY_DAC_MODE_CTRL_C(i));
 
        return mask & 3;
 }
 
-static int
-evo_icmd(struct drm_device *dev, int ch, u32 mthd, u32 data)
-{
-       int ret = 0;
-       nv_mask(dev, 0x610300 + (ch * 0x08), 0x00000001, 0x00000001);
-       nv_wr32(dev, 0x610304 + (ch * 0x08), data);
-       nv_wr32(dev, 0x610300 + (ch * 0x08), 0x80000001 | mthd);
-       if (!nv_wait(dev, 0x610300 + (ch * 0x08), 0x80000000, 0x00000000))
-               ret = -EBUSY;
-       if (ret || (nouveau_reg_debug & NOUVEAU_REG_DEBUG_EVO))
-               NV_INFO(dev, "EvoPIO: %d 0x%04x 0x%08x\n", ch, mthd, data);
-       nv_mask(dev, 0x610300 + (ch * 0x08), 0x00000001, 0x00000000);
-       return ret;
-}
-
 int
 nv50_display_early_init(struct drm_device *dev)
 {
-       u32 ctrl = nv_rd32(dev, 0x610200);
-       int i;
-
-       /* check if master evo channel is already active, a good a sign as any
-        * that the display engine is in a weird state (hibernate/kexec), if
-        * it is, do our best to reset the display engine...
-        */
-       if ((ctrl & 0x00000003) == 0x00000003) {
-               NV_INFO(dev, "PDISP: EVO(0) 0x%08x, resetting...\n", ctrl);
-
-               /* deactivate both heads first, PDISP will disappear forever
-                * (well, until you power cycle) on some boards as soon as
-                * PMC_ENABLE is hit unless they are..
-                */
-               for (i = 0; i < 2; i++) {
-                       evo_icmd(dev, 0, 0x0880 + (i * 0x400), 0x05000000);
-                       evo_icmd(dev, 0, 0x089c + (i * 0x400), 0);
-                       evo_icmd(dev, 0, 0x0840 + (i * 0x400), 0);
-                       evo_icmd(dev, 0, 0x0844 + (i * 0x400), 0);
-                       evo_icmd(dev, 0, 0x085c + (i * 0x400), 0);
-                       evo_icmd(dev, 0, 0x0874 + (i * 0x400), 0);
-               }
-               evo_icmd(dev, 0, 0x0080, 0);
-
-               /* reset PDISP */
-               nv_mask(dev, 0x000200, 0x40000000, 0x00000000);
-               nv_mask(dev, 0x000200, 0x40000000, 0x40000000);
-       }
-
        return 0;
 }
 
@@ -132,11 +90,8 @@ nv50_display_late_takedown(struct drm_device *dev)
 int
 nv50_display_sync(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
-       struct nouveau_timer_engine *ptimer = &dev_priv->engine.timer;
        struct nv50_display *disp = nv50_display(dev);
        struct nouveau_channel *evo = disp->master;
-       u64 start;
        int ret;
 
        ret = RING_SPACE(evo, 6);
@@ -148,29 +103,28 @@ nv50_display_sync(struct drm_device *dev)
                BEGIN_NV04(evo, 0, 0x0084, 1);
                OUT_RING  (evo, 0x00000000);
 
-               nv_wo32(disp->ntfy, 0x000, 0x00000000);
+               nv_wo32(disp->ramin, 0x2000, 0x00000000);
                FIRE_RING (evo);
 
-               start = ptimer->read(dev);
-               do {
-                       if (nv_ro32(disp->ntfy, 0x000))
-                               return 0;
-               } while (ptimer->read(dev) - start < 2000000000ULL);
+               if (nv_wait_ne(disp->ramin, 0x2000, 0xffffffff, 0x00000000))
+                       return 0;
        }
 
-       return -EBUSY;
+       return 0;
 }
 
 int
 nv50_display_init(struct drm_device *dev)
 {
+       struct nouveau_drm *drm = nouveau_drm(dev);
+       struct nouveau_device *device = nouveau_dev(dev);
        struct nouveau_channel *evo;
        int ret, i;
        u32 val;
 
-       NV_DEBUG_KMS(dev, "\n");
+       NV_DEBUG(drm, "\n");
 
-       nv_wr32(dev, 0x00610184, nv_rd32(dev, 0x00614004));
+       nv_wr32(device, 0x00610184, nv_rd32(device, 0x00614004));
 
        /*
         * I think the 0x006101XX range is some kind of main control area
@@ -178,82 +132,82 @@ nv50_display_init(struct drm_device *dev)
         */
        /* CRTC? */
        for (i = 0; i < 2; i++) {
-               val = nv_rd32(dev, 0x00616100 + (i * 0x800));
-               nv_wr32(dev, 0x00610190 + (i * 0x10), val);
-               val = nv_rd32(dev, 0x00616104 + (i * 0x800));
-               nv_wr32(dev, 0x00610194 + (i * 0x10), val);
-               val = nv_rd32(dev, 0x00616108 + (i * 0x800));
-               nv_wr32(dev, 0x00610198 + (i * 0x10), val);
-               val = nv_rd32(dev, 0x0061610c + (i * 0x800));
-               nv_wr32(dev, 0x0061019c + (i * 0x10), val);
+               val = nv_rd32(device, 0x00616100 + (i * 0x800));
+               nv_wr32(device, 0x00610190 + (i * 0x10), val);
+               val = nv_rd32(device, 0x00616104 + (i * 0x800));
+               nv_wr32(device, 0x00610194 + (i * 0x10), val);
+               val = nv_rd32(device, 0x00616108 + (i * 0x800));
+               nv_wr32(device, 0x00610198 + (i * 0x10), val);
+               val = nv_rd32(device, 0x0061610c + (i * 0x800));
+               nv_wr32(device, 0x0061019c + (i * 0x10), val);
        }
 
        /* DAC */
        for (i = 0; i < 3; i++) {
-               val = nv_rd32(dev, 0x0061a000 + (i * 0x800));
-               nv_wr32(dev, 0x006101d0 + (i * 0x04), val);
+               val = nv_rd32(device, 0x0061a000 + (i * 0x800));
+               nv_wr32(device, 0x006101d0 + (i * 0x04), val);
        }
 
        /* SOR */
        for (i = 0; i < nv50_sor_nr(dev); i++) {
-               val = nv_rd32(dev, 0x0061c000 + (i * 0x800));
-               nv_wr32(dev, 0x006101e0 + (i * 0x04), val);
+               val = nv_rd32(device, 0x0061c000 + (i * 0x800));
+               nv_wr32(device, 0x006101e0 + (i * 0x04), val);
        }
 
        /* EXT */
        for (i = 0; i < 3; i++) {
-               val = nv_rd32(dev, 0x0061e000 + (i * 0x800));
-               nv_wr32(dev, 0x006101f0 + (i * 0x04), val);
+               val = nv_rd32(device, 0x0061e000 + (i * 0x800));
+               nv_wr32(device, 0x006101f0 + (i * 0x04), val);
        }
 
        for (i = 0; i < 3; i++) {
-               nv_wr32(dev, NV50_PDISPLAY_DAC_DPMS_CTRL(i), 0x00550000 |
+               nv_wr32(device, NV50_PDISPLAY_DAC_DPMS_CTRL(i), 0x00550000 |
                        NV50_PDISPLAY_DAC_DPMS_CTRL_PENDING);
-               nv_wr32(dev, NV50_PDISPLAY_DAC_CLK_CTRL1(i), 0x00000001);
+               nv_wr32(device, NV50_PDISPLAY_DAC_CLK_CTRL1(i), 0x00000001);
        }
 
        /* The precise purpose is unknown, i suspect it has something to do
         * with text mode.
         */
-       if (nv_rd32(dev, NV50_PDISPLAY_INTR_1) & 0x100) {
-               nv_wr32(dev, NV50_PDISPLAY_INTR_1, 0x100);
-               nv_wr32(dev, 0x006194e8, nv_rd32(dev, 0x006194e8) & ~1);
-               if (!nv_wait(dev, 0x006194e8, 2, 0)) {
-                       NV_ERROR(dev, "timeout: (0x6194e8 & 2) != 0\n");
-                       NV_ERROR(dev, "0x6194e8 = 0x%08x\n",
-                                               nv_rd32(dev, 0x6194e8));
+       if (nv_rd32(device, NV50_PDISPLAY_INTR_1) & 0x100) {
+               nv_wr32(device, NV50_PDISPLAY_INTR_1, 0x100);
+               nv_wr32(device, 0x006194e8, nv_rd32(device, 0x006194e8) & ~1);
+               if (!nv_wait(device, 0x006194e8, 2, 0)) {
+                       NV_ERROR(drm, "timeout: (0x6194e8 & 2) != 0\n");
+                       NV_ERROR(drm, "0x6194e8 = 0x%08x\n",
+                                               nv_rd32(device, 0x6194e8));
                        return -EBUSY;
                }
        }
 
        for (i = 0; i < 2; i++) {
-               nv_wr32(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i), 0x2000);
-               if (!nv_wait(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
+               nv_wr32(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i), 0x2000);
+               if (!nv_wait(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
                             NV50_PDISPLAY_CURSOR_CURSOR_CTRL2_STATUS, 0)) {
-                       NV_ERROR(dev, "timeout: CURSOR_CTRL2_STATUS == 0\n");
-                       NV_ERROR(dev, "CURSOR_CTRL2 = 0x%08x\n",
-                                nv_rd32(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i)));
+                       NV_ERROR(drm, "timeout: CURSOR_CTRL2_STATUS == 0\n");
+                       NV_ERROR(drm, "CURSOR_CTRL2 = 0x%08x\n",
+                                nv_rd32(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i)));
                        return -EBUSY;
                }
 
-               nv_wr32(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
+               nv_wr32(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
                        NV50_PDISPLAY_CURSOR_CURSOR_CTRL2_ON);
-               if (!nv_wait(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
+               if (!nv_wait(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
                             NV50_PDISPLAY_CURSOR_CURSOR_CTRL2_STATUS,
                             NV50_PDISPLAY_CURSOR_CURSOR_CTRL2_STATUS_ACTIVE)) {
-                       NV_ERROR(dev, "timeout: "
+                       NV_ERROR(drm, "timeout: "
                                      "CURSOR_CTRL2_STATUS_ACTIVE(%d)\n", i);
-                       NV_ERROR(dev, "CURSOR_CTRL2(%d) = 0x%08x\n", i,
-                                nv_rd32(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i)));
+                       NV_ERROR(drm, "CURSOR_CTRL2(%d) = 0x%08x\n", i,
+                                nv_rd32(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i)));
                        return -EBUSY;
                }
        }
 
-       nv_wr32(dev, NV50_PDISPLAY_PIO_CTRL, 0x00000000);
-       nv_mask(dev, NV50_PDISPLAY_INTR_0, 0x00000000, 0x00000000);
-       nv_wr32(dev, NV50_PDISPLAY_INTR_EN_0, 0x00000000);
-       nv_mask(dev, NV50_PDISPLAY_INTR_1, 0x00000000, 0x00000000);
-       nv_wr32(dev, NV50_PDISPLAY_INTR_EN_1,
+       nv_wr32(device, NV50_PDISPLAY_PIO_CTRL, 0x00000000);
+       nv_mask(device, NV50_PDISPLAY_INTR_0, 0x00000000, 0x00000000);
+       nv_wr32(device, NV50_PDISPLAY_INTR_EN_0, 0x00000000);
+       nv_mask(device, NV50_PDISPLAY_INTR_1, 0x00000000, 0x00000000);
+       nv_wr32(device, NV50_PDISPLAY_INTR_EN_1,
                     NV50_PDISPLAY_INTR_EN_1_CLK_UNK10 |
                     NV50_PDISPLAY_INTR_EN_1_CLK_UNK20 |
                     NV50_PDISPLAY_INTR_EN_1_CLK_UNK40);
@@ -263,7 +217,7 @@ nv50_display_init(struct drm_device *dev)
                return ret;
        evo = nv50_display(dev)->master;
 
-       nv_wr32(dev, NV50_PDISPLAY_OBJECTS, (evo->ramin->vinst >> 8) | 9);
+       nv_wr32(device, NV50_PDISPLAY_OBJECTS, (nv50_display(dev)->ramin->addr >> 8) | 9);
 
        ret = RING_SPACE(evo, 3);
        if (ret)
@@ -278,12 +232,14 @@ nv50_display_init(struct drm_device *dev)
 void
 nv50_display_fini(struct drm_device *dev)
 {
+       struct nouveau_drm *drm = nouveau_drm(dev);
+       struct nouveau_device *device = nouveau_dev(dev);
        struct nv50_display *disp = nv50_display(dev);
        struct nouveau_channel *evo = disp->master;
        struct drm_crtc *drm_crtc;
        int ret, i;
 
-       NV_DEBUG_KMS(dev, "\n");
+       NV_DEBUG(drm, "\n");
 
        list_for_each_entry(drm_crtc, &dev->mode_config.crtc_list, head) {
                struct nouveau_crtc *crtc = nouveau_crtc(drm_crtc);
@@ -308,55 +264,59 @@ nv50_display_fini(struct drm_device *dev)
                if (!crtc->base.enabled)
                        continue;
 
-               nv_wr32(dev, NV50_PDISPLAY_INTR_1, mask);
-               if (!nv_wait(dev, NV50_PDISPLAY_INTR_1, mask, mask)) {
-                       NV_ERROR(dev, "timeout: (0x610024 & 0x%08x) == "
+               nv_wr32(device, NV50_PDISPLAY_INTR_1, mask);
+               if (!nv_wait(device, NV50_PDISPLAY_INTR_1, mask, mask)) {
+                       NV_ERROR(drm, "timeout: (0x610024 & 0x%08x) == "
                                      "0x%08x\n", mask, mask);
-                       NV_ERROR(dev, "0x610024 = 0x%08x\n",
-                                nv_rd32(dev, NV50_PDISPLAY_INTR_1));
+                       NV_ERROR(drm, "0x610024 = 0x%08x\n",
+                                nv_rd32(device, NV50_PDISPLAY_INTR_1));
                }
        }
 
        for (i = 0; i < 2; i++) {
-               nv_wr32(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i), 0);
-               if (!nv_wait(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
+               nv_wr32(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i), 0);
+               if (!nv_wait(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i),
                             NV50_PDISPLAY_CURSOR_CURSOR_CTRL2_STATUS, 0)) {
-                       NV_ERROR(dev, "timeout: CURSOR_CTRL2_STATUS == 0\n");
-                       NV_ERROR(dev, "CURSOR_CTRL2 = 0x%08x\n",
-                                nv_rd32(dev, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i)));
+                       NV_ERROR(drm, "timeout: CURSOR_CTRL2_STATUS == 0\n");
+                       NV_ERROR(drm, "CURSOR_CTRL2 = 0x%08x\n",
+                                nv_rd32(device, NV50_PDISPLAY_CURSOR_CURSOR_CTRL2(i)));
                }
        }
 
        nv50_evo_fini(dev);
 
        for (i = 0; i < 3; i++) {
-               if (!nv_wait(dev, NV50_PDISPLAY_SOR_DPMS_STATE(i),
+               if (!nv_wait(device, NV50_PDISPLAY_SOR_DPMS_STATE(i),
                             NV50_PDISPLAY_SOR_DPMS_STATE_WAIT, 0)) {
-                       NV_ERROR(dev, "timeout: SOR_DPMS_STATE_WAIT(%d) == 0\n", i);
-                       NV_ERROR(dev, "SOR_DPMS_STATE(%d) = 0x%08x\n", i,
-                                 nv_rd32(dev, NV50_PDISPLAY_SOR_DPMS_STATE(i)));
+                       NV_ERROR(drm, "timeout: SOR_DPMS_STATE_WAIT(%d) == 0\n", i);
+                       NV_ERROR(drm, "SOR_DPMS_STATE(%d) = 0x%08x\n", i,
+                                 nv_rd32(device, NV50_PDISPLAY_SOR_DPMS_STATE(i)));
                }
        }
 
        /* disable interrupts. */
-       nv_wr32(dev, NV50_PDISPLAY_INTR_EN_1, 0x00000000);
+       nv_wr32(device, NV50_PDISPLAY_INTR_EN_1, 0x00000000);
 }
 
 int
 nv50_display_create(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
-       struct dcb_table *dcb = &dev_priv->vbios.dcb;
+       struct nouveau_drm *drm = nouveau_drm(dev);
+       struct dcb_table *dcb = &drm->vbios.dcb;
        struct drm_connector *connector, *ct;
        struct nv50_display *priv;
        int ret, i;
 
-       NV_DEBUG_KMS(dev, "\n");
+       NV_DEBUG(drm, "\n");
 
        priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
-       dev_priv->engine.display.priv = priv;
+
+       nouveau_display(dev)->priv = priv;
+       nouveau_display(dev)->dtor = nv50_display_destroy;
+       nouveau_display(dev)->init = nv50_display_init;
+       nouveau_display(dev)->fini = nv50_display_fini;
 
        /* Create CRTC objects */
        for (i = 0; i < 2; i++) {
@@ -367,10 +327,10 @@ nv50_display_create(struct drm_device *dev)
 
        /* We setup the encoders from the BIOS table */
        for (i = 0 ; i < dcb->entries; i++) {
-               struct dcb_entry *entry = &dcb->entry[i];
+               struct dcb_output *entry = &dcb->entry[i];
 
                if (entry->location != DCB_LOC_ON_CHIP) {
-                       NV_WARN(dev, "Off-chip encoder %d/%d unsupported\n",
+                       NV_WARN(drm, "Off-chip encoder %d/%d unsupported\n",
                                entry->type, ffs(entry->or) - 1);
                        continue;
                }
@@ -380,16 +340,16 @@ nv50_display_create(struct drm_device *dev)
                        continue;
 
                switch (entry->type) {
-               case OUTPUT_TMDS:
-               case OUTPUT_LVDS:
-               case OUTPUT_DP:
+               case DCB_OUTPUT_TMDS:
+               case DCB_OUTPUT_LVDS:
+               case DCB_OUTPUT_DP:
                        nv50_sor_create(connector, entry);
                        break;
-               case OUTPUT_ANALOG:
+               case DCB_OUTPUT_ANALOG:
                        nv50_dac_create(connector, entry);
                        break;
                default:
-                       NV_WARN(dev, "DCB encoder %d unknown\n", entry->type);
+                       NV_WARN(drm, "DCB encoder %d unknown\n", entry->type);
                        continue;
                }
        }
@@ -397,14 +357,13 @@ nv50_display_create(struct drm_device *dev)
        list_for_each_entry_safe(connector, ct,
                                 &dev->mode_config.connector_list, head) {
                if (!connector->encoder_ids[0]) {
-                       NV_WARN(dev, "%s has no encoders, removing\n",
+                       NV_WARN(drm, "%s has no encoders, removing\n",
                                drm_get_connector_name(connector));
                        connector->funcs->destroy(connector);
                }
        }
 
        tasklet_init(&priv->tasklet, nv50_display_bh, (unsigned long)dev);
-       nouveau_irq_register(dev, 26, nv50_display_isr);
 
        ret = nv50_evo_create(dev);
        if (ret) {
@@ -420,13 +379,16 @@ nv50_display_destroy(struct drm_device *dev)
 {
        struct nv50_display *disp = nv50_display(dev);
 
-       NV_DEBUG_KMS(dev, "\n");
-
        nv50_evo_destroy(dev);
-       nouveau_irq_unregister(dev, 26);
        kfree(disp);
 }
 
+struct nouveau_bo *
+nv50_display_crtc_sema(struct drm_device *dev, int crtc)
+{
+       return nv50_display(dev)->crtc[crtc].sem.bo;
+}
+
 void
 nv50_display_flip_stop(struct drm_crtc *crtc)
 {
@@ -457,7 +419,7 @@ int
 nv50_display_flip_next(struct drm_crtc *crtc, struct drm_framebuffer *fb,
                       struct nouveau_channel *chan)
 {
-       struct drm_nouveau_private *dev_priv = crtc->dev->dev_private;
+       struct nouveau_drm *drm = nouveau_drm(crtc->dev);
        struct nouveau_framebuffer *nv_fb = nouveau_framebuffer(fb);
        struct nv50_display *disp = nv50_display(crtc->dev);
        struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
@@ -477,7 +439,7 @@ nv50_display_flip_next(struct drm_crtc *crtc, struct drm_framebuffer *fb,
                        return ret;
                }
 
-               if (dev_priv->chipset < 0xc0) {
+               if (nv_device(drm->device)->chipset < 0xc0) {
                        BEGIN_NV04(chan, 0, 0x0060, 2);
                        OUT_RING  (chan, NvEvoSema0 + nv_crtc->index);
                        OUT_RING  (chan, dispc->sem.offset);
@@ -487,12 +449,12 @@ nv50_display_flip_next(struct drm_crtc *crtc, struct drm_framebuffer *fb,
                        OUT_RING  (chan, dispc->sem.offset ^ 0x10);
                        OUT_RING  (chan, 0x74b1e000);
                        BEGIN_NV04(chan, 0, 0x0060, 1);
-                       if (dev_priv->chipset < 0x84)
+                       if (nv_device(drm->device)->chipset < 0x84)
                                OUT_RING  (chan, NvSema);
                        else
-                               OUT_RING  (chan, chan->vram_handle);
+                               OUT_RING  (chan, chan->vram);
                } else {
-                       u64 offset = nvc0_software_crtc(chan, nv_crtc->index);
+                       u64 offset = nvc0_fence_crtc(chan, nv_crtc->index);
                        offset += dispc->sem.offset;
                        BEGIN_NVC0(chan, 0, 0x0010, 4);
                        OUT_RING  (chan, upper_32_bits(offset));
@@ -555,13 +517,13 @@ nv50_display_flip_next(struct drm_crtc *crtc, struct drm_framebuffer *fb,
 }
 
 static u16
-nv50_display_script_select(struct drm_device *dev, struct dcb_entry *dcb,
+nv50_display_script_select(struct drm_device *dev, struct dcb_output *dcb,
                           u32 mc, int pxclk)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
+       struct nouveau_drm *drm = nouveau_drm(dev);
        struct nouveau_connector *nv_connector = NULL;
        struct drm_encoder *encoder;
-       struct nvbios *bios = &dev_priv->vbios;
+       struct nvbios *bios = &drm->vbios;
        u32 script = 0, or;
 
        list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
@@ -576,7 +538,7 @@ nv50_display_script_select(struct drm_device *dev, struct dcb_entry *dcb,
 
        or = ffs(dcb->or) - 1;
        switch (dcb->type) {
-       case OUTPUT_LVDS:
+       case DCB_OUTPUT_LVDS:
                script = (mc >> 8) & 0xf;
                if (bios->fp_no_ddc) {
                        if (bios->fp.dual_link)
@@ -609,94 +571,39 @@ nv50_display_script_select(struct drm_device *dev, struct dcb_entry *dcb,
                            (nv_connector->edid->input & 0x70) >= 0x20)
                                script |= 0x0200;
                }
-
-               if (nouveau_uscript_lvds >= 0) {
-                       NV_INFO(dev, "override script 0x%04x with 0x%04x "
-                                    "for output LVDS-%d\n", script,
-                                    nouveau_uscript_lvds, or);
-                       script = nouveau_uscript_lvds;
-               }
                break;
-       case OUTPUT_TMDS:
+       case DCB_OUTPUT_TMDS:
                script = (mc >> 8) & 0xf;
                if (pxclk >= 165000)
                        script |= 0x0100;
-
-               if (nouveau_uscript_tmds >= 0) {
-                       NV_INFO(dev, "override script 0x%04x with 0x%04x "
-                                    "for output TMDS-%d\n", script,
-                                    nouveau_uscript_tmds, or);
-                       script = nouveau_uscript_tmds;
-               }
                break;
-       case OUTPUT_DP:
+       case DCB_OUTPUT_DP:
                script = (mc >> 8) & 0xf;
                break;
-       case OUTPUT_ANALOG:
+       case DCB_OUTPUT_ANALOG:
                script = 0xff;
                break;
        default:
-               NV_ERROR(dev, "modeset on unsupported output type!\n");
+               NV_ERROR(drm, "modeset on unsupported output type!\n");
                break;
        }
 
        return script;
 }
 
-static void
-nv50_display_vblank_crtc_handler(struct drm_device *dev, int crtc)
-{
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
-       struct nouveau_software_priv *psw = nv_engine(dev, NVOBJ_ENGINE_SW);
-       struct nouveau_software_chan *pch, *tmp;
-
-       list_for_each_entry_safe(pch, tmp, &psw->vblank, vblank.list) {
-               if (pch->vblank.head != crtc)
-                       continue;
-
-               spin_lock(&psw->peephole_lock);
-               nv_wr32(dev, 0x001704, pch->vblank.channel);
-               nv_wr32(dev, 0x001710, 0x80000000 | pch->vblank.ctxdma);
-               if (dev_priv->chipset == 0x50) {
-                       nv_wr32(dev, 0x001570, pch->vblank.offset);
-                       nv_wr32(dev, 0x001574, pch->vblank.value);
-               } else {
-                       nv_wr32(dev, 0x060010, pch->vblank.offset);
-                       nv_wr32(dev, 0x060014, pch->vblank.value);
-               }
-               spin_unlock(&psw->peephole_lock);
-
-               list_del(&pch->vblank.list);
-               drm_vblank_put(dev, crtc);
-       }
-
-       drm_handle_vblank(dev, crtc);
-}
-
-static void
-nv50_display_vblank_handler(struct drm_device *dev, uint32_t intr)
-{
-       if (intr & NV50_PDISPLAY_INTR_1_VBLANK_CRTC_0)
-               nv50_display_vblank_crtc_handler(dev, 0);
-
-       if (intr & NV50_PDISPLAY_INTR_1_VBLANK_CRTC_1)
-               nv50_display_vblank_crtc_handler(dev, 1);
-
-       nv_wr32(dev, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_VBLANK_CRTC);
-}
-
 static void
 nv50_display_unk10_handler(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
+       struct nouveau_device *device = nouveau_dev(dev);
+       struct nouveau_drm *drm = nouveau_drm(dev);
        struct nv50_display *disp = nv50_display(dev);
-       u32 unk30 = nv_rd32(dev, 0x610030), mc;
-       int i, crtc, or = 0, type = OUTPUT_ANY;
+       u32 unk30 = nv_rd32(device, 0x610030), mc;
+       int i, crtc, or = 0, type = DCB_OUTPUT_ANY;
 
-       NV_DEBUG_KMS(dev, "0x610030: 0x%08x\n", unk30);
+       NV_DEBUG(drm, "0x610030: 0x%08x\n", unk30);
        disp->irq.dcb = NULL;
 
-       nv_wr32(dev, 0x619494, nv_rd32(dev, 0x619494) & ~8);
+       nv_wr32(device, 0x619494, nv_rd32(device, 0x619494) & ~8);
 
        /* Determine which CRTC we're dealing with, only 1 ever will be
         * signalled at the same time with the current nouveau code.
@@ -711,44 +618,44 @@ nv50_display_unk10_handler(struct drm_device *dev)
                goto ack;
 
        /* Find which encoder was connected to the CRTC */
-       for (i = 0; type == OUTPUT_ANY && i < 3; i++) {
-               mc = nv_rd32(dev, NV50_PDISPLAY_DAC_MODE_CTRL_C(i));
-               NV_DEBUG_KMS(dev, "DAC-%d mc: 0x%08x\n", i, mc);
+       for (i = 0; type == DCB_OUTPUT_ANY && i < 3; i++) {
+               mc = nv_rd32(device, NV50_PDISPLAY_DAC_MODE_CTRL_C(i));
+               NV_DEBUG(drm, "DAC-%d mc: 0x%08x\n", i, mc);
                if (!(mc & (1 << crtc)))
                        continue;
 
                switch ((mc & 0x00000f00) >> 8) {
-               case 0: type = OUTPUT_ANALOG; break;
-               case 1: type = OUTPUT_TV; break;
+               case 0: type = DCB_OUTPUT_ANALOG; break;
+               case 1: type = DCB_OUTPUT_TV; break;
                default:
-                       NV_ERROR(dev, "invalid mc, DAC-%d: 0x%08x\n", i, mc);
+                       NV_ERROR(drm, "invalid mc, DAC-%d: 0x%08x\n", i, mc);
                        goto ack;
                }
 
                or = i;
        }
 
-       for (i = 0; type == OUTPUT_ANY && i < nv50_sor_nr(dev); i++) {
-               if (dev_priv->chipset  < 0x90 ||
-                   dev_priv->chipset == 0x92 ||
-                   dev_priv->chipset == 0xa0)
-                       mc = nv_rd32(dev, NV50_PDISPLAY_SOR_MODE_CTRL_C(i));
+       for (i = 0; type == DCB_OUTPUT_ANY && i < nv50_sor_nr(dev); i++) {
+               if (nv_device(drm->device)->chipset  < 0x90 ||
+                   nv_device(drm->device)->chipset == 0x92 ||
+                   nv_device(drm->device)->chipset == 0xa0)
+                       mc = nv_rd32(device, NV50_PDISPLAY_SOR_MODE_CTRL_C(i));
                else
-                       mc = nv_rd32(dev, NV90_PDISPLAY_SOR_MODE_CTRL_C(i));
+                       mc = nv_rd32(device, NV90_PDISPLAY_SOR_MODE_CTRL_C(i));
 
-               NV_DEBUG_KMS(dev, "SOR-%d mc: 0x%08x\n", i, mc);
+               NV_DEBUG(drm, "SOR-%d mc: 0x%08x\n", i, mc);
                if (!(mc & (1 << crtc)))
                        continue;
 
                switch ((mc & 0x00000f00) >> 8) {
-               case 0: type = OUTPUT_LVDS; break;
-               case 1: type = OUTPUT_TMDS; break;
-               case 2: type = OUTPUT_TMDS; break;
-               case 5: type = OUTPUT_TMDS; break;
-               case 8: type = OUTPUT_DP; break;
-               case 9: type = OUTPUT_DP; break;
+               case 0: type = DCB_OUTPUT_LVDS; break;
+               case 1: type = DCB_OUTPUT_TMDS; break;
+               case 2: type = DCB_OUTPUT_TMDS; break;
+               case 5: type = DCB_OUTPUT_TMDS; break;
+               case 8: type = DCB_OUTPUT_DP; break;
+               case 9: type = DCB_OUTPUT_DP; break;
                default:
-                       NV_ERROR(dev, "invalid mc, SOR-%d: 0x%08x\n", i, mc);
+                       NV_ERROR(drm, "invalid mc, SOR-%d: 0x%08x\n", i, mc);
                        goto ack;
                }
 
@@ -756,12 +663,12 @@ nv50_display_unk10_handler(struct drm_device *dev)
        }
 
        /* There was no encoder to disable */
-       if (type == OUTPUT_ANY)
+       if (type == DCB_OUTPUT_ANY)
                goto ack;
 
        /* Disable the encoder */
-       for (i = 0; i < dev_priv->vbios.dcb.entries; i++) {
-               struct dcb_entry *dcb = &dev_priv->vbios.dcb.entry[i];
+       for (i = 0; i < drm->vbios.dcb.entries; i++) {
+               struct dcb_output *dcb = &drm->vbios.dcb.entry[i];
 
                if (dcb->type == type && (dcb->or & (1 << or))) {
                        nouveau_bios_run_display_table(dev, 0, -1, dcb, -1);
@@ -770,22 +677,23 @@ nv50_display_unk10_handler(struct drm_device *dev)
                }
        }
 
-       NV_ERROR(dev, "no dcb for %d %d 0x%08x\n", or, type, mc);
+       NV_ERROR(drm, "no dcb for %d %d 0x%08x\n", or, type, mc);
 ack:
-       nv_wr32(dev, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_CLK_UNK10);
-       nv_wr32(dev, 0x610030, 0x80000000);
+       nv_wr32(device, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_CLK_UNK10);
+       nv_wr32(device, 0x610030, 0x80000000);
 }
 
 static void
 nv50_display_unk20_handler(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
+       struct nouveau_device *device = nouveau_dev(dev);
+       struct nouveau_drm *drm = nouveau_drm(dev);
        struct nv50_display *disp = nv50_display(dev);
-       u32 unk30 = nv_rd32(dev, 0x610030), tmp, pclk, script, mc = 0;
-       struct dcb_entry *dcb;
-       int i, crtc, or = 0, type = OUTPUT_ANY;
+       u32 unk30 = nv_rd32(device, 0x610030), tmp, pclk, script, mc = 0;
+       struct dcb_output *dcb;
+       int i, crtc, or = 0, type = DCB_OUTPUT_ANY;
 
-       NV_DEBUG_KMS(dev, "0x610030: 0x%08x\n", unk30);
+       NV_DEBUG(drm, "0x610030: 0x%08x\n", unk30);
        dcb = disp->irq.dcb;
        if (dcb) {
                nouveau_bios_run_display_table(dev, 0, -2, dcb, -1);
@@ -795,86 +703,86 @@ nv50_display_unk20_handler(struct drm_device *dev)
        /* CRTC clock change requested? */
        crtc = ffs((unk30 & 0x00000600) >> 9) - 1;
        if (crtc >= 0) {
-               pclk  = nv_rd32(dev, NV50_PDISPLAY_CRTC_P(crtc, CLOCK));
+               pclk  = nv_rd32(device, NV50_PDISPLAY_CRTC_P(crtc, CLOCK));
                pclk &= 0x003fffff;
                if (pclk)
                        nv50_crtc_set_clock(dev, crtc, pclk);
 
-               tmp = nv_rd32(dev, NV50_PDISPLAY_CRTC_CLK_CTRL2(crtc));
+               tmp = nv_rd32(device, NV50_PDISPLAY_CRTC_CLK_CTRL2(crtc));
                tmp &= ~0x000000f;
-               nv_wr32(dev, NV50_PDISPLAY_CRTC_CLK_CTRL2(crtc), tmp);
+               nv_wr32(device, NV50_PDISPLAY_CRTC_CLK_CTRL2(crtc), tmp);
        }
 
        /* Nothing needs to be done for the encoder */
        crtc = ffs((unk30 & 0x00000180) >> 7) - 1;
        if (crtc < 0)
                goto ack;
-       pclk  = nv_rd32(dev, NV50_PDISPLAY_CRTC_P(crtc, CLOCK)) & 0x003fffff;
+       pclk  = nv_rd32(device, NV50_PDISPLAY_CRTC_P(crtc, CLOCK)) & 0x003fffff;
 
        /* Find which encoder is connected to the CRTC */
-       for (i = 0; type == OUTPUT_ANY && i < 3; i++) {
-               mc = nv_rd32(dev, NV50_PDISPLAY_DAC_MODE_CTRL_P(i));
-               NV_DEBUG_KMS(dev, "DAC-%d mc: 0x%08x\n", i, mc);
+       for (i = 0; type == DCB_OUTPUT_ANY && i < 3; i++) {
+               mc = nv_rd32(device, NV50_PDISPLAY_DAC_MODE_CTRL_P(i));
+               NV_DEBUG(drm, "DAC-%d mc: 0x%08x\n", i, mc);
                if (!(mc & (1 << crtc)))
                        continue;
 
                switch ((mc & 0x00000f00) >> 8) {
-               case 0: type = OUTPUT_ANALOG; break;
-               case 1: type = OUTPUT_TV; break;
+               case 0: type = DCB_OUTPUT_ANALOG; break;
+               case 1: type = DCB_OUTPUT_TV; break;
                default:
-                       NV_ERROR(dev, "invalid mc, DAC-%d: 0x%08x\n", i, mc);
+                       NV_ERROR(drm, "invalid mc, DAC-%d: 0x%08x\n", i, mc);
                        goto ack;
                }
 
                or = i;
        }
 
-       for (i = 0; type == OUTPUT_ANY && i < nv50_sor_nr(dev); i++) {
-               if (dev_priv->chipset  < 0x90 ||
-                   dev_priv->chipset == 0x92 ||
-                   dev_priv->chipset == 0xa0)
-                       mc = nv_rd32(dev, NV50_PDISPLAY_SOR_MODE_CTRL_P(i));
+       for (i = 0; type == DCB_OUTPUT_ANY && i < nv50_sor_nr(dev); i++) {
+               if (nv_device(drm->device)->chipset  < 0x90 ||
+                   nv_device(drm->device)->chipset == 0x92 ||
+                   nv_device(drm->device)->chipset == 0xa0)
+                       mc = nv_rd32(device, NV50_PDISPLAY_SOR_MODE_CTRL_P(i));
                else
-                       mc = nv_rd32(dev, NV90_PDISPLAY_SOR_MODE_CTRL_P(i));
+                       mc = nv_rd32(device, NV90_PDISPLAY_SOR_MODE_CTRL_P(i));
 
-               NV_DEBUG_KMS(dev, "SOR-%d mc: 0x%08x\n", i, mc);
+               NV_DEBUG(drm, "SOR-%d mc: 0x%08x\n", i, mc);
                if (!(mc & (1 << crtc)))
                        continue;
 
                switch ((mc & 0x00000f00) >> 8) {
-               case 0: type = OUTPUT_LVDS; break;
-               case 1: type = OUTPUT_TMDS; break;
-               case 2: type = OUTPUT_TMDS; break;
-               case 5: type = OUTPUT_TMDS; break;
-               case 8: type = OUTPUT_DP; break;
-               case 9: type = OUTPUT_DP; break;
+               case 0: type = DCB_OUTPUT_LVDS; break;
+               case 1: type = DCB_OUTPUT_TMDS; break;
+               case 2: type = DCB_OUTPUT_TMDS; break;
+               case 5: type = DCB_OUTPUT_TMDS; break;
+               case 8: type = DCB_OUTPUT_DP; break;
+               case 9: type = DCB_OUTPUT_DP; break;
                default:
-                       NV_ERROR(dev, "invalid mc, SOR-%d: 0x%08x\n", i, mc);
+                       NV_ERROR(drm, "invalid mc, SOR-%d: 0x%08x\n", i, mc);
                        goto ack;
                }
 
                or = i;
        }
 
-       if (type == OUTPUT_ANY)
+       if (type == DCB_OUTPUT_ANY)
                goto ack;
 
        /* Enable the encoder */
-       for (i = 0; i < dev_priv->vbios.dcb.entries; i++) {
-               dcb = &dev_priv->vbios.dcb.entry[i];
+       for (i = 0; i < drm->vbios.dcb.entries; i++) {
+               dcb = &drm->vbios.dcb.entry[i];
                if (dcb->type == type && (dcb->or & (1 << or)))
                        break;
        }
 
-       if (i == dev_priv->vbios.dcb.entries) {
-               NV_ERROR(dev, "no dcb for %d %d 0x%08x\n", or, type, mc);
+       if (i == drm->vbios.dcb.entries) {
+               NV_ERROR(drm, "no dcb for %d %d 0x%08x\n", or, type, mc);
                goto ack;
        }
 
        script = nv50_display_script_select(dev, dcb, mc, pclk);
        nouveau_bios_run_display_table(dev, script, pclk, dcb, -1);
 
-       if (type == OUTPUT_DP) {
+       if (type == DCB_OUTPUT_DP) {
                int link = !(dcb->dpconf.sor.link & 1);
                if ((mc & 0x000f0000) == 0x00020000)
                        nv50_sor_dp_calc_tu(dev, or, link, pclk, 18);
@@ -882,14 +790,14 @@ nv50_display_unk20_handler(struct drm_device *dev)
                        nv50_sor_dp_calc_tu(dev, or, link, pclk, 24);
        }
 
-       if (dcb->type != OUTPUT_ANALOG) {
-               tmp = nv_rd32(dev, NV50_PDISPLAY_SOR_CLK_CTRL2(or));
+       if (dcb->type != DCB_OUTPUT_ANALOG) {
+               tmp = nv_rd32(device, NV50_PDISPLAY_SOR_CLK_CTRL2(or));
                tmp &= ~0x00000f0f;
                if (script & 0x0100)
                        tmp |= 0x00000101;
-               nv_wr32(dev, NV50_PDISPLAY_SOR_CLK_CTRL2(or), tmp);
+               nv_wr32(device, NV50_PDISPLAY_SOR_CLK_CTRL2(or), tmp);
        } else {
-               nv_wr32(dev, NV50_PDISPLAY_DAC_CLK_CTRL2(or), 0);
+               nv_wr32(device, NV50_PDISPLAY_DAC_CLK_CTRL2(or), 0);
        }
 
        disp->irq.dcb = dcb;
@@ -897,8 +805,8 @@ nv50_display_unk20_handler(struct drm_device *dev)
        disp->irq.script = script;
 
 ack:
-       nv_wr32(dev, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_CLK_UNK20);
-       nv_wr32(dev, 0x610030, 0x80000000);
+       nv_wr32(device, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_CLK_UNK20);
+       nv_wr32(device, 0x610030, 0x80000000);
 }
 
 /* If programming a TMDS output on a SOR that can also be configured for
@@ -910,23 +818,24 @@ ack:
  * programmed for DisplayPort.
  */
 static void
-nv50_display_unk40_dp_set_tmds(struct drm_device *dev, struct dcb_entry *dcb)
+nv50_display_unk40_dp_set_tmds(struct drm_device *dev, struct dcb_output *dcb)
 {
+       struct nouveau_device *device = nouveau_dev(dev);
        int or = ffs(dcb->or) - 1, link = !(dcb->dpconf.sor.link & 1);
        struct drm_encoder *encoder;
        u32 tmp;
 
-       if (dcb->type != OUTPUT_TMDS)
+       if (dcb->type != DCB_OUTPUT_TMDS)
                return;
 
        list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
                struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
 
-               if (nv_encoder->dcb->type == OUTPUT_DP &&
+               if (nv_encoder->dcb->type == DCB_OUTPUT_DP &&
                    nv_encoder->dcb->or & (1 << or)) {
-                       tmp  = nv_rd32(dev, NV50_SOR_DP_CTRL(or, link));
+                       tmp  = nv_rd32(device, NV50_SOR_DP_CTRL(or, link));
                        tmp &= ~NV50_SOR_DP_CTRL_ENABLED;
-                       nv_wr32(dev, NV50_SOR_DP_CTRL(or, link), tmp);
+                       nv_wr32(device, NV50_SOR_DP_CTRL(or, link), tmp);
                        break;
                }
        }
@@ -935,12 +844,14 @@ nv50_display_unk40_dp_set_tmds(struct drm_device *dev, struct dcb_entry *dcb)
 static void
 nv50_display_unk40_handler(struct drm_device *dev)
 {
+       struct nouveau_device *device = nouveau_dev(dev);
+       struct nouveau_drm *drm = nouveau_drm(dev);
        struct nv50_display *disp = nv50_display(dev);
-       struct dcb_entry *dcb = disp->irq.dcb;
+       struct dcb_output *dcb = disp->irq.dcb;
        u16 script = disp->irq.script;
-       u32 unk30 = nv_rd32(dev, 0x610030), pclk = disp->irq.pclk;
+       u32 unk30 = nv_rd32(device, 0x610030), pclk = disp->irq.pclk;
 
-       NV_DEBUG_KMS(dev, "0x610030: 0x%08x\n", unk30);
+       NV_DEBUG(drm, "0x610030: 0x%08x\n", unk30);
        disp->irq.dcb = NULL;
        if (!dcb)
                goto ack;
@@ -949,21 +860,23 @@ nv50_display_unk40_handler(struct drm_device *dev)
        nv50_display_unk40_dp_set_tmds(dev, dcb);
 
 ack:
-       nv_wr32(dev, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_CLK_UNK40);
-       nv_wr32(dev, 0x610030, 0x80000000);
-       nv_wr32(dev, 0x619494, nv_rd32(dev, 0x619494) | 8);
+       nv_wr32(device, NV50_PDISPLAY_INTR_1, NV50_PDISPLAY_INTR_1_CLK_UNK40);
+       nv_wr32(device, 0x610030, 0x80000000);
+       nv_wr32(device, 0x619494, nv_rd32(device, 0x619494) | 8);
 }
 
 static void
 nv50_display_bh(unsigned long data)
 {
        struct drm_device *dev = (struct drm_device *)data;
+       struct nouveau_device *device = nouveau_dev(dev);
+       struct nouveau_drm *drm = nouveau_drm(dev);
 
        for (;;) {
-               uint32_t intr0 = nv_rd32(dev, NV50_PDISPLAY_INTR_0);
-               uint32_t intr1 = nv_rd32(dev, NV50_PDISPLAY_INTR_1);
+               uint32_t intr0 = nv_rd32(device, NV50_PDISPLAY_INTR_0);
+               uint32_t intr1 = nv_rd32(device, NV50_PDISPLAY_INTR_1);
 
-               NV_DEBUG_KMS(dev, "PDISPLAY_INTR_BH 0x%08x 0x%08x\n", intr0, intr1);
+               NV_DEBUG(drm, "PDISPLAY_INTR_BH 0x%08x 0x%08x\n", intr0, intr1);
 
                if (intr1 & NV50_PDISPLAY_INTR_1_CLK_UNK10)
                        nv50_display_unk10_handler(dev);
@@ -977,13 +890,15 @@ nv50_display_bh(unsigned long data)
                        break;
        }
 
-       nv_wr32(dev, NV03_PMC_INTR_EN_0, 1);
+       nv_wr32(device, NV03_PMC_INTR_EN_0, 1);
 }
 
 static void
 nv50_display_error_handler(struct drm_device *dev)
 {
-       u32 channels = (nv_rd32(dev, NV50_PDISPLAY_INTR_0) & 0x001f0000) >> 16;
+       struct nouveau_device *device = nouveau_dev(dev);
+       struct nouveau_drm *drm = nouveau_drm(dev);
+       u32 channels = (nv_rd32(device, NV50_PDISPLAY_INTR_0) & 0x001f0000) >> 16;
        u32 addr, data;
        int chid;
 
@@ -991,29 +906,31 @@ nv50_display_error_handler(struct drm_device *dev)
                if (!(channels & (1 << chid)))
                        continue;
 
-               nv_wr32(dev, NV50_PDISPLAY_INTR_0, 0x00010000 << chid);
-               addr = nv_rd32(dev, NV50_PDISPLAY_TRAPPED_ADDR(chid));
-               data = nv_rd32(dev, NV50_PDISPLAY_TRAPPED_DATA(chid));
-               NV_ERROR(dev, "EvoCh %d Mthd 0x%04x Data 0x%08x "
+               nv_wr32(device, NV50_PDISPLAY_INTR_0, 0x00010000 << chid);
+               addr = nv_rd32(device, NV50_PDISPLAY_TRAPPED_ADDR(chid));
+               data = nv_rd32(device, NV50_PDISPLAY_TRAPPED_DATA(chid));
+               NV_ERROR(drm, "EvoCh %d Mthd 0x%04x Data 0x%08x "
                              "(0x%04x 0x%02x)\n", chid,
                         addr & 0xffc, data, addr >> 16, (addr >> 12) & 0xf);
 
-               nv_wr32(dev, NV50_PDISPLAY_TRAPPED_ADDR(chid), 0x90000000);
+               nv_wr32(device, NV50_PDISPLAY_TRAPPED_ADDR(chid), 0x90000000);
        }
 }
 
-static void
-nv50_display_isr(struct drm_device *dev)
+void
+nv50_display_intr(struct drm_device *dev)
 {
+       struct nouveau_device *device = nouveau_dev(dev);
+       struct nouveau_drm *drm = nouveau_drm(dev);
        struct nv50_display *disp = nv50_display(dev);
        uint32_t delayed = 0;
 
-       while (nv_rd32(dev, NV50_PMC_INTR_0) & NV50_PMC_INTR_0_DISPLAY) {
-               uint32_t intr0 = nv_rd32(dev, NV50_PDISPLAY_INTR_0);
-               uint32_t intr1 = nv_rd32(dev, NV50_PDISPLAY_INTR_1);
+       while (nv_rd32(device, NV50_PMC_INTR_0) & NV50_PMC_INTR_0_DISPLAY) {
+               uint32_t intr0 = nv_rd32(device, NV50_PDISPLAY_INTR_0);
+               uint32_t intr1 = nv_rd32(device, NV50_PDISPLAY_INTR_1);
                uint32_t clock;
 
-               NV_DEBUG_KMS(dev, "PDISPLAY_INTR 0x%08x 0x%08x\n", intr0, intr1);
+               NV_DEBUG(drm, "PDISPLAY_INTR 0x%08x 0x%08x\n", intr0, intr1);
 
                if (!intr0 && !(intr1 & ~delayed))
                        break;
@@ -1024,29 +941,29 @@ nv50_display_isr(struct drm_device *dev)
                }
 
                if (intr1 & NV50_PDISPLAY_INTR_1_VBLANK_CRTC) {
-                       nv50_display_vblank_handler(dev, intr1);
                        intr1 &= ~NV50_PDISPLAY_INTR_1_VBLANK_CRTC;
+                       delayed |= NV50_PDISPLAY_INTR_1_VBLANK_CRTC;
                }
 
                clock = (intr1 & (NV50_PDISPLAY_INTR_1_CLK_UNK10 |
                                  NV50_PDISPLAY_INTR_1_CLK_UNK20 |
                                  NV50_PDISPLAY_INTR_1_CLK_UNK40));
                if (clock) {
-                       nv_wr32(dev, NV03_PMC_INTR_EN_0, 0);
+                       nv_wr32(device, NV03_PMC_INTR_EN_0, 0);
                        tasklet_schedule(&disp->tasklet);
                        delayed |= clock;
                        intr1 &= ~clock;
                }
 
                if (intr0) {
-                       NV_ERROR(dev, "unknown PDISPLAY_INTR_0: 0x%08x\n", intr0);
-                       nv_wr32(dev, NV50_PDISPLAY_INTR_0, intr0);
+                       NV_ERROR(drm, "unknown PDISPLAY_INTR_0: 0x%08x\n", intr0);
+                       nv_wr32(device, NV50_PDISPLAY_INTR_0, intr0);
                }
 
                if (intr1) {
-                       NV_ERROR(dev,
+                       NV_ERROR(drm,
                                 "unknown PDISPLAY_INTR_1: 0x%08x\n", intr1);
-                       nv_wr32(dev, NV50_PDISPLAY_INTR_1, intr1);
+                       nv_wr32(device, NV50_PDISPLAY_INTR_1, intr1);
                }
        }
 }