Merge branch 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzi...
[pandora-kernel.git] / drivers / ata / sata_mv.c
index b52c051..4b6b209 100644 (file)
@@ -1190,7 +1190,7 @@ static void mv_wait_for_edma_empty_idle(struct ata_port *ap)
                        break;
                udelay(per_loop);
        }
-       /* ata_port_printk(ap, KERN_INFO, "%s: %u+ usecs\n", __func__, i); */
+       /* ata_port_info(ap, "%s: %u+ usecs\n", __func__, i); */
 }
 
 /**
@@ -1228,7 +1228,7 @@ static int mv_stop_edma(struct ata_port *ap)
        pp->pp_flags &= ~MV_PP_FLAG_EDMA_EN;
        mv_wait_for_edma_empty_idle(ap);
        if (mv_stop_edma_engine(port_mmio)) {
-               ata_port_printk(ap, KERN_ERR, "Unable to stop eDMA\n");
+               ata_port_err(ap, "Unable to stop eDMA\n");
                err = -EIO;
        }
        mv_edma_cfg(ap, 0, 0);
@@ -1382,7 +1382,7 @@ static void mv6_dev_config(struct ata_device *adev)
        if (adev->flags & ATA_DFLAG_NCQ) {
                if (sata_pmp_attached(adev->link->ap)) {
                        adev->flags &= ~ATA_DFLAG_NCQ;
-                       ata_dev_printk(adev, KERN_INFO,
+                       ata_dev_info(adev,
                                "NCQ disabled for command-based switching\n");
                }
        }
@@ -2225,9 +2225,8 @@ static unsigned int mv_send_fis(struct ata_port *ap, u32 *fis, int nwords)
 
        /* See if it worked */
        if ((ifstat & 0x3000) != 0x1000) {
-               ata_port_printk(ap, KERN_WARNING,
-                               "%s transmission error, ifstat=%08x\n",
-                               __func__, ifstat);
+               ata_port_warn(ap, "%s transmission error, ifstat=%08x\n",
+                             __func__, ifstat);
                return AC_ERR_OTHER;
        }
        return 0;
@@ -2342,9 +2341,9 @@ static unsigned int mv_qc_issue(struct ata_queued_cmd *qc)
                 */
                if (limit_warnings > 0 && (qc->nbytes / qc->sect_size) > 1) {
                        --limit_warnings;
-                       ata_link_printk(qc->dev->link, KERN_WARNING, DRV_NAME
-                                       ": attempting PIO w/multiple DRQ: "
-                                       "this may fail due to h/w errata\n");
+                       ata_link_warn(qc->dev->link, DRV_NAME
+                                     ": attempting PIO w/multiple DRQ: "
+                                     "this may fail due to h/w errata\n");
                }
                /* drop through */
        case ATA_PROT_NODATA:
@@ -2499,20 +2498,20 @@ static int mv_handle_fbs_ncq_dev_err(struct ata_port *ap)
        }
        failed_links = hweight16(new_map);
 
-       ata_port_printk(ap, KERN_INFO, "%s: pmp_map=%04x qc_map=%04x "
-                       "failed_links=%d nr_active_links=%d\n",
-                       __func__, pp->delayed_eh_pmp_map,
-                       ap->qc_active, failed_links,
-                       ap->nr_active_links);
+       ata_port_info(ap,
+                     "%s: pmp_map=%04x qc_map=%04x failed_links=%d nr_active_links=%d\n",
+                     __func__, pp->delayed_eh_pmp_map,
+                     ap->qc_active, failed_links,
+                     ap->nr_active_links);
 
        if (ap->nr_active_links <= failed_links && mv_req_q_empty(ap)) {
                mv_process_crpb_entries(ap, pp);
                mv_stop_edma(ap);
                mv_eh_freeze(ap);
-               ata_port_printk(ap, KERN_INFO, "%s: done\n", __func__);
+               ata_port_info(ap, "%s: done\n", __func__);
                return 1;       /* handled */
        }
-       ata_port_printk(ap, KERN_INFO, "%s: waiting\n", __func__);
+       ata_port_info(ap, "%s: waiting\n", __func__);
        return 1;       /* handled */
 }
 
@@ -2554,9 +2553,8 @@ static int mv_handle_dev_err(struct ata_port *ap, u32 edma_err_cause)
                 * and we cannot handle it here.
                 */
                if (edma_err_cause & EDMA_ERR_SELF_DIS) {
-                       ata_port_printk(ap, KERN_WARNING,
-                               "%s: err_cause=0x%x pp_flags=0x%x\n",
-                               __func__, edma_err_cause, pp->pp_flags);
+                       ata_port_warn(ap, "%s: err_cause=0x%x pp_flags=0x%x\n",
+                                     __func__, edma_err_cause, pp->pp_flags);
                        return 0; /* not handled */
                }
                return mv_handle_fbs_ncq_dev_err(ap);
@@ -2567,9 +2565,8 @@ static int mv_handle_dev_err(struct ata_port *ap, u32 edma_err_cause)
                 * and we cannot handle it here.
                 */
                if (!(edma_err_cause & EDMA_ERR_SELF_DIS)) {
-                       ata_port_printk(ap, KERN_WARNING,
-                               "%s: err_cause=0x%x pp_flags=0x%x\n",
-                               __func__, edma_err_cause, pp->pp_flags);
+                       ata_port_warn(ap, "%s: err_cause=0x%x pp_flags=0x%x\n",
+                                     __func__, edma_err_cause, pp->pp_flags);
                        return 0; /* not handled */
                }
                return mv_handle_fbs_non_ncq_dev_err(ap);
@@ -2930,8 +2927,7 @@ static int mv_pci_error(struct ata_host *host, void __iomem *mmio)
 
        err_cause = readl(mmio + hpriv->irq_cause_offset);
 
-       dev_printk(KERN_ERR, host->dev, "PCI ERROR; PCI IRQ cause=0x%08x\n",
-                  err_cause);
+       dev_err(host->dev, "PCI ERROR; PCI IRQ cause=0x%08x\n", err_cause);
 
        DPRINTK("All regs @ PCI error\n");
        mv_dump_all_regs(mmio, -1, to_pci_dev(host->dev));
@@ -3760,8 +3756,8 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx)
                        hp_flags |= MV_HP_ERRATA_50XXB2;
                        break;
                default:
-                       dev_printk(KERN_WARNING, &pdev->dev,
-                          "Applying 50XXB2 workarounds to unknown rev\n");
+                       dev_warn(&pdev->dev,
+                                "Applying 50XXB2 workarounds to unknown rev\n");
                        hp_flags |= MV_HP_ERRATA_50XXB2;
                        break;
                }
@@ -3780,8 +3776,8 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx)
                        hp_flags |= MV_HP_ERRATA_50XXB2;
                        break;
                default:
-                       dev_printk(KERN_WARNING, &pdev->dev,
-                          "Applying B2 workarounds to unknown rev\n");
+                       dev_warn(&pdev->dev,
+                                "Applying B2 workarounds to unknown rev\n");
                        hp_flags |= MV_HP_ERRATA_50XXB2;
                        break;
                }
@@ -3801,8 +3797,8 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx)
                        hp_flags |= MV_HP_ERRATA_60X1C0;
                        break;
                default:
-                       dev_printk(KERN_WARNING, &pdev->dev,
-                                  "Applying B2 workarounds to unknown rev\n");
+                       dev_warn(&pdev->dev,
+                                "Applying B2 workarounds to unknown rev\n");
                        hp_flags |= MV_HP_ERRATA_60X1B2;
                        break;
                }
@@ -3851,8 +3847,8 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx)
                        hp_flags |= MV_HP_ERRATA_60X1C0;
                        break;
                default:
-                       dev_printk(KERN_WARNING, &pdev->dev,
-                          "Applying 60X1C0 workarounds to unknown rev\n");
+                       dev_warn(&pdev->dev,
+                                "Applying 60X1C0 workarounds to unknown rev\n");
                        hp_flags |= MV_HP_ERRATA_60X1C0;
                        break;
                }
@@ -3867,8 +3863,7 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx)
                break;
 
        default:
-               dev_printk(KERN_ERR, host->dev,
-                          "BUG: invalid board index %u\n", board_idx);
+               dev_err(host->dev, "BUG: invalid board index %u\n", board_idx);
                return 1;
        }
 
@@ -4023,7 +4018,6 @@ static void mv_conf_mbus_windows(struct mv_host_priv *hpriv,
  */
 static int mv_platform_probe(struct platform_device *pdev)
 {
-       static int printed_version;
        const struct mv_sata_platform_data *mv_platform_data;
        const struct ata_port_info *ppi[] =
            { &mv_port_info[chip_soc], NULL };
@@ -4032,8 +4026,7 @@ static int mv_platform_probe(struct platform_device *pdev)
        struct resource *res;
        int n_ports, rc;
 
-       if (!printed_version++)
-               dev_printk(KERN_INFO, &pdev->dev, "version " DRV_VERSION "\n");
+       ata_print_version_once(&pdev->dev, DRV_VERSION);
 
        /*
         * Simple resource validation ..
@@ -4091,9 +4084,8 @@ static int mv_platform_probe(struct platform_device *pdev)
        if (rc)
                goto err;
 
-       dev_printk(KERN_INFO, &pdev->dev,
-                  "slots %u ports %d\n", (unsigned)MV_MAX_Q_DEPTH,
-                  host->n_ports);
+       dev_info(&pdev->dev, "slots %u ports %d\n",
+                (unsigned)MV_MAX_Q_DEPTH, host->n_ports);
 
        return ata_host_activate(host, platform_get_irq(pdev, 0), mv_interrupt,
                                 IRQF_SHARED, &mv6_sht);
@@ -4217,22 +4209,21 @@ static int pci_go_64(struct pci_dev *pdev)
                if (rc) {
                        rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
                        if (rc) {
-                               dev_printk(KERN_ERR, &pdev->dev,
-                                          "64-bit DMA enable failed\n");
+                               dev_err(&pdev->dev,
+                                       "64-bit DMA enable failed\n");
                                return rc;
                        }
                }
        } else {
                rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
                if (rc) {
-                       dev_printk(KERN_ERR, &pdev->dev,
-                                  "32-bit DMA enable failed\n");
+                       dev_err(&pdev->dev, "32-bit DMA enable failed\n");
                        return rc;
                }
                rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
                if (rc) {
-                       dev_printk(KERN_ERR, &pdev->dev,
-                                  "32-bit consistent DMA enable failed\n");
+                       dev_err(&pdev->dev,
+                               "32-bit consistent DMA enable failed\n");
                        return rc;
                }
        }
@@ -4276,10 +4267,9 @@ static void mv_print_info(struct ata_host *host)
        else
                gen = "?";
 
-       dev_printk(KERN_INFO, &pdev->dev,
-              "Gen-%s %u slots %u ports %s mode IRQ via %s\n",
-              gen, (unsigned)MV_MAX_Q_DEPTH, host->n_ports,
-              scc_s, (MV_HP_FLAG_MSI & hpriv->hp_flags) ? "MSI" : "INTx");
+       dev_info(&pdev->dev, "Gen-%s %u slots %u ports %s mode IRQ via %s\n",
+                gen, (unsigned)MV_MAX_Q_DEPTH, host->n_ports,
+                scc_s, (MV_HP_FLAG_MSI & hpriv->hp_flags) ? "MSI" : "INTx");
 }
 
 /**
@@ -4293,15 +4283,13 @@ static void mv_print_info(struct ata_host *host)
 static int mv_pci_init_one(struct pci_dev *pdev,
                           const struct pci_device_id *ent)
 {
-       static int printed_version;
        unsigned int board_idx = (unsigned int)ent->driver_data;
        const struct ata_port_info *ppi[] = { &mv_port_info[board_idx], NULL };
        struct ata_host *host;
        struct mv_host_priv *hpriv;
        int n_ports, port, rc;
 
-       if (!printed_version++)
-               dev_printk(KERN_INFO, &pdev->dev, "version " DRV_VERSION "\n");
+       ata_print_version_once(&pdev->dev, DRV_VERSION);
 
        /* allocate host */
        n_ports = mv_get_hc_count(ppi[0]->flags) * MV_PORTS_PER_HC;