libata: reimplement ata_acpi_cbl_80wire() using ata_acpi_gtm_xfermask()

[pandora-kernel.git] / drivers / ata / libata-acpi.c

diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 9f0b208..9e8ec19 100644 (file)
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -441,22 +441,6 @@ static int ata_dev_get_GTF(struct ata_device *dev, struct ata_acpi_gtf **gtf)
        return rc;
 }
 
-/* Welcome to ACPI, bring a bucket */
-const unsigned int ata_acpi_pio_cycle[7] = {
-       600, 383, 240, 180, 120, 100, 80
-};
-EXPORT_SYMBOL_GPL(ata_acpi_pio_cycle);
-
-const unsigned int ata_acpi_mwdma_cycle[5] = {
-       480, 150, 120, 100, 80
-};
-EXPORT_SYMBOL_GPL(ata_acpi_mwdma_cycle);
-
-const unsigned int ata_acpi_udma_cycle[7] = {
-       120, 80, 60, 45, 30, 20, 15
-};
-EXPORT_SYMBOL_GPL(ata_acpi_udma_cycle);
-
 /**
  * ata_acpi_gtm_xfermode - determine xfermode from GTM parameter
  * @dev: target device
@@ -473,87 +457,62 @@ EXPORT_SYMBOL_GPL(ata_acpi_udma_cycle);
 unsigned long ata_acpi_gtm_xfermask(struct ata_device *dev,
                                    const struct ata_acpi_gtm *gtm)
 {
-       unsigned long pio_mask = 0, mwdma_mask = 0, udma_mask = 0;
-       int unit, i;
-       u32 t;
+       unsigned long xfer_mask = 0;
+       unsigned int type;
+       int unit;
+       u8 mode;
 
        /* we always use the 0 slot for crap hardware */
        unit = dev->devno;
        if (!(gtm->flags & 0x10))
                unit = 0;
 
-       /* Values larger than the longest cycle results in 0 mask
-        * while values equal to smaller than the shortest cycle
-        * results in mask which includes all supported modes.
-        * Disabled transfer method has the value of 0xffffffff which
-        * will always result in 0 mask.
-        */
-
-       /* start by scanning for PIO modes */
-       t = gtm->drive[unit].pio;
-       for (i = 0; i < ARRAY_SIZE(ata_acpi_pio_cycle); i++)
-               if (t > ata_acpi_pio_cycle[i])
-                       break;
-       pio_mask = (1 << i) - 1;
+       /* PIO */
+       mode = ata_timing_cycle2mode(ATA_SHIFT_PIO, gtm->drive[unit].pio);
+       xfer_mask |= ata_xfer_mode2mask(mode);
 
        /* See if we have MWDMA or UDMA data. We don't bother with
         * MWDMA if UDMA is available as this means the BIOS set UDMA
         * and our error changedown if it works is UDMA to PIO anyway.
         */
-       t = gtm->drive[unit].dma;
-       if (!(gtm->flags & (1 << (2 * unit)))) {
-               /* MWDMA */
-               for (i = 0; i < ARRAY_SIZE(ata_acpi_mwdma_cycle); i++)
-                       if (t > ata_acpi_mwdma_cycle[i])
-                               break;
-               mwdma_mask = (1 << i) - 1;
-       } else {
-               /* UDMA */
-               for (i = 0; i < ARRAY_SIZE(ata_acpi_udma_cycle); i++)
-                       if (t > ata_acpi_udma_cycle[i])
-                               break;
-               udma_mask = (1 << i) - 1;
-       }
+       if (!(gtm->flags & (1 << (2 * unit))))
+               type = ATA_SHIFT_MWDMA;
+       else
+               type = ATA_SHIFT_UDMA;
+
+       mode = ata_timing_cycle2mode(type, gtm->drive[unit].dma);
+       xfer_mask |= ata_xfer_mode2mask(mode);
 
-       return ata_pack_xfermask(pio_mask, mwdma_mask, udma_mask);
+       return xfer_mask;
 }
 EXPORT_SYMBOL_GPL(ata_acpi_gtm_xfermask);
 
 /**
  * ata_acpi_cbl_80wire         -       Check for 80 wire cable
  * @ap: Port to check
+ * @gtm: GTM data to use
  *
- * Return 1 if the ACPI mode data for this port indicates the BIOS selected
- * an 80wire mode.
+ * Return 1 if the @gtm indicates the BIOS selected an 80wire mode.
  */
-
-int ata_acpi_cbl_80wire(struct ata_port *ap)
+int ata_acpi_cbl_80wire(struct ata_port *ap, const struct ata_acpi_gtm *gtm)
 {
-       const struct ata_acpi_gtm *gtm = ata_acpi_init_gtm(ap);
-       int valid = 0;
+       struct ata_device *dev;
 
-       if (!gtm)
-               return 0;
+       ata_link_for_each_dev(dev, &ap->link) {
+               unsigned long xfer_mask, udma_mask;
+
+               if (!ata_dev_enabled(dev))
+                       continue;
+
+               xfer_mask = ata_acpi_gtm_xfermask(dev, gtm);
+               ata_unpack_xfermask(xfer_mask, NULL, NULL, &udma_mask);
+
+               if (udma_mask & ~ATA_UDMA_MASK_40C)
+                       return 1;
+       }
 
-       /* Split timing, DMA enabled */
-       if ((gtm->flags & 0x11) == 0x11 && gtm->drive[0].dma < 55)
-               valid |= 1;
-       if ((gtm->flags & 0x14) == 0x14 && gtm->drive[1].dma < 55)
-               valid |= 2;
-       /* Shared timing, DMA enabled */
-       if ((gtm->flags & 0x11) == 0x01 && gtm->drive[0].dma < 55)
-               valid |= 1;
-       if ((gtm->flags & 0x14) == 0x04 && gtm->drive[0].dma < 55)
-               valid |= 2;
-
-       /* Drive check */
-       if ((valid & 1) && ata_dev_enabled(&ap->link.device[0]))
-               return 1;
-       if ((valid & 2) && ata_dev_enabled(&ap->link.device[1]))
-               return 1;
        return 0;
 }
-
 EXPORT_SYMBOL_GPL(ata_acpi_cbl_80wire);
 
 static void ata_acpi_gtf_to_tf(struct ata_device *dev,