Merge master.kernel.org:/home/rmk/linux-2.6-serial
[pandora-kernel.git] / drivers / acpi / hotkey.c
index c25b2b9..32c9d88 100644 (file)
@@ -184,7 +184,7 @@ static union acpi_hotkey *get_hotkey_by_event(struct
                                              *hotkey_list, int event);
 
 /* event based config */
-static struct file_operations hotkey_config_fops = {
+static const struct file_operations hotkey_config_fops = {
        .open = hotkey_open_config,
        .read = seq_read,
        .write = hotkey_write_config,
@@ -193,7 +193,7 @@ static struct file_operations hotkey_config_fops = {
 };
 
 /* polling based config */
-static struct file_operations hotkey_poll_config_fops = {
+static const struct file_operations hotkey_poll_config_fops = {
        .open = hotkey_poll_open_config,
        .read = seq_read,
        .write = hotkey_write_config,
@@ -202,7 +202,7 @@ static struct file_operations hotkey_poll_config_fops = {
 };
 
 /* hotkey driver info */
-static struct file_operations hotkey_info_fops = {
+static const struct file_operations hotkey_info_fops = {
        .open = hotkey_info_open_fs,
        .read = seq_read,
        .llseek = seq_lseek,
@@ -210,7 +210,7 @@ static struct file_operations hotkey_info_fops = {
 };
 
 /* action */
-static struct file_operations hotkey_action_fops = {
+static const struct file_operations hotkey_action_fops = {
        .open = hotkey_action_open_fs,
        .read = seq_read,
        .write = hotkey_execute_aml_method,
@@ -219,7 +219,7 @@ static struct file_operations hotkey_action_fops = {
 };
 
 /* polling results */
-static struct file_operations hotkey_polling_fops = {
+static const struct file_operations hotkey_polling_fops = {
        .open = hotkey_polling_open_fs,
        .read = seq_read,
        .llseek = seq_lseek,
@@ -231,11 +231,10 @@ struct list_head hotkey_entries;  /* head of the list of hotkey_list */
 
 static int hotkey_info_seq_show(struct seq_file *seq, void *offset)
 {
-       ACPI_FUNCTION_TRACE("hotkey_info_seq_show");
 
        seq_printf(seq, "Hotkey generic driver ver: %s\n", HOTKEY_ACPI_VERSION);
 
-       return_VALUE(0);
+       return 0;
 }
 
 static int hotkey_info_open_fs(struct inode *inode, struct file *file)
@@ -266,7 +265,6 @@ static int hotkey_polling_seq_show(struct seq_file *seq, void *offset)
            (struct acpi_polling_hotkey *)seq->private;
        char *buf;
 
-       ACPI_FUNCTION_TRACE("hotkey_polling_seq_show");
 
        if (poll_hotkey->poll_result) {
                buf = format_result(poll_hotkey->poll_result);
@@ -274,7 +272,7 @@ static int hotkey_polling_seq_show(struct seq_file *seq, void *offset)
                        seq_printf(seq, "%s", buf);
                kfree(buf);
        }
-       return_VALUE(0);
+       return 0;
 }
 
 static int hotkey_polling_open_fs(struct inode *inode, struct file *file)
@@ -293,7 +291,6 @@ static int hotkey_get_internal_event(int event, struct acpi_hotkey_list *list)
        struct list_head *entries;
        int val = -1;
 
-       ACPI_FUNCTION_TRACE("hotkey_get_internal_event");
 
        list_for_each(entries, list->entries) {
                union acpi_hotkey *key =
@@ -305,7 +302,7 @@ static int hotkey_get_internal_event(int event, struct acpi_hotkey_list *list)
                }
        }
 
-       return_VALUE(val);
+       return val;
 }
 
 static void
@@ -314,15 +311,14 @@ acpi_hotkey_notify_handler(acpi_handle handle, u32 event, void *data)
        struct acpi_device *device = NULL;
        u32 internal_event;
 
-       ACPI_FUNCTION_TRACE("acpi_hotkey_notify_handler");
 
        if (acpi_bus_get_device(handle, &device))
-               return_VOID;
+               return;
 
        internal_event = hotkey_get_internal_event(event, &global_hotkey_list);
        acpi_bus_generate_event(device, internal_event, 0);
 
-       return_VOID;
+       return;
 }
 
 /* Need to invent automatically hotkey add method */
@@ -346,7 +342,6 @@ static int create_polling_proc(union acpi_hotkey *device)
        char proc_name[80];
        mode_t mode;
 
-       ACPI_FUNCTION_TRACE("create_polling_proc");
        mode = S_IFREG | S_IRUGO | S_IWUGO;
 
        sprintf(proc_name, "%d", device->link.hotkey_standard_num);
@@ -356,10 +351,7 @@ static int create_polling_proc(union acpi_hotkey *device)
        proc = create_proc_entry(proc_name, mode, hotkey_proc_dir);
 
        if (!proc) {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                 "Hotkey: Unable to create %s entry\n",
-                                 device->poll_hotkey.poll_method));
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        } else {
                proc->proc_fops = &hotkey_polling_fops;
                proc->owner = THIS_MODULE;
@@ -368,7 +360,7 @@ static int create_polling_proc(union acpi_hotkey *device)
                proc->gid = 0;
                device->poll_hotkey.proc = proc;
        }
-       return_VALUE(0);
+       return 0;
 }
 
 static int hotkey_add(union acpi_hotkey *device)
@@ -376,7 +368,6 @@ static int hotkey_add(union acpi_hotkey *device)
        int status = 0;
        struct acpi_device *dev = NULL;
 
-       ACPI_FUNCTION_TRACE("hotkey_add");
 
        if (device->link.hotkey_type == ACPI_HOTKEY_EVENT) {
                acpi_bus_get_device(device->event_hotkey.bus_handle, &dev);
@@ -391,14 +382,13 @@ static int hotkey_add(union acpi_hotkey *device)
 
        list_add_tail(&device->link.entries, global_hotkey_list.entries);
 
-       return_VALUE(status);
+       return status;
 }
 
 static int hotkey_remove(union acpi_hotkey *device)
 {
        struct list_head *entries, *next;
 
-       ACPI_FUNCTION_TRACE("hotkey_remove");
 
        list_for_each_safe(entries, next, global_hotkey_list.entries) {
                union acpi_hotkey *key =
@@ -412,14 +402,13 @@ static int hotkey_remove(union acpi_hotkey *device)
                }
        }
        kfree(device);
-       return_VALUE(0);
+       return 0;
 }
 
 static int hotkey_update(union acpi_hotkey *key)
 {
        struct list_head *entries;
 
-       ACPI_FUNCTION_TRACE("hotkey_update");
 
        list_for_each(entries, global_hotkey_list.entries) {
                union acpi_hotkey *tmp =
@@ -461,19 +450,18 @@ static int hotkey_update(union acpi_hotkey *key)
                                 */
                                kfree(key);
                        }
-                       return_VALUE(0);
+                       return 0;
                        break;
                }
        }
 
-       return_VALUE(-ENODEV);
+       return -ENODEV;
 }
 
 static void free_hotkey_device(union acpi_hotkey *key)
 {
        struct acpi_device *dev;
 
-       ACPI_FUNCTION_TRACE("free_hotkey_device");
 
        if (key->link.hotkey_type == ACPI_HOTKEY_EVENT) {
                acpi_bus_get_device(key->event_hotkey.bus_handle, &dev);
@@ -493,7 +481,7 @@ static void free_hotkey_device(union acpi_hotkey *key)
                free_poll_hotkey_buffer(key);
        }
        kfree(key);
-       return_VOID;
+       return;
 }
 
 static void free_hotkey_buffer(union acpi_hotkey *key)
@@ -514,7 +502,6 @@ init_hotkey_device(union acpi_hotkey *key, char *bus_str, char *action_str,
        acpi_handle tmp_handle;
        acpi_status status = AE_OK;
 
-       ACPI_FUNCTION_TRACE("init_hotkey_device");
 
        if (std_num < 0 || IS_POLL(std_num) || !key)
                goto do_fail;
@@ -541,9 +528,9 @@ init_hotkey_device(union acpi_hotkey *key, char *bus_str, char *action_str,
                                 method, &tmp_handle);
        if (ACPI_FAILURE(status))
                goto do_fail;
-       return_VALUE(AE_OK);
+       return AE_OK;
       do_fail:
-       return_VALUE(-ENODEV);
+       return -ENODEV;
 }
 
 static int
@@ -555,7 +542,6 @@ init_poll_hotkey_device(union acpi_hotkey *key,
        acpi_status status = AE_OK;
        acpi_handle tmp_handle;
 
-       ACPI_FUNCTION_TRACE("init_poll_hotkey_device");
 
        if (std_num < 0 || IS_EVENT(std_num) || !key)
                goto do_fail;
@@ -590,22 +576,20 @@ init_poll_hotkey_device(union acpi_hotkey *key,
            (union acpi_object *)kmalloc(sizeof(union acpi_object), GFP_KERNEL);
        if (!key->poll_hotkey.poll_result)
                goto do_fail;
-       return_VALUE(AE_OK);
+       return AE_OK;
       do_fail:
-       return_VALUE(-ENODEV);
+       return -ENODEV;
 }
 
 static int hotkey_open_config(struct inode *inode, struct file *file)
 {
-       ACPI_FUNCTION_TRACE("hotkey_open_config");
-       return_VALUE(single_open
+       return (single_open
                     (file, hotkey_config_seq_show, PDE(inode)->data));
 }
 
 static int hotkey_poll_open_config(struct inode *inode, struct file *file)
 {
-       ACPI_FUNCTION_TRACE("hotkey_poll_open_config");
-       return_VALUE(single_open
+       return (single_open
                     (file, hotkey_poll_config_seq_show, PDE(inode)->data));
 }
 
@@ -618,7 +602,6 @@ static int hotkey_config_seq_show(struct seq_file *seq, void *offset)
        struct acpi_buffer bus = { ACPI_PATHNAME_MAX, bus_name };
        struct acpi_buffer act = { ACPI_PATHNAME_MAX, action_name };
 
-       ACPI_FUNCTION_TRACE(("hotkey_config_seq_show"));
 
        list_for_each(entries, hotkey_list->entries) {
                union acpi_hotkey *key =
@@ -636,7 +619,7 @@ static int hotkey_config_seq_show(struct seq_file *seq, void *offset)
                }
        }
        seq_puts(seq, "\n");
-       return_VALUE(0);
+       return 0;
 }
 
 static int hotkey_poll_config_seq_show(struct seq_file *seq, void *offset)
@@ -648,7 +631,6 @@ static int hotkey_poll_config_seq_show(struct seq_file *seq, void *offset)
        struct acpi_buffer bus = { ACPI_PATHNAME_MAX, bus_name };
        struct acpi_buffer act = { ACPI_PATHNAME_MAX, action_name };
 
-       ACPI_FUNCTION_TRACE(("hotkey_config_seq_show"));
 
        list_for_each(entries, hotkey_list->entries) {
                union acpi_hotkey *key =
@@ -666,7 +648,7 @@ static int hotkey_poll_config_seq_show(struct seq_file *seq, void *offset)
                }
        }
        seq_puts(seq, "\n");
-       return_VALUE(0);
+       return 0;
 }
 
 static int
@@ -678,7 +660,6 @@ get_parms(char *config_record,
          char **method, int *internal_event_num, int *external_event_num)
 {
        char *tmp, *tmp1, count;
-       ACPI_FUNCTION_TRACE(("get_parms"));
 
        sscanf(config_record, "%d", cmd);
 
@@ -744,9 +725,9 @@ get_parms(char *config_record,
            0)
                goto do_fail;
 
-       return_VALUE(6);
+       return 6;
       do_fail:
-       return_VALUE(-1);
+       return -1;
 }
 
 /*  count is length for one input record */
@@ -763,16 +744,15 @@ static ssize_t hotkey_write_config(struct file *file,
        int ret = 0;
        union acpi_hotkey *key = NULL;
 
-       ACPI_FUNCTION_TRACE(("hotkey_write_config"));
 
        config_record = (char *)kmalloc(count + 1, GFP_KERNEL);
        if (!config_record)
-               return_VALUE(-ENOMEM);
+               return -ENOMEM;
 
        if (copy_from_user(config_record, buffer, count)) {
                kfree(config_record);
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid data \n"));
-               return_VALUE(-EINVAL);
+               printk(KERN_ERR PREFIX "Invalid data\n");
+               return -EINVAL;
        }
        config_record[count] = 0;
 
@@ -792,9 +772,8 @@ static ssize_t hotkey_write_config(struct file *file,
                kfree(bus_method);
                kfree(action_handle);
                kfree(method);
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                 "Invalid data format ret=%d\n", ret));
-               return_VALUE(-EINVAL);
+               printk(KERN_ERR PREFIX "Invalid data format ret=%d\n", ret);
+               return -EINVAL;
        }
 
        key = kmalloc(sizeof(union acpi_hotkey), GFP_KERNEL);
@@ -806,7 +785,7 @@ static ssize_t hotkey_write_config(struct file *file,
                tmp = get_hotkey_by_event(&global_hotkey_list,
                                          internal_event_num);
                if (!tmp)
-                       ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid key"));
+                       printk(KERN_ERR PREFIX "Invalid key\n");
                else
                        memcpy(key, tmp, sizeof(union acpi_hotkey));
                goto cont_cmd;
@@ -828,8 +807,8 @@ static ssize_t hotkey_write_config(struct file *file,
                else
                        free_poll_hotkey_buffer(key);
                kfree(key);
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid hotkey \n"));
-               return_VALUE(-EINVAL);
+               printk(KERN_ERR PREFIX "Invalid hotkey\n");
+               return -EINVAL;
        }
 
       cont_cmd:
@@ -855,15 +834,15 @@ static ssize_t hotkey_write_config(struct file *file,
                goto fail_out;
                break;
        }
-       return_VALUE(count);
+       return count;
       fail_out:
        if (IS_EVENT(internal_event_num))
                free_hotkey_buffer(key);
        else
                free_poll_hotkey_buffer(key);
        kfree(key);
-       ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "invalid key\n"));
-       return_VALUE(-EINVAL);
+       printk(KERN_ERR PREFIX "invalid key\n");
+       return -EINVAL;
 }
 
 /*
@@ -880,7 +859,6 @@ static int write_acpi_int(acpi_handle handle, const char *method, int val,
        union acpi_object in_obj;       /* the only param we use */
        acpi_status status;
 
-       ACPI_FUNCTION_TRACE("write_acpi_int");
        params.count = 1;
        params.pointer = &in_obj;
        in_obj.type = ACPI_TYPE_INTEGER;
@@ -888,7 +866,7 @@ static int write_acpi_int(acpi_handle handle, const char *method, int val,
 
        status = acpi_evaluate_object(handle, (char *)method, &params, output);
 
-       return_VALUE(status == AE_OK);
+       return (status == AE_OK);
 }
 
 static int read_acpi_int(acpi_handle handle, const char *method,
@@ -898,7 +876,6 @@ static int read_acpi_int(acpi_handle handle, const char *method,
        union acpi_object out_obj;
        acpi_status status;
 
-       ACPI_FUNCTION_TRACE("read_acpi_int");
        output.length = sizeof(out_obj);
        output.pointer = &out_obj;
 
@@ -907,8 +884,8 @@ static int read_acpi_int(acpi_handle handle, const char *method,
                val->integer.value = out_obj.integer.value;
                val->type = out_obj.type;
        } else
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "null val pointer"));
-       return_VALUE((status == AE_OK)
+               printk(KERN_ERR PREFIX "null val pointer\n");
+       return ((status == AE_OK)
                     && (out_obj.type == ACPI_TYPE_INTEGER));
 }
 
@@ -945,24 +922,23 @@ static ssize_t hotkey_execute_aml_method(struct file *file,
        int event, method_type, type, value;
        union acpi_hotkey *key;
 
-       ACPI_FUNCTION_TRACE("hotkey_execte_aml_method");
 
        arg = (char *)kmalloc(count + 1, GFP_KERNEL);
        if (!arg)
-               return_VALUE(-ENOMEM);
+               return -ENOMEM;
        arg[count] = 0;
 
        if (copy_from_user(arg, buffer, count)) {
                kfree(arg);
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid argument 2"));
-               return_VALUE(-EINVAL);
+               printk(KERN_ERR PREFIX "Invalid argument 2\n");
+               return -EINVAL;
        }
 
        if (sscanf(arg, "%d:%d:%d:%d", &event, &method_type, &type, &value) !=
            4) {
                kfree(arg);
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid argument 3"));
-               return_VALUE(-EINVAL);
+               printk(KERN_ERR PREFIX "Invalid argument 3\n");
+               return -EINVAL;
        }
        kfree(arg);
        if (type == ACPI_TYPE_INTEGER) {
@@ -987,12 +963,12 @@ static ssize_t hotkey_execute_aml_method(struct file *file,
 
                }
        } else {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Not supported"));
-               return_VALUE(-EINVAL);
+               printk(KERN_WARNING "Not supported\n");
+               return -EINVAL;
        }
-       return_VALUE(count);
+       return count;
       do_fail:
-       return_VALUE(-EINVAL);
+       return -EINVAL;
 
 }
 
@@ -1001,7 +977,6 @@ static int __init hotkey_init(void)
        int result;
        mode_t mode = S_IFREG | S_IRUGO | S_IWUGO;
 
-       ACPI_FUNCTION_TRACE("hotkey_init");
 
        if (acpi_disabled)
                return -ENODEV;
@@ -1013,9 +988,6 @@ static int __init hotkey_init(void)
 
        hotkey_proc_dir = proc_mkdir(HOTKEY_PROC, acpi_root_dir);
        if (!hotkey_proc_dir) {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                 "Hotkey: Unable to create %s entry\n",
-                                 HOTKEY_PROC));
                return (-ENODEV);
        }
        hotkey_proc_dir->owner = THIS_MODULE;
@@ -1023,9 +995,6 @@ static int __init hotkey_init(void)
        hotkey_config =
            create_proc_entry(HOTKEY_EV_CONFIG, mode, hotkey_proc_dir);
        if (!hotkey_config) {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                 "Hotkey: Unable to create %s entry\n",
-                                 HOTKEY_EV_CONFIG));
                goto do_fail1;
        } else {
                hotkey_config->proc_fops = &hotkey_config_fops;
@@ -1038,10 +1007,6 @@ static int __init hotkey_init(void)
        hotkey_poll_config =
            create_proc_entry(HOTKEY_PL_CONFIG, mode, hotkey_proc_dir);
        if (!hotkey_poll_config) {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                 "Hotkey: Unable to create %s entry\n",
-                                 HOTKEY_EV_CONFIG));
-
                goto do_fail2;
        } else {
                hotkey_poll_config->proc_fops = &hotkey_poll_config_fops;
@@ -1053,9 +1018,6 @@ static int __init hotkey_init(void)
 
        hotkey_action = create_proc_entry(HOTKEY_ACTION, mode, hotkey_proc_dir);
        if (!hotkey_action) {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                 "Hotkey: Unable to create %s entry\n",
-                                 HOTKEY_ACTION));
                goto do_fail3;
        } else {
                hotkey_action->proc_fops = &hotkey_action_fops;
@@ -1066,9 +1028,6 @@ static int __init hotkey_init(void)
 
        hotkey_info = create_proc_entry(HOTKEY_INFO, mode, hotkey_proc_dir);
        if (!hotkey_info) {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                 "Hotkey: Unable to create %s entry\n",
-                                 HOTKEY_INFO));
                goto do_fail4;
        } else {
                hotkey_info->proc_fops = &hotkey_info_fops;
@@ -1104,7 +1063,6 @@ static void __exit hotkey_exit(void)
 {
        struct list_head *entries, *next;
 
-       ACPI_FUNCTION_TRACE("hotkey_exit");
 
        list_for_each_safe(entries, next, global_hotkey_list.entries) {
                union acpi_hotkey *key =