Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm
[pandora-kernel.git] / arch / blackfin / kernel / module.c
index d5aee36..67fc7a5 100644 (file)
@@ -27,6 +27,7 @@
  * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
+#define pr_fmt(fmt) "module %s: " fmt
 
 #include <linux/moduleloader.h>
 #include <linux/elf.h>
@@ -36,6 +37,7 @@
 #include <linux/kernel.h>
 #include <asm/dma.h>
 #include <asm/cacheflush.h>
+#include <asm/uaccess.h>
 
 void *module_alloc(unsigned long size)
 {
@@ -52,7 +54,7 @@ void module_free(struct module *mod, void *module_region)
 
 /* Transfer the section to the L1 memory */
 int
-module_frob_arch_sections(Elf_Ehdr * hdr, Elf_Shdr * sechdrs,
+module_frob_arch_sections(Elf_Ehdr *hdr, Elf_Shdr *sechdrs,
                          char *secstrings, struct module *mod)
 {
        /*
@@ -63,126 +65,119 @@ module_frob_arch_sections(Elf_Ehdr * hdr, Elf_Shdr * sechdrs,
         * NOTE: this breaks the semantic of mod->arch structure.
         */
        Elf_Shdr *s, *sechdrs_end = sechdrs + hdr->e_shnum;
-       void *dest = NULL;
+       void *dest;
 
        for (s = sechdrs; s < sechdrs_end; ++s) {
-               if ((strcmp(".l1.text", secstrings + s->sh_name) == 0) ||
-                   ((strcmp(".text", secstrings + s->sh_name) == 0) &&
-                    (hdr->e_flags & EF_BFIN_CODE_IN_L1) && (s->sh_size > 0))) {
+               const char *shname = secstrings + s->sh_name;
+
+               if (s->sh_size == 0)
+                       continue;
+
+               if (!strcmp(".l1.text", shname) ||
+                   (!strcmp(".text", shname) &&
+                    (hdr->e_flags & EF_BFIN_CODE_IN_L1))) {
+
                        dest = l1_inst_sram_alloc(s->sh_size);
                        mod->arch.text_l1 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                      "module %s: L1 instruction memory allocation failed\n",
-                                      mod->name);
+                               pr_err("L1 inst memory allocation failed\n",
+                                       mod->name);
                                return -1;
                        }
                        dma_memcpy(dest, (void *)s->sh_addr, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
-               if ((strcmp(".l1.data", secstrings + s->sh_name) == 0) ||
-                   ((strcmp(".data", secstrings + s->sh_name) == 0) &&
-                    (hdr->e_flags & EF_BFIN_DATA_IN_L1) && (s->sh_size > 0))) {
+
+               } else if (!strcmp(".l1.data", shname) ||
+                          (!strcmp(".data", shname) &&
+                           (hdr->e_flags & EF_BFIN_DATA_IN_L1))) {
+
                        dest = l1_data_sram_alloc(s->sh_size);
                        mod->arch.data_a_l1 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                       "module %s: L1 data memory allocation failed\n",
+                               pr_err("L1 data memory allocation failed\n",
                                        mod->name);
                                return -1;
                        }
                        memcpy(dest, (void *)s->sh_addr, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
-               if (strcmp(".l1.bss", secstrings + s->sh_name) == 0 ||
-                   ((strcmp(".bss", secstrings + s->sh_name) == 0) &&
-                    (hdr->e_flags & EF_BFIN_DATA_IN_L1) && (s->sh_size > 0))) {
-                       dest = l1_data_sram_alloc(s->sh_size);
+
+               } else if (!strcmp(".l1.bss", shname) ||
+                          (!strcmp(".bss", shname) &&
+                           (hdr->e_flags & EF_BFIN_DATA_IN_L1))) {
+
+                       dest = l1_data_sram_zalloc(s->sh_size);
                        mod->arch.bss_a_l1 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                       "module %s: L1 data memory allocation failed\n",
+                               pr_err("L1 data memory allocation failed\n",
                                        mod->name);
                                return -1;
                        }
-                       memset(dest, 0, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
-               if (strcmp(".l1.data.B", secstrings + s->sh_name) == 0) {
+
+               } else if (!strcmp(".l1.data.B", shname)) {
+
                        dest = l1_data_B_sram_alloc(s->sh_size);
                        mod->arch.data_b_l1 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                       "module %s: L1 data memory allocation failed\n",
+                               pr_err("L1 data memory allocation failed\n",
                                        mod->name);
                                return -1;
                        }
                        memcpy(dest, (void *)s->sh_addr, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
-               if (strcmp(".l1.bss.B", secstrings + s->sh_name) == 0) {
+
+               } else if (!strcmp(".l1.bss.B", shname)) {
+
                        dest = l1_data_B_sram_alloc(s->sh_size);
                        mod->arch.bss_b_l1 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                       "module %s: L1 data memory allocation failed\n",
+                               pr_err("L1 data memory allocation failed\n",
                                        mod->name);
                                return -1;
                        }
                        memset(dest, 0, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
-               if ((strcmp(".l2.text", secstrings + s->sh_name) == 0) ||
-                   ((strcmp(".text", secstrings + s->sh_name) == 0) &&
-                    (hdr->e_flags & EF_BFIN_CODE_IN_L2) && (s->sh_size > 0))) {
+
+               } else if (!strcmp(".l2.text", shname) ||
+                          (!strcmp(".text", shname) &&
+                           (hdr->e_flags & EF_BFIN_CODE_IN_L2))) {
+
                        dest = l2_sram_alloc(s->sh_size);
                        mod->arch.text_l2 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                      "module %s: L2 SRAM allocation failed\n",
-                                      mod->name);
+                               pr_err("L2 SRAM allocation failed\n",
+                                       mod->name);
                                return -1;
                        }
                        memcpy(dest, (void *)s->sh_addr, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
-               if ((strcmp(".l2.data", secstrings + s->sh_name) == 0) ||
-                   ((strcmp(".data", secstrings + s->sh_name) == 0) &&
-                    (hdr->e_flags & EF_BFIN_DATA_IN_L2) && (s->sh_size > 0))) {
+
+               } else if (!strcmp(".l2.data", shname) ||
+                          (!strcmp(".data", shname) &&
+                           (hdr->e_flags & EF_BFIN_DATA_IN_L2))) {
+
                        dest = l2_sram_alloc(s->sh_size);
                        mod->arch.data_l2 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                       "module %s: L2 SRAM allocation failed\n",
+                               pr_err("L2 SRAM allocation failed\n",
                                        mod->name);
                                return -1;
                        }
                        memcpy(dest, (void *)s->sh_addr, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
-               if (strcmp(".l2.bss", secstrings + s->sh_name) == 0 ||
-                   ((strcmp(".bss", secstrings + s->sh_name) == 0) &&
-                    (hdr->e_flags & EF_BFIN_DATA_IN_L2) && (s->sh_size > 0))) {
-                       dest = l2_sram_alloc(s->sh_size);
+
+               } else if (!strcmp(".l2.bss", shname) ||
+                          (!strcmp(".bss", shname) &&
+                           (hdr->e_flags & EF_BFIN_DATA_IN_L2))) {
+
+                       dest = l2_sram_zalloc(s->sh_size);
                        mod->arch.bss_l2 = dest;
                        if (dest == NULL) {
-                               printk(KERN_ERR
-                                       "module %s: L2 SRAM allocation failed\n",
+                               pr_err("L2 SRAM allocation failed\n",
                                        mod->name);
                                return -1;
                        }
-                       memset(dest, 0, s->sh_size);
-                       s->sh_flags &= ~SHF_ALLOC;
-                       s->sh_addr = (unsigned long)dest;
-               }
+
+               } else
+                       continue;
+
+               s->sh_flags &= ~SHF_ALLOC;
+               s->sh_addr = (unsigned long)dest;
        }
+
        return 0;
 }
 
@@ -190,7 +185,7 @@ int
 apply_relocate(Elf_Shdr * sechdrs, const char *strtab,
               unsigned int symindex, unsigned int relsec, struct module *me)
 {
-       printk(KERN_ERR "module %s: .rel unsupported\n", me->name);
+       pr_err(".rel unsupported\n", me->name);
        return -ENOEXEC;
 }
 
@@ -205,109 +200,86 @@ apply_relocate(Elf_Shdr * sechdrs, const char *strtab,
 /*            gas does not generate it.                                  */
 /*************************************************************************/
 int
-apply_relocate_add(Elf_Shdr * sechdrs, const char *strtab,
+apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
                   unsigned int symindex, unsigned int relsec,
                   struct module *mod)
 {
        unsigned int i;
-       unsigned short tmp;
        Elf32_Rela *rel = (void *)sechdrs[relsec].sh_addr;
        Elf32_Sym *sym;
-       uint32_t *location32;
-       uint16_t *location16;
-       uint32_t value;
+       unsigned long location, value, size;
+
+       pr_debug("applying relocate section %u to %u\n", mod->name,
+               relsec, sechdrs[relsec].sh_info);
 
-       pr_debug("Applying relocate section %u to %u\n", relsec,
-              sechdrs[relsec].sh_info);
        for (i = 0; i < sechdrs[relsec].sh_size / sizeof(*rel); i++) {
                /* This is where to make the change */
-               location16 =
-                   (uint16_t *) (sechdrs[sechdrs[relsec].sh_info].sh_addr +
-                                 rel[i].r_offset);
-               location32 = (uint32_t *) location16;
+               location = sechdrs[sechdrs[relsec].sh_info].sh_addr +
+                          rel[i].r_offset;
+
                /* This is the symbol it is referring to. Note that all
                   undefined symbols have been resolved. */
                sym = (Elf32_Sym *) sechdrs[symindex].sh_addr
                    + ELF32_R_SYM(rel[i].r_info);
                value = sym->st_value;
                value += rel[i].r_addend;
-               pr_debug("location is %x, value is %x type is %d \n",
-                        (unsigned int) location32, value,
-                        ELF32_R_TYPE(rel[i].r_info));
+
 #ifdef CONFIG_SMP
-               if ((unsigned long)location16 >= COREB_L1_DATA_A_START) {
-                       printk(KERN_ERR "module %s: cannot relocate in L1: %u (SMP kernel)",
-                                      mod->name, ELF32_R_TYPE(rel[i].r_info));
+               if (location >= COREB_L1_DATA_A_START) {
+                       pr_err("cannot relocate in L1: %u (SMP kernel)",
+                               mod->name, ELF32_R_TYPE(rel[i].r_info));
                        return -ENOEXEC;
                }
 #endif
+
+               pr_debug("location is %lx, value is %lx type is %d\n",
+                       mod->name, location, value, ELF32_R_TYPE(rel[i].r_info));
+
                switch (ELF32_R_TYPE(rel[i].r_info)) {
 
+               case R_BFIN_HUIMM16:
+                       value >>= 16;
+               case R_BFIN_LUIMM16:
+               case R_BFIN_RIMM16:
+                       size = 2;
+                       break;
+               case R_BFIN_BYTE4_DATA:
+                       size = 4;
+                       break;
+
                case R_BFIN_PCREL24:
                case R_BFIN_PCREL24_JUMP_L:
-                       /* Add the value, subtract its postition */
-                       location16 =
-                           (uint16_t *) (sechdrs[sechdrs[relsec].sh_info].
-                                         sh_addr + rel[i].r_offset - 2);
-                       location32 = (uint32_t *) location16;
-                       value -= (uint32_t) location32;
-                       value >>= 1;
-                       if ((value & 0xFF000000) != 0 &&
-                           (value & 0xFF000000) != 0xFF000000) {
-                               printk(KERN_ERR "module %s: relocation overflow\n",
-                                      mod->name);
-                               return -ENOEXEC;
-                       }
-                       pr_debug("value is %x, before %x-%x after %x-%x\n", value,
-                              *location16, *(location16 + 1),
-                              (*location16 & 0xff00) | (value >> 16 & 0x00ff),
-                              value & 0xffff);
-                       *location16 =
-                           (*location16 & 0xff00) | (value >> 16 & 0x00ff);
-                       *(location16 + 1) = value & 0xffff;
-                       break;
                case R_BFIN_PCREL12_JUMP:
                case R_BFIN_PCREL12_JUMP_S:
-                       value -= (uint32_t) location32;
-                       value >>= 1;
-                       *location16 = (value & 0xfff);
-                       break;
                case R_BFIN_PCREL10:
-                       value -= (uint32_t) location32;
-                       value >>= 1;
-                       *location16 = (value & 0x3ff);
-                       break;
-               case R_BFIN_LUIMM16:
-                       pr_debug("before %x after %x\n", *location16,
-                                      (value & 0xffff));
-                       tmp = (value & 0xffff);
-                       if ((unsigned long)location16 >= L1_CODE_START) {
-                               dma_memcpy(location16, &tmp, 2);
-                       } else
-                               *location16 = tmp;
-                       break;
-               case R_BFIN_HUIMM16:
-                       pr_debug("before %x after %x\n", *location16,
-                                      ((value >> 16) & 0xffff));
-                       tmp = ((value >> 16) & 0xffff);
-                       if ((unsigned long)location16 >= L1_CODE_START) {
-                               dma_memcpy(location16, &tmp, 2);
-                       } else
-                               *location16 = tmp;
+                       pr_err("unsupported relocation: %u (no -mlong-calls?)\n",
+                               mod->name, ELF32_R_TYPE(rel[i].r_info));
+                       return -ENOEXEC;
+
+               default:
+                       pr_err("unknown relocation: %u\n", mod->name,
+                               ELF32_R_TYPE(rel[i].r_info));
+                       return -ENOEXEC;
+               }
+
+               switch (bfin_mem_access_type(location, size)) {
+               case BFIN_MEM_ACCESS_CORE:
+               case BFIN_MEM_ACCESS_CORE_ONLY:
+                       memcpy((void *)location, &value, size);
                        break;
-               case R_BFIN_RIMM16:
-                       *location16 = (value & 0xffff);
+               case BFIN_MEM_ACCESS_DMA:
+                       dma_memcpy((void *)location, &value, size);
                        break;
-               case R_BFIN_BYTE4_DATA:
-                       pr_debug("before %x after %x\n", *location32, value);
-                       *location32 = value;
+               case BFIN_MEM_ACCESS_ITEST:
+                       isram_memcpy((void *)location, &value, size);
                        break;
                default:
-                       printk(KERN_ERR "module %s: Unknown relocation: %u\n",
-                              mod->name, ELF32_R_TYPE(rel[i].r_info));
+                       pr_err("invalid relocation for %#lx\n",
+                               mod->name, location);
                        return -ENOEXEC;
                }
        }
+
        return 0;
 }
 
@@ -332,22 +304,28 @@ module_finalize(const Elf_Ehdr * hdr,
        for (i = 1; i < hdr->e_shnum; i++) {
                const char *strtab = (char *)sechdrs[strindex].sh_addr;
                unsigned int info = sechdrs[i].sh_info;
+               const char *shname = secstrings + sechdrs[i].sh_name;
 
                /* Not a valid relocation section? */
                if (info >= hdr->e_shnum)
                        continue;
 
-               if ((sechdrs[i].sh_type == SHT_RELA) &&
-                   ((strcmp(".rela.l2.text", secstrings + sechdrs[i].sh_name) == 0) ||
-                   (strcmp(".rela.l1.text", secstrings + sechdrs[i].sh_name) == 0) ||
-                   ((strcmp(".rela.text", secstrings + sechdrs[i].sh_name) == 0) &&
-                       (hdr->e_flags & (EF_BFIN_CODE_IN_L1|EF_BFIN_CODE_IN_L2))))) {
+               /* Only support RELA relocation types */
+               if (sechdrs[i].sh_type != SHT_RELA)
+                       continue;
+
+               if (!strcmp(".rela.l2.text", shname) ||
+                   !strcmp(".rela.l1.text", shname) ||
+                   (!strcmp(".rela.text", shname) &&
+                        (hdr->e_flags & (EF_BFIN_CODE_IN_L1 | EF_BFIN_CODE_IN_L2)))) {
+
                        err = apply_relocate_add((Elf_Shdr *) sechdrs, strtab,
                                           symindex, i, mod);
                        if (err < 0)
                                return -ENOEXEC;
                }
        }
+
        return 0;
 }