sched: Don't set sd->child to NULL when it is already NULL
authorViresh Kumar <viresh.kumar@linaro.org>
Mon, 10 Jun 2013 10:57:19 +0000 (16:27 +0530)
committerIngo Molnar <mingo@kernel.org>
Wed, 19 Jun 2013 10:58:45 +0000 (12:58 +0200)
Memory for sd is allocated with kzalloc_node() which will initialize its fields
with zero. In build_sched_domain() we are setting sd->child to child even if
child is NULL, which isn't required.

Lets do it only if child isn't NULL.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/f4753a1730051341003ad2ad29a3229c7356678e.1370861520.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c

index 3de6264..88c2c0e 100644 (file)
@@ -5955,8 +5955,8 @@ struct sched_domain *build_sched_domain(struct sched_domain_topology_level *tl,
                sd->level = child->level + 1;
                sched_domain_level_max = max(sched_domain_level_max, sd->level);
                child->parent = sd;
+               sd->child = child;
        }
-       sd->child = child;
        set_domain_attribute(sd, attr);
 
        return sd;