[ALSA] hda - Add support for the ATI RS600 HDMI audio device
[pandora-kernel.git] / sound / core / timer.c
index 1b90a38..d92f73c 100644 (file)
@@ -25,6 +25,7 @@
 #include <linux/smp_lock.h>
 #include <linux/slab.h>
 #include <linux/time.h>
+#include <linux/mutex.h>
 #include <linux/moduleparam.h>
 #include <linux/string.h>
 #include <sound/core.h>
@@ -53,8 +54,8 @@ MODULE_LICENSE("GPL");
 module_param(timer_limit, int, 0444);
 MODULE_PARM_DESC(timer_limit, "Maximum global timers in system.");
 
-typedef struct {
-       snd_timer_instance_t *timeri;
+struct snd_timer_user {
+       struct snd_timer_instance *timeri;
        int tread;              /* enhanced read with timestamps and events */
        unsigned long ticks;
        unsigned long overrun;
@@ -62,16 +63,16 @@ typedef struct {
        int qtail;
        int qused;
        int queue_size;
-       snd_timer_read_t *queue;
-       snd_timer_tread_t *tqueue;
+       struct snd_timer_read *queue;
+       struct snd_timer_tread *tqueue;
        spinlock_t qlock;
        unsigned long last_resolution;
        unsigned int filter;
        struct timespec tstamp;         /* trigger tstamp */
        wait_queue_head_t qchange_sleep;
        struct fasync_struct *fasync;
-       struct semaphore tread_sem;
-} snd_timer_user_t;
+       struct mutex tread_sem;
+};
 
 /* list of timers */
 static LIST_HEAD(snd_timer_list);
@@ -82,23 +83,23 @@ static LIST_HEAD(snd_timer_slave_list);
 /* lock for slave active lists */
 static DEFINE_SPINLOCK(slave_active_lock);
 
-static DECLARE_MUTEX(register_mutex);
+static DEFINE_MUTEX(register_mutex);
 
-static int snd_timer_free(snd_timer_t *timer);
-static int snd_timer_dev_free(snd_device_t *device);
-static int snd_timer_dev_register(snd_device_t *device);
-static int snd_timer_dev_unregister(snd_device_t *device);
+static int snd_timer_free(struct snd_timer *timer);
+static int snd_timer_dev_free(struct snd_device *device);
+static int snd_timer_dev_register(struct snd_device *device);
+static int snd_timer_dev_unregister(struct snd_device *device);
 
-static void snd_timer_reschedule(snd_timer_t * timer, unsigned long ticks_left);
+static void snd_timer_reschedule(struct snd_timer * timer, unsigned long ticks_left);
 
 /*
  * create a timer instance with the given owner string.
  * when timer is not NULL, increments the module counter
  */
-static snd_timer_instance_t *snd_timer_instance_new(char *owner,
-                                                   snd_timer_t *timer)
+static struct snd_timer_instance *snd_timer_instance_new(char *owner,
+                                                        struct snd_timer *timer)
 {
-       snd_timer_instance_t *timeri;
+       struct snd_timer_instance *timeri;
        timeri = kzalloc(sizeof(*timeri), GFP_KERNEL);
        if (timeri == NULL)
                return NULL;
@@ -126,13 +127,13 @@ static snd_timer_instance_t *snd_timer_instance_new(char *owner,
 /*
  * find a timer instance from the given timer id
  */
-static snd_timer_t *snd_timer_find(snd_timer_id_t *tid)
+static struct snd_timer *snd_timer_find(struct snd_timer_id *tid)
 {
-       snd_timer_t *timer = NULL;
+       struct snd_timer *timer = NULL;
        struct list_head *p;
 
        list_for_each(p, &snd_timer_list) {
-               timer = list_entry(p, snd_timer_t, device_list);
+               timer = list_entry(p, struct snd_timer, device_list);
 
                if (timer->tmr_class != tid->dev_class)
                        continue;
@@ -152,7 +153,7 @@ static snd_timer_t *snd_timer_find(snd_timer_id_t *tid)
 
 #ifdef CONFIG_KMOD
 
-static void snd_timer_request(snd_timer_id_t *tid)
+static void snd_timer_request(struct snd_timer_id *tid)
 {
        if (! current->fs->root)
                return;
@@ -179,17 +180,17 @@ static void snd_timer_request(snd_timer_id_t *tid)
  *
  * call this with register_mutex down.
  */
-static void snd_timer_check_slave(snd_timer_instance_t *slave)
+static void snd_timer_check_slave(struct snd_timer_instance *slave)
 {
-       snd_timer_t *timer;
-       snd_timer_instance_t *master;
+       struct snd_timer *timer;
+       struct snd_timer_instance *master;
        struct list_head *p, *q;
 
        /* FIXME: it's really dumb to look up all entries.. */
        list_for_each(p, &snd_timer_list) {
-               timer = list_entry(p, snd_timer_t, device_list);
+               timer = list_entry(p, struct snd_timer, device_list);
                list_for_each(q, &timer->open_list_head) {
-                       master = list_entry(q, snd_timer_instance_t, open_list);
+                       master = list_entry(q, struct snd_timer_instance, open_list);
                        if (slave->slave_class == master->slave_class &&
                            slave->slave_id == master->slave_id) {
                                list_del(&slave->open_list);
@@ -211,14 +212,14 @@ static void snd_timer_check_slave(snd_timer_instance_t *slave)
  *
  * call this with register_mutex down.
  */
-static void snd_timer_check_master(snd_timer_instance_t *master)
+static void snd_timer_check_master(struct snd_timer_instance *master)
 {
-       snd_timer_instance_t *slave;
+       struct snd_timer_instance *slave;
        struct list_head *p, *n;
 
        /* check all pending slaves */
        list_for_each_safe(p, n, &snd_timer_slave_list) {
-               slave = list_entry(p, snd_timer_instance_t, open_list);
+               slave = list_entry(p, struct snd_timer_instance, open_list);
                if (slave->slave_class == master->slave_class &&
                    slave->slave_id == master->slave_id) {
                        list_del(p);
@@ -238,12 +239,12 @@ static void snd_timer_check_master(snd_timer_instance_t *master)
  * open a timer instance
  * when opening a master, the slave id must be here given.
  */
-int snd_timer_open(snd_timer_instance_t **ti,
-                  char *owner, snd_timer_id_t *tid,
+int snd_timer_open(struct snd_timer_instance **ti,
+                  char *owner, struct snd_timer_id *tid,
                   unsigned int slave_id)
 {
-       snd_timer_t *timer;
-       snd_timer_instance_t *timeri = NULL;
+       struct snd_timer *timer;
+       struct snd_timer_instance *timeri = NULL;
 
        if (tid->dev_class == SNDRV_TIMER_CLASS_SLAVE) {
                /* open a slave instance */
@@ -252,10 +253,10 @@ int snd_timer_open(snd_timer_instance_t **ti,
                        snd_printd("invalid slave class %i\n", tid->dev_sclass);
                        return -EINVAL;
                }
-               down(&register_mutex);
+               mutex_lock(&register_mutex);
                timeri = snd_timer_instance_new(owner, NULL);
                if (!timeri) {
-                       up(&register_mutex);
+                       mutex_unlock(&register_mutex);
                        return -ENOMEM;
                }
                timeri->slave_class = tid->dev_sclass;
@@ -263,37 +264,37 @@ int snd_timer_open(snd_timer_instance_t **ti,
                timeri->flags |= SNDRV_TIMER_IFLG_SLAVE;
                list_add_tail(&timeri->open_list, &snd_timer_slave_list);
                snd_timer_check_slave(timeri);
-               up(&register_mutex);
+               mutex_unlock(&register_mutex);
                *ti = timeri;
                return 0;
        }
 
        /* open a master instance */
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        timer = snd_timer_find(tid);
 #ifdef CONFIG_KMOD
        if (timer == NULL) {
-               up(&register_mutex);
+               mutex_unlock(&register_mutex);
                snd_timer_request(tid);
-               down(&register_mutex);
+               mutex_lock(&register_mutex);
                timer = snd_timer_find(tid);
        }
 #endif
        if (!timer) {
-               up(&register_mutex);
+               mutex_unlock(&register_mutex);
                return -ENODEV;
        }
        if (!list_empty(&timer->open_list_head)) {
                timeri = list_entry(timer->open_list_head.next,
-                                   snd_timer_instance_t, open_list);
+                                   struct snd_timer_instance, open_list);
                if (timeri->flags & SNDRV_TIMER_IFLG_EXCLUSIVE) {
-                       up(&register_mutex);
+                       mutex_unlock(&register_mutex);
                        return -EBUSY;
                }
        }
        timeri = snd_timer_instance_new(owner, timer);
        if (!timeri) {
-               up(&register_mutex);
+               mutex_unlock(&register_mutex);
                return -ENOMEM;
        }
        timeri->slave_class = tid->dev_sclass;
@@ -302,22 +303,22 @@ int snd_timer_open(snd_timer_instance_t **ti,
                timer->hw.open(timer);
        list_add_tail(&timeri->open_list, &timer->open_list_head);
        snd_timer_check_master(timeri);
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
        *ti = timeri;
        return 0;
 }
 
-static int _snd_timer_stop(snd_timer_instance_t * timeri,
-                          int keep_flag, enum sndrv_timer_event event);
+static int _snd_timer_stop(struct snd_timer_instance *timeri,
+                          int keep_flag, int event);
 
 /*
  * close a timer instance
  */
-int snd_timer_close(snd_timer_instance_t * timeri)
+int snd_timer_close(struct snd_timer_instance *timeri)
 {
-       snd_timer_t *timer = NULL;
+       struct snd_timer *timer = NULL;
        struct list_head *p, *n;
-       snd_timer_instance_t *slave;
+       struct snd_timer_instance *slave;
 
        snd_assert(timeri != NULL, return -ENXIO);
 
@@ -333,9 +334,9 @@ int snd_timer_close(snd_timer_instance_t * timeri)
                        spin_lock_irq(&slave_active_lock);
                }
                spin_unlock_irq(&slave_active_lock);
-               down(&register_mutex);
+               mutex_lock(&register_mutex);
                list_del(&timeri->open_list);
-               up(&register_mutex);
+               mutex_unlock(&register_mutex);
        } else {
                timer = timeri->timer;
                /* wait, until the active callback is finished */
@@ -346,14 +347,14 @@ int snd_timer_close(snd_timer_instance_t * timeri)
                        spin_lock_irq(&timer->lock);
                }
                spin_unlock_irq(&timer->lock);
-               down(&register_mutex);
+               mutex_lock(&register_mutex);
                list_del(&timeri->open_list);
                if (timer && list_empty(&timer->open_list_head) &&
                    timer->hw.close)
                        timer->hw.close(timer);
                /* remove slave links */
                list_for_each_safe(p, n, &timeri->slave_list_head) {
-                       slave = list_entry(p, snd_timer_instance_t, open_list);
+                       slave = list_entry(p, struct snd_timer_instance, open_list);
                        spin_lock_irq(&slave_active_lock);
                        _snd_timer_stop(slave, 1, SNDRV_TIMER_EVENT_RESOLUTION);
                        list_del(p);
@@ -362,7 +363,7 @@ int snd_timer_close(snd_timer_instance_t * timeri)
                        slave->timer = NULL;
                        spin_unlock_irq(&slave_active_lock);
                }
-               up(&register_mutex);
+               mutex_unlock(&register_mutex);
        }
        if (timeri->private_free)
                timeri->private_free(timeri);
@@ -373,9 +374,9 @@ int snd_timer_close(snd_timer_instance_t * timeri)
        return 0;
 }
 
-unsigned long snd_timer_resolution(snd_timer_instance_t * timeri)
+unsigned long snd_timer_resolution(struct snd_timer_instance *timeri)
 {
-       snd_timer_t * timer;
+       struct snd_timer * timer;
 
        if (timeri == NULL)
                return 0;
@@ -387,13 +388,12 @@ unsigned long snd_timer_resolution(snd_timer_instance_t * timeri)
        return 0;
 }
 
-static void snd_timer_notify1(snd_timer_instance_t *ti,
-                             enum sndrv_timer_event event)
+static void snd_timer_notify1(struct snd_timer_instance *ti, int event)
 {
-       snd_timer_t *timer;
+       struct snd_timer *timer;
        unsigned long flags;
        unsigned long resolution = 0;
-       snd_timer_instance_t *ts;
+       struct snd_timer_instance *ts;
        struct list_head *n;
        struct timespec tstamp;
 
@@ -414,14 +414,14 @@ static void snd_timer_notify1(snd_timer_instance_t *ti,
                return;
        spin_lock_irqsave(&timer->lock, flags);
        list_for_each(n, &ti->slave_active_head) {
-               ts = list_entry(n, snd_timer_instance_t, active_list);
+               ts = list_entry(n, struct snd_timer_instance, active_list);
                if (ts->ccallback)
                        ts->ccallback(ti, event + 100, &tstamp, resolution);
        }
        spin_unlock_irqrestore(&timer->lock, flags);
 }
 
-static int snd_timer_start1(snd_timer_t *timer, snd_timer_instance_t *timeri,
+static int snd_timer_start1(struct snd_timer *timer, struct snd_timer_instance *timeri,
                            unsigned long sticks)
 {
        list_del(&timeri->active_list);
@@ -442,7 +442,7 @@ static int snd_timer_start1(snd_timer_t *timer, snd_timer_instance_t *timeri,
        }
 }
 
-static int snd_timer_start_slave(snd_timer_instance_t *timeri)
+static int snd_timer_start_slave(struct snd_timer_instance *timeri)
 {
        unsigned long flags;
 
@@ -458,9 +458,9 @@ static int snd_timer_start_slave(snd_timer_instance_t *timeri)
 /*
  *  start the timer instance
  */
-int snd_timer_start(snd_timer_instance_t * timeri, unsigned int ticks)
+int snd_timer_start(struct snd_timer_instance *timeri, unsigned int ticks)
 {
-       snd_timer_t *timer;
+       struct snd_timer *timer;
        int result = -EINVAL;
        unsigned long flags;
 
@@ -483,10 +483,10 @@ int snd_timer_start(snd_timer_instance_t * timeri, unsigned int ticks)
        return result;
 }
 
-static int _snd_timer_stop(snd_timer_instance_t * timeri,
-                          int keep_flag, enum sndrv_timer_event event)
+static int _snd_timer_stop(struct snd_timer_instance * timeri,
+                          int keep_flag, int event)
 {
-       snd_timer_t *timer;
+       struct snd_timer *timer;
        unsigned long flags;
 
        snd_assert(timeri != NULL, return -ENXIO);
@@ -532,9 +532,9 @@ static int _snd_timer_stop(snd_timer_instance_t * timeri,
  *
  * do not call this from the timer callback!
  */
-int snd_timer_stop(snd_timer_instance_t * timeri)
+int snd_timer_stop(struct snd_timer_instance *timeri)
 {
-       snd_timer_t *timer;
+       struct snd_timer *timer;
        unsigned long flags;
        int err;
 
@@ -552,9 +552,9 @@ int snd_timer_stop(snd_timer_instance_t * timeri)
 /*
  * start again..  the tick is kept.
  */
-int snd_timer_continue(snd_timer_instance_t * timeri)
+int snd_timer_continue(struct snd_timer_instance *timeri)
 {
-       snd_timer_t *timer;
+       struct snd_timer *timer;
        int result = -EINVAL;
        unsigned long flags;
 
@@ -578,7 +578,7 @@ int snd_timer_continue(snd_timer_instance_t * timeri)
 /*
  * pause.. remember the ticks left
  */
-int snd_timer_pause(snd_timer_instance_t * timeri)
+int snd_timer_pause(struct snd_timer_instance * timeri)
 {
        return _snd_timer_stop(timeri, 0, SNDRV_TIMER_EVENT_PAUSE);
 }
@@ -589,14 +589,14 @@ int snd_timer_pause(snd_timer_instance_t * timeri)
  * start pending instances and check the scheduling ticks.
  * when the scheduling ticks is changed set CHANGE flag to reprogram the timer.
  */
-static void snd_timer_reschedule(snd_timer_t * timer, unsigned long ticks_left)
+static void snd_timer_reschedule(struct snd_timer * timer, unsigned long ticks_left)
 {
-       snd_timer_instance_t *ti;
+       struct snd_timer_instance *ti;
        unsigned long ticks = ~0UL;
        struct list_head *p;
 
        list_for_each(p, &timer->active_list_head) {
-               ti = list_entry(p, snd_timer_instance_t, active_list);
+               ti = list_entry(p, struct snd_timer_instance, active_list);
                if (ti->flags & SNDRV_TIMER_IFLG_START) {
                        ti->flags &= ~SNDRV_TIMER_IFLG_START;
                        ti->flags |= SNDRV_TIMER_IFLG_RUNNING;
@@ -624,8 +624,8 @@ static void snd_timer_reschedule(snd_timer_t * timer, unsigned long ticks_left)
  */
 static void snd_timer_tasklet(unsigned long arg)
 {
-       snd_timer_t *timer = (snd_timer_t *) arg;
-       snd_timer_instance_t *ti;
+       struct snd_timer *timer = (struct snd_timer *) arg;
+       struct snd_timer_instance *ti;
        struct list_head *p;
        unsigned long resolution, ticks;
 
@@ -633,7 +633,7 @@ static void snd_timer_tasklet(unsigned long arg)
        /* now process all callbacks */
        while (!list_empty(&timer->sack_list_head)) {
                p = timer->sack_list_head.next;         /* get first item */
-               ti = list_entry(p, snd_timer_instance_t, ack_list);
+               ti = list_entry(p, struct snd_timer_instance, ack_list);
 
                /* remove from ack_list and make empty */
                list_del_init(p);
@@ -658,17 +658,18 @@ static void snd_timer_tasklet(unsigned long arg)
  * ticks_left is usually equal to timer->sticks.
  *
  */
-void snd_timer_interrupt(snd_timer_t * timer, unsigned long ticks_left)
+void snd_timer_interrupt(struct snd_timer * timer, unsigned long ticks_left)
 {
-       snd_timer_instance_t *ti, *ts;
+       struct snd_timer_instance *ti, *ts;
        unsigned long resolution, ticks;
        struct list_head *p, *q, *n, *ack_list_head;
+       unsigned long flags;
        int use_tasklet = 0;
 
        if (timer == NULL)
                return;
 
-       spin_lock(&timer->lock);
+       spin_lock_irqsave(&timer->lock, flags);
 
        /* remember the current resolution */
        if (timer->hw.c_resolution)
@@ -682,7 +683,7 @@ void snd_timer_interrupt(snd_timer_t * timer, unsigned long ticks_left)
         * is called.
         */
        list_for_each_safe(p, n, &timer->active_list_head) {
-               ti = list_entry(p, snd_timer_instance_t, active_list);
+               ti = list_entry(p, struct snd_timer_instance, active_list);
                if (!(ti->flags & SNDRV_TIMER_IFLG_RUNNING))
                        continue;
                ti->pticks += ticks_left;
@@ -708,7 +709,7 @@ void snd_timer_interrupt(snd_timer_t * timer, unsigned long ticks_left)
                if (list_empty(&ti->ack_list))
                        list_add_tail(&ti->ack_list, ack_list_head);
                list_for_each(q, &ti->slave_active_head) {
-                       ts = list_entry(q, snd_timer_instance_t, active_list);
+                       ts = list_entry(q, struct snd_timer_instance, active_list);
                        ts->pticks = ti->pticks;
                        ts->resolution = resolution;
                        if (list_empty(&ts->ack_list))
@@ -735,7 +736,7 @@ void snd_timer_interrupt(snd_timer_t * timer, unsigned long ticks_left)
        /* now process all fast callbacks */
        while (!list_empty(&timer->ack_list_head)) {
                p = timer->ack_list_head.next;          /* get first item */
-               ti = list_entry(p, snd_timer_instance_t, ack_list);
+               ti = list_entry(p, struct snd_timer_instance, ack_list);
 
                /* remove from ack_list and make empty */
                list_del_init(p);
@@ -753,7 +754,7 @@ void snd_timer_interrupt(snd_timer_t * timer, unsigned long ticks_left)
 
        /* do we have any slow callbacks? */
        use_tasklet = !list_empty(&timer->sack_list_head);
-       spin_unlock(&timer->lock);
+       spin_unlock_irqrestore(&timer->lock, flags);
 
        if (use_tasklet)
                tasklet_hi_schedule(&timer->task_queue);
@@ -763,12 +764,12 @@ void snd_timer_interrupt(snd_timer_t * timer, unsigned long ticks_left)
 
  */
 
-int snd_timer_new(snd_card_t *card, char *id, snd_timer_id_t *tid,
-                 snd_timer_t **rtimer)
+int snd_timer_new(struct snd_card *card, char *id, struct snd_timer_id *tid,
+                 struct snd_timer **rtimer)
 {
-       snd_timer_t *timer;
+       struct snd_timer *timer;
        int err;
-       static snd_device_ops_t ops = {
+       static struct snd_device_ops ops = {
                .dev_free = snd_timer_dev_free,
                .dev_register = snd_timer_dev_register,
                .dev_unregister = snd_timer_dev_unregister
@@ -778,8 +779,10 @@ int snd_timer_new(snd_card_t *card, char *id, snd_timer_id_t *tid,
        snd_assert(rtimer != NULL, return -EINVAL);
        *rtimer = NULL;
        timer = kzalloc(sizeof(*timer), GFP_KERNEL);
-       if (timer == NULL)
+       if (timer == NULL) {
+               snd_printk(KERN_ERR "timer: cannot allocate\n");
                return -ENOMEM;
+       }
        timer->tmr_class = tid->dev_class;
        timer->card = card;
        timer->tmr_device = tid->device;
@@ -806,7 +809,7 @@ int snd_timer_new(snd_card_t *card, char *id, snd_timer_id_t *tid,
        return 0;
 }
 
-static int snd_timer_free(snd_timer_t *timer)
+static int snd_timer_free(struct snd_timer *timer)
 {
        snd_assert(timer != NULL, return -ENXIO);
        if (timer->private_free)
@@ -815,16 +818,16 @@ static int snd_timer_free(snd_timer_t *timer)
        return 0;
 }
 
-static int snd_timer_dev_free(snd_device_t *device)
+static int snd_timer_dev_free(struct snd_device *device)
 {
-       snd_timer_t *timer = device->device_data;
+       struct snd_timer *timer = device->device_data;
        return snd_timer_free(timer);
 }
 
-static int snd_timer_dev_register(snd_device_t *dev)
+static int snd_timer_dev_register(struct snd_device *dev)
 {
-       snd_timer_t *timer = dev->device_data;
-       snd_timer_t *timer1;
+       struct snd_timer *timer = dev->device_data;
+       struct snd_timer *timer1;
        struct list_head *p;
 
        snd_assert(timer != NULL && timer->hw.start != NULL &&
@@ -833,9 +836,9 @@ static int snd_timer_dev_register(snd_device_t *dev)
            !timer->hw.resolution && timer->hw.c_resolution == NULL)
                return -EINVAL;
 
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        list_for_each(p, &snd_timer_list) {
-               timer1 = list_entry(p, snd_timer_t, device_list);
+               timer1 = list_entry(p, struct snd_timer, device_list);
                if (timer1->tmr_class > timer->tmr_class)
                        break;
                if (timer1->tmr_class < timer->tmr_class)
@@ -855,46 +858,45 @@ static int snd_timer_dev_register(snd_device_t *dev)
                if (timer1->tmr_subdevice < timer->tmr_subdevice)
                        continue;
                /* conflicts.. */
-               up(&register_mutex);
+               mutex_unlock(&register_mutex);
                return -EBUSY;
        }
        list_add_tail(&timer->device_list, p);
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
        return 0;
 }
 
-static int snd_timer_unregister(snd_timer_t *timer)
+static int snd_timer_unregister(struct snd_timer *timer)
 {
        struct list_head *p, *n;
-       snd_timer_instance_t *ti;
+       struct snd_timer_instance *ti;
 
        snd_assert(timer != NULL, return -ENXIO);
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        if (! list_empty(&timer->open_list_head)) {
                snd_printk(KERN_WARNING "timer 0x%lx is busy?\n", (long)timer);
                list_for_each_safe(p, n, &timer->open_list_head) {
                        list_del_init(p);
-                       ti = list_entry(p, snd_timer_instance_t, open_list);
+                       ti = list_entry(p, struct snd_timer_instance, open_list);
                        ti->timer = NULL;
                }
        }
        list_del(&timer->device_list);
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
        return snd_timer_free(timer);
 }
 
-static int snd_timer_dev_unregister(snd_device_t *device)
+static int snd_timer_dev_unregister(struct snd_device *device)
 {
-       snd_timer_t *timer = device->device_data;
+       struct snd_timer *timer = device->device_data;
        return snd_timer_unregister(timer);
 }
 
-void snd_timer_notify(snd_timer_t *timer, enum sndrv_timer_event event,
-                     struct timespec *tstamp)
+void snd_timer_notify(struct snd_timer *timer, int event, struct timespec *tstamp)
 {
        unsigned long flags;
        unsigned long resolution = 0;
-       snd_timer_instance_t *ti, *ts;
+       struct snd_timer_instance *ti, *ts;
        struct list_head *p, *n;
 
        if (! (timer->hw.flags & SNDRV_TIMER_HW_SLAVE))
@@ -911,11 +913,11 @@ void snd_timer_notify(snd_timer_t *timer, enum sndrv_timer_event event,
                        resolution = timer->hw.resolution;
        }
        list_for_each(p, &timer->active_list_head) {
-               ti = list_entry(p, snd_timer_instance_t, active_list);
+               ti = list_entry(p, struct snd_timer_instance, active_list);
                if (ti->ccallback)
                        ti->ccallback(ti, event, tstamp, resolution);
                list_for_each(n, &ti->slave_active_head) {
-                       ts = list_entry(n, snd_timer_instance_t, active_list);
+                       ts = list_entry(n, struct snd_timer_instance, active_list);
                        if (ts->ccallback)
                                ts->ccallback(ts, event, tstamp, resolution);
                }
@@ -926,9 +928,9 @@ void snd_timer_notify(snd_timer_t *timer, enum sndrv_timer_event event,
 /*
  * exported functions for global timers
  */
-int snd_timer_global_new(char *id, int device, snd_timer_t **rtimer)
+int snd_timer_global_new(char *id, int device, struct snd_timer **rtimer)
 {
-       snd_timer_id_t tid;
+       struct snd_timer_id tid;
 
        tid.dev_class = SNDRV_TIMER_CLASS_GLOBAL;
        tid.dev_sclass = SNDRV_TIMER_SCLASS_NONE;
@@ -938,21 +940,21 @@ int snd_timer_global_new(char *id, int device, snd_timer_t **rtimer)
        return snd_timer_new(NULL, id, &tid, rtimer);
 }
 
-int snd_timer_global_free(snd_timer_t *timer)
+int snd_timer_global_free(struct snd_timer *timer)
 {
        return snd_timer_free(timer);
 }
 
-int snd_timer_global_register(snd_timer_t *timer)
+int snd_timer_global_register(struct snd_timer *timer)
 {
-       snd_device_t dev;
+       struct snd_device dev;
 
        memset(&dev, 0, sizeof(dev));
        dev.device_data = timer;
        return snd_timer_dev_register(&dev);
 }
 
-int snd_timer_global_unregister(snd_timer_t *timer)
+int snd_timer_global_unregister(struct snd_timer *timer)
 {
        return snd_timer_unregister(timer);
 }
@@ -971,7 +973,7 @@ struct snd_timer_system_private {
 
 static void snd_timer_s_function(unsigned long data)
 {
-       snd_timer_t *timer = (snd_timer_t *)data;
+       struct snd_timer *timer = (struct snd_timer *)data;
        struct snd_timer_system_private *priv = timer->private_data;
        unsigned long jiff = jiffies;
        if (time_after(jiff, priv->last_expires))
@@ -979,7 +981,7 @@ static void snd_timer_s_function(unsigned long data)
        snd_timer_interrupt(timer, (long)jiff - (long)priv->last_jiffies);
 }
 
-static int snd_timer_s_start(snd_timer_t * timer)
+static int snd_timer_s_start(struct snd_timer * timer)
 {
        struct snd_timer_system_private *priv;
        unsigned long njiff;
@@ -998,7 +1000,7 @@ static int snd_timer_s_start(snd_timer_t * timer)
        return 0;
 }
 
-static int snd_timer_s_stop(snd_timer_t * timer)
+static int snd_timer_s_stop(struct snd_timer * timer)
 {
        struct snd_timer_system_private *priv;
        unsigned long jiff;
@@ -1013,7 +1015,7 @@ static int snd_timer_s_stop(snd_timer_t * timer)
        return 0;
 }
 
-static struct _snd_timer_hardware snd_timer_system =
+static struct snd_timer_hardware snd_timer_system =
 {
        .flags =        SNDRV_TIMER_HW_FIRST | SNDRV_TIMER_HW_TASKLET,
        .resolution =   1000000000L / HZ,
@@ -1022,14 +1024,14 @@ static struct _snd_timer_hardware snd_timer_system =
        .stop =         snd_timer_s_stop
 };
 
-static void snd_timer_free_system(snd_timer_t *timer)
+static void snd_timer_free_system(struct snd_timer *timer)
 {
        kfree(timer->private_data);
 }
 
 static int snd_timer_register_system(void)
 {
-       snd_timer_t *timer;
+       struct snd_timer *timer;
        struct snd_timer_system_private *priv;
        int err;
 
@@ -1051,21 +1053,21 @@ static int snd_timer_register_system(void)
        return snd_timer_global_register(timer);
 }
 
+#ifdef CONFIG_PROC_FS
 /*
  *  Info interface
  */
 
-static void snd_timer_proc_read(snd_info_entry_t *entry,
-                               snd_info_buffer_t * buffer)
+static void snd_timer_proc_read(struct snd_info_entry *entry,
+                               struct snd_info_buffer *buffer)
 {
-       unsigned long flags;
-       snd_timer_t *timer;
-       snd_timer_instance_t *ti;
+       struct snd_timer *timer;
+       struct snd_timer_instance *ti;
        struct list_head *p, *q;
 
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        list_for_each(p, &snd_timer_list) {
-               timer = list_entry(p, snd_timer_t, device_list);
+               timer = list_entry(p, struct snd_timer, device_list);
                switch (timer->tmr_class) {
                case SNDRV_TIMER_CLASS_GLOBAL:
                        snd_iprintf(buffer, "G%i: ", timer->tmr_device);
@@ -1092,30 +1094,54 @@ static void snd_timer_proc_read(snd_info_entry_t *entry,
                if (timer->hw.flags & SNDRV_TIMER_HW_SLAVE)
                        snd_iprintf(buffer, " SLAVE");
                snd_iprintf(buffer, "\n");
-               spin_lock_irqsave(&timer->lock, flags);
                list_for_each(q, &timer->open_list_head) {
-                       ti = list_entry(q, snd_timer_instance_t, open_list);
+                       ti = list_entry(q, struct snd_timer_instance, open_list);
                        snd_iprintf(buffer, "  Client %s : %s\n",
                                    ti->owner ? ti->owner : "unknown",
                                    ti->flags & (SNDRV_TIMER_IFLG_START |
                                                 SNDRV_TIMER_IFLG_RUNNING)
                                    ? "running" : "stopped");
                }
-               spin_unlock_irqrestore(&timer->lock, flags);
        }
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
 }
 
+static struct snd_info_entry *snd_timer_proc_entry = NULL;
+
+static void __init snd_timer_proc_init(void)
+{
+       struct snd_info_entry *entry;
+
+       entry = snd_info_create_module_entry(THIS_MODULE, "timers", NULL);
+       if (entry != NULL) {
+               entry->c.text.read = snd_timer_proc_read;
+               if (snd_info_register(entry) < 0) {
+                       snd_info_free_entry(entry);
+                       entry = NULL;
+               }
+       }
+       snd_timer_proc_entry = entry;
+}
+
+static void __exit snd_timer_proc_done(void)
+{
+       snd_info_unregister(snd_timer_proc_entry);
+}
+#else /* !CONFIG_PROC_FS */
+#define snd_timer_proc_init()
+#define snd_timer_proc_done()
+#endif
+
 /*
  *  USER SPACE interface
  */
 
-static void snd_timer_user_interrupt(snd_timer_instance_t *timeri,
+static void snd_timer_user_interrupt(struct snd_timer_instance *timeri,
                                     unsigned long resolution,
                                     unsigned long ticks)
 {
-       snd_timer_user_t *tu = timeri->callback_data;
-       snd_timer_read_t *r;
+       struct snd_timer_user *tu = timeri->callback_data;
+       struct snd_timer_read *r;
        int prev;
 
        spin_lock(&tu->qlock);
@@ -1142,8 +1168,8 @@ static void snd_timer_user_interrupt(snd_timer_instance_t *timeri,
        wake_up(&tu->qchange_sleep);
 }
 
-static void snd_timer_user_append_to_tqueue(snd_timer_user_t *tu,
-                                           snd_timer_tread_t *tread)
+static void snd_timer_user_append_to_tqueue(struct snd_timer_user *tu,
+                                           struct snd_timer_tread *tread)
 {
        if (tu->qused >= tu->queue_size) {
                tu->overrun++;
@@ -1154,13 +1180,13 @@ static void snd_timer_user_append_to_tqueue(snd_timer_user_t *tu,
        }
 }
 
-static void snd_timer_user_ccallback(snd_timer_instance_t *timeri,
-                                    enum sndrv_timer_event event,
+static void snd_timer_user_ccallback(struct snd_timer_instance *timeri,
+                                    int event,
                                     struct timespec *tstamp,
                                     unsigned long resolution)
 {
-       snd_timer_user_t *tu = timeri->callback_data;
-       snd_timer_tread_t r1;
+       struct snd_timer_user *tu = timeri->callback_data;
+       struct snd_timer_tread r1;
 
        if (event >= SNDRV_TIMER_EVENT_START &&
            event <= SNDRV_TIMER_EVENT_PAUSE)
@@ -1177,12 +1203,12 @@ static void snd_timer_user_ccallback(snd_timer_instance_t *timeri,
        wake_up(&tu->qchange_sleep);
 }
 
-static void snd_timer_user_tinterrupt(snd_timer_instance_t *timeri,
+static void snd_timer_user_tinterrupt(struct snd_timer_instance *timeri,
                                      unsigned long resolution,
                                      unsigned long ticks)
 {
-       snd_timer_user_t *tu = timeri->callback_data;
-       snd_timer_tread_t *r, r1;
+       struct snd_timer_user *tu = timeri->callback_data;
+       struct snd_timer_tread *r, r1;
        struct timespec tstamp;
        int prev, append = 0;
 
@@ -1233,17 +1259,17 @@ static void snd_timer_user_tinterrupt(snd_timer_instance_t *timeri,
 
 static int snd_timer_user_open(struct inode *inode, struct file *file)
 {
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
 
        tu = kzalloc(sizeof(*tu), GFP_KERNEL);
        if (tu == NULL)
                return -ENOMEM;
        spin_lock_init(&tu->qlock);
        init_waitqueue_head(&tu->qchange_sleep);
-       init_MUTEX(&tu->tread_sem);
+       mutex_init(&tu->tread_sem);
        tu->ticks = 1;
        tu->queue_size = 128;
-       tu->queue = kmalloc(tu->queue_size * sizeof(snd_timer_read_t),
+       tu->queue = kmalloc(tu->queue_size * sizeof(struct snd_timer_read),
                            GFP_KERNEL);
        if (tu->queue == NULL) {
                kfree(tu);
@@ -1255,7 +1281,7 @@ static int snd_timer_user_open(struct inode *inode, struct file *file)
 
 static int snd_timer_user_release(struct inode *inode, struct file *file)
 {
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
 
        if (file->private_data) {
                tu = file->private_data;
@@ -1270,7 +1296,7 @@ static int snd_timer_user_release(struct inode *inode, struct file *file)
        return 0;
 }
 
-static void snd_timer_user_zero_id(snd_timer_id_t *id)
+static void snd_timer_user_zero_id(struct snd_timer_id *id)
 {
        id->dev_class = SNDRV_TIMER_CLASS_NONE;
        id->dev_sclass = SNDRV_TIMER_SCLASS_NONE;
@@ -1279,7 +1305,7 @@ static void snd_timer_user_zero_id(snd_timer_id_t *id)
        id->subdevice = -1;
 }
 
-static void snd_timer_user_copy_id(snd_timer_id_t *id, snd_timer_t *timer)
+static void snd_timer_user_copy_id(struct snd_timer_id *id, struct snd_timer *timer)
 {
        id->dev_class = timer->tmr_class;
        id->dev_sclass = SNDRV_TIMER_SCLASS_NONE;
@@ -1288,21 +1314,21 @@ static void snd_timer_user_copy_id(snd_timer_id_t *id, snd_timer_t *timer)
        id->subdevice = timer->tmr_subdevice;
 }
 
-static int snd_timer_user_next_device(snd_timer_id_t __user *_tid)
+static int snd_timer_user_next_device(struct snd_timer_id __user *_tid)
 {
-       snd_timer_id_t id;
-       snd_timer_t *timer;
+       struct snd_timer_id id;
+       struct snd_timer *timer;
        struct list_head *p;
 
        if (copy_from_user(&id, _tid, sizeof(id)))
                return -EFAULT;
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        if (id.dev_class < 0) {         /* first item */
                if (list_empty(&snd_timer_list))
                        snd_timer_user_zero_id(&id);
                else {
                        timer = list_entry(snd_timer_list.next,
-                                          snd_timer_t, device_list);
+                                          struct snd_timer, device_list);
                        snd_timer_user_copy_id(&id, timer);
                }
        } else {
@@ -1310,7 +1336,7 @@ static int snd_timer_user_next_device(snd_timer_id_t __user *_tid)
                case SNDRV_TIMER_CLASS_GLOBAL:
                        id.device = id.device < 0 ? 0 : id.device + 1;
                        list_for_each(p, &snd_timer_list) {
-                               timer = list_entry(p, snd_timer_t, device_list);
+                               timer = list_entry(p, struct snd_timer, device_list);
                                if (timer->tmr_class > SNDRV_TIMER_CLASS_GLOBAL) {
                                        snd_timer_user_copy_id(&id, timer);
                                        break;
@@ -1343,7 +1369,7 @@ static int snd_timer_user_next_device(snd_timer_id_t __user *_tid)
                                }
                        }
                        list_for_each(p, &snd_timer_list) {
-                               timer = list_entry(p, snd_timer_t, device_list);
+                               timer = list_entry(p, struct snd_timer, device_list);
                                if (timer->tmr_class > id.dev_class) {
                                        snd_timer_user_copy_id(&id, timer);
                                        break;
@@ -1378,18 +1404,18 @@ static int snd_timer_user_next_device(snd_timer_id_t __user *_tid)
                        snd_timer_user_zero_id(&id);
                }
        }
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
        if (copy_to_user(_tid, &id, sizeof(*_tid)))
                return -EFAULT;
        return 0;
 }
 
 static int snd_timer_user_ginfo(struct file *file,
-                               snd_timer_ginfo_t __user *_ginfo)
+                               struct snd_timer_ginfo __user *_ginfo)
 {
-       snd_timer_ginfo_t *ginfo;
-       snd_timer_id_t tid;
-       snd_timer_t *t;
+       struct snd_timer_ginfo *ginfo;
+       struct snd_timer_id tid;
+       struct snd_timer *t;
        struct list_head *p;
        int err = 0;
 
@@ -1403,7 +1429,7 @@ static int snd_timer_user_ginfo(struct file *file,
        tid = ginfo->tid;
        memset(ginfo, 0, sizeof(*ginfo));
        ginfo->tid = tid;
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        t = snd_timer_find(&tid);
        if (t != NULL) {
                ginfo->card = t->card ? t->card->number : -1;
@@ -1422,7 +1448,7 @@ static int snd_timer_user_ginfo(struct file *file,
        } else {
                err = -ENODEV;
        }
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
        if (err >= 0 && copy_to_user(_ginfo, ginfo, sizeof(*ginfo)))
                err = -EFAULT;
        kfree(ginfo);
@@ -1430,15 +1456,15 @@ static int snd_timer_user_ginfo(struct file *file,
 }
 
 static int snd_timer_user_gparams(struct file *file,
-                                 snd_timer_gparams_t __user *_gparams)
+                                 struct snd_timer_gparams __user *_gparams)
 {
-       snd_timer_gparams_t gparams;
-       snd_timer_t *t;
+       struct snd_timer_gparams gparams;
+       struct snd_timer *t;
        int err;
 
        if (copy_from_user(&gparams, _gparams, sizeof(gparams)))
                return -EFAULT;
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        t = snd_timer_find(&gparams.tid);
        if (!t) {
                err = -ENODEV;
@@ -1454,16 +1480,16 @@ static int snd_timer_user_gparams(struct file *file,
        }
        err = t->hw.set_period(t, gparams.period_num, gparams.period_den);
 _error:
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
        return err;
 }
 
 static int snd_timer_user_gstatus(struct file *file,
-                                 snd_timer_gstatus_t __user *_gstatus)
+                                 struct snd_timer_gstatus __user *_gstatus)
 {
-       snd_timer_gstatus_t gstatus;
-       snd_timer_id_t tid;
-       snd_timer_t *t;
+       struct snd_timer_gstatus gstatus;
+       struct snd_timer_id tid;
+       struct snd_timer *t;
        int err = 0;
 
        if (copy_from_user(&gstatus, _gstatus, sizeof(gstatus)))
@@ -1471,7 +1497,7 @@ static int snd_timer_user_gstatus(struct file *file,
        tid = gstatus.tid;
        memset(&gstatus, 0, sizeof(gstatus));
        gstatus.tid = tid;
-       down(&register_mutex);
+       mutex_lock(&register_mutex);
        t = snd_timer_find(&tid);
        if (t != NULL) {
                if (t->hw.c_resolution)
@@ -1488,22 +1514,22 @@ static int snd_timer_user_gstatus(struct file *file,
        } else {
                err = -ENODEV;
        }
-       up(&register_mutex);
+       mutex_unlock(&register_mutex);
        if (err >= 0 && copy_to_user(_gstatus, &gstatus, sizeof(gstatus)))
                err = -EFAULT;
        return err;
 }
 
 static int snd_timer_user_tselect(struct file *file,
-                                 snd_timer_select_t __user *_tselect)
+                                 struct snd_timer_select __user *_tselect)
 {
-       snd_timer_user_t *tu;
-       snd_timer_select_t tselect;
+       struct snd_timer_user *tu;
+       struct snd_timer_select tselect;
        char str[32];
        int err = 0;
 
        tu = file->private_data;
-       down(&tu->tread_sem);
+       mutex_lock(&tu->tread_sem);
        if (tu->timeri) {
                snd_timer_close(tu->timeri);
                tu->timeri = NULL;
@@ -1524,12 +1550,12 @@ static int snd_timer_user_tselect(struct file *file,
        kfree(tu->tqueue);
        tu->tqueue = NULL;
        if (tu->tread) {
-               tu->tqueue = kmalloc(tu->queue_size * sizeof(snd_timer_tread_t),
+               tu->tqueue = kmalloc(tu->queue_size * sizeof(struct snd_timer_tread),
                                     GFP_KERNEL);
                if (tu->tqueue == NULL)
                        err = -ENOMEM;
        } else {
-               tu->queue = kmalloc(tu->queue_size * sizeof(snd_timer_read_t),
+               tu->queue = kmalloc(tu->queue_size * sizeof(struct snd_timer_read),
                                    GFP_KERNEL);
                if (tu->queue == NULL)
                        err = -ENOMEM;
@@ -1547,16 +1573,16 @@ static int snd_timer_user_tselect(struct file *file,
        }
 
       __err:
-       up(&tu->tread_sem);
+       mutex_unlock(&tu->tread_sem);
        return err;
 }
 
 static int snd_timer_user_info(struct file *file,
-                              snd_timer_info_t __user *_info)
+                              struct snd_timer_info __user *_info)
 {
-       snd_timer_user_t *tu;
-       snd_timer_info_t *info;
-       snd_timer_t *t;
+       struct snd_timer_user *tu;
+       struct snd_timer_info *info;
+       struct snd_timer *t;
        int err = 0;
 
        tu = file->private_data;
@@ -1580,13 +1606,13 @@ static int snd_timer_user_info(struct file *file,
 }
 
 static int snd_timer_user_params(struct file *file,
-                                snd_timer_params_t __user *_params)
+                                struct snd_timer_params __user *_params)
 {
-       snd_timer_user_t *tu;
-       snd_timer_params_t params;
-       snd_timer_t *t;
-       snd_timer_read_t *tr;
-       snd_timer_tread_t *ttr;
+       struct snd_timer_user *tu;
+       struct snd_timer_params params;
+       struct snd_timer *t;
+       struct snd_timer_read *tr;
+       struct snd_timer_tread *ttr;
        int err;
 
        tu = file->private_data;
@@ -1656,14 +1682,14 @@ static int snd_timer_user_params(struct file *file,
        tu->qhead = tu->qtail = tu->qused = 0;
        if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
                if (tu->tread) {
-                       snd_timer_tread_t tread;
+                       struct snd_timer_tread tread;
                        tread.event = SNDRV_TIMER_EVENT_EARLY;
                        tread.tstamp.tv_sec = 0;
                        tread.tstamp.tv_nsec = 0;
                        tread.val = 0;
                        snd_timer_user_append_to_tqueue(tu, &tread);
                } else {
-                       snd_timer_read_t *r = &tu->queue[0];
+                       struct snd_timer_read *r = &tu->queue[0];
                        r->resolution = 0;
                        r->ticks = 0;
                        tu->qused++;
@@ -1680,10 +1706,10 @@ static int snd_timer_user_params(struct file *file,
 }
 
 static int snd_timer_user_status(struct file *file,
-                                snd_timer_status_t __user *_status)
+                                struct snd_timer_status __user *_status)
 {
-       snd_timer_user_t *tu;
-       snd_timer_status_t status;
+       struct snd_timer_user *tu;
+       struct snd_timer_status status;
 
        tu = file->private_data;
        snd_assert(tu->timeri != NULL, return -ENXIO);
@@ -1703,7 +1729,7 @@ static int snd_timer_user_status(struct file *file,
 static int snd_timer_user_start(struct file *file)
 {
        int err;
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
 
        tu = file->private_data;
        snd_assert(tu->timeri != NULL, return -ENXIO);
@@ -1716,7 +1742,7 @@ static int snd_timer_user_start(struct file *file)
 static int snd_timer_user_stop(struct file *file)
 {
        int err;
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
 
        tu = file->private_data;
        snd_assert(tu->timeri != NULL, return -ENXIO);
@@ -1726,7 +1752,7 @@ static int snd_timer_user_stop(struct file *file)
 static int snd_timer_user_continue(struct file *file)
 {
        int err;
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
 
        tu = file->private_data;
        snd_assert(tu->timeri != NULL, return -ENXIO);
@@ -1737,7 +1763,7 @@ static int snd_timer_user_continue(struct file *file)
 static int snd_timer_user_pause(struct file *file)
 {
        int err;
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
 
        tu = file->private_data;
        snd_assert(tu->timeri != NULL, return -ENXIO);
@@ -1754,7 +1780,7 @@ enum {
 static long snd_timer_user_ioctl(struct file *file, unsigned int cmd,
                                 unsigned long arg)
 {
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
        void __user *argp = (void __user *)arg;
        int __user *p = argp;
 
@@ -1768,17 +1794,17 @@ static long snd_timer_user_ioctl(struct file *file, unsigned int cmd,
        {
                int xarg;
 
-               down(&tu->tread_sem);
+               mutex_lock(&tu->tread_sem);
                if (tu->timeri) {       /* too late */
-                       up(&tu->tread_sem);
+                       mutex_unlock(&tu->tread_sem);
                        return -EBUSY;
                }
                if (get_user(xarg, p)) {
-                       up(&tu->tread_sem);
+                       mutex_unlock(&tu->tread_sem);
                        return -EFAULT;
                }
                tu->tread = xarg ? 1 : 0;
-               up(&tu->tread_sem);
+               mutex_unlock(&tu->tread_sem);
                return 0;
        }
        case SNDRV_TIMER_IOCTL_GINFO:
@@ -1813,7 +1839,7 @@ static long snd_timer_user_ioctl(struct file *file, unsigned int cmd,
 
 static int snd_timer_user_fasync(int fd, struct file * file, int on)
 {
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
        int err;
 
        tu = file->private_data;
@@ -1826,12 +1852,12 @@ static int snd_timer_user_fasync(int fd, struct file * file, int on)
 static ssize_t snd_timer_user_read(struct file *file, char __user *buffer,
                                   size_t count, loff_t *offset)
 {
-       snd_timer_user_t *tu;
+       struct snd_timer_user *tu;
        long result = 0, unit;
        int err = 0;
 
        tu = file->private_data;
-       unit = tu->tread ? sizeof(snd_timer_tread_t) : sizeof(snd_timer_read_t);
+       unit = tu->tread ? sizeof(struct snd_timer_tread) : sizeof(struct snd_timer_read);
        spin_lock_irq(&tu->qlock);
        while ((long)count - result >= unit) {
                while (!tu->qused) {
@@ -1864,13 +1890,13 @@ static ssize_t snd_timer_user_read(struct file *file, char __user *buffer,
 
                if (tu->tread) {
                        if (copy_to_user(buffer, &tu->tqueue[tu->qhead++],
-                                        sizeof(snd_timer_tread_t))) {
+                                        sizeof(struct snd_timer_tread))) {
                                err = -EFAULT;
                                goto _error;
                        }
                } else {
                        if (copy_to_user(buffer, &tu->queue[tu->qhead++],
-                                        sizeof(snd_timer_read_t))) {
+                                        sizeof(struct snd_timer_read))) {
                                err = -EFAULT;
                                goto _error;
                        }
@@ -1892,7 +1918,7 @@ static ssize_t snd_timer_user_read(struct file *file, char __user *buffer,
 static unsigned int snd_timer_user_poll(struct file *file, poll_table * wait)
 {
         unsigned int mask;
-        snd_timer_user_t *tu;
+        struct snd_timer_user *tu;
 
         tu = file->private_data;
 
@@ -1923,44 +1949,27 @@ static struct file_operations snd_timer_f_ops =
        .fasync =       snd_timer_user_fasync,
 };
 
-static snd_minor_t snd_timer_reg =
-{
-       .comment =      "timer",
-       .f_ops =        &snd_timer_f_ops,
-};
-
 /*
  *  ENTRY functions
  */
 
-static snd_info_entry_t *snd_timer_proc_entry = NULL;
-
 static int __init alsa_timer_init(void)
 {
        int err;
-       snd_info_entry_t *entry;
 
 #ifdef SNDRV_OSS_INFO_DEV_TIMERS
        snd_oss_info_register(SNDRV_OSS_INFO_DEV_TIMERS, SNDRV_CARDS - 1,
                              "system timer");
 #endif
-       entry = snd_info_create_module_entry(THIS_MODULE, "timers", NULL);
-       if (entry != NULL) {
-               entry->c.text.read_size = SNDRV_TIMER_DEVICES * 128;
-               entry->c.text.read = snd_timer_proc_read;
-               if (snd_info_register(entry) < 0) {
-                       snd_info_free_entry(entry);
-                       entry = NULL;
-               }
-       }
-       snd_timer_proc_entry = entry;
+
        if ((err = snd_timer_register_system()) < 0)
                snd_printk(KERN_ERR "unable to register system timer (%i)\n",
                           err);
-       if ((err = snd_register_device(SNDRV_DEVICE_TYPE_TIMER,
-                                       NULL, 0, &snd_timer_reg, "timer"))<0)
+       if ((err = snd_register_device(SNDRV_DEVICE_TYPE_TIMER, NULL, 0,
+                                      &snd_timer_f_ops, NULL, "timer")) < 0)
                snd_printk(KERN_ERR "unable to register timer device (%i)\n",
                           err);
+       snd_timer_proc_init();
        return 0;
 }
 
@@ -1971,13 +1980,10 @@ static void __exit alsa_timer_exit(void)
        snd_unregister_device(SNDRV_DEVICE_TYPE_TIMER, NULL, 0);
        /* unregister the system timer */
        list_for_each_safe(p, n, &snd_timer_list) {
-               snd_timer_t *timer = list_entry(p, snd_timer_t, device_list);
+               struct snd_timer *timer = list_entry(p, struct snd_timer, device_list);
                snd_timer_unregister(timer);
        }
-       if (snd_timer_proc_entry) {
-               snd_info_unregister(snd_timer_proc_entry);
-               snd_timer_proc_entry = NULL;
-       }
+       snd_timer_proc_done();
 #ifdef SNDRV_OSS_INFO_DEV_TIMERS
        snd_oss_info_unregister(SNDRV_OSS_INFO_DEV_TIMERS, SNDRV_CARDS - 1);
 #endif