Merge git://github.com/rustyrussell/linux
[pandora-kernel.git] / drivers / video / fsl-diu-fb.c
index 3776949..a16beeb 100644 (file)
 #include <linux/clk.h>
 #include <linux/uaccess.h>
 #include <linux/vmalloc.h>
+#include <linux/spinlock.h>
 
 #include <sysdev/fsl_soc.h>
 #include <linux/fsl-diu-fb.h>
 #include "edid.h"
 
+#define FSL_AOI_NUM    6       /* 5 AOIs and one dummy AOI */
+                               /* 1 for plane 0, 2 for plane 1&2 each */
+
+/* HW cursor parameters */
+#define MAX_CURS               32
+
+/* INT_STATUS/INT_MASK field descriptions */
+#define INT_VSYNC      0x01    /* Vsync interrupt  */
+#define INT_VSYNC_WB   0x02    /* Vsync interrupt for write back operation */
+#define INT_UNDRUN     0x04    /* Under run exception interrupt */
+#define INT_PARERR     0x08    /* Display parameters error interrupt */
+#define INT_LS_BF_VS   0x10    /* Lines before vsync. interrupt */
+
+struct diu_addr {
+       void *vaddr;            /* Virtual address */
+       dma_addr_t paddr;       /* Physical address */
+       __u32 offset;
+};
+
 /*
  * List of supported video modes
  *
- * The first entry is the default video mode
+ * The first entry is the default video mode.  The remain entries are in
+ * order if increasing resolution and frequency.  The 320x240-60 mode is
+ * the initial AOI for the second and third planes.
  */
 static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
        {
-               .name           = "1024x768-60",
                .refresh        = 60,
                .xres           = 1024,
                .yres           = 768,
@@ -57,7 +78,132 @@ static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
                .vmode          = FB_VMODE_NONINTERLACED
        },
        {
-               .name           = "1024x768-70",
+               .refresh        = 60,
+               .xres           = 320,
+               .yres           = 240,
+               .pixclock       = 79440,
+               .left_margin    = 16,
+               .right_margin   = 16,
+               .upper_margin   = 16,
+               .lower_margin   = 5,
+               .hsync_len      = 48,
+               .vsync_len      = 1,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 60,
+               .xres           = 640,
+               .yres           = 480,
+               .pixclock       = 39722,
+               .left_margin    = 48,
+               .right_margin   = 16,
+               .upper_margin   = 33,
+               .lower_margin   = 10,
+               .hsync_len      = 96,
+               .vsync_len      = 2,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 72,
+               .xres           = 640,
+               .yres           = 480,
+               .pixclock       = 32052,
+               .left_margin    = 128,
+               .right_margin   = 24,
+               .upper_margin   = 28,
+               .lower_margin   = 9,
+               .hsync_len      = 40,
+               .vsync_len      = 3,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 75,
+               .xres           = 640,
+               .yres           = 480,
+               .pixclock       = 31747,
+               .left_margin    = 120,
+               .right_margin   = 16,
+               .upper_margin   = 16,
+               .lower_margin   = 1,
+               .hsync_len      = 64,
+               .vsync_len      = 3,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 90,
+               .xres           = 640,
+               .yres           = 480,
+               .pixclock       = 25057,
+               .left_margin    = 120,
+               .right_margin   = 32,
+               .upper_margin   = 14,
+               .lower_margin   = 25,
+               .hsync_len      = 40,
+               .vsync_len      = 14,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 100,
+               .xres           = 640,
+               .yres           = 480,
+               .pixclock       = 22272,
+               .left_margin    = 48,
+               .right_margin   = 32,
+               .upper_margin   = 17,
+               .lower_margin   = 22,
+               .hsync_len      = 128,
+               .vsync_len      = 12,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 60,
+               .xres           = 800,
+               .yres           = 480,
+               .pixclock       = 33805,
+               .left_margin    = 96,
+               .right_margin   = 24,
+               .upper_margin   = 10,
+               .lower_margin   = 3,
+               .hsync_len      = 72,
+               .vsync_len      = 7,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 60,
+               .xres           = 800,
+               .yres           = 600,
+               .pixclock       = 25000,
+               .left_margin    = 88,
+               .right_margin   = 40,
+               .upper_margin   = 23,
+               .lower_margin   = 1,
+               .hsync_len      = 128,
+               .vsync_len      = 4,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 60,
+               .xres           = 854,
+               .yres           = 480,
+               .pixclock       = 31518,
+               .left_margin    = 104,
+               .right_margin   = 16,
+               .upper_margin   = 13,
+               .lower_margin   = 1,
+               .hsync_len      = 88,
+               .vsync_len      = 3,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
                .refresh        = 70,
                .xres           = 1024,
                .yres           = 768,
@@ -72,7 +218,6 @@ static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
                .vmode          = FB_VMODE_NONINTERLACED
        },
        {
-               .name           = "1024x768-75",
                .refresh        = 75,
                .xres           = 1024,
                .yres           = 768,
@@ -87,7 +232,34 @@ static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
                .vmode          = FB_VMODE_NONINTERLACED
        },
        {
-               .name           = "1280x1024-60",
+               .refresh        = 60,
+               .xres           = 1280,
+               .yres           = 480,
+               .pixclock       = 18939,
+               .left_margin    = 353,
+               .right_margin   = 47,
+               .upper_margin   = 39,
+               .lower_margin   = 4,
+               .hsync_len      = 8,
+               .vsync_len      = 2,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
+               .refresh        = 60,
+               .xres           = 1280,
+               .yres           = 720,
+               .pixclock       = 13426,
+               .left_margin    = 192,
+               .right_margin   = 64,
+               .upper_margin   = 22,
+               .lower_margin   = 1,
+               .hsync_len      = 136,
+               .vsync_len      = 3,
+               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+               .vmode          = FB_VMODE_NONINTERLACED
+       },
+       {
                .refresh        = 60,
                .xres           = 1280,
                .yres           = 1024,
@@ -102,7 +274,6 @@ static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
                .vmode          = FB_VMODE_NONINTERLACED
        },
        {
-               .name           = "1280x1024-70",
                .refresh        = 70,
                .xres           = 1280,
                .yres           = 1024,
@@ -117,7 +288,6 @@ static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
                .vmode          = FB_VMODE_NONINTERLACED
        },
        {
-               .name           = "1280x1024-75",
                .refresh        = 75,
                .xres           = 1280,
                .yres           = 1024,
@@ -132,38 +302,22 @@ static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
                .vmode          = FB_VMODE_NONINTERLACED
        },
        {
-               .name           = "320x240",            /* for AOI only */
-               .refresh        = 60,
-               .xres           = 320,
-               .yres           = 240,
-               .pixclock       = 15385,
-               .left_margin    = 0,
-               .right_margin   = 0,
-               .upper_margin   = 0,
-               .lower_margin   = 0,
-               .hsync_len      = 0,
-               .vsync_len      = 0,
-               .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
-               .vmode          = FB_VMODE_NONINTERLACED
-       },
-       {
-               .name           = "1280x480-60",
                .refresh        = 60,
-               .xres           = 1280,
-               .yres           = 480,
-               .pixclock       = 18939,
-               .left_margin    = 353,
-               .right_margin   = 47,
-               .upper_margin   = 39,
-               .lower_margin   = 4,
-               .hsync_len      = 8,
-               .vsync_len      = 2,
+               .xres           = 1920,
+               .yres           = 1080,
+               .pixclock       = 5787,
+               .left_margin    = 328,
+               .right_margin   = 120,
+               .upper_margin   = 34,
+               .lower_margin   = 1,
+               .hsync_len      = 208,
+               .vsync_len      = 3,
                .sync           = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
                .vmode          = FB_VMODE_NONINTERLACED
        },
 };
 
-static char *fb_mode = "1024x768-32@60";
+static char *fb_mode;
 static unsigned long default_bpp = 32;
 static enum fsl_diu_monitor_port monitor_port;
 static char *monitor_string;
@@ -185,14 +339,26 @@ struct fsl_diu_data {
        unsigned int irq;
        int fb_enabled;
        enum fsl_diu_monitor_port monitor_port;
+       struct diu __iomem *diu_reg;
+       spinlock_t reg_lock;
+       struct diu_addr ad;
+       struct diu_addr gamma;
+       struct diu_addr pallete;
+       struct diu_addr cursor;
+};
+
+enum mfb_index {
+       PLANE0 = 0,     /* Plane 0, only one AOI that fills the screen */
+       PLANE1_AOI0,    /* Plane 1, first AOI */
+       PLANE1_AOI1,    /* Plane 1, second AOI */
+       PLANE2_AOI0,    /* Plane 2, first AOI */
+       PLANE2_AOI1,    /* Plane 2, second AOI */
 };
 
 struct mfb_info {
-       int index;
-       int type;
+       enum mfb_index index;
        char *id;
        int registered;
-       int blank;
        unsigned long pseudo_palette[16];
        struct diu_ad *ad;
        int cursor_reset;
@@ -206,18 +372,16 @@ struct mfb_info {
 
 
 static struct mfb_info mfb_template[] = {
-       {               /* AOI 0 for plane 0 */
-               .index = 0,
-               .type = MFB_TYPE_OUTPUT,
+       {
+               .index = PLANE0,
                .id = "Panel0",
                .registered = 0,
                .count = 0,
                .x_aoi_d = 0,
                .y_aoi_d = 0,
        },
-       {               /* AOI 0 for plane 1 */
-               .index = 1,
-               .type = MFB_TYPE_OUTPUT,
+       {
+               .index = PLANE1_AOI0,
                .id = "Panel1 AOI0",
                .registered = 0,
                .g_alpha = 0xff,
@@ -225,9 +389,8 @@ static struct mfb_info mfb_template[] = {
                .x_aoi_d = 0,
                .y_aoi_d = 0,
        },
-       {               /* AOI 1 for plane 1 */
-               .index = 2,
-               .type = MFB_TYPE_OUTPUT,
+       {
+               .index = PLANE1_AOI1,
                .id = "Panel1 AOI1",
                .registered = 0,
                .g_alpha = 0xff,
@@ -235,9 +398,8 @@ static struct mfb_info mfb_template[] = {
                .x_aoi_d = 0,
                .y_aoi_d = 480,
        },
-       {               /* AOI 0 for plane 2 */
-               .index = 3,
-               .type = MFB_TYPE_OUTPUT,
+       {
+               .index = PLANE2_AOI0,
                .id = "Panel2 AOI0",
                .registered = 0,
                .g_alpha = 0xff,
@@ -245,9 +407,8 @@ static struct mfb_info mfb_template[] = {
                .x_aoi_d = 640,
                .y_aoi_d = 0,
        },
-       {               /* AOI 1 for plane 2 */
-               .index = 4,
-               .type = MFB_TYPE_OUTPUT,
+       {
+               .index = PLANE2_AOI1,
                .id = "Panel2 AOI1",
                .registered = 0,
                .g_alpha = 0xff,
@@ -257,13 +418,6 @@ static struct mfb_info mfb_template[] = {
        },
 };
 
-static struct diu_hw dr = {
-       .mode = MFB_MODE1,
-       .reg_lock = __SPIN_LOCK_UNLOCKED(diu_hw.reg_lock),
-};
-
-static struct diu_pool pool;
-
 /**
  * fsl_diu_name_to_port - convert a port name to a monitor port enum
  *
@@ -337,81 +491,72 @@ void wr_reg_wa(u32 *reg, u32 val)
        } while (in_be32(reg) != val);
 }
 
-static int fsl_diu_enable_panel(struct fb_info *info)
+static void fsl_diu_enable_panel(struct fb_info *info)
 {
        struct mfb_info *pmfbi, *cmfbi, *mfbi = info->par;
-       struct diu *hw = dr.diu_reg;
        struct diu_ad *ad = mfbi->ad;
        struct fsl_diu_data *machine_data = mfbi->parent;
-       int res = 0;
+       struct diu __iomem *hw = machine_data->diu_reg;
 
-       if (mfbi->type != MFB_TYPE_OFF) {
-               switch (mfbi->index) {
-               case 0:                         /* plane 0 */
-                       if (hw->desc[0] != ad->paddr)
-                               wr_reg_wa(&hw->desc[0], ad->paddr);
-                       break;
-               case 1:                         /* plane 1 AOI 0 */
-                       cmfbi = machine_data->fsl_diu_info[2]->par;
-                       if (hw->desc[1] != ad->paddr) { /* AOI0 closed */
-                               if (cmfbi->count > 0)   /* AOI1 open */
-                                       ad->next_ad =
-                                               cpu_to_le32(cmfbi->ad->paddr);
-                               else
-                                       ad->next_ad = 0;
-                               wr_reg_wa(&hw->desc[1], ad->paddr);
-                       }
-                       break;
-               case 3:                         /* plane 2 AOI 0 */
-                       cmfbi = machine_data->fsl_diu_info[4]->par;
-                       if (hw->desc[2] != ad->paddr) { /* AOI0 closed */
-                               if (cmfbi->count > 0)   /* AOI1 open */
-                                       ad->next_ad =
-                                               cpu_to_le32(cmfbi->ad->paddr);
-                               else
-                                       ad->next_ad = 0;
-                               wr_reg_wa(&hw->desc[2], ad->paddr);
-                       }
-                       break;
-               case 2:                         /* plane 1 AOI 1 */
-                       pmfbi = machine_data->fsl_diu_info[1]->par;
-                       ad->next_ad = 0;
-                       if (hw->desc[1] == machine_data->dummy_ad->paddr)
-                               wr_reg_wa(&hw->desc[1], ad->paddr);
-                       else                                    /* AOI0 open */
-                               pmfbi->ad->next_ad = cpu_to_le32(ad->paddr);
-                       break;
-               case 4:                         /* plane 2 AOI 1 */
-                       pmfbi = machine_data->fsl_diu_info[3]->par;
-                       ad->next_ad = 0;
-                       if (hw->desc[2] == machine_data->dummy_ad->paddr)
-                               wr_reg_wa(&hw->desc[2], ad->paddr);
-                       else                            /* AOI0 was open */
-                               pmfbi->ad->next_ad = cpu_to_le32(ad->paddr);
-                       break;
-               default:
-                       res = -EINVAL;
-                       break;
+       switch (mfbi->index) {
+       case PLANE0:
+               if (hw->desc[0] != ad->paddr)
+                       wr_reg_wa(&hw->desc[0], ad->paddr);
+               break;
+       case PLANE1_AOI0:
+               cmfbi = machine_data->fsl_diu_info[2]->par;
+               if (hw->desc[1] != ad->paddr) { /* AOI0 closed */
+                       if (cmfbi->count > 0)   /* AOI1 open */
+                               ad->next_ad =
+                                       cpu_to_le32(cmfbi->ad->paddr);
+                       else
+                               ad->next_ad = 0;
+                       wr_reg_wa(&hw->desc[1], ad->paddr);
                }
-       } else
-               res = -EINVAL;
-       return res;
+               break;
+       case PLANE2_AOI0:
+               cmfbi = machine_data->fsl_diu_info[4]->par;
+               if (hw->desc[2] != ad->paddr) { /* AOI0 closed */
+                       if (cmfbi->count > 0)   /* AOI1 open */
+                               ad->next_ad =
+                                       cpu_to_le32(cmfbi->ad->paddr);
+                       else
+                               ad->next_ad = 0;
+                       wr_reg_wa(&hw->desc[2], ad->paddr);
+               }
+               break;
+       case PLANE1_AOI1:
+               pmfbi = machine_data->fsl_diu_info[1]->par;
+               ad->next_ad = 0;
+               if (hw->desc[1] == machine_data->dummy_ad->paddr)
+                       wr_reg_wa(&hw->desc[1], ad->paddr);
+               else                                    /* AOI0 open */
+                       pmfbi->ad->next_ad = cpu_to_le32(ad->paddr);
+               break;
+       case PLANE2_AOI1:
+               pmfbi = machine_data->fsl_diu_info[3]->par;
+               ad->next_ad = 0;
+               if (hw->desc[2] == machine_data->dummy_ad->paddr)
+                       wr_reg_wa(&hw->desc[2], ad->paddr);
+               else                            /* AOI0 was open */
+                       pmfbi->ad->next_ad = cpu_to_le32(ad->paddr);
+               break;
+       }
 }
 
-static int fsl_diu_disable_panel(struct fb_info *info)
+static void fsl_diu_disable_panel(struct fb_info *info)
 {
        struct mfb_info *pmfbi, *cmfbi, *mfbi = info->par;
-       struct diu *hw = dr.diu_reg;
        struct diu_ad *ad = mfbi->ad;
        struct fsl_diu_data *machine_data = mfbi->parent;
-       int res = 0;
+       struct diu __iomem *hw = machine_data->diu_reg;
 
        switch (mfbi->index) {
-       case 0:                                 /* plane 0 */
+       case PLANE0:
                if (hw->desc[0] != machine_data->dummy_ad->paddr)
                        wr_reg_wa(&hw->desc[0], machine_data->dummy_ad->paddr);
                break;
-       case 1:                                 /* plane 1 AOI 0 */
+       case PLANE1_AOI0:
                cmfbi = machine_data->fsl_diu_info[2]->par;
                if (cmfbi->count > 0)   /* AOI1 is open */
                        wr_reg_wa(&hw->desc[1], cmfbi->ad->paddr);
@@ -420,7 +565,7 @@ static int fsl_diu_disable_panel(struct fb_info *info)
                        wr_reg_wa(&hw->desc[1], machine_data->dummy_ad->paddr);
                                        /* close AOI 0 */
                break;
-       case 3:                                 /* plane 2 AOI 0 */
+       case PLANE2_AOI0:
                cmfbi = machine_data->fsl_diu_info[4]->par;
                if (cmfbi->count > 0)   /* AOI1 is open */
                        wr_reg_wa(&hw->desc[2], cmfbi->ad->paddr);
@@ -429,7 +574,7 @@ static int fsl_diu_disable_panel(struct fb_info *info)
                        wr_reg_wa(&hw->desc[2], machine_data->dummy_ad->paddr);
                                        /* close AOI 0 */
                break;
-       case 2:                                 /* plane 1 AOI 1 */
+       case PLANE1_AOI1:
                pmfbi = machine_data->fsl_diu_info[1]->par;
                if (hw->desc[1] != ad->paddr) {
                                /* AOI1 is not the first in the chain */
@@ -440,7 +585,7 @@ static int fsl_diu_disable_panel(struct fb_info *info)
                        wr_reg_wa(&hw->desc[1], machine_data->dummy_ad->paddr);
                                        /* close AOI 1 */
                break;
-       case 4:                                 /* plane 2 AOI 1 */
+       case PLANE2_AOI1:
                pmfbi = machine_data->fsl_diu_info[3]->par;
                if (hw->desc[2] != ad->paddr) {
                                /* AOI1 is not the first in the chain */
@@ -451,31 +596,26 @@ static int fsl_diu_disable_panel(struct fb_info *info)
                        wr_reg_wa(&hw->desc[2], machine_data->dummy_ad->paddr);
                                /* close AOI 1 */
                break;
-       default:
-               res = -EINVAL;
-               break;
        }
-
-       return res;
 }
 
 static void enable_lcdc(struct fb_info *info)
 {
-       struct diu *hw = dr.diu_reg;
        struct mfb_info *mfbi = info->par;
        struct fsl_diu_data *machine_data = mfbi->parent;
+       struct diu __iomem *hw = machine_data->diu_reg;
 
        if (!machine_data->fb_enabled) {
-               out_be32(&hw->diu_mode, dr.mode);
+               out_be32(&hw->diu_mode, MFB_MODE1);
                machine_data->fb_enabled++;
        }
 }
 
 static void disable_lcdc(struct fb_info *info)
 {
-       struct diu *hw = dr.diu_reg;
        struct mfb_info *mfbi = info->par;
        struct fsl_diu_data *machine_data = mfbi->parent;
+       struct diu __iomem *hw = machine_data->diu_reg;
 
        if (machine_data->fb_enabled) {
                out_be32(&hw->diu_mode, 0);
@@ -488,7 +628,8 @@ static void adjust_aoi_size_position(struct fb_var_screeninfo *var,
 {
        struct mfb_info *lower_aoi_mfbi, *upper_aoi_mfbi, *mfbi = info->par;
        struct fsl_diu_data *machine_data = mfbi->parent;
-       int available_height, upper_aoi_bottom, index = mfbi->index;
+       int available_height, upper_aoi_bottom;
+       enum mfb_index index = mfbi->index;
        int lower_aoi_is_open, upper_aoi_is_open;
        __u32 base_plane_width, base_plane_height, upper_aoi_height;
 
@@ -500,14 +641,14 @@ static void adjust_aoi_size_position(struct fb_var_screeninfo *var,
        if (mfbi->y_aoi_d < 0)
                mfbi->y_aoi_d = 0;
        switch (index) {
-       case 0:
+       case PLANE0:
                if (mfbi->x_aoi_d != 0)
                        mfbi->x_aoi_d = 0;
                if (mfbi->y_aoi_d != 0)
                        mfbi->y_aoi_d = 0;
                break;
-       case 1:                 /* AOI 0 */
-       case 3:
+       case PLANE1_AOI0:
+       case PLANE2_AOI0:
                lower_aoi_mfbi = machine_data->fsl_diu_info[index+1]->par;
                lower_aoi_is_open = lower_aoi_mfbi->count > 0 ? 1 : 0;
                if (var->xres > base_plane_width)
@@ -524,8 +665,8 @@ static void adjust_aoi_size_position(struct fb_var_screeninfo *var,
                if ((mfbi->y_aoi_d + var->yres) > available_height)
                        mfbi->y_aoi_d = available_height - var->yres;
                break;
-       case 2:                 /* AOI 1 */
-       case 4:
+       case PLANE1_AOI1:
+       case PLANE2_AOI1:
                upper_aoi_mfbi = machine_data->fsl_diu_info[index-1]->par;
                upper_aoi_height =
                                machine_data->fsl_diu_info[index-1]->var.yres;
@@ -669,36 +810,32 @@ static void update_lcdc(struct fb_info *info)
        struct fb_var_screeninfo *var = &info->var;
        struct mfb_info *mfbi = info->par;
        struct fsl_diu_data *machine_data = mfbi->parent;
-       struct diu *hw;
+       struct diu __iomem *hw;
        int i, j;
        char __iomem *cursor_base, *gamma_table_base;
 
        u32 temp;
 
-       hw = dr.diu_reg;
-
-       if (mfbi->type == MFB_TYPE_OFF) {
-               fsl_diu_disable_panel(info);
-               return;
-       }
+       hw = machine_data->diu_reg;
 
        diu_ops.set_monitor_port(machine_data->monitor_port);
-       gamma_table_base = pool.gamma.vaddr;
-       cursor_base = pool.cursor.vaddr;
+       gamma_table_base = machine_data->gamma.vaddr;
+       cursor_base = machine_data->cursor.vaddr;
        /* Prep for DIU init  - gamma table, cursor table */
 
        for (i = 0; i <= 2; i++)
                for (j = 0; j <= 255; j++)
                        *gamma_table_base++ = j;
 
-       diu_ops.set_gamma_table(machine_data->monitor_port, pool.gamma.vaddr);
+       diu_ops.set_gamma_table(machine_data->monitor_port,
+                               machine_data->gamma.vaddr);
 
        disable_lcdc(info);
 
        /* Program DIU registers */
 
-       out_be32(&hw->gamma, pool.gamma.paddr);
-       out_be32(&hw->cursor, pool.cursor.paddr);
+       out_be32(&hw->gamma, machine_data->gamma.paddr);
+       out_be32(&hw->cursor, machine_data->cursor.paddr);
 
        out_be32(&hw->bgnd, 0x007F7F7F);        /* BGND */
        out_be32(&hw->bgnd_wb, 0);              /* BGND_WB */
@@ -791,9 +928,9 @@ static int fsl_diu_set_par(struct fb_info *info)
        struct mfb_info *mfbi = info->par;
        struct fsl_diu_data *machine_data = mfbi->parent;
        struct diu_ad *ad = mfbi->ad;
-       struct diu *hw;
+       struct diu __iomem *hw;
 
-       hw = dr.diu_reg;
+       hw = machine_data->diu_reg;
 
        set_fix(info);
        mfbi->cursor_reset = 1;
@@ -830,7 +967,7 @@ static int fsl_diu_set_par(struct fb_info *info)
        ad->ckmin_g = 255;
        ad->ckmin_b = 255;
 
-       if (mfbi->index == 0)
+       if (mfbi->index == PLANE0)
                update_lcdc(info);
        return 0;
 }
@@ -921,37 +1058,6 @@ static int fsl_diu_pan_display(struct fb_var_screeninfo *var,
        return 0;
 }
 
-/*
- * Blank the screen if blank_mode != 0, else unblank. Return 0 if blanking
- * succeeded, != 0 if un-/blanking failed.
- * blank_mode == 2: suspend vsync
- * blank_mode == 3: suspend hsync
- * blank_mode == 4: powerdown
- */
-static int fsl_diu_blank(int blank_mode, struct fb_info *info)
-{
-       struct mfb_info *mfbi = info->par;
-
-       mfbi->blank = blank_mode;
-
-       switch (blank_mode) {
-       case FB_BLANK_VSYNC_SUSPEND:
-       case FB_BLANK_HSYNC_SUSPEND:
-       /* FIXME: fixes to enable_panel and enable lcdc needed */
-       case FB_BLANK_NORMAL:
-       /*      fsl_diu_disable_panel(info);*/
-               break;
-       case FB_BLANK_POWERDOWN:
-       /*      disable_lcdc(info);     */
-               break;
-       case FB_BLANK_UNBLANK:
-       /*      fsl_diu_enable_panel(info);*/
-               break;
-       }
-
-       return 0;
-}
-
 static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
                       unsigned long arg)
 {
@@ -966,11 +1072,19 @@ static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
        if (!arg)
                return -EINVAL;
        switch (cmd) {
+       case MFB_SET_PIXFMT_OLD:
+               dev_warn(info->dev,
+                        "MFB_SET_PIXFMT value of 0x%08x is deprecated.\n",
+                        MFB_SET_PIXFMT_OLD);
        case MFB_SET_PIXFMT:
                if (copy_from_user(&pix_fmt, buf, sizeof(pix_fmt)))
                        return -EFAULT;
                ad->pix_fmt = pix_fmt;
                break;
+       case MFB_GET_PIXFMT_OLD:
+               dev_warn(info->dev,
+                        "MFB_GET_PIXFMT value of 0x%08x is deprecated.\n",
+                        MFB_GET_PIXFMT_OLD);
        case MFB_GET_PIXFMT:
                pix_fmt = ad->pix_fmt;
                if (copy_to_user(buf, &pix_fmt, sizeof(pix_fmt)))
@@ -1030,14 +1144,6 @@ static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
                        ad->ckmin_b = ck.blue_min;
                }
                break;
-       case FBIOGET_GWINFO:
-               if (mfbi->type == MFB_TYPE_OFF)
-                       return -ENODEV;
-               /* get graphic window information */
-               if (copy_to_user(buf, ad, sizeof(*ad)))
-                       return -EFAULT;
-               break;
-
        default:
                dev_err(info->dev, "unknown ioctl command (0x%08X)\n", cmd);
                return -ENOIOCTLCMD;
@@ -1054,7 +1160,7 @@ static int fsl_diu_open(struct fb_info *info, int user)
        int res = 0;
 
        /* free boot splash memory on first /dev/fb0 open */
-       if (!mfbi->index && diu_ops.release_bootmem)
+       if ((mfbi->index == PLANE0) && diu_ops.release_bootmem)
                diu_ops.release_bootmem();
 
        spin_lock(&diu_lock);
@@ -1064,11 +1170,8 @@ static int fsl_diu_open(struct fb_info *info, int user)
                res = fsl_diu_set_par(info);
                if (res < 0)
                        mfbi->count--;
-               else {
-                       res = fsl_diu_enable_panel(info);
-                       if (res < 0)
-                               mfbi->count--;
-               }
+               else
+                       fsl_diu_enable_panel(info);
        }
 
        spin_unlock(&diu_lock);
@@ -1084,11 +1187,9 @@ static int fsl_diu_release(struct fb_info *info, int user)
 
        spin_lock(&diu_lock);
        mfbi->count--;
-       if (mfbi->count == 0) {
-               res = fsl_diu_disable_panel(info);
-               if (res < 0)
-                       mfbi->count++;
-       }
+       if (mfbi->count == 0)
+               fsl_diu_disable_panel(info);
+
        spin_unlock(&diu_lock);
        return res;
 }
@@ -1098,7 +1199,6 @@ static struct fb_ops fsl_diu_ops = {
        .fb_check_var = fsl_diu_check_var,
        .fb_set_par = fsl_diu_set_par,
        .fb_setcolreg = fsl_diu_setcolreg,
-       .fb_blank = fsl_diu_blank,
        .fb_pan_display = fsl_diu_pan_display,
        .fb_fillrect = cfb_fillrect,
        .fb_copyarea = cfb_copyarea,
@@ -1135,7 +1235,7 @@ static int __devinit install_fb(struct fb_info *info)
        if (init_fbinfo(info))
                return -EINVAL;
 
-       if (mfbi->index == 0) { /* plane 0 */
+       if (mfbi->index == PLANE0) {
                if (mfbi->edid_data) {
                        /* Now build modedb from EDID */
                        fb_edid_to_monspecs(mfbi->edid_data, &info->monspecs);
@@ -1156,7 +1256,7 @@ static int __devinit install_fb(struct fb_info *info)
                 * For plane 0 we continue and look into
                 * driver's internal modedb.
                 */
-               if (mfbi->index == 0 && mfbi->edid_data)
+               if ((mfbi->index == PLANE0) && mfbi->edid_data)
                        has_default_mode = 0;
                else
                        return -EINVAL;
@@ -1193,13 +1293,9 @@ static int __devinit install_fb(struct fb_info *info)
                fb_videomode_to_var(&info->var, modedb);
        }
 
-       if (mfbi->type == MFB_TYPE_OFF)
-               mfbi->blank = FB_BLANK_NORMAL;
-       else
-               mfbi->blank = FB_BLANK_UNBLANK;
-
        if (fsl_diu_check_var(&info->var, info)) {
                dev_err(info->dev, "fsl_diu_check_var failed\n");
+               unmap_video_memory(info);
                fb_dealloc_cmap(&info->cmap);
                return -EINVAL;
        }
@@ -1224,7 +1320,7 @@ static void uninstall_fb(struct fb_info *info)
        if (!mfbi->registered)
                return;
 
-       if (mfbi->index == 0)
+       if (mfbi->index == PLANE0)
                kfree(mfbi->edid_data);
 
        unregister_framebuffer(info);
@@ -1237,7 +1333,7 @@ static void uninstall_fb(struct fb_info *info)
 
 static irqreturn_t fsl_diu_isr(int irq, void *dev_id)
 {
-       struct diu *hw = dr.diu_reg;
+       struct diu __iomem *hw = dev_id;
        unsigned int status = in_be32(&hw->int_status);
 
        if (status) {
@@ -1263,27 +1359,22 @@ static irqreturn_t fsl_diu_isr(int irq, void *dev_id)
        return IRQ_NONE;
 }
 
-static int request_irq_local(int irq)
+static int request_irq_local(struct fsl_diu_data *machine_data)
 {
+       struct diu __iomem *hw = machine_data->diu_reg;
        u32 ints;
-       struct diu *hw;
        int ret;
 
-       hw = dr.diu_reg;
-
        /* Read to clear the status */
        in_be32(&hw->int_status);
 
-       ret = request_irq(irq, fsl_diu_isr, 0, "fsl-diu-fb", NULL);
+       ret = request_irq(machine_data->irq, fsl_diu_isr, 0, "fsl-diu-fb", hw);
        if (!ret) {
                ints = INT_PARERR | INT_LS_BF_VS;
 #if !defined(CONFIG_NOT_COHERENT_CACHE)
                ints |= INT_VSYNC;
 #endif
 
-               if (dr.mode == MFB_MODE2 || dr.mode == MFB_MODE3)
-                       ints |= INT_VSYNC_WB;
-
                /* Read to clear the status */
                in_be32(&hw->int_status);
                out_be32(&hw->int_mask, ints);
@@ -1292,14 +1383,14 @@ static int request_irq_local(int irq)
        return ret;
 }
 
-static void free_irq_local(int irq)
+static void free_irq_local(struct fsl_diu_data *machine_data)
 {
-       struct diu *hw = dr.diu_reg;
+       struct diu __iomem *hw = machine_data->diu_reg;
 
        /* Disable all LCDC interrupt */
        out_be32(&hw->int_mask, 0x1f);
 
-       free_irq(irq, NULL);
+       free_irq(machine_data->irq, NULL);
 }
 
 #ifdef CONFIG_PM
@@ -1417,6 +1508,8 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
        if (!machine_data)
                return -ENOMEM;
 
+       spin_lock_init(&machine_data->reg_lock);
+
        for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++) {
                machine_data->fsl_diu_info[i] =
                        framebuffer_alloc(sizeof(struct mfb_info), &pdev->dev);
@@ -1429,7 +1522,7 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
                memcpy(mfbi, &mfb_template[i], sizeof(struct mfb_info));
                mfbi->parent = machine_data;
 
-               if (mfbi->index == 0) {
+               if (mfbi->index == PLANE0) {
                        const u8 *prop;
                        int len;
 
@@ -1441,16 +1534,16 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
                }
        }
 
-       dr.diu_reg = of_iomap(np, 0);
-       if (!dr.diu_reg) {
+       machine_data->diu_reg = of_iomap(np, 0);
+       if (!machine_data->diu_reg) {
                dev_err(&pdev->dev, "cannot map DIU registers\n");
                ret = -EFAULT;
                goto error2;
        }
 
-       diu_mode = in_be32(&dr.diu_reg->diu_mode);
-       if (diu_mode != MFB_MODE1)
-               out_be32(&dr.diu_reg->diu_mode, 0);     /* disable DIU */
+       diu_mode = in_be32(&machine_data->diu_reg->diu_mode);
+       if (diu_mode == MFB_MODE0)
+               out_be32(&machine_data->diu_reg->diu_mode, 0); /* disable DIU */
 
        /* Get the IRQ of the DIU */
        machine_data->irq = irq_of_parse_and_map(np, 0);
@@ -1463,27 +1556,27 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
        machine_data->monitor_port = monitor_port;
 
        /* Area descriptor memory pool aligns to 64-bit boundary */
-       if (allocate_buf(&pdev->dev, &pool.ad,
+       if (allocate_buf(&pdev->dev, &machine_data->ad,
                         sizeof(struct diu_ad) * FSL_AOI_NUM, 8))
                return -ENOMEM;
 
        /* Get memory for Gamma Table  - 32-byte aligned memory */
-       if (allocate_buf(&pdev->dev, &pool.gamma, 768, 32)) {
+       if (allocate_buf(&pdev->dev, &machine_data->gamma, 768, 32)) {
                ret = -ENOMEM;
                goto error;
        }
 
        /* For performance, cursor bitmap buffer aligns to 32-byte boundary */
-       if (allocate_buf(&pdev->dev, &pool.cursor, MAX_CURS * MAX_CURS * 2,
-                        32)) {
+       if (allocate_buf(&pdev->dev, &machine_data->cursor,
+                        MAX_CURS * MAX_CURS * 2, 32)) {
                ret = -ENOMEM;
                goto error;
        }
 
        i = ARRAY_SIZE(machine_data->fsl_diu_info);
-       machine_data->dummy_ad = (struct diu_ad *)
-                       ((u32)pool.ad.vaddr + pool.ad.offset) + i;
-       machine_data->dummy_ad->paddr = pool.ad.paddr +
+       machine_data->dummy_ad = (struct diu_ad *)((u32)machine_data->ad.vaddr +
+                       machine_data->ad.offset) + i;
+       machine_data->dummy_ad->paddr = machine_data->ad.paddr +
                        i * sizeof(struct diu_ad);
        machine_data->dummy_aoi_virt = fsl_diu_alloc(64, &dummy_ad_addr);
        if (!machine_data->dummy_aoi_virt) {
@@ -1502,18 +1595,20 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
         * Let DIU display splash screen if it was pre-initialized
         * by the bootloader, set dummy area descriptor otherwise.
         */
-       if (diu_mode != MFB_MODE1)
-               out_be32(&dr.diu_reg->desc[0], machine_data->dummy_ad->paddr);
+       if (diu_mode == MFB_MODE0)
+               out_be32(&machine_data->diu_reg->desc[0],
+                        machine_data->dummy_ad->paddr);
 
-       out_be32(&dr.diu_reg->desc[1], machine_data->dummy_ad->paddr);
-       out_be32(&dr.diu_reg->desc[2], machine_data->dummy_ad->paddr);
+       out_be32(&machine_data->diu_reg->desc[1], machine_data->dummy_ad->paddr);
+       out_be32(&machine_data->diu_reg->desc[2], machine_data->dummy_ad->paddr);
 
        for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++) {
                machine_data->fsl_diu_info[i]->fix.smem_start = 0;
                mfbi = machine_data->fsl_diu_info[i]->par;
-               mfbi->ad = (struct diu_ad *)((u32)pool.ad.vaddr
-                                       + pool.ad.offset) + i;
-               mfbi->ad->paddr = pool.ad.paddr + i * sizeof(struct diu_ad);
+               mfbi->ad = (struct diu_ad *)((u32)machine_data->ad.vaddr
+                                       + machine_data->ad.offset) + i;
+               mfbi->ad->paddr =
+                       machine_data->ad.paddr + i * sizeof(struct diu_ad);
                ret = install_fb(machine_data->fsl_diu_info[i]);
                if (ret) {
                        dev_err(&pdev->dev, "could not register fb %d\n", i);
@@ -1521,7 +1616,7 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
                }
        }
 
-       if (request_irq_local(machine_data->irq)) {
+       if (request_irq_local(machine_data)) {
                dev_err(&pdev->dev, "could not claim irq\n");
                goto error;
        }
@@ -1542,20 +1637,20 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
        return 0;
 
 error:
-       for (i = ARRAY_SIZE(machine_data->fsl_diu_info);
-               i > 0; i--)
-               uninstall_fb(machine_data->fsl_diu_info[i - 1]);
-       if (pool.ad.vaddr)
-               free_buf(&pdev->dev, &pool.ad,
+       for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++)
+               uninstall_fb(machine_data->fsl_diu_info[i]);
+
+       if (machine_data->ad.vaddr)
+               free_buf(&pdev->dev, &machine_data->ad,
                         sizeof(struct diu_ad) * FSL_AOI_NUM, 8);
-       if (pool.gamma.vaddr)
-               free_buf(&pdev->dev, &pool.gamma, 768, 32);
-       if (pool.cursor.vaddr)
-               free_buf(&pdev->dev, &pool.cursor, MAX_CURS * MAX_CURS * 2,
-                        32);
+       if (machine_data->gamma.vaddr)
+               free_buf(&pdev->dev, &machine_data->gamma, 768, 32);
+       if (machine_data->cursor.vaddr)
+               free_buf(&pdev->dev, &machine_data->cursor,
+                        MAX_CURS * MAX_CURS * 2, 32);
        if (machine_data->dummy_aoi_virt)
                fsl_diu_free(machine_data->dummy_aoi_virt, 64);
-       iounmap(dr.diu_reg);
+       iounmap(machine_data->diu_reg);
 
 error2:
        for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++)
@@ -1573,19 +1668,20 @@ static int fsl_diu_remove(struct platform_device *pdev)
 
        machine_data = dev_get_drvdata(&pdev->dev);
        disable_lcdc(machine_data->fsl_diu_info[0]);
-       free_irq_local(machine_data->irq);
-       for (i = ARRAY_SIZE(machine_data->fsl_diu_info); i > 0; i--)
-               uninstall_fb(machine_data->fsl_diu_info[i - 1]);
-       if (pool.ad.vaddr)
-               free_buf(&pdev->dev, &pool.ad,
+       free_irq_local(machine_data);
+       for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++)
+               uninstall_fb(machine_data->fsl_diu_info[i]);
+       if (machine_data->ad.vaddr)
+               free_buf(&pdev->dev, &machine_data->ad,
                         sizeof(struct diu_ad) * FSL_AOI_NUM, 8);
-       if (pool.gamma.vaddr)
-               free_buf(&pdev->dev, &pool.gamma, 768, 32);
-       if (pool.cursor.vaddr)
-               free_buf(&pdev->dev, &pool.cursor, MAX_CURS * MAX_CURS * 2, 32);
+       if (machine_data->gamma.vaddr)
+               free_buf(&pdev->dev, &machine_data->gamma, 768, 32);
+       if (machine_data->cursor.vaddr)
+               free_buf(&pdev->dev, &machine_data->cursor,
+                        MAX_CURS * MAX_CURS * 2, 32);
        if (machine_data->dummy_aoi_virt)
                fsl_diu_free(machine_data->dummy_aoi_virt, 64);
-       iounmap(dr.diu_reg);
+       iounmap(machine_data->diu_reg);
        for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++)
                if (machine_data->fsl_diu_info[i])
                        framebuffer_release(machine_data->fsl_diu_info[i]);
@@ -1708,7 +1804,6 @@ static int __init fsl_diu_init(void)
 #if defined(CONFIG_NOT_COHERENT_CACHE)
                vfree(coherence_data);
 #endif
-               iounmap(dr.diu_reg);
        }
        return ret;
 }