SHPCHP: fix __must_check warnings
[pandora-kernel.git] / drivers / pci / hotplug / shpchp_core.c
index cb4ac43..235c18a 100644 (file)
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/pci.h>
+#include <linux/workqueue.h>
 #include "shpchp.h"
 
 /* Global variables */
 int shpchp_debug;
 int shpchp_poll_mode;
 int shpchp_poll_time;
-LIST_HEAD(shpchp_ctrl_list);
+struct workqueue_struct *shpchp_wq;
 
 #define DRIVER_VERSION "0.4"
 #define DRIVER_AUTHOR  "Dan Zink <dan.zink@compaq.com>, Greg Kroah-Hartman <greg@kroah.com>, Dely Sy <dely.l.sy@intel.com>"
@@ -57,7 +58,6 @@ MODULE_PARM_DESC(shpchp_poll_time, "Polling mechanism frequency, in seconds");
 
 #define SHPC_MODULE_NAME "shpchp"
 
-static int shpc_start_thread (void);
 static int set_attention_status (struct hotplug_slot *slot, u8 value);
 static int enable_slot         (struct hotplug_slot *slot);
 static int disable_slot                (struct hotplug_slot *slot);
@@ -104,6 +104,23 @@ static void make_slot_name(struct slot *slot)
                 slot->bus, slot->number);
 }
 
+
+
+
+static int
+shpchprm_get_physical_slot_number(struct controller *ctrl, u32 *sun,
+                               u8 busnum, u8 devnum)
+{
+       int offset = devnum - ctrl->slot_device_offset;
+
+       dbg("%s: ctrl->slot_num_inc %d, offset %d\n", __FUNCTION__,
+                       ctrl->slot_num_inc, offset);
+       *sun = (u8) (ctrl->first_slot + ctrl->slot_num_inc *offset);
+       return 0;
+}
+
+
+
 static int init_slots(struct controller *ctrl)
 {
        struct slot *slot;
@@ -135,12 +152,14 @@ static int init_slots(struct controller *ctrl)
                slot->bus = ctrl->slot_bus;
                slot->device = ctrl->slot_device_offset + i;
                slot->hpc_ops = ctrl->hpc_ops;
+               mutex_init(&slot->lock);
 
                if (shpchprm_get_physical_slot_number(ctrl, &sun,
                                                      slot->bus, slot->device))
                        goto error_info;
 
                slot->number = sun;
+               INIT_WORK(&slot->work, queue_pushbutton_work, slot);
 
                /* register this slot with the hotplug pci core */
                hotplug_slot->private = slot;
@@ -176,7 +195,7 @@ error:
        return retval;
 }
 
-static void cleanup_slots(struct controller *ctrl)
+void cleanup_slots(struct controller *ctrl)
 {
        struct list_head *tmp;
        struct list_head *next;
@@ -185,6 +204,9 @@ static void cleanup_slots(struct controller *ctrl)
        list_for_each_safe(tmp, next, &ctrl->slot_list) {
                slot = list_entry(tmp, struct slot, slot_list);
                list_del(&slot->slot_list);
+               cancel_delayed_work(&slot->work);
+               flush_scheduled_work();
+               flush_workqueue(shpchp_wq);
                pci_hp_deregister(slot->hotplug_slot);
        }
 }
@@ -240,7 +262,7 @@ static int enable_slot (struct hotplug_slot *hotplug_slot)
 
        dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
 
-       return shpchp_enable_slot(slot);
+       return shpchp_sysfs_enable_slot(slot);
 }
 
 static int disable_slot (struct hotplug_slot *hotplug_slot)
@@ -249,7 +271,7 @@ static int disable_slot (struct hotplug_slot *hotplug_slot)
 
        dbg("%s - physical_slot = %s\n", __FUNCTION__, hotplug_slot->name);
 
-       return shpchp_disable_slot(slot);
+       return shpchp_sysfs_disable_slot(slot);
 }
 
 static int get_power_status (struct hotplug_slot *hotplug_slot, u8 *value)
@@ -386,14 +408,6 @@ static int shpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        pci_set_drvdata(pdev, ctrl);
 
-       ctrl->pci_bus = kmalloc(sizeof(*ctrl->pci_bus), GFP_KERNEL);
-       if (!ctrl->pci_bus) {
-               err("out of memory\n");
-               rc = -ENOMEM;
-               goto err_out_unmap_mmio_region;
-       }
-
-       memcpy (ctrl->pci_bus, pdev->bus, sizeof (*ctrl->pci_bus));
        ctrl->bus = pdev->bus->number;
        ctrl->slot_bus = pdev->subordinate->number;
        ctrl->device = PCI_SLOT(pdev->devfn);
@@ -408,7 +422,7 @@ static int shpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        rc = get_ctlr_slot_config(ctrl);
        if (rc) {
                err(msg_initialization_err, rc);
-               goto err_out_free_ctrl_bus;
+               goto err_out_release_ctlr;
        }
        first_device_num = ctrl->slot_device_offset;
        num_ctlr_slots = ctrl->num_slots;
@@ -419,7 +433,7 @@ static int shpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        rc = init_slots(ctrl);
        if (rc) {
                err(msg_initialization_err, 6);
-               goto err_out_free_ctrl_slot;
+               goto err_out_release_ctlr;
        }
 
        /* Now hpc_functions (slot->hpc_ops->functions) are ready  */
@@ -435,20 +449,15 @@ static int shpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                ctrl->speed = PCI_SPEED_33MHz;
        }
 
-       /* Finish setting up the hot plug ctrl device */
-       ctrl->next_event = 0;
-
-       list_add(&ctrl->ctrl_list, &shpchp_ctrl_list);
-
-       shpchp_create_ctrl_files(ctrl);
+       rc = shpchp_create_ctrl_files(ctrl);
+       if (rc)
+               goto err_cleanup_slots;
 
        return 0;
 
-err_out_free_ctrl_slot:
+err_cleanup_slots:
        cleanup_slots(ctrl);
-err_out_free_ctrl_bus:
-       kfree(ctrl->pci_bus);
-err_out_unmap_mmio_region:
+err_out_release_ctlr:
        ctrl->hpc_ops->release_ctlr(ctrl);
 err_out_free_ctrl:
        kfree(ctrl);
@@ -456,39 +465,13 @@ err_out_none:
        return -ENODEV;
 }
 
-static int shpc_start_thread(void)
-{
-       int retval = 0;
-
-       dbg("Initialize + Start the notification/polling mechanism \n");
-
-       retval = shpchp_event_start_thread();
-       if (retval) {
-               dbg("shpchp_event_start_thread() failed\n");
-               return retval;
-       }
-
-       return retval;
-}
-
-static void __exit unload_shpchpd(void)
+static void shpc_remove(struct pci_dev *dev)
 {
-       struct list_head *tmp;
-       struct list_head *next;
-       struct controller *ctrl;
-
-       list_for_each_safe(tmp, next, &shpchp_ctrl_list) {
-               ctrl = list_entry(tmp, struct controller, ctrl_list);
-               shpchp_remove_ctrl_files(ctrl);
-               cleanup_slots(ctrl);
-               kfree (ctrl->pci_bus);
-               ctrl->hpc_ops->release_ctlr(ctrl);
-               kfree(ctrl);
-       }
-
-       /* Stop the notification mechanism */
-       shpchp_event_stop_thread();
+       struct controller *ctrl = pci_get_drvdata(dev);
 
+       shpchp_remove_ctrl_files(ctrl);
+       ctrl->hpc_ops->release_ctlr(ctrl);
+       kfree(ctrl);
 }
 
 static struct pci_device_id shpcd_pci_tbl[] = {
@@ -501,7 +484,7 @@ static struct pci_driver shpc_driver = {
        .name =         SHPC_MODULE_NAME,
        .id_table =     shpcd_pci_tbl,
        .probe =        shpc_probe,
-       /* remove:      shpc_remove_one, */
+       .remove =       shpc_remove,
 };
 
 static int __init shpcd_init(void)
@@ -512,28 +495,16 @@ static int __init shpcd_init(void)
        shpchp_poll_mode = 1;
 #endif
 
-       retval = shpc_start_thread();
-       if (retval)
-               goto error_hpc_init;
-
        retval = pci_register_driver(&shpc_driver);
        dbg("%s: pci_register_driver = %d\n", __FUNCTION__, retval);
        info(DRIVER_DESC " version: " DRIVER_VERSION "\n");
-
-error_hpc_init:
-       if (retval) {
-               shpchp_event_stop_thread();
-       }
        return retval;
 }
 
 static void __exit shpcd_cleanup(void)
 {
        dbg("unload_shpchpd()\n");
-       unload_shpchpd();
-
        pci_unregister_driver(&shpc_driver);
-
        info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
 }