mwifiex: fix checkpatch --strict warnings/errors Part 9
[pandora-kernel.git] / drivers / net / wireless / mwifiex / wmm.c
index 6f0cc21..5a7316c 100644 (file)
@@ -87,15 +87,15 @@ mwifiex_wmm_ac_debug_print(const struct ieee_types_wmm_ac_parameters *ac_param)
        const char *ac_str[] = { "BK", "BE", "VI", "VO" };
 
        pr_debug("info: WMM AC_%s: ACI=%d, ACM=%d, Aifsn=%d, "
-              "EcwMin=%d, EcwMax=%d, TxopLimit=%d\n",
-              ac_str[wmm_aci_to_qidx_map[(ac_param->aci_aifsn_bitmap
-              & MWIFIEX_ACI) >> 5]],
-              (ac_param->aci_aifsn_bitmap & MWIFIEX_ACI) >> 5,
-              (ac_param->aci_aifsn_bitmap & MWIFIEX_ACM) >> 4,
-              ac_param->aci_aifsn_bitmap & MWIFIEX_AIFSN,
-              ac_param->ecw_bitmap & MWIFIEX_ECW_MIN,
-              (ac_param->ecw_bitmap & MWIFIEX_ECW_MAX) >> 4,
-              le16_to_cpu(ac_param->tx_op_limit));
+                "EcwMin=%d, EcwMax=%d, TxopLimit=%d\n",
+                ac_str[wmm_aci_to_qidx_map[(ac_param->aci_aifsn_bitmap
+                                            & MWIFIEX_ACI) >> 5]],
+                (ac_param->aci_aifsn_bitmap & MWIFIEX_ACI) >> 5,
+                (ac_param->aci_aifsn_bitmap & MWIFIEX_ACM) >> 4,
+                ac_param->aci_aifsn_bitmap & MWIFIEX_AIFSN,
+                ac_param->ecw_bitmap & MWIFIEX_ECW_MIN,
+                (ac_param->ecw_bitmap & MWIFIEX_ECW_MAX) >> 4,
+                le16_to_cpu(ac_param->tx_op_limit));
 }
 
 /*
@@ -112,7 +112,7 @@ mwifiex_wmm_allocate_ralist_node(struct mwifiex_adapter *adapter, u8 *ra)
 
        if (!ra_list) {
                dev_err(adapter->dev, "%s: failed to alloc ra_list\n",
-                                               __func__);
+                       __func__);
                return NULL;
        }
        INIT_LIST_HEAD(&ra_list->list);
@@ -154,7 +154,7 @@ mwifiex_ralist_add(struct mwifiex_private *priv, u8 *ra)
                        ra_list, ra_list->is_11n_enabled);
 
                list_add_tail(&ra_list->list,
-                               &priv->wmm.tid_tbl_ptr[i].ra_list);
+                             &priv->wmm.tid_tbl_ptr[i].ra_list);
 
                if (!priv->wmm.tid_tbl_ptr[i].ra_list_curr)
                        priv->wmm.tid_tbl_ptr[i].ra_list_curr = ra_list;
@@ -217,22 +217,19 @@ mwifiex_wmm_setup_queue_priorities(struct mwifiex_private *priv,
                wmm_ie->reserved);
 
        for (num_ac = 0; num_ac < ARRAY_SIZE(wmm_ie->ac_params); num_ac++) {
-               cw_min = (1 << (wmm_ie->ac_params[num_ac].ecw_bitmap &
-                       MWIFIEX_ECW_MIN)) - 1;
-               avg_back_off = (cw_min >> 1) +
-                       (wmm_ie->ac_params[num_ac].aci_aifsn_bitmap &
-                       MWIFIEX_AIFSN);
-
-               ac_idx = wmm_aci_to_qidx_map[(wmm_ie->ac_params[num_ac].
-                                            aci_aifsn_bitmap &
-                                            MWIFIEX_ACI) >> 5];
+               u8 ecw = wmm_ie->ac_params[num_ac].ecw_bitmap;
+               u8 aci_aifsn = wmm_ie->ac_params[num_ac].aci_aifsn_bitmap;
+               cw_min = (1 << (ecw & MWIFIEX_ECW_MIN)) - 1;
+               avg_back_off = (cw_min >> 1) + (aci_aifsn & MWIFIEX_AIFSN);
+
+               ac_idx = wmm_aci_to_qidx_map[(aci_aifsn & MWIFIEX_ACI) >> 5];
                priv->wmm.queue_priority[ac_idx] = ac_idx;
                tmp[ac_idx] = avg_back_off;
 
-               dev_dbg(priv->adapter->dev, "info: WMM: CWmax=%d CWmin=%d Avg Back-off=%d\n",
-                      (1 << ((wmm_ie->ac_params[num_ac].ecw_bitmap &
-                      MWIFIEX_ECW_MAX) >> 4)) - 1,
-                      cw_min, avg_back_off);
+               dev_dbg(priv->adapter->dev,
+                       "info: WMM: CWmax=%d CWmin=%d Avg Back-off=%d\n",
+                       (1 << ((ecw & MWIFIEX_ECW_MAX) >> 4)) - 1,
+                       cw_min, avg_back_off);
                mwifiex_wmm_ac_debug_print(&wmm_ie->ac_params[num_ac]);
        }
 
@@ -312,13 +309,14 @@ mwifiex_wmm_setup_ac_downgrade(struct mwifiex_private *priv)
                /* WMM is not enabled, default priorities */
                for (ac_val = WMM_AC_BK; ac_val <= WMM_AC_VO; ac_val++)
                        priv->wmm.ac_down_graded_vals[ac_val] =
-                               (enum mwifiex_wmm_ac_e) ac_val;
+                                               (enum mwifiex_wmm_ac_e) ac_val;
        } else {
                for (ac_val = WMM_AC_BK; ac_val <= WMM_AC_VO; ac_val++) {
                        priv->wmm.ac_down_graded_vals[ac_val]
                                = mwifiex_wmm_eval_downgrade_ac(priv,
                                                (enum mwifiex_wmm_ac_e) ac_val);
-                       dev_dbg(priv->adapter->dev, "info: WMM: AC PRIO %d maps to %d\n",
+                       dev_dbg(priv->adapter->dev,
+                               "info: WMM: AC PRIO %d maps to %d\n",
                                ac_val, priv->wmm.ac_down_graded_vals[ac_val]);
                }
        }
@@ -394,13 +392,13 @@ mwifiex_wmm_init(struct mwifiex_adapter *adapter)
                }
 
                priv->aggr_prio_tbl[6].amsdu
-                       = priv->aggr_prio_tbl[6].ampdu_ap
-                       = priv->aggr_prio_tbl[6].ampdu_user
-                       = BA_STREAM_NOT_ALLOWED;
+                                       = priv->aggr_prio_tbl[6].ampdu_ap
+                                       = priv->aggr_prio_tbl[6].ampdu_user
+                                       = BA_STREAM_NOT_ALLOWED;
 
                priv->aggr_prio_tbl[7].amsdu = priv->aggr_prio_tbl[7].ampdu_ap
-                       = priv->aggr_prio_tbl[7].ampdu_user
-                       = BA_STREAM_NOT_ALLOWED;
+                                       = priv->aggr_prio_tbl[7].ampdu_user
+                                       = BA_STREAM_NOT_ALLOWED;
 
                priv->add_ba_param.timeout = MWIFIEX_DEFAULT_BLOCK_ACK_TIMEOUT;
                priv->add_ba_param.tx_win_size = MWIFIEX_AMPDU_DEF_TXWINSIZE;
@@ -472,7 +470,7 @@ static void mwifiex_wmm_cleanup_queues(struct mwifiex_private *priv)
 
        for (i = 0; i < MAX_NUM_TID; i++)
                mwifiex_wmm_del_pkts_in_ralist(priv, &priv->wmm.tid_tbl_ptr[i].
-                                                    ra_list);
+                                                                      ra_list);
 
        atomic_set(&priv->wmm.tx_pkts_queued, 0);
        atomic_set(&priv->wmm.highest_queued_prio, HIGH_PRIO_TID);
@@ -488,9 +486,10 @@ static void mwifiex_wmm_delete_all_ralist(struct mwifiex_private *priv)
 
        for (i = 0; i < MAX_NUM_TID; ++i) {
                dev_dbg(priv->adapter->dev,
-                               "info: ra_list: freeing buf for tid %d\n", i);
+                       "info: ra_list: freeing buf for tid %d\n", i);
                list_for_each_entry_safe(ra_list, tmp_node,
-                               &priv->wmm.tid_tbl_ptr[i].ra_list, list) {
+                                        &priv->wmm.tid_tbl_ptr[i].ra_list,
+                                        list) {
                        list_del(&ra_list->list);
                        kfree(ra_list);
                }
@@ -652,7 +651,7 @@ mwifiex_wmm_add_buf_txqueue(struct mwifiex_private *priv,
        if (atomic_read(&priv->wmm.highest_queued_prio) <
                                                tos_to_tid_inv[tid_down])
                atomic_set(&priv->wmm.highest_queued_prio,
-                                               tos_to_tid_inv[tid_down]);
+                          tos_to_tid_inv[tid_down]);
 
        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, flags);
 }
@@ -681,7 +680,7 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv,
        struct mwifiex_wmm_ac_status *ac_status;
 
        dev_dbg(priv->adapter->dev, "info: WMM: WMM_GET_STATUS cmdresp received: %d\n",
-                       resp_len);
+               resp_len);
 
        while ((resp_len >= sizeof(tlv_hdr->header)) && valid) {
                tlv_hdr = (struct mwifiex_ie_types_data *) curr;
@@ -695,15 +694,15 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv,
                        dev_dbg(priv->adapter->dev,
                                "info: CMD_RESP: WMM_GET_STATUS:"
                                " QSTATUS TLV: %d, %d, %d\n",
-                              tlv_wmm_qstatus->queue_index,
-                              tlv_wmm_qstatus->flow_required,
-                              tlv_wmm_qstatus->disabled);
+                               tlv_wmm_qstatus->queue_index,
+                               tlv_wmm_qstatus->flow_required,
+                               tlv_wmm_qstatus->disabled);
 
                        ac_status = &priv->wmm.ac_status[tlv_wmm_qstatus->
                                                         queue_index];
                        ac_status->disabled = tlv_wmm_qstatus->disabled;
                        ac_status->flow_required =
-                               tlv_wmm_qstatus->flow_required;
+                                               tlv_wmm_qstatus->flow_required;
                        ac_status->flow_created = tlv_wmm_qstatus->flow_created;
                        break;
 
@@ -772,29 +771,27 @@ mwifiex_wmm_process_association_req(struct mwifiex_private *priv,
        if (!wmm_ie)
                return 0;
 
-       dev_dbg(priv->adapter->dev, "info: WMM: process assoc req:"
-                       "bss->wmmIe=0x%x\n",
-                       wmm_ie->vend_hdr.element_id);
+       dev_dbg(priv->adapter->dev,
+               "info: WMM: process assoc req: bss->wmm_ie=%#x\n",
+               wmm_ie->vend_hdr.element_id);
 
-       if ((priv->wmm_required
-            || (ht_cap && (priv->adapter->config_bands & BAND_GN
-                    || priv->adapter->config_bands & BAND_AN))
-           )
-           && wmm_ie->vend_hdr.element_id == WLAN_EID_VENDOR_SPECIFIC) {
+       if ((priv->wmm_required ||
+            (ht_cap && (priv->adapter->config_bands & BAND_GN ||
+            priv->adapter->config_bands & BAND_AN))) &&
+           wmm_ie->vend_hdr.element_id == WLAN_EID_VENDOR_SPECIFIC) {
                wmm_tlv = (struct mwifiex_ie_types_wmm_param_set *) *assoc_buf;
                wmm_tlv->header.type = cpu_to_le16((u16) wmm_info_ie[0]);
                wmm_tlv->header.len = cpu_to_le16((u16) wmm_info_ie[1]);
                memcpy(wmm_tlv->wmm_ie, &wmm_info_ie[2],
-                       le16_to_cpu(wmm_tlv->header.len));
+                      le16_to_cpu(wmm_tlv->header.len));
                if (wmm_ie->qos_info_bitmap & IEEE80211_WMM_IE_AP_QOSINFO_UAPSD)
                        memcpy((u8 *) (wmm_tlv->wmm_ie
-                                       + le16_to_cpu(wmm_tlv->header.len)
-                                        - sizeof(priv->wmm_qosinfo)),
-                                       &priv->wmm_qosinfo,
-                                       sizeof(priv->wmm_qosinfo));
+                                      + le16_to_cpu(wmm_tlv->header.len)
+                                      - sizeof(priv->wmm_qosinfo)),
+                              &priv->wmm_qosinfo, sizeof(priv->wmm_qosinfo));
 
                ret_len = sizeof(wmm_tlv->header)
-                       + le16_to_cpu(wmm_tlv->header.len);
+                         + le16_to_cpu(wmm_tlv->header.len);
 
                *assoc_buf += ret_len;
        }
@@ -813,7 +810,7 @@ mwifiex_wmm_process_association_req(struct mwifiex_private *priv,
  */
 u8
 mwifiex_wmm_compute_drv_pkt_delay(struct mwifiex_private *priv,
-                                       const struct sk_buff *skb)
+                                 const struct sk_buff *skb)
 {
        u8 ret_val;
        struct timeval out_tstamp, in_tstamp;
@@ -857,11 +854,11 @@ mwifiex_wmm_get_highest_priolist_ptr(struct mwifiex_adapter *adapter,
 
        for (j = adapter->priv_num - 1; j >= 0; --j) {
                spin_lock_irqsave(&adapter->bss_prio_tbl[j].bss_prio_lock,
-                               flags);
+                                 flags);
                is_list_empty = list_empty(&adapter->bss_prio_tbl[j]
-                               .bss_prio_head);
+                                          .bss_prio_head);
                spin_unlock_irqrestore(&adapter->bss_prio_tbl[j].bss_prio_lock,
-                               flags);
+                                      flags);
                if (is_list_empty)
                        continue;
 
@@ -1210,10 +1207,11 @@ mwifiex_dequeue_tx_packet(struct mwifiex_adapter *adapter)
                return 0;
        }
 
-       if (!ptr->is_11n_enabled || mwifiex_is_ba_stream_setup(priv, ptr, tid)
-           || ((priv->sec_info.wpa_enabled
-                 || priv->sec_info.wpa2_enabled) && !priv->wpa_is_gtk_set)
-               ) {
+       if (!ptr->is_11n_enabled ||
+           mwifiex_is_ba_stream_setup(priv, ptr, tid) ||
+           ((priv->sec_info.wpa_enabled ||
+             priv->sec_info.wpa2_enabled) &&
+            !priv->wpa_is_gtk_set)) {
                mwifiex_send_single_packet(priv, ptr, ptr_index, flags);
                /* ra_list_spinlock has been freed in
                   mwifiex_send_single_packet() */