Merge tag 'hsi-for-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi
[pandora-kernel.git] / drivers / net / tun.c
index 9c58286..a5cbf67 100644 (file)
@@ -104,6 +104,15 @@ do {                                                               \
 } while (0)
 #endif
 
+/* TUN device flags */
+
+/* IFF_ATTACH_QUEUE is never stored in device flags,
+ * overload it to mean fasync when stored there.
+ */
+#define TUN_FASYNC     IFF_ATTACH_QUEUE
+
+#define TUN_FEATURES (IFF_NO_PI | IFF_ONE_QUEUE | IFF_VNET_HDR | \
+                     IFF_VNET_LE | IFF_MULTI_QUEUE)
 #define GOODCOPY_LEN 128
 
 #define FLT_EXACT_COUNT 8
@@ -197,6 +206,16 @@ struct tun_struct {
        u32 flow_count;
 };
 
+static inline u16 tun16_to_cpu(struct tun_struct *tun, __virtio16 val)
+{
+       return __virtio16_to_cpu(tun->flags & IFF_VNET_LE, val);
+}
+
+static inline __virtio16 cpu_to_tun16(struct tun_struct *tun, u16 val)
+{
+       return __cpu_to_virtio16(tun->flags & IFF_VNET_LE, val);
+}
+
 static inline u32 tun_hashfn(u32 rxhash)
 {
        return rxhash & 0x3ff;
@@ -473,7 +492,7 @@ static void __tun_detach(struct tun_file *tfile, bool clean)
                if (tun && tun->numqueues == 0 && tun->numdisabled == 0) {
                        netif_carrier_off(tun->dev);
 
-                       if (!(tun->flags & TUN_PERSIST) &&
+                       if (!(tun->flags & IFF_PERSIST) &&
                            tun->dev->reg_state == NETREG_REGISTERED)
                                unregister_netdevice(tun->dev);
                }
@@ -524,7 +543,7 @@ static void tun_detach_all(struct net_device *dev)
        }
        BUG_ON(tun->numdisabled != 0);
 
-       if (tun->flags & TUN_PERSIST)
+       if (tun->flags & IFF_PERSIST)
                module_put(THIS_MODULE);
 }
 
@@ -542,7 +561,7 @@ static int tun_attach(struct tun_struct *tun, struct file *file, bool skip_filte
                goto out;
 
        err = -EBUSY;
-       if (!(tun->flags & TUN_TAP_MQ) && tun->numqueues == 1)
+       if (!(tun->flags & IFF_MULTI_QUEUE) && tun->numqueues == 1)
                goto out;
 
        err = -E2BIG;
@@ -921,7 +940,7 @@ static void tun_net_init(struct net_device *dev)
        struct tun_struct *tun = netdev_priv(dev);
 
        switch (tun->flags & TUN_TYPE_MASK) {
-       case TUN_TUN_DEV:
+       case IFF_TUN:
                dev->netdev_ops = &tun_netdev_ops;
 
                /* Point-to-Point TUN Device */
@@ -935,7 +954,7 @@ static void tun_net_init(struct net_device *dev)
                dev->tx_queue_len = TUN_READQ_SIZE;  /* We prefer our own queue length */
                break;
 
-       case TUN_TAP_DEV:
+       case IFF_TAP:
                dev->netdev_ops = &tap_netdev_ops;
                /* Ethernet TAP Device */
                ether_setup(dev);
@@ -1027,7 +1046,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
        u32 rxhash;
        ssize_t n;
 
-       if (!(tun->flags & TUN_NO_PI)) {
+       if (!(tun->flags & IFF_NO_PI)) {
                if (len < sizeof(pi))
                        return -EINVAL;
                len -= sizeof(pi);
@@ -1037,7 +1056,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
                        return -EFAULT;
        }
 
-       if (tun->flags & TUN_VNET_HDR) {
+       if (tun->flags & IFF_VNET_HDR) {
                if (len < tun->vnet_hdr_sz)
                        return -EINVAL;
                len -= tun->vnet_hdr_sz;
@@ -1047,18 +1066,18 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
                        return -EFAULT;
 
                if ((gso.flags & VIRTIO_NET_HDR_F_NEEDS_CSUM) &&
-                   gso.csum_start + gso.csum_offset + 2 > gso.hdr_len)
-                       gso.hdr_len = gso.csum_start + gso.csum_offset + 2;
+                   tun16_to_cpu(tun, gso.csum_start) + tun16_to_cpu(tun, gso.csum_offset) + 2 > tun16_to_cpu(tun, gso.hdr_len))
+                       gso.hdr_len = cpu_to_tun16(tun, tun16_to_cpu(tun, gso.csum_start) + tun16_to_cpu(tun, gso.csum_offset) + 2);
 
-               if (gso.hdr_len > len)
+               if (tun16_to_cpu(tun, gso.hdr_len) > len)
                        return -EINVAL;
                iov_iter_advance(from, tun->vnet_hdr_sz - sizeof(gso));
        }
 
-       if ((tun->flags & TUN_TYPE_MASK) == TUN_TAP_DEV) {
+       if ((tun->flags & TUN_TYPE_MASK) == IFF_TAP) {
                align += NET_IP_ALIGN;
                if (unlikely(len < ETH_HLEN ||
-                            (gso.hdr_len && gso.hdr_len < ETH_HLEN)))
+                            (gso.hdr_len && tun16_to_cpu(tun, gso.hdr_len) < ETH_HLEN)))
                        return -EINVAL;
        }
 
@@ -1071,7 +1090,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
                 * enough room for skb expand head in case it is used.
                 * The rest of the buffer is mapped from userspace.
                 */
-               copylen = gso.hdr_len ? gso.hdr_len : GOODCOPY_LEN;
+               copylen = gso.hdr_len ? tun16_to_cpu(tun, gso.hdr_len) : GOODCOPY_LEN;
                if (copylen > good_linear)
                        copylen = good_linear;
                linear = copylen;
@@ -1082,10 +1101,10 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
 
        if (!zerocopy) {
                copylen = len;
-               if (gso.hdr_len > good_linear)
+               if (tun16_to_cpu(tun, gso.hdr_len) > good_linear)
                        linear = good_linear;
                else
-                       linear = gso.hdr_len;
+                       linear = tun16_to_cpu(tun, gso.hdr_len);
        }
 
        skb = tun_alloc_skb(tfile, align, copylen, linear, noblock);
@@ -1112,8 +1131,8 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
        }
 
        if (gso.flags & VIRTIO_NET_HDR_F_NEEDS_CSUM) {
-               if (!skb_partial_csum_set(skb, gso.csum_start,
-                                         gso.csum_offset)) {
+               if (!skb_partial_csum_set(skb, tun16_to_cpu(tun, gso.csum_start),
+                                         tun16_to_cpu(tun, gso.csum_offset))) {
                        tun->dev->stats.rx_frame_errors++;
                        kfree_skb(skb);
                        return -EINVAL;
@@ -1121,8 +1140,8 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
        }
 
        switch (tun->flags & TUN_TYPE_MASK) {
-       case TUN_TUN_DEV:
-               if (tun->flags & TUN_NO_PI) {
+       case IFF_TUN:
+               if (tun->flags & IFF_NO_PI) {
                        switch (skb->data[0] & 0xf0) {
                        case 0x40:
                                pi.proto = htons(ETH_P_IP);
@@ -1141,7 +1160,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
                skb->protocol = pi.proto;
                skb->dev = tun->dev;
                break;
-       case TUN_TAP_DEV:
+       case IFF_TAP:
                skb->protocol = eth_type_trans(skb, tun->dev);
                break;
        }
@@ -1181,7 +1200,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
                if (gso.gso_type & VIRTIO_NET_HDR_GSO_ECN)
                        skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ECN;
 
-               skb_shinfo(skb)->gso_size = gso.gso_size;
+               skb_shinfo(skb)->gso_size = tun16_to_cpu(tun, gso.gso_size);
                if (skb_shinfo(skb)->gso_size == 0) {
                        tun->dev->stats.rx_frame_errors++;
                        kfree_skb(skb);
@@ -1243,12 +1262,12 @@ static ssize_t tun_put_user(struct tun_struct *tun,
        if (vlan_tx_tag_present(skb))
                vlan_hlen = VLAN_HLEN;
 
-       if (tun->flags & TUN_VNET_HDR)
+       if (tun->flags & IFF_VNET_HDR)
                vnet_hdr_sz = tun->vnet_hdr_sz;
 
        total = skb->len + vlan_hlen + vnet_hdr_sz;
 
-       if (!(tun->flags & TUN_NO_PI)) {
+       if (!(tun->flags & IFF_NO_PI)) {
                if (iov_iter_count(iter) < sizeof(pi))
                        return -EINVAL;
 
@@ -1271,8 +1290,8 @@ static ssize_t tun_put_user(struct tun_struct *tun,
                        struct skb_shared_info *sinfo = skb_shinfo(skb);
 
                        /* This is a hint as to how much should be linear. */
-                       gso.hdr_len = skb_headlen(skb);
-                       gso.gso_size = sinfo->gso_size;
+                       gso.hdr_len = cpu_to_tun16(tun, skb_headlen(skb));
+                       gso.gso_size = cpu_to_tun16(tun, sinfo->gso_size);
                        if (sinfo->gso_type & SKB_GSO_TCPV4)
                                gso.gso_type = VIRTIO_NET_HDR_GSO_TCPV4;
                        else if (sinfo->gso_type & SKB_GSO_TCPV6)
@@ -1280,12 +1299,12 @@ static ssize_t tun_put_user(struct tun_struct *tun,
                        else {
                                pr_err("unexpected GSO type: "
                                       "0x%x, gso_size %d, hdr_len %d\n",
-                                      sinfo->gso_type, gso.gso_size,
-                                      gso.hdr_len);
+                                      sinfo->gso_type, tun16_to_cpu(tun, gso.gso_size),
+                                      tun16_to_cpu(tun, gso.hdr_len));
                                print_hex_dump(KERN_ERR, "tun: ",
                                               DUMP_PREFIX_NONE,
                                               16, 1, skb->head,
-                                              min((int)gso.hdr_len, 64), true);
+                                              min((int)tun16_to_cpu(tun, gso.hdr_len), 64), true);
                                WARN_ON_ONCE(1);
                                return -EINVAL;
                        }
@@ -1296,9 +1315,9 @@ static ssize_t tun_put_user(struct tun_struct *tun,
 
                if (skb->ip_summed == CHECKSUM_PARTIAL) {
                        gso.flags = VIRTIO_NET_HDR_F_NEEDS_CSUM;
-                       gso.csum_start = skb_checksum_start_offset(skb) +
-                                        vlan_hlen;
-                       gso.csum_offset = skb->csum_offset;
+                       gso.csum_start = cpu_to_tun16(tun, skb_checksum_start_offset(skb) +
+                                                     vlan_hlen);
+                       gso.csum_offset = cpu_to_tun16(tun, skb->csum_offset);
                } else if (skb->ip_summed == CHECKSUM_UNNECESSARY) {
                        gso.flags = VIRTIO_NET_HDR_F_DATA_VALID;
                } /* else everything is zero */
@@ -1449,13 +1468,11 @@ static int tun_sendmsg(struct kiocb *iocb, struct socket *sock,
        int ret;
        struct tun_file *tfile = container_of(sock, struct tun_file, socket);
        struct tun_struct *tun = __tun_get(tfile);
-       struct iov_iter from;
 
        if (!tun)
                return -EBADFD;
 
-       iov_iter_init(&from, WRITE, m->msg_iov, m->msg_iovlen, total_len);
-       ret = tun_get_user(tun, tfile, m->msg_control, &from,
+       ret = tun_get_user(tun, tfile, m->msg_control, &m->msg_iter,
                           m->msg_flags & MSG_DONTWAIT);
        tun_put(tun);
        return ret;
@@ -1467,7 +1484,6 @@ static int tun_recvmsg(struct kiocb *iocb, struct socket *sock,
 {
        struct tun_file *tfile = container_of(sock, struct tun_file, socket);
        struct tun_struct *tun = __tun_get(tfile);
-       struct iov_iter to;
        int ret;
 
        if (!tun)
@@ -1482,8 +1498,7 @@ static int tun_recvmsg(struct kiocb *iocb, struct socket *sock,
                                         SOL_PACKET, TUN_TX_TIMESTAMP);
                goto out;
        }
-       iov_iter_init(&to, READ, m->msg_iov, m->msg_iovlen, total_len);
-       ret = tun_do_read(tun, tfile, &to, flags & MSG_DONTWAIT);
+       ret = tun_do_read(tun, tfile, &m->msg_iter, flags & MSG_DONTWAIT);
        if (ret > total_len) {
                m->msg_flags |= MSG_TRUNC;
                ret = flags & MSG_TRUNC ? ret : total_len;
@@ -1515,32 +1530,7 @@ static struct proto tun_proto = {
 
 static int tun_flags(struct tun_struct *tun)
 {
-       int flags = 0;
-
-       if (tun->flags & TUN_TUN_DEV)
-               flags |= IFF_TUN;
-       else
-               flags |= IFF_TAP;
-
-       if (tun->flags & TUN_NO_PI)
-               flags |= IFF_NO_PI;
-
-       /* This flag has no real effect.  We track the value for backwards
-        * compatibility.
-        */
-       if (tun->flags & TUN_ONE_QUEUE)
-               flags |= IFF_ONE_QUEUE;
-
-       if (tun->flags & TUN_VNET_HDR)
-               flags |= IFF_VNET_HDR;
-
-       if (tun->flags & TUN_TAP_MQ)
-               flags |= IFF_MULTI_QUEUE;
-
-       if (tun->flags & TUN_PERSIST)
-               flags |= IFF_PERSIST;
-
-       return flags;
+       return tun->flags & (TUN_FEATURES | IFF_PERSIST | IFF_TUN | IFF_TAP);
 }
 
 static ssize_t tun_show_flags(struct device *dev, struct device_attribute *attr,
@@ -1596,7 +1586,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
                        return -EINVAL;
 
                if (!!(ifr->ifr_flags & IFF_MULTI_QUEUE) !=
-                   !!(tun->flags & TUN_TAP_MQ))
+                   !!(tun->flags & IFF_MULTI_QUEUE))
                        return -EINVAL;
 
                if (tun_not_capable(tun))
@@ -1609,7 +1599,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
                if (err < 0)
                        return err;
 
-               if (tun->flags & TUN_TAP_MQ &&
+               if (tun->flags & IFF_MULTI_QUEUE &&
                    (tun->numqueues + tun->numdisabled > 1)) {
                        /* One or more queue has already been attached, no need
                         * to initialize the device again.
@@ -1632,11 +1622,11 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
                /* Set dev type */
                if (ifr->ifr_flags & IFF_TUN) {
                        /* TUN device */
-                       flags |= TUN_TUN_DEV;
+                       flags |= IFF_TUN;
                        name = "tun%d";
                } else if (ifr->ifr_flags & IFF_TAP) {
                        /* TAP device */
-                       flags |= TUN_TAP_DEV;
+                       flags |= IFF_TAP;
                        name = "tap%d";
                } else
                        return -EINVAL;
@@ -1700,28 +1690,8 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
 
        tun_debug(KERN_INFO, tun, "tun_set_iff\n");
 
-       if (ifr->ifr_flags & IFF_NO_PI)
-               tun->flags |= TUN_NO_PI;
-       else
-               tun->flags &= ~TUN_NO_PI;
-
-       /* This flag has no real effect.  We track the value for backwards
-        * compatibility.
-        */
-       if (ifr->ifr_flags & IFF_ONE_QUEUE)
-               tun->flags |= TUN_ONE_QUEUE;
-       else
-               tun->flags &= ~TUN_ONE_QUEUE;
-
-       if (ifr->ifr_flags & IFF_VNET_HDR)
-               tun->flags |= TUN_VNET_HDR;
-       else
-               tun->flags &= ~TUN_VNET_HDR;
-
-       if (ifr->ifr_flags & IFF_MULTI_QUEUE)
-               tun->flags |= TUN_TAP_MQ;
-       else
-               tun->flags &= ~TUN_TAP_MQ;
+       tun->flags = (tun->flags & ~TUN_FEATURES) |
+               (ifr->ifr_flags & TUN_FEATURES);
 
        /* Make sure persistent devices do not get stuck in
         * xoff state.
@@ -1849,7 +1819,7 @@ static int tun_set_queue(struct file *file, struct ifreq *ifr)
                ret = tun_attach(tun, file, false);
        } else if (ifr->ifr_flags & IFF_DETACH_QUEUE) {
                tun = rtnl_dereference(tfile->tun);
-               if (!tun || !(tun->flags & TUN_TAP_MQ) || tfile->detached)
+               if (!tun || !(tun->flags & IFF_MULTI_QUEUE) || tfile->detached)
                        ret = -EINVAL;
                else
                        __tun_detach(tfile, false);
@@ -1884,9 +1854,9 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
        if (cmd == TUNGETFEATURES) {
                /* Currently this just means: "what IFF flags are valid?".
                 * This is needed because we never checked for invalid flags on
-                * TUNSETIFF. */
-               return put_user(IFF_TUN | IFF_TAP | IFF_NO_PI | IFF_ONE_QUEUE |
-                               IFF_VNET_HDR | IFF_MULTI_QUEUE,
+                * TUNSETIFF.
+                */
+               return put_user(IFF_TUN | IFF_TAP | TUN_FEATURES,
                                (unsigned int __user*)argp);
        } else if (cmd == TUNSETQUEUE)
                return tun_set_queue(file, &ifr);
@@ -1953,12 +1923,12 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
                /* Disable/Enable persist mode. Keep an extra reference to the
                 * module to prevent the module being unprobed.
                 */
-               if (arg && !(tun->flags & TUN_PERSIST)) {
-                       tun->flags |= TUN_PERSIST;
+               if (arg && !(tun->flags & IFF_PERSIST)) {
+                       tun->flags |= IFF_PERSIST;
                        __module_get(THIS_MODULE);
                }
-               if (!arg && (tun->flags & TUN_PERSIST)) {
-                       tun->flags &= ~TUN_PERSIST;
+               if (!arg && (tun->flags & IFF_PERSIST)) {
+                       tun->flags &= ~IFF_PERSIST;
                        module_put(THIS_MODULE);
                }
 
@@ -2016,7 +1986,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
        case TUNSETTXFILTER:
                /* Can be set only for TAPs */
                ret = -EINVAL;
-               if ((tun->flags & TUN_TYPE_MASK) != TUN_TAP_DEV)
+               if ((tun->flags & TUN_TYPE_MASK) != IFF_TAP)
                        break;
                ret = update_filter(&tun->txflt, (void __user *)arg);
                break;
@@ -2075,7 +2045,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
        case TUNATTACHFILTER:
                /* Can be set only for TAPs */
                ret = -EINVAL;
-               if ((tun->flags & TUN_TYPE_MASK) != TUN_TAP_DEV)
+               if ((tun->flags & TUN_TYPE_MASK) != IFF_TAP)
                        break;
                ret = -EFAULT;
                if (copy_from_user(&tun->fprog, argp, sizeof(tun->fprog)))
@@ -2087,7 +2057,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
        case TUNDETACHFILTER:
                /* Can be set only for TAPs */
                ret = -EINVAL;
-               if ((tun->flags & TUN_TYPE_MASK) != TUN_TAP_DEV)
+               if ((tun->flags & TUN_TYPE_MASK) != IFF_TAP)
                        break;
                ret = 0;
                tun_detach_filter(tun, tun->numqueues);
@@ -2095,7 +2065,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
 
        case TUNGETFILTER:
                ret = -EINVAL;
-               if ((tun->flags & TUN_TYPE_MASK) != TUN_TAP_DEV)
+               if ((tun->flags & TUN_TYPE_MASK) != IFF_TAP)
                        break;
                ret = -EFAULT;
                if (copy_to_user(argp, &tun->fprog, sizeof(tun->fprog)))
@@ -2216,7 +2186,7 @@ static int tun_chr_close(struct inode *inode, struct file *file)
 }
 
 #ifdef CONFIG_PROC_FS
-static int tun_chr_show_fdinfo(struct seq_file *m, struct file *f)
+static void tun_chr_show_fdinfo(struct seq_file *m, struct file *f)
 {
        struct tun_struct *tun;
        struct ifreq ifr;
@@ -2232,7 +2202,7 @@ static int tun_chr_show_fdinfo(struct seq_file *m, struct file *f)
        if (tun)
                tun_put(tun);
 
-       return seq_printf(m, "iff:\t%s\n", ifr.ifr_name);
+       seq_printf(m, "iff:\t%s\n", ifr.ifr_name);
 }
 #endif
 
@@ -2288,10 +2258,10 @@ static void tun_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info
        strlcpy(info->version, DRV_VERSION, sizeof(info->version));
 
        switch (tun->flags & TUN_TYPE_MASK) {
-       case TUN_TUN_DEV:
+       case IFF_TUN:
                strlcpy(info->bus_info, "tun", sizeof(info->bus_info));
                break;
-       case TUN_TAP_DEV:
+       case IFF_TAP:
                strlcpy(info->bus_info, "tap", sizeof(info->bus_info));
                break;
        }