IB/ehca: Use round_jiffies() for EQ polling timer
[pandora-kernel.git] / drivers / infiniband / hw / ehca / ehca_main.c
index fe90e74..173d3e9 100644 (file)
 #ifdef CONFIG_PPC_64K_PAGES
 #include <linux/slab.h>
 #endif
+
 #include "ehca_classes.h"
 #include "ehca_iverbs.h"
 #include "ehca_mrmw.h"
 #include "ehca_tools.h"
 #include "hcp_if.h"
 
+#define HCAD_VERSION "0025"
+
 MODULE_LICENSE("Dual BSD/GPL");
 MODULE_AUTHOR("Christoph Raisch <raisch@de.ibm.com>");
 MODULE_DESCRIPTION("IBM eServer HCA InfiniBand Device Driver");
-MODULE_VERSION("SVNEHCA_0022");
+MODULE_VERSION(HCAD_VERSION);
 
 int ehca_open_aqp1     = 0;
 int ehca_debug_level   = 0;
@@ -62,17 +65,21 @@ int ehca_use_hp_mr     = 0;
 int ehca_port_act_time = 30;
 int ehca_poll_all_eqs  = 1;
 int ehca_static_rate   = -1;
-int ehca_scaling_code  = 1;
-
-module_param_named(open_aqp1,     ehca_open_aqp1,     int, 0);
-module_param_named(debug_level,   ehca_debug_level,   int, 0);
-module_param_named(hw_level,      ehca_hw_level,      int, 0);
-module_param_named(nr_ports,      ehca_nr_ports,      int, 0);
-module_param_named(use_hp_mr,     ehca_use_hp_mr,     int, 0);
-module_param_named(port_act_time, ehca_port_act_time, int, 0);
-module_param_named(poll_all_eqs,  ehca_poll_all_eqs,  int, 0);
-module_param_named(static_rate,   ehca_static_rate,   int, 0);
-module_param_named(scaling_code,   ehca_scaling_code,   int, 0);
+int ehca_scaling_code  = 0;
+int ehca_mr_largepage  = 1;
+int ehca_lock_hcalls   = -1;
+
+module_param_named(open_aqp1,     ehca_open_aqp1,     int, S_IRUGO);
+module_param_named(debug_level,   ehca_debug_level,   int, S_IRUGO);
+module_param_named(hw_level,      ehca_hw_level,      int, S_IRUGO);
+module_param_named(nr_ports,      ehca_nr_ports,      int, S_IRUGO);
+module_param_named(use_hp_mr,     ehca_use_hp_mr,     int, S_IRUGO);
+module_param_named(port_act_time, ehca_port_act_time, int, S_IRUGO);
+module_param_named(poll_all_eqs,  ehca_poll_all_eqs,  int, S_IRUGO);
+module_param_named(static_rate,   ehca_static_rate,   int, S_IRUGO);
+module_param_named(scaling_code,  ehca_scaling_code,  int, S_IRUGO);
+module_param_named(mr_largepage,  ehca_mr_largepage,  int, S_IRUGO);
+module_param_named(lock_hcalls,   ehca_lock_hcalls,   bool, S_IRUGO);
 
 MODULE_PARM_DESC(open_aqp1,
                 "AQP1 on startup (0: no (default), 1: yes)");
@@ -94,21 +101,26 @@ MODULE_PARM_DESC(poll_all_eqs,
 MODULE_PARM_DESC(static_rate,
                 "set permanent static rate (default: disabled)");
 MODULE_PARM_DESC(scaling_code,
-                "set scaling code (0: disabled, 1: enabled/default)");
-
-spinlock_t ehca_qp_idr_lock;
-spinlock_t ehca_cq_idr_lock;
+                "set scaling code (0: disabled/default, 1: enabled)");
+MODULE_PARM_DESC(mr_largepage,
+                "use large page for MR (0: use PAGE_SIZE (default), "
+                "1: use large page depending on MR size");
+MODULE_PARM_DESC(lock_hcalls,
+                "serialize all hCalls made by the driver "
+                "(default: autodetect)");
+
+DEFINE_RWLOCK(ehca_qp_idr_lock);
+DEFINE_RWLOCK(ehca_cq_idr_lock);
 DEFINE_IDR(ehca_qp_idr);
 DEFINE_IDR(ehca_cq_idr);
 
-
-static struct list_head shca_list; /* list of all registered ehcas */
-static spinlock_t shca_list_lock;
+static LIST_HEAD(shca_list); /* list of all registered ehcas */
+static DEFINE_SPINLOCK(shca_list_lock);
 
 static struct timer_list poll_eqs_timer;
 
 #ifdef CONFIG_PPC_64K_PAGES
-static struct kmem_cache *ctblk_cache = NULL;
+static struct kmem_cache *ctblk_cache;
 
 void *ehca_alloc_fw_ctrlblock(gfp_t flags)
 {
@@ -126,6 +138,23 @@ void ehca_free_fw_ctrlblock(void *ptr)
 }
 #endif
 
+int ehca2ib_return_code(u64 ehca_rc)
+{
+       switch (ehca_rc) {
+       case H_SUCCESS:
+               return 0;
+       case H_RESOURCE:             /* Resource in use */
+       case H_BUSY:
+               return -EBUSY;
+       case H_NOT_ENOUGH_RESOURCES: /* insufficient resources */
+       case H_CONSTRAINED:          /* resource constraint */
+       case H_NO_MEM:
+               return -ENOMEM;
+       default:
+               return -EINVAL;
+       }
+}
+
 static int ehca_create_slab_caches(void)
 {
        int ret;
@@ -160,19 +189,28 @@ static int ehca_create_slab_caches(void)
                goto create_slab_caches5;
        }
 
+       ret = ehca_init_small_qp_cache();
+       if (ret) {
+               ehca_gen_err("Cannot create small queue SLAB cache.");
+               goto create_slab_caches6;
+       }
+
 #ifdef CONFIG_PPC_64K_PAGES
        ctblk_cache = kmem_cache_create("ehca_cache_ctblk",
                                        EHCA_PAGESIZE, H_CB_ALIGNMENT,
                                        SLAB_HWCACHE_ALIGN,
-                                       NULL, NULL);
+                                       NULL);
        if (!ctblk_cache) {
                ehca_gen_err("Cannot create ctblk SLAB cache.");
-               ehca_cleanup_mrmw_cache();
-               goto create_slab_caches5;
+               ehca_cleanup_small_qp_cache();
+               goto create_slab_caches6;
        }
 #endif
        return 0;
 
+create_slab_caches6:
+       ehca_cleanup_mrmw_cache();
+
 create_slab_caches5:
        ehca_cleanup_av_cache();
 
@@ -190,6 +228,7 @@ create_slab_caches2:
 
 static void ehca_destroy_slab_caches(void)
 {
+       ehca_cleanup_small_qp_cache();
        ehca_cleanup_mrmw_cache();
        ehca_cleanup_av_cache();
        ehca_cleanup_qp_cache();
@@ -201,14 +240,46 @@ static void ehca_destroy_slab_caches(void)
 #endif
 }
 
-#define EHCA_HCAAVER  EHCA_BMASK_IBM(32,39)
-#define EHCA_REVID    EHCA_BMASK_IBM(40,63)
+#define EHCA_HCAAVER  EHCA_BMASK_IBM(32, 39)
+#define EHCA_REVID    EHCA_BMASK_IBM(40, 63)
+
+static struct cap_descr {
+       u64 mask;
+       char *descr;
+} hca_cap_descr[] = {
+       { HCA_CAP_AH_PORT_NR_CHECK, "HCA_CAP_AH_PORT_NR_CHECK" },
+       { HCA_CAP_ATOMIC, "HCA_CAP_ATOMIC" },
+       { HCA_CAP_AUTO_PATH_MIG, "HCA_CAP_AUTO_PATH_MIG" },
+       { HCA_CAP_BAD_P_KEY_CTR, "HCA_CAP_BAD_P_KEY_CTR" },
+       { HCA_CAP_SQD_RTS_PORT_CHANGE, "HCA_CAP_SQD_RTS_PORT_CHANGE" },
+       { HCA_CAP_CUR_QP_STATE_MOD, "HCA_CAP_CUR_QP_STATE_MOD" },
+       { HCA_CAP_INIT_TYPE, "HCA_CAP_INIT_TYPE" },
+       { HCA_CAP_PORT_ACTIVE_EVENT, "HCA_CAP_PORT_ACTIVE_EVENT" },
+       { HCA_CAP_Q_KEY_VIOL_CTR, "HCA_CAP_Q_KEY_VIOL_CTR" },
+       { HCA_CAP_WQE_RESIZE, "HCA_CAP_WQE_RESIZE" },
+       { HCA_CAP_RAW_PACKET_MCAST, "HCA_CAP_RAW_PACKET_MCAST" },
+       { HCA_CAP_SHUTDOWN_PORT, "HCA_CAP_SHUTDOWN_PORT" },
+       { HCA_CAP_RC_LL_QP, "HCA_CAP_RC_LL_QP" },
+       { HCA_CAP_SRQ, "HCA_CAP_SRQ" },
+       { HCA_CAP_UD_LL_QP, "HCA_CAP_UD_LL_QP" },
+       { HCA_CAP_RESIZE_MR, "HCA_CAP_RESIZE_MR" },
+       { HCA_CAP_MINI_QP, "HCA_CAP_MINI_QP" },
+       { HCA_CAP_H_ALLOC_RES_SYNC, "HCA_CAP_H_ALLOC_RES_SYNC" },
+};
 
-int ehca_sense_attributes(struct ehca_shca *shca)
+static int ehca_sense_attributes(struct ehca_shca *shca)
 {
-       int ret = 0;
+       int i, ret = 0;
        u64 h_ret;
        struct hipz_query_hca *rblock;
+       struct hipz_query_port *port;
+
+       static const u32 pgsize_map[] = {
+               HCA_CAP_MR_PGSIZE_4K,  0x1000,
+               HCA_CAP_MR_PGSIZE_64K, 0x10000,
+               HCA_CAP_MR_PGSIZE_1M,  0x100000,
+               HCA_CAP_MR_PGSIZE_16M, 0x1000000,
+       };
 
        rblock = ehca_alloc_fw_ctrlblock(GFP_KERNEL);
        if (!rblock) {
@@ -218,10 +289,10 @@ int ehca_sense_attributes(struct ehca_shca *shca)
 
        h_ret = hipz_h_query_hca(shca->ipz_hca_handle, rblock);
        if (h_ret != H_SUCCESS) {
-               ehca_gen_err("Cannot query device properties. h_ret=%lx",
+               ehca_gen_err("Cannot query device properties. h_ret=%li",
                             h_ret);
                ret = -EPERM;
-               goto num_ports1;
+               goto sense_attributes1;
        }
 
        if (ehca_nr_ports == 1)
@@ -240,19 +311,62 @@ int ehca_sense_attributes(struct ehca_shca *shca)
 
                ehca_gen_dbg(" ... hardware version=%x:%x", hcaaver, revid);
 
-               if ((hcaaver == 1) && (revid == 0))
-                       shca->hw_level = 0;
-               else if ((hcaaver == 1) && (revid == 1))
-                       shca->hw_level = 1;
-               else if ((hcaaver == 1) && (revid == 2))
-                       shca->hw_level = 2;
-       }
+               if (hcaaver == 1) {
+                       if (revid <= 3)
+                               shca->hw_level = 0x10 | (revid + 1);
+                       else
+                               shca->hw_level = 0x14;
+               } else if (hcaaver == 2) {
+                       if (revid == 0)
+                               shca->hw_level = 0x21;
+                       else if (revid == 0x10)
+                               shca->hw_level = 0x22;
+                       else if (revid == 0x20 || revid == 0x21)
+                               shca->hw_level = 0x23;
+               }
+
+               if (!shca->hw_level) {
+                       ehca_gen_warn("unknown hardware version"
+                                     " - assuming default level");
+                       shca->hw_level = 0x22;
+               }
+       } else
+               shca->hw_level = ehca_hw_level;
        ehca_gen_dbg(" ... hardware level=%x", shca->hw_level);
 
-       shca->sport[0].rate = IB_RATE_30_GBPS;
-       shca->sport[1].rate = IB_RATE_30_GBPS;
+       shca->hca_cap = rblock->hca_cap_indicators;
+       ehca_gen_dbg(" ... HCA capabilities:");
+       for (i = 0; i < ARRAY_SIZE(hca_cap_descr); i++)
+               if (EHCA_BMASK_GET(hca_cap_descr[i].mask, shca->hca_cap))
+                       ehca_gen_dbg("   %s", hca_cap_descr[i].descr);
+
+       /* Autodetect hCall locking -- the "H_ALLOC_RESOURCE synced" flag is
+        * a firmware property, so it's valid across all adapters
+        */
+       if (ehca_lock_hcalls == -1)
+               ehca_lock_hcalls = !(shca->hca_cap & HCA_CAP_H_ALLOC_RES_SYNC);
+
+       /* translate supported MR page sizes; always support 4K */
+       shca->hca_cap_mr_pgsize = EHCA_PAGESIZE;
+       if (ehca_mr_largepage) { /* support extra sizes only if enabled */
+               for (i = 0; i < ARRAY_SIZE(pgsize_map); i += 2)
+                       if (rblock->memory_page_size_supported & pgsize_map[i])
+                               shca->hca_cap_mr_pgsize |= pgsize_map[i + 1];
+       }
+
+       /* query max MTU from first port -- it's the same for all ports */
+       port = (struct hipz_query_port *)rblock;
+       h_ret = hipz_h_query_port(shca->ipz_hca_handle, 1, port);
+       if (h_ret != H_SUCCESS) {
+               ehca_gen_err("Cannot query port properties. h_ret=%li",
+                            h_ret);
+               ret = -EPERM;
+               goto sense_attributes1;
+       }
+
+       shca->max_mtu = port->max_mtu;
 
-num_ports1:
+sense_attributes1:
        ehca_free_fw_ctrlblock(rblock);
        return ret;
 }
@@ -292,7 +406,7 @@ int ehca_init_device(struct ehca_shca *shca)
        strlcpy(shca->ib_device.name, "ehca%d", IB_DEVICE_NAME_MAX);
        shca->ib_device.owner               = THIS_MODULE;
 
-       shca->ib_device.uverbs_abi_ver      = 6;
+       shca->ib_device.uverbs_abi_ver      = 8;
        shca->ib_device.uverbs_cmd_mask     =
                (1ull << IB_USER_VERBS_CMD_GET_CONTEXT)         |
                (1ull << IB_USER_VERBS_CMD_QUERY_DEVICE)        |
@@ -314,7 +428,7 @@ int ehca_init_device(struct ehca_shca *shca)
        shca->ib_device.node_type           = RDMA_NODE_IB_CA;
        shca->ib_device.phys_port_cnt       = shca->num_ports;
        shca->ib_device.num_comp_vectors    = 1;
-       shca->ib_device.dma_device          = &shca->ibmebus_dev->ofdev.dev;
+       shca->ib_device.dma_device          = &shca->ofdev->dev;
        shca->ib_device.query_device        = ehca_query_device;
        shca->ib_device.query_port          = ehca_query_port;
        shca->ib_device.query_gid           = ehca_query_gid;
@@ -360,6 +474,20 @@ int ehca_init_device(struct ehca_shca *shca)
        /* shca->ib_device.process_mad      = ehca_process_mad;     */
        shca->ib_device.mmap                = ehca_mmap;
 
+       if (EHCA_BMASK_GET(HCA_CAP_SRQ, shca->hca_cap)) {
+               shca->ib_device.uverbs_cmd_mask |=
+                       (1ull << IB_USER_VERBS_CMD_CREATE_SRQ) |
+                       (1ull << IB_USER_VERBS_CMD_MODIFY_SRQ) |
+                       (1ull << IB_USER_VERBS_CMD_QUERY_SRQ) |
+                       (1ull << IB_USER_VERBS_CMD_DESTROY_SRQ);
+
+               shca->ib_device.create_srq          = ehca_create_srq;
+               shca->ib_device.modify_srq          = ehca_modify_srq;
+               shca->ib_device.query_srq           = ehca_query_srq;
+               shca->ib_device.destroy_srq         = ehca_destroy_srq;
+               shca->ib_device.post_srq_recv       = ehca_post_srq_recv;
+       }
+
        return ret;
 }
 
@@ -376,7 +504,7 @@ static int ehca_create_aqp1(struct ehca_shca *shca, u32 port)
                return -EPERM;
        }
 
-       ibcq = ib_create_cq(&shca->ib_device, NULL, NULL, (void*)(-1), 10, 0);
+       ibcq = ib_create_cq(&shca->ib_device, NULL, NULL, (void *)(-1), 10, 0);
        if (IS_ERR(ibcq)) {
                ehca_err(&shca->ib_device, "Cannot create AQP1 CQ.");
                return PTR_ERR(ibcq);
@@ -424,13 +552,13 @@ static int ehca_destroy_aqp1(struct ehca_sport *sport)
 
        ret = ib_destroy_qp(sport->ibqp_aqp1);
        if (ret) {
-               ehca_gen_err("Cannot destroy AQP1 QP. ret=%x", ret);
+               ehca_gen_err("Cannot destroy AQP1 QP. ret=%i", ret);
                return ret;
        }
 
        ret = ib_destroy_cq(sport->ibcq_aqp1);
        if (ret)
-               ehca_gen_err("Cannot destroy AQP1 CQ. ret=%x", ret);
+               ehca_gen_err("Cannot destroy AQP1 CQ. ret=%i", ret);
 
        return ret;
 }
@@ -453,15 +581,19 @@ static ssize_t ehca_store_debug_level(struct device_driver *ddp,
 DRIVER_ATTR(debug_level, S_IRUSR | S_IWUSR,
            ehca_show_debug_level, ehca_store_debug_level);
 
-void ehca_create_driver_sysfs(struct ibmebus_driver *drv)
-{
-       driver_create_file(&drv->driver, &driver_attr_debug_level);
-}
+static struct attribute *ehca_drv_attrs[] = {
+       &driver_attr_debug_level.attr,
+       NULL
+};
 
-void ehca_remove_driver_sysfs(struct ibmebus_driver *drv)
-{
-       driver_remove_file(&drv->driver, &driver_attr_debug_level);
-}
+static struct attribute_group ehca_drv_attr_grp = {
+       .attrs = ehca_drv_attrs
+};
+
+static struct attribute_group *ehca_drv_attr_groups[] = {
+       &ehca_drv_attr_grp,
+       NULL,
+};
 
 #define EHCA_RESOURCE_ATTR(name)                                           \
 static ssize_t  ehca_show_##name(struct device *dev,                       \
@@ -476,12 +608,12 @@ static ssize_t  ehca_show_##name(struct device *dev,                       \
                                                                           \
        rblock = ehca_alloc_fw_ctrlblock(GFP_KERNEL);                      \
        if (!rblock) {                                                     \
-               dev_err(dev, "Can't allocate rblock memory.");             \
+               dev_err(dev, "Can't allocate rblock memory.\n");           \
                return 0;                                                  \
        }                                                                  \
                                                                           \
        if (hipz_h_query_hca(shca->ipz_hca_handle, rblock) != H_SUCCESS) { \
-               dev_err(dev, "Can't query device properties");             \
+               dev_err(dev, "Can't query device properties\n");           \
                ehca_free_fw_ctrlblock(rblock);                            \
                return 0;                                                  \
        }                                                                  \
@@ -523,46 +655,39 @@ static ssize_t ehca_show_adapter_handle(struct device *dev,
 }
 static DEVICE_ATTR(adapter_handle, S_IRUGO, ehca_show_adapter_handle, NULL);
 
-
-void ehca_create_device_sysfs(struct ibmebus_dev *dev)
+static ssize_t ehca_show_mr_largepage(struct device *dev,
+                                     struct device_attribute *attr,
+                                     char *buf)
 {
-       device_create_file(&dev->ofdev.dev, &dev_attr_adapter_handle);
-       device_create_file(&dev->ofdev.dev, &dev_attr_num_ports);
-       device_create_file(&dev->ofdev.dev, &dev_attr_hw_ver);
-       device_create_file(&dev->ofdev.dev, &dev_attr_max_eq);
-       device_create_file(&dev->ofdev.dev, &dev_attr_cur_eq);
-       device_create_file(&dev->ofdev.dev, &dev_attr_max_cq);
-       device_create_file(&dev->ofdev.dev, &dev_attr_cur_cq);
-       device_create_file(&dev->ofdev.dev, &dev_attr_max_qp);
-       device_create_file(&dev->ofdev.dev, &dev_attr_cur_qp);
-       device_create_file(&dev->ofdev.dev, &dev_attr_max_mr);
-       device_create_file(&dev->ofdev.dev, &dev_attr_cur_mr);
-       device_create_file(&dev->ofdev.dev, &dev_attr_max_mw);
-       device_create_file(&dev->ofdev.dev, &dev_attr_cur_mw);
-       device_create_file(&dev->ofdev.dev, &dev_attr_max_pd);
-       device_create_file(&dev->ofdev.dev, &dev_attr_max_ah);
+       return sprintf(buf, "%d\n", ehca_mr_largepage);
 }
+static DEVICE_ATTR(mr_largepage, S_IRUGO, ehca_show_mr_largepage, NULL);
+
+static struct attribute *ehca_dev_attrs[] = {
+       &dev_attr_adapter_handle.attr,
+       &dev_attr_num_ports.attr,
+       &dev_attr_hw_ver.attr,
+       &dev_attr_max_eq.attr,
+       &dev_attr_cur_eq.attr,
+       &dev_attr_max_cq.attr,
+       &dev_attr_cur_cq.attr,
+       &dev_attr_max_qp.attr,
+       &dev_attr_cur_qp.attr,
+       &dev_attr_max_mr.attr,
+       &dev_attr_cur_mr.attr,
+       &dev_attr_max_mw.attr,
+       &dev_attr_cur_mw.attr,
+       &dev_attr_max_pd.attr,
+       &dev_attr_max_ah.attr,
+       &dev_attr_mr_largepage.attr,
+       NULL
+};
 
-void ehca_remove_device_sysfs(struct ibmebus_dev *dev)
-{
-       device_remove_file(&dev->ofdev.dev, &dev_attr_adapter_handle);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_num_ports);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_hw_ver);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_max_eq);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_cur_eq);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_max_cq);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_cur_cq);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_max_qp);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_cur_qp);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_max_mr);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_cur_mr);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_max_mw);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_cur_mw);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_max_pd);
-       device_remove_file(&dev->ofdev.dev, &dev_attr_max_ah);
-}
+static struct attribute_group ehca_dev_attr_grp = {
+       .attrs = ehca_dev_attrs
+};
 
-static int __devinit ehca_probe(struct ibmebus_dev *dev,
+static int __devinit ehca_probe(struct of_device *dev,
                                const struct of_device_id *id)
 {
        struct ehca_shca *shca;
@@ -570,16 +695,16 @@ static int __devinit ehca_probe(struct ibmebus_dev *dev,
        struct ib_pd *ibpd;
        int ret;
 
-       handle = of_get_property(dev->ofdev.node, "ibm,hca-handle", NULL);
+       handle = of_get_property(dev->node, "ibm,hca-handle", NULL);
        if (!handle) {
                ehca_gen_err("Cannot get eHCA handle for adapter: %s.",
-                            dev->ofdev.node->full_name);
+                            dev->node->full_name);
                return -ENODEV;
        }
 
        if (!(*handle)) {
                ehca_gen_err("Wrong eHCA handle for adapter: %s.",
-                            dev->ofdev.node->full_name);
+                            dev->node->full_name);
                return -ENODEV;
        }
 
@@ -590,9 +715,9 @@ static int __devinit ehca_probe(struct ibmebus_dev *dev,
        }
        mutex_init(&shca->modify_mutex);
 
-       shca->ibmebus_dev = dev;
+       shca->ofdev = dev;
        shca->ipz_hca_handle.handle = *handle;
-       dev->ofdev.dev.driver_data = shca;
+       dev->dev.driver_data = shca;
 
        ret = ehca_sense_attributes(shca);
        if (ret < 0) {
@@ -620,7 +745,7 @@ static int __devinit ehca_probe(struct ibmebus_dev *dev,
        }
 
        /* create internal protection domain */
-       ibpd = ehca_alloc_pd(&shca->ib_device, (void*)(-1), NULL);
+       ibpd = ehca_alloc_pd(&shca->ib_device, (void *)(-1), NULL);
        if (IS_ERR(ibpd)) {
                ehca_err(&shca->ib_device, "Cannot create internal PD.");
                ret = PTR_ERR(ibpd);
@@ -634,7 +759,7 @@ static int __devinit ehca_probe(struct ibmebus_dev *dev,
        ret = ehca_reg_internal_maxmr(shca, shca->pd, &shca->maxmr);
 
        if (ret) {
-               ehca_err(&shca->ib_device, "Cannot create internal MR ret=%x",
+               ehca_err(&shca->ib_device, "Cannot create internal MR ret=%i",
                         ret);
                goto probe5;
        }
@@ -642,7 +767,7 @@ static int __devinit ehca_probe(struct ibmebus_dev *dev,
        ret = ib_register_device(&shca->ib_device);
        if (ret) {
                ehca_err(&shca->ib_device,
-                        "ib_register_device() failed ret=%x", ret);
+                        "ib_register_device() failed ret=%i", ret);
                goto probe6;
        }
 
@@ -668,7 +793,10 @@ static int __devinit ehca_probe(struct ibmebus_dev *dev,
                }
        }
 
-       ehca_create_device_sysfs(dev);
+       ret = sysfs_create_group(&dev->dev.kobj, &ehca_dev_attr_grp);
+       if (ret) /* only complain; we can live without attributes */
+               ehca_err(&shca->ib_device,
+                        "Cannot create device attributes  ret=%d", ret);
 
        spin_lock(&shca_list_lock);
        list_add(&shca->shca_list, &shca_list);
@@ -680,7 +808,7 @@ probe8:
        ret = ehca_destroy_aqp1(&shca->sport[0]);
        if (ret)
                ehca_err(&shca->ib_device,
-                        "Cannot destroy AQP1 for port 1. ret=%x", ret);
+                        "Cannot destroy AQP1 for port 1. ret=%i", ret);
 
 probe7:
        ib_unregister_device(&shca->ib_device);
@@ -715,12 +843,12 @@ probe1:
        return -EINVAL;
 }
 
-static int __devexit ehca_remove(struct ibmebus_dev *dev)
+static int __devexit ehca_remove(struct of_device *dev)
 {
-       struct ehca_shca *shca = dev->ofdev.dev.driver_data;
+       struct ehca_shca *shca = dev->dev.driver_data;
        int ret;
 
-       ehca_remove_device_sysfs(dev);
+       sysfs_remove_group(&dev->dev.kobj, &ehca_dev_attr_grp);
 
        if (ehca_open_aqp1 == 1) {
                int i;
@@ -729,7 +857,7 @@ static int __devexit ehca_remove(struct ibmebus_dev *dev)
                        if (ret)
                                ehca_err(&shca->ib_device,
                                         "Cannot destroy AQP1 for port %x "
-                                        "ret=%x", ret, i);
+                                        "ret=%i", ret, i);
                }
        }
 
@@ -738,20 +866,20 @@ static int __devexit ehca_remove(struct ibmebus_dev *dev)
        ret = ehca_dereg_internal_maxmr(shca);
        if (ret)
                ehca_err(&shca->ib_device,
-                        "Cannot destroy internal MR. ret=%x", ret);
+                        "Cannot destroy internal MR. ret=%i", ret);
 
        ret = ehca_dealloc_pd(&shca->pd->ib_pd);
        if (ret)
                ehca_err(&shca->ib_device,
-                        "Cannot destroy internal PD. ret=%x", ret);
+                        "Cannot destroy internal PD. ret=%i", ret);
 
        ret = ehca_destroy_eq(shca, &shca->eq);
        if (ret)
-               ehca_err(&shca->ib_device, "Cannot destroy EQ. ret=%x", ret);
+               ehca_err(&shca->ib_device, "Cannot destroy EQ. ret=%i", ret);
 
        ret = ehca_destroy_eq(shca, &shca->neq);
        if (ret)
-               ehca_err(&shca->ib_device, "Canot destroy NEQ. ret=%x", ret);
+               ehca_err(&shca->ib_device, "Canot destroy NEQ. ret=%i", ret);
 
        ib_dealloc_device(&shca->ib_device);
 
@@ -771,11 +899,14 @@ static struct of_device_id ehca_device_table[] =
        {},
 };
 
-static struct ibmebus_driver ehca_driver = {
-       .name     = "ehca",
-       .id_table = ehca_device_table,
-       .probe    = ehca_probe,
-       .remove   = ehca_remove,
+static struct of_platform_driver ehca_driver = {
+       .name        = "ehca",
+       .match_table = ehca_device_table,
+       .probe       = ehca_probe,
+       .remove      = ehca_remove,
+       .driver      = {
+               .groups = ehca_drv_attr_groups,
+       },
 };
 
 void ehca_poll_eqs(unsigned long data)
@@ -803,7 +934,7 @@ void ehca_poll_eqs(unsigned long data)
                                ehca_process_eq(shca, 0);
                }
        }
-       mod_timer(&poll_eqs_timer, jiffies + HZ);
+       mod_timer(&poll_eqs_timer, round_jiffies(jiffies + HZ));
        spin_unlock(&shca_list_lock);
 }
 
@@ -812,34 +943,28 @@ int __init ehca_module_init(void)
        int ret;
 
        printk(KERN_INFO "eHCA Infiniband Device Driver "
-              "(Rel.: SVNEHCA_0022)\n");
-       idr_init(&ehca_qp_idr);
-       idr_init(&ehca_cq_idr);
-       spin_lock_init(&ehca_qp_idr_lock);
-       spin_lock_init(&ehca_cq_idr_lock);
-
-       INIT_LIST_HEAD(&shca_list);
-       spin_lock_init(&shca_list_lock);
+              "(Version " HCAD_VERSION ")\n");
 
-       if ((ret = ehca_create_comp_pool())) {
+       ret = ehca_create_comp_pool();
+       if (ret) {
                ehca_gen_err("Cannot create comp pool.");
                return ret;
        }
 
-       if ((ret = ehca_create_slab_caches())) {
+       ret = ehca_create_slab_caches();
+       if (ret) {
                ehca_gen_err("Cannot create SLAB caches");
                ret = -ENOMEM;
                goto module_init1;
        }
 
-       if ((ret = ibmebus_register_driver(&ehca_driver))) {
+       ret = ibmebus_register_driver(&ehca_driver);
+       if (ret) {
                ehca_gen_err("Cannot register eHCA device driver");
                ret = -EINVAL;
                goto module_init2;
        }
 
-       ehca_create_driver_sysfs(&ehca_driver);
-
        if (ehca_poll_all_eqs != 1) {
                ehca_gen_err("WARNING!!!");
                ehca_gen_err("It is possible to lose interrupts.");
@@ -865,7 +990,6 @@ void __exit ehca_module_exit(void)
        if (ehca_poll_all_eqs == 1)
                del_timer_sync(&poll_eqs_timer);
 
-       ehca_remove_driver_sysfs(&ehca_driver);
        ibmebus_unregister_driver(&ehca_driver);
 
        ehca_destroy_slab_caches();