Merge branch 'next/dt' of git://git.linaro.org/people/arnd/arm-soc
[pandora-kernel.git] / drivers / gpu / drm / vmwgfx / vmwgfx_kms.c
index dfe32e6..8b14dfd 100644 (file)
 
 #include "vmwgfx_kms.h"
 
+
 /* Might need a hrtimer here? */
 #define VMWGFX_PRESENT_RATE ((HZ / 60 > 0) ? HZ / 60 : 1)
 
-static int vmw_surface_dmabuf_pin(struct vmw_framebuffer *vfb);
-static int vmw_surface_dmabuf_unpin(struct vmw_framebuffer *vfb);
-
 void vmw_display_unit_cleanup(struct vmw_display_unit *du)
 {
        if (du->cursor_surface)
@@ -329,41 +327,10 @@ struct vmw_framebuffer_surface {
        struct vmw_framebuffer base;
        struct vmw_surface *surface;
        struct vmw_dma_buffer *buffer;
-       struct delayed_work d_work;
-       struct mutex work_lock;
-       bool present_fs;
        struct list_head head;
        struct drm_master *master;
 };
 
-/**
- * vmw_kms_idle_workqueues - Flush workqueues on this master
- *
- * @vmaster - Pointer identifying the master, for the surfaces of which
- * we idle the dirty work queues.
- *
- * This function should be called with the ttm lock held in exclusive mode
- * to idle all dirty work queues before the fifo is taken down.
- *
- * The work task may actually requeue itself, but after the flush returns we're
- * sure that there's nothing to present, since the ttm lock is held in
- * exclusive mode, so the fifo will never get used.
- */
-
-void vmw_kms_idle_workqueues(struct vmw_master *vmaster)
-{
-       struct vmw_framebuffer_surface *entry;
-
-       mutex_lock(&vmaster->fb_surf_mutex);
-       list_for_each_entry(entry, &vmaster->fb_surf, head) {
-               if (cancel_delayed_work_sync(&entry->d_work))
-                       (void) entry->d_work.work.func(&entry->d_work.work);
-
-               (void) cancel_delayed_work_sync(&entry->d_work);
-       }
-       mutex_unlock(&vmaster->fb_surf_mutex);
-}
-
 void vmw_framebuffer_surface_destroy(struct drm_framebuffer *framebuffer)
 {
        struct vmw_framebuffer_surface *vfbs =
@@ -375,64 +342,127 @@ void vmw_framebuffer_surface_destroy(struct drm_framebuffer *framebuffer)
        list_del(&vfbs->head);
        mutex_unlock(&vmaster->fb_surf_mutex);
 
-       cancel_delayed_work_sync(&vfbs->d_work);
        drm_master_put(&vfbs->master);
        drm_framebuffer_cleanup(framebuffer);
        vmw_surface_unreference(&vfbs->surface);
+       ttm_base_object_unref(&vfbs->base.user_obj);
 
        kfree(vfbs);
 }
 
-static void vmw_framebuffer_present_fs_callback(struct work_struct *work)
+static int do_surface_dirty_sou(struct vmw_private *dev_priv,
+                               struct drm_file *file_priv,
+                               struct vmw_framebuffer *framebuffer,
+                               unsigned flags, unsigned color,
+                               struct drm_clip_rect *clips,
+                               unsigned num_clips, int inc)
 {
-       struct delayed_work *d_work =
-               container_of(work, struct delayed_work, work);
-       struct vmw_framebuffer_surface *vfbs =
-               container_of(d_work, struct vmw_framebuffer_surface, d_work);
-       struct vmw_surface *surf = vfbs->surface;
-       struct drm_framebuffer *framebuffer = &vfbs->base.base;
-       struct vmw_private *dev_priv = vmw_priv(framebuffer->dev);
+       struct drm_clip_rect *clips_ptr;
+       struct vmw_display_unit *units[VMWGFX_NUM_DISPLAY_UNITS];
+       struct drm_crtc *crtc;
+       size_t fifo_size;
+       int i, num_units;
+       int ret = 0; /* silence warning */
+       int left, right, top, bottom;
 
        struct {
                SVGA3dCmdHeader header;
-               SVGA3dCmdPresent body;
-               SVGA3dCopyRect cr;
+               SVGA3dCmdBlitSurfaceToScreen body;
        } *cmd;
+       SVGASignedRect *blits;
 
-       /**
-        * Strictly we should take the ttm_lock in read mode before accessing
-        * the fifo, to make sure the fifo is present and up. However,
-        * instead we flush all workqueues under the ttm lock in exclusive mode
-        * before taking down the fifo.
-        */
-       mutex_lock(&vfbs->work_lock);
-       if (!vfbs->present_fs)
-               goto out_unlock;
-
-       cmd = vmw_fifo_reserve(dev_priv, sizeof(*cmd));
-       if (unlikely(cmd == NULL))
-               goto out_resched;
-
-       cmd->header.id = cpu_to_le32(SVGA_3D_CMD_PRESENT);
-       cmd->header.size = cpu_to_le32(sizeof(cmd->body) + sizeof(cmd->cr));
-       cmd->body.sid = cpu_to_le32(surf->res.id);
-       cmd->cr.x = cpu_to_le32(0);
-       cmd->cr.y = cpu_to_le32(0);
-       cmd->cr.srcx = cmd->cr.x;
-       cmd->cr.srcy = cmd->cr.y;
-       cmd->cr.w = cpu_to_le32(framebuffer->width);
-       cmd->cr.h = cpu_to_le32(framebuffer->height);
-       vfbs->present_fs = false;
-       vmw_fifo_commit(dev_priv, sizeof(*cmd));
-out_resched:
-       /**
-        * Will not re-add if already pending.
-        */
-       schedule_delayed_work(&vfbs->d_work, VMWGFX_PRESENT_RATE);
-out_unlock:
-       mutex_unlock(&vfbs->work_lock);
-}
 
+       num_units = 0;
+       list_for_each_entry(crtc, &dev_priv->dev->mode_config.crtc_list,
+                           head) {
+               if (crtc->fb != &framebuffer->base)
+                       continue;
+               units[num_units++] = vmw_crtc_to_du(crtc);
+       }
+
+       BUG_ON(!clips || !num_clips);
+
+       fifo_size = sizeof(*cmd) + sizeof(SVGASignedRect) * num_clips;
+       cmd = kzalloc(fifo_size, GFP_KERNEL);
+       if (unlikely(cmd == NULL)) {
+               DRM_ERROR("Temporary fifo memory alloc failed.\n");
+               return -ENOMEM;
+       }
+
+       left = clips->x1;
+       right = clips->x2;
+       top = clips->y1;
+       bottom = clips->y2;
+
+       clips_ptr = clips;
+       for (i = 1; i < num_clips; i++, clips_ptr += inc) {
+               left = min_t(int, left, (int)clips_ptr->x1);
+               right = max_t(int, right, (int)clips_ptr->x2);
+               top = min_t(int, top, (int)clips_ptr->y1);
+               bottom = max_t(int, bottom, (int)clips_ptr->y2);
+       }
+
+       /* only need to do this once */
+       memset(cmd, 0, fifo_size);
+       cmd->header.id = cpu_to_le32(SVGA_3D_CMD_BLIT_SURFACE_TO_SCREEN);
+       cmd->header.size = cpu_to_le32(fifo_size - sizeof(cmd->header));
+
+       cmd->body.srcRect.left = left;
+       cmd->body.srcRect.right = right;
+       cmd->body.srcRect.top = top;
+       cmd->body.srcRect.bottom = bottom;
+
+       clips_ptr = clips;
+       blits = (SVGASignedRect *)&cmd[1];
+       for (i = 0; i < num_clips; i++, clips_ptr += inc) {
+               blits[i].left   = clips_ptr->x1 - left;
+               blits[i].right  = clips_ptr->x2 - left;
+               blits[i].top    = clips_ptr->y1 - top;
+               blits[i].bottom = clips_ptr->y2 - top;
+       }
+
+       /* do per unit writing, reuse fifo for each */
+       for (i = 0; i < num_units; i++) {
+               struct vmw_display_unit *unit = units[i];
+               int clip_x1 = left - unit->crtc.x;
+               int clip_y1 = top - unit->crtc.y;
+               int clip_x2 = right - unit->crtc.x;
+               int clip_y2 = bottom - unit->crtc.y;
+
+               /* skip any crtcs that misses the clip region */
+               if (clip_x1 >= unit->crtc.mode.hdisplay ||
+                   clip_y1 >= unit->crtc.mode.vdisplay ||
+                   clip_x2 <= 0 || clip_y2 <= 0)
+                       continue;
+
+               /* need to reset sid as it is changed by execbuf */
+               cmd->body.srcImage.sid = cpu_to_le32(framebuffer->user_handle);
+
+               cmd->body.destScreenId = unit->unit;
+
+               /*
+                * The blit command is a lot more resilient then the
+                * readback command when it comes to clip rects. So its
+                * okay to go out of bounds.
+                */
+
+               cmd->body.destRect.left = clip_x1;
+               cmd->body.destRect.right = clip_x2;
+               cmd->body.destRect.top = clip_y1;
+               cmd->body.destRect.bottom = clip_y2;
+
+
+               ret = vmw_execbuf_process(file_priv, dev_priv, NULL, cmd,
+                                         fifo_size, 0, NULL);
+
+               if (unlikely(ret != 0))
+                       break;
+       }
+
+       kfree(cmd);
+
+       return ret;
+}
 
 int vmw_framebuffer_surface_dirty(struct drm_framebuffer *framebuffer,
                                  struct drm_file *file_priv,
@@ -444,44 +474,20 @@ int vmw_framebuffer_surface_dirty(struct drm_framebuffer *framebuffer,
        struct vmw_master *vmaster = vmw_master(file_priv->master);
        struct vmw_framebuffer_surface *vfbs =
                vmw_framebuffer_to_vfbs(framebuffer);
-       struct vmw_surface *surf = vfbs->surface;
        struct drm_clip_rect norect;
-       SVGA3dCopyRect *cr;
-       int i, inc = 1;
-       int ret;
-
-       struct {
-               SVGA3dCmdHeader header;
-               SVGA3dCmdPresent body;
-               SVGA3dCopyRect cr;
-       } *cmd;
+       int ret, inc = 1;
 
        if (unlikely(vfbs->master != file_priv->master))
                return -EINVAL;
 
+       /* Require ScreenObject support for 3D */
+       if (!dev_priv->sou_priv)
+               return -EINVAL;
+
        ret = ttm_read_lock(&vmaster->lock, true);
        if (unlikely(ret != 0))
                return ret;
 
-       if (!num_clips ||
-           !(dev_priv->fifo.capabilities &
-             SVGA_FIFO_CAP_SCREEN_OBJECT)) {
-               int ret;
-
-               mutex_lock(&vfbs->work_lock);
-               vfbs->present_fs = true;
-               ret = schedule_delayed_work(&vfbs->d_work, VMWGFX_PRESENT_RATE);
-               mutex_unlock(&vfbs->work_lock);
-               if (ret) {
-                       /**
-                        * No work pending, Force immediate present.
-                        */
-                       vmw_framebuffer_present_fs_callback(&vfbs->d_work.work);
-               }
-               ttm_read_unlock(&vmaster->lock);
-               return 0;
-       }
-
        if (!num_clips) {
                num_clips = 1;
                clips = &norect;
@@ -493,29 +499,10 @@ int vmw_framebuffer_surface_dirty(struct drm_framebuffer *framebuffer,
                inc = 2; /* skip source rects */
        }
 
-       cmd = vmw_fifo_reserve(dev_priv, sizeof(*cmd) + (num_clips - 1) * sizeof(cmd->cr));
-       if (unlikely(cmd == NULL)) {
-               DRM_ERROR("Fifo reserve failed.\n");
-               ttm_read_unlock(&vmaster->lock);
-               return -ENOMEM;
-       }
-
-       memset(cmd, 0, sizeof(*cmd));
-
-       cmd->header.id = cpu_to_le32(SVGA_3D_CMD_PRESENT);
-       cmd->header.size = cpu_to_le32(sizeof(cmd->body) + num_clips * sizeof(cmd->cr));
-       cmd->body.sid = cpu_to_le32(surf->res.id);
-
-       for (i = 0, cr = &cmd->cr; i < num_clips; i++, cr++, clips += inc) {
-               cr->x = cpu_to_le16(clips->x1);
-               cr->y = cpu_to_le16(clips->y1);
-               cr->srcx = cr->x;
-               cr->srcy = cr->y;
-               cr->w = cpu_to_le16(clips->x2 - clips->x1);
-               cr->h = cpu_to_le16(clips->y2 - clips->y1);
-       }
+       ret = do_surface_dirty_sou(dev_priv, file_priv, &vfbs->base,
+                                  flags, color,
+                                  clips, num_clips, inc);
 
-       vmw_fifo_commit(dev_priv, sizeof(*cmd) + (num_clips - 1) * sizeof(cmd->cr));
        ttm_read_unlock(&vmaster->lock);
        return 0;
 }
@@ -540,6 +527,10 @@ static int vmw_kms_new_framebuffer_surface(struct vmw_private *dev_priv,
        struct vmw_master *vmaster = vmw_master(file_priv->master);
        int ret;
 
+       /* 3D is only supported on HWv8 hosts which supports screen objects */
+       if (!dev_priv->sou_priv)
+               return -ENOSYS;
+
        /*
         * Sanity checks.
         */
@@ -567,6 +558,9 @@ static int vmw_kms_new_framebuffer_surface(struct vmw_private *dev_priv,
        case 15:
                format = SVGA3D_A1R5G5B5;
                break;
+       case 8:
+               format = SVGA3D_LUMINANCE8;
+               break;
        default:
                DRM_ERROR("Invalid color depth: %d\n", mode_cmd->depth);
                return -EINVAL;
@@ -599,14 +593,11 @@ static int vmw_kms_new_framebuffer_surface(struct vmw_private *dev_priv,
        vfbs->base.base.depth = mode_cmd->depth;
        vfbs->base.base.width = mode_cmd->width;
        vfbs->base.base.height = mode_cmd->height;
-       vfbs->base.pin = &vmw_surface_dmabuf_pin;
-       vfbs->base.unpin = &vmw_surface_dmabuf_unpin;
        vfbs->surface = surface;
+       vfbs->base.user_handle = mode_cmd->handle;
        vfbs->master = drm_master_get(file_priv->master);
-       mutex_init(&vfbs->work_lock);
 
        mutex_lock(&vmaster->fb_surf_mutex);
-       INIT_DELAYED_WORK(&vfbs->d_work, &vmw_framebuffer_present_fs_callback);
        list_add_tail(&vfbs->head, &vmaster->fb_surf);
        mutex_unlock(&vmaster->fb_surf_mutex);
 
@@ -641,48 +632,33 @@ void vmw_framebuffer_dmabuf_destroy(struct drm_framebuffer *framebuffer)
 
        drm_framebuffer_cleanup(framebuffer);
        vmw_dmabuf_unreference(&vfbd->buffer);
+       ttm_base_object_unref(&vfbd->base.user_obj);
 
        kfree(vfbd);
 }
 
-int vmw_framebuffer_dmabuf_dirty(struct drm_framebuffer *framebuffer,
-                                struct drm_file *file_priv,
-                                unsigned flags, unsigned color,
-                                struct drm_clip_rect *clips,
-                                unsigned num_clips)
+static int do_dmabuf_dirty_ldu(struct vmw_private *dev_priv,
+                              struct vmw_framebuffer *framebuffer,
+                              unsigned flags, unsigned color,
+                              struct drm_clip_rect *clips,
+                              unsigned num_clips, int increment)
 {
-       struct vmw_private *dev_priv = vmw_priv(framebuffer->dev);
-       struct vmw_master *vmaster = vmw_master(file_priv->master);
-       struct drm_clip_rect norect;
-       int ret;
+       size_t fifo_size;
+       int i;
+
        struct {
                uint32_t header;
                SVGAFifoCmdUpdate body;
        } *cmd;
-       int i, increment = 1;
-
-       ret = ttm_read_lock(&vmaster->lock, true);
-       if (unlikely(ret != 0))
-               return ret;
-
-       if (!num_clips) {
-               num_clips = 1;
-               clips = &norect;
-               norect.x1 = norect.y1 = 0;
-               norect.x2 = framebuffer->width;
-               norect.y2 = framebuffer->height;
-       } else if (flags & DRM_MODE_FB_DIRTY_ANNOTATE_COPY) {
-               num_clips /= 2;
-               increment = 2;
-       }
 
-       cmd = vmw_fifo_reserve(dev_priv, sizeof(*cmd) * num_clips);
+       fifo_size = sizeof(*cmd) * num_clips;
+       cmd = vmw_fifo_reserve(dev_priv, fifo_size);
        if (unlikely(cmd == NULL)) {
                DRM_ERROR("Fifo reserve failed.\n");
-               ttm_read_unlock(&vmaster->lock);
                return -ENOMEM;
        }
 
+       memset(cmd, 0, fifo_size);
        for (i = 0; i < num_clips; i++, clips += increment) {
                cmd[i].header = cpu_to_le32(SVGA_CMD_UPDATE);
                cmd[i].body.x = cpu_to_le32(clips->x1);
@@ -691,57 +667,186 @@ int vmw_framebuffer_dmabuf_dirty(struct drm_framebuffer *framebuffer,
                cmd[i].body.height = cpu_to_le32(clips->y2 - clips->y1);
        }
 
-       vmw_fifo_commit(dev_priv, sizeof(*cmd) * num_clips);
-       ttm_read_unlock(&vmaster->lock);
-
+       vmw_fifo_commit(dev_priv, fifo_size);
        return 0;
 }
 
-static struct drm_framebuffer_funcs vmw_framebuffer_dmabuf_funcs = {
-       .destroy = vmw_framebuffer_dmabuf_destroy,
-       .dirty = vmw_framebuffer_dmabuf_dirty,
-       .create_handle = vmw_framebuffer_create_handle,
-};
-
-static int vmw_surface_dmabuf_pin(struct vmw_framebuffer *vfb)
+static int do_dmabuf_define_gmrfb(struct drm_file *file_priv,
+                                 struct vmw_private *dev_priv,
+                                 struct vmw_framebuffer *framebuffer)
 {
-       struct vmw_private *dev_priv = vmw_priv(vfb->base.dev);
-       struct vmw_framebuffer_surface *vfbs =
-               vmw_framebuffer_to_vfbs(&vfb->base);
-       unsigned long size = vfbs->base.base.pitch * vfbs->base.base.height;
+       int depth = framebuffer->base.depth;
+       size_t fifo_size;
        int ret;
 
-       vfbs->buffer = kzalloc(sizeof(*vfbs->buffer), GFP_KERNEL);
-       if (unlikely(vfbs->buffer == NULL))
+       struct {
+               uint32_t header;
+               SVGAFifoCmdDefineGMRFB body;
+       } *cmd;
+
+       /* Emulate RGBA support, contrary to svga_reg.h this is not
+        * supported by hosts. This is only a problem if we are reading
+        * this value later and expecting what we uploaded back.
+        */
+       if (depth == 32)
+               depth = 24;
+
+       fifo_size = sizeof(*cmd);
+       cmd = kmalloc(fifo_size, GFP_KERNEL);
+       if (unlikely(cmd == NULL)) {
+               DRM_ERROR("Failed to allocate temporary cmd buffer.\n");
                return -ENOMEM;
+       }
 
-       vmw_overlay_pause_all(dev_priv);
-       ret = vmw_dmabuf_init(dev_priv, vfbs->buffer, size,
-                              &vmw_vram_ne_placement,
-                              false, &vmw_dmabuf_bo_free);
-       vmw_overlay_resume_all(dev_priv);
+       memset(cmd, 0, fifo_size);
+       cmd->header = SVGA_CMD_DEFINE_GMRFB;
+       cmd->body.format.bitsPerPixel = framebuffer->base.bits_per_pixel;
+       cmd->body.format.colorDepth = depth;
+       cmd->body.format.reserved = 0;
+       cmd->body.bytesPerLine = framebuffer->base.pitch;
+       cmd->body.ptr.gmrId = framebuffer->user_handle;
+       cmd->body.ptr.offset = 0;
+
+       ret = vmw_execbuf_process(file_priv, dev_priv, NULL, cmd,
+                                 fifo_size, 0, NULL);
+
+       kfree(cmd);
+
+       return ret;
+}
+
+static int do_dmabuf_dirty_sou(struct drm_file *file_priv,
+                              struct vmw_private *dev_priv,
+                              struct vmw_framebuffer *framebuffer,
+                              unsigned flags, unsigned color,
+                              struct drm_clip_rect *clips,
+                              unsigned num_clips, int increment)
+{
+       struct vmw_display_unit *units[VMWGFX_NUM_DISPLAY_UNITS];
+       struct drm_clip_rect *clips_ptr;
+       int i, k, num_units, ret;
+       struct drm_crtc *crtc;
+       size_t fifo_size;
+
+       struct {
+               uint32_t header;
+               SVGAFifoCmdBlitGMRFBToScreen body;
+       } *blits;
+
+       ret = do_dmabuf_define_gmrfb(file_priv, dev_priv, framebuffer);
        if (unlikely(ret != 0))
-               vfbs->buffer = NULL;
+               return ret; /* define_gmrfb prints warnings */
+
+       fifo_size = sizeof(*blits) * num_clips;
+       blits = kmalloc(fifo_size, GFP_KERNEL);
+       if (unlikely(blits == NULL)) {
+               DRM_ERROR("Failed to allocate temporary cmd buffer.\n");
+               return -ENOMEM;
+       }
+
+       num_units = 0;
+       list_for_each_entry(crtc, &dev_priv->dev->mode_config.crtc_list, head) {
+               if (crtc->fb != &framebuffer->base)
+                       continue;
+               units[num_units++] = vmw_crtc_to_du(crtc);
+       }
+
+       for (k = 0; k < num_units; k++) {
+               struct vmw_display_unit *unit = units[k];
+               int hit_num = 0;
+
+               clips_ptr = clips;
+               for (i = 0; i < num_clips; i++, clips_ptr += increment) {
+                       int clip_x1 = clips_ptr->x1 - unit->crtc.x;
+                       int clip_y1 = clips_ptr->y1 - unit->crtc.y;
+                       int clip_x2 = clips_ptr->x2 - unit->crtc.x;
+                       int clip_y2 = clips_ptr->y2 - unit->crtc.y;
+
+                       /* skip any crtcs that misses the clip region */
+                       if (clip_x1 >= unit->crtc.mode.hdisplay ||
+                           clip_y1 >= unit->crtc.mode.vdisplay ||
+                           clip_x2 <= 0 || clip_y2 <= 0)
+                               continue;
+
+                       blits[hit_num].header = SVGA_CMD_BLIT_GMRFB_TO_SCREEN;
+                       blits[hit_num].body.destScreenId = unit->unit;
+                       blits[hit_num].body.srcOrigin.x = clips_ptr->x1;
+                       blits[hit_num].body.srcOrigin.y = clips_ptr->y1;
+                       blits[hit_num].body.destRect.left = clip_x1;
+                       blits[hit_num].body.destRect.top = clip_y1;
+                       blits[hit_num].body.destRect.right = clip_x2;
+                       blits[hit_num].body.destRect.bottom = clip_y2;
+                       hit_num++;
+               }
+
+               /* no clips hit the crtc */
+               if (hit_num == 0)
+                       continue;
+
+               fifo_size = sizeof(*blits) * hit_num;
+               ret = vmw_execbuf_process(file_priv, dev_priv, NULL, blits,
+                                         fifo_size, 0, NULL);
+
+               if (unlikely(ret != 0))
+                       break;
+       }
+
+       kfree(blits);
 
        return ret;
 }
 
-static int vmw_surface_dmabuf_unpin(struct vmw_framebuffer *vfb)
+int vmw_framebuffer_dmabuf_dirty(struct drm_framebuffer *framebuffer,
+                                struct drm_file *file_priv,
+                                unsigned flags, unsigned color,
+                                struct drm_clip_rect *clips,
+                                unsigned num_clips)
 {
-       struct ttm_buffer_object *bo;
-       struct vmw_framebuffer_surface *vfbs =
-               vmw_framebuffer_to_vfbs(&vfb->base);
+       struct vmw_private *dev_priv = vmw_priv(framebuffer->dev);
+       struct vmw_master *vmaster = vmw_master(file_priv->master);
+       struct vmw_framebuffer_dmabuf *vfbd =
+               vmw_framebuffer_to_vfbd(framebuffer);
+       struct drm_clip_rect norect;
+       int ret, increment = 1;
 
-       if (unlikely(vfbs->buffer == NULL))
-               return 0;
+       ret = ttm_read_lock(&vmaster->lock, true);
+       if (unlikely(ret != 0))
+               return ret;
+
+       if (!num_clips) {
+               num_clips = 1;
+               clips = &norect;
+               norect.x1 = norect.y1 = 0;
+               norect.x2 = framebuffer->width;
+               norect.y2 = framebuffer->height;
+       } else if (flags & DRM_MODE_FB_DIRTY_ANNOTATE_COPY) {
+               num_clips /= 2;
+               increment = 2;
+       }
 
-       bo = &vfbs->buffer->base;
-       ttm_bo_unref(&bo);
-       vfbs->buffer = NULL;
+       if (dev_priv->ldu_priv) {
+               ret = do_dmabuf_dirty_ldu(dev_priv, &vfbd->base,
+                                         flags, color,
+                                         clips, num_clips, increment);
+       } else {
+               ret = do_dmabuf_dirty_sou(file_priv, dev_priv, &vfbd->base,
+                                         flags, color,
+                                         clips, num_clips, increment);
+       }
 
-       return 0;
+       ttm_read_unlock(&vmaster->lock);
+       return ret;
 }
 
+static struct drm_framebuffer_funcs vmw_framebuffer_dmabuf_funcs = {
+       .destroy = vmw_framebuffer_dmabuf_destroy,
+       .dirty = vmw_framebuffer_dmabuf_dirty,
+       .create_handle = vmw_framebuffer_create_handle,
+};
+
+/**
+ * Pin the dmabuffer to the start of vram.
+ */
 static int vmw_framebuffer_dmabuf_pin(struct vmw_framebuffer *vfb)
 {
        struct vmw_private *dev_priv = vmw_priv(vfb->base.dev);
@@ -749,10 +854,12 @@ static int vmw_framebuffer_dmabuf_pin(struct vmw_framebuffer *vfb)
                vmw_framebuffer_to_vfbd(&vfb->base);
        int ret;
 
+       /* This code should not be used with screen objects */
+       BUG_ON(dev_priv->sou_priv);
 
        vmw_overlay_pause_all(dev_priv);
 
-       ret = vmw_dmabuf_to_start_of_vram(dev_priv, vfbd->buffer);
+       ret = vmw_dmabuf_to_start_of_vram(dev_priv, vfbd->buffer, true, false);
 
        vmw_overlay_resume_all(dev_priv);
 
@@ -772,7 +879,7 @@ static int vmw_framebuffer_dmabuf_unpin(struct vmw_framebuffer *vfb)
                return 0;
        }
 
-       return vmw_dmabuf_from_vram(dev_priv, vfbd->buffer);
+       return vmw_dmabuf_unpin(dev_priv, vfbd->buffer, false);
 }
 
 static int vmw_kms_new_framebuffer_dmabuf(struct vmw_private *dev_priv,
@@ -794,6 +901,33 @@ static int vmw_kms_new_framebuffer_dmabuf(struct vmw_private *dev_priv,
                return -EINVAL;
        }
 
+       /* Limited framebuffer color depth support for screen objects */
+       if (dev_priv->sou_priv) {
+               switch (mode_cmd->depth) {
+               case 32:
+               case 24:
+                       /* Only support 32 bpp for 32 and 24 depth fbs */
+                       if (mode_cmd->bpp == 32)
+                               break;
+
+                       DRM_ERROR("Invalid color depth/bbp: %d %d\n",
+                                 mode_cmd->depth, mode_cmd->bpp);
+                       return -EINVAL;
+               case 16:
+               case 15:
+                       /* Only support 16 bpp for 16 and 15 depth fbs */
+                       if (mode_cmd->bpp == 16)
+                               break;
+
+                       DRM_ERROR("Invalid color depth/bbp: %d %d\n",
+                                 mode_cmd->depth, mode_cmd->bpp);
+                       return -EINVAL;
+               default:
+                       DRM_ERROR("Invalid color depth: %d\n", mode_cmd->depth);
+                       return -EINVAL;
+               }
+       }
+
        vfbd = kzalloc(sizeof(*vfbd), GFP_KERNEL);
        if (!vfbd) {
                ret = -ENOMEM;
@@ -815,9 +949,13 @@ static int vmw_kms_new_framebuffer_dmabuf(struct vmw_private *dev_priv,
        vfbd->base.base.depth = mode_cmd->depth;
        vfbd->base.base.width = mode_cmd->width;
        vfbd->base.base.height = mode_cmd->height;
-       vfbd->base.pin = vmw_framebuffer_dmabuf_pin;
-       vfbd->base.unpin = vmw_framebuffer_dmabuf_unpin;
+       if (!dev_priv->sou_priv) {
+               vfbd->base.pin = vmw_framebuffer_dmabuf_pin;
+               vfbd->base.unpin = vmw_framebuffer_dmabuf_unpin;
+       }
+       vfbd->base.dmabuf = true;
        vfbd->buffer = dmabuf;
+       vfbd->base.user_handle = mode_cmd->handle;
        *out = &vfbd->base;
 
        return 0;
@@ -843,6 +981,7 @@ static struct drm_framebuffer *vmw_kms_fb_create(struct drm_device *dev,
        struct vmw_framebuffer *vfb = NULL;
        struct vmw_surface *surface = NULL;
        struct vmw_dma_buffer *bo = NULL;
+       struct ttm_base_object *user_obj;
        u64 required_size;
        int ret;
 
@@ -858,6 +997,21 @@ static struct drm_framebuffer *vmw_kms_fb_create(struct drm_device *dev,
                return NULL;
        }
 
+       /*
+        * Take a reference on the user object of the resource
+        * backing the kms fb. This ensures that user-space handle
+        * lookups on that resource will always work as long as
+        * it's registered with a kms framebuffer. This is important,
+        * since vmw_execbuf_process identifies resources in the
+        * command stream using user-space handles.
+        */
+
+       user_obj = ttm_base_object_lookup(tfile, mode_cmd->handle);
+       if (unlikely(user_obj == NULL)) {
+               DRM_ERROR("Could not locate requested kms frame buffer.\n");
+               return ERR_PTR(-ENOENT);
+       }
+
        /**
         * End conditioned code.
         */
@@ -878,8 +1032,10 @@ static struct drm_framebuffer *vmw_kms_fb_create(struct drm_device *dev,
 
        if (ret) {
                DRM_ERROR("failed to create vmw_framebuffer: %i\n", ret);
+               ttm_base_object_unref(&user_obj);
                return ERR_PTR(ret);
-       }
+       } else
+               vfb->user_obj = user_obj;
        return &vfb->base;
 
 try_dmabuf:
@@ -899,8 +1055,10 @@ try_dmabuf:
 
        if (ret) {
                DRM_ERROR("failed to create vmw_framebuffer: %i\n", ret);
+               ttm_base_object_unref(&user_obj);
                return ERR_PTR(ret);
-       }
+       } else
+               vfb->user_obj = user_obj;
 
        return &vfb->base;
 
@@ -908,6 +1066,7 @@ err_not_scanout:
        DRM_ERROR("surface not marked as scanout\n");
        /* vmw_user_surface_lookup takes one ref */
        vmw_surface_unreference(&surface);
+       ttm_base_object_unref(&user_obj);
 
        return ERR_PTR(-EINVAL);
 }
@@ -916,6 +1075,210 @@ static struct drm_mode_config_funcs vmw_kms_funcs = {
        .fb_create = vmw_kms_fb_create,
 };
 
+int vmw_kms_present(struct vmw_private *dev_priv,
+                   struct drm_file *file_priv,
+                   struct vmw_framebuffer *vfb,
+                   struct vmw_surface *surface,
+                   uint32_t sid,
+                   int32_t destX, int32_t destY,
+                   struct drm_vmw_rect *clips,
+                   uint32_t num_clips)
+{
+       struct vmw_display_unit *units[VMWGFX_NUM_DISPLAY_UNITS];
+       struct drm_crtc *crtc;
+       size_t fifo_size;
+       int i, k, num_units;
+       int ret = 0; /* silence warning */
+
+       struct {
+               SVGA3dCmdHeader header;
+               SVGA3dCmdBlitSurfaceToScreen body;
+       } *cmd;
+       SVGASignedRect *blits;
+
+       num_units = 0;
+       list_for_each_entry(crtc, &dev_priv->dev->mode_config.crtc_list, head) {
+               if (crtc->fb != &vfb->base)
+                       continue;
+               units[num_units++] = vmw_crtc_to_du(crtc);
+       }
+
+       BUG_ON(surface == NULL);
+       BUG_ON(!clips || !num_clips);
+
+       fifo_size = sizeof(*cmd) + sizeof(SVGASignedRect) * num_clips;
+       cmd = kmalloc(fifo_size, GFP_KERNEL);
+       if (unlikely(cmd == NULL)) {
+               DRM_ERROR("Failed to allocate temporary fifo memory.\n");
+               return -ENOMEM;
+       }
+
+       /* only need to do this once */
+       memset(cmd, 0, fifo_size);
+       cmd->header.id = cpu_to_le32(SVGA_3D_CMD_BLIT_SURFACE_TO_SCREEN);
+       cmd->header.size = cpu_to_le32(fifo_size - sizeof(cmd->header));
+
+       cmd->body.srcRect.left = 0;
+       cmd->body.srcRect.right = surface->sizes[0].width;
+       cmd->body.srcRect.top = 0;
+       cmd->body.srcRect.bottom = surface->sizes[0].height;
+
+       blits = (SVGASignedRect *)&cmd[1];
+       for (i = 0; i < num_clips; i++) {
+               blits[i].left   = clips[i].x;
+               blits[i].right  = clips[i].x + clips[i].w;
+               blits[i].top    = clips[i].y;
+               blits[i].bottom = clips[i].y + clips[i].h;
+       }
+
+       for (k = 0; k < num_units; k++) {
+               struct vmw_display_unit *unit = units[k];
+               int clip_x1 = destX - unit->crtc.x;
+               int clip_y1 = destY - unit->crtc.y;
+               int clip_x2 = clip_x1 + surface->sizes[0].width;
+               int clip_y2 = clip_y1 + surface->sizes[0].height;
+
+               /* skip any crtcs that misses the clip region */
+               if (clip_x1 >= unit->crtc.mode.hdisplay ||
+                   clip_y1 >= unit->crtc.mode.vdisplay ||
+                   clip_x2 <= 0 || clip_y2 <= 0)
+                       continue;
+
+               /* need to reset sid as it is changed by execbuf */
+               cmd->body.srcImage.sid = sid;
+
+               cmd->body.destScreenId = unit->unit;
+
+               /*
+                * The blit command is a lot more resilient then the
+                * readback command when it comes to clip rects. So its
+                * okay to go out of bounds.
+                */
+
+               cmd->body.destRect.left = clip_x1;
+               cmd->body.destRect.right = clip_x2;
+               cmd->body.destRect.top = clip_y1;
+               cmd->body.destRect.bottom = clip_y2;
+
+               ret = vmw_execbuf_process(file_priv, dev_priv, NULL, cmd,
+                                         fifo_size, 0, NULL);
+
+               if (unlikely(ret != 0))
+                       break;
+       }
+
+       kfree(cmd);
+
+       return ret;
+}
+
+int vmw_kms_readback(struct vmw_private *dev_priv,
+                    struct drm_file *file_priv,
+                    struct vmw_framebuffer *vfb,
+                    struct drm_vmw_fence_rep __user *user_fence_rep,
+                    struct drm_vmw_rect *clips,
+                    uint32_t num_clips)
+{
+       struct vmw_framebuffer_dmabuf *vfbd =
+               vmw_framebuffer_to_vfbd(&vfb->base);
+       struct vmw_dma_buffer *dmabuf = vfbd->buffer;
+       struct vmw_display_unit *units[VMWGFX_NUM_DISPLAY_UNITS];
+       struct drm_crtc *crtc;
+       size_t fifo_size;
+       int i, k, ret, num_units, blits_pos;
+
+       struct {
+               uint32_t header;
+               SVGAFifoCmdDefineGMRFB body;
+       } *cmd;
+       struct {
+               uint32_t header;
+               SVGAFifoCmdBlitScreenToGMRFB body;
+       } *blits;
+
+       num_units = 0;
+       list_for_each_entry(crtc, &dev_priv->dev->mode_config.crtc_list, head) {
+               if (crtc->fb != &vfb->base)
+                       continue;
+               units[num_units++] = vmw_crtc_to_du(crtc);
+       }
+
+       BUG_ON(dmabuf == NULL);
+       BUG_ON(!clips || !num_clips);
+
+       /* take a safe guess at fifo size */
+       fifo_size = sizeof(*cmd) + sizeof(*blits) * num_clips * num_units;
+       cmd = kmalloc(fifo_size, GFP_KERNEL);
+       if (unlikely(cmd == NULL)) {
+               DRM_ERROR("Failed to allocate temporary fifo memory.\n");
+               return -ENOMEM;
+       }
+
+       memset(cmd, 0, fifo_size);
+       cmd->header = SVGA_CMD_DEFINE_GMRFB;
+       cmd->body.format.bitsPerPixel = vfb->base.bits_per_pixel;
+       cmd->body.format.colorDepth = vfb->base.depth;
+       cmd->body.format.reserved = 0;
+       cmd->body.bytesPerLine = vfb->base.pitch;
+       cmd->body.ptr.gmrId = vfb->user_handle;
+       cmd->body.ptr.offset = 0;
+
+       blits = (void *)&cmd[1];
+       blits_pos = 0;
+       for (i = 0; i < num_units; i++) {
+               struct drm_vmw_rect *c = clips;
+               for (k = 0; k < num_clips; k++, c++) {
+                       /* transform clip coords to crtc origin based coords */
+                       int clip_x1 = c->x - units[i]->crtc.x;
+                       int clip_x2 = c->x - units[i]->crtc.x + c->w;
+                       int clip_y1 = c->y - units[i]->crtc.y;
+                       int clip_y2 = c->y - units[i]->crtc.y + c->h;
+                       int dest_x = c->x;
+                       int dest_y = c->y;
+
+                       /* compensate for clipping, we negate
+                        * a negative number and add that.
+                        */
+                       if (clip_x1 < 0)
+                               dest_x += -clip_x1;
+                       if (clip_y1 < 0)
+                               dest_y += -clip_y1;
+
+                       /* clip */
+                       clip_x1 = max(clip_x1, 0);
+                       clip_y1 = max(clip_y1, 0);
+                       clip_x2 = min(clip_x2, units[i]->crtc.mode.hdisplay);
+                       clip_y2 = min(clip_y2, units[i]->crtc.mode.vdisplay);
+
+                       /* and cull any rects that misses the crtc */
+                       if (clip_x1 >= units[i]->crtc.mode.hdisplay ||
+                           clip_y1 >= units[i]->crtc.mode.vdisplay ||
+                           clip_x2 <= 0 || clip_y2 <= 0)
+                               continue;
+
+                       blits[blits_pos].header = SVGA_CMD_BLIT_SCREEN_TO_GMRFB;
+                       blits[blits_pos].body.srcScreenId = units[i]->unit;
+                       blits[blits_pos].body.destOrigin.x = dest_x;
+                       blits[blits_pos].body.destOrigin.y = dest_y;
+
+                       blits[blits_pos].body.srcRect.left = clip_x1;
+                       blits[blits_pos].body.srcRect.top = clip_y1;
+                       blits[blits_pos].body.srcRect.right = clip_x2;
+                       blits[blits_pos].body.srcRect.bottom = clip_y2;
+                       blits_pos++;
+               }
+       }
+       /* reset size here and use calculated exact size from loops */
+       fifo_size = sizeof(*cmd) + sizeof(*blits) * blits_pos;
+
+       ret = vmw_execbuf_process(file_priv, dev_priv, NULL, cmd, fifo_size,
+                                 0, user_fence_rep);
+
+       kfree(cmd);
+
+       return ret;
+}
+
 int vmw_kms_init(struct vmw_private *dev_priv)
 {
        struct drm_device *dev = dev_priv->dev;
@@ -929,7 +1292,9 @@ int vmw_kms_init(struct vmw_private *dev_priv)
        dev->mode_config.max_width = 8192;
        dev->mode_config.max_height = 8192;
 
-       ret = vmw_kms_init_legacy_display_system(dev_priv);
+       ret = vmw_kms_init_screen_object_display(dev_priv);
+       if (ret) /* Fallback */
+               (void)vmw_kms_init_legacy_display_system(dev_priv);
 
        return 0;
 }
@@ -987,9 +1352,9 @@ out:
        return ret;
 }
 
-void vmw_kms_write_svga(struct vmw_private *vmw_priv,
+int vmw_kms_write_svga(struct vmw_private *vmw_priv,
                        unsigned width, unsigned height, unsigned pitch,
-                       unsigned bbp, unsigned depth)
+                       unsigned bpp, unsigned depth)
 {
        if (vmw_priv->capabilities & SVGA_CAP_PITCHLOCK)
                vmw_write(vmw_priv, SVGA_REG_PITCHLOCK, pitch);
@@ -997,11 +1362,15 @@ void vmw_kms_write_svga(struct vmw_private *vmw_priv,
                iowrite32(pitch, vmw_priv->mmio_virt + SVGA_FIFO_PITCHLOCK);
        vmw_write(vmw_priv, SVGA_REG_WIDTH, width);
        vmw_write(vmw_priv, SVGA_REG_HEIGHT, height);
-       vmw_write(vmw_priv, SVGA_REG_BITS_PER_PIXEL, bbp);
-       vmw_write(vmw_priv, SVGA_REG_DEPTH, depth);
-       vmw_write(vmw_priv, SVGA_REG_RED_MASK, 0x00ff0000);
-       vmw_write(vmw_priv, SVGA_REG_GREEN_MASK, 0x0000ff00);
-       vmw_write(vmw_priv, SVGA_REG_BLUE_MASK, 0x000000ff);
+       vmw_write(vmw_priv, SVGA_REG_BITS_PER_PIXEL, bpp);
+
+       if (vmw_read(vmw_priv, SVGA_REG_DEPTH) != depth) {
+               DRM_ERROR("Invalid depth %u for %u bpp, host expects %u\n",
+                         depth, bpp, vmw_read(vmw_priv, SVGA_REG_DEPTH));
+               return -EINVAL;
+       }
+
+       return 0;
 }
 
 int vmw_kms_save_vga(struct vmw_private *vmw_priv)
@@ -1011,12 +1380,7 @@ int vmw_kms_save_vga(struct vmw_private *vmw_priv)
 
        vmw_priv->vga_width = vmw_read(vmw_priv, SVGA_REG_WIDTH);
        vmw_priv->vga_height = vmw_read(vmw_priv, SVGA_REG_HEIGHT);
-       vmw_priv->vga_depth = vmw_read(vmw_priv, SVGA_REG_DEPTH);
        vmw_priv->vga_bpp = vmw_read(vmw_priv, SVGA_REG_BITS_PER_PIXEL);
-       vmw_priv->vga_pseudo = vmw_read(vmw_priv, SVGA_REG_PSEUDOCOLOR);
-       vmw_priv->vga_red_mask = vmw_read(vmw_priv, SVGA_REG_RED_MASK);
-       vmw_priv->vga_blue_mask = vmw_read(vmw_priv, SVGA_REG_BLUE_MASK);
-       vmw_priv->vga_green_mask = vmw_read(vmw_priv, SVGA_REG_GREEN_MASK);
        if (vmw_priv->capabilities & SVGA_CAP_PITCHLOCK)
                vmw_priv->vga_pitchlock =
                  vmw_read(vmw_priv, SVGA_REG_PITCHLOCK);
@@ -1065,12 +1429,7 @@ int vmw_kms_restore_vga(struct vmw_private *vmw_priv)
 
        vmw_write(vmw_priv, SVGA_REG_WIDTH, vmw_priv->vga_width);
        vmw_write(vmw_priv, SVGA_REG_HEIGHT, vmw_priv->vga_height);
-       vmw_write(vmw_priv, SVGA_REG_DEPTH, vmw_priv->vga_depth);
        vmw_write(vmw_priv, SVGA_REG_BITS_PER_PIXEL, vmw_priv->vga_bpp);
-       vmw_write(vmw_priv, SVGA_REG_PSEUDOCOLOR, vmw_priv->vga_pseudo);
-       vmw_write(vmw_priv, SVGA_REG_RED_MASK, vmw_priv->vga_red_mask);
-       vmw_write(vmw_priv, SVGA_REG_GREEN_MASK, vmw_priv->vga_green_mask);
-       vmw_write(vmw_priv, SVGA_REG_BLUE_MASK, vmw_priv->vga_blue_mask);
        if (vmw_priv->capabilities & SVGA_CAP_PITCHLOCK)
                vmw_write(vmw_priv, SVGA_REG_PITCHLOCK,
                          vmw_priv->vga_pitchlock);
@@ -1095,60 +1454,272 @@ int vmw_kms_restore_vga(struct vmw_private *vmw_priv)
        return 0;
 }
 
-int vmw_kms_update_layout_ioctl(struct drm_device *dev, void *data,
-                               struct drm_file *file_priv)
+bool vmw_kms_validate_mode_vram(struct vmw_private *dev_priv,
+                               uint32_t pitch,
+                               uint32_t height)
 {
-       struct vmw_private *dev_priv = vmw_priv(dev);
-       struct drm_vmw_update_layout_arg *arg =
-               (struct drm_vmw_update_layout_arg *)data;
-       struct vmw_master *vmaster = vmw_master(file_priv->master);
-       void __user *user_rects;
-       struct drm_vmw_rect *rects;
-       unsigned rects_size;
-       int ret;
+       return ((u64) pitch * (u64) height) < (u64) dev_priv->vram_size;
+}
 
-       ret = ttm_read_lock(&vmaster->lock, true);
-       if (unlikely(ret != 0))
-               return ret;
 
-       if (!arg->num_outputs) {
-               struct drm_vmw_rect def_rect = {0, 0, 800, 600};
-               vmw_kms_ldu_update_layout(dev_priv, 1, &def_rect);
-               goto out_unlock;
-       }
+/**
+ * Function called by DRM code called with vbl_lock held.
+ */
+u32 vmw_get_vblank_counter(struct drm_device *dev, int crtc)
+{
+       return 0;
+}
 
-       rects_size = arg->num_outputs * sizeof(struct drm_vmw_rect);
-       rects = kzalloc(rects_size, GFP_KERNEL);
-       if (unlikely(!rects)) {
-               ret = -ENOMEM;
-               goto out_unlock;
+/**
+ * Function called by DRM code called with vbl_lock held.
+ */
+int vmw_enable_vblank(struct drm_device *dev, int crtc)
+{
+       return -ENOSYS;
+}
+
+/**
+ * Function called by DRM code called with vbl_lock held.
+ */
+void vmw_disable_vblank(struct drm_device *dev, int crtc)
+{
+}
+
+
+/*
+ * Small shared kms functions.
+ */
+
+int vmw_du_update_layout(struct vmw_private *dev_priv, unsigned num,
+                        struct drm_vmw_rect *rects)
+{
+       struct drm_device *dev = dev_priv->dev;
+       struct vmw_display_unit *du;
+       struct drm_connector *con;
+
+       mutex_lock(&dev->mode_config.mutex);
+
+#if 0
+       {
+               unsigned int i;
+
+               DRM_INFO("%s: new layout ", __func__);
+               for (i = 0; i < num; i++)
+                       DRM_INFO("(%i, %i %ux%u) ", rects[i].x, rects[i].y,
+                                rects[i].w, rects[i].h);
+               DRM_INFO("\n");
+       }
+#endif
+
+       list_for_each_entry(con, &dev->mode_config.connector_list, head) {
+               du = vmw_connector_to_du(con);
+               if (num > du->unit) {
+                       du->pref_width = rects[du->unit].w;
+                       du->pref_height = rects[du->unit].h;
+                       du->pref_active = true;
+               } else {
+                       du->pref_width = 800;
+                       du->pref_height = 600;
+                       du->pref_active = false;
+               }
+               con->status = vmw_du_connector_detect(con, true);
        }
 
-       user_rects = (void __user *)(unsigned long)arg->rects;
-       ret = copy_from_user(rects, user_rects, rects_size);
-       if (unlikely(ret != 0)) {
-               DRM_ERROR("Failed to get rects.\n");
-               ret = -EFAULT;
-               goto out_free;
+       mutex_unlock(&dev->mode_config.mutex);
+
+       return 0;
+}
+
+void vmw_du_crtc_save(struct drm_crtc *crtc)
+{
+}
+
+void vmw_du_crtc_restore(struct drm_crtc *crtc)
+{
+}
+
+void vmw_du_crtc_gamma_set(struct drm_crtc *crtc,
+                          u16 *r, u16 *g, u16 *b,
+                          uint32_t start, uint32_t size)
+{
+       struct vmw_private *dev_priv = vmw_priv(crtc->dev);
+       int i;
+
+       for (i = 0; i < size; i++) {
+               DRM_DEBUG("%d r/g/b = 0x%04x / 0x%04x / 0x%04x\n", i,
+                         r[i], g[i], b[i]);
+               vmw_write(dev_priv, SVGA_PALETTE_BASE + i * 3 + 0, r[i] >> 8);
+               vmw_write(dev_priv, SVGA_PALETTE_BASE + i * 3 + 1, g[i] >> 8);
+               vmw_write(dev_priv, SVGA_PALETTE_BASE + i * 3 + 2, b[i] >> 8);
        }
+}
 
-       vmw_kms_ldu_update_layout(dev_priv, arg->num_outputs, rects);
+void vmw_du_connector_dpms(struct drm_connector *connector, int mode)
+{
+}
 
-out_free:
-       kfree(rects);
-out_unlock:
-       ttm_read_unlock(&vmaster->lock);
-       return ret;
+void vmw_du_connector_save(struct drm_connector *connector)
+{
 }
 
-bool vmw_kms_validate_mode_vram(struct vmw_private *dev_priv,
-                               uint32_t pitch,
-                               uint32_t height)
+void vmw_du_connector_restore(struct drm_connector *connector)
 {
-       return ((u64) pitch * (u64) height) < (u64) dev_priv->vram_size;
 }
 
-u32 vmw_get_vblank_counter(struct drm_device *dev, int crtc)
+enum drm_connector_status
+vmw_du_connector_detect(struct drm_connector *connector, bool force)
+{
+       uint32_t num_displays;
+       struct drm_device *dev = connector->dev;
+       struct vmw_private *dev_priv = vmw_priv(dev);
+
+       mutex_lock(&dev_priv->hw_mutex);
+       num_displays = vmw_read(dev_priv, SVGA_REG_NUM_DISPLAYS);
+       mutex_unlock(&dev_priv->hw_mutex);
+
+       return ((vmw_connector_to_du(connector)->unit < num_displays) ?
+               connector_status_connected : connector_status_disconnected);
+}
+
+static struct drm_display_mode vmw_kms_connector_builtin[] = {
+       /* 640x480@60Hz */
+       { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 25175, 640, 656,
+                  752, 800, 0, 480, 489, 492, 525, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) },
+       /* 800x600@60Hz */
+       { DRM_MODE("800x600", DRM_MODE_TYPE_DRIVER, 40000, 800, 840,
+                  968, 1056, 0, 600, 601, 605, 628, 0,
+                  DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1024x768@60Hz */
+       { DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 65000, 1024, 1048,
+                  1184, 1344, 0, 768, 771, 777, 806, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) },
+       /* 1152x864@75Hz */
+       { DRM_MODE("1152x864", DRM_MODE_TYPE_DRIVER, 108000, 1152, 1216,
+                  1344, 1600, 0, 864, 865, 868, 900, 0,
+                  DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1280x768@60Hz */
+       { DRM_MODE("1280x768", DRM_MODE_TYPE_DRIVER, 79500, 1280, 1344,
+                  1472, 1664, 0, 768, 771, 778, 798, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1280x800@60Hz */
+       { DRM_MODE("1280x800", DRM_MODE_TYPE_DRIVER, 83500, 1280, 1352,
+                  1480, 1680, 0, 800, 803, 809, 831, 0,
+                  DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
+       /* 1280x960@60Hz */
+       { DRM_MODE("1280x960", DRM_MODE_TYPE_DRIVER, 108000, 1280, 1376,
+                  1488, 1800, 0, 960, 961, 964, 1000, 0,
+                  DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1280x1024@60Hz */
+       { DRM_MODE("1280x1024", DRM_MODE_TYPE_DRIVER, 108000, 1280, 1328,
+                  1440, 1688, 0, 1024, 1025, 1028, 1066, 0,
+                  DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1360x768@60Hz */
+       { DRM_MODE("1360x768", DRM_MODE_TYPE_DRIVER, 85500, 1360, 1424,
+                  1536, 1792, 0, 768, 771, 777, 795, 0,
+                  DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1440x1050@60Hz */
+       { DRM_MODE("1400x1050", DRM_MODE_TYPE_DRIVER, 121750, 1400, 1488,
+                  1632, 1864, 0, 1050, 1053, 1057, 1089, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1440x900@60Hz */
+       { DRM_MODE("1440x900", DRM_MODE_TYPE_DRIVER, 106500, 1440, 1520,
+                  1672, 1904, 0, 900, 903, 909, 934, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1600x1200@60Hz */
+       { DRM_MODE("1600x1200", DRM_MODE_TYPE_DRIVER, 162000, 1600, 1664,
+                  1856, 2160, 0, 1200, 1201, 1204, 1250, 0,
+                  DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1680x1050@60Hz */
+       { DRM_MODE("1680x1050", DRM_MODE_TYPE_DRIVER, 146250, 1680, 1784,
+                  1960, 2240, 0, 1050, 1053, 1059, 1089, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1792x1344@60Hz */
+       { DRM_MODE("1792x1344", DRM_MODE_TYPE_DRIVER, 204750, 1792, 1920,
+                  2120, 2448, 0, 1344, 1345, 1348, 1394, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1853x1392@60Hz */
+       { DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 218250, 1856, 1952,
+                  2176, 2528, 0, 1392, 1393, 1396, 1439, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1920x1200@60Hz */
+       { DRM_MODE("1920x1200", DRM_MODE_TYPE_DRIVER, 193250, 1920, 2056,
+                  2256, 2592, 0, 1200, 1203, 1209, 1245, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 1920x1440@60Hz */
+       { DRM_MODE("1920x1440", DRM_MODE_TYPE_DRIVER, 234000, 1920, 2048,
+                  2256, 2600, 0, 1440, 1441, 1444, 1500, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* 2560x1600@60Hz */
+       { DRM_MODE("2560x1600", DRM_MODE_TYPE_DRIVER, 348500, 2560, 2752,
+                  3032, 3504, 0, 1600, 1603, 1609, 1658, 0,
+                  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
+       /* Terminate */
+       { DRM_MODE("", 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0) },
+};
+
+int vmw_du_connector_fill_modes(struct drm_connector *connector,
+                               uint32_t max_width, uint32_t max_height)
+{
+       struct vmw_display_unit *du = vmw_connector_to_du(connector);
+       struct drm_device *dev = connector->dev;
+       struct vmw_private *dev_priv = vmw_priv(dev);
+       struct drm_display_mode *mode = NULL;
+       struct drm_display_mode *bmode;
+       struct drm_display_mode prefmode = { DRM_MODE("preferred",
+               DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
+               0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+               DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC)
+       };
+       int i;
+
+       /* Add preferred mode */
+       {
+               mode = drm_mode_duplicate(dev, &prefmode);
+               if (!mode)
+                       return 0;
+               mode->hdisplay = du->pref_width;
+               mode->vdisplay = du->pref_height;
+               mode->vrefresh = drm_mode_vrefresh(mode);
+               if (vmw_kms_validate_mode_vram(dev_priv, mode->hdisplay * 2,
+                                              mode->vdisplay)) {
+                       drm_mode_probed_add(connector, mode);
+
+                       if (du->pref_mode) {
+                               list_del_init(&du->pref_mode->head);
+                               drm_mode_destroy(dev, du->pref_mode);
+                       }
+
+                       du->pref_mode = mode;
+               }
+       }
+
+       for (i = 0; vmw_kms_connector_builtin[i].type != 0; i++) {
+               bmode = &vmw_kms_connector_builtin[i];
+               if (bmode->hdisplay > max_width ||
+                   bmode->vdisplay > max_height)
+                       continue;
+
+               if (!vmw_kms_validate_mode_vram(dev_priv, bmode->hdisplay * 2,
+                                               bmode->vdisplay))
+                       continue;
+
+               mode = drm_mode_duplicate(dev, bmode);
+               if (!mode)
+                       return 0;
+               mode->vrefresh = drm_mode_vrefresh(mode);
+
+               drm_mode_probed_add(connector, mode);
+       }
+
+       drm_mode_connector_list_update(connector);
+
+       return 1;
+}
+
+int vmw_du_connector_set_property(struct drm_connector *connector,
+                                 struct drm_property *property,
+                                 uint64_t val)
 {
        return 0;
 }