Kobject: convert drivers/* from kobject_unregister() to kobject_put()
[pandora-kernel.git] / drivers / base / sys.c
index 18febe2..e666441 100644 (file)
@@ -25,8 +25,6 @@
 
 #include "base.h"
 
-extern struct kset devices_subsys;
-
 #define to_sysdev(k) container_of(k, struct sys_device, kobj)
 #define to_sysdev_attr(a) container_of(a, struct sysdev_attribute, attr)
 
@@ -128,18 +126,16 @@ void sysdev_class_remove_file(struct sysdev_class *c,
 }
 EXPORT_SYMBOL_GPL(sysdev_class_remove_file);
 
-/*
- * declare system_subsys
- */
-static decl_subsys(system, &ktype_sysdev_class, NULL);
+static struct kset *system_kset;
 
 int sysdev_class_register(struct sysdev_class * cls)
 {
        pr_debug("Registering sysdev class '%s'\n",
                 kobject_name(&cls->kset.kobj));
        INIT_LIST_HEAD(&cls->drivers);
-       cls->kset.kobj.parent = &system_subsys.kobj;
-       kset_set_kset_s(cls, system_subsys);
+       cls->kset.kobj.parent = &system_kset->kobj;
+       cls->kset.kobj.ktype = &ktype_sysdev_class;
+       cls->kset.kobj.kset = system_kset;
        return kset_register(&cls->kset);
 }
 
@@ -153,25 +149,22 @@ void sysdev_class_unregister(struct sysdev_class * cls)
 EXPORT_SYMBOL_GPL(sysdev_class_register);
 EXPORT_SYMBOL_GPL(sysdev_class_unregister);
 
-
-static LIST_HEAD(sysdev_drivers);
 static DEFINE_MUTEX(sysdev_drivers_lock);
 
 /**
  *     sysdev_driver_register - Register auxillary driver
- *     @cls:   Device class driver belongs to.
+ *     @cls:   Device class driver belongs to.
  *     @drv:   Driver.
  *
- *     If @cls is valid, then @drv is inserted into @cls->drivers to be
+ *     @drv is inserted into @cls->drivers to be
  *     called on each operation on devices of that class. The refcount
  *     of @cls is incremented.
- *     Otherwise, @drv is inserted into sysdev_drivers, and called for
- *     each device.
  */
 
-int sysdev_driver_register(struct sysdev_class * cls,
-                          struct sysdev_driver * drv)
+int sysdev_driver_register(struct sysdev_class *cls, struct sysdev_driver *drv)
 {
+       int err = 0;
+
        mutex_lock(&sysdev_drivers_lock);
        if (cls && kset_get(&cls->kset)) {
                list_add_tail(&drv->entry, &cls->drivers);
@@ -182,10 +175,13 @@ int sysdev_driver_register(struct sysdev_class * cls,
                        list_for_each_entry(dev, &cls->kset.list, kobj.entry)
                                drv->add(dev);
                }
-       } else
-               list_add_tail(&drv->entry, &sysdev_drivers);
+       } else {
+               err = -EINVAL;
+               printk(KERN_ERR "%s: invalid device class\n", __FUNCTION__);
+               WARN_ON(1);
+       }
        mutex_unlock(&sysdev_drivers_lock);
-       return 0;
+       return err;
 }
 
 
@@ -228,20 +224,15 @@ int sysdev_register(struct sys_device * sysdev)
        if (!cls)
                return -EINVAL;
 
+       pr_debug("Registering sys device '%s'\n", kobject_name(&sysdev->kobj));
+
        /* Make sure the kset is set */
        sysdev->kobj.kset = &cls->kset;
 
-       /* But make sure we point to the right type for sysfs translation */
-       sysdev->kobj.ktype = &ktype_sysdev;
-       error = kobject_set_name(&sysdev->kobj, "%s%d",
-                        kobject_name(&cls->kset.kobj), sysdev->id);
-       if (error)
-               return error;
-
-       pr_debug("Registering sys device '%s'\n", kobject_name(&sysdev->kobj));
-
        /* Register the object */
-       error = kobject_register(&sysdev->kobj);
+       error = kobject_init_and_add(&sysdev->kobj, &ktype_sysdev, NULL,
+                                    "%s%d", kobject_name(&cls->kset.kobj),
+                                    sysdev->id);
 
        if (!error) {
                struct sysdev_driver * drv;
@@ -251,12 +242,6 @@ int sysdev_register(struct sys_device * sysdev)
                 * code that should have called us.
                 */
 
-               /* Notify global drivers */
-               list_for_each_entry(drv, &sysdev_drivers, entry) {
-                       if (drv->add)
-                               drv->add(sysdev);
-               }
-
                /* Notify class auxillary drivers */
                list_for_each_entry(drv, &cls->drivers, entry) {
                        if (drv->add)
@@ -264,6 +249,7 @@ int sysdev_register(struct sys_device * sysdev)
                }
                mutex_unlock(&sysdev_drivers_lock);
        }
+       kobject_uevent(&sysdev->kobj, KOBJ_ADD);
        return error;
 }
 
@@ -272,18 +258,13 @@ void sysdev_unregister(struct sys_device * sysdev)
        struct sysdev_driver * drv;
 
        mutex_lock(&sysdev_drivers_lock);
-       list_for_each_entry(drv, &sysdev_drivers, entry) {
-               if (drv->remove)
-                       drv->remove(sysdev);
-       }
-
        list_for_each_entry(drv, &sysdev->cls->drivers, entry) {
                if (drv->remove)
                        drv->remove(sysdev);
        }
        mutex_unlock(&sysdev_drivers_lock);
 
-       kobject_unregister(&sysdev->kobj);
+       kobject_put(&sysdev->kobj);
 }
 
 
@@ -293,7 +274,7 @@ void sysdev_unregister(struct sys_device * sysdev)
  *
  *     Loop over each class of system devices, and the devices in each
  *     of those classes. For each device, we call the shutdown method for
- *     each driver registered for the device - the globals, the auxillaries,
+ *     each driver registered for the device - the auxillaries,
  *     and the class driver.
  *
  *     Note: The list is iterated in reverse order, so that we shut down
@@ -309,8 +290,7 @@ void sysdev_shutdown(void)
        pr_debug("Shutting Down System Devices\n");
 
        mutex_lock(&sysdev_drivers_lock);
-       list_for_each_entry_reverse(cls, &system_subsys.list,
-                                   kset.kobj.entry) {
+       list_for_each_entry_reverse(cls, &system_kset->list, kset.kobj.entry) {
                struct sys_device * sysdev;
 
                pr_debug("Shutting down type '%s':\n",
@@ -320,13 +300,7 @@ void sysdev_shutdown(void)
                        struct sysdev_driver * drv;
                        pr_debug(" %s\n", kobject_name(&sysdev->kobj));
 
-                       /* Call global drivers first. */
-                       list_for_each_entry(drv, &sysdev_drivers, entry) {
-                               if (drv->shutdown)
-                                       drv->shutdown(sysdev);
-                       }
-
-                       /* Call auxillary drivers next. */
+                       /* Call auxillary drivers first */
                        list_for_each_entry(drv, &cls->drivers, entry) {
                                if (drv->shutdown)
                                        drv->shutdown(sysdev);
@@ -354,12 +328,6 @@ static void __sysdev_resume(struct sys_device *dev)
                if (drv->resume)
                        drv->resume(dev);
        }
-
-       /* Call global drivers. */
-       list_for_each_entry(drv, &sysdev_drivers, entry) {
-               if (drv->resume)
-                       drv->resume(dev);
-       }
 }
 
 /**
@@ -384,25 +352,14 @@ int sysdev_suspend(pm_message_t state)
 
        pr_debug("Suspending System Devices\n");
 
-       list_for_each_entry_reverse(cls, &system_subsys.list,
-                                   kset.kobj.entry) {
-
+       list_for_each_entry_reverse(cls, &system_kset->list, kset.kobj.entry) {
                pr_debug("Suspending type '%s':\n",
                         kobject_name(&cls->kset.kobj));
 
                list_for_each_entry(sysdev, &cls->kset.list, kobj.entry) {
                        pr_debug(" %s\n", kobject_name(&sysdev->kobj));
 
-                       /* Call global drivers first. */
-                       list_for_each_entry(drv, &sysdev_drivers, entry) {
-                               if (drv->suspend) {
-                                       ret = drv->suspend(sysdev, state);
-                                       if (ret)
-                                               goto gbl_driver;
-                               }
-                       }
-
-                       /* Call auxillary drivers next. */
+                       /* Call auxillary drivers first */
                        list_for_each_entry(drv, &cls->drivers, entry) {
                                if (drv->suspend) {
                                        ret = drv->suspend(sysdev, state);
@@ -436,18 +393,7 @@ aux_driver:
                if (err_drv->resume)
                        err_drv->resume(sysdev);
        }
-       drv = NULL;
 
-gbl_driver:
-       if (drv)
-               printk(KERN_ERR "sysdev driver suspend failed for %s\n",
-                               kobject_name(&sysdev->kobj));
-       list_for_each_entry(err_drv, &sysdev_drivers, entry) {
-               if (err_drv == drv)
-                       break;
-               if (err_drv->resume)
-                       err_drv->resume(sysdev);
-       }
        /* resume other sysdevs in current class */
        list_for_each_entry(err_dev, &cls->kset.list, kobj.entry) {
                if (err_dev == sysdev)
@@ -457,8 +403,7 @@ gbl_driver:
        }
 
        /* resume other classes */
-       list_for_each_entry_continue(cls, &system_subsys.list,
-                                       kset.kobj.entry) {
+       list_for_each_entry_continue(cls, &system_kset->list, kset.kobj.entry) {
                list_for_each_entry(err_dev, &cls->kset.list, kobj.entry) {
                        pr_debug(" %s\n", kobject_name(&err_dev->kobj));
                        __sysdev_resume(err_dev);
@@ -483,7 +428,7 @@ int sysdev_resume(void)
 
        pr_debug("Resuming System Devices\n");
 
-       list_for_each_entry(cls, &system_subsys.list, kset.kobj.entry) {
+       list_for_each_entry(cls, &system_kset->list, kset.kobj.entry) {
                struct sys_device * sysdev;
 
                pr_debug("Resuming type '%s':\n",
@@ -501,8 +446,10 @@ int sysdev_resume(void)
 
 int __init system_bus_init(void)
 {
-       system_subsys.kobj.parent = &devices_subsys.kobj;
-       return subsystem_register(&system_subsys);
+       system_kset = kset_create_and_add("system", NULL, &devices_kset->kobj);
+       if (!system_kset)
+               return -ENOMEM;
+       return 0;
 }
 
 EXPORT_SYMBOL_GPL(sysdev_register);