Merge tag 'v3.6-rc2' into drm-intel-next
[pandora-kernel.git] / drivers / gpu / drm / i915 / intel_sdvo.c
1 /*
2  * Copyright 2006 Dave Airlie <airlied@linux.ie>
3  * Copyright © 2006-2007 Intel Corporation
4  *   Jesse Barnes <jesse.barnes@intel.com>
5  *
6  * Permission is hereby granted, free of charge, to any person obtaining a
7  * copy of this software and associated documentation files (the "Software"),
8  * to deal in the Software without restriction, including without limitation
9  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10  * and/or sell copies of the Software, and to permit persons to whom the
11  * Software is furnished to do so, subject to the following conditions:
12  *
13  * The above copyright notice and this permission notice (including the next
14  * paragraph) shall be included in all copies or substantial portions of the
15  * Software.
16  *
17  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
20  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
22  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
23  * DEALINGS IN THE SOFTWARE.
24  *
25  * Authors:
26  *      Eric Anholt <eric@anholt.net>
27  */
28 #include <linux/i2c.h>
29 #include <linux/slab.h>
30 #include <linux/delay.h>
31 #include <linux/export.h>
32 #include "drmP.h"
33 #include "drm.h"
34 #include "drm_crtc.h"
35 #include "drm_edid.h"
36 #include "intel_drv.h"
37 #include "i915_drm.h"
38 #include "i915_drv.h"
39 #include "intel_sdvo_regs.h"
40
41 #define SDVO_TMDS_MASK (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_TMDS1)
42 #define SDVO_RGB_MASK  (SDVO_OUTPUT_RGB0 | SDVO_OUTPUT_RGB1)
43 #define SDVO_LVDS_MASK (SDVO_OUTPUT_LVDS0 | SDVO_OUTPUT_LVDS1)
44 #define SDVO_TV_MASK   (SDVO_OUTPUT_CVBS0 | SDVO_OUTPUT_SVID0 | SDVO_OUTPUT_YPRPB0)
45
46 #define SDVO_OUTPUT_MASK (SDVO_TMDS_MASK | SDVO_RGB_MASK | SDVO_LVDS_MASK |\
47                         SDVO_TV_MASK)
48
49 #define IS_TV(c)        (c->output_flag & SDVO_TV_MASK)
50 #define IS_TMDS(c)      (c->output_flag & SDVO_TMDS_MASK)
51 #define IS_LVDS(c)      (c->output_flag & SDVO_LVDS_MASK)
52 #define IS_TV_OR_LVDS(c) (c->output_flag & (SDVO_TV_MASK | SDVO_LVDS_MASK))
53 #define IS_DIGITAL(c) (c->output_flag & (SDVO_TMDS_MASK | SDVO_LVDS_MASK))
54
55
56 static const char *tv_format_names[] = {
57         "NTSC_M"   , "NTSC_J"  , "NTSC_443",
58         "PAL_B"    , "PAL_D"   , "PAL_G"   ,
59         "PAL_H"    , "PAL_I"   , "PAL_M"   ,
60         "PAL_N"    , "PAL_NC"  , "PAL_60"  ,
61         "SECAM_B"  , "SECAM_D" , "SECAM_G" ,
62         "SECAM_K"  , "SECAM_K1", "SECAM_L" ,
63         "SECAM_60"
64 };
65
66 #define TV_FORMAT_NUM  (sizeof(tv_format_names) / sizeof(*tv_format_names))
67
68 struct intel_sdvo {
69         struct intel_encoder base;
70
71         struct i2c_adapter *i2c;
72         u8 slave_addr;
73
74         struct i2c_adapter ddc;
75
76         /* Register for the SDVO device: SDVOB or SDVOC */
77         uint32_t sdvo_reg;
78
79         /* Active outputs controlled by this SDVO output */
80         uint16_t controlled_output;
81
82         /*
83          * Capabilities of the SDVO device returned by
84          * i830_sdvo_get_capabilities()
85          */
86         struct intel_sdvo_caps caps;
87
88         /* Pixel clock limitations reported by the SDVO device, in kHz */
89         int pixel_clock_min, pixel_clock_max;
90
91         /*
92         * For multiple function SDVO device,
93         * this is for current attached outputs.
94         */
95         uint16_t attached_output;
96
97         /*
98          * Hotplug activation bits for this device
99          */
100         uint8_t hotplug_active[2];
101
102         /**
103          * This is used to select the color range of RBG outputs in HDMI mode.
104          * It is only valid when using TMDS encoding and 8 bit per color mode.
105          */
106         uint32_t color_range;
107
108         /**
109          * This is set if we're going to treat the device as TV-out.
110          *
111          * While we have these nice friendly flags for output types that ought
112          * to decide this for us, the S-Video output on our HDMI+S-Video card
113          * shows up as RGB1 (VGA).
114          */
115         bool is_tv;
116
117         /* On different gens SDVOB is at different places. */
118         bool is_sdvob;
119
120         /* This is for current tv format name */
121         int tv_format_index;
122
123         /**
124          * This is set if we treat the device as HDMI, instead of DVI.
125          */
126         bool is_hdmi;
127         bool has_hdmi_monitor;
128         bool has_hdmi_audio;
129
130         /**
131          * This is set if we detect output of sdvo device as LVDS and
132          * have a valid fixed mode to use with the panel.
133          */
134         bool is_lvds;
135
136         /**
137          * This is sdvo fixed pannel mode pointer
138          */
139         struct drm_display_mode *sdvo_lvds_fixed_mode;
140
141         /* DDC bus used by this SDVO encoder */
142         uint8_t ddc_bus;
143 };
144
145 struct intel_sdvo_connector {
146         struct intel_connector base;
147
148         /* Mark the type of connector */
149         uint16_t output_flag;
150
151         enum hdmi_force_audio force_audio;
152
153         /* This contains all current supported TV format */
154         u8 tv_format_supported[TV_FORMAT_NUM];
155         int   format_supported_num;
156         struct drm_property *tv_format;
157
158         /* add the property for the SDVO-TV */
159         struct drm_property *left;
160         struct drm_property *right;
161         struct drm_property *top;
162         struct drm_property *bottom;
163         struct drm_property *hpos;
164         struct drm_property *vpos;
165         struct drm_property *contrast;
166         struct drm_property *saturation;
167         struct drm_property *hue;
168         struct drm_property *sharpness;
169         struct drm_property *flicker_filter;
170         struct drm_property *flicker_filter_adaptive;
171         struct drm_property *flicker_filter_2d;
172         struct drm_property *tv_chroma_filter;
173         struct drm_property *tv_luma_filter;
174         struct drm_property *dot_crawl;
175
176         /* add the property for the SDVO-TV/LVDS */
177         struct drm_property *brightness;
178
179         /* Add variable to record current setting for the above property */
180         u32     left_margin, right_margin, top_margin, bottom_margin;
181
182         /* this is to get the range of margin.*/
183         u32     max_hscan,  max_vscan;
184         u32     max_hpos, cur_hpos;
185         u32     max_vpos, cur_vpos;
186         u32     cur_brightness, max_brightness;
187         u32     cur_contrast,   max_contrast;
188         u32     cur_saturation, max_saturation;
189         u32     cur_hue,        max_hue;
190         u32     cur_sharpness,  max_sharpness;
191         u32     cur_flicker_filter,             max_flicker_filter;
192         u32     cur_flicker_filter_adaptive,    max_flicker_filter_adaptive;
193         u32     cur_flicker_filter_2d,          max_flicker_filter_2d;
194         u32     cur_tv_chroma_filter,   max_tv_chroma_filter;
195         u32     cur_tv_luma_filter,     max_tv_luma_filter;
196         u32     cur_dot_crawl,  max_dot_crawl;
197 };
198
199 static struct intel_sdvo *to_intel_sdvo(struct drm_encoder *encoder)
200 {
201         return container_of(encoder, struct intel_sdvo, base.base);
202 }
203
204 static struct intel_sdvo *intel_attached_sdvo(struct drm_connector *connector)
205 {
206         return container_of(intel_attached_encoder(connector),
207                             struct intel_sdvo, base);
208 }
209
210 static struct intel_sdvo_connector *to_intel_sdvo_connector(struct drm_connector *connector)
211 {
212         return container_of(to_intel_connector(connector), struct intel_sdvo_connector, base);
213 }
214
215 static bool
216 intel_sdvo_output_setup(struct intel_sdvo *intel_sdvo, uint16_t flags);
217 static bool
218 intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
219                               struct intel_sdvo_connector *intel_sdvo_connector,
220                               int type);
221 static bool
222 intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo,
223                                    struct intel_sdvo_connector *intel_sdvo_connector);
224
225 /**
226  * Writes the SDVOB or SDVOC with the given value, but always writes both
227  * SDVOB and SDVOC to work around apparent hardware issues (according to
228  * comments in the BIOS).
229  */
230 static void intel_sdvo_write_sdvox(struct intel_sdvo *intel_sdvo, u32 val)
231 {
232         struct drm_device *dev = intel_sdvo->base.base.dev;
233         struct drm_i915_private *dev_priv = dev->dev_private;
234         u32 bval = val, cval = val;
235         int i;
236
237         if (intel_sdvo->sdvo_reg == PCH_SDVOB) {
238                 I915_WRITE(intel_sdvo->sdvo_reg, val);
239                 I915_READ(intel_sdvo->sdvo_reg);
240                 return;
241         }
242
243         if (intel_sdvo->sdvo_reg == SDVOB) {
244                 cval = I915_READ(SDVOC);
245         } else {
246                 bval = I915_READ(SDVOB);
247         }
248         /*
249          * Write the registers twice for luck. Sometimes,
250          * writing them only once doesn't appear to 'stick'.
251          * The BIOS does this too. Yay, magic
252          */
253         for (i = 0; i < 2; i++)
254         {
255                 I915_WRITE(SDVOB, bval);
256                 I915_READ(SDVOB);
257                 I915_WRITE(SDVOC, cval);
258                 I915_READ(SDVOC);
259         }
260 }
261
262 static bool intel_sdvo_read_byte(struct intel_sdvo *intel_sdvo, u8 addr, u8 *ch)
263 {
264         struct i2c_msg msgs[] = {
265                 {
266                         .addr = intel_sdvo->slave_addr,
267                         .flags = 0,
268                         .len = 1,
269                         .buf = &addr,
270                 },
271                 {
272                         .addr = intel_sdvo->slave_addr,
273                         .flags = I2C_M_RD,
274                         .len = 1,
275                         .buf = ch,
276                 }
277         };
278         int ret;
279
280         if ((ret = i2c_transfer(intel_sdvo->i2c, msgs, 2)) == 2)
281                 return true;
282
283         DRM_DEBUG_KMS("i2c transfer returned %d\n", ret);
284         return false;
285 }
286
287 #define SDVO_CMD_NAME_ENTRY(cmd) {cmd, #cmd}
288 /** Mapping of command numbers to names, for debug output */
289 static const struct _sdvo_cmd_name {
290         u8 cmd;
291         const char *name;
292 } sdvo_cmd_names[] = {
293         SDVO_CMD_NAME_ENTRY(SDVO_CMD_RESET),
294         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_DEVICE_CAPS),
295         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FIRMWARE_REV),
296         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TRAINED_INPUTS),
297         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ACTIVE_OUTPUTS),
298         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ACTIVE_OUTPUTS),
299         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_IN_OUT_MAP),
300         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_IN_OUT_MAP),
301         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ATTACHED_DISPLAYS),
302         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HOT_PLUG_SUPPORT),
303         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ACTIVE_HOT_PLUG),
304         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ACTIVE_HOT_PLUG),
305         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INTERRUPT_EVENT_SOURCE),
306         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TARGET_INPUT),
307         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TARGET_OUTPUT),
308         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_TIMINGS_PART1),
309         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_TIMINGS_PART2),
310         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART1),
311         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART2),
312         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART1),
313         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OUTPUT_TIMINGS_PART1),
314         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OUTPUT_TIMINGS_PART2),
315         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_TIMINGS_PART1),
316         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_TIMINGS_PART2),
317         SDVO_CMD_NAME_ENTRY(SDVO_CMD_CREATE_PREFERRED_INPUT_TIMING),
318         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART1),
319         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART2),
320         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_PIXEL_CLOCK_RANGE),
321         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_PIXEL_CLOCK_RANGE),
322         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_CLOCK_RATE_MULTS),
323         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_CLOCK_RATE_MULT),
324         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CLOCK_RATE_MULT),
325         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_TV_FORMATS),
326         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_FORMAT),
327         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_FORMAT),
328         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_POWER_STATES),
329         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_POWER_STATE),
330         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ENCODER_POWER_STATE),
331         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_DISPLAY_POWER_STATE),
332         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CONTROL_BUS_SWITCH),
333         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SDTV_RESOLUTION_SUPPORT),
334         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SCALED_HDTV_RESOLUTION_SUPPORT),
335         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_ENHANCEMENTS),
336
337         /* Add the op code for SDVO enhancements */
338         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_HPOS),
339         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HPOS),
340         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HPOS),
341         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_VPOS),
342         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_VPOS),
343         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_VPOS),
344         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_SATURATION),
345         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SATURATION),
346         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_SATURATION),
347         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_HUE),
348         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HUE),
349         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HUE),
350         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_CONTRAST),
351         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_CONTRAST),
352         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CONTRAST),
353         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_BRIGHTNESS),
354         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_BRIGHTNESS),
355         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_BRIGHTNESS),
356         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_OVERSCAN_H),
357         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OVERSCAN_H),
358         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OVERSCAN_H),
359         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_OVERSCAN_V),
360         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OVERSCAN_V),
361         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OVERSCAN_V),
362         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER),
363         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER),
364         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER),
365         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER_ADAPTIVE),
366         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER_ADAPTIVE),
367         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER_ADAPTIVE),
368         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER_2D),
369         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER_2D),
370         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER_2D),
371         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_SHARPNESS),
372         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SHARPNESS),
373         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_SHARPNESS),
374         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_DOT_CRAWL),
375         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_DOT_CRAWL),
376         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_TV_CHROMA_FILTER),
377         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_CHROMA_FILTER),
378         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_CHROMA_FILTER),
379         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_TV_LUMA_FILTER),
380         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_LUMA_FILTER),
381         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_LUMA_FILTER),
382
383         /* HDMI op code */
384         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPP_ENCODE),
385         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ENCODE),
386         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ENCODE),
387         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_PIXEL_REPLI),
388         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PIXEL_REPLI),
389         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_COLORIMETRY_CAP),
390         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_COLORIMETRY),
391         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_COLORIMETRY),
392         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_AUDIO_ENCRYPT_PREFER),
393         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_AUDIO_STAT),
394         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_AUDIO_STAT),
395         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_INDEX),
396         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_INDEX),
397         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_INFO),
398         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_AV_SPLIT),
399         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_AV_SPLIT),
400         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_TXRATE),
401         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_TXRATE),
402         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_DATA),
403         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_DATA),
404 };
405
406 #define SDVO_NAME(svdo) ((svdo)->is_sdvob ? "SDVOB" : "SDVOC")
407
408 static void intel_sdvo_debug_write(struct intel_sdvo *intel_sdvo, u8 cmd,
409                                    const void *args, int args_len)
410 {
411         int i;
412
413         DRM_DEBUG_KMS("%s: W: %02X ",
414                                 SDVO_NAME(intel_sdvo), cmd);
415         for (i = 0; i < args_len; i++)
416                 DRM_LOG_KMS("%02X ", ((u8 *)args)[i]);
417         for (; i < 8; i++)
418                 DRM_LOG_KMS("   ");
419         for (i = 0; i < ARRAY_SIZE(sdvo_cmd_names); i++) {
420                 if (cmd == sdvo_cmd_names[i].cmd) {
421                         DRM_LOG_KMS("(%s)", sdvo_cmd_names[i].name);
422                         break;
423                 }
424         }
425         if (i == ARRAY_SIZE(sdvo_cmd_names))
426                 DRM_LOG_KMS("(%02X)", cmd);
427         DRM_LOG_KMS("\n");
428 }
429
430 static const char *cmd_status_names[] = {
431         "Power on",
432         "Success",
433         "Not supported",
434         "Invalid arg",
435         "Pending",
436         "Target not specified",
437         "Scaling not supported"
438 };
439
440 static bool intel_sdvo_write_cmd(struct intel_sdvo *intel_sdvo, u8 cmd,
441                                  const void *args, int args_len)
442 {
443         u8 *buf, status;
444         struct i2c_msg *msgs;
445         int i, ret = true;
446
447         /* Would be simpler to allocate both in one go ? */        
448         buf = (u8 *)kzalloc(args_len * 2 + 2, GFP_KERNEL);
449         if (!buf)
450                 return false;
451
452         msgs = kcalloc(args_len + 3, sizeof(*msgs), GFP_KERNEL);
453         if (!msgs) {
454                 kfree(buf);
455                 return false;
456         }
457
458         intel_sdvo_debug_write(intel_sdvo, cmd, args, args_len);
459
460         for (i = 0; i < args_len; i++) {
461                 msgs[i].addr = intel_sdvo->slave_addr;
462                 msgs[i].flags = 0;
463                 msgs[i].len = 2;
464                 msgs[i].buf = buf + 2 *i;
465                 buf[2*i + 0] = SDVO_I2C_ARG_0 - i;
466                 buf[2*i + 1] = ((u8*)args)[i];
467         }
468         msgs[i].addr = intel_sdvo->slave_addr;
469         msgs[i].flags = 0;
470         msgs[i].len = 2;
471         msgs[i].buf = buf + 2*i;
472         buf[2*i + 0] = SDVO_I2C_OPCODE;
473         buf[2*i + 1] = cmd;
474
475         /* the following two are to read the response */
476         status = SDVO_I2C_CMD_STATUS;
477         msgs[i+1].addr = intel_sdvo->slave_addr;
478         msgs[i+1].flags = 0;
479         msgs[i+1].len = 1;
480         msgs[i+1].buf = &status;
481
482         msgs[i+2].addr = intel_sdvo->slave_addr;
483         msgs[i+2].flags = I2C_M_RD;
484         msgs[i+2].len = 1;
485         msgs[i+2].buf = &status;
486
487         ret = i2c_transfer(intel_sdvo->i2c, msgs, i+3);
488         if (ret < 0) {
489                 DRM_DEBUG_KMS("I2c transfer returned %d\n", ret);
490                 ret = false;
491                 goto out;
492         }
493         if (ret != i+3) {
494                 /* failure in I2C transfer */
495                 DRM_DEBUG_KMS("I2c transfer returned %d/%d\n", ret, i+3);
496                 ret = false;
497         }
498
499 out:
500         kfree(msgs);
501         kfree(buf);
502         return ret;
503 }
504
505 static bool intel_sdvo_read_response(struct intel_sdvo *intel_sdvo,
506                                      void *response, int response_len)
507 {
508         u8 retry = 5;
509         u8 status;
510         int i;
511
512         DRM_DEBUG_KMS("%s: R: ", SDVO_NAME(intel_sdvo));
513
514         /*
515          * The documentation states that all commands will be
516          * processed within 15µs, and that we need only poll
517          * the status byte a maximum of 3 times in order for the
518          * command to be complete.
519          *
520          * Check 5 times in case the hardware failed to read the docs.
521          */
522         if (!intel_sdvo_read_byte(intel_sdvo,
523                                   SDVO_I2C_CMD_STATUS,
524                                   &status))
525                 goto log_fail;
526
527         while (status == SDVO_CMD_STATUS_PENDING && retry--) {
528                 udelay(15);
529                 if (!intel_sdvo_read_byte(intel_sdvo,
530                                           SDVO_I2C_CMD_STATUS,
531                                           &status))
532                         goto log_fail;
533         }
534
535         if (status <= SDVO_CMD_STATUS_SCALING_NOT_SUPP)
536                 DRM_LOG_KMS("(%s)", cmd_status_names[status]);
537         else
538                 DRM_LOG_KMS("(??? %d)", status);
539
540         if (status != SDVO_CMD_STATUS_SUCCESS)
541                 goto log_fail;
542
543         /* Read the command response */
544         for (i = 0; i < response_len; i++) {
545                 if (!intel_sdvo_read_byte(intel_sdvo,
546                                           SDVO_I2C_RETURN_0 + i,
547                                           &((u8 *)response)[i]))
548                         goto log_fail;
549                 DRM_LOG_KMS(" %02X", ((u8 *)response)[i]);
550         }
551         DRM_LOG_KMS("\n");
552         return true;
553
554 log_fail:
555         DRM_LOG_KMS("... failed\n");
556         return false;
557 }
558
559 static int intel_sdvo_get_pixel_multiplier(struct drm_display_mode *mode)
560 {
561         if (mode->clock >= 100000)
562                 return 1;
563         else if (mode->clock >= 50000)
564                 return 2;
565         else
566                 return 4;
567 }
568
569 static bool intel_sdvo_set_control_bus_switch(struct intel_sdvo *intel_sdvo,
570                                               u8 ddc_bus)
571 {
572         /* This must be the immediately preceding write before the i2c xfer */
573         return intel_sdvo_write_cmd(intel_sdvo,
574                                     SDVO_CMD_SET_CONTROL_BUS_SWITCH,
575                                     &ddc_bus, 1);
576 }
577
578 static bool intel_sdvo_set_value(struct intel_sdvo *intel_sdvo, u8 cmd, const void *data, int len)
579 {
580         if (!intel_sdvo_write_cmd(intel_sdvo, cmd, data, len))
581                 return false;
582
583         return intel_sdvo_read_response(intel_sdvo, NULL, 0);
584 }
585
586 static bool
587 intel_sdvo_get_value(struct intel_sdvo *intel_sdvo, u8 cmd, void *value, int len)
588 {
589         if (!intel_sdvo_write_cmd(intel_sdvo, cmd, NULL, 0))
590                 return false;
591
592         return intel_sdvo_read_response(intel_sdvo, value, len);
593 }
594
595 static bool intel_sdvo_set_target_input(struct intel_sdvo *intel_sdvo)
596 {
597         struct intel_sdvo_set_target_input_args targets = {0};
598         return intel_sdvo_set_value(intel_sdvo,
599                                     SDVO_CMD_SET_TARGET_INPUT,
600                                     &targets, sizeof(targets));
601 }
602
603 /**
604  * Return whether each input is trained.
605  *
606  * This function is making an assumption about the layout of the response,
607  * which should be checked against the docs.
608  */
609 static bool intel_sdvo_get_trained_inputs(struct intel_sdvo *intel_sdvo, bool *input_1, bool *input_2)
610 {
611         struct intel_sdvo_get_trained_inputs_response response;
612
613         BUILD_BUG_ON(sizeof(response) != 1);
614         if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_TRAINED_INPUTS,
615                                   &response, sizeof(response)))
616                 return false;
617
618         *input_1 = response.input0_trained;
619         *input_2 = response.input1_trained;
620         return true;
621 }
622
623 static bool intel_sdvo_set_active_outputs(struct intel_sdvo *intel_sdvo,
624                                           u16 outputs)
625 {
626         return intel_sdvo_set_value(intel_sdvo,
627                                     SDVO_CMD_SET_ACTIVE_OUTPUTS,
628                                     &outputs, sizeof(outputs));
629 }
630
631 static bool intel_sdvo_set_encoder_power_state(struct intel_sdvo *intel_sdvo,
632                                                int mode)
633 {
634         u8 state = SDVO_ENCODER_STATE_ON;
635
636         switch (mode) {
637         case DRM_MODE_DPMS_ON:
638                 state = SDVO_ENCODER_STATE_ON;
639                 break;
640         case DRM_MODE_DPMS_STANDBY:
641                 state = SDVO_ENCODER_STATE_STANDBY;
642                 break;
643         case DRM_MODE_DPMS_SUSPEND:
644                 state = SDVO_ENCODER_STATE_SUSPEND;
645                 break;
646         case DRM_MODE_DPMS_OFF:
647                 state = SDVO_ENCODER_STATE_OFF;
648                 break;
649         }
650
651         return intel_sdvo_set_value(intel_sdvo,
652                                     SDVO_CMD_SET_ENCODER_POWER_STATE, &state, sizeof(state));
653 }
654
655 static bool intel_sdvo_get_input_pixel_clock_range(struct intel_sdvo *intel_sdvo,
656                                                    int *clock_min,
657                                                    int *clock_max)
658 {
659         struct intel_sdvo_pixel_clock_range clocks;
660
661         BUILD_BUG_ON(sizeof(clocks) != 4);
662         if (!intel_sdvo_get_value(intel_sdvo,
663                                   SDVO_CMD_GET_INPUT_PIXEL_CLOCK_RANGE,
664                                   &clocks, sizeof(clocks)))
665                 return false;
666
667         /* Convert the values from units of 10 kHz to kHz. */
668         *clock_min = clocks.min * 10;
669         *clock_max = clocks.max * 10;
670         return true;
671 }
672
673 static bool intel_sdvo_set_target_output(struct intel_sdvo *intel_sdvo,
674                                          u16 outputs)
675 {
676         return intel_sdvo_set_value(intel_sdvo,
677                                     SDVO_CMD_SET_TARGET_OUTPUT,
678                                     &outputs, sizeof(outputs));
679 }
680
681 static bool intel_sdvo_set_timing(struct intel_sdvo *intel_sdvo, u8 cmd,
682                                   struct intel_sdvo_dtd *dtd)
683 {
684         return intel_sdvo_set_value(intel_sdvo, cmd, &dtd->part1, sizeof(dtd->part1)) &&
685                 intel_sdvo_set_value(intel_sdvo, cmd + 1, &dtd->part2, sizeof(dtd->part2));
686 }
687
688 static bool intel_sdvo_set_input_timing(struct intel_sdvo *intel_sdvo,
689                                          struct intel_sdvo_dtd *dtd)
690 {
691         return intel_sdvo_set_timing(intel_sdvo,
692                                      SDVO_CMD_SET_INPUT_TIMINGS_PART1, dtd);
693 }
694
695 static bool intel_sdvo_set_output_timing(struct intel_sdvo *intel_sdvo,
696                                          struct intel_sdvo_dtd *dtd)
697 {
698         return intel_sdvo_set_timing(intel_sdvo,
699                                      SDVO_CMD_SET_OUTPUT_TIMINGS_PART1, dtd);
700 }
701
702 static bool
703 intel_sdvo_create_preferred_input_timing(struct intel_sdvo *intel_sdvo,
704                                          uint16_t clock,
705                                          uint16_t width,
706                                          uint16_t height)
707 {
708         struct intel_sdvo_preferred_input_timing_args args;
709
710         memset(&args, 0, sizeof(args));
711         args.clock = clock;
712         args.width = width;
713         args.height = height;
714         args.interlace = 0;
715
716         if (intel_sdvo->is_lvds &&
717            (intel_sdvo->sdvo_lvds_fixed_mode->hdisplay != width ||
718             intel_sdvo->sdvo_lvds_fixed_mode->vdisplay != height))
719                 args.scaled = 1;
720
721         return intel_sdvo_set_value(intel_sdvo,
722                                     SDVO_CMD_CREATE_PREFERRED_INPUT_TIMING,
723                                     &args, sizeof(args));
724 }
725
726 static bool intel_sdvo_get_preferred_input_timing(struct intel_sdvo *intel_sdvo,
727                                                   struct intel_sdvo_dtd *dtd)
728 {
729         BUILD_BUG_ON(sizeof(dtd->part1) != 8);
730         BUILD_BUG_ON(sizeof(dtd->part2) != 8);
731         return intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART1,
732                                     &dtd->part1, sizeof(dtd->part1)) &&
733                 intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART2,
734                                      &dtd->part2, sizeof(dtd->part2));
735 }
736
737 static bool intel_sdvo_set_clock_rate_mult(struct intel_sdvo *intel_sdvo, u8 val)
738 {
739         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_CLOCK_RATE_MULT, &val, 1);
740 }
741
742 static void intel_sdvo_get_dtd_from_mode(struct intel_sdvo_dtd *dtd,
743                                          const struct drm_display_mode *mode)
744 {
745         uint16_t width, height;
746         uint16_t h_blank_len, h_sync_len, v_blank_len, v_sync_len;
747         uint16_t h_sync_offset, v_sync_offset;
748         int mode_clock;
749
750         width = mode->hdisplay;
751         height = mode->vdisplay;
752
753         /* do some mode translations */
754         h_blank_len = mode->htotal - mode->hdisplay;
755         h_sync_len = mode->hsync_end - mode->hsync_start;
756
757         v_blank_len = mode->vtotal - mode->vdisplay;
758         v_sync_len = mode->vsync_end - mode->vsync_start;
759
760         h_sync_offset = mode->hsync_start - mode->hdisplay;
761         v_sync_offset = mode->vsync_start - mode->vdisplay;
762
763         mode_clock = mode->clock;
764         mode_clock /= intel_mode_get_pixel_multiplier(mode) ?: 1;
765         mode_clock /= 10;
766         dtd->part1.clock = mode_clock;
767
768         dtd->part1.h_active = width & 0xff;
769         dtd->part1.h_blank = h_blank_len & 0xff;
770         dtd->part1.h_high = (((width >> 8) & 0xf) << 4) |
771                 ((h_blank_len >> 8) & 0xf);
772         dtd->part1.v_active = height & 0xff;
773         dtd->part1.v_blank = v_blank_len & 0xff;
774         dtd->part1.v_high = (((height >> 8) & 0xf) << 4) |
775                 ((v_blank_len >> 8) & 0xf);
776
777         dtd->part2.h_sync_off = h_sync_offset & 0xff;
778         dtd->part2.h_sync_width = h_sync_len & 0xff;
779         dtd->part2.v_sync_off_width = (v_sync_offset & 0xf) << 4 |
780                 (v_sync_len & 0xf);
781         dtd->part2.sync_off_width_high = ((h_sync_offset & 0x300) >> 2) |
782                 ((h_sync_len & 0x300) >> 4) | ((v_sync_offset & 0x30) >> 2) |
783                 ((v_sync_len & 0x30) >> 4);
784
785         dtd->part2.dtd_flags = 0x18;
786         if (mode->flags & DRM_MODE_FLAG_INTERLACE)
787                 dtd->part2.dtd_flags |= DTD_FLAG_INTERLACE;
788         if (mode->flags & DRM_MODE_FLAG_PHSYNC)
789                 dtd->part2.dtd_flags |= DTD_FLAG_HSYNC_POSITIVE;
790         if (mode->flags & DRM_MODE_FLAG_PVSYNC)
791                 dtd->part2.dtd_flags |= DTD_FLAG_VSYNC_POSITIVE;
792
793         dtd->part2.sdvo_flags = 0;
794         dtd->part2.v_sync_off_high = v_sync_offset & 0xc0;
795         dtd->part2.reserved = 0;
796 }
797
798 static void intel_sdvo_get_mode_from_dtd(struct drm_display_mode * mode,
799                                          const struct intel_sdvo_dtd *dtd)
800 {
801         mode->hdisplay = dtd->part1.h_active;
802         mode->hdisplay += ((dtd->part1.h_high >> 4) & 0x0f) << 8;
803         mode->hsync_start = mode->hdisplay + dtd->part2.h_sync_off;
804         mode->hsync_start += (dtd->part2.sync_off_width_high & 0xc0) << 2;
805         mode->hsync_end = mode->hsync_start + dtd->part2.h_sync_width;
806         mode->hsync_end += (dtd->part2.sync_off_width_high & 0x30) << 4;
807         mode->htotal = mode->hdisplay + dtd->part1.h_blank;
808         mode->htotal += (dtd->part1.h_high & 0xf) << 8;
809
810         mode->vdisplay = dtd->part1.v_active;
811         mode->vdisplay += ((dtd->part1.v_high >> 4) & 0x0f) << 8;
812         mode->vsync_start = mode->vdisplay;
813         mode->vsync_start += (dtd->part2.v_sync_off_width >> 4) & 0xf;
814         mode->vsync_start += (dtd->part2.sync_off_width_high & 0x0c) << 2;
815         mode->vsync_start += dtd->part2.v_sync_off_high & 0xc0;
816         mode->vsync_end = mode->vsync_start +
817                 (dtd->part2.v_sync_off_width & 0xf);
818         mode->vsync_end += (dtd->part2.sync_off_width_high & 0x3) << 4;
819         mode->vtotal = mode->vdisplay + dtd->part1.v_blank;
820         mode->vtotal += (dtd->part1.v_high & 0xf) << 8;
821
822         mode->clock = dtd->part1.clock * 10;
823
824         mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC);
825         if (dtd->part2.dtd_flags & DTD_FLAG_INTERLACE)
826                 mode->flags |= DRM_MODE_FLAG_INTERLACE;
827         if (dtd->part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE)
828                 mode->flags |= DRM_MODE_FLAG_PHSYNC;
829         if (dtd->part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE)
830                 mode->flags |= DRM_MODE_FLAG_PVSYNC;
831 }
832
833 static bool intel_sdvo_check_supp_encode(struct intel_sdvo *intel_sdvo)
834 {
835         struct intel_sdvo_encode encode;
836
837         BUILD_BUG_ON(sizeof(encode) != 2);
838         return intel_sdvo_get_value(intel_sdvo,
839                                   SDVO_CMD_GET_SUPP_ENCODE,
840                                   &encode, sizeof(encode));
841 }
842
843 static bool intel_sdvo_set_encode(struct intel_sdvo *intel_sdvo,
844                                   uint8_t mode)
845 {
846         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_ENCODE, &mode, 1);
847 }
848
849 static bool intel_sdvo_set_colorimetry(struct intel_sdvo *intel_sdvo,
850                                        uint8_t mode)
851 {
852         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_COLORIMETRY, &mode, 1);
853 }
854
855 #if 0
856 static void intel_sdvo_dump_hdmi_buf(struct intel_sdvo *intel_sdvo)
857 {
858         int i, j;
859         uint8_t set_buf_index[2];
860         uint8_t av_split;
861         uint8_t buf_size;
862         uint8_t buf[48];
863         uint8_t *pos;
864
865         intel_sdvo_get_value(encoder, SDVO_CMD_GET_HBUF_AV_SPLIT, &av_split, 1);
866
867         for (i = 0; i <= av_split; i++) {
868                 set_buf_index[0] = i; set_buf_index[1] = 0;
869                 intel_sdvo_write_cmd(encoder, SDVO_CMD_SET_HBUF_INDEX,
870                                      set_buf_index, 2);
871                 intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_INFO, NULL, 0);
872                 intel_sdvo_read_response(encoder, &buf_size, 1);
873
874                 pos = buf;
875                 for (j = 0; j <= buf_size; j += 8) {
876                         intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_DATA,
877                                              NULL, 0);
878                         intel_sdvo_read_response(encoder, pos, 8);
879                         pos += 8;
880                 }
881         }
882 }
883 #endif
884
885 static bool intel_sdvo_set_avi_infoframe(struct intel_sdvo *intel_sdvo)
886 {
887         struct dip_infoframe avi_if = {
888                 .type = DIP_TYPE_AVI,
889                 .ver = DIP_VERSION_AVI,
890                 .len = DIP_LEN_AVI,
891         };
892         uint8_t tx_rate = SDVO_HBUF_TX_VSYNC;
893         uint8_t set_buf_index[2] = { 1, 0 };
894         uint8_t sdvo_data[4 + sizeof(avi_if.body.avi)];
895         uint64_t *data = (uint64_t *)sdvo_data;
896         unsigned i;
897
898         intel_dip_infoframe_csum(&avi_if);
899
900         /* sdvo spec says that the ecc is handled by the hw, and it looks like
901          * we must not send the ecc field, either. */
902         memcpy(sdvo_data, &avi_if, 3);
903         sdvo_data[3] = avi_if.checksum;
904         memcpy(&sdvo_data[4], &avi_if.body, sizeof(avi_if.body.avi));
905
906         if (!intel_sdvo_set_value(intel_sdvo,
907                                   SDVO_CMD_SET_HBUF_INDEX,
908                                   set_buf_index, 2))
909                 return false;
910
911         for (i = 0; i < sizeof(sdvo_data); i += 8) {
912                 if (!intel_sdvo_set_value(intel_sdvo,
913                                           SDVO_CMD_SET_HBUF_DATA,
914                                           data, 8))
915                         return false;
916                 data++;
917         }
918
919         return intel_sdvo_set_value(intel_sdvo,
920                                     SDVO_CMD_SET_HBUF_TXRATE,
921                                     &tx_rate, 1);
922 }
923
924 static bool intel_sdvo_set_tv_format(struct intel_sdvo *intel_sdvo)
925 {
926         struct intel_sdvo_tv_format format;
927         uint32_t format_map;
928
929         format_map = 1 << intel_sdvo->tv_format_index;
930         memset(&format, 0, sizeof(format));
931         memcpy(&format, &format_map, min(sizeof(format), sizeof(format_map)));
932
933         BUILD_BUG_ON(sizeof(format) != 6);
934         return intel_sdvo_set_value(intel_sdvo,
935                                     SDVO_CMD_SET_TV_FORMAT,
936                                     &format, sizeof(format));
937 }
938
939 static bool
940 intel_sdvo_set_output_timings_from_mode(struct intel_sdvo *intel_sdvo,
941                                         const struct drm_display_mode *mode)
942 {
943         struct intel_sdvo_dtd output_dtd;
944
945         if (!intel_sdvo_set_target_output(intel_sdvo,
946                                           intel_sdvo->attached_output))
947                 return false;
948
949         intel_sdvo_get_dtd_from_mode(&output_dtd, mode);
950         if (!intel_sdvo_set_output_timing(intel_sdvo, &output_dtd))
951                 return false;
952
953         return true;
954 }
955
956 /* Asks the sdvo controller for the preferred input mode given the output mode.
957  * Unfortunately we have to set up the full output mode to do that. */
958 static bool
959 intel_sdvo_get_preferred_input_mode(struct intel_sdvo *intel_sdvo,
960                                     const struct drm_display_mode *mode,
961                                     struct drm_display_mode *adjusted_mode)
962 {
963         struct intel_sdvo_dtd input_dtd;
964
965         /* Reset the input timing to the screen. Assume always input 0. */
966         if (!intel_sdvo_set_target_input(intel_sdvo))
967                 return false;
968
969         if (!intel_sdvo_create_preferred_input_timing(intel_sdvo,
970                                                       mode->clock / 10,
971                                                       mode->hdisplay,
972                                                       mode->vdisplay))
973                 return false;
974
975         if (!intel_sdvo_get_preferred_input_timing(intel_sdvo,
976                                                    &input_dtd))
977                 return false;
978
979         intel_sdvo_get_mode_from_dtd(adjusted_mode, &input_dtd);
980
981         return true;
982 }
983
984 static bool intel_sdvo_mode_fixup(struct drm_encoder *encoder,
985                                   const struct drm_display_mode *mode,
986                                   struct drm_display_mode *adjusted_mode)
987 {
988         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
989         int multiplier;
990
991         /* We need to construct preferred input timings based on our
992          * output timings.  To do that, we have to set the output
993          * timings, even though this isn't really the right place in
994          * the sequence to do it. Oh well.
995          */
996         if (intel_sdvo->is_tv) {
997                 if (!intel_sdvo_set_output_timings_from_mode(intel_sdvo, mode))
998                         return false;
999
1000                 (void) intel_sdvo_get_preferred_input_mode(intel_sdvo,
1001                                                            mode,
1002                                                            adjusted_mode);
1003         } else if (intel_sdvo->is_lvds) {
1004                 if (!intel_sdvo_set_output_timings_from_mode(intel_sdvo,
1005                                                              intel_sdvo->sdvo_lvds_fixed_mode))
1006                         return false;
1007
1008                 (void) intel_sdvo_get_preferred_input_mode(intel_sdvo,
1009                                                            mode,
1010                                                            adjusted_mode);
1011         }
1012
1013         /* Make the CRTC code factor in the SDVO pixel multiplier.  The
1014          * SDVO device will factor out the multiplier during mode_set.
1015          */
1016         multiplier = intel_sdvo_get_pixel_multiplier(adjusted_mode);
1017         intel_mode_set_pixel_multiplier(adjusted_mode, multiplier);
1018
1019         return true;
1020 }
1021
1022 static void intel_sdvo_mode_set(struct drm_encoder *encoder,
1023                                 struct drm_display_mode *mode,
1024                                 struct drm_display_mode *adjusted_mode)
1025 {
1026         struct drm_device *dev = encoder->dev;
1027         struct drm_i915_private *dev_priv = dev->dev_private;
1028         struct drm_crtc *crtc = encoder->crtc;
1029         struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
1030         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
1031         u32 sdvox;
1032         struct intel_sdvo_in_out_map in_out;
1033         struct intel_sdvo_dtd input_dtd, output_dtd;
1034         int pixel_multiplier = intel_mode_get_pixel_multiplier(adjusted_mode);
1035         int rate;
1036
1037         if (!mode)
1038                 return;
1039
1040         /* First, set the input mapping for the first input to our controlled
1041          * output. This is only correct if we're a single-input device, in
1042          * which case the first input is the output from the appropriate SDVO
1043          * channel on the motherboard.  In a two-input device, the first input
1044          * will be SDVOB and the second SDVOC.
1045          */
1046         in_out.in0 = intel_sdvo->attached_output;
1047         in_out.in1 = 0;
1048
1049         intel_sdvo_set_value(intel_sdvo,
1050                              SDVO_CMD_SET_IN_OUT_MAP,
1051                              &in_out, sizeof(in_out));
1052
1053         /* Set the output timings to the screen */
1054         if (!intel_sdvo_set_target_output(intel_sdvo,
1055                                           intel_sdvo->attached_output))
1056                 return;
1057
1058         /* lvds has a special fixed output timing. */
1059         if (intel_sdvo->is_lvds)
1060                 intel_sdvo_get_dtd_from_mode(&output_dtd,
1061                                              intel_sdvo->sdvo_lvds_fixed_mode);
1062         else
1063                 intel_sdvo_get_dtd_from_mode(&output_dtd, mode);
1064         if (!intel_sdvo_set_output_timing(intel_sdvo, &output_dtd))
1065                 DRM_INFO("Setting output timings on %s failed\n",
1066                          SDVO_NAME(intel_sdvo));
1067
1068         /* Set the input timing to the screen. Assume always input 0. */
1069         if (!intel_sdvo_set_target_input(intel_sdvo))
1070                 return;
1071
1072         if (intel_sdvo->has_hdmi_monitor) {
1073                 intel_sdvo_set_encode(intel_sdvo, SDVO_ENCODE_HDMI);
1074                 intel_sdvo_set_colorimetry(intel_sdvo,
1075                                            SDVO_COLORIMETRY_RGB256);
1076                 intel_sdvo_set_avi_infoframe(intel_sdvo);
1077         } else
1078                 intel_sdvo_set_encode(intel_sdvo, SDVO_ENCODE_DVI);
1079
1080         if (intel_sdvo->is_tv &&
1081             !intel_sdvo_set_tv_format(intel_sdvo))
1082                 return;
1083
1084         /* We have tried to get input timing in mode_fixup, and filled into
1085          * adjusted_mode.
1086          */
1087         intel_sdvo_get_dtd_from_mode(&input_dtd, adjusted_mode);
1088         if (!intel_sdvo_set_input_timing(intel_sdvo, &input_dtd))
1089                 DRM_INFO("Setting input timings on %s failed\n",
1090                          SDVO_NAME(intel_sdvo));
1091
1092         switch (pixel_multiplier) {
1093         default:
1094         case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
1095         case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
1096         case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
1097         }
1098         if (!intel_sdvo_set_clock_rate_mult(intel_sdvo, rate))
1099                 return;
1100
1101         /* Set the SDVO control regs. */
1102         if (INTEL_INFO(dev)->gen >= 4) {
1103                 /* The real mode polarity is set by the SDVO commands, using
1104                  * struct intel_sdvo_dtd. */
1105                 sdvox = SDVO_VSYNC_ACTIVE_HIGH | SDVO_HSYNC_ACTIVE_HIGH;
1106                 if (intel_sdvo->is_hdmi)
1107                         sdvox |= intel_sdvo->color_range;
1108                 if (INTEL_INFO(dev)->gen < 5)
1109                         sdvox |= SDVO_BORDER_ENABLE;
1110         } else {
1111                 sdvox = I915_READ(intel_sdvo->sdvo_reg);
1112                 switch (intel_sdvo->sdvo_reg) {
1113                 case SDVOB:
1114                         sdvox &= SDVOB_PRESERVE_MASK;
1115                         break;
1116                 case SDVOC:
1117                         sdvox &= SDVOC_PRESERVE_MASK;
1118                         break;
1119                 }
1120                 sdvox |= (9 << 19) | SDVO_BORDER_ENABLE;
1121         }
1122
1123         if (INTEL_PCH_TYPE(dev) >= PCH_CPT)
1124                 sdvox |= TRANSCODER_CPT(intel_crtc->pipe);
1125         else
1126                 sdvox |= TRANSCODER(intel_crtc->pipe);
1127
1128         if (intel_sdvo->has_hdmi_audio)
1129                 sdvox |= SDVO_AUDIO_ENABLE;
1130
1131         if (INTEL_INFO(dev)->gen >= 4) {
1132                 /* done in crtc_mode_set as the dpll_md reg must be written early */
1133         } else if (IS_I945G(dev) || IS_I945GM(dev) || IS_G33(dev)) {
1134                 /* done in crtc_mode_set as it lives inside the dpll register */
1135         } else {
1136                 sdvox |= (pixel_multiplier - 1) << SDVO_PORT_MULTIPLY_SHIFT;
1137         }
1138
1139         if (input_dtd.part2.sdvo_flags & SDVO_NEED_TO_STALL &&
1140             INTEL_INFO(dev)->gen < 5)
1141                 sdvox |= SDVO_STALL_SELECT;
1142         intel_sdvo_write_sdvox(intel_sdvo, sdvox);
1143 }
1144
1145 static void intel_sdvo_dpms(struct drm_encoder *encoder, int mode)
1146 {
1147         struct drm_device *dev = encoder->dev;
1148         struct drm_i915_private *dev_priv = dev->dev_private;
1149         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
1150         struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
1151         u32 temp;
1152
1153         if (mode != DRM_MODE_DPMS_ON) {
1154                 intel_sdvo_set_active_outputs(intel_sdvo, 0);
1155                 if (0)
1156                         intel_sdvo_set_encoder_power_state(intel_sdvo, mode);
1157
1158                 if (mode == DRM_MODE_DPMS_OFF) {
1159                         temp = I915_READ(intel_sdvo->sdvo_reg);
1160                         if ((temp & SDVO_ENABLE) != 0) {
1161                                 intel_sdvo_write_sdvox(intel_sdvo, temp & ~SDVO_ENABLE);
1162                         }
1163                 }
1164         } else {
1165                 bool input1, input2;
1166                 int i;
1167                 u8 status;
1168
1169                 temp = I915_READ(intel_sdvo->sdvo_reg);
1170                 if ((temp & SDVO_ENABLE) == 0)
1171                         intel_sdvo_write_sdvox(intel_sdvo, temp | SDVO_ENABLE);
1172                 for (i = 0; i < 2; i++)
1173                         intel_wait_for_vblank(dev, intel_crtc->pipe);
1174
1175                 status = intel_sdvo_get_trained_inputs(intel_sdvo, &input1, &input2);
1176                 /* Warn if the device reported failure to sync.
1177                  * A lot of SDVO devices fail to notify of sync, but it's
1178                  * a given it the status is a success, we succeeded.
1179                  */
1180                 if (status == SDVO_CMD_STATUS_SUCCESS && !input1) {
1181                         DRM_DEBUG_KMS("First %s output reported failure to "
1182                                         "sync\n", SDVO_NAME(intel_sdvo));
1183                 }
1184
1185                 if (0)
1186                         intel_sdvo_set_encoder_power_state(intel_sdvo, mode);
1187                 intel_sdvo_set_active_outputs(intel_sdvo, intel_sdvo->attached_output);
1188         }
1189         return;
1190 }
1191
1192 static int intel_sdvo_mode_valid(struct drm_connector *connector,
1193                                  struct drm_display_mode *mode)
1194 {
1195         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1196
1197         if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
1198                 return MODE_NO_DBLESCAN;
1199
1200         if (intel_sdvo->pixel_clock_min > mode->clock)
1201                 return MODE_CLOCK_LOW;
1202
1203         if (intel_sdvo->pixel_clock_max < mode->clock)
1204                 return MODE_CLOCK_HIGH;
1205
1206         if (intel_sdvo->is_lvds) {
1207                 if (mode->hdisplay > intel_sdvo->sdvo_lvds_fixed_mode->hdisplay)
1208                         return MODE_PANEL;
1209
1210                 if (mode->vdisplay > intel_sdvo->sdvo_lvds_fixed_mode->vdisplay)
1211                         return MODE_PANEL;
1212         }
1213
1214         return MODE_OK;
1215 }
1216
1217 static bool intel_sdvo_get_capabilities(struct intel_sdvo *intel_sdvo, struct intel_sdvo_caps *caps)
1218 {
1219         BUILD_BUG_ON(sizeof(*caps) != 8);
1220         if (!intel_sdvo_get_value(intel_sdvo,
1221                                   SDVO_CMD_GET_DEVICE_CAPS,
1222                                   caps, sizeof(*caps)))
1223                 return false;
1224
1225         DRM_DEBUG_KMS("SDVO capabilities:\n"
1226                       "  vendor_id: %d\n"
1227                       "  device_id: %d\n"
1228                       "  device_rev_id: %d\n"
1229                       "  sdvo_version_major: %d\n"
1230                       "  sdvo_version_minor: %d\n"
1231                       "  sdvo_inputs_mask: %d\n"
1232                       "  smooth_scaling: %d\n"
1233                       "  sharp_scaling: %d\n"
1234                       "  up_scaling: %d\n"
1235                       "  down_scaling: %d\n"
1236                       "  stall_support: %d\n"
1237                       "  output_flags: %d\n",
1238                       caps->vendor_id,
1239                       caps->device_id,
1240                       caps->device_rev_id,
1241                       caps->sdvo_version_major,
1242                       caps->sdvo_version_minor,
1243                       caps->sdvo_inputs_mask,
1244                       caps->smooth_scaling,
1245                       caps->sharp_scaling,
1246                       caps->up_scaling,
1247                       caps->down_scaling,
1248                       caps->stall_support,
1249                       caps->output_flags);
1250
1251         return true;
1252 }
1253
1254 static int intel_sdvo_supports_hotplug(struct intel_sdvo *intel_sdvo)
1255 {
1256         struct drm_device *dev = intel_sdvo->base.base.dev;
1257         u8 response[2];
1258
1259         /* HW Erratum: SDVO Hotplug is broken on all i945G chips, there's noise
1260          * on the line. */
1261         if (IS_I945G(dev) || IS_I945GM(dev))
1262                 return false;
1263
1264         return intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT,
1265                                     &response, 2) && response[0];
1266 }
1267
1268 static void intel_sdvo_enable_hotplug(struct intel_encoder *encoder)
1269 {
1270         struct intel_sdvo *intel_sdvo = to_intel_sdvo(&encoder->base);
1271
1272         intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG, &intel_sdvo->hotplug_active, 2);
1273 }
1274
1275 static bool
1276 intel_sdvo_multifunc_encoder(struct intel_sdvo *intel_sdvo)
1277 {
1278         /* Is there more than one type of output? */
1279         return hweight16(intel_sdvo->caps.output_flags) > 1;
1280 }
1281
1282 static struct edid *
1283 intel_sdvo_get_edid(struct drm_connector *connector)
1284 {
1285         struct intel_sdvo *sdvo = intel_attached_sdvo(connector);
1286         return drm_get_edid(connector, &sdvo->ddc);
1287 }
1288
1289 /* Mac mini hack -- use the same DDC as the analog connector */
1290 static struct edid *
1291 intel_sdvo_get_analog_edid(struct drm_connector *connector)
1292 {
1293         struct drm_i915_private *dev_priv = connector->dev->dev_private;
1294
1295         return drm_get_edid(connector,
1296                             intel_gmbus_get_adapter(dev_priv,
1297                                                     dev_priv->crt_ddc_pin));
1298 }
1299
1300 static enum drm_connector_status
1301 intel_sdvo_tmds_sink_detect(struct drm_connector *connector)
1302 {
1303         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1304         enum drm_connector_status status;
1305         struct edid *edid;
1306
1307         edid = intel_sdvo_get_edid(connector);
1308
1309         if (edid == NULL && intel_sdvo_multifunc_encoder(intel_sdvo)) {
1310                 u8 ddc, saved_ddc = intel_sdvo->ddc_bus;
1311
1312                 /*
1313                  * Don't use the 1 as the argument of DDC bus switch to get
1314                  * the EDID. It is used for SDVO SPD ROM.
1315                  */
1316                 for (ddc = intel_sdvo->ddc_bus >> 1; ddc > 1; ddc >>= 1) {
1317                         intel_sdvo->ddc_bus = ddc;
1318                         edid = intel_sdvo_get_edid(connector);
1319                         if (edid)
1320                                 break;
1321                 }
1322                 /*
1323                  * If we found the EDID on the other bus,
1324                  * assume that is the correct DDC bus.
1325                  */
1326                 if (edid == NULL)
1327                         intel_sdvo->ddc_bus = saved_ddc;
1328         }
1329
1330         /*
1331          * When there is no edid and no monitor is connected with VGA
1332          * port, try to use the CRT ddc to read the EDID for DVI-connector.
1333          */
1334         if (edid == NULL)
1335                 edid = intel_sdvo_get_analog_edid(connector);
1336
1337         status = connector_status_unknown;
1338         if (edid != NULL) {
1339                 /* DDC bus is shared, match EDID to connector type */
1340                 if (edid->input & DRM_EDID_INPUT_DIGITAL) {
1341                         status = connector_status_connected;
1342                         if (intel_sdvo->is_hdmi) {
1343                                 intel_sdvo->has_hdmi_monitor = drm_detect_hdmi_monitor(edid);
1344                                 intel_sdvo->has_hdmi_audio = drm_detect_monitor_audio(edid);
1345                         }
1346                 } else
1347                         status = connector_status_disconnected;
1348                 connector->display_info.raw_edid = NULL;
1349                 kfree(edid);
1350         }
1351
1352         if (status == connector_status_connected) {
1353                 struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1354                 if (intel_sdvo_connector->force_audio != HDMI_AUDIO_AUTO)
1355                         intel_sdvo->has_hdmi_audio = (intel_sdvo_connector->force_audio == HDMI_AUDIO_ON);
1356         }
1357
1358         return status;
1359 }
1360
1361 static bool
1362 intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo,
1363                                   struct edid *edid)
1364 {
1365         bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL);
1366         bool connector_is_digital = !!IS_DIGITAL(sdvo);
1367
1368         DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n",
1369                       connector_is_digital, monitor_is_digital);
1370         return connector_is_digital == monitor_is_digital;
1371 }
1372
1373 static enum drm_connector_status
1374 intel_sdvo_detect(struct drm_connector *connector, bool force)
1375 {
1376         uint16_t response;
1377         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1378         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1379         enum drm_connector_status ret;
1380
1381         if (!intel_sdvo_write_cmd(intel_sdvo,
1382                                   SDVO_CMD_GET_ATTACHED_DISPLAYS, NULL, 0))
1383                 return connector_status_unknown;
1384
1385         /* add 30ms delay when the output type might be TV */
1386         if (intel_sdvo->caps.output_flags & SDVO_TV_MASK)
1387                 msleep(30);
1388
1389         if (!intel_sdvo_read_response(intel_sdvo, &response, 2))
1390                 return connector_status_unknown;
1391
1392         DRM_DEBUG_KMS("SDVO response %d %d [%x]\n",
1393                       response & 0xff, response >> 8,
1394                       intel_sdvo_connector->output_flag);
1395
1396         if (response == 0)
1397                 return connector_status_disconnected;
1398
1399         intel_sdvo->attached_output = response;
1400
1401         intel_sdvo->has_hdmi_monitor = false;
1402         intel_sdvo->has_hdmi_audio = false;
1403
1404         if ((intel_sdvo_connector->output_flag & response) == 0)
1405                 ret = connector_status_disconnected;
1406         else if (IS_TMDS(intel_sdvo_connector))
1407                 ret = intel_sdvo_tmds_sink_detect(connector);
1408         else {
1409                 struct edid *edid;
1410
1411                 /* if we have an edid check it matches the connection */
1412                 edid = intel_sdvo_get_edid(connector);
1413                 if (edid == NULL)
1414                         edid = intel_sdvo_get_analog_edid(connector);
1415                 if (edid != NULL) {
1416                         if (intel_sdvo_connector_matches_edid(intel_sdvo_connector,
1417                                                               edid))
1418                                 ret = connector_status_connected;
1419                         else
1420                                 ret = connector_status_disconnected;
1421
1422                         connector->display_info.raw_edid = NULL;
1423                         kfree(edid);
1424                 } else
1425                         ret = connector_status_connected;
1426         }
1427
1428         /* May update encoder flag for like clock for SDVO TV, etc.*/
1429         if (ret == connector_status_connected) {
1430                 intel_sdvo->is_tv = false;
1431                 intel_sdvo->is_lvds = false;
1432                 intel_sdvo->base.needs_tv_clock = false;
1433
1434                 if (response & SDVO_TV_MASK) {
1435                         intel_sdvo->is_tv = true;
1436                         intel_sdvo->base.needs_tv_clock = true;
1437                 }
1438                 if (response & SDVO_LVDS_MASK)
1439                         intel_sdvo->is_lvds = intel_sdvo->sdvo_lvds_fixed_mode != NULL;
1440         }
1441
1442         return ret;
1443 }
1444
1445 static void intel_sdvo_get_ddc_modes(struct drm_connector *connector)
1446 {
1447         struct edid *edid;
1448
1449         /* set the bus switch and get the modes */
1450         edid = intel_sdvo_get_edid(connector);
1451
1452         /*
1453          * Mac mini hack.  On this device, the DVI-I connector shares one DDC
1454          * link between analog and digital outputs. So, if the regular SDVO
1455          * DDC fails, check to see if the analog output is disconnected, in
1456          * which case we'll look there for the digital DDC data.
1457          */
1458         if (edid == NULL)
1459                 edid = intel_sdvo_get_analog_edid(connector);
1460
1461         if (edid != NULL) {
1462                 if (intel_sdvo_connector_matches_edid(to_intel_sdvo_connector(connector),
1463                                                       edid)) {
1464                         drm_mode_connector_update_edid_property(connector, edid);
1465                         drm_add_edid_modes(connector, edid);
1466                 }
1467
1468                 connector->display_info.raw_edid = NULL;
1469                 kfree(edid);
1470         }
1471 }
1472
1473 /*
1474  * Set of SDVO TV modes.
1475  * Note!  This is in reply order (see loop in get_tv_modes).
1476  * XXX: all 60Hz refresh?
1477  */
1478 static const struct drm_display_mode sdvo_tv_modes[] = {
1479         { DRM_MODE("320x200", DRM_MODE_TYPE_DRIVER, 5815, 320, 321, 384,
1480                    416, 0, 200, 201, 232, 233, 0,
1481                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1482         { DRM_MODE("320x240", DRM_MODE_TYPE_DRIVER, 6814, 320, 321, 384,
1483                    416, 0, 240, 241, 272, 273, 0,
1484                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1485         { DRM_MODE("400x300", DRM_MODE_TYPE_DRIVER, 9910, 400, 401, 464,
1486                    496, 0, 300, 301, 332, 333, 0,
1487                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1488         { DRM_MODE("640x350", DRM_MODE_TYPE_DRIVER, 16913, 640, 641, 704,
1489                    736, 0, 350, 351, 382, 383, 0,
1490                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1491         { DRM_MODE("640x400", DRM_MODE_TYPE_DRIVER, 19121, 640, 641, 704,
1492                    736, 0, 400, 401, 432, 433, 0,
1493                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1494         { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 22654, 640, 641, 704,
1495                    736, 0, 480, 481, 512, 513, 0,
1496                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1497         { DRM_MODE("704x480", DRM_MODE_TYPE_DRIVER, 24624, 704, 705, 768,
1498                    800, 0, 480, 481, 512, 513, 0,
1499                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1500         { DRM_MODE("704x576", DRM_MODE_TYPE_DRIVER, 29232, 704, 705, 768,
1501                    800, 0, 576, 577, 608, 609, 0,
1502                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1503         { DRM_MODE("720x350", DRM_MODE_TYPE_DRIVER, 18751, 720, 721, 784,
1504                    816, 0, 350, 351, 382, 383, 0,
1505                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1506         { DRM_MODE("720x400", DRM_MODE_TYPE_DRIVER, 21199, 720, 721, 784,
1507                    816, 0, 400, 401, 432, 433, 0,
1508                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1509         { DRM_MODE("720x480", DRM_MODE_TYPE_DRIVER, 25116, 720, 721, 784,
1510                    816, 0, 480, 481, 512, 513, 0,
1511                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1512         { DRM_MODE("720x540", DRM_MODE_TYPE_DRIVER, 28054, 720, 721, 784,
1513                    816, 0, 540, 541, 572, 573, 0,
1514                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1515         { DRM_MODE("720x576", DRM_MODE_TYPE_DRIVER, 29816, 720, 721, 784,
1516                    816, 0, 576, 577, 608, 609, 0,
1517                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1518         { DRM_MODE("768x576", DRM_MODE_TYPE_DRIVER, 31570, 768, 769, 832,
1519                    864, 0, 576, 577, 608, 609, 0,
1520                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1521         { DRM_MODE("800x600", DRM_MODE_TYPE_DRIVER, 34030, 800, 801, 864,
1522                    896, 0, 600, 601, 632, 633, 0,
1523                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1524         { DRM_MODE("832x624", DRM_MODE_TYPE_DRIVER, 36581, 832, 833, 896,
1525                    928, 0, 624, 625, 656, 657, 0,
1526                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1527         { DRM_MODE("920x766", DRM_MODE_TYPE_DRIVER, 48707, 920, 921, 984,
1528                    1016, 0, 766, 767, 798, 799, 0,
1529                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1530         { DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 53827, 1024, 1025, 1088,
1531                    1120, 0, 768, 769, 800, 801, 0,
1532                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1533         { DRM_MODE("1280x1024", DRM_MODE_TYPE_DRIVER, 87265, 1280, 1281, 1344,
1534                    1376, 0, 1024, 1025, 1056, 1057, 0,
1535                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1536 };
1537
1538 static void intel_sdvo_get_tv_modes(struct drm_connector *connector)
1539 {
1540         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1541         struct intel_sdvo_sdtv_resolution_request tv_res;
1542         uint32_t reply = 0, format_map = 0;
1543         int i;
1544
1545         /* Read the list of supported input resolutions for the selected TV
1546          * format.
1547          */
1548         format_map = 1 << intel_sdvo->tv_format_index;
1549         memcpy(&tv_res, &format_map,
1550                min(sizeof(format_map), sizeof(struct intel_sdvo_sdtv_resolution_request)));
1551
1552         if (!intel_sdvo_set_target_output(intel_sdvo, intel_sdvo->attached_output))
1553                 return;
1554
1555         BUILD_BUG_ON(sizeof(tv_res) != 3);
1556         if (!intel_sdvo_write_cmd(intel_sdvo,
1557                                   SDVO_CMD_GET_SDTV_RESOLUTION_SUPPORT,
1558                                   &tv_res, sizeof(tv_res)))
1559                 return;
1560         if (!intel_sdvo_read_response(intel_sdvo, &reply, 3))
1561                 return;
1562
1563         for (i = 0; i < ARRAY_SIZE(sdvo_tv_modes); i++)
1564                 if (reply & (1 << i)) {
1565                         struct drm_display_mode *nmode;
1566                         nmode = drm_mode_duplicate(connector->dev,
1567                                                    &sdvo_tv_modes[i]);
1568                         if (nmode)
1569                                 drm_mode_probed_add(connector, nmode);
1570                 }
1571 }
1572
1573 static void intel_sdvo_get_lvds_modes(struct drm_connector *connector)
1574 {
1575         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1576         struct drm_i915_private *dev_priv = connector->dev->dev_private;
1577         struct drm_display_mode *newmode;
1578
1579         /*
1580          * Attempt to get the mode list from DDC.
1581          * Assume that the preferred modes are
1582          * arranged in priority order.
1583          */
1584         intel_ddc_get_modes(connector, intel_sdvo->i2c);
1585         if (list_empty(&connector->probed_modes) == false)
1586                 goto end;
1587
1588         /* Fetch modes from VBT */
1589         if (dev_priv->sdvo_lvds_vbt_mode != NULL) {
1590                 newmode = drm_mode_duplicate(connector->dev,
1591                                              dev_priv->sdvo_lvds_vbt_mode);
1592                 if (newmode != NULL) {
1593                         /* Guarantee the mode is preferred */
1594                         newmode->type = (DRM_MODE_TYPE_PREFERRED |
1595                                          DRM_MODE_TYPE_DRIVER);
1596                         drm_mode_probed_add(connector, newmode);
1597                 }
1598         }
1599
1600 end:
1601         list_for_each_entry(newmode, &connector->probed_modes, head) {
1602                 if (newmode->type & DRM_MODE_TYPE_PREFERRED) {
1603                         intel_sdvo->sdvo_lvds_fixed_mode =
1604                                 drm_mode_duplicate(connector->dev, newmode);
1605
1606                         intel_sdvo->is_lvds = true;
1607                         break;
1608                 }
1609         }
1610
1611 }
1612
1613 static int intel_sdvo_get_modes(struct drm_connector *connector)
1614 {
1615         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1616
1617         if (IS_TV(intel_sdvo_connector))
1618                 intel_sdvo_get_tv_modes(connector);
1619         else if (IS_LVDS(intel_sdvo_connector))
1620                 intel_sdvo_get_lvds_modes(connector);
1621         else
1622                 intel_sdvo_get_ddc_modes(connector);
1623
1624         return !list_empty(&connector->probed_modes);
1625 }
1626
1627 static void
1628 intel_sdvo_destroy_enhance_property(struct drm_connector *connector)
1629 {
1630         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1631         struct drm_device *dev = connector->dev;
1632
1633         if (intel_sdvo_connector->left)
1634                 drm_property_destroy(dev, intel_sdvo_connector->left);
1635         if (intel_sdvo_connector->right)
1636                 drm_property_destroy(dev, intel_sdvo_connector->right);
1637         if (intel_sdvo_connector->top)
1638                 drm_property_destroy(dev, intel_sdvo_connector->top);
1639         if (intel_sdvo_connector->bottom)
1640                 drm_property_destroy(dev, intel_sdvo_connector->bottom);
1641         if (intel_sdvo_connector->hpos)
1642                 drm_property_destroy(dev, intel_sdvo_connector->hpos);
1643         if (intel_sdvo_connector->vpos)
1644                 drm_property_destroy(dev, intel_sdvo_connector->vpos);
1645         if (intel_sdvo_connector->saturation)
1646                 drm_property_destroy(dev, intel_sdvo_connector->saturation);
1647         if (intel_sdvo_connector->contrast)
1648                 drm_property_destroy(dev, intel_sdvo_connector->contrast);
1649         if (intel_sdvo_connector->hue)
1650                 drm_property_destroy(dev, intel_sdvo_connector->hue);
1651         if (intel_sdvo_connector->sharpness)
1652                 drm_property_destroy(dev, intel_sdvo_connector->sharpness);
1653         if (intel_sdvo_connector->flicker_filter)
1654                 drm_property_destroy(dev, intel_sdvo_connector->flicker_filter);
1655         if (intel_sdvo_connector->flicker_filter_2d)
1656                 drm_property_destroy(dev, intel_sdvo_connector->flicker_filter_2d);
1657         if (intel_sdvo_connector->flicker_filter_adaptive)
1658                 drm_property_destroy(dev, intel_sdvo_connector->flicker_filter_adaptive);
1659         if (intel_sdvo_connector->tv_luma_filter)
1660                 drm_property_destroy(dev, intel_sdvo_connector->tv_luma_filter);
1661         if (intel_sdvo_connector->tv_chroma_filter)
1662                 drm_property_destroy(dev, intel_sdvo_connector->tv_chroma_filter);
1663         if (intel_sdvo_connector->dot_crawl)
1664                 drm_property_destroy(dev, intel_sdvo_connector->dot_crawl);
1665         if (intel_sdvo_connector->brightness)
1666                 drm_property_destroy(dev, intel_sdvo_connector->brightness);
1667 }
1668
1669 static void intel_sdvo_destroy(struct drm_connector *connector)
1670 {
1671         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1672
1673         if (intel_sdvo_connector->tv_format)
1674                 drm_property_destroy(connector->dev,
1675                                      intel_sdvo_connector->tv_format);
1676
1677         intel_sdvo_destroy_enhance_property(connector);
1678         drm_sysfs_connector_remove(connector);
1679         drm_connector_cleanup(connector);
1680         kfree(connector);
1681 }
1682
1683 static bool intel_sdvo_detect_hdmi_audio(struct drm_connector *connector)
1684 {
1685         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1686         struct edid *edid;
1687         bool has_audio = false;
1688
1689         if (!intel_sdvo->is_hdmi)
1690                 return false;
1691
1692         edid = intel_sdvo_get_edid(connector);
1693         if (edid != NULL && edid->input & DRM_EDID_INPUT_DIGITAL)
1694                 has_audio = drm_detect_monitor_audio(edid);
1695
1696         return has_audio;
1697 }
1698
1699 static int
1700 intel_sdvo_set_property(struct drm_connector *connector,
1701                         struct drm_property *property,
1702                         uint64_t val)
1703 {
1704         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1705         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1706         struct drm_i915_private *dev_priv = connector->dev->dev_private;
1707         uint16_t temp_value;
1708         uint8_t cmd;
1709         int ret;
1710
1711         ret = drm_connector_property_set_value(connector, property, val);
1712         if (ret)
1713                 return ret;
1714
1715         if (property == dev_priv->force_audio_property) {
1716                 int i = val;
1717                 bool has_audio;
1718
1719                 if (i == intel_sdvo_connector->force_audio)
1720                         return 0;
1721
1722                 intel_sdvo_connector->force_audio = i;
1723
1724                 if (i == HDMI_AUDIO_AUTO)
1725                         has_audio = intel_sdvo_detect_hdmi_audio(connector);
1726                 else
1727                         has_audio = (i == HDMI_AUDIO_ON);
1728
1729                 if (has_audio == intel_sdvo->has_hdmi_audio)
1730                         return 0;
1731
1732                 intel_sdvo->has_hdmi_audio = has_audio;
1733                 goto done;
1734         }
1735
1736         if (property == dev_priv->broadcast_rgb_property) {
1737                 if (val == !!intel_sdvo->color_range)
1738                         return 0;
1739
1740                 intel_sdvo->color_range = val ? SDVO_COLOR_RANGE_16_235 : 0;
1741                 goto done;
1742         }
1743
1744 #define CHECK_PROPERTY(name, NAME) \
1745         if (intel_sdvo_connector->name == property) { \
1746                 if (intel_sdvo_connector->cur_##name == temp_value) return 0; \
1747                 if (intel_sdvo_connector->max_##name < temp_value) return -EINVAL; \
1748                 cmd = SDVO_CMD_SET_##NAME; \
1749                 intel_sdvo_connector->cur_##name = temp_value; \
1750                 goto set_value; \
1751         }
1752
1753         if (property == intel_sdvo_connector->tv_format) {
1754                 if (val >= TV_FORMAT_NUM)
1755                         return -EINVAL;
1756
1757                 if (intel_sdvo->tv_format_index ==
1758                     intel_sdvo_connector->tv_format_supported[val])
1759                         return 0;
1760
1761                 intel_sdvo->tv_format_index = intel_sdvo_connector->tv_format_supported[val];
1762                 goto done;
1763         } else if (IS_TV_OR_LVDS(intel_sdvo_connector)) {
1764                 temp_value = val;
1765                 if (intel_sdvo_connector->left == property) {
1766                         drm_connector_property_set_value(connector,
1767                                                          intel_sdvo_connector->right, val);
1768                         if (intel_sdvo_connector->left_margin == temp_value)
1769                                 return 0;
1770
1771                         intel_sdvo_connector->left_margin = temp_value;
1772                         intel_sdvo_connector->right_margin = temp_value;
1773                         temp_value = intel_sdvo_connector->max_hscan -
1774                                 intel_sdvo_connector->left_margin;
1775                         cmd = SDVO_CMD_SET_OVERSCAN_H;
1776                         goto set_value;
1777                 } else if (intel_sdvo_connector->right == property) {
1778                         drm_connector_property_set_value(connector,
1779                                                          intel_sdvo_connector->left, val);
1780                         if (intel_sdvo_connector->right_margin == temp_value)
1781                                 return 0;
1782
1783                         intel_sdvo_connector->left_margin = temp_value;
1784                         intel_sdvo_connector->right_margin = temp_value;
1785                         temp_value = intel_sdvo_connector->max_hscan -
1786                                 intel_sdvo_connector->left_margin;
1787                         cmd = SDVO_CMD_SET_OVERSCAN_H;
1788                         goto set_value;
1789                 } else if (intel_sdvo_connector->top == property) {
1790                         drm_connector_property_set_value(connector,
1791                                                          intel_sdvo_connector->bottom, val);
1792                         if (intel_sdvo_connector->top_margin == temp_value)
1793                                 return 0;
1794
1795                         intel_sdvo_connector->top_margin = temp_value;
1796                         intel_sdvo_connector->bottom_margin = temp_value;
1797                         temp_value = intel_sdvo_connector->max_vscan -
1798                                 intel_sdvo_connector->top_margin;
1799                         cmd = SDVO_CMD_SET_OVERSCAN_V;
1800                         goto set_value;
1801                 } else if (intel_sdvo_connector->bottom == property) {
1802                         drm_connector_property_set_value(connector,
1803                                                          intel_sdvo_connector->top, val);
1804                         if (intel_sdvo_connector->bottom_margin == temp_value)
1805                                 return 0;
1806
1807                         intel_sdvo_connector->top_margin = temp_value;
1808                         intel_sdvo_connector->bottom_margin = temp_value;
1809                         temp_value = intel_sdvo_connector->max_vscan -
1810                                 intel_sdvo_connector->top_margin;
1811                         cmd = SDVO_CMD_SET_OVERSCAN_V;
1812                         goto set_value;
1813                 }
1814                 CHECK_PROPERTY(hpos, HPOS)
1815                 CHECK_PROPERTY(vpos, VPOS)
1816                 CHECK_PROPERTY(saturation, SATURATION)
1817                 CHECK_PROPERTY(contrast, CONTRAST)
1818                 CHECK_PROPERTY(hue, HUE)
1819                 CHECK_PROPERTY(brightness, BRIGHTNESS)
1820                 CHECK_PROPERTY(sharpness, SHARPNESS)
1821                 CHECK_PROPERTY(flicker_filter, FLICKER_FILTER)
1822                 CHECK_PROPERTY(flicker_filter_2d, FLICKER_FILTER_2D)
1823                 CHECK_PROPERTY(flicker_filter_adaptive, FLICKER_FILTER_ADAPTIVE)
1824                 CHECK_PROPERTY(tv_chroma_filter, TV_CHROMA_FILTER)
1825                 CHECK_PROPERTY(tv_luma_filter, TV_LUMA_FILTER)
1826                 CHECK_PROPERTY(dot_crawl, DOT_CRAWL)
1827         }
1828
1829         return -EINVAL; /* unknown property */
1830
1831 set_value:
1832         if (!intel_sdvo_set_value(intel_sdvo, cmd, &temp_value, 2))
1833                 return -EIO;
1834
1835
1836 done:
1837         if (intel_sdvo->base.base.crtc) {
1838                 struct drm_crtc *crtc = intel_sdvo->base.base.crtc;
1839                 drm_crtc_helper_set_mode(crtc, &crtc->mode, crtc->x,
1840                                          crtc->y, crtc->fb);
1841         }
1842
1843         return 0;
1844 #undef CHECK_PROPERTY
1845 }
1846
1847 static const struct drm_encoder_helper_funcs intel_sdvo_helper_funcs = {
1848         .dpms = intel_sdvo_dpms,
1849         .mode_fixup = intel_sdvo_mode_fixup,
1850         .prepare = intel_encoder_prepare,
1851         .mode_set = intel_sdvo_mode_set,
1852         .commit = intel_encoder_commit,
1853 };
1854
1855 static const struct drm_connector_funcs intel_sdvo_connector_funcs = {
1856         .dpms = drm_helper_connector_dpms,
1857         .detect = intel_sdvo_detect,
1858         .fill_modes = drm_helper_probe_single_connector_modes,
1859         .set_property = intel_sdvo_set_property,
1860         .destroy = intel_sdvo_destroy,
1861 };
1862
1863 static const struct drm_connector_helper_funcs intel_sdvo_connector_helper_funcs = {
1864         .get_modes = intel_sdvo_get_modes,
1865         .mode_valid = intel_sdvo_mode_valid,
1866         .best_encoder = intel_best_encoder,
1867 };
1868
1869 static void intel_sdvo_enc_destroy(struct drm_encoder *encoder)
1870 {
1871         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
1872
1873         if (intel_sdvo->sdvo_lvds_fixed_mode != NULL)
1874                 drm_mode_destroy(encoder->dev,
1875                                  intel_sdvo->sdvo_lvds_fixed_mode);
1876
1877         i2c_del_adapter(&intel_sdvo->ddc);
1878         intel_encoder_destroy(encoder);
1879 }
1880
1881 static const struct drm_encoder_funcs intel_sdvo_enc_funcs = {
1882         .destroy = intel_sdvo_enc_destroy,
1883 };
1884
1885 static void
1886 intel_sdvo_guess_ddc_bus(struct intel_sdvo *sdvo)
1887 {
1888         uint16_t mask = 0;
1889         unsigned int num_bits;
1890
1891         /* Make a mask of outputs less than or equal to our own priority in the
1892          * list.
1893          */
1894         switch (sdvo->controlled_output) {
1895         case SDVO_OUTPUT_LVDS1:
1896                 mask |= SDVO_OUTPUT_LVDS1;
1897         case SDVO_OUTPUT_LVDS0:
1898                 mask |= SDVO_OUTPUT_LVDS0;
1899         case SDVO_OUTPUT_TMDS1:
1900                 mask |= SDVO_OUTPUT_TMDS1;
1901         case SDVO_OUTPUT_TMDS0:
1902                 mask |= SDVO_OUTPUT_TMDS0;
1903         case SDVO_OUTPUT_RGB1:
1904                 mask |= SDVO_OUTPUT_RGB1;
1905         case SDVO_OUTPUT_RGB0:
1906                 mask |= SDVO_OUTPUT_RGB0;
1907                 break;
1908         }
1909
1910         /* Count bits to find what number we are in the priority list. */
1911         mask &= sdvo->caps.output_flags;
1912         num_bits = hweight16(mask);
1913         /* If more than 3 outputs, default to DDC bus 3 for now. */
1914         if (num_bits > 3)
1915                 num_bits = 3;
1916
1917         /* Corresponds to SDVO_CONTROL_BUS_DDCx */
1918         sdvo->ddc_bus = 1 << num_bits;
1919 }
1920
1921 /**
1922  * Choose the appropriate DDC bus for control bus switch command for this
1923  * SDVO output based on the controlled output.
1924  *
1925  * DDC bus number assignment is in a priority order of RGB outputs, then TMDS
1926  * outputs, then LVDS outputs.
1927  */
1928 static void
1929 intel_sdvo_select_ddc_bus(struct drm_i915_private *dev_priv,
1930                           struct intel_sdvo *sdvo, u32 reg)
1931 {
1932         struct sdvo_device_mapping *mapping;
1933
1934         if (sdvo->is_sdvob)
1935                 mapping = &(dev_priv->sdvo_mappings[0]);
1936         else
1937                 mapping = &(dev_priv->sdvo_mappings[1]);
1938
1939         if (mapping->initialized)
1940                 sdvo->ddc_bus = 1 << ((mapping->ddc_pin & 0xf0) >> 4);
1941         else
1942                 intel_sdvo_guess_ddc_bus(sdvo);
1943 }
1944
1945 static void
1946 intel_sdvo_select_i2c_bus(struct drm_i915_private *dev_priv,
1947                           struct intel_sdvo *sdvo, u32 reg)
1948 {
1949         struct sdvo_device_mapping *mapping;
1950         u8 pin;
1951
1952         if (sdvo->is_sdvob)
1953                 mapping = &dev_priv->sdvo_mappings[0];
1954         else
1955                 mapping = &dev_priv->sdvo_mappings[1];
1956
1957         pin = GMBUS_PORT_DPB;
1958         if (mapping->initialized)
1959                 pin = mapping->i2c_pin;
1960
1961         if (intel_gmbus_is_port_valid(pin)) {
1962                 sdvo->i2c = intel_gmbus_get_adapter(dev_priv, pin);
1963                 intel_gmbus_set_speed(sdvo->i2c, GMBUS_RATE_1MHZ);
1964                 intel_gmbus_force_bit(sdvo->i2c, true);
1965         } else {
1966                 sdvo->i2c = intel_gmbus_get_adapter(dev_priv, GMBUS_PORT_DPB);
1967         }
1968 }
1969
1970 static bool
1971 intel_sdvo_is_hdmi_connector(struct intel_sdvo *intel_sdvo, int device)
1972 {
1973         return intel_sdvo_check_supp_encode(intel_sdvo);
1974 }
1975
1976 static u8
1977 intel_sdvo_get_slave_addr(struct drm_device *dev, struct intel_sdvo *sdvo)
1978 {
1979         struct drm_i915_private *dev_priv = dev->dev_private;
1980         struct sdvo_device_mapping *my_mapping, *other_mapping;
1981
1982         if (sdvo->is_sdvob) {
1983                 my_mapping = &dev_priv->sdvo_mappings[0];
1984                 other_mapping = &dev_priv->sdvo_mappings[1];
1985         } else {
1986                 my_mapping = &dev_priv->sdvo_mappings[1];
1987                 other_mapping = &dev_priv->sdvo_mappings[0];
1988         }
1989
1990         /* If the BIOS described our SDVO device, take advantage of it. */
1991         if (my_mapping->slave_addr)
1992                 return my_mapping->slave_addr;
1993
1994         /* If the BIOS only described a different SDVO device, use the
1995          * address that it isn't using.
1996          */
1997         if (other_mapping->slave_addr) {
1998                 if (other_mapping->slave_addr == 0x70)
1999                         return 0x72;
2000                 else
2001                         return 0x70;
2002         }
2003
2004         /* No SDVO device info is found for another DVO port,
2005          * so use mapping assumption we had before BIOS parsing.
2006          */
2007         if (sdvo->is_sdvob)
2008                 return 0x70;
2009         else
2010                 return 0x72;
2011 }
2012
2013 static void
2014 intel_sdvo_connector_init(struct intel_sdvo_connector *connector,
2015                           struct intel_sdvo *encoder)
2016 {
2017         drm_connector_init(encoder->base.base.dev,
2018                            &connector->base.base,
2019                            &intel_sdvo_connector_funcs,
2020                            connector->base.base.connector_type);
2021
2022         drm_connector_helper_add(&connector->base.base,
2023                                  &intel_sdvo_connector_helper_funcs);
2024
2025         connector->base.base.interlace_allowed = 1;
2026         connector->base.base.doublescan_allowed = 0;
2027         connector->base.base.display_info.subpixel_order = SubPixelHorizontalRGB;
2028
2029         intel_connector_attach_encoder(&connector->base, &encoder->base);
2030         drm_sysfs_connector_add(&connector->base.base);
2031 }
2032
2033 static void
2034 intel_sdvo_add_hdmi_properties(struct intel_sdvo_connector *connector)
2035 {
2036         struct drm_device *dev = connector->base.base.dev;
2037
2038         intel_attach_force_audio_property(&connector->base.base);
2039         if (INTEL_INFO(dev)->gen >= 4 && IS_MOBILE(dev))
2040                 intel_attach_broadcast_rgb_property(&connector->base.base);
2041 }
2042
2043 static bool
2044 intel_sdvo_dvi_init(struct intel_sdvo *intel_sdvo, int device)
2045 {
2046         struct drm_encoder *encoder = &intel_sdvo->base.base;
2047         struct drm_connector *connector;
2048         struct intel_encoder *intel_encoder = to_intel_encoder(encoder);
2049         struct intel_connector *intel_connector;
2050         struct intel_sdvo_connector *intel_sdvo_connector;
2051
2052         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2053         if (!intel_sdvo_connector)
2054                 return false;
2055
2056         if (device == 0) {
2057                 intel_sdvo->controlled_output |= SDVO_OUTPUT_TMDS0;
2058                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_TMDS0;
2059         } else if (device == 1) {
2060                 intel_sdvo->controlled_output |= SDVO_OUTPUT_TMDS1;
2061                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_TMDS1;
2062         }
2063
2064         intel_connector = &intel_sdvo_connector->base;
2065         connector = &intel_connector->base;
2066         if (intel_sdvo_supports_hotplug(intel_sdvo) & (1 << device)) {
2067                 connector->polled = DRM_CONNECTOR_POLL_HPD;
2068                 intel_sdvo->hotplug_active[0] |= 1 << device;
2069                 /* Some SDVO devices have one-shot hotplug interrupts.
2070                  * Ensure that they get re-enabled when an interrupt happens.
2071                  */
2072                 intel_encoder->hot_plug = intel_sdvo_enable_hotplug;
2073                 intel_sdvo_enable_hotplug(intel_encoder);
2074         }
2075         else
2076                 connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
2077         encoder->encoder_type = DRM_MODE_ENCODER_TMDS;
2078         connector->connector_type = DRM_MODE_CONNECTOR_DVID;
2079
2080         if (intel_sdvo_is_hdmi_connector(intel_sdvo, device)) {
2081                 connector->connector_type = DRM_MODE_CONNECTOR_HDMIA;
2082                 intel_sdvo->is_hdmi = true;
2083         }
2084         intel_sdvo->base.cloneable = true;
2085
2086         intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
2087         if (intel_sdvo->is_hdmi)
2088                 intel_sdvo_add_hdmi_properties(intel_sdvo_connector);
2089
2090         return true;
2091 }
2092
2093 static bool
2094 intel_sdvo_tv_init(struct intel_sdvo *intel_sdvo, int type)
2095 {
2096         struct drm_encoder *encoder = &intel_sdvo->base.base;
2097         struct drm_connector *connector;
2098         struct intel_connector *intel_connector;
2099         struct intel_sdvo_connector *intel_sdvo_connector;
2100
2101         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2102         if (!intel_sdvo_connector)
2103                 return false;
2104
2105         intel_connector = &intel_sdvo_connector->base;
2106         connector = &intel_connector->base;
2107         encoder->encoder_type = DRM_MODE_ENCODER_TVDAC;
2108         connector->connector_type = DRM_MODE_CONNECTOR_SVIDEO;
2109
2110         intel_sdvo->controlled_output |= type;
2111         intel_sdvo_connector->output_flag = type;
2112
2113         intel_sdvo->is_tv = true;
2114         intel_sdvo->base.needs_tv_clock = true;
2115         intel_sdvo->base.cloneable = false;
2116
2117         intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
2118
2119         if (!intel_sdvo_tv_create_property(intel_sdvo, intel_sdvo_connector, type))
2120                 goto err;
2121
2122         if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
2123                 goto err;
2124
2125         return true;
2126
2127 err:
2128         intel_sdvo_destroy(connector);
2129         return false;
2130 }
2131
2132 static bool
2133 intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device)
2134 {
2135         struct drm_encoder *encoder = &intel_sdvo->base.base;
2136         struct drm_connector *connector;
2137         struct intel_connector *intel_connector;
2138         struct intel_sdvo_connector *intel_sdvo_connector;
2139
2140         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2141         if (!intel_sdvo_connector)
2142                 return false;
2143
2144         intel_connector = &intel_sdvo_connector->base;
2145         connector = &intel_connector->base;
2146         connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2147         encoder->encoder_type = DRM_MODE_ENCODER_DAC;
2148         connector->connector_type = DRM_MODE_CONNECTOR_VGA;
2149
2150         if (device == 0) {
2151                 intel_sdvo->controlled_output |= SDVO_OUTPUT_RGB0;
2152                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_RGB0;
2153         } else if (device == 1) {
2154                 intel_sdvo->controlled_output |= SDVO_OUTPUT_RGB1;
2155                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_RGB1;
2156         }
2157
2158         intel_sdvo->base.cloneable = true;
2159
2160         intel_sdvo_connector_init(intel_sdvo_connector,
2161                                   intel_sdvo);
2162         return true;
2163 }
2164
2165 static bool
2166 intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
2167 {
2168         struct drm_encoder *encoder = &intel_sdvo->base.base;
2169         struct drm_connector *connector;
2170         struct intel_connector *intel_connector;
2171         struct intel_sdvo_connector *intel_sdvo_connector;
2172
2173         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2174         if (!intel_sdvo_connector)
2175                 return false;
2176
2177         intel_connector = &intel_sdvo_connector->base;
2178         connector = &intel_connector->base;
2179         encoder->encoder_type = DRM_MODE_ENCODER_LVDS;
2180         connector->connector_type = DRM_MODE_CONNECTOR_LVDS;
2181
2182         if (device == 0) {
2183                 intel_sdvo->controlled_output |= SDVO_OUTPUT_LVDS0;
2184                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS0;
2185         } else if (device == 1) {
2186                 intel_sdvo->controlled_output |= SDVO_OUTPUT_LVDS1;
2187                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS1;
2188         }
2189
2190         /* SDVO LVDS is cloneable because the SDVO encoder does the upscaling,
2191          * as opposed to native LVDS, where we upscale with the panel-fitter
2192          * (and hence only the native LVDS resolution could be cloned). */
2193         intel_sdvo->base.cloneable = true;
2194
2195         intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
2196         if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
2197                 goto err;
2198
2199         return true;
2200
2201 err:
2202         intel_sdvo_destroy(connector);
2203         return false;
2204 }
2205
2206 static bool
2207 intel_sdvo_output_setup(struct intel_sdvo *intel_sdvo, uint16_t flags)
2208 {
2209         intel_sdvo->is_tv = false;
2210         intel_sdvo->base.needs_tv_clock = false;
2211         intel_sdvo->is_lvds = false;
2212
2213         /* SDVO requires XXX1 function may not exist unless it has XXX0 function.*/
2214
2215         if (flags & SDVO_OUTPUT_TMDS0)
2216                 if (!intel_sdvo_dvi_init(intel_sdvo, 0))
2217                         return false;
2218
2219         if ((flags & SDVO_TMDS_MASK) == SDVO_TMDS_MASK)
2220                 if (!intel_sdvo_dvi_init(intel_sdvo, 1))
2221                         return false;
2222
2223         /* TV has no XXX1 function block */
2224         if (flags & SDVO_OUTPUT_SVID0)
2225                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_SVID0))
2226                         return false;
2227
2228         if (flags & SDVO_OUTPUT_CVBS0)
2229                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_CVBS0))
2230                         return false;
2231
2232         if (flags & SDVO_OUTPUT_YPRPB0)
2233                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_YPRPB0))
2234                         return false;
2235
2236         if (flags & SDVO_OUTPUT_RGB0)
2237                 if (!intel_sdvo_analog_init(intel_sdvo, 0))
2238                         return false;
2239
2240         if ((flags & SDVO_RGB_MASK) == SDVO_RGB_MASK)
2241                 if (!intel_sdvo_analog_init(intel_sdvo, 1))
2242                         return false;
2243
2244         if (flags & SDVO_OUTPUT_LVDS0)
2245                 if (!intel_sdvo_lvds_init(intel_sdvo, 0))
2246                         return false;
2247
2248         if ((flags & SDVO_LVDS_MASK) == SDVO_LVDS_MASK)
2249                 if (!intel_sdvo_lvds_init(intel_sdvo, 1))
2250                         return false;
2251
2252         if ((flags & SDVO_OUTPUT_MASK) == 0) {
2253                 unsigned char bytes[2];
2254
2255                 intel_sdvo->controlled_output = 0;
2256                 memcpy(bytes, &intel_sdvo->caps.output_flags, 2);
2257                 DRM_DEBUG_KMS("%s: Unknown SDVO output type (0x%02x%02x)\n",
2258                               SDVO_NAME(intel_sdvo),
2259                               bytes[0], bytes[1]);
2260                 return false;
2261         }
2262         intel_sdvo->base.crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
2263
2264         return true;
2265 }
2266
2267 static bool intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
2268                                           struct intel_sdvo_connector *intel_sdvo_connector,
2269                                           int type)
2270 {
2271         struct drm_device *dev = intel_sdvo->base.base.dev;
2272         struct intel_sdvo_tv_format format;
2273         uint32_t format_map, i;
2274
2275         if (!intel_sdvo_set_target_output(intel_sdvo, type))
2276                 return false;
2277
2278         BUILD_BUG_ON(sizeof(format) != 6);
2279         if (!intel_sdvo_get_value(intel_sdvo,
2280                                   SDVO_CMD_GET_SUPPORTED_TV_FORMATS,
2281                                   &format, sizeof(format)))
2282                 return false;
2283
2284         memcpy(&format_map, &format, min(sizeof(format_map), sizeof(format)));
2285
2286         if (format_map == 0)
2287                 return false;
2288
2289         intel_sdvo_connector->format_supported_num = 0;
2290         for (i = 0 ; i < TV_FORMAT_NUM; i++)
2291                 if (format_map & (1 << i))
2292                         intel_sdvo_connector->tv_format_supported[intel_sdvo_connector->format_supported_num++] = i;
2293
2294
2295         intel_sdvo_connector->tv_format =
2296                         drm_property_create(dev, DRM_MODE_PROP_ENUM,
2297                                             "mode", intel_sdvo_connector->format_supported_num);
2298         if (!intel_sdvo_connector->tv_format)
2299                 return false;
2300
2301         for (i = 0; i < intel_sdvo_connector->format_supported_num; i++)
2302                 drm_property_add_enum(
2303                                 intel_sdvo_connector->tv_format, i,
2304                                 i, tv_format_names[intel_sdvo_connector->tv_format_supported[i]]);
2305
2306         intel_sdvo->tv_format_index = intel_sdvo_connector->tv_format_supported[0];
2307         drm_connector_attach_property(&intel_sdvo_connector->base.base,
2308                                       intel_sdvo_connector->tv_format, 0);
2309         return true;
2310
2311 }
2312
2313 #define ENHANCEMENT(name, NAME) do { \
2314         if (enhancements.name) { \
2315                 if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_MAX_##NAME, &data_value, 4) || \
2316                     !intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_##NAME, &response, 2)) \
2317                         return false; \
2318                 intel_sdvo_connector->max_##name = data_value[0]; \
2319                 intel_sdvo_connector->cur_##name = response; \
2320                 intel_sdvo_connector->name = \
2321                         drm_property_create_range(dev, 0, #name, 0, data_value[0]); \
2322                 if (!intel_sdvo_connector->name) return false; \
2323                 drm_connector_attach_property(connector, \
2324                                               intel_sdvo_connector->name, \
2325                                               intel_sdvo_connector->cur_##name); \
2326                 DRM_DEBUG_KMS(#name ": max %d, default %d, current %d\n", \
2327                               data_value[0], data_value[1], response); \
2328         } \
2329 } while (0)
2330
2331 static bool
2332 intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo,
2333                                       struct intel_sdvo_connector *intel_sdvo_connector,
2334                                       struct intel_sdvo_enhancements_reply enhancements)
2335 {
2336         struct drm_device *dev = intel_sdvo->base.base.dev;
2337         struct drm_connector *connector = &intel_sdvo_connector->base.base;
2338         uint16_t response, data_value[2];
2339
2340         /* when horizontal overscan is supported, Add the left/right  property */
2341         if (enhancements.overscan_h) {
2342                 if (!intel_sdvo_get_value(intel_sdvo,
2343                                           SDVO_CMD_GET_MAX_OVERSCAN_H,
2344                                           &data_value, 4))
2345                         return false;
2346
2347                 if (!intel_sdvo_get_value(intel_sdvo,
2348                                           SDVO_CMD_GET_OVERSCAN_H,
2349                                           &response, 2))
2350                         return false;
2351
2352                 intel_sdvo_connector->max_hscan = data_value[0];
2353                 intel_sdvo_connector->left_margin = data_value[0] - response;
2354                 intel_sdvo_connector->right_margin = intel_sdvo_connector->left_margin;
2355                 intel_sdvo_connector->left =
2356                         drm_property_create_range(dev, 0, "left_margin", 0, data_value[0]);
2357                 if (!intel_sdvo_connector->left)
2358                         return false;
2359
2360                 drm_connector_attach_property(connector,
2361                                               intel_sdvo_connector->left,
2362                                               intel_sdvo_connector->left_margin);
2363
2364                 intel_sdvo_connector->right =
2365                         drm_property_create_range(dev, 0, "right_margin", 0, data_value[0]);
2366                 if (!intel_sdvo_connector->right)
2367                         return false;
2368
2369                 drm_connector_attach_property(connector,
2370                                               intel_sdvo_connector->right,
2371                                               intel_sdvo_connector->right_margin);
2372                 DRM_DEBUG_KMS("h_overscan: max %d, "
2373                               "default %d, current %d\n",
2374                               data_value[0], data_value[1], response);
2375         }
2376
2377         if (enhancements.overscan_v) {
2378                 if (!intel_sdvo_get_value(intel_sdvo,
2379                                           SDVO_CMD_GET_MAX_OVERSCAN_V,
2380                                           &data_value, 4))
2381                         return false;
2382
2383                 if (!intel_sdvo_get_value(intel_sdvo,
2384                                           SDVO_CMD_GET_OVERSCAN_V,
2385                                           &response, 2))
2386                         return false;
2387
2388                 intel_sdvo_connector->max_vscan = data_value[0];
2389                 intel_sdvo_connector->top_margin = data_value[0] - response;
2390                 intel_sdvo_connector->bottom_margin = intel_sdvo_connector->top_margin;
2391                 intel_sdvo_connector->top =
2392                         drm_property_create_range(dev, 0,
2393                                             "top_margin", 0, data_value[0]);
2394                 if (!intel_sdvo_connector->top)
2395                         return false;
2396
2397                 drm_connector_attach_property(connector,
2398                                               intel_sdvo_connector->top,
2399                                               intel_sdvo_connector->top_margin);
2400
2401                 intel_sdvo_connector->bottom =
2402                         drm_property_create_range(dev, 0,
2403                                             "bottom_margin", 0, data_value[0]);
2404                 if (!intel_sdvo_connector->bottom)
2405                         return false;
2406
2407                 drm_connector_attach_property(connector,
2408                                               intel_sdvo_connector->bottom,
2409                                               intel_sdvo_connector->bottom_margin);
2410                 DRM_DEBUG_KMS("v_overscan: max %d, "
2411                               "default %d, current %d\n",
2412                               data_value[0], data_value[1], response);
2413         }
2414
2415         ENHANCEMENT(hpos, HPOS);
2416         ENHANCEMENT(vpos, VPOS);
2417         ENHANCEMENT(saturation, SATURATION);
2418         ENHANCEMENT(contrast, CONTRAST);
2419         ENHANCEMENT(hue, HUE);
2420         ENHANCEMENT(sharpness, SHARPNESS);
2421         ENHANCEMENT(brightness, BRIGHTNESS);
2422         ENHANCEMENT(flicker_filter, FLICKER_FILTER);
2423         ENHANCEMENT(flicker_filter_adaptive, FLICKER_FILTER_ADAPTIVE);
2424         ENHANCEMENT(flicker_filter_2d, FLICKER_FILTER_2D);
2425         ENHANCEMENT(tv_chroma_filter, TV_CHROMA_FILTER);
2426         ENHANCEMENT(tv_luma_filter, TV_LUMA_FILTER);
2427
2428         if (enhancements.dot_crawl) {
2429                 if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_DOT_CRAWL, &response, 2))
2430                         return false;
2431
2432                 intel_sdvo_connector->max_dot_crawl = 1;
2433                 intel_sdvo_connector->cur_dot_crawl = response & 0x1;
2434                 intel_sdvo_connector->dot_crawl =
2435                         drm_property_create_range(dev, 0, "dot_crawl", 0, 1);
2436                 if (!intel_sdvo_connector->dot_crawl)
2437                         return false;
2438
2439                 drm_connector_attach_property(connector,
2440                                               intel_sdvo_connector->dot_crawl,
2441                                               intel_sdvo_connector->cur_dot_crawl);
2442                 DRM_DEBUG_KMS("dot crawl: current %d\n", response);
2443         }
2444
2445         return true;
2446 }
2447
2448 static bool
2449 intel_sdvo_create_enhance_property_lvds(struct intel_sdvo *intel_sdvo,
2450                                         struct intel_sdvo_connector *intel_sdvo_connector,
2451                                         struct intel_sdvo_enhancements_reply enhancements)
2452 {
2453         struct drm_device *dev = intel_sdvo->base.base.dev;
2454         struct drm_connector *connector = &intel_sdvo_connector->base.base;
2455         uint16_t response, data_value[2];
2456
2457         ENHANCEMENT(brightness, BRIGHTNESS);
2458
2459         return true;
2460 }
2461 #undef ENHANCEMENT
2462
2463 static bool intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo,
2464                                                struct intel_sdvo_connector *intel_sdvo_connector)
2465 {
2466         union {
2467                 struct intel_sdvo_enhancements_reply reply;
2468                 uint16_t response;
2469         } enhancements;
2470
2471         BUILD_BUG_ON(sizeof(enhancements) != 2);
2472
2473         enhancements.response = 0;
2474         intel_sdvo_get_value(intel_sdvo,
2475                              SDVO_CMD_GET_SUPPORTED_ENHANCEMENTS,
2476                              &enhancements, sizeof(enhancements));
2477         if (enhancements.response == 0) {
2478                 DRM_DEBUG_KMS("No enhancement is supported\n");
2479                 return true;
2480         }
2481
2482         if (IS_TV(intel_sdvo_connector))
2483                 return intel_sdvo_create_enhance_property_tv(intel_sdvo, intel_sdvo_connector, enhancements.reply);
2484         else if (IS_LVDS(intel_sdvo_connector))
2485                 return intel_sdvo_create_enhance_property_lvds(intel_sdvo, intel_sdvo_connector, enhancements.reply);
2486         else
2487                 return true;
2488 }
2489
2490 static int intel_sdvo_ddc_proxy_xfer(struct i2c_adapter *adapter,
2491                                      struct i2c_msg *msgs,
2492                                      int num)
2493 {
2494         struct intel_sdvo *sdvo = adapter->algo_data;
2495
2496         if (!intel_sdvo_set_control_bus_switch(sdvo, sdvo->ddc_bus))
2497                 return -EIO;
2498
2499         return sdvo->i2c->algo->master_xfer(sdvo->i2c, msgs, num);
2500 }
2501
2502 static u32 intel_sdvo_ddc_proxy_func(struct i2c_adapter *adapter)
2503 {
2504         struct intel_sdvo *sdvo = adapter->algo_data;
2505         return sdvo->i2c->algo->functionality(sdvo->i2c);
2506 }
2507
2508 static const struct i2c_algorithm intel_sdvo_ddc_proxy = {
2509         .master_xfer    = intel_sdvo_ddc_proxy_xfer,
2510         .functionality  = intel_sdvo_ddc_proxy_func
2511 };
2512
2513 static bool
2514 intel_sdvo_init_ddc_proxy(struct intel_sdvo *sdvo,
2515                           struct drm_device *dev)
2516 {
2517         sdvo->ddc.owner = THIS_MODULE;
2518         sdvo->ddc.class = I2C_CLASS_DDC;
2519         snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy");
2520         sdvo->ddc.dev.parent = &dev->pdev->dev;
2521         sdvo->ddc.algo_data = sdvo;
2522         sdvo->ddc.algo = &intel_sdvo_ddc_proxy;
2523
2524         return i2c_add_adapter(&sdvo->ddc) == 0;
2525 }
2526
2527 bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob)
2528 {
2529         struct drm_i915_private *dev_priv = dev->dev_private;
2530         struct intel_encoder *intel_encoder;
2531         struct intel_sdvo *intel_sdvo;
2532         u32 hotplug_mask;
2533         int i;
2534
2535         intel_sdvo = kzalloc(sizeof(struct intel_sdvo), GFP_KERNEL);
2536         if (!intel_sdvo)
2537                 return false;
2538
2539         intel_sdvo->sdvo_reg = sdvo_reg;
2540         intel_sdvo->is_sdvob = is_sdvob;
2541         intel_sdvo->slave_addr = intel_sdvo_get_slave_addr(dev, intel_sdvo) >> 1;
2542         intel_sdvo_select_i2c_bus(dev_priv, intel_sdvo, sdvo_reg);
2543         if (!intel_sdvo_init_ddc_proxy(intel_sdvo, dev)) {
2544                 kfree(intel_sdvo);
2545                 return false;
2546         }
2547
2548         /* encoder type will be decided later */
2549         intel_encoder = &intel_sdvo->base;
2550         intel_encoder->type = INTEL_OUTPUT_SDVO;
2551         drm_encoder_init(dev, &intel_encoder->base, &intel_sdvo_enc_funcs, 0);
2552
2553         /* Read the regs to test if we can talk to the device */
2554         for (i = 0; i < 0x40; i++) {
2555                 u8 byte;
2556
2557                 if (!intel_sdvo_read_byte(intel_sdvo, i, &byte)) {
2558                         DRM_DEBUG_KMS("No SDVO device found on %s\n",
2559                                       SDVO_NAME(intel_sdvo));
2560                         goto err;
2561                 }
2562         }
2563
2564         hotplug_mask = 0;
2565         if (IS_G4X(dev)) {
2566                 hotplug_mask = intel_sdvo->is_sdvob ?
2567                         SDVOB_HOTPLUG_INT_STATUS_G4X : SDVOC_HOTPLUG_INT_STATUS_G4X;
2568         } else if (IS_GEN4(dev)) {
2569                 hotplug_mask = intel_sdvo->is_sdvob ?
2570                         SDVOB_HOTPLUG_INT_STATUS_I965 : SDVOC_HOTPLUG_INT_STATUS_I965;
2571         } else {
2572                 hotplug_mask = intel_sdvo->is_sdvob ?
2573                         SDVOB_HOTPLUG_INT_STATUS_I915 : SDVOC_HOTPLUG_INT_STATUS_I915;
2574         }
2575         dev_priv->hotplug_supported_mask |= hotplug_mask;
2576
2577         drm_encoder_helper_add(&intel_encoder->base, &intel_sdvo_helper_funcs);
2578
2579         /* In default case sdvo lvds is false */
2580         if (!intel_sdvo_get_capabilities(intel_sdvo, &intel_sdvo->caps))
2581                 goto err;
2582
2583         /* Set up hotplug command - note paranoia about contents of reply.
2584          * We assume that the hardware is in a sane state, and only touch
2585          * the bits we think we understand.
2586          */
2587         intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_ACTIVE_HOT_PLUG,
2588                              &intel_sdvo->hotplug_active, 2);
2589         intel_sdvo->hotplug_active[0] &= ~0x3;
2590
2591         if (intel_sdvo_output_setup(intel_sdvo,
2592                                     intel_sdvo->caps.output_flags) != true) {
2593                 DRM_DEBUG_KMS("SDVO output failed to setup on %s\n",
2594                               SDVO_NAME(intel_sdvo));
2595                 goto err;
2596         }
2597
2598         intel_sdvo_select_ddc_bus(dev_priv, intel_sdvo, sdvo_reg);
2599
2600         /* Set the input timing to the screen. Assume always input 0. */
2601         if (!intel_sdvo_set_target_input(intel_sdvo))
2602                 goto err;
2603
2604         if (!intel_sdvo_get_input_pixel_clock_range(intel_sdvo,
2605                                                     &intel_sdvo->pixel_clock_min,
2606                                                     &intel_sdvo->pixel_clock_max))
2607                 goto err;
2608
2609         DRM_DEBUG_KMS("%s device VID/DID: %02X:%02X.%02X, "
2610                         "clock range %dMHz - %dMHz, "
2611                         "input 1: %c, input 2: %c, "
2612                         "output 1: %c, output 2: %c\n",
2613                         SDVO_NAME(intel_sdvo),
2614                         intel_sdvo->caps.vendor_id, intel_sdvo->caps.device_id,
2615                         intel_sdvo->caps.device_rev_id,
2616                         intel_sdvo->pixel_clock_min / 1000,
2617                         intel_sdvo->pixel_clock_max / 1000,
2618                         (intel_sdvo->caps.sdvo_inputs_mask & 0x1) ? 'Y' : 'N',
2619                         (intel_sdvo->caps.sdvo_inputs_mask & 0x2) ? 'Y' : 'N',
2620                         /* check currently supported outputs */
2621                         intel_sdvo->caps.output_flags &
2622                         (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_RGB0) ? 'Y' : 'N',
2623                         intel_sdvo->caps.output_flags &
2624                         (SDVO_OUTPUT_TMDS1 | SDVO_OUTPUT_RGB1) ? 'Y' : 'N');
2625         return true;
2626
2627 err:
2628         drm_encoder_cleanup(&intel_encoder->base);
2629         i2c_del_adapter(&intel_sdvo->ddc);
2630         kfree(intel_sdvo);
2631
2632         return false;
2633 }