2 * Copyright © 2006-2010 Intel Corporation
3 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
25 * Eric Anholt <eric@anholt.net>
26 * Dave Airlie <airlied@linux.ie>
27 * Jesse Barnes <jesse.barnes@intel.com>
28 * Chris Wilson <chris@chris-wilson.co.uk>
31 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
33 #include <linux/moduleparam.h>
34 #include "intel_drv.h"
36 #define PCI_LBPC 0xf4 /* legacy/combination backlight modes */
39 intel_fixed_panel_mode(const struct drm_display_mode *fixed_mode,
40 struct drm_display_mode *adjusted_mode)
42 drm_mode_copy(adjusted_mode, fixed_mode);
44 drm_mode_set_crtcinfo(adjusted_mode, 0);
47 /* adjusted_mode has been preset to be the panel's fixed mode */
49 intel_pch_panel_fitting(struct intel_crtc *intel_crtc,
50 struct intel_crtc_config *pipe_config,
53 struct drm_display_mode *mode, *adjusted_mode;
54 int x, y, width, height;
56 mode = &pipe_config->requested_mode;
57 adjusted_mode = &pipe_config->adjusted_mode;
59 x = y = width = height = 0;
61 /* Native modes don't need fitting */
62 if (adjusted_mode->hdisplay == mode->hdisplay &&
63 adjusted_mode->vdisplay == mode->vdisplay)
66 switch (fitting_mode) {
67 case DRM_MODE_SCALE_CENTER:
68 width = mode->hdisplay;
69 height = mode->vdisplay;
70 x = (adjusted_mode->hdisplay - width + 1)/2;
71 y = (adjusted_mode->vdisplay - height + 1)/2;
74 case DRM_MODE_SCALE_ASPECT:
75 /* Scale but preserve the aspect ratio */
77 u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
78 u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;
79 if (scaled_width > scaled_height) { /* pillar */
80 width = scaled_height / mode->vdisplay;
83 x = (adjusted_mode->hdisplay - width + 1) / 2;
85 height = adjusted_mode->vdisplay;
86 } else if (scaled_width < scaled_height) { /* letter */
87 height = scaled_width / mode->hdisplay;
90 y = (adjusted_mode->vdisplay - height + 1) / 2;
92 width = adjusted_mode->hdisplay;
95 width = adjusted_mode->hdisplay;
96 height = adjusted_mode->vdisplay;
101 case DRM_MODE_SCALE_FULLSCREEN:
103 width = adjusted_mode->hdisplay;
104 height = adjusted_mode->vdisplay;
108 WARN(1, "bad panel fit mode: %d\n", fitting_mode);
113 pipe_config->pch_pfit.pos = (x << 16) | y;
114 pipe_config->pch_pfit.size = (width << 16) | height;
115 pipe_config->pch_pfit.enabled = pipe_config->pch_pfit.size != 0;
119 centre_horizontally(struct drm_display_mode *mode,
122 u32 border, sync_pos, blank_width, sync_width;
124 /* keep the hsync and hblank widths constant */
125 sync_width = mode->crtc_hsync_end - mode->crtc_hsync_start;
126 blank_width = mode->crtc_hblank_end - mode->crtc_hblank_start;
127 sync_pos = (blank_width - sync_width + 1) / 2;
129 border = (mode->hdisplay - width + 1) / 2;
130 border += border & 1; /* make the border even */
132 mode->crtc_hdisplay = width;
133 mode->crtc_hblank_start = width + border;
134 mode->crtc_hblank_end = mode->crtc_hblank_start + blank_width;
136 mode->crtc_hsync_start = mode->crtc_hblank_start + sync_pos;
137 mode->crtc_hsync_end = mode->crtc_hsync_start + sync_width;
141 centre_vertically(struct drm_display_mode *mode,
144 u32 border, sync_pos, blank_width, sync_width;
146 /* keep the vsync and vblank widths constant */
147 sync_width = mode->crtc_vsync_end - mode->crtc_vsync_start;
148 blank_width = mode->crtc_vblank_end - mode->crtc_vblank_start;
149 sync_pos = (blank_width - sync_width + 1) / 2;
151 border = (mode->vdisplay - height + 1) / 2;
153 mode->crtc_vdisplay = height;
154 mode->crtc_vblank_start = height + border;
155 mode->crtc_vblank_end = mode->crtc_vblank_start + blank_width;
157 mode->crtc_vsync_start = mode->crtc_vblank_start + sync_pos;
158 mode->crtc_vsync_end = mode->crtc_vsync_start + sync_width;
161 static inline u32 panel_fitter_scaling(u32 source, u32 target)
164 * Floating point operation is not supported. So the FACTOR
165 * is defined, which can avoid the floating point computation
166 * when calculating the panel ratio.
169 #define FACTOR (1 << ACCURACY)
170 u32 ratio = source * FACTOR / target;
171 return (FACTOR * ratio + FACTOR/2) / FACTOR;
174 void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc,
175 struct intel_crtc_config *pipe_config,
178 struct drm_device *dev = intel_crtc->base.dev;
179 u32 pfit_control = 0, pfit_pgm_ratios = 0, border = 0;
180 struct drm_display_mode *mode, *adjusted_mode;
182 mode = &pipe_config->requested_mode;
183 adjusted_mode = &pipe_config->adjusted_mode;
185 /* Native modes don't need fitting */
186 if (adjusted_mode->hdisplay == mode->hdisplay &&
187 adjusted_mode->vdisplay == mode->vdisplay)
190 switch (fitting_mode) {
191 case DRM_MODE_SCALE_CENTER:
193 * For centered modes, we have to calculate border widths &
194 * heights and modify the values programmed into the CRTC.
196 centre_horizontally(adjusted_mode, mode->hdisplay);
197 centre_vertically(adjusted_mode, mode->vdisplay);
198 border = LVDS_BORDER_ENABLE;
200 case DRM_MODE_SCALE_ASPECT:
201 /* Scale but preserve the aspect ratio */
202 if (INTEL_INFO(dev)->gen >= 4) {
203 u32 scaled_width = adjusted_mode->hdisplay *
205 u32 scaled_height = mode->hdisplay *
206 adjusted_mode->vdisplay;
208 /* 965+ is easy, it does everything in hw */
209 if (scaled_width > scaled_height)
210 pfit_control |= PFIT_ENABLE |
212 else if (scaled_width < scaled_height)
213 pfit_control |= PFIT_ENABLE |
215 else if (adjusted_mode->hdisplay != mode->hdisplay)
216 pfit_control |= PFIT_ENABLE | PFIT_SCALING_AUTO;
218 u32 scaled_width = adjusted_mode->hdisplay *
220 u32 scaled_height = mode->hdisplay *
221 adjusted_mode->vdisplay;
223 * For earlier chips we have to calculate the scaling
224 * ratio by hand and program it into the
225 * PFIT_PGM_RATIO register
227 if (scaled_width > scaled_height) { /* pillar */
228 centre_horizontally(adjusted_mode,
232 border = LVDS_BORDER_ENABLE;
233 if (mode->vdisplay != adjusted_mode->vdisplay) {
234 u32 bits = panel_fitter_scaling(mode->vdisplay, adjusted_mode->vdisplay);
235 pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
236 bits << PFIT_VERT_SCALE_SHIFT);
237 pfit_control |= (PFIT_ENABLE |
238 VERT_INTERP_BILINEAR |
239 HORIZ_INTERP_BILINEAR);
241 } else if (scaled_width < scaled_height) { /* letter */
242 centre_vertically(adjusted_mode,
246 border = LVDS_BORDER_ENABLE;
247 if (mode->hdisplay != adjusted_mode->hdisplay) {
248 u32 bits = panel_fitter_scaling(mode->hdisplay, adjusted_mode->hdisplay);
249 pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
250 bits << PFIT_VERT_SCALE_SHIFT);
251 pfit_control |= (PFIT_ENABLE |
252 VERT_INTERP_BILINEAR |
253 HORIZ_INTERP_BILINEAR);
256 /* Aspects match, Let hw scale both directions */
257 pfit_control |= (PFIT_ENABLE |
258 VERT_AUTO_SCALE | HORIZ_AUTO_SCALE |
259 VERT_INTERP_BILINEAR |
260 HORIZ_INTERP_BILINEAR);
264 case DRM_MODE_SCALE_FULLSCREEN:
266 * Full scaling, even if it changes the aspect ratio.
267 * Fortunately this is all done for us in hw.
269 if (mode->vdisplay != adjusted_mode->vdisplay ||
270 mode->hdisplay != adjusted_mode->hdisplay) {
271 pfit_control |= PFIT_ENABLE;
272 if (INTEL_INFO(dev)->gen >= 4)
273 pfit_control |= PFIT_SCALING_AUTO;
275 pfit_control |= (VERT_AUTO_SCALE |
276 VERT_INTERP_BILINEAR |
278 HORIZ_INTERP_BILINEAR);
282 WARN(1, "bad panel fit mode: %d\n", fitting_mode);
286 /* 965+ wants fuzzy fitting */
287 /* FIXME: handle multiple panels by failing gracefully */
288 if (INTEL_INFO(dev)->gen >= 4)
289 pfit_control |= ((intel_crtc->pipe << PFIT_PIPE_SHIFT) |
293 if ((pfit_control & PFIT_ENABLE) == 0) {
298 /* Make sure pre-965 set dither correctly for 18bpp panels. */
299 if (INTEL_INFO(dev)->gen < 4 && pipe_config->pipe_bpp == 18)
300 pfit_control |= PANEL_8TO6_DITHER_ENABLE;
302 pipe_config->gmch_pfit.control = pfit_control;
303 pipe_config->gmch_pfit.pgm_ratios = pfit_pgm_ratios;
304 pipe_config->gmch_pfit.lvds_border_bits = border;
307 static int is_backlight_combination_mode(struct drm_device *dev)
309 struct drm_i915_private *dev_priv = dev->dev_private;
311 if (INTEL_INFO(dev)->gen >= 4)
312 return I915_READ(BLC_PWM_CTL2) & BLM_COMBINATION_MODE;
315 return I915_READ(BLC_PWM_CTL) & BLM_LEGACY_MODE;
320 /* XXX: query mode clock or hardware clock and program max PWM appropriately
323 static u32 i915_read_blc_pwm_ctl(struct drm_device *dev)
325 struct drm_i915_private *dev_priv = dev->dev_private;
328 WARN_ON_SMP(!spin_is_locked(&dev_priv->backlight.lock));
330 /* Restore the CTL value if it lost, e.g. GPU reset */
332 if (HAS_PCH_SPLIT(dev_priv->dev)) {
333 val = I915_READ(BLC_PWM_PCH_CTL2);
334 if (dev_priv->regfile.saveBLC_PWM_CTL2 == 0) {
335 dev_priv->regfile.saveBLC_PWM_CTL2 = val;
336 } else if (val == 0) {
337 val = dev_priv->regfile.saveBLC_PWM_CTL2;
338 I915_WRITE(BLC_PWM_PCH_CTL2, val);
341 val = I915_READ(BLC_PWM_CTL);
342 if (dev_priv->regfile.saveBLC_PWM_CTL == 0) {
343 dev_priv->regfile.saveBLC_PWM_CTL = val;
344 if (INTEL_INFO(dev)->gen >= 4)
345 dev_priv->regfile.saveBLC_PWM_CTL2 =
346 I915_READ(BLC_PWM_CTL2);
347 } else if (val == 0) {
348 val = dev_priv->regfile.saveBLC_PWM_CTL;
349 I915_WRITE(BLC_PWM_CTL, val);
350 if (INTEL_INFO(dev)->gen >= 4)
351 I915_WRITE(BLC_PWM_CTL2,
352 dev_priv->regfile.saveBLC_PWM_CTL2);
359 static u32 intel_panel_get_max_backlight(struct drm_device *dev)
363 max = i915_read_blc_pwm_ctl(dev);
365 if (HAS_PCH_SPLIT(dev)) {
368 if (INTEL_INFO(dev)->gen < 4)
373 if (is_backlight_combination_mode(dev))
377 DRM_DEBUG_DRIVER("max backlight PWM = %d\n", max);
382 static int i915_panel_invert_brightness;
383 MODULE_PARM_DESC(invert_brightness, "Invert backlight brightness "
384 "(-1 force normal, 0 machine defaults, 1 force inversion), please "
385 "report PCI device ID, subsystem vendor and subsystem device ID "
386 "to dri-devel@lists.freedesktop.org, if your machine needs it. "
387 "It will then be included in an upcoming module version.");
388 module_param_named(invert_brightness, i915_panel_invert_brightness, int, 0600);
389 static u32 intel_panel_compute_brightness(struct drm_device *dev, u32 val)
391 struct drm_i915_private *dev_priv = dev->dev_private;
393 if (i915_panel_invert_brightness < 0)
396 if (i915_panel_invert_brightness > 0 ||
397 dev_priv->quirks & QUIRK_INVERT_BRIGHTNESS) {
398 u32 max = intel_panel_get_max_backlight(dev);
406 static u32 intel_panel_get_backlight(struct drm_device *dev)
408 struct drm_i915_private *dev_priv = dev->dev_private;
412 spin_lock_irqsave(&dev_priv->backlight.lock, flags);
414 if (HAS_PCH_SPLIT(dev)) {
415 val = I915_READ(BLC_PWM_CPU_CTL) & BACKLIGHT_DUTY_CYCLE_MASK;
417 val = I915_READ(BLC_PWM_CTL) & BACKLIGHT_DUTY_CYCLE_MASK;
418 if (INTEL_INFO(dev)->gen < 4)
421 if (is_backlight_combination_mode(dev)) {
424 pci_read_config_byte(dev->pdev, PCI_LBPC, &lbpc);
429 val = intel_panel_compute_brightness(dev, val);
431 spin_unlock_irqrestore(&dev_priv->backlight.lock, flags);
433 DRM_DEBUG_DRIVER("get backlight PWM = %d\n", val);
437 static void intel_pch_panel_set_backlight(struct drm_device *dev, u32 level)
439 struct drm_i915_private *dev_priv = dev->dev_private;
440 u32 val = I915_READ(BLC_PWM_CPU_CTL) & ~BACKLIGHT_DUTY_CYCLE_MASK;
441 I915_WRITE(BLC_PWM_CPU_CTL, val | level);
444 static void intel_panel_actually_set_backlight(struct drm_device *dev, u32 level)
446 struct drm_i915_private *dev_priv = dev->dev_private;
449 DRM_DEBUG_DRIVER("set backlight PWM = %d\n", level);
450 level = intel_panel_compute_brightness(dev, level);
452 if (HAS_PCH_SPLIT(dev))
453 return intel_pch_panel_set_backlight(dev, level);
455 if (is_backlight_combination_mode(dev)) {
456 u32 max = intel_panel_get_max_backlight(dev);
459 /* we're screwed, but keep behaviour backwards compatible */
463 lbpc = level * 0xfe / max + 1;
465 pci_write_config_byte(dev->pdev, PCI_LBPC, lbpc);
468 tmp = I915_READ(BLC_PWM_CTL);
469 if (INTEL_INFO(dev)->gen < 4)
471 tmp &= ~BACKLIGHT_DUTY_CYCLE_MASK;
472 I915_WRITE(BLC_PWM_CTL, tmp | level);
475 /* set backlight brightness to level in range [0..max] */
476 void intel_panel_set_backlight(struct drm_device *dev, u32 level, u32 max)
478 struct drm_i915_private *dev_priv = dev->dev_private;
482 spin_lock_irqsave(&dev_priv->backlight.lock, flags);
484 freq = intel_panel_get_max_backlight(dev);
486 /* we are screwed, bail out */
490 /* scale to hardware, but be careful to not overflow */
492 level = level * freq / max;
494 level = freq / max * level;
496 dev_priv->backlight.level = level;
497 if (dev_priv->backlight.device)
498 dev_priv->backlight.device->props.brightness = level;
500 if (dev_priv->backlight.enabled)
501 intel_panel_actually_set_backlight(dev, level);
503 spin_unlock_irqrestore(&dev_priv->backlight.lock, flags);
506 void intel_panel_disable_backlight(struct drm_device *dev)
508 struct drm_i915_private *dev_priv = dev->dev_private;
512 * Do not disable backlight on the vgaswitcheroo path. When switching
513 * away from i915, the other client may depend on i915 to handle the
514 * backlight. This will leave the backlight on unnecessarily when
515 * another client is not activated.
517 if (dev->switch_power_state == DRM_SWITCH_POWER_CHANGING) {
518 DRM_DEBUG_DRIVER("Skipping backlight disable on vga switch\n");
522 spin_lock_irqsave(&dev_priv->backlight.lock, flags);
524 dev_priv->backlight.enabled = false;
525 intel_panel_actually_set_backlight(dev, 0);
527 if (INTEL_INFO(dev)->gen >= 4) {
530 reg = HAS_PCH_SPLIT(dev) ? BLC_PWM_CPU_CTL2 : BLC_PWM_CTL2;
532 I915_WRITE(reg, I915_READ(reg) & ~BLM_PWM_ENABLE);
534 if (HAS_PCH_SPLIT(dev)) {
535 tmp = I915_READ(BLC_PWM_PCH_CTL1);
536 tmp &= ~BLM_PCH_PWM_ENABLE;
537 I915_WRITE(BLC_PWM_PCH_CTL1, tmp);
541 spin_unlock_irqrestore(&dev_priv->backlight.lock, flags);
544 void intel_panel_enable_backlight(struct drm_device *dev,
547 struct drm_i915_private *dev_priv = dev->dev_private;
548 enum transcoder cpu_transcoder =
549 intel_pipe_to_cpu_transcoder(dev_priv, pipe);
552 spin_lock_irqsave(&dev_priv->backlight.lock, flags);
554 if (dev_priv->backlight.level == 0) {
555 dev_priv->backlight.level = intel_panel_get_max_backlight(dev);
556 if (dev_priv->backlight.device)
557 dev_priv->backlight.device->props.brightness =
558 dev_priv->backlight.level;
561 if (INTEL_INFO(dev)->gen >= 4) {
564 reg = HAS_PCH_SPLIT(dev) ? BLC_PWM_CPU_CTL2 : BLC_PWM_CTL2;
567 tmp = I915_READ(reg);
569 /* Note that this can also get called through dpms changes. And
570 * we don't track the backlight dpms state, hence check whether
571 * we have to do anything first. */
572 if (tmp & BLM_PWM_ENABLE)
575 if (INTEL_INFO(dev)->num_pipes == 3)
576 tmp &= ~BLM_PIPE_SELECT_IVB;
578 tmp &= ~BLM_PIPE_SELECT;
580 if (cpu_transcoder == TRANSCODER_EDP)
581 tmp |= BLM_TRANSCODER_EDP;
583 tmp |= BLM_PIPE(cpu_transcoder);
584 tmp &= ~BLM_PWM_ENABLE;
586 I915_WRITE(reg, tmp);
588 I915_WRITE(reg, tmp | BLM_PWM_ENABLE);
590 if (HAS_PCH_SPLIT(dev) &&
591 !(dev_priv->quirks & QUIRK_NO_PCH_PWM_ENABLE)) {
592 tmp = I915_READ(BLC_PWM_PCH_CTL1);
593 tmp |= BLM_PCH_PWM_ENABLE;
594 tmp &= ~BLM_PCH_OVERRIDE_ENABLE;
595 I915_WRITE(BLC_PWM_PCH_CTL1, tmp);
600 /* Call below after setting BLC_PWM_CPU_CTL2 and BLC_PWM_PCH_CTL1.
601 * BLC_PWM_CPU_CTL may be cleared to zero automatically when these
604 dev_priv->backlight.enabled = true;
605 intel_panel_actually_set_backlight(dev, dev_priv->backlight.level);
607 spin_unlock_irqrestore(&dev_priv->backlight.lock, flags);
610 static void intel_panel_init_backlight(struct drm_device *dev)
612 struct drm_i915_private *dev_priv = dev->dev_private;
614 dev_priv->backlight.level = intel_panel_get_backlight(dev);
615 dev_priv->backlight.enabled = dev_priv->backlight.level != 0;
618 enum drm_connector_status
619 intel_panel_detect(struct drm_device *dev)
621 struct drm_i915_private *dev_priv = dev->dev_private;
623 /* Assume that the BIOS does not lie through the OpRegion... */
624 if (!i915_panel_ignore_lid && dev_priv->opregion.lid_state) {
625 return ioread32(dev_priv->opregion.lid_state) & 0x1 ?
626 connector_status_connected :
627 connector_status_disconnected;
630 switch (i915_panel_ignore_lid) {
632 return connector_status_connected;
634 return connector_status_disconnected;
636 return connector_status_unknown;
640 #ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
641 static int intel_panel_update_status(struct backlight_device *bd)
643 struct drm_device *dev = bl_get_data(bd);
644 intel_panel_set_backlight(dev, bd->props.brightness,
645 bd->props.max_brightness);
649 static int intel_panel_get_brightness(struct backlight_device *bd)
651 struct drm_device *dev = bl_get_data(bd);
652 return intel_panel_get_backlight(dev);
655 static const struct backlight_ops intel_panel_bl_ops = {
656 .update_status = intel_panel_update_status,
657 .get_brightness = intel_panel_get_brightness,
660 int intel_panel_setup_backlight(struct drm_connector *connector)
662 struct drm_device *dev = connector->dev;
663 struct drm_i915_private *dev_priv = dev->dev_private;
664 struct backlight_properties props;
667 intel_panel_init_backlight(dev);
669 if (WARN_ON(dev_priv->backlight.device))
672 memset(&props, 0, sizeof(props));
673 props.type = BACKLIGHT_RAW;
674 props.brightness = dev_priv->backlight.level;
676 spin_lock_irqsave(&dev_priv->backlight.lock, flags);
677 props.max_brightness = intel_panel_get_max_backlight(dev);
678 spin_unlock_irqrestore(&dev_priv->backlight.lock, flags);
680 if (props.max_brightness == 0) {
681 DRM_DEBUG_DRIVER("Failed to get maximum backlight value\n");
684 dev_priv->backlight.device =
685 backlight_device_register("intel_backlight",
686 &connector->kdev, dev,
687 &intel_panel_bl_ops, &props);
689 if (IS_ERR(dev_priv->backlight.device)) {
690 DRM_ERROR("Failed to register backlight: %ld\n",
691 PTR_ERR(dev_priv->backlight.device));
692 dev_priv->backlight.device = NULL;
698 void intel_panel_destroy_backlight(struct drm_device *dev)
700 struct drm_i915_private *dev_priv = dev->dev_private;
701 if (dev_priv->backlight.device) {
702 backlight_device_unregister(dev_priv->backlight.device);
703 dev_priv->backlight.device = NULL;
707 int intel_panel_setup_backlight(struct drm_connector *connector)
709 intel_panel_init_backlight(connector->dev);
713 void intel_panel_destroy_backlight(struct drm_device *dev)
719 int intel_panel_init(struct intel_panel *panel,
720 struct drm_display_mode *fixed_mode)
722 panel->fixed_mode = fixed_mode;
727 void intel_panel_fini(struct intel_panel *panel)
729 struct intel_connector *intel_connector =
730 container_of(panel, struct intel_connector, panel);
732 if (panel->fixed_mode)
733 drm_mode_destroy(intel_connector->base.dev, panel->fixed_mode);