2 * Copyright © 2008 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
24 * Keith Packard <keithp@keithp.com>
28 #include <linux/i2c.h>
29 #include <linux/slab.h>
33 #include "drm_crtc_helper.h"
34 #include "intel_drv.h"
37 #include "drm_dp_helper.h"
40 #define DP_LINK_STATUS_SIZE 6
41 #define DP_LINK_CHECK_TIMEOUT (10 * 1000)
43 #define DP_LINK_CONFIGURATION_SIZE 9
46 struct intel_encoder base;
49 uint8_t link_configuration[DP_LINK_CONFIGURATION_SIZE];
57 struct i2c_adapter adapter;
58 struct i2c_algo_dp_aux_data algo;
61 uint8_t link_status[DP_LINK_STATUS_SIZE];
62 int panel_power_up_delay;
63 int panel_power_down_delay;
64 int panel_power_cycle_delay;
65 int backlight_on_delay;
66 int backlight_off_delay;
67 struct drm_display_mode *panel_fixed_mode; /* for eDP */
71 * is_edp - is the given port attached to an eDP panel (either CPU or PCH)
72 * @intel_dp: DP struct
74 * If a CPU or PCH DP output is attached to an eDP panel, this function
75 * will return true, and false otherwise.
77 static bool is_edp(struct intel_dp *intel_dp)
79 return intel_dp->base.type == INTEL_OUTPUT_EDP;
83 * is_pch_edp - is the port on the PCH and attached to an eDP panel?
84 * @intel_dp: DP struct
86 * Returns true if the given DP struct corresponds to a PCH DP port attached
87 * to an eDP panel, false otherwise. Helpful for determining whether we
88 * may need FDI resources for a given DP output or not.
90 static bool is_pch_edp(struct intel_dp *intel_dp)
92 return intel_dp->is_pch_edp;
95 static struct intel_dp *enc_to_intel_dp(struct drm_encoder *encoder)
97 return container_of(encoder, struct intel_dp, base.base);
100 static struct intel_dp *intel_attached_dp(struct drm_connector *connector)
102 return container_of(intel_attached_encoder(connector),
103 struct intel_dp, base);
107 * intel_encoder_is_pch_edp - is the given encoder a PCH attached eDP?
108 * @encoder: DRM encoder
110 * Return true if @encoder corresponds to a PCH attached eDP panel. Needed
111 * by intel_display.c.
113 bool intel_encoder_is_pch_edp(struct drm_encoder *encoder)
115 struct intel_dp *intel_dp;
120 intel_dp = enc_to_intel_dp(encoder);
122 return is_pch_edp(intel_dp);
125 static void intel_dp_start_link_train(struct intel_dp *intel_dp);
126 static void intel_dp_complete_link_train(struct intel_dp *intel_dp);
127 static void intel_dp_link_down(struct intel_dp *intel_dp);
130 intel_edp_link_config (struct intel_encoder *intel_encoder,
131 int *lane_num, int *link_bw)
133 struct intel_dp *intel_dp = container_of(intel_encoder, struct intel_dp, base);
135 *lane_num = intel_dp->lane_count;
136 if (intel_dp->link_bw == DP_LINK_BW_1_62)
138 else if (intel_dp->link_bw == DP_LINK_BW_2_7)
143 intel_dp_max_lane_count(struct intel_dp *intel_dp)
145 int max_lane_count = 4;
147 if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11) {
148 max_lane_count = intel_dp->dpcd[DP_MAX_LANE_COUNT] & 0x1f;
149 switch (max_lane_count) {
150 case 1: case 2: case 4:
156 return max_lane_count;
160 intel_dp_max_link_bw(struct intel_dp *intel_dp)
162 int max_link_bw = intel_dp->dpcd[DP_MAX_LINK_RATE];
164 switch (max_link_bw) {
165 case DP_LINK_BW_1_62:
169 max_link_bw = DP_LINK_BW_1_62;
176 intel_dp_link_clock(uint8_t link_bw)
178 if (link_bw == DP_LINK_BW_2_7)
184 /* I think this is a fiction */
186 intel_dp_link_required(struct drm_device *dev, struct intel_dp *intel_dp, int pixel_clock)
188 struct drm_crtc *crtc = intel_dp->base.base.crtc;
189 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
193 bpp = intel_crtc->bpp;
195 return (pixel_clock * bpp + 7) / 8;
199 intel_dp_max_data_rate(int max_link_clock, int max_lanes)
201 return (max_link_clock * max_lanes * 8) / 10;
205 intel_dp_mode_valid(struct drm_connector *connector,
206 struct drm_display_mode *mode)
208 struct intel_dp *intel_dp = intel_attached_dp(connector);
209 int max_link_clock = intel_dp_link_clock(intel_dp_max_link_bw(intel_dp));
210 int max_lanes = intel_dp_max_lane_count(intel_dp);
212 if (is_edp(intel_dp) && intel_dp->panel_fixed_mode) {
213 if (mode->hdisplay > intel_dp->panel_fixed_mode->hdisplay)
216 if (mode->vdisplay > intel_dp->panel_fixed_mode->vdisplay)
220 /* only refuse the mode on non eDP since we have seen some weird eDP panels
221 which are outside spec tolerances but somehow work by magic */
222 if (!is_edp(intel_dp) &&
223 (intel_dp_link_required(connector->dev, intel_dp, mode->clock)
224 > intel_dp_max_data_rate(max_link_clock, max_lanes)))
225 return MODE_CLOCK_HIGH;
227 if (mode->clock < 10000)
228 return MODE_CLOCK_LOW;
234 pack_aux(uint8_t *src, int src_bytes)
241 for (i = 0; i < src_bytes; i++)
242 v |= ((uint32_t) src[i]) << ((3-i) * 8);
247 unpack_aux(uint32_t src, uint8_t *dst, int dst_bytes)
252 for (i = 0; i < dst_bytes; i++)
253 dst[i] = src >> ((3-i) * 8);
256 /* hrawclock is 1/4 the FSB frequency */
258 intel_hrawclk(struct drm_device *dev)
260 struct drm_i915_private *dev_priv = dev->dev_private;
263 clkcfg = I915_READ(CLKCFG);
264 switch (clkcfg & CLKCFG_FSB_MASK) {
273 case CLKCFG_FSB_1067:
275 case CLKCFG_FSB_1333:
277 /* these two are just a guess; one of them might be right */
278 case CLKCFG_FSB_1600:
279 case CLKCFG_FSB_1600_ALT:
287 intel_dp_check_edp(struct intel_dp *intel_dp)
289 struct drm_device *dev = intel_dp->base.base.dev;
290 struct drm_i915_private *dev_priv = dev->dev_private;
291 u32 pp_status, pp_control;
292 if (!is_edp(intel_dp))
294 pp_status = I915_READ(PCH_PP_STATUS);
295 pp_control = I915_READ(PCH_PP_CONTROL);
296 if ((pp_status & PP_ON) == 0 && (pp_control & EDP_FORCE_VDD) == 0) {
297 WARN(1, "eDP powered off while attempting aux channel communication.\n");
298 DRM_DEBUG_KMS("Status 0x%08x Control 0x%08x\n",
300 I915_READ(PCH_PP_CONTROL));
305 intel_dp_aux_ch(struct intel_dp *intel_dp,
306 uint8_t *send, int send_bytes,
307 uint8_t *recv, int recv_size)
309 uint32_t output_reg = intel_dp->output_reg;
310 struct drm_device *dev = intel_dp->base.base.dev;
311 struct drm_i915_private *dev_priv = dev->dev_private;
312 uint32_t ch_ctl = output_reg + 0x10;
313 uint32_t ch_data = ch_ctl + 4;
317 uint32_t aux_clock_divider;
320 intel_dp_check_edp(intel_dp);
321 /* The clock divider is based off the hrawclk,
322 * and would like to run at 2MHz. So, take the
323 * hrawclk value and divide by 2 and use that
325 * Note that PCH attached eDP panels should use a 125MHz input
328 if (is_edp(intel_dp) && !is_pch_edp(intel_dp)) {
330 aux_clock_divider = 200; /* SNB eDP input clock at 400Mhz */
332 aux_clock_divider = 225; /* eDP input clock at 450Mhz */
333 } else if (HAS_PCH_SPLIT(dev))
334 aux_clock_divider = 62; /* IRL input clock fixed at 125Mhz */
336 aux_clock_divider = intel_hrawclk(dev) / 2;
343 /* Try to wait for any previous AUX channel activity */
344 for (try = 0; try < 3; try++) {
345 status = I915_READ(ch_ctl);
346 if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
352 WARN(1, "dp_aux_ch not started status 0x%08x\n",
357 /* Must try at least 3 times according to DP spec */
358 for (try = 0; try < 5; try++) {
359 /* Load the send data into the aux channel data registers */
360 for (i = 0; i < send_bytes; i += 4)
361 I915_WRITE(ch_data + i,
362 pack_aux(send + i, send_bytes - i));
364 /* Send the command and wait for it to complete */
366 DP_AUX_CH_CTL_SEND_BUSY |
367 DP_AUX_CH_CTL_TIME_OUT_400us |
368 (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
369 (precharge << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
370 (aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT) |
372 DP_AUX_CH_CTL_TIME_OUT_ERROR |
373 DP_AUX_CH_CTL_RECEIVE_ERROR);
375 status = I915_READ(ch_ctl);
376 if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
381 /* Clear done status and any errors */
385 DP_AUX_CH_CTL_TIME_OUT_ERROR |
386 DP_AUX_CH_CTL_RECEIVE_ERROR);
387 if (status & DP_AUX_CH_CTL_DONE)
391 if ((status & DP_AUX_CH_CTL_DONE) == 0) {
392 DRM_ERROR("dp_aux_ch not done status 0x%08x\n", status);
396 /* Check for timeout or receive error.
397 * Timeouts occur when the sink is not connected
399 if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
400 DRM_ERROR("dp_aux_ch receive error status 0x%08x\n", status);
404 /* Timeouts occur when the device isn't connected, so they're
405 * "normal" -- don't fill the kernel log with these */
406 if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
407 DRM_DEBUG_KMS("dp_aux_ch timeout status 0x%08x\n", status);
411 /* Unload any bytes sent back from the other side */
412 recv_bytes = ((status & DP_AUX_CH_CTL_MESSAGE_SIZE_MASK) >>
413 DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT);
414 if (recv_bytes > recv_size)
415 recv_bytes = recv_size;
417 for (i = 0; i < recv_bytes; i += 4)
418 unpack_aux(I915_READ(ch_data + i),
419 recv + i, recv_bytes - i);
424 /* Write data to the aux channel in native mode */
426 intel_dp_aux_native_write(struct intel_dp *intel_dp,
427 uint16_t address, uint8_t *send, int send_bytes)
434 intel_dp_check_edp(intel_dp);
437 msg[0] = AUX_NATIVE_WRITE << 4;
438 msg[1] = address >> 8;
439 msg[2] = address & 0xff;
440 msg[3] = send_bytes - 1;
441 memcpy(&msg[4], send, send_bytes);
442 msg_bytes = send_bytes + 4;
444 ret = intel_dp_aux_ch(intel_dp, msg, msg_bytes, &ack, 1);
447 if ((ack & AUX_NATIVE_REPLY_MASK) == AUX_NATIVE_REPLY_ACK)
449 else if ((ack & AUX_NATIVE_REPLY_MASK) == AUX_NATIVE_REPLY_DEFER)
457 /* Write a single byte to the aux channel in native mode */
459 intel_dp_aux_native_write_1(struct intel_dp *intel_dp,
460 uint16_t address, uint8_t byte)
462 return intel_dp_aux_native_write(intel_dp, address, &byte, 1);
465 /* read bytes from a native aux channel */
467 intel_dp_aux_native_read(struct intel_dp *intel_dp,
468 uint16_t address, uint8_t *recv, int recv_bytes)
477 intel_dp_check_edp(intel_dp);
478 msg[0] = AUX_NATIVE_READ << 4;
479 msg[1] = address >> 8;
480 msg[2] = address & 0xff;
481 msg[3] = recv_bytes - 1;
484 reply_bytes = recv_bytes + 1;
487 ret = intel_dp_aux_ch(intel_dp, msg, msg_bytes,
494 if ((ack & AUX_NATIVE_REPLY_MASK) == AUX_NATIVE_REPLY_ACK) {
495 memcpy(recv, reply + 1, ret - 1);
498 else if ((ack & AUX_NATIVE_REPLY_MASK) == AUX_NATIVE_REPLY_DEFER)
506 intel_dp_i2c_aux_ch(struct i2c_adapter *adapter, int mode,
507 uint8_t write_byte, uint8_t *read_byte)
509 struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
510 struct intel_dp *intel_dp = container_of(adapter,
513 uint16_t address = algo_data->address;
521 intel_dp_check_edp(intel_dp);
522 /* Set up the command byte */
523 if (mode & MODE_I2C_READ)
524 msg[0] = AUX_I2C_READ << 4;
526 msg[0] = AUX_I2C_WRITE << 4;
528 if (!(mode & MODE_I2C_STOP))
529 msg[0] |= AUX_I2C_MOT << 4;
531 msg[1] = address >> 8;
552 for (retry = 0; retry < 5; retry++) {
553 ret = intel_dp_aux_ch(intel_dp,
557 DRM_DEBUG_KMS("aux_ch failed %d\n", ret);
561 switch (reply[0] & AUX_NATIVE_REPLY_MASK) {
562 case AUX_NATIVE_REPLY_ACK:
563 /* I2C-over-AUX Reply field is only valid
564 * when paired with AUX ACK.
567 case AUX_NATIVE_REPLY_NACK:
568 DRM_DEBUG_KMS("aux_ch native nack\n");
570 case AUX_NATIVE_REPLY_DEFER:
574 DRM_ERROR("aux_ch invalid native reply 0x%02x\n",
579 switch (reply[0] & AUX_I2C_REPLY_MASK) {
580 case AUX_I2C_REPLY_ACK:
581 if (mode == MODE_I2C_READ) {
582 *read_byte = reply[1];
584 return reply_bytes - 1;
585 case AUX_I2C_REPLY_NACK:
586 DRM_DEBUG_KMS("aux_i2c nack\n");
588 case AUX_I2C_REPLY_DEFER:
589 DRM_DEBUG_KMS("aux_i2c defer\n");
593 DRM_ERROR("aux_i2c invalid reply 0x%02x\n", reply[0]);
598 DRM_ERROR("too many retries, giving up\n");
602 static void ironlake_edp_panel_vdd_on(struct intel_dp *intel_dp);
603 static void ironlake_edp_panel_vdd_off(struct intel_dp *intel_dp);
606 intel_dp_i2c_init(struct intel_dp *intel_dp,
607 struct intel_connector *intel_connector, const char *name)
611 DRM_DEBUG_KMS("i2c_init %s\n", name);
612 intel_dp->algo.running = false;
613 intel_dp->algo.address = 0;
614 intel_dp->algo.aux_ch = intel_dp_i2c_aux_ch;
616 memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter));
617 intel_dp->adapter.owner = THIS_MODULE;
618 intel_dp->adapter.class = I2C_CLASS_DDC;
619 strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1);
620 intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0';
621 intel_dp->adapter.algo_data = &intel_dp->algo;
622 intel_dp->adapter.dev.parent = &intel_connector->base.kdev;
624 ironlake_edp_panel_vdd_on(intel_dp);
625 ret = i2c_dp_aux_add_bus(&intel_dp->adapter);
626 ironlake_edp_panel_vdd_off(intel_dp);
631 intel_dp_mode_fixup(struct drm_encoder *encoder, struct drm_display_mode *mode,
632 struct drm_display_mode *adjusted_mode)
634 struct drm_device *dev = encoder->dev;
635 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
636 int lane_count, clock;
637 int max_lane_count = intel_dp_max_lane_count(intel_dp);
638 int max_clock = intel_dp_max_link_bw(intel_dp) == DP_LINK_BW_2_7 ? 1 : 0;
639 static int bws[2] = { DP_LINK_BW_1_62, DP_LINK_BW_2_7 };
641 if (is_edp(intel_dp) && intel_dp->panel_fixed_mode) {
642 intel_fixed_panel_mode(intel_dp->panel_fixed_mode, adjusted_mode);
643 intel_pch_panel_fitting(dev, DRM_MODE_SCALE_FULLSCREEN,
644 mode, adjusted_mode);
646 * the mode->clock is used to calculate the Data&Link M/N
647 * of the pipe. For the eDP the fixed clock should be used.
649 mode->clock = intel_dp->panel_fixed_mode->clock;
652 for (lane_count = 1; lane_count <= max_lane_count; lane_count <<= 1) {
653 for (clock = 0; clock <= max_clock; clock++) {
654 int link_avail = intel_dp_max_data_rate(intel_dp_link_clock(bws[clock]), lane_count);
656 if (intel_dp_link_required(encoder->dev, intel_dp, mode->clock)
658 intel_dp->link_bw = bws[clock];
659 intel_dp->lane_count = lane_count;
660 adjusted_mode->clock = intel_dp_link_clock(intel_dp->link_bw);
661 DRM_DEBUG_KMS("Display port link bw %02x lane "
662 "count %d clock %d\n",
663 intel_dp->link_bw, intel_dp->lane_count,
664 adjusted_mode->clock);
670 if (is_edp(intel_dp)) {
671 /* okay we failed just pick the highest */
672 intel_dp->lane_count = max_lane_count;
673 intel_dp->link_bw = bws[max_clock];
674 adjusted_mode->clock = intel_dp_link_clock(intel_dp->link_bw);
675 DRM_DEBUG_KMS("Force picking display port link bw %02x lane "
676 "count %d clock %d\n",
677 intel_dp->link_bw, intel_dp->lane_count,
678 adjusted_mode->clock);
686 struct intel_dp_m_n {
695 intel_reduce_ratio(uint32_t *num, uint32_t *den)
697 while (*num > 0xffffff || *den > 0xffffff) {
704 intel_dp_compute_m_n(int bpp,
708 struct intel_dp_m_n *m_n)
711 m_n->gmch_m = (pixel_clock * bpp) >> 3;
712 m_n->gmch_n = link_clock * nlanes;
713 intel_reduce_ratio(&m_n->gmch_m, &m_n->gmch_n);
714 m_n->link_m = pixel_clock;
715 m_n->link_n = link_clock;
716 intel_reduce_ratio(&m_n->link_m, &m_n->link_n);
720 intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode,
721 struct drm_display_mode *adjusted_mode)
723 struct drm_device *dev = crtc->dev;
724 struct drm_mode_config *mode_config = &dev->mode_config;
725 struct drm_encoder *encoder;
726 struct drm_i915_private *dev_priv = dev->dev_private;
727 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
729 struct intel_dp_m_n m_n;
730 int pipe = intel_crtc->pipe;
733 * Find the lane count in the intel_encoder private
735 list_for_each_entry(encoder, &mode_config->encoder_list, head) {
736 struct intel_dp *intel_dp;
738 if (encoder->crtc != crtc)
741 intel_dp = enc_to_intel_dp(encoder);
742 if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT) {
743 lane_count = intel_dp->lane_count;
745 } else if (is_edp(intel_dp)) {
746 lane_count = dev_priv->edp.lanes;
752 * Compute the GMCH and Link ratios. The '3' here is
753 * the number of bytes_per_pixel post-LUT, which we always
754 * set up for 8-bits of R/G/B, or 3 bytes total.
756 intel_dp_compute_m_n(intel_crtc->bpp, lane_count,
757 mode->clock, adjusted_mode->clock, &m_n);
759 if (HAS_PCH_SPLIT(dev)) {
760 I915_WRITE(TRANSDATA_M1(pipe),
761 ((m_n.tu - 1) << PIPE_GMCH_DATA_M_TU_SIZE_SHIFT) |
763 I915_WRITE(TRANSDATA_N1(pipe), m_n.gmch_n);
764 I915_WRITE(TRANSDPLINK_M1(pipe), m_n.link_m);
765 I915_WRITE(TRANSDPLINK_N1(pipe), m_n.link_n);
767 I915_WRITE(PIPE_GMCH_DATA_M(pipe),
768 ((m_n.tu - 1) << PIPE_GMCH_DATA_M_TU_SIZE_SHIFT) |
770 I915_WRITE(PIPE_GMCH_DATA_N(pipe), m_n.gmch_n);
771 I915_WRITE(PIPE_DP_LINK_M(pipe), m_n.link_m);
772 I915_WRITE(PIPE_DP_LINK_N(pipe), m_n.link_n);
776 static void ironlake_edp_pll_on(struct drm_encoder *encoder);
777 static void ironlake_edp_pll_off(struct drm_encoder *encoder);
780 intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
781 struct drm_display_mode *adjusted_mode)
783 struct drm_device *dev = encoder->dev;
784 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
785 struct drm_crtc *crtc = intel_dp->base.base.crtc;
786 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
788 /* Turn on the eDP PLL if needed */
789 if (is_edp(intel_dp)) {
790 if (!is_pch_edp(intel_dp))
791 ironlake_edp_pll_on(encoder);
793 ironlake_edp_pll_off(encoder);
796 intel_dp->DP = DP_VOLTAGE_0_4 | DP_PRE_EMPHASIS_0;
797 intel_dp->DP |= intel_dp->color_range;
799 if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
800 intel_dp->DP |= DP_SYNC_HS_HIGH;
801 if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
802 intel_dp->DP |= DP_SYNC_VS_HIGH;
804 if (HAS_PCH_CPT(dev) && !is_edp(intel_dp))
805 intel_dp->DP |= DP_LINK_TRAIN_OFF_CPT;
807 intel_dp->DP |= DP_LINK_TRAIN_OFF;
809 switch (intel_dp->lane_count) {
811 intel_dp->DP |= DP_PORT_WIDTH_1;
814 intel_dp->DP |= DP_PORT_WIDTH_2;
817 intel_dp->DP |= DP_PORT_WIDTH_4;
820 if (intel_dp->has_audio)
821 intel_dp->DP |= DP_AUDIO_OUTPUT_ENABLE;
823 memset(intel_dp->link_configuration, 0, DP_LINK_CONFIGURATION_SIZE);
824 intel_dp->link_configuration[0] = intel_dp->link_bw;
825 intel_dp->link_configuration[1] = intel_dp->lane_count;
826 intel_dp->link_configuration[8] = DP_SET_ANSI_8B10B;
829 * Check for DPCD version > 1.1 and enhanced framing support
831 if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11 &&
832 (intel_dp->dpcd[DP_MAX_LANE_COUNT] & DP_ENHANCED_FRAME_CAP)) {
833 intel_dp->link_configuration[1] |= DP_LANE_COUNT_ENHANCED_FRAME_EN;
834 intel_dp->DP |= DP_ENHANCED_FRAMING;
837 /* CPT DP's pipe select is decided in TRANS_DP_CTL */
838 if (intel_crtc->pipe == 1 && !HAS_PCH_CPT(dev))
839 intel_dp->DP |= DP_PIPEB_SELECT;
841 if (is_edp(intel_dp) && !is_pch_edp(intel_dp)) {
842 /* don't miss out required setting for eDP */
843 intel_dp->DP |= DP_PLL_ENABLE;
844 if (adjusted_mode->clock < 200000)
845 intel_dp->DP |= DP_PLL_FREQ_160MHZ;
847 intel_dp->DP |= DP_PLL_FREQ_270MHZ;
851 static void ironlake_edp_panel_vdd_on(struct intel_dp *intel_dp)
853 struct drm_device *dev = intel_dp->base.base.dev;
854 struct drm_i915_private *dev_priv = dev->dev_private;
857 if (!is_edp(intel_dp))
859 DRM_DEBUG_KMS("Turn eDP VDD on\n");
861 * If the panel wasn't on, make sure there's not a currently
862 * active PP sequence before enabling AUX VDD.
864 pp_status = I915_READ(PCH_PP_STATUS);
866 pp = I915_READ(PCH_PP_CONTROL);
867 pp &= ~PANEL_UNLOCK_MASK;
868 pp |= PANEL_UNLOCK_REGS;
870 I915_WRITE(PCH_PP_CONTROL, pp);
871 POSTING_READ(PCH_PP_CONTROL);
872 DRM_DEBUG_KMS("PCH_PP_STATUS: 0x%08x PCH_PP_CONTROL: 0x%08x\n",
873 I915_READ(PCH_PP_STATUS), I915_READ(PCH_PP_CONTROL));
874 if (!(pp_status & PP_ON)) {
875 msleep(intel_dp->panel_power_up_delay);
876 DRM_DEBUG_KMS("eDP VDD was not on\n");
880 static void ironlake_edp_panel_vdd_off(struct intel_dp *intel_dp)
882 struct drm_device *dev = intel_dp->base.base.dev;
883 struct drm_i915_private *dev_priv = dev->dev_private;
886 if (!is_edp(intel_dp))
888 DRM_DEBUG_KMS("Turn eDP VDD off\n");
889 pp = I915_READ(PCH_PP_CONTROL);
890 pp &= ~PANEL_UNLOCK_MASK;
891 pp |= PANEL_UNLOCK_REGS;
892 pp &= ~EDP_FORCE_VDD;
893 I915_WRITE(PCH_PP_CONTROL, pp);
894 POSTING_READ(PCH_PP_CONTROL);
896 /* Make sure sequencer is idle before allowing subsequent activity */
897 DRM_DEBUG_KMS("PCH_PP_STATUS: 0x%08x PCH_PP_CONTROL: 0x%08x\n",
898 I915_READ(PCH_PP_STATUS), I915_READ(PCH_PP_CONTROL));
899 msleep(intel_dp->panel_power_cycle_delay);
902 /* Returns true if the panel was already on when called */
903 static void ironlake_edp_panel_on (struct intel_dp *intel_dp)
905 struct drm_device *dev = intel_dp->base.base.dev;
906 struct drm_i915_private *dev_priv = dev->dev_private;
907 u32 pp, idle_on_mask = PP_ON | PP_SEQUENCE_STATE_ON_IDLE;
909 if (!is_edp(intel_dp))
911 if (I915_READ(PCH_PP_STATUS) & PP_ON)
914 pp = I915_READ(PCH_PP_CONTROL);
915 pp &= ~PANEL_UNLOCK_MASK;
916 pp |= PANEL_UNLOCK_REGS;
918 /* ILK workaround: disable reset around power sequence */
919 pp &= ~PANEL_POWER_RESET;
920 I915_WRITE(PCH_PP_CONTROL, pp);
921 POSTING_READ(PCH_PP_CONTROL);
923 pp |= POWER_TARGET_ON;
924 I915_WRITE(PCH_PP_CONTROL, pp);
925 POSTING_READ(PCH_PP_CONTROL);
927 if (wait_for((I915_READ(PCH_PP_STATUS) & idle_on_mask) == idle_on_mask,
929 DRM_ERROR("panel on wait timed out: 0x%08x\n",
930 I915_READ(PCH_PP_STATUS));
932 pp |= PANEL_POWER_RESET; /* restore panel reset bit */
933 I915_WRITE(PCH_PP_CONTROL, pp);
934 POSTING_READ(PCH_PP_CONTROL);
937 static void ironlake_edp_panel_off(struct drm_encoder *encoder)
939 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
940 struct drm_device *dev = encoder->dev;
941 struct drm_i915_private *dev_priv = dev->dev_private;
942 u32 pp, idle_off_mask = PP_ON | PP_SEQUENCE_MASK |
943 PP_CYCLE_DELAY_ACTIVE | PP_SEQUENCE_STATE_MASK;
945 if (!is_edp(intel_dp))
947 pp = I915_READ(PCH_PP_CONTROL);
948 pp &= ~PANEL_UNLOCK_MASK;
949 pp |= PANEL_UNLOCK_REGS;
951 /* ILK workaround: disable reset around power sequence */
952 pp &= ~PANEL_POWER_RESET;
953 I915_WRITE(PCH_PP_CONTROL, pp);
954 POSTING_READ(PCH_PP_CONTROL);
956 pp &= ~POWER_TARGET_ON;
957 I915_WRITE(PCH_PP_CONTROL, pp);
958 POSTING_READ(PCH_PP_CONTROL);
959 msleep(intel_dp->panel_power_cycle_delay);
961 if (wait_for((I915_READ(PCH_PP_STATUS) & idle_off_mask) == 0, 5000))
962 DRM_ERROR("panel off wait timed out: 0x%08x\n",
963 I915_READ(PCH_PP_STATUS));
965 pp |= PANEL_POWER_RESET; /* restore panel reset bit */
966 I915_WRITE(PCH_PP_CONTROL, pp);
967 POSTING_READ(PCH_PP_CONTROL);
970 static void ironlake_edp_backlight_on (struct intel_dp *intel_dp)
972 struct drm_device *dev = intel_dp->base.base.dev;
973 struct drm_i915_private *dev_priv = dev->dev_private;
976 if (!is_edp(intel_dp))
981 * If we enable the backlight right away following a panel power
982 * on, we may see slight flicker as the panel syncs with the eDP
983 * link. So delay a bit to make sure the image is solid before
984 * allowing it to appear.
986 msleep(intel_dp->backlight_on_delay);
987 pp = I915_READ(PCH_PP_CONTROL);
988 pp &= ~PANEL_UNLOCK_MASK;
989 pp |= PANEL_UNLOCK_REGS;
990 pp |= EDP_BLC_ENABLE;
991 I915_WRITE(PCH_PP_CONTROL, pp);
992 POSTING_READ(PCH_PP_CONTROL);
995 static void ironlake_edp_backlight_off (struct intel_dp *intel_dp)
997 struct drm_device *dev = intel_dp->base.base.dev;
998 struct drm_i915_private *dev_priv = dev->dev_private;
1001 if (!is_edp(intel_dp))
1004 DRM_DEBUG_KMS("\n");
1005 pp = I915_READ(PCH_PP_CONTROL);
1006 pp &= ~PANEL_UNLOCK_MASK;
1007 pp |= PANEL_UNLOCK_REGS;
1008 pp &= ~EDP_BLC_ENABLE;
1009 I915_WRITE(PCH_PP_CONTROL, pp);
1010 POSTING_READ(PCH_PP_CONTROL);
1011 msleep(intel_dp->backlight_off_delay);
1014 static void ironlake_edp_pll_on(struct drm_encoder *encoder)
1016 struct drm_device *dev = encoder->dev;
1017 struct drm_i915_private *dev_priv = dev->dev_private;
1020 DRM_DEBUG_KMS("\n");
1021 dpa_ctl = I915_READ(DP_A);
1022 dpa_ctl |= DP_PLL_ENABLE;
1023 I915_WRITE(DP_A, dpa_ctl);
1028 static void ironlake_edp_pll_off(struct drm_encoder *encoder)
1030 struct drm_device *dev = encoder->dev;
1031 struct drm_i915_private *dev_priv = dev->dev_private;
1034 dpa_ctl = I915_READ(DP_A);
1035 dpa_ctl &= ~DP_PLL_ENABLE;
1036 I915_WRITE(DP_A, dpa_ctl);
1041 /* If the sink supports it, try to set the power state appropriately */
1042 static void intel_dp_sink_dpms(struct intel_dp *intel_dp, int mode)
1046 /* Should have a valid DPCD by this point */
1047 if (intel_dp->dpcd[DP_DPCD_REV] < 0x11)
1050 if (mode != DRM_MODE_DPMS_ON) {
1051 ret = intel_dp_aux_native_write_1(intel_dp, DP_SET_POWER,
1054 DRM_DEBUG_DRIVER("failed to write sink power state\n");
1057 * When turning on, we need to retry for 1ms to give the sink
1060 for (i = 0; i < 3; i++) {
1061 ret = intel_dp_aux_native_write_1(intel_dp,
1071 static void intel_dp_prepare(struct drm_encoder *encoder)
1073 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
1075 /* Wake up the sink first */
1076 ironlake_edp_panel_vdd_on(intel_dp);
1077 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
1078 ironlake_edp_panel_vdd_off(intel_dp);
1080 /* Make sure the panel is off before trying to
1083 ironlake_edp_backlight_off(intel_dp);
1084 intel_dp_link_down(intel_dp);
1085 ironlake_edp_panel_off(encoder);
1088 static void intel_dp_commit(struct drm_encoder *encoder)
1090 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
1092 ironlake_edp_panel_vdd_on(intel_dp);
1093 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
1094 intel_dp_start_link_train(intel_dp);
1095 ironlake_edp_panel_on(intel_dp);
1096 ironlake_edp_panel_vdd_off(intel_dp);
1097 intel_dp_complete_link_train(intel_dp);
1098 ironlake_edp_backlight_on(intel_dp);
1100 intel_dp->dpms_mode = DRM_MODE_DPMS_ON;
1104 intel_dp_dpms(struct drm_encoder *encoder, int mode)
1106 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
1107 struct drm_device *dev = encoder->dev;
1108 struct drm_i915_private *dev_priv = dev->dev_private;
1109 uint32_t dp_reg = I915_READ(intel_dp->output_reg);
1111 if (mode != DRM_MODE_DPMS_ON) {
1112 ironlake_edp_panel_vdd_on(intel_dp);
1113 if (is_edp(intel_dp))
1114 ironlake_edp_backlight_off(intel_dp);
1115 intel_dp_sink_dpms(intel_dp, mode);
1116 intel_dp_link_down(intel_dp);
1117 ironlake_edp_panel_off(encoder);
1118 if (is_edp(intel_dp) && !is_pch_edp(intel_dp))
1119 ironlake_edp_pll_off(encoder);
1120 ironlake_edp_panel_vdd_off(intel_dp);
1122 ironlake_edp_panel_vdd_on(intel_dp);
1123 intel_dp_sink_dpms(intel_dp, mode);
1124 if (!(dp_reg & DP_PORT_EN)) {
1125 intel_dp_start_link_train(intel_dp);
1126 ironlake_edp_panel_on(intel_dp);
1127 ironlake_edp_panel_vdd_off(intel_dp);
1128 intel_dp_complete_link_train(intel_dp);
1129 ironlake_edp_backlight_on(intel_dp);
1131 ironlake_edp_panel_vdd_off(intel_dp);
1133 intel_dp->dpms_mode = mode;
1137 * Native read with retry for link status and receiver capability reads for
1138 * cases where the sink may still be asleep.
1141 intel_dp_aux_native_read_retry(struct intel_dp *intel_dp, uint16_t address,
1142 uint8_t *recv, int recv_bytes)
1147 * Sinks are *supposed* to come up within 1ms from an off state,
1148 * but we're also supposed to retry 3 times per the spec.
1150 for (i = 0; i < 3; i++) {
1151 ret = intel_dp_aux_native_read(intel_dp, address, recv,
1153 if (ret == recv_bytes)
1162 * Fetch AUX CH registers 0x202 - 0x207 which contain
1163 * link status information
1166 intel_dp_get_link_status(struct intel_dp *intel_dp)
1168 return intel_dp_aux_native_read_retry(intel_dp,
1170 intel_dp->link_status,
1171 DP_LINK_STATUS_SIZE);
1175 intel_dp_link_status(uint8_t link_status[DP_LINK_STATUS_SIZE],
1178 return link_status[r - DP_LANE0_1_STATUS];
1182 intel_get_adjust_request_voltage(uint8_t link_status[DP_LINK_STATUS_SIZE],
1185 int i = DP_ADJUST_REQUEST_LANE0_1 + (lane >> 1);
1186 int s = ((lane & 1) ?
1187 DP_ADJUST_VOLTAGE_SWING_LANE1_SHIFT :
1188 DP_ADJUST_VOLTAGE_SWING_LANE0_SHIFT);
1189 uint8_t l = intel_dp_link_status(link_status, i);
1191 return ((l >> s) & 3) << DP_TRAIN_VOLTAGE_SWING_SHIFT;
1195 intel_get_adjust_request_pre_emphasis(uint8_t link_status[DP_LINK_STATUS_SIZE],
1198 int i = DP_ADJUST_REQUEST_LANE0_1 + (lane >> 1);
1199 int s = ((lane & 1) ?
1200 DP_ADJUST_PRE_EMPHASIS_LANE1_SHIFT :
1201 DP_ADJUST_PRE_EMPHASIS_LANE0_SHIFT);
1202 uint8_t l = intel_dp_link_status(link_status, i);
1204 return ((l >> s) & 3) << DP_TRAIN_PRE_EMPHASIS_SHIFT;
1209 static char *voltage_names[] = {
1210 "0.4V", "0.6V", "0.8V", "1.2V"
1212 static char *pre_emph_names[] = {
1213 "0dB", "3.5dB", "6dB", "9.5dB"
1215 static char *link_train_names[] = {
1216 "pattern 1", "pattern 2", "idle", "off"
1221 * These are source-specific values; current Intel hardware supports
1222 * a maximum voltage of 800mV and a maximum pre-emphasis of 6dB
1224 #define I830_DP_VOLTAGE_MAX DP_TRAIN_VOLTAGE_SWING_800
1227 intel_dp_pre_emphasis_max(uint8_t voltage_swing)
1229 switch (voltage_swing & DP_TRAIN_VOLTAGE_SWING_MASK) {
1230 case DP_TRAIN_VOLTAGE_SWING_400:
1231 return DP_TRAIN_PRE_EMPHASIS_6;
1232 case DP_TRAIN_VOLTAGE_SWING_600:
1233 return DP_TRAIN_PRE_EMPHASIS_6;
1234 case DP_TRAIN_VOLTAGE_SWING_800:
1235 return DP_TRAIN_PRE_EMPHASIS_3_5;
1236 case DP_TRAIN_VOLTAGE_SWING_1200:
1238 return DP_TRAIN_PRE_EMPHASIS_0;
1243 intel_get_adjust_train(struct intel_dp *intel_dp)
1249 for (lane = 0; lane < intel_dp->lane_count; lane++) {
1250 uint8_t this_v = intel_get_adjust_request_voltage(intel_dp->link_status, lane);
1251 uint8_t this_p = intel_get_adjust_request_pre_emphasis(intel_dp->link_status, lane);
1259 if (v >= I830_DP_VOLTAGE_MAX)
1260 v = I830_DP_VOLTAGE_MAX | DP_TRAIN_MAX_SWING_REACHED;
1262 if (p >= intel_dp_pre_emphasis_max(v))
1263 p = intel_dp_pre_emphasis_max(v) | DP_TRAIN_MAX_PRE_EMPHASIS_REACHED;
1265 for (lane = 0; lane < 4; lane++)
1266 intel_dp->train_set[lane] = v | p;
1270 intel_dp_signal_levels(uint8_t train_set, int lane_count)
1272 uint32_t signal_levels = 0;
1274 switch (train_set & DP_TRAIN_VOLTAGE_SWING_MASK) {
1275 case DP_TRAIN_VOLTAGE_SWING_400:
1277 signal_levels |= DP_VOLTAGE_0_4;
1279 case DP_TRAIN_VOLTAGE_SWING_600:
1280 signal_levels |= DP_VOLTAGE_0_6;
1282 case DP_TRAIN_VOLTAGE_SWING_800:
1283 signal_levels |= DP_VOLTAGE_0_8;
1285 case DP_TRAIN_VOLTAGE_SWING_1200:
1286 signal_levels |= DP_VOLTAGE_1_2;
1289 switch (train_set & DP_TRAIN_PRE_EMPHASIS_MASK) {
1290 case DP_TRAIN_PRE_EMPHASIS_0:
1292 signal_levels |= DP_PRE_EMPHASIS_0;
1294 case DP_TRAIN_PRE_EMPHASIS_3_5:
1295 signal_levels |= DP_PRE_EMPHASIS_3_5;
1297 case DP_TRAIN_PRE_EMPHASIS_6:
1298 signal_levels |= DP_PRE_EMPHASIS_6;
1300 case DP_TRAIN_PRE_EMPHASIS_9_5:
1301 signal_levels |= DP_PRE_EMPHASIS_9_5;
1304 return signal_levels;
1307 /* Gen6's DP voltage swing and pre-emphasis control */
1309 intel_gen6_edp_signal_levels(uint8_t train_set)
1311 int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK |
1312 DP_TRAIN_PRE_EMPHASIS_MASK);
1313 switch (signal_levels) {
1314 case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PRE_EMPHASIS_0:
1315 case DP_TRAIN_VOLTAGE_SWING_600 | DP_TRAIN_PRE_EMPHASIS_0:
1316 return EDP_LINK_TRAIN_400_600MV_0DB_SNB_B;
1317 case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PRE_EMPHASIS_3_5:
1318 return EDP_LINK_TRAIN_400MV_3_5DB_SNB_B;
1319 case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PRE_EMPHASIS_6:
1320 case DP_TRAIN_VOLTAGE_SWING_600 | DP_TRAIN_PRE_EMPHASIS_6:
1321 return EDP_LINK_TRAIN_400_600MV_6DB_SNB_B;
1322 case DP_TRAIN_VOLTAGE_SWING_600 | DP_TRAIN_PRE_EMPHASIS_3_5:
1323 case DP_TRAIN_VOLTAGE_SWING_800 | DP_TRAIN_PRE_EMPHASIS_3_5:
1324 return EDP_LINK_TRAIN_600_800MV_3_5DB_SNB_B;
1325 case DP_TRAIN_VOLTAGE_SWING_800 | DP_TRAIN_PRE_EMPHASIS_0:
1326 case DP_TRAIN_VOLTAGE_SWING_1200 | DP_TRAIN_PRE_EMPHASIS_0:
1327 return EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B;
1329 DRM_DEBUG_KMS("Unsupported voltage swing/pre-emphasis level:"
1330 "0x%x\n", signal_levels);
1331 return EDP_LINK_TRAIN_400_600MV_0DB_SNB_B;
1336 intel_get_lane_status(uint8_t link_status[DP_LINK_STATUS_SIZE],
1339 int i = DP_LANE0_1_STATUS + (lane >> 1);
1340 int s = (lane & 1) * 4;
1341 uint8_t l = intel_dp_link_status(link_status, i);
1343 return (l >> s) & 0xf;
1346 /* Check for clock recovery is done on all channels */
1348 intel_clock_recovery_ok(uint8_t link_status[DP_LINK_STATUS_SIZE], int lane_count)
1351 uint8_t lane_status;
1353 for (lane = 0; lane < lane_count; lane++) {
1354 lane_status = intel_get_lane_status(link_status, lane);
1355 if ((lane_status & DP_LANE_CR_DONE) == 0)
1361 /* Check to see if channel eq is done on all channels */
1362 #define CHANNEL_EQ_BITS (DP_LANE_CR_DONE|\
1363 DP_LANE_CHANNEL_EQ_DONE|\
1364 DP_LANE_SYMBOL_LOCKED)
1366 intel_channel_eq_ok(struct intel_dp *intel_dp)
1369 uint8_t lane_status;
1372 lane_align = intel_dp_link_status(intel_dp->link_status,
1373 DP_LANE_ALIGN_STATUS_UPDATED);
1374 if ((lane_align & DP_INTERLANE_ALIGN_DONE) == 0)
1376 for (lane = 0; lane < intel_dp->lane_count; lane++) {
1377 lane_status = intel_get_lane_status(intel_dp->link_status, lane);
1378 if ((lane_status & CHANNEL_EQ_BITS) != CHANNEL_EQ_BITS)
1385 intel_dp_set_link_train(struct intel_dp *intel_dp,
1386 uint32_t dp_reg_value,
1387 uint8_t dp_train_pat)
1389 struct drm_device *dev = intel_dp->base.base.dev;
1390 struct drm_i915_private *dev_priv = dev->dev_private;
1393 I915_WRITE(intel_dp->output_reg, dp_reg_value);
1394 POSTING_READ(intel_dp->output_reg);
1396 intel_dp_aux_native_write_1(intel_dp,
1397 DP_TRAINING_PATTERN_SET,
1400 ret = intel_dp_aux_native_write(intel_dp,
1401 DP_TRAINING_LANE0_SET,
1402 intel_dp->train_set, 4);
1409 /* Enable corresponding port and start training pattern 1 */
1411 intel_dp_start_link_train(struct intel_dp *intel_dp)
1413 struct drm_device *dev = intel_dp->base.base.dev;
1414 struct drm_i915_private *dev_priv = dev->dev_private;
1415 struct intel_crtc *intel_crtc = to_intel_crtc(intel_dp->base.base.crtc);
1418 bool clock_recovery = false;
1421 uint32_t DP = intel_dp->DP;
1424 * On CPT we have to enable the port in training pattern 1, which
1425 * will happen below in intel_dp_set_link_train. Otherwise, enable
1426 * the port and wait for it to become active.
1428 if (!HAS_PCH_CPT(dev)) {
1429 I915_WRITE(intel_dp->output_reg, intel_dp->DP);
1430 POSTING_READ(intel_dp->output_reg);
1431 intel_wait_for_vblank(dev, intel_crtc->pipe);
1434 /* Write the link configuration data */
1435 intel_dp_aux_native_write(intel_dp, DP_LINK_BW_SET,
1436 intel_dp->link_configuration,
1437 DP_LINK_CONFIGURATION_SIZE);
1440 if (HAS_PCH_CPT(dev) && !is_edp(intel_dp))
1441 DP &= ~DP_LINK_TRAIN_MASK_CPT;
1443 DP &= ~DP_LINK_TRAIN_MASK;
1444 memset(intel_dp->train_set, 0, 4);
1447 clock_recovery = false;
1449 /* Use intel_dp->train_set[0] to set the voltage and pre emphasis values */
1450 uint32_t signal_levels;
1451 if (IS_GEN6(dev) && is_edp(intel_dp)) {
1452 signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]);
1453 DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels;
1455 signal_levels = intel_dp_signal_levels(intel_dp->train_set[0], intel_dp->lane_count);
1456 DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels;
1459 if (HAS_PCH_CPT(dev) && !is_edp(intel_dp))
1460 reg = DP | DP_LINK_TRAIN_PAT_1_CPT;
1462 reg = DP | DP_LINK_TRAIN_PAT_1;
1464 if (!intel_dp_set_link_train(intel_dp, reg,
1465 DP_TRAINING_PATTERN_1 |
1466 DP_LINK_SCRAMBLING_DISABLE))
1468 /* Set training pattern 1 */
1471 if (!intel_dp_get_link_status(intel_dp))
1474 if (intel_clock_recovery_ok(intel_dp->link_status, intel_dp->lane_count)) {
1475 clock_recovery = true;
1479 /* Check to see if we've tried the max voltage */
1480 for (i = 0; i < intel_dp->lane_count; i++)
1481 if ((intel_dp->train_set[i] & DP_TRAIN_MAX_SWING_REACHED) == 0)
1483 if (i == intel_dp->lane_count)
1486 /* Check to see if we've tried the same voltage 5 times */
1487 if ((intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK) == voltage) {
1493 voltage = intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK;
1495 /* Compute new intel_dp->train_set as requested by target */
1496 intel_get_adjust_train(intel_dp);
1503 intel_dp_complete_link_train(struct intel_dp *intel_dp)
1505 struct drm_device *dev = intel_dp->base.base.dev;
1506 struct drm_i915_private *dev_priv = dev->dev_private;
1507 bool channel_eq = false;
1508 int tries, cr_tries;
1510 uint32_t DP = intel_dp->DP;
1512 /* channel equalization */
1517 /* Use intel_dp->train_set[0] to set the voltage and pre emphasis values */
1518 uint32_t signal_levels;
1521 DRM_ERROR("failed to train DP, aborting\n");
1522 intel_dp_link_down(intel_dp);
1526 if (IS_GEN6(dev) && is_edp(intel_dp)) {
1527 signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]);
1528 DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels;
1530 signal_levels = intel_dp_signal_levels(intel_dp->train_set[0], intel_dp->lane_count);
1531 DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels;
1534 if (HAS_PCH_CPT(dev) && !is_edp(intel_dp))
1535 reg = DP | DP_LINK_TRAIN_PAT_2_CPT;
1537 reg = DP | DP_LINK_TRAIN_PAT_2;
1539 /* channel eq pattern */
1540 if (!intel_dp_set_link_train(intel_dp, reg,
1541 DP_TRAINING_PATTERN_2 |
1542 DP_LINK_SCRAMBLING_DISABLE))
1546 if (!intel_dp_get_link_status(intel_dp))
1549 /* Make sure clock is still ok */
1550 if (!intel_clock_recovery_ok(intel_dp->link_status, intel_dp->lane_count)) {
1551 intel_dp_start_link_train(intel_dp);
1556 if (intel_channel_eq_ok(intel_dp)) {
1561 /* Try 5 times, then try clock recovery if that fails */
1563 intel_dp_link_down(intel_dp);
1564 intel_dp_start_link_train(intel_dp);
1570 /* Compute new intel_dp->train_set as requested by target */
1571 intel_get_adjust_train(intel_dp);
1575 if (HAS_PCH_CPT(dev) && !is_edp(intel_dp))
1576 reg = DP | DP_LINK_TRAIN_OFF_CPT;
1578 reg = DP | DP_LINK_TRAIN_OFF;
1580 I915_WRITE(intel_dp->output_reg, reg);
1581 POSTING_READ(intel_dp->output_reg);
1582 intel_dp_aux_native_write_1(intel_dp,
1583 DP_TRAINING_PATTERN_SET, DP_TRAINING_PATTERN_DISABLE);
1587 intel_dp_link_down(struct intel_dp *intel_dp)
1589 struct drm_device *dev = intel_dp->base.base.dev;
1590 struct drm_i915_private *dev_priv = dev->dev_private;
1591 uint32_t DP = intel_dp->DP;
1593 if ((I915_READ(intel_dp->output_reg) & DP_PORT_EN) == 0)
1596 DRM_DEBUG_KMS("\n");
1598 if (is_edp(intel_dp)) {
1599 DP &= ~DP_PLL_ENABLE;
1600 I915_WRITE(intel_dp->output_reg, DP);
1601 POSTING_READ(intel_dp->output_reg);
1605 if (HAS_PCH_CPT(dev) && !is_edp(intel_dp)) {
1606 DP &= ~DP_LINK_TRAIN_MASK_CPT;
1607 I915_WRITE(intel_dp->output_reg, DP | DP_LINK_TRAIN_PAT_IDLE_CPT);
1609 DP &= ~DP_LINK_TRAIN_MASK;
1610 I915_WRITE(intel_dp->output_reg, DP | DP_LINK_TRAIN_PAT_IDLE);
1612 POSTING_READ(intel_dp->output_reg);
1616 if (is_edp(intel_dp))
1617 DP |= DP_LINK_TRAIN_OFF;
1619 if (!HAS_PCH_CPT(dev) &&
1620 I915_READ(intel_dp->output_reg) & DP_PIPEB_SELECT) {
1621 struct drm_crtc *crtc = intel_dp->base.base.crtc;
1623 /* Hardware workaround: leaving our transcoder select
1624 * set to transcoder B while it's off will prevent the
1625 * corresponding HDMI output on transcoder A.
1627 * Combine this with another hardware workaround:
1628 * transcoder select bit can only be cleared while the
1631 DP &= ~DP_PIPEB_SELECT;
1632 I915_WRITE(intel_dp->output_reg, DP);
1634 /* Changes to enable or select take place the vblank
1635 * after being written.
1638 /* We can arrive here never having been attached
1639 * to a CRTC, for instance, due to inheriting
1640 * random state from the BIOS.
1642 * If the pipe is not running, play safe and
1643 * wait for the clocks to stabilise before
1646 POSTING_READ(intel_dp->output_reg);
1649 intel_wait_for_vblank(dev, to_intel_crtc(crtc)->pipe);
1652 I915_WRITE(intel_dp->output_reg, DP & ~DP_PORT_EN);
1653 POSTING_READ(intel_dp->output_reg);
1654 msleep(intel_dp->panel_power_down_delay);
1658 intel_dp_get_dpcd(struct intel_dp *intel_dp)
1660 if (intel_dp_aux_native_read_retry(intel_dp, 0x000, intel_dp->dpcd,
1661 sizeof (intel_dp->dpcd)) &&
1662 (intel_dp->dpcd[DP_DPCD_REV] != 0)) {
1670 * According to DP spec
1673 * 2. Configure link according to Receiver Capabilities
1674 * 3. Use Link Training from 2.5.3.3 and 3.5.1.3
1675 * 4. Check link status on receipt of hot-plug interrupt
1679 intel_dp_check_link_status(struct intel_dp *intel_dp)
1681 if (intel_dp->dpms_mode != DRM_MODE_DPMS_ON)
1684 if (!intel_dp->base.base.crtc)
1687 /* Try to read receiver status if the link appears to be up */
1688 if (!intel_dp_get_link_status(intel_dp)) {
1689 intel_dp_link_down(intel_dp);
1693 /* Now read the DPCD to see if it's actually running */
1694 if (!intel_dp_get_dpcd(intel_dp)) {
1695 intel_dp_link_down(intel_dp);
1699 if (!intel_channel_eq_ok(intel_dp)) {
1700 DRM_DEBUG_KMS("%s: channel EQ not ok, retraining\n",
1701 drm_get_encoder_name(&intel_dp->base.base));
1702 intel_dp_start_link_train(intel_dp);
1703 intel_dp_complete_link_train(intel_dp);
1707 static enum drm_connector_status
1708 intel_dp_detect_dpcd(struct intel_dp *intel_dp)
1710 if (intel_dp_get_dpcd(intel_dp))
1711 return connector_status_connected;
1712 return connector_status_disconnected;
1715 static enum drm_connector_status
1716 ironlake_dp_detect(struct intel_dp *intel_dp)
1718 enum drm_connector_status status;
1720 /* Can't disconnect eDP, but you can close the lid... */
1721 if (is_edp(intel_dp)) {
1722 status = intel_panel_detect(intel_dp->base.base.dev);
1723 if (status == connector_status_unknown)
1724 status = connector_status_connected;
1728 return intel_dp_detect_dpcd(intel_dp);
1731 static enum drm_connector_status
1732 g4x_dp_detect(struct intel_dp *intel_dp)
1734 struct drm_device *dev = intel_dp->base.base.dev;
1735 struct drm_i915_private *dev_priv = dev->dev_private;
1738 switch (intel_dp->output_reg) {
1740 bit = DPB_HOTPLUG_INT_STATUS;
1743 bit = DPC_HOTPLUG_INT_STATUS;
1746 bit = DPD_HOTPLUG_INT_STATUS;
1749 return connector_status_unknown;
1752 temp = I915_READ(PORT_HOTPLUG_STAT);
1754 if ((temp & bit) == 0)
1755 return connector_status_disconnected;
1757 return intel_dp_detect_dpcd(intel_dp);
1760 static struct edid *
1761 intel_dp_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
1763 struct intel_dp *intel_dp = intel_attached_dp(connector);
1766 ironlake_edp_panel_vdd_on(intel_dp);
1767 edid = drm_get_edid(connector, adapter);
1768 ironlake_edp_panel_vdd_off(intel_dp);
1773 intel_dp_get_edid_modes(struct drm_connector *connector, struct i2c_adapter *adapter)
1775 struct intel_dp *intel_dp = intel_attached_dp(connector);
1778 ironlake_edp_panel_vdd_on(intel_dp);
1779 ret = intel_ddc_get_modes(connector, adapter);
1780 ironlake_edp_panel_vdd_off(intel_dp);
1786 * Uses CRT_HOTPLUG_EN and CRT_HOTPLUG_STAT to detect DP connection.
1788 * \return true if DP port is connected.
1789 * \return false if DP port is disconnected.
1791 static enum drm_connector_status
1792 intel_dp_detect(struct drm_connector *connector, bool force)
1794 struct intel_dp *intel_dp = intel_attached_dp(connector);
1795 struct drm_device *dev = intel_dp->base.base.dev;
1796 enum drm_connector_status status;
1797 struct edid *edid = NULL;
1799 intel_dp->has_audio = false;
1801 if (HAS_PCH_SPLIT(dev))
1802 status = ironlake_dp_detect(intel_dp);
1804 status = g4x_dp_detect(intel_dp);
1806 DRM_DEBUG_KMS("DPCD: %02hx%02hx%02hx%02hx%02hx%02hx%02hx%02hx\n",
1807 intel_dp->dpcd[0], intel_dp->dpcd[1], intel_dp->dpcd[2],
1808 intel_dp->dpcd[3], intel_dp->dpcd[4], intel_dp->dpcd[5],
1809 intel_dp->dpcd[6], intel_dp->dpcd[7]);
1811 if (status != connector_status_connected)
1814 if (intel_dp->force_audio) {
1815 intel_dp->has_audio = intel_dp->force_audio > 0;
1817 edid = intel_dp_get_edid(connector, &intel_dp->adapter);
1819 intel_dp->has_audio = drm_detect_monitor_audio(edid);
1820 connector->display_info.raw_edid = NULL;
1825 return connector_status_connected;
1828 static int intel_dp_get_modes(struct drm_connector *connector)
1830 struct intel_dp *intel_dp = intel_attached_dp(connector);
1831 struct drm_device *dev = intel_dp->base.base.dev;
1832 struct drm_i915_private *dev_priv = dev->dev_private;
1835 /* We should parse the EDID data and find out if it has an audio sink
1838 ret = intel_dp_get_edid_modes(connector, &intel_dp->adapter);
1840 if (is_edp(intel_dp) && !intel_dp->panel_fixed_mode) {
1841 struct drm_display_mode *newmode;
1842 list_for_each_entry(newmode, &connector->probed_modes,
1844 if ((newmode->type & DRM_MODE_TYPE_PREFERRED)) {
1845 intel_dp->panel_fixed_mode =
1846 drm_mode_duplicate(dev, newmode);
1854 /* if eDP has no EDID, try to use fixed panel mode from VBT */
1855 if (is_edp(intel_dp)) {
1856 /* initialize panel mode from VBT if available for eDP */
1857 if (intel_dp->panel_fixed_mode == NULL && dev_priv->lfp_lvds_vbt_mode != NULL) {
1858 intel_dp->panel_fixed_mode =
1859 drm_mode_duplicate(dev, dev_priv->lfp_lvds_vbt_mode);
1860 if (intel_dp->panel_fixed_mode) {
1861 intel_dp->panel_fixed_mode->type |=
1862 DRM_MODE_TYPE_PREFERRED;
1865 if (intel_dp->panel_fixed_mode) {
1866 struct drm_display_mode *mode;
1867 mode = drm_mode_duplicate(dev, intel_dp->panel_fixed_mode);
1868 drm_mode_probed_add(connector, mode);
1876 intel_dp_detect_audio(struct drm_connector *connector)
1878 struct intel_dp *intel_dp = intel_attached_dp(connector);
1880 bool has_audio = false;
1882 edid = intel_dp_get_edid(connector, &intel_dp->adapter);
1884 has_audio = drm_detect_monitor_audio(edid);
1886 connector->display_info.raw_edid = NULL;
1894 intel_dp_set_property(struct drm_connector *connector,
1895 struct drm_property *property,
1898 struct drm_i915_private *dev_priv = connector->dev->dev_private;
1899 struct intel_dp *intel_dp = intel_attached_dp(connector);
1902 ret = drm_connector_property_set_value(connector, property, val);
1906 if (property == dev_priv->force_audio_property) {
1910 if (i == intel_dp->force_audio)
1913 intel_dp->force_audio = i;
1916 has_audio = intel_dp_detect_audio(connector);
1920 if (has_audio == intel_dp->has_audio)
1923 intel_dp->has_audio = has_audio;
1927 if (property == dev_priv->broadcast_rgb_property) {
1928 if (val == !!intel_dp->color_range)
1931 intel_dp->color_range = val ? DP_COLOR_RANGE_16_235 : 0;
1938 if (intel_dp->base.base.crtc) {
1939 struct drm_crtc *crtc = intel_dp->base.base.crtc;
1940 drm_crtc_helper_set_mode(crtc, &crtc->mode,
1949 intel_dp_destroy (struct drm_connector *connector)
1951 struct drm_device *dev = connector->dev;
1953 if (intel_dpd_is_edp(dev))
1954 intel_panel_destroy_backlight(dev);
1956 drm_sysfs_connector_remove(connector);
1957 drm_connector_cleanup(connector);
1961 static void intel_dp_encoder_destroy(struct drm_encoder *encoder)
1963 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
1965 i2c_del_adapter(&intel_dp->adapter);
1966 drm_encoder_cleanup(encoder);
1970 static const struct drm_encoder_helper_funcs intel_dp_helper_funcs = {
1971 .dpms = intel_dp_dpms,
1972 .mode_fixup = intel_dp_mode_fixup,
1973 .prepare = intel_dp_prepare,
1974 .mode_set = intel_dp_mode_set,
1975 .commit = intel_dp_commit,
1978 static const struct drm_connector_funcs intel_dp_connector_funcs = {
1979 .dpms = drm_helper_connector_dpms,
1980 .detect = intel_dp_detect,
1981 .fill_modes = drm_helper_probe_single_connector_modes,
1982 .set_property = intel_dp_set_property,
1983 .destroy = intel_dp_destroy,
1986 static const struct drm_connector_helper_funcs intel_dp_connector_helper_funcs = {
1987 .get_modes = intel_dp_get_modes,
1988 .mode_valid = intel_dp_mode_valid,
1989 .best_encoder = intel_best_encoder,
1992 static const struct drm_encoder_funcs intel_dp_enc_funcs = {
1993 .destroy = intel_dp_encoder_destroy,
1997 intel_dp_hot_plug(struct intel_encoder *intel_encoder)
1999 struct intel_dp *intel_dp = container_of(intel_encoder, struct intel_dp, base);
2001 intel_dp_check_link_status(intel_dp);
2004 /* Return which DP Port should be selected for Transcoder DP control */
2006 intel_trans_dp_port_sel (struct drm_crtc *crtc)
2008 struct drm_device *dev = crtc->dev;
2009 struct drm_mode_config *mode_config = &dev->mode_config;
2010 struct drm_encoder *encoder;
2012 list_for_each_entry(encoder, &mode_config->encoder_list, head) {
2013 struct intel_dp *intel_dp;
2015 if (encoder->crtc != crtc)
2018 intel_dp = enc_to_intel_dp(encoder);
2019 if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT)
2020 return intel_dp->output_reg;
2026 /* check the VBT to see whether the eDP is on DP-D port */
2027 bool intel_dpd_is_edp(struct drm_device *dev)
2029 struct drm_i915_private *dev_priv = dev->dev_private;
2030 struct child_device_config *p_child;
2033 if (!dev_priv->child_dev_num)
2036 for (i = 0; i < dev_priv->child_dev_num; i++) {
2037 p_child = dev_priv->child_dev + i;
2039 if (p_child->dvo_port == PORT_IDPD &&
2040 p_child->device_type == DEVICE_TYPE_eDP)
2047 intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connector)
2049 intel_attach_force_audio_property(connector);
2050 intel_attach_broadcast_rgb_property(connector);
2054 intel_dp_init(struct drm_device *dev, int output_reg)
2056 struct drm_i915_private *dev_priv = dev->dev_private;
2057 struct drm_connector *connector;
2058 struct intel_dp *intel_dp;
2059 struct intel_encoder *intel_encoder;
2060 struct intel_connector *intel_connector;
2061 const char *name = NULL;
2064 intel_dp = kzalloc(sizeof(struct intel_dp), GFP_KERNEL);
2068 intel_dp->output_reg = output_reg;
2069 intel_dp->dpms_mode = -1;
2071 intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
2072 if (!intel_connector) {
2076 intel_encoder = &intel_dp->base;
2078 if (HAS_PCH_SPLIT(dev) && output_reg == PCH_DP_D)
2079 if (intel_dpd_is_edp(dev))
2080 intel_dp->is_pch_edp = true;
2082 if (output_reg == DP_A || is_pch_edp(intel_dp)) {
2083 type = DRM_MODE_CONNECTOR_eDP;
2084 intel_encoder->type = INTEL_OUTPUT_EDP;
2086 type = DRM_MODE_CONNECTOR_DisplayPort;
2087 intel_encoder->type = INTEL_OUTPUT_DISPLAYPORT;
2090 connector = &intel_connector->base;
2091 drm_connector_init(dev, connector, &intel_dp_connector_funcs, type);
2092 drm_connector_helper_add(connector, &intel_dp_connector_helper_funcs);
2094 connector->polled = DRM_CONNECTOR_POLL_HPD;
2096 if (output_reg == DP_B || output_reg == PCH_DP_B)
2097 intel_encoder->clone_mask = (1 << INTEL_DP_B_CLONE_BIT);
2098 else if (output_reg == DP_C || output_reg == PCH_DP_C)
2099 intel_encoder->clone_mask = (1 << INTEL_DP_C_CLONE_BIT);
2100 else if (output_reg == DP_D || output_reg == PCH_DP_D)
2101 intel_encoder->clone_mask = (1 << INTEL_DP_D_CLONE_BIT);
2103 if (is_edp(intel_dp))
2104 intel_encoder->clone_mask = (1 << INTEL_EDP_CLONE_BIT);
2106 intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
2107 connector->interlace_allowed = true;
2108 connector->doublescan_allowed = 0;
2110 drm_encoder_init(dev, &intel_encoder->base, &intel_dp_enc_funcs,
2111 DRM_MODE_ENCODER_TMDS);
2112 drm_encoder_helper_add(&intel_encoder->base, &intel_dp_helper_funcs);
2114 intel_connector_attach_encoder(intel_connector, intel_encoder);
2115 drm_sysfs_connector_add(connector);
2117 /* Set up the DDC bus. */
2118 switch (output_reg) {
2124 dev_priv->hotplug_supported_mask |=
2125 HDMIB_HOTPLUG_INT_STATUS;
2130 dev_priv->hotplug_supported_mask |=
2131 HDMIC_HOTPLUG_INT_STATUS;
2136 dev_priv->hotplug_supported_mask |=
2137 HDMID_HOTPLUG_INT_STATUS;
2142 /* Cache some DPCD data in the eDP case */
2143 if (is_edp(intel_dp)) {
2145 struct edp_power_seq cur, vbt;
2146 u32 pp_on, pp_off, pp_div;
2148 pp_on = I915_READ(PCH_PP_ON_DELAYS);
2149 pp_off = I915_READ(PCH_PP_OFF_DELAYS);
2150 pp_div = I915_READ(PCH_PP_DIVISOR);
2152 /* Pull timing values out of registers */
2153 cur.t1_t3 = (pp_on & PANEL_POWER_UP_DELAY_MASK) >>
2154 PANEL_POWER_UP_DELAY_SHIFT;
2156 cur.t8 = (pp_on & PANEL_LIGHT_ON_DELAY_MASK) >>
2157 PANEL_LIGHT_ON_DELAY_SHIFT;
2159 cur.t9 = (pp_off & PANEL_LIGHT_OFF_DELAY_MASK) >>
2160 PANEL_LIGHT_OFF_DELAY_SHIFT;
2162 cur.t10 = (pp_off & PANEL_POWER_DOWN_DELAY_MASK) >>
2163 PANEL_POWER_DOWN_DELAY_SHIFT;
2165 cur.t11_t12 = ((pp_div & PANEL_POWER_CYCLE_DELAY_MASK) >>
2166 PANEL_POWER_CYCLE_DELAY_SHIFT) * 1000;
2168 DRM_DEBUG_KMS("cur t1_t3 %d t8 %d t9 %d t10 %d t11_t12 %d\n",
2169 cur.t1_t3, cur.t8, cur.t9, cur.t10, cur.t11_t12);
2171 vbt = dev_priv->edp.pps;
2173 DRM_DEBUG_KMS("vbt t1_t3 %d t8 %d t9 %d t10 %d t11_t12 %d\n",
2174 vbt.t1_t3, vbt.t8, vbt.t9, vbt.t10, vbt.t11_t12);
2176 #define get_delay(field) ((max(cur.field, vbt.field) + 9) / 10)
2178 intel_dp->panel_power_up_delay = get_delay(t1_t3);
2179 intel_dp->backlight_on_delay = get_delay(t8);
2180 intel_dp->backlight_off_delay = get_delay(t9);
2181 intel_dp->panel_power_down_delay = get_delay(t10);
2182 intel_dp->panel_power_cycle_delay = get_delay(t11_t12);
2184 DRM_DEBUG_KMS("panel power up delay %d, power down delay %d, power cycle delay %d\n",
2185 intel_dp->panel_power_up_delay, intel_dp->panel_power_down_delay,
2186 intel_dp->panel_power_cycle_delay);
2188 DRM_DEBUG_KMS("backlight on delay %d, off delay %d\n",
2189 intel_dp->backlight_on_delay, intel_dp->backlight_off_delay);
2191 ironlake_edp_panel_vdd_on(intel_dp);
2192 ret = intel_dp_get_dpcd(intel_dp);
2193 ironlake_edp_panel_vdd_off(intel_dp);
2195 if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11)
2196 dev_priv->no_aux_handshake =
2197 intel_dp->dpcd[DP_MAX_DOWNSPREAD] &
2198 DP_NO_AUX_HANDSHAKE_LINK_TRAINING;
2200 /* if this fails, presume the device is a ghost */
2201 DRM_INFO("failed to retrieve link info, disabling eDP\n");
2202 intel_dp_encoder_destroy(&intel_dp->base.base);
2203 intel_dp_destroy(&intel_connector->base);
2208 intel_dp_i2c_init(intel_dp, intel_connector, name);
2210 intel_encoder->hot_plug = intel_dp_hot_plug;
2212 if (is_edp(intel_dp)) {
2213 dev_priv->int_edp_connector = connector;
2214 intel_panel_setup_backlight(dev);
2217 intel_dp_add_properties(intel_dp, connector);
2219 /* For G4X desktop chip, PEG_BAND_GAP_DATA 3:0 must first be written
2220 * 0xd. Failure to do so will result in spurious interrupts being
2221 * generated on the port when a cable is not attached.
2223 if (IS_G4X(dev) && !IS_GM45(dev)) {
2224 u32 temp = I915_READ(PEG_BAND_GAP_DATA);
2225 I915_WRITE(PEG_BAND_GAP_DATA, (temp & ~0xf) | 0xd);