git.openpandora.org
/
pandora-libraries.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Bloody off-by-1 error for a malloc, leading to ever-so-slight memory corruption....
[pandora-libraries.git]
/
lib
/
pnd_desktop.c
diff --git
a/lib/pnd_desktop.c
b/lib/pnd_desktop.c
index
3abf62d
..
349056d
100644
(file)
--- a/
lib/pnd_desktop.c
+++ b/
lib/pnd_desktop.c
@@
-298,7
+298,8
@@
unsigned char pnd_emit_dotinfo ( char *targetpath, char *pndrun, pnd_disco_t *p
// exec line
char args [ 1001 ];
char *pargs = args;
// exec line
char args [ 1001 ];
char *pargs = args;
- if ( pnd_conf_get_as_char ( desktoph, "info.viewer_args" ) ) {
+ char *viewerargs = pnd_conf_get_as_char ( desktoph, "info.viewer_args" );
+ if ( viewerargs && viewerargs [ 0 ] ) {
snprintf ( pargs, 1001, "%s %s",
pnd_conf_get_as_char ( desktoph, "info.viewer_args" ), p -> info_filename );
} else {
snprintf ( pargs, 1001, "%s %s",
pnd_conf_get_as_char ( desktoph, "info.viewer_args" ), p -> info_filename );
} else {