PM / Runtime: Remove idle notification after failing suspend
authorRafael J. Wysocki <rjw@sisk.pl>
Sun, 10 Oct 2010 23:02:27 +0000 (01:02 +0200)
committerRafael J. Wysocki <rjw@sisk.pl>
Sat, 16 Oct 2010 23:57:49 +0000 (01:57 +0200)
commitf71648d73c1650b8b4aceb3856bebbde6daa3b86
treede47bd189c730d82781a43cc638452aef37facfe
parent3624eb04c24861ab296842414f9752a393e68372
PM / Runtime: Remove idle notification after failing suspend

If runtime suspend of a device fails returning -EAGAIN or -EBUSY,
which means that it's safe to try to suspend it again, the PM core
runs the runtime idle helper function for it.  Unfortunately this may
lead to problems, for example for PCI devices whose drivers don't
implement the ->runtime_idle() callback, because in that case the
PCI bus type's ->runtime_idle() always calls pm_runtime_suspend()
for the given device.  Then, if there's an automatic idle
notification after the driver's ->runtime_suspend() returning -EAGAIN
or -EBUSY, it will make the suspend happen again possibly causing a
busy loop to appear.  To avoid that, remove the idle notification
after failing runtime suspend of a device altogether and let the
callers of pm_runtime_suspend() repeat the operation if need be.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
drivers/base/power/runtime.c