ext4: use atomic64_t for the per-flexbg free_clusters count
authorTheodore Ts'o <tytso@mit.edu>
Tue, 12 Mar 2013 03:39:59 +0000 (23:39 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 12 Mar 2013 03:39:59 +0000 (23:39 -0400)
commit90ba983f6889e65a3b506b30dc606aa9d1d46cd2
tree964ad0ccf415e73a7760b5bfe65506f5d825e1cf
parentad56edad089b56300fd13bb9eeb7d0424d978239
ext4: use atomic64_t for the per-flexbg free_clusters count

A user who was using a 8TB+ file system and with a very large flexbg
size (> 65536) could cause the atomic_t used in the struct flex_groups
to overflow.  This was detected by PaX security patchset:

http://forums.grsecurity.net/viewtopic.php?f=3&t=3289&p=12551#p12551

This bug was introduced in commit 9f24e4208f7e, so it's been around
since 2.6.30.  :-(

Fix this by using an atomic64_t for struct orlav_stats's
free_clusters.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Cc: stable@vger.kernel.org
fs/ext4/ext4.h
fs/ext4/ialloc.c
fs/ext4/mballoc.c
fs/ext4/resize.c
fs/ext4/super.c