md/raid5: For odirect-write performance, do not set STRIPE_PREREAD_ACTIVE.
authormajianpeng <majianpeng@gmail.com>
Tue, 31 Jul 2012 00:05:44 +0000 (10:05 +1000)
committerNeilBrown <neilb@suse.de>
Tue, 31 Jul 2012 00:05:44 +0000 (10:05 +1000)
commit895e3c5c58a80bb9e4e05d9ac38b4f30e0f97d80
tree0376aaaaf8166e07a052067e5f825ab5b914d758
parentb7219ccb33aa0df9949a60c68b5e9f712615e56f
md/raid5: For odirect-write performance, do not set STRIPE_PREREAD_ACTIVE.

'sync' writes set both REQ_SYNC and REQ_NOIDLE.
O_DIRECT writes set REQ_SYNC but not REQ_NOIDLE.

We currently assume that a REQ_SYNC request will not be followed by
more requests and so set STRIPE_PREREAD_ACTIVE to expedite the
request.
This is appropriate for sync requests, but not for O_DIRECT requests.

So make the setting of STRIPE_PREREAD_ACTIVE conditional on REQ_NOIDLE
rather than REQ_SYNC.  This is consistent with the documented meaning
of REQ_NOIDLE:

        __REQ_NOIDLE,           /* don't anticipate more IO after this one */

Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c