Nest rename_lock inside vfsmount_lock
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Mar 2013 22:25:57 +0000 (18:25 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Mar 2013 22:25:57 +0000 (18:25 -0400)
commit7ea600b5314529f9d1b9d6d3c41cb26fce6a7a4a
tree8cc99c507999dcb7c35e973e22d79ae9a3ac8165
parent06ae43f34bcc07a0b6be8bf78a1c895bcd12c839
Nest rename_lock inside vfsmount_lock

... lest we get livelocks between path_is_under() and d_path() and friends.

The thing is, wrt fairness lglocks are more similar to rwsems than to rwlocks;
it is possible to have thread B spin on attempt to take lock shared while thread
A is already holding it shared, if B is on lower-numbered CPU than A and there's
a thread C spinning on attempt to take the same lock exclusive.

As the result, we need consistent ordering between vfsmount_lock (lglock) and
rename_lock (seq_lock), even though everything that takes both is going to take
vfsmount_lock only shared.

Spotted-by: Brad Spengler <spender@grsecurity.net>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/dcache.c