futex: Forbid uaddr == uaddr2 in futex_wait_requeue_pi()
authorDarren Hart <dvhart@linux.intel.com>
Fri, 20 Jul 2012 18:53:31 +0000 (11:53 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 24 Jul 2012 14:02:57 +0000 (16:02 +0200)
commit6f7b0a2a5c0fb03be7c25bd1745baa50582348ef
tree23bf0f7ccfeea44ef9aa8057d53ade47b69a8a44
parentf27071cb7fe3e1d37a9dbe6c0dfc5395cd40fa43
futex: Forbid uaddr == uaddr2 in futex_wait_requeue_pi()

If uaddr == uaddr2, then we have broken the rule of only requeueing
from a non-pi futex to a pi futex with this call. If we attempt this,
as the trinity test suite manages to do, we miss early wakeups as
q.key is equal to key2 (because they are the same uaddr). We will then
attempt to dereference the pi_mutex (which would exist had the futex_q
been properly requeued to a pi futex) and trigger a NULL pointer
dereference.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: Dave Jones <davej@redhat.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/ad82bfe7f7d130247fbe2b5b4275654807774227.1342809673.git.dvhart@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/futex.c