x86, mm: Hold mm->page_table_lock while doing vmalloc_sync
authorJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Tue, 21 Sep 2010 19:01:51 +0000 (12:01 -0700)
committerH. Peter Anvin <hpa@linux.intel.com>
Tue, 19 Oct 2010 20:57:08 +0000 (13:57 -0700)
commit617d34d9e5d8326ec8f188c616aa06ac59d083fe
tree763d02b7713bad65ba819a8334bb0e95d4370352
parent44235dcde416104b8e1db7606c283f4c0149c760
x86, mm: Hold mm->page_table_lock while doing vmalloc_sync

Take mm->page_table_lock while syncing the vmalloc region.  This prevents
a race with the Xen pagetable pin/unpin code, which expects that the
page_table_lock is already held.  If this race occurs, then Xen can see
an inconsistent page type (a page can either be read/write or a pagetable
page, and pin/unpin converts it between them), which will cause either
the pin or the set_p[gm]d to fail; either will crash the kernel.

vmalloc_sync_all() should be called rarely, so this extra use of
page_table_lock should not interfere with its normal users.

The mm pointer is stashed in the pgd page's index field, as that won't
be otherwise used for pgds.

Reported-by: Ian Campbell <ian.cambell@eu.citrix.com>
Originally-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <4CB88A4C.1080305@goop.org>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
arch/x86/include/asm/pgtable.h
arch/x86/mm/fault.c
arch/x86/mm/init_64.c
arch/x86/mm/pgtable.c