pandora-kernel.git
13 years ago[media] saa7134: Fix strange kconfig dependency on RC_CORE
Steven Rostedt [Thu, 10 Mar 2011 22:41:29 +0000 (19:41 -0300)]
[media] saa7134: Fix strange kconfig dependency on RC_CORE

As the code in saa7134-input is not a module, but the config for it is
set as a boolean instead of a tristate, this causes a strange dependency
on RC_CORE.

VIDEO_SAA7134_RC (which determines if saa7134-input.o is built) depends
on RC_CORE and VIDEO_SAA7134. If VIDEO_SAA7134 is compiled as 'y' but
RC_CORE is compiled as 'm' VIDEO_SAA7134_RC can still be set to 'y'
which causes undefined symbols that it needs from RC_CORE.

The simplest solution is to not allow VIDEO_SAA7134_RC be enabled if
RC_CORE compiled as a module (m) and VIDEO_SA7134 is compiled into the
kernel (y).

Suggested-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] STV0288 added full frontend status
Malcolm Priestley [Sun, 6 Mar 2011 16:37:00 +0000 (13:37 -0300)]
[media] STV0288 added full frontend status

status now returns
 FE_HAS_CARRIER
 FE_HAS_SIGNAL
 FE_HAS_VITERBI

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - zc3xx: Add exposure control for sensor hv7131r
Jean-François Moine [Tue, 22 Mar 2011 09:47:56 +0000 (06:47 -0300)]
[media] gspca - zc3xx: Add exposure control for sensor hv7131r

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - main: Add endpoint direction test in alt_xfer
Patrice Chotard [Mon, 21 Mar 2011 19:58:56 +0000 (16:58 -0300)]
[media] gspca - main: Add endpoint direction test in alt_xfer

This patch fixes a bug in gspca, more precisely in alt_xfer().

This function looks for an input transfer endpoint in an alternate setting.
By default it returns the first endpoint corresponding to the transfer type
indicated in parameter.
But with some USB devices, the first endpoint corresponding to the transfer
type is not always an INPUT endpoint but an OUTPUT one.

This patch adds the endpoint direction test to be sure to return an INPUT endpoint

Signed-off-by: Patrice CHOTARD <patricechotard@free.fr>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: Fix exposure for some webcams
Jean-François Moine [Tue, 22 Mar 2011 09:09:49 +0000 (06:09 -0300)]
[media] gspca - nw80x: Fix exposure for some webcams

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: Get the sensor ID when bridge et31x110
Jean-François Moine [Tue, 22 Mar 2011 09:07:40 +0000 (06:07 -0300)]
[media] gspca - nw80x: Get the sensor ID when bridge et31x110

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: Fix some image resolutions
Jean-François Moine [Tue, 22 Mar 2011 09:04:09 +0000 (06:04 -0300)]
[media] gspca - nw80x: Fix some image resolutions

No 352x288 for Ds3303 and no 320x240 for Generic802.

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: Check the bridge from the webcam type
Jean-François Moine [Tue, 22 Mar 2011 08:58:19 +0000 (05:58 -0300)]
[media] gspca - nw80x: Check the bridge from the webcam type

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: Fix the gain, exposure and autogain
Jean-François Moine [Tue, 22 Mar 2011 08:53:21 +0000 (05:53 -0300)]
[media] gspca - nw80x: Fix the gain, exposure and autogain

The autogain now uses common functions.

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: Do some initialization at probe time
Jean-François Moine [Tue, 22 Mar 2011 08:46:24 +0000 (05:46 -0300)]
[media] gspca - nw80x: Do some initialization at probe time

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: The webcam dsb-c110 is the same as the twinkle
Jean-François Moine [Tue, 22 Mar 2011 08:37:18 +0000 (05:37 -0300)]
[media] gspca - nw80x: The webcam dsb-c110 is the same as the twinkle

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: Cleanup source
Jean-François Moine [Tue, 22 Mar 2011 08:16:11 +0000 (05:16 -0300)]
[media] gspca - nw80x: Cleanup source

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2: use new flag to enable core priority handling
Hans Verkuil [Tue, 22 Mar 2011 13:14:07 +0000 (10:14 -0300)]
[media] v4l2: use new flag to enable core priority handling

Rather than guess which driver supports core priority handling, require drivers
that do to explicitly set the V4L2_FL_USE_FH_PRIO flag in video_device.

Updated the core prio handling accordingly and set the flag in the three
drivers that do.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] ivtv: replace ugly casts with a proper container_of
Hans Verkuil [Sat, 12 Mar 2011 09:43:28 +0000 (06:43 -0300)]
[media] ivtv: replace ugly casts with a proper container_of

ivtv-ioctl cast the 'void *fh' directly to 'ivtv_open_id *'. This should be
done properly with a contained_of since the 'void *fh' is really a
'struct v4l2_fh *'.

It worked because the v4l2_fh field is also the first field in the ivtv_open_id
struct, but it is not clean code.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] ivtv: add missing v4l2_fh_exit
Hans Verkuil [Sat, 12 Mar 2011 09:39:44 +0000 (06:39 -0300)]
[media] ivtv: add missing v4l2_fh_exit

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] vivi: convert to core priority handling
Hans Verkuil [Fri, 11 Mar 2011 23:01:54 +0000 (20:01 -0300)]
[media] vivi: convert to core priority handling

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] dsbr100: ensure correct disconnect sequence
Hans Verkuil [Mon, 17 Jan 2011 23:25:11 +0000 (20:25 -0300)]
[media] dsbr100: ensure correct disconnect sequence

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] dsbr100: convert to unlocked_ioctl
Hans Verkuil [Sun, 19 Dec 2010 21:54:08 +0000 (18:54 -0300)]
[media] dsbr100: convert to unlocked_ioctl

Use core-assisted locking so .ioctl can be replaced by .unlocked_ioctl.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2-framework.txt: document new v4l2_device release() callback
Hans Verkuil [Thu, 24 Feb 2011 09:28:46 +0000 (06:28 -0300)]
[media] v4l2-framework.txt: document new v4l2_device release() callback

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2-device: add kref and a release function
Hans Verkuil [Sat, 12 Mar 2011 09:37:19 +0000 (06:37 -0300)]
[media] v4l2-device: add kref and a release function

The video_device struct has proper ref counting and its release function
will be called when the last user releases it. But no such support was
available for struct v4l2_device. This made it hard to determine when a
USB driver can release the device if it has multiple device nodes.

With one device node it is easy of course, since when the device node is
released, the whole device can be released.

This patch adds refcounting to v4l2_device. When registering device nodes
the v4l2_device refcount will be increased, when releasing device nodes
it will be decreased. The (optional) release function will be called when
the last device node was released.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] cx18: use core priority handling
Hans Verkuil [Sat, 12 Mar 2011 09:36:08 +0000 (06:36 -0300)]
[media] cx18: use core priority handling

VIDIOC_S/G_PRIORITY handling is now done by the v4l2 core framework.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] cx18: use v4l2_fh as preparation for adding core priority support
Hans Verkuil [Sat, 12 Mar 2011 09:35:33 +0000 (06:35 -0300)]
[media] cx18: use v4l2_fh as preparation for adding core priority support

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2-framework.txt: improve v4l2_fh/priority documentation
Hans Verkuil [Thu, 24 Feb 2011 13:58:13 +0000 (10:58 -0300)]
[media] v4l2-framework.txt: improve v4l2_fh/priority documentation

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] ivtv: convert to core priority handling
Hans Verkuil [Fri, 11 Mar 2011 22:03:41 +0000 (19:03 -0300)]
[media] ivtv: convert to core priority handling

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2-ioctl: add priority handling support
Hans Verkuil [Fri, 11 Mar 2011 22:00:56 +0000 (19:00 -0300)]
[media] v4l2-ioctl: add priority handling support

Drivers that use v4l2_fh can now use the core framework support of g/s_priority.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2-fh: add v4l2_fh_is_singular
Hans Verkuil [Sat, 8 Jan 2011 12:38:02 +0000 (09:38 -0300)]
[media] v4l2-fh: add v4l2_fh_is_singular

Several drivers need to do something when the first filehandle is opened
or the last filehandle is closed. Most implement some use count mechanism,
but if they use v4l2_fh, then you can also just check if this is the only
filehandle for the device node. A simple helper function can do this.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2-fh: add v4l2_fh_open and v4l2_fh_release helper functions
Hans Verkuil [Sat, 8 Jan 2011 12:36:04 +0000 (09:36 -0300)]
[media] v4l2-fh: add v4l2_fh_open and v4l2_fh_release helper functions

Add two new functions: v4l2_fh_open allocates and initializes a struct v4l2_fh
based on a struct file pointer and v4l2_fh_release releases and frees a struct
v4l2_fh.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2-fh: implement v4l2_priority support
Hans Verkuil [Wed, 29 Dec 2010 16:36:50 +0000 (13:36 -0300)]
[media] v4l2-fh: implement v4l2_priority support

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2: add v4l2_prio_state to v4l2_device and video_device
Hans Verkuil [Thu, 24 Feb 2011 13:42:24 +0000 (10:42 -0300)]
[media] v4l2: add v4l2_prio_state to v4l2_device and video_device

Integrate the v4l2_prio_state into the core, ready for use.

One struct v4l2_prio_state is added to v4l2_device and a pointer
to a prio state is added to video_device.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2_prio: move from v4l2-common to v4l2-dev
Hans Verkuil [Wed, 29 Dec 2010 13:05:02 +0000 (10:05 -0300)]
[media] v4l2_prio: move from v4l2-common to v4l2-dev

We are going to move priority handling into the v4l2 core. As a consequence
the v4l2_prio helper functions need to be moved into the core videodev
module as well to prevent circular dependencies.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] saa7134-input: key up events not sent after suspend/resume
Vadim Solomin [Sun, 6 Mar 2011 16:00:38 +0000 (13:00 -0300)]
[media] saa7134-input: key up events not sent after suspend/resume

On my AverMedia AverTV Studio 507, key up events are no longer sent after
a suspend-to-disk/resume cycle, resulting in "stuck" keys.

Apparently, for key up events to be generated, a certain GPIO pin must be set.
Currently it's set in saa7134_input_init1(), but that function is not called
on device resume. I suggest that code be moved to __saa7134_ir_start(), which
is called both on init and resume.

Signed-off-by: Vadim Solomin <vadic052@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] stv0367: typo in function parameter
Dan Carpenter [Sun, 6 Mar 2011 13:41:23 +0000 (10:41 -0300)]
[media] stv0367: typo in function parameter

The CellsCoeffs arrays are [3][6][5] not [2][6][5].

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Igor M. Liplianin <liplianin@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] stv0367: signedness bug in stv0367_get_tuner_freq()
Dan Carpenter [Sun, 6 Mar 2011 13:40:11 +0000 (10:40 -0300)]
[media] stv0367: signedness bug in stv0367_get_tuner_freq()

We use err to store negative error codes so it should be signed.  And
if we return an error from stv0367_get_tuner_freq() that needs to be
handled properly as well.  (param->frequency is a u32).

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] via-camera: Fix OLPC serial check
Daniel Drake [Thu, 3 Mar 2011 19:03:31 +0000 (16:03 -0300)]
[media] via-camera: Fix OLPC serial check

The code that checks the OLPC serial port is never built at the moment,
because CONFIG_OLPC_XO_1_5 doesn't exist and probably won't be added.

Fix it so that it gets compiled in, only executes on OLPC laptops, and
move the check into the probe routine.

The compiler is smart enough to eliminate this code when CONFIG_OLPC=n
(due to machine_is_olpc() always returning false).

Signed-off-by: Daniel Drake <dsd@laptop.org>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] Change to 32 bit and add other remote controls for lme2510
Malcolm Priestley [Sun, 23 Jan 2011 21:26:03 +0000 (18:26 -0300)]
[media] Change to 32 bit and add other remote controls for lme2510

These bubble button remote controls appear to be generic from China.

These are the three variants known to be supplied with DM04/QQBOX DVB-S

They could well be supplied with other devices from the region.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] DM04/QQBOX Update V1.76 - use 32 bit remote decoding
Malcolm Priestley [Sun, 23 Jan 2011 21:22:45 +0000 (18:22 -0300)]
[media] DM04/QQBOX Update V1.76 - use 32 bit remote decoding

Use 32 bit decoding to add support for more than one variant of remote
control.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] DM04 LME2510(C) Sharp BS2F7HZ0194 Firmware Information
Malcolm Priestley [Sun, 13 Feb 2011 01:38:47 +0000 (22:38 -0300)]
[media] DM04 LME2510(C) Sharp BS2F7HZ0194 Firmware Information

DM04 LME2510(C) Sharp BS2F7HZ0194 Firmware Information

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v180 - DM04/QQBOX added support for BS2F7HZ0194 versions
Malcolm Priestley [Sun, 13 Feb 2011 01:35:08 +0000 (22:35 -0300)]
[media] v180 - DM04/QQBOX added support for BS2F7HZ0194 versions

Old versions of these boxes have the BS2F7HZ0194 tuner module on
both the LME2510 and LME2510C.

Firmware dvb-usb-lme2510-s0194.fw  and/or dvb-usb-lme2510c-s0194.fw
files are required.

See Documentation/dvb/lmedm04.txt

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] drivers/media/video/tlg2300/pd-video.c: Remove second mutex_unlock in pd_vidi...
Alexander Strakh [Tue, 25 Jan 2011 21:00:13 +0000 (18:00 -0300)]
[media] drivers/media/video/tlg2300/pd-video.c: Remove second mutex_unlock in pd_vidioc_s_fmt

Error path in file drivers/media/video/tlg2300/pd-video.c:
1. First mutex_unlock on &pd->lock in line 767 (in function that
   called from line 805)
2. Second in line  806

 805        pd_vidioc_s_fmt(pd, &f->fmt.pix);
 806        mutex_unlock(&pd->lock);

Found by Linux Device Drivers Verification Project

Signed-off-by: Alexander Strakh <strakh@ispras.ru>
Acked-by: Huang Shijie <shijie8@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] radio-wl1273: remove unused wl1273_device->work
Tejun Heo [Mon, 24 Jan 2011 14:23:15 +0000 (11:23 -0300)]
[media] radio-wl1273: remove unused wl1273_device->work

wl1273_device->work is unused.  Remove it along with the spurious
flush_scheduled_work() call in wl1273_fm_module_exit().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Matti Aaltonen <matti.j.aaltonen@nokia.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] Zarlink zl10036 DVB-S: Fix mem leak in zl10036_attach
Jesper Juhl [Thu, 17 Feb 2011 20:33:56 +0000 (17:33 -0300)]
[media] Zarlink zl10036 DVB-S: Fix mem leak in zl10036_attach

On Thu, 17 Feb 2011, Matthias Schwarzott wrote:

> On Sunday 06 February 2011, Jesper Juhl wrote:
> > If the memory allocation to 'state' succeeds but we jump to the 'error'
> > label before 'state' is assigned to fe->tuner_priv, then the call to
> > 'zl10036_release(fe)' at the 'error:' label will not free 'state', but
> > only what was previously assigned to 'tuner_priv', thus leaking the memory
> > allocated to 'state'.
> > There are may ways to fix this, including assigning the allocated memory
> > directly to 'fe->tuner_priv', but I did not go for that since the
> > additional pointer derefs are more expensive than the local variable, so I
> > just added a 'kfree(state)' call. I guess the call to 'zl10036_release'
> > might not even be needed in this case, but I wasn't sure, so I left it in.
> >
> Yeah, that call to zl10036_release can be completely eleminated.
> Another thing is: jumping to the error label only makes sense when memory was
> already allocated. So the jump in line 471 can be replaced by "return NULL",
> as the other error handling before allocation:
>         if (NULL == config) {
>                 printk(KERN_ERR "%s: no config specified", __func__);
>                 goto error;
>         }
>
> I suggest to improve the patch to clean the code up when changing that.
>
> But I am fine with commiting this patch also if you do not want to change it.
>

Thank you for your feedback. It makes a lot of sense.
Changing it is not a problem :)
How about the updated patch below?

If the memory allocation to 'state' succeeds but we jump to the 'error'
label before 'state' is assigned to fe->tuner_priv, then the call to
'zl10036_release(fe)' at the 'error:' label will not free 'state', but
only what was previously assigned to 'tuner_priv', thus leaking the memory
allocated to 'state'.
This patch fixes the leak and also does not jump to 'error:' before mem
has been allocated but instead just returns. Also some small style
cleanups.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] V4L: videobuf, don't use dma addr as physical
Jiri Slaby [Mon, 28 Feb 2011 09:37:02 +0000 (06:37 -0300)]
[media] V4L: videobuf, don't use dma addr as physical

mem->dma_handle is a dma address obtained by dma_alloc_coherent which
needn't be a physical address in presence of IOMMU, as
a hardware IOMMU can (and most likely) will return a bus address where
physical != bus address.

So ensure we are remapping (remap_pfn_range) the right page in
__videobuf_mmap_mapper by using virt_to_phys(mem->vaddr) and not
mem->dma_handle.

While at it, use PFN_DOWN instead of explicit shift.

[mchehab@redhat.com: Fix compilation breakage due to the lack of a comma]
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] uvcvideo: Fix descriptor parsing for video output devices
Laurent Pinchart [Wed, 23 Feb 2011 14:19:17 +0000 (11:19 -0300)]
[media] uvcvideo: Fix descriptor parsing for video output devices

Commit 4057ac6ca9a77c4275b34b5925ab5c99557913b1

    V4L/DVB (13505): uvcvideo: Refactor chain scan

broke output terminals parsing. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: stable@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] uvcvideo: Fix uvc_fixup_video_ctrl() format search
Stephan Lachowsky [Fri, 28 Jan 2011 02:04:33 +0000 (23:04 -0300)]
[media] uvcvideo: Fix uvc_fixup_video_ctrl() format search

The scheme used to index format in uvc_fixup_video_ctrl() is not robust:
format index is based on descriptor ordering, which does not necessarily
match bFormatIndex ordering.  Searching for first matching format will
prevent uvc_fixup_video_ctrl() from using the wrong format/frame to make
adjustments.

Signed-off-by: Stephan Lachowsky <stephan.lachowsky@maxim-ic.com>
Cc: stable@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] vb2: Handle return value from start_streaming callback
Pawel Osciak [Sun, 20 Mar 2011 22:26:41 +0000 (19:26 -0300)]
[media] vb2: Handle return value from start_streaming callback

Fix vb2 not handling return value from start_streaming() callback.

Signed-off-by: Pawel Osciak <pawel@osciak.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] vb2: vb2_poll() fix return values for file I/O mode
Pawel Osciak [Sun, 20 Mar 2011 21:17:34 +0000 (18:17 -0300)]
[media] vb2: vb2_poll() fix return values for file I/O mode

poll() should be returning poll-specific error values, not E* errors.

Signed-off-by: Pawel Osciak <pawel@osciak.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] Update Pawel Osciak's e-mail address
Pawel Osciak [Sun, 13 Mar 2011 18:23:32 +0000 (15:23 -0300)]
[media] Update Pawel Osciak's e-mail address

Signed-off-by: Pawel Osciak <pawel@osciak.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] Make 2.6.39 not 2.6.38 the version when Multi-planar API was added
Pawel Osciak [Sun, 13 Mar 2011 18:20:22 +0000 (15:20 -0300)]
[media] Make 2.6.39 not 2.6.38 the version when Multi-planar API was added

Multi-planar API was added to 2.6.39 version of Video for Linux 2 API.

Signed-off-by: Pawel Osciak <pawel@osciak.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] af9013: reimplement firmware download
Antti Palosaari [Sat, 19 Mar 2011 21:02:22 +0000 (18:02 -0300)]
[media] af9013: reimplement firmware download

Split FW download packages smarter way and bug free. Implementation is
based of Andrea Merello's example he provided for tda18218 driver.
Count remaining FW bytes down in loop instead of division and modulo
combination used earlier.

Thanks to: Andrea Merello <andrea.merello@gmail.com>

Signed-off-by: Antti Palosaari <crope@iki.fi>
Cc: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] af9013: download FW earlier in attach()
Antti Palosaari [Sat, 19 Mar 2011 20:18:18 +0000 (17:18 -0300)]
[media] af9013: download FW earlier in attach()

Quick test shows that FW must be running before other checks
so make it happen earlier.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] af9015: reimplement firmware download
Antti Palosaari [Sat, 19 Mar 2011 19:51:43 +0000 (16:51 -0300)]
[media] af9015: reimplement firmware download

Split FW download packages smarter way and bug free. Implementation is
based of Andrea Merello's example he provided for tda18218 driver.
Count remaining FW bytes down in loop instead of division and modulo
combination used earlier.

Thanks-to: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Cc: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] af9015: map remote for TerraTec Cinergy T Stick RC
Antti Palosaari [Sat, 19 Mar 2011 17:25:36 +0000 (14:25 -0300)]
[media] af9015: map remote for TerraTec Cinergy T Stick RC

Map rc-terratec-slim-2 for TerraTec Cinergy T Stick RC device.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Cc: Martin Groszhauser <mgroszhauser@gmail.com>
Cc: TerraTux <TerraTux@terratec.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] add TerraTec remote
Antti Palosaari [Sat, 19 Mar 2011 17:11:55 +0000 (14:11 -0300)]
[media] add TerraTec remote

Remote used for TerraTec Cinergy T Stick RC.
Keytable from Martin Groszhauser <mgroszhauser@gmail.com>

Signed-off-by: Antti Palosaari <crope@iki.fi>
Cc: Martin Groszhauser <mgroszhauser@gmail.com>
Cc: TerraTux <TerraTux@terratec.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] af9015: small RC change
Antti Palosaari [Fri, 18 Mar 2011 22:36:42 +0000 (19:36 -0300)]
[media] af9015: small RC change

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] af9015: enhance RC
Ian Armstrong [Fri, 18 Mar 2011 22:23:05 +0000 (19:23 -0300)]
[media] af9015: enhance RC

Patch from Ian Armstrong.

I've encountered a couple of problems with the current af9015 driver as
supplied with the 2.6.37 kernel, that the attached patch appears to fix. (I've
generated this patch against the current v4l-dvb git).

Some key-presses are lost. A key-press is only generated upon 'valid' data
(buf[14] == (u8) ~buf[15]), but the buffer is wiped before this check.
Sometimes the 15th byte has not been set at the time of read, so the data
isn't valid & ignored. On the next poll the 15th byte has been set, but the
rest of the data was wiped previously, so the data is still invalid & the key
is lost.

Weird repeat error, where an old key press is sometimes repeated in error. ie.
button sequence '1 (pause) 2 (pause) 3 (pause) 4' generates output like '1
(pause) 2 (pause) 23 (pause) 4'. The current driver zeroes the data for the
key pushed, but sometimes this data is already zero but with other bytes set
suggesting a repeat code. This results in the last key being incorrectly
repeated.

This patch attempts to reduce the risk of a missed key-press & also stop the
random repeat of an old key-press when a new key is pressed.

Signed-off-by: Ian Armstrong <ian@iarmst.demon.co.uk>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - nw80x: New subdriver for Divio based webcams
Jean-François Moine [Mon, 14 Mar 2011 11:49:28 +0000 (08:49 -0300)]
[media] gspca - nw80x: New subdriver for Divio based webcams

[mchehab@redhat.com: Fix a few CodingStyle issues]
Tested-by: Kjell Claesson <kjell.claesson@epost.tidanet.se>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - main: Cleanup source
Jean-François Moine [Mon, 14 Mar 2011 08:33:01 +0000 (05:33 -0300)]
[media] gspca - main: Cleanup source

- change copyright and erroneous comment
- small code optimization
- have constant the device template

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - ov519: Add exposure and autogain controls for ov2610/2610ae
Jean-François Moine [Sun, 13 Mar 2011 19:36:49 +0000 (16:36 -0300)]
[media] gspca - ov519: Add exposure and autogain controls for ov2610/2610ae

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - jeilinj / stv06xx: Fix some warnings
Jean-François Moine [Sun, 13 Mar 2011 19:17:08 +0000 (16:17 -0300)]
[media] gspca - jeilinj / stv06xx: Fix some warnings

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - sonixb: Clenup source
Jean-François Moine [Sun, 13 Mar 2011 19:07:25 +0000 (16:07 -0300)]
[media] gspca - sonixb: Clenup source

- update copyright and module author
- set the sensor table as constant

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - sonixb: Update inactive flags to reflect autogain setting
Hans de Goede [Sun, 13 Mar 2011 19:05:55 +0000 (16:05 -0300)]
[media] gspca - sonixb: Update inactive flags to reflect autogain setting

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - sonixb: Use the new control mechanism
Jean-François Moine [Sun, 13 Mar 2011 18:04:11 +0000 (15:04 -0300)]
[media] gspca - sonixb: Use the new control mechanism

Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca: New file autogain_functions.h
Jean-François Moine [Sun, 13 Mar 2011 17:38:46 +0000 (14:38 -0300)]
[media] gspca: New file autogain_functions.h

This file contains functions for the auto gain.
It must be used with the new control mechanism.

Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - zc3xx: Cleanup source
Jean-François Moine [Sat, 26 Feb 2011 16:56:20 +0000 (13:56 -0300)]
[media] gspca - zc3xx: Cleanup source

- change some comments and copyright
- change an erroneous register name
- change hdcs2020b to hdcs2020

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca - zc3xx: Remove double definition
Jean-François Moine [Sat, 26 Feb 2011 11:04:03 +0000 (08:04 -0300)]
[media] gspca - zc3xx: Remove double definition

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] gspca_cpia1: Add support for button
Hans de Goede [Sun, 13 Mar 2011 15:26:14 +0000 (12:26 -0300)]
[media] gspca_cpia1: Add support for button

Not only the qx3 microscope has a button, but some cameras too. Tested
with the Trust sp@cecam 100 (and with a creative and ezcam without button).

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] pvrusb2: check kmalloc return value
Xiaochen Wang [Mon, 14 Mar 2011 01:32:53 +0000 (22:32 -0300)]
[media] pvrusb2: check kmalloc return value

 allows the driver to proceed and initialize the below two values
 even if the kmalloc() fails.
        hdw->std_info_enum.def.type_enum.value_names
        hdw->std_info_enum.def.type_enum.count

Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] pvrusb2: Remove dead code
Mike Isely [Mon, 14 Mar 2011 01:18:23 +0000 (22:18 -0300)]
[media] pvrusb2: Remove dead code

This was caught via a compiler warning.  Amazingly enough this bit of
benign dreck dates all the way back to 2008.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] pvrusb2: Implement support for Terratec Grabster AV400
Mike Isely [Sun, 13 Mar 2011 23:37:11 +0000 (20:37 -0300)]
[media] pvrusb2: Implement support for Terratec Grabster AV400

Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] Fix 'ID nv12mt already defined' error
Hans Verkuil [Fri, 11 Mar 2011 21:18:54 +0000 (18:18 -0300)]
[media] Fix 'ID nv12mt already defined' error

DocBook validation fix.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] V4L DocBook: update V4L2 version
Hans Verkuil [Fri, 11 Mar 2011 19:25:23 +0000 (16:25 -0300)]
[media] V4L DocBook: update V4L2 version

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] V4L doc fixes
Hans Verkuil [Fri, 11 Mar 2011 19:22:21 +0000 (16:22 -0300)]
[media] V4L doc fixes

The xmlto validation produced a number of errors that are now fixed.
Sadly, the DocBook/Makefile still adds --skip-validation to xmlto, so
these errors are missed during a normal compile.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2: vb2-dma-sg: fix potential security hole
Andrzej Pietrasiewicz [Wed, 2 Mar 2011 12:12:13 +0000 (09:12 -0300)]
[media] v4l2: vb2-dma-sg: fix potential security hole

Memory allocated by alloc_page() function might contain some potentially
important data from other system processes. The patch adds a flag to
zero the allocated page before giving it to videobuf2 (and then to
userspace).

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2: vb2: simplify __vb2_queue_free function
Marek Szyprowski [Thu, 10 Mar 2011 12:10:49 +0000 (09:10 -0300)]
[media] v4l2: vb2: simplify __vb2_queue_free function

__vb2_queue_free function doesn't really return anything useful. This patch
removes support for the return value to simplify the code.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2: vb2: one more fix for REQBUFS()
Marek Szyprowski [Fri, 11 Mar 2011 09:07:27 +0000 (06:07 -0300)]
[media] v4l2: vb2: one more fix for REQBUFS()

Return immediately if the target number of buffers is the same as
the current one and memory access type doesn't change.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2: vb2-dma-sg: fix memory leak
Andrzej Pietrasiewicz [Fri, 28 Jan 2011 12:42:51 +0000 (09:42 -0300)]
[media] v4l2: vb2-dma-sg: fix memory leak

This patch fixes two minor memory leaks in videobuf2-dma-sg module. They
might happen only in case some other operations (like memory allocation)
failed.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l2: vb2: fix queue reallocation and REQBUFS(0) case
Marek Szyprowski [Wed, 9 Mar 2011 17:03:24 +0000 (14:03 -0300)]
[media] v4l2: vb2: fix queue reallocation and REQBUFS(0) case

This patch fixes 2 minor bugs in videobuf2 core:
1. Queue should be reallocated if one change the memory access
method without changing the number of buffers.
2. In case of REQBUFS(0), the request should not be passed to the
driver.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] v4l: Documentation for the NV12MT format
Kamil Debski [Fri, 11 Mar 2011 09:16:22 +0000 (06:16 -0300)]
[media] v4l: Documentation for the NV12MT format

Added documentation for V4L2_PIX_FMT_NV12MT format. This is a YUV 4:2:0
format with macro block size of 64x32 and specific order of macro blocks
in the memory.

Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] s5p-fimc: Fix G_FMT ioctl handler
Sylwester Nawrocki [Sat, 15 Jan 2011 04:17:42 +0000 (01:17 -0300)]
[media] s5p-fimc: Fix G_FMT ioctl handler

Use pix_mp member of struct v4l2_format to return a format
description rather than pix. Also fill in the plane_fmt array.
This is a missing bit of conversion to the multiplanar API.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] s5p-fimc: Use dynamic debug
Sylwester Nawrocki [Wed, 23 Feb 2011 11:17:57 +0000 (08:17 -0300)]
[media] s5p-fimc: Use dynamic debug

Use pr_debug instead of printk so it is possible to control
debug traces at runtime.
E.g. to enable debug trace in file fimc-core.c use command:
echo -n 'file fimc-core.c +p' > /sys/kernel/debug/dynamic_debug/control
or
echo -n 'file fimc-core.c -p' > /sys/kernel/debug/dynamic_debug/control
to disable.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] s5p-fimc: Add a platform data entry for MIPI-CSI data alignment
Sylwester Nawrocki [Mon, 21 Feb 2011 15:09:01 +0000 (12:09 -0300)]
[media] s5p-fimc: Add a platform data entry for MIPI-CSI data alignment

Allow the MIPI-CSI data alignment to be defined in the board setup
as it may be different across various camera sensors.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] s5p-fimc: Allow defining number of sensors at runtime
Sylwester Nawrocki [Mon, 28 Feb 2011 14:12:19 +0000 (11:12 -0300)]
[media] s5p-fimc: Allow defining number of sensors at runtime

Add num_clients field to struct s5p_fimc_isp_info to define exactly
size of clients array which simplifies a bit the sensors management.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] s5p-fimc: Prevent hanging on device close and fix the locking
Sylwester Nawrocki [Wed, 23 Feb 2011 11:24:33 +0000 (08:24 -0300)]
[media] s5p-fimc: Prevent hanging on device close and fix the locking

Rework the locking in m2m driver to assure proper operation on SMP systems.

When job_abort or stop_streaming was called to immediately shutdown
a memory-to-memory transaction video buffers scheduled for processing
were never returned to vb2 and v4l2_m2m_job_finish was not called
which led to hanging.

Correct this and also return the unprocessed buffers to vb2 marking
them as erroneous, in case the end of frame interrupt do not occur.

Reported-by: Sewoon Park <seuni.park@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] s5p-fimc: Prevent oops when i2c adapter is not available
Sylwester Nawrocki [Fri, 11 Feb 2011 15:33:06 +0000 (12:33 -0300)]
[media] s5p-fimc: Prevent oops when i2c adapter is not available

Prevent invalid pointer dereference on error path.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] s5p-fimc: fix ISR and buffer handling for fimc-capture
Sungchun Kang [Mon, 7 Feb 2011 18:59:46 +0000 (15:59 -0300)]
[media] s5p-fimc: fix ISR and buffer handling for fimc-capture

In some cases fimc H/W did not stop although there were no output
buffers available. So the capture deactivation interrupt routine
is modified and the state of ST_CAPT_RUN is cleared only
in the LAST-IRQ call.

After LAST-IRQ is generated, H/W pointer will be skipped by 1 frame.
(reference by user manual) So, S/W pointer should be increased too.

Reviewed-by Jonghun Han <jonghun.han@samsung.com>
Signed-off-by: Sungchun Kang <sungchun.kang@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] Force xc5000 firmware loading for NetUP Dual DVB-T/C CI RF card
Abylay Ospan [Sun, 2 Jan 2011 12:15:00 +0000 (09:15 -0300)]
[media] Force xc5000 firmware loading for NetUP Dual DVB-T/C CI RF card

Two xc5000 tuners connected to same i2c bus.
Experiments shows that situation when one tuner is not initialized
while other is tuned to channel causes TS errors.

Signed-off-by: Abylay Ospan <aospan@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] Fix CI code for NetUP Dual DVB-T/C CI RF card
Abylay Ospan [Sun, 2 Jan 2011 12:14:00 +0000 (09:14 -0300)]
[media] Fix CI code for NetUP Dual DVB-T/C CI RF card

CI reset takes several seconds on some CAM,
so there is no need to lock mutex all that time.
Also we need not to preserve CI's reset bits in
CIBUSCTRL register, they are handled automatically by FPGA.
Set it to 0 explicitly in order to not reset wrong CAM.

Signed-off-by: Abylay Ospan <aospan@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] stv0367: implement uncorrected blocks counter
Abylay Ospan [Sun, 2 Jan 2011 12:12:00 +0000 (09:12 -0300)]
[media] stv0367: implement uncorrected blocks counter

Signed-off-by: Abylay Ospan <aospan@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] stv0367: change default value for AGC register
Abylay Ospan [Sun, 2 Jan 2011 12:11:00 +0000 (09:11 -0300)]
[media] stv0367: change default value for AGC register

Signed-off-by: Abylay Ospan <aospan@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] cx23885: Altera FPGA CI interface reworked
Abylay Ospan [Sun, 2 Jan 2011 12:10:00 +0000 (09:10 -0300)]
[media] cx23885: Altera FPGA CI interface reworked

It decreases I2C traffic.

Signed-off-by: Abylay Ospan <aospan@netup.ru>
Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] cpia2: Fix some gcc 4.6 warnings when debug is disabled
Mauro Carvalho Chehab [Fri, 11 Mar 2011 20:00:01 +0000 (17:00 -0300)]
[media] cpia2: Fix some gcc 4.6 warnings when debug is disabled

cpia2_core.c:529:14: warning: variable 'dir' set but not used [-Wunused-but-set-variable]
cpia2_core.c:526:5: warning: variable 'block_index' set but not used [-Wunused-but-set-variable]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] several drivers: Fix a few gcc 4.6 warnings
Mauro Carvalho Chehab [Fri, 11 Mar 2011 19:51:18 +0000 (16:51 -0300)]
[media] several drivers: Fix a few gcc 4.6 warnings

au0828-dvb.c:99:6: warning: variable 'ptr' set but not used [-Wunused-but-set-variable]
au0828-video.c:1180:25: warning: variable 'maxheight' set but not used [-Wunused-but-set-variable]
au0828-video.c:1180:15: warning: variable 'maxwidth' set but not used [-Wunused-but-set-variable]
bttv-input.c:196:16: warning: variable 'current_jiffies' set but not used [-Wunused-but-set-variable]

Those variables are not used at all, so just remove them.

Cc: Steven Toth <stoth@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] altera-ci.h: add missing inline
Hans Verkuil [Sun, 6 Mar 2011 12:49:37 +0000 (09:49 -0300)]
[media] altera-ci.h: add missing inline

Functions defined in a header should be static inline. This prevents
compile warnings like:

'altera_ci_tuner_reset' defined but not used

(Actually appeared in the media backwards compatibility build).

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] cx88-alsa: fix compiler warning
Hans Verkuil [Sun, 6 Mar 2011 12:31:00 +0000 (09:31 -0300)]
[media] cx88-alsa: fix compiler warning

drivers/media/video/cx88/cx88-alsa.c: In function 'cx88_audio_initdev':
drivers/media/video/cx88/cx88-alsa.c:881:20: warning: 'core' may be used uninitialized in this function

The compiler doesn't understand that snd_cx88_create fills in the core
pointer. So just initialize it to NULL.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] fmdrv_common.c: fix compiler warning
Hans Verkuil [Sun, 6 Mar 2011 12:30:02 +0000 (09:30 -0300)]
[media] fmdrv_common.c: fix compiler warning

drivers/media/radio/wl128x/fmdrv_common.c: In function 'recv_tasklet':
drivers/media/radio/wl128x/fmdrv_common.c:274:4: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

The result of sizeof() should be printed with %zu.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] altera-ci.c: fix compiler warnings
Hans Verkuil [Sun, 6 Mar 2011 12:27:44 +0000 (09:27 -0300)]
[media] altera-ci.c: fix compiler warnings

drivers/media/video/cx23885/altera-ci.c: In function 'altera_hw_filt_init':
drivers/media/video/cx23885/altera-ci.c:671:2: warning: cast from pointer to integer of different size
drivers/media/video/cx23885/altera-ci.c: In function 'altera_ci_init':
drivers/media/video/cx23885/altera-ci.c:739:2: warning: cast from pointer to integer of different size

Use %p instead of 0x%x to print addresses.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] stv0367.c: fix compiler warning
Hans Verkuil [Sun, 6 Mar 2011 12:26:24 +0000 (09:26 -0300)]
[media] stv0367.c: fix compiler warning

drivers/media/dvb/frontends/stv0367.c: In function 'stv0367ter_lock_algo':
drivers/media/dvb/frontends/stv0367.c:1315:2: warning: cast from pointer to integer of different size

Use %p to print addresses instead of 0x%x.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] tuner-xc2028.c: fix compile warning
Hans Verkuil [Sun, 6 Mar 2011 12:24:32 +0000 (09:24 -0300)]
[media] tuner-xc2028.c: fix compile warning

drivers/media/common/tuners/tuner-xc2028.c: In function 'generic_set_freq':
drivers/media/common/tuners/tuner-xc2028.c:936:15: warning: comparison between 'enum tuner_mode' and 'enum v4l2_tuner_type'

Argument type was enum tuner_mode, but should have been enum v4l2_tuner_type.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] omap3isp: Add documentation
Sakari Ailus [Mon, 7 Mar 2011 17:20:52 +0000 (14:20 -0300)]
[media] omap3isp: Add documentation

Add documentation on the OMAP 3 ISP driver. Document the subdevs, V4L2
events and private IOCTLs the driver implements

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: David Cohen <dacohen@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
13 years ago[media] media: Pick a free ioctls range
Laurent Pinchart [Sat, 5 Mar 2011 20:14:33 +0000 (17:14 -0300)]
[media] media: Pick a free ioctls range

Pick an unused range of ioctls in Documentation/ioctl/ioctl-number.txt
and use it for the MEDIA_IOC_* ioctls.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>