fix panic on prefetch(NULL) on PA7300LC
authorJames Bottomley <JBottomley@Parallels.com>
Wed, 16 May 2012 10:10:27 +0000 (11:10 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:43:18 +0000 (00:43 +0100)
commit b3cb8674811d1851bbf1486a73d62b90c119b994 upstream.

Due to an errata, the PA7300LC generates a TLB miss interruption even on the
prefetch instruction.  This means that prefetch(NULL), which is supposed to be
a nop on linux actually generates a NULL deref fault.  Fix this by testing the
address of prefetch against NULL before doing the prefetch.

Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/parisc/include/asm/prefetch.h

index c5edc60..1ee7c82 100644 (file)
 #define ARCH_HAS_PREFETCH
 static inline void prefetch(const void *addr)
 {
-       __asm__("ldw 0(%0), %%r0" : : "r" (addr));
+       __asm__(
+#ifndef CONFIG_PA20
+               /* Need to avoid prefetch of NULL on PA7300LC */
+               "       extrw,u,= %0,31,32,%%r0\n"
+#endif
+               "       ldw 0(%0), %%r0" : : "r" (addr));
 }
 
 /* LDD is a PA2.0 addition. */