sfc: Correct error code for unsupported interrupt coalescing parameters
authorBen Hutchings <bhutchings@solarflare.com>
Mon, 5 Sep 2011 07:41:27 +0000 (07:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Sep 2011 20:50:36 +0000 (16:50 -0400)
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ethtool.c

index bc4643a..6de2715 100644 (file)
@@ -628,12 +628,12 @@ static int efx_ethtool_set_coalesce(struct net_device *net_dev,
        unsigned tx_usecs, rx_usecs, adaptive;
 
        if (coalesce->use_adaptive_tx_coalesce)
-               return -EOPNOTSUPP;
+               return -EINVAL;
 
        if (coalesce->rx_coalesce_usecs || coalesce->tx_coalesce_usecs) {
                netif_err(efx, drv, efx->net_dev, "invalid coalescing setting. "
                          "Only rx/tx_coalesce_usecs_irq are supported\n");
-               return -EOPNOTSUPP;
+               return -EINVAL;
        }
 
        rx_usecs = coalesce->rx_coalesce_usecs_irq;
@@ -647,7 +647,7 @@ static int efx_ethtool_set_coalesce(struct net_device *net_dev,
                    tx_usecs) {
                        netif_err(efx, drv, efx->net_dev, "Channel is shared. "
                                  "Only RX coalescing may be set\n");
-                       return -EOPNOTSUPP;
+                       return -EINVAL;
                }
        }