mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
authorAxel Lin <axel.lin@gmail.com>
Mon, 9 Aug 2010 06:48:16 +0000 (14:48 +0800)
committerLiam Girdwood <lrg@slimlogic.co.uk>
Wed, 11 Aug 2010 10:38:02 +0000 (11:38 +0100)
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/mfd/max8998.c

index 0d68de2..73e6f5c 100644 (file)
@@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
        int ret = 0;
 
        max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
-       if (max8998 == NULL) {
-               kfree(i2c);
+       if (max8998 == NULL)
                return -ENOMEM;
-       }
 
        i2c_set_clientdata(i2c, max8998);
        max8998->dev = &i2c->dev;