[ARM] dns323-setup.c: fix WARN() when booting
authorArnaud Patard <arnaud.patard@rtp-net.org>
Sat, 3 Apr 2010 08:31:33 +0000 (10:31 +0200)
committerNicolas Pitre <nico@fluxnic.net>
Mon, 3 May 2010 20:34:47 +0000 (16:34 -0400)
Since commit b2a731aa5cbca7e0252da75e16de7ae5feb1313a, dns323_init() is
setting the power led gpio direction with gpio_direction_output() but
doesn't request the gpio before (which is not permitted by the gpio
layer afaik). This behaviour is triggering a WARN() at boot time.

Tested-by: Christian Samsel <csamsel@gmxpro.de>
Cc: Martin Michlmayr <tbm@cyrius.com>
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: Nicolas Pitre <nico@marvell.com>
    [ Part 2: "Attached Text" ]

arch/arm/mach-orion5x/dns323-setup.c

index 421b82f..685f34a 100644 (file)
@@ -439,6 +439,7 @@ static void __init dns323_init(void)
         */
        if (dns323_dev_id() == MV88F5181_DEV_ID) {
                dns323_leds[0].active_low = 1;
+               gpio_request(DNS323_GPIO_LED_POWER1, "Power Led Enable");
                gpio_direction_output(DNS323_GPIO_LED_POWER1, 0);
        }