rt2x00: Remove check for rf word 0
authorIvo van Doorn <ivdoorn@gmail.com>
Sun, 15 Feb 2009 16:42:48 +0000 (17:42 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 27 Feb 2009 19:52:35 +0000 (14:52 -0500)
The only way rf_write() can be called with word 0 is
when the user sends the wrong word index through debugfs.
However the values which are send through debugfs are
validated using the RF_BASE and RF_SIZE macro values,
the most logical solution is to increase RF_BASE with 4
and decrease RF_SIZE with 4 (RF_SIZE has always been
1 word too big)

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2400pci.c
drivers/net/wireless/rt2x00/rt2400pci.h
drivers/net/wireless/rt2x00/rt2500pci.c
drivers/net/wireless/rt2x00/rt2500pci.h
drivers/net/wireless/rt2x00/rt2500usb.c
drivers/net/wireless/rt2x00/rt2500usb.h
drivers/net/wireless/rt2x00/rt61pci.c
drivers/net/wireless/rt2x00/rt61pci.h
drivers/net/wireless/rt2x00/rt73usb.c
drivers/net/wireless/rt2x00/rt73usb.h

index b084825..0f08773 100644 (file)
@@ -114,9 +114,6 @@ static void rt2400pci_rf_write(struct rt2x00_dev *rt2x00dev,
 {
        u32 reg;
 
-       if (!word)
-               return;
-
        mutex_lock(&rt2x00dev->csr_mutex);
 
        /*
index 72ac31c..ec3b004 100644 (file)
@@ -48,8 +48,8 @@
 #define EEPROM_SIZE                    0x0100
 #define BBP_BASE                       0x0000
 #define BBP_SIZE                       0x0020
-#define RF_BASE                                0x0000
-#define RF_SIZE                                0x0010
+#define RF_BASE                                0x0004
+#define RF_SIZE                                0x000c
 
 /*
  * Number of TX queues.
index eb82860..276a823 100644 (file)
@@ -114,9 +114,6 @@ static void rt2500pci_rf_write(struct rt2x00_dev *rt2x00dev,
 {
        u32 reg;
 
-       if (!word)
-               return;
-
        mutex_lock(&rt2x00dev->csr_mutex);
 
        /*
index 17a0c9c..ce2f065 100644 (file)
@@ -59,8 +59,8 @@
 #define EEPROM_SIZE                    0x0200
 #define BBP_BASE                       0x0000
 #define BBP_SIZE                       0x0040
-#define RF_BASE                                0x0000
-#define RF_SIZE                                0x0014
+#define RF_BASE                                0x0004
+#define RF_SIZE                                0x0010
 
 /*
  * Number of TX queues.
index 270691a..ca28067 100644 (file)
@@ -204,9 +204,6 @@ static void rt2500usb_rf_write(struct rt2x00_dev *rt2x00dev,
 {
        u16 reg;
 
-       if (!word)
-               return;
-
        mutex_lock(&rt2x00dev->csr_mutex);
 
        /*
index afce0e0..5bc46fe 100644 (file)
@@ -59,8 +59,8 @@
 #define EEPROM_SIZE                    0x006a
 #define BBP_BASE                       0x0000
 #define BBP_SIZE                       0x0060
-#define RF_BASE                                0x0000
-#define RF_SIZE                                0x0014
+#define RF_BASE                                0x0004
+#define RF_SIZE                                0x0010
 
 /*
  * Number of TX queues.
index 0be147f..2ca8b7a 100644 (file)
@@ -123,9 +123,6 @@ static void rt61pci_rf_write(struct rt2x00_dev *rt2x00dev,
 {
        u32 reg;
 
-       if (!word)
-               return;
-
        mutex_lock(&rt2x00dev->csr_mutex);
 
        /*
index 2f97fee..41e8959 100644 (file)
@@ -50,8 +50,8 @@
 #define EEPROM_SIZE                    0x0100
 #define BBP_BASE                       0x0000
 #define BBP_SIZE                       0x0080
-#define RF_BASE                                0x0000
-#define RF_SIZE                                0x0014
+#define RF_BASE                                0x0004
+#define RF_SIZE                                0x0010
 
 /*
  * Number of TX queues.
index 8f52234..846996c 100644 (file)
@@ -122,9 +122,6 @@ static void rt73usb_rf_write(struct rt2x00_dev *rt2x00dev,
 {
        u32 reg;
 
-       if (!word)
-               return;
-
        mutex_lock(&rt2x00dev->csr_mutex);
 
        /*
index 834b28c..c8016f6 100644 (file)
@@ -50,8 +50,8 @@
 #define EEPROM_SIZE                    0x0100
 #define BBP_BASE                       0x0000
 #define BBP_SIZE                       0x0080
-#define RF_BASE                                0x0000
-#define RF_SIZE                                0x0014
+#define RF_BASE                                0x0004
+#define RF_SIZE                                0x0010
 
 /*
  * Number of TX queues.