NFSv4: Rate limit the state manager for lock reclaim warning messages
authorWilliam Dauchy <wdauchy@gmail.com>
Wed, 14 Mar 2012 11:32:04 +0000 (12:32 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 25 Jul 2012 03:11:00 +0000 (04:11 +0100)
commit 96dcadc2fdd111dca90d559f189a30c65394451a upstream.

Adding rate limit on `Lock reclaim failed` messages since it could fill
up system logs
Signed-off-by: William Dauchy <wdauchy@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
[bwh: Backported to 3.2: add the 'NFS:' prefix at the same time]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/nfs/nfs4state.c

index 66020ac..07354b7 100644 (file)
@@ -1186,8 +1186,9 @@ restart:
                                spin_lock(&state->state_lock);
                                list_for_each_entry(lock, &state->lock_states, ls_locks) {
                                        if (!(lock->ls_flags & NFS_LOCK_INITIALIZED))
-                                               printk("%s: Lock reclaim failed!\n",
-                                                       __func__);
+                                               pr_warn_ratelimited("NFS: "
+                                                       "%s: Lock reclaim "
+                                                       "failed!\n", __func__);
                                }
                                spin_unlock(&state->state_lock);
                                nfs4_put_open_state(state);