ide: fix ide_find_port()
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Thu, 17 Apr 2008 22:46:21 +0000 (00:46 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Thu, 17 Apr 2008 22:46:21 +0000 (00:46 +0200)
* Instead of checking for '->io_ports[IDE_DATA_OFFSET] == 0' check for
  '->chipset == ide_unknown' when looking for an empty ide_hwifs[] slot.

* Do ide-pnp initialization after ide-generic when IDE is built-in
  (ide-pnp is the only user of ide_find_port() which needs such fixup).

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/Makefile
drivers/ide/ide.c

index a4a4323..571544c 100644 (file)
@@ -36,9 +36,9 @@ ifeq ($(CONFIG_BLK_DEV_CMD640), y)
 endif
 
 obj-$(CONFIG_BLK_DEV_IDE)              += cris/ ppc/
-obj-$(CONFIG_BLK_DEV_IDEPNP)           += ide-pnp.o
 obj-$(CONFIG_IDE_H8300)                        += h8300/
 obj-$(CONFIG_IDE_GENERIC)              += ide-generic.o
+obj-$(CONFIG_BLK_DEV_IDEPNP)           += ide-pnp.o
 
 ide-cd_mod-y += ide-cd.o ide-cd_ioctl.o ide-cd_verbose.o
 
index 5f54515..67ce697 100644 (file)
@@ -255,7 +255,7 @@ ide_hwif_t * ide_find_port(unsigned long base)
 
        for (i = 0; i < MAX_HWIFS; i++) {
                hwif = &ide_hwifs[i];
-               if (hwif->io_ports[IDE_DATA_OFFSET] == 0)
+               if (hwif->chipset == ide_unknown)
                        goto found;
        }