UBI: do not change file pointer while updating
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Thu, 24 Jan 2008 14:45:57 +0000 (16:45 +0200)
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Fri, 25 Jan 2008 14:41:25 +0000 (16:41 +0200)
Since we do not change semantics of seek(), changing the file
pointer while updating does not make much sense.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
drivers/mtd/ubi/cdev.c
drivers/mtd/ubi/upd.c

index a7aa123..d9bd494 100644 (file)
@@ -368,6 +368,7 @@ static ssize_t vol_cdev_write(struct file *file, const char __user *buf,
                 */
                count = err;
 
+               vol->updating = 0;
                err = ubi_check_volume(ubi, vol->vol_id);
                if (err < 0)
                        return err;
@@ -382,7 +383,6 @@ static ssize_t vol_cdev_write(struct file *file, const char __user *buf,
                revoke_exclusive(desc, UBI_READWRITE);
        }
 
-       *offp += count;
        return count;
 }
 
@@ -430,8 +430,6 @@ static int vol_cdev_ioctl(struct inode *inode, struct file *file,
                err = ubi_start_update(ubi, vol->vol_id, bytes);
                if (bytes == 0)
                        revoke_exclusive(desc, UBI_READWRITE);
-
-               file->f_pos = 0;
                break;
        }
 
index e32b04d..3defa57 100644 (file)
@@ -343,7 +343,6 @@ int ubi_more_update_data(struct ubi_device *ubi, int vol_id,
                if (err == 0) {
                        err = to_write;
                        vfree(vol->upd_buf);
-                       vol->updating = 0;
                }
        }