ipv4: fix redirect handling for TCP packets
authorMichal Kubecek <mkubecek@suse.cz>
Tue, 28 May 2013 06:26:49 +0000 (08:26 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 May 2013 06:39:19 +0000 (23:39 -0700)
commitf96ef988cc603487c03a6de07807b06cbe641829
treeeeca4296492586db73ab13e22da6394203e25b3f
parent9a9c56cb34e65000d1f0a4b7553399bfcf7c5a52
ipv4: fix redirect handling for TCP packets

Unlike ipv4_redirect() and ipv4_sk_redirect(), ip_do_redirect()
doesn't call __build_flow_key() directly but via
ip_rt_build_flow_key() wrapper. This leads to __build_flow_key()
getting pointer to IPv4 header of the ICMP redirect packet
rather than pointer to the embedded IPv4 header of the packet
initiating the redirect.

As a result, handling of ICMP redirects initiated by TCP packets
is broken. Issue was introduced by

4895c771c ("ipv4: Add FIB nexthop exceptions.")

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/route.c